)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alessandro Pilotti \u003cap@pilotti.it\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-09 16:34:38 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for deploying Quantum on Windows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some changes in setup.py are required to properly handle dependencies"},{"line_number":10,"context_line":"and data files on WIndows (including Hyper-V server)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAM3%2F%2Fr74%3D","line":7,"updated":"2013-01-09 16:34:28.000000000","message":"Please file a bug on launchpad and link it to this commit message.","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"}],"bin/quantum-hyperv-agent":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23527c626b674c0069e0858a90a7761213ff2f8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.plugins.hyperv.agent.hyperv_quantum_agent import main"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FxOQ%3D","line":22,"updated":"2013-01-06 18:18:46.000000000","message":"please add a new line here - between 21 and 22","commit_id":"9108cc187b7cee836152f903a5e2c3c4c9776be5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23527c626b674c0069e0858a90a7761213ff2f8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.plugins.hyperv.agent.hyperv_quantum_agent import main"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2Fwfk%3D","line":21,"updated":"2013-01-07 14:07:57.000000000","message":"please add a new line here - please see HACKING.rst","commit_id":"455a3b3125fcad08df1c8981061bf977c94b24b4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum.plugins.hyperv.agent.hyperv_quantum_agent import main"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"AAAAM3%2F%2Flfw%3D","line":23,"updated":"2013-01-14 23:14:56.000000000","message":"seems strange to merge this in before the hyperv plugin code merges, as I assume this will be broken, but I guess there\u0027s not much harm.","commit_id":"ba12d3eb9372e0aee2830c73a0554cf3d6588ba0"}],"setup.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23527c626b674c0069e0858a90a7761213ff2f8a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    depend_links.append(\u0027pywin32\u0027)"},{"line_number":26,"context_line":"    depend_links.append(\u0027wmi\u0027)"},{"line_number":27,"context_line":"else:"},{"line_number":28,"context_line":"    depend_links.append(\u0027pyudev\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Name \u003d \u0027quantum\u0027"},{"line_number":31,"context_line":"Url \u003d \"https://launchpad.net/quantum\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FxOA%3D","line":28,"updated":"2013-01-06 18:18:46.000000000","message":"why this dependency?","commit_id":"9108cc187b7cee836152f903a5e2c3c4c9776be5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23527c626b674c0069e0858a90a7761213ff2f8a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            \u0027quantum.plugins.ryu.agent.ryu_quantum_agent:main\u0027,"},{"line_number":148,"context_line":"            \u0027quantum-nec-agent \u003d \u0027"},{"line_number":149,"context_line":"            \u0027quantum.plugins.nec.agent.nec_quantum_agent:main\u0027,"},{"line_number":150,"context_line":"            \u0027quantum-hyperv-agent \u003d \u0027"},{"line_number":151,"context_line":"            \u0027quantum.plugins.hyperv.agent.hyperv_quantum_agent:main\u0027,"},{"line_number":152,"context_line":"            \u0027quantum-server \u003d quantum.server:main\u0027,"},{"line_number":153,"context_line":"            \u0027quantum-debug \u003d quantum.debug.shell:main\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FxOE%3D","line":150,"updated":"2013-01-06 18:18:46.000000000","message":"is this relevant if the platform is not windows?","commit_id":"9108cc187b7cee836152f903a5e2c3c4c9776be5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23527c626b674c0069e0858a90a7761213ff2f8a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            \u0027quantum.plugins.ryu.agent.ryu_quantum_agent:main\u0027,"},{"line_number":148,"context_line":"            \u0027quantum-nec-agent \u003d \u0027"},{"line_number":149,"context_line":"            \u0027quantum.plugins.nec.agent.nec_quantum_agent:main\u0027,"},{"line_number":150,"context_line":"            \u0027quantum-hyperv-agent \u003d \u0027"},{"line_number":151,"context_line":"            \u0027quantum.plugins.hyperv.agent.hyperv_quantum_agent:main\u0027,"},{"line_number":152,"context_line":"            \u0027quantum-server \u003d quantum.server:main\u0027,"},{"line_number":153,"context_line":"            \u0027quantum-debug \u003d quantum.debug.shell:main\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FwfI%3D","line":150,"updated":"2013-01-07 14:07:57.000000000","message":"is this not specific to windows?","commit_id":"455a3b3125fcad08df1c8981061bf977c94b24b4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"    depend_links.append(\u0027pywin32\u0027)"},{"line_number":26,"context_line":"    depend_links.append(\u0027wmi\u0027)"},{"line_number":27,"context_line":"else:"},{"line_number":28,"context_line":"    depend_links.append(\u0027pyudev\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Name \u003d \u0027quantum\u0027"},{"line_number":31,"context_line":"Url \u003d \"https://launchpad.net/quantum\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Fr6I%3D","line":28,"updated":"2013-01-09 16:34:28.000000000","message":"consider depend_links_dict \u003d {\u0027win32\u0027: [\u0027pywin32\u0027, \u0027wmi\u0027]}","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"meta_plugin_config_path \u003d \u0027etc/quantum/plugins/metaplugin\u0027"},{"line_number":59,"context_line":"nec_plugin_config_path \u003d \u0027etc/quantum/plugins/nec\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"if sys.platform \u003d\u003d \u0027win32\u0027:"},{"line_number":62,"context_line":"    DataFiles \u003d []"},{"line_number":63,"context_line":"else:"},{"line_number":64,"context_line":"    DataFiles \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Fr68%3D","line":61,"updated":"2013-01-09 16:34:28.000000000","message":"just win32 or also cygwin?","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":98,"context_line":"        (meta_plugin_config_path,"},{"line_number":99,"context_line":"            [\u0027etc/quantum/plugins/metaplugin/metaplugin.ini\u0027]),"},{"line_number":100,"context_line":"        (nec_plugin_config_path, [\u0027etc/quantum/plugins/nec/nec.ini\u0027]),"},{"line_number":101,"context_line":"    ]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"setuptools.setup("},{"line_number":104,"context_line":"    name\u003dName,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Fr64%3D","line":101,"updated":"2013-01-09 16:34:28.000000000","message":"boring nit: consider the following:\n\ndefault_DataFiles \u003d [... all the paths ...]\n\nDataFiles \u003d {\u0027win32\u0027: [] }\n\nand see comment @ line 129","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \u0027Programming Language :: Python :: 2.7\u0027,"},{"line_number":121,"context_line":"    ],"},{"line_number":122,"context_line":"    scripts\u003dProjectScripts,"},{"line_number":123,"context_line":"    install_requires\u003drequires,"},{"line_number":124,"context_line":"    dependency_links\u003ddepend_links,"},{"line_number":125,"context_line":"    include_package_data\u003dFalse,"},{"line_number":126,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Fr6w%3D","line":123,"updated":"2013-01-09 16:34:28.000000000","message":"consider :\ndepend_links.extend(depend_links_dict.set_default(sys.platform, [\u0027pyudev\u0027]))","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":125,"context_line":"    include_package_data\u003dFalse,"},{"line_number":126,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"},{"line_number":127,"context_line":"    packages\u003dsetuptools.find_packages(\u0027.\u0027),"},{"line_number":128,"context_line":"    cmdclass\u003dsetup.get_cmdclass(),"},{"line_number":129,"context_line":"    data_files\u003dDataFiles,"},{"line_number":130,"context_line":"    eager_resources\u003dEagerResources,"},{"line_number":131,"context_line":"    entry_points\u003d{"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Fr60%3D","line":128,"updated":"2013-01-09 16:34:28.000000000","message":"data_files \u003d DataFiles.set_default(sys.platform, default_DataFiles)\n\njust because I hate if statements :)\nAlso check whether defaultdict might suit your needs.","commit_id":"6436407ddd8d8a0e65497e1e18f1c00d40fa080f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8b027d61a5ebf31828562142a84f5b478ecbada6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    depend_links.append(\u0027pywin32\u0027)"},{"line_number":26,"context_line":"    depend_links.append(\u0027wmi\u0027)"},{"line_number":27,"context_line":"else:"},{"line_number":28,"context_line":"    depend_links.append(\u0027pyudev\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Name \u003d \u0027quantum\u0027"},{"line_number":31,"context_line":"Url \u003d \"https://launchpad.net/quantum\""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FnAM%3D","line":28,"updated":"2013-01-14 02:17:33.000000000","message":"why add pyudev?","commit_id":"13f03e8bebf374c06344dfed7903942c338adc66"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"hyperv_plugin_config_path \u003d \u0027etc/quantum/plugins/hyperv\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if sys.platform \u003d\u003d \u0027win32\u0027:"},{"line_number":63,"context_line":"    DataFiles \u003d []"},{"line_number":64,"context_line":"else:"},{"line_number":65,"context_line":"    DataFiles \u003d ["},{"line_number":66,"context_line":"        (config_path,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2Fm%2FU%3D","line":63,"updated":"2013-01-14 02:49:51.000000000","message":"Maybe its best to put lines 62 and 63 after line 104 without changing lines 65 through 104?","commit_id":"13f03e8bebf374c06344dfed7903942c338adc66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8b027d61a5ebf31828562142a84f5b478ecbada6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"hyperv_plugin_config_path \u003d \u0027etc/quantum/plugins/hyperv\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if sys.platform \u003d\u003d \u0027win32\u0027:"},{"line_number":63,"context_line":"    DataFiles \u003d []"},{"line_number":64,"context_line":"else:"},{"line_number":65,"context_line":"    DataFiles \u003d ["},{"line_number":66,"context_line":"        (config_path,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2Fmvo%3D","line":63,"in_reply_to":"AAAAM3%2F%2Fm%2FU%3D","updated":"2013-01-14 10:12:59.000000000","message":"I think the current codes is fine. We don\u0027t want to assign variable and then assign it with empty.","commit_id":"13f03e8bebf374c06344dfed7903942c338adc66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8b027d61a5ebf31828562142a84f5b478ecbada6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            \u0027quantum-nec-agent \u003d \u0027"},{"line_number":152,"context_line":"            \u0027quantum.plugins.nec.agent.nec_quantum_agent:main\u0027,"},{"line_number":153,"context_line":"            \u0027quantum-hyperv-agent \u003d \u0027"},{"line_number":154,"context_line":"            \u0027quantum.plugins.hyperv.agent.hyperv_quantum_agent:main\u0027,"},{"line_number":155,"context_line":"            \u0027quantum-server \u003d quantum.server:main\u0027,"},{"line_number":156,"context_line":"            \u0027quantum-debug \u003d quantum.debug.shell:main\u0027,"},{"line_number":157,"context_line":"            \u0027quantum-ovs-cleanup \u003d quantum.agent.ovs_cleanup_util:main\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FnAQ%3D","line":154,"updated":"2013-01-14 02:17:33.000000000","message":"since quanum-hyperv-agent is only for windows platform, I think we will have to use a branch here too. we should make sure which binaries can and should be run on windows.","commit_id":"13f03e8bebf374c06344dfed7903942c338adc66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8b027d61a5ebf31828562142a84f5b478ecbada6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    depend_links.append(\u0027pywin32\u0027)"},{"line_number":26,"context_line":"    depend_links.append(\u0027wmi\u0027)"},{"line_number":27,"context_line":"else:"},{"line_number":28,"context_line":"    depend_links.append(\u0027pyudev\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Name \u003d \u0027quantum\u0027"},{"line_number":31,"context_line":"Url \u003d \"https://launchpad.net/quantum\""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAM3%2F%2Fmts%3D","line":28,"updated":"2013-01-14 11:04:08.000000000","message":"why do u add it here?","commit_id":"1d4aa2127d18853a77078b502ac1cf8d2889534e"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"6c5143d4c4cf16ce143b77a15608c904c4ca9fd7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    depend_links.append(\u0027pywin32\u0027)"},{"line_number":26,"context_line":"    depend_links.append(\u0027wmi\u0027)"},{"line_number":27,"context_line":"else:"},{"line_number":28,"context_line":"    depend_links.append(\u0027pyudev\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Name \u003d \u0027quantum\u0027"},{"line_number":31,"context_line":"Url \u003d \"https://launchpad.net/quantum\""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAM3%2F%2Fmtc%3D","line":28,"in_reply_to":"AAAAM3%2F%2Fmts%3D","updated":"2013-01-14 11:07:04.000000000","message":"pyudev is not available on Windows.\nIt needs to be removed from pip-requires, which I just noticed is not included in the patch. I\u0027m going to fix it in the next patchset.","commit_id":"1d4aa2127d18853a77078b502ac1cf8d2889534e"}]}