)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"d0bb5668f878e9e0b01919d2cc90384fcaf42b67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-11 15:49:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVSNeutronAgent pass the config as paramter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using the global cfg.CONF, pass the config as parameter."},{"line_number":10,"context_line":"This is very useful to test the agent without having to override"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_78a2699c","line":7,"updated":"2015-06-11 15:03:07.000000000","message":"nit : parameter?","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c4be6adfe13a0e1401c37d3f25aa7173b632b061","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-11 15:49:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVSNeutronAgent pass the config as paramter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using the global cfg.CONF, pass the config as parameter."},{"line_number":10,"context_line":"This is very useful to test the agent without having to override"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_f3867a15","line":7,"in_reply_to":"3afb71cf_78a2699c","updated":"2015-06-12 09:03:16.000000000","message":"thanks, I will fix this when I respin","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d02941ea6f60a33dfceae48f7dc2f0a5705a59fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using the global cfg.CONF, pass the config as parameter."},{"line_number":10,"context_line":"This is very useful to test the agent without having to override"},{"line_number":11,"context_line":"the global config."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I45534d79e044da9f2be4d596a58310fb28b7bf22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af86dd1_d6aa4585","line":11,"updated":"2015-06-12 07:09:16.000000000","message":"miss Partially-Implements","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c4be6adfe13a0e1401c37d3f25aa7173b632b061","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using the global cfg.CONF, pass the config as parameter."},{"line_number":10,"context_line":"This is very useful to test the agent without having to override"},{"line_number":11,"context_line":"the global config."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I45534d79e044da9f2be4d596a58310fb28b7bf22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af86dd1_58031f10","line":11,"in_reply_to":"1af86dd1_d6aa4585","updated":"2015-06-12 09:03:16.000000000","message":"it\u0027s not really related to any blueprint","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4c97e4acf8b0556eb3c1c7803536ffe164de4786","unresolved":false,"context_lines":[{"line_number":164,"context_line":"               interconnect the integration bridge to physical bridges."},{"line_number":165,"context_line":"        :param quitting_rpc_timeout: timeout in seconds for rpc calls after"},{"line_number":166,"context_line":"               SIGTERM is received"},{"line_number":167,"context_line":"        :param conf: an instance of cfg.CONF"},{"line_number":168,"context_line":"        \u0027\u0027\u0027"},{"line_number":169,"context_line":"        super(OVSNeutronAgent, self).__init__()"},{"line_number":170,"context_line":"        self.br_int_cls \u003d bridge_classes[\u0027br_int\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_071c38c0","line":167,"updated":"2015-06-11 14:11:41.000000000","message":"an instance of ConfigOpts?","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bcbf13a97ac2bd59477b0b3a512b2374d13a3c42","unresolved":false,"context_lines":[{"line_number":164,"context_line":"               interconnect the integration bridge to physical bridges."},{"line_number":165,"context_line":"        :param quitting_rpc_timeout: timeout in seconds for rpc calls after"},{"line_number":166,"context_line":"               SIGTERM is received"},{"line_number":167,"context_line":"        :param conf: an instance of cfg.CONF"},{"line_number":168,"context_line":"        \u0027\u0027\u0027"},{"line_number":169,"context_line":"        super(OVSNeutronAgent, self).__init__()"},{"line_number":170,"context_line":"        self.br_int_cls \u003d bridge_classes[\u0027br_int\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_4a3b5739","line":167,"in_reply_to":"3afb71cf_071c38c0","updated":"2015-06-11 14:30:46.000000000","message":"Done","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"b781d2b63ef11c859fd12d7354c14a1567010f0a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.enable_distributed_routing \u003d enable_distributed_routing"},{"line_number":183,"context_line":"        self.arp_responder_enabled \u003d arp_responder and self.l2_pop"},{"line_number":184,"context_line":"        self.prevent_arp_spoofing \u003d prevent_arp_spoofing"},{"line_number":185,"context_line":"        self.agent_state \u003d {"},{"line_number":186,"context_line":"            \u0027binary\u0027: \u0027neutron-openvswitch-agent\u0027,"},{"line_number":187,"context_line":"            \u0027host\u0027: cfg.CONF.host,"},{"line_number":188,"context_line":"            \u0027topic\u0027: q_const.L2_AGENT_TOPIC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_e4b8faea","line":185,"updated":"2015-06-11 13:44:30.000000000","message":"cfg.CONF is used here","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"b781d2b63ef11c859fd12d7354c14a1567010f0a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            self.enable_tunneling \u003d False"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if conf:"},{"line_number":206,"context_line":"            self.conf \u003d conf"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.conf \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_04ed56ef","line":205,"updated":"2015-06-11 13:44:30.000000000","message":"This needs to be above the previous comment","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3c7d14c68a67bc3b0f3544e1f699b2210fb44a5f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            self.enable_tunneling \u003d False"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if conf:"},{"line_number":206,"context_line":"            self.conf \u003d conf"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.conf \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ca92a74b","line":205,"in_reply_to":"3afb71cf_04ed56ef","updated":"2015-06-11 14:23:33.000000000","message":"oh yes, thanks for noticing this. It seems I can\u0027t do search/replace correctly today","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4c97e4acf8b0556eb3c1c7803536ffe164de4786","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"                               \"Agent and Server side.\"))"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"def create_agent_config_map(config):"},{"line_number":1638,"context_line":"    \"\"\"Create a map of agent config parameters."},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"    :param config: an instance of cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c7caa01a","line":1637,"updated":"2015-06-11 14:11:41.000000000","message":"create_agent_config_map is another way to pass configurations to the agent class.\nit\u0027s better to have a unified way, rather than two.","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d97c5a3c9a5c0196a5b91620ee328489b5ffe1f9","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"                               \"Agent and Server side.\"))"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"def create_agent_config_map(config):"},{"line_number":1638,"context_line":"    \"\"\"Create a map of agent config parameters."},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"    :param config: an instance of cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_cb3f4686","line":1637,"in_reply_to":"3afb71cf_4aac7735","updated":"2015-06-11 16:19:59.000000000","message":"i meant it might be time to clean up these config stuffs.\nok, i understand it\u0027s out of scope of this patch.","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"bcbf13a97ac2bd59477b0b3a512b2374d13a3c42","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"                               \"Agent and Server side.\"))"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"def create_agent_config_map(config):"},{"line_number":1638,"context_line":"    \"\"\"Create a map of agent config parameters."},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"    :param config: an instance of cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_4aac7735","line":1637,"in_reply_to":"3afb71cf_c7caa01a","updated":"2015-06-11 14:30:46.000000000","message":"I am not sure what you mean here. There are already two ways to pass configuration to the agent: the config file and the parameters passed to the constructor. I didn\u0027t want to use the default config cfg.CONF that\u0027s why I created this patch.","commit_id":"ed3534a453036c28a92269bba4964ffb5a0f6199"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"f97cfb397ca27660bc2996465e19d464c6203050","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if conf:"},{"line_number":187,"context_line":"            self.conf \u003d conf"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            self.conf \u003d cfg.CONF"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.agent_state \u003d {"},{"line_number":192,"context_line":"            \u0027binary\u0027: \u0027neutron-openvswitch-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_dd95ba88","line":189,"updated":"2015-06-11 20:54:14.000000000","message":"this should be:\n\nself.conf \u003d conf or cfg.CONF","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d02941ea6f60a33dfceae48f7dc2f0a5705a59fa","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if conf:"},{"line_number":187,"context_line":"            self.conf \u003d conf"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            self.conf \u003d cfg.CONF"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.agent_state \u003d {"},{"line_number":192,"context_line":"            \u0027binary\u0027: \u0027neutron-openvswitch-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_16b69ddc","line":189,"in_reply_to":"3afb71cf_dd95ba88","updated":"2015-06-12 07:09:16.000000000","message":"+1","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c4be6adfe13a0e1401c37d3f25aa7173b632b061","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if conf:"},{"line_number":187,"context_line":"            self.conf \u003d conf"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            self.conf \u003d cfg.CONF"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.agent_state \u003d {"},{"line_number":192,"context_line":"            \u0027binary\u0027: \u0027neutron-openvswitch-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_fb08852a","line":189,"in_reply_to":"3afb71cf_dd95ba88","updated":"2015-06-12 09:03:16.000000000","message":"Done","commit_id":"b67481aefe094a5b8a2f92d0a703d2dfa7a1c390"}]}