)]}'
{"doc/source/devref/quota.rst":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9f866b482fee14e88c3b0541282c3d1bf5625753","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement. "},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."},{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_185ed2e9","line":38,"updated":"2015-06-13 16:24:49.000000000","message":"please remove the last space.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement. "},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."},{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_6b1e7fbc","line":38,"in_reply_to":"fa32b979_185ed2e9","updated":"2015-06-17 19:53:40.000000000","message":"sure.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."},{"line_number":44,"context_line":"This API extension is loaded like any other extension. For this reason plugins"},{"line_number":45,"context_line":"must explicitly support it by including \"quotas\" in the"},{"line_number":46,"context_line":"support_extension_aliases attribute."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_c0503161","line":44,"updated":"2015-06-11 21:32:57.000000000","message":"Just wondering, probably due to my lack of understanding, if the plugins doesnt need to be aware of this (or implement this) as stated above, why the plugin \"must explicitly support it\", basically i guess the question is why all extensions are plugin configuration even when they are agnostic to the plugin ?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."},{"line_number":44,"context_line":"This API extension is loaded like any other extension. For this reason plugins"},{"line_number":45,"context_line":"must explicitly support it by including \"quotas\" in the"},{"line_number":46,"context_line":"support_extension_aliases attribute."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_cb530b6a","line":44,"in_reply_to":"3afb71cf_c0503161","updated":"2015-06-17 19:53:40.000000000","message":"your wondering is correct. It\u0027s just one of the things that do not make a lot of sense in neutron. Basically the plugin doesn\u0027t have to do anything for quota enforcement as it\u0027s done before dispatching the request to the plugin.\n\nOn the other hand, for quota management - ie: setting limits - there is an API extension (!) which must be explicitly supported by the plugin, otherwise the extension manager won\u0027t load it.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9f866b482fee14e88c3b0541282c3d1bf5625753","unresolved":false,"context_lines":[{"line_number":74,"context_line":"an attribute is added for every resource managed by the quota engine."},{"line_number":75,"context_line":"Request authorisation is performed in this controller, and only \u0027admin\u0027 users"},{"line_number":76,"context_line":"are allowed to modify quotas for tenants. As the neutron policy engine is not"},{"line_number":77,"context_line":"used, it is not possible to configure which users should be allowed to manage"},{"line_number":78,"context_line":"quotas using policy.json."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The driver operations dealing with quota management are:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_d8b38a09","line":77,"updated":"2015-06-13 16:24:49.000000000","message":"nit: Who is the users, that is admin?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"91a82d723027e7c008a29b6f0bc667c027e6a24c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"an attribute is added for every resource managed by the quota engine."},{"line_number":75,"context_line":"Request authorisation is performed in this controller, and only \u0027admin\u0027 users"},{"line_number":76,"context_line":"are allowed to modify quotas for tenants. As the neutron policy engine is not"},{"line_number":77,"context_line":"used, it is not possible to configure which users should be allowed to manage"},{"line_number":78,"context_line":"quotas using policy.json."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The driver operations dealing with quota management are:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_688e7ad1","line":77,"in_reply_to":"fa32b979_8be0a397","updated":"2015-06-18 00:02:40.000000000","message":"Sorry, I misunderstood your intention since it occurs to me just \"admin only can use policy.json?\".  You ignore my comment.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"an attribute is added for every resource managed by the quota engine."},{"line_number":75,"context_line":"Request authorisation is performed in this controller, and only \u0027admin\u0027 users"},{"line_number":76,"context_line":"are allowed to modify quotas for tenants. As the neutron policy engine is not"},{"line_number":77,"context_line":"used, it is not possible to configure which users should be allowed to manage"},{"line_number":78,"context_line":"quotas using policy.json."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The driver operations dealing with quota management are:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_8be0a397","line":77,"in_reply_to":"fa32b979_d8b38a09","updated":"2015-06-17 19:53:40.000000000","message":"I\u0027ve used \"users\" in a generic way - as \"any user\". If you think you have a better term feel free to suggest","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"quotas using policy.json."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The driver operations dealing with quota management are:"},{"line_number":81,"context_line":"* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027"},{"line_number":82,"context_line":"  table for a given tenant identifier;"},{"line_number":83,"context_line":"* update_quota_limit, which adds or updates an entry in the \u0027quotas\u0027 tenant for"},{"line_number":84,"context_line":"  a given tenant identifier and a given resource name;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_a36d5ace","line":81,"updated":"2015-06-11 21:32:57.000000000","message":"Is it possible to define quota profiles ? and attach these profiles to tenants ?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"quotas using policy.json."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"The driver operations dealing with quota management are:"},{"line_number":81,"context_line":"* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027"},{"line_number":82,"context_line":"  table for a given tenant identifier;"},{"line_number":83,"context_line":"* update_quota_limit, which adds or updates an entry in the \u0027quotas\u0027 tenant for"},{"line_number":84,"context_line":"  a given tenant identifier and a given resource name;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_2b9717ed","line":81,"in_reply_to":"1af86dd1_a36d5ace","updated":"2015-06-17 19:53:40.000000000","message":"not yet. Nova has a similar capability - called quota classes If you want to implement in neutron, you have my +1.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"when coupled with the concept of resource reservation, discussed in another"},{"line_number":122,"context_line":"section of this chapter."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Tracking quota usage is not as simple ads updating a counter every time"},{"line_number":125,"context_line":"resources are created or deleted."},{"line_number":126,"context_line":"Indeed a quota-limited resource in Neutron can be created in several ways."},{"line_number":127,"context_line":"While a RESTful API request is the most common one, resources can be created"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_4348e62d","line":124,"updated":"2015-06-11 21:32:57.000000000","message":"\"not as simple ads..\" \u003d\u003e \"not as simple as\"","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"when coupled with the concept of resource reservation, discussed in another"},{"line_number":122,"context_line":"section of this chapter."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Tracking quota usage is not as simple ads updating a counter every time"},{"line_number":125,"context_line":"resources are created or deleted."},{"line_number":126,"context_line":"Indeed a quota-limited resource in Neutron can be created in several ways."},{"line_number":127,"context_line":"While a RESTful API request is the most common one, resources can be created"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_abb24792","line":124,"in_reply_to":"1af86dd1_4348e62d","updated":"2015-06-17 19:53:40.000000000","message":"no I meant ads! I want an ad returned automatically every X responses where X can be configured by the deployer ;)","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":134,"context_line":"The event handler is executed after a record is inserted or deleted."},{"line_number":135,"context_line":"As result usage data for that resource and will be marked as \u0027dirty\u0027 once"},{"line_number":136,"context_line":"the operation completes, so that the next time usage data is requested,"},{"line_number":137,"context_line":"it will be synchronised counting resource usage from the database."},{"line_number":138,"context_line":"Even if this solution has some drawbacks, listed in the \u0027exceptions and"},{"line_number":139,"context_line":"caveats\u0027 section, it is more reliable than solutions such as:"},{"line_number":140,"context_line":"* Updating the usage counters with the new \u0027correct\u0027 value every time an"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_6320824a","line":137,"updated":"2015-06-11 21:32:57.000000000","message":"How these event handlers can block the creations if the quota is met? and if these objects are not added by the users, how will the user be notified that something failed?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"The event handler is executed after a record is inserted or deleted."},{"line_number":135,"context_line":"As result usage data for that resource and will be marked as \u0027dirty\u0027 once"},{"line_number":136,"context_line":"the operation completes, so that the next time usage data is requested,"},{"line_number":137,"context_line":"it will be synchronised counting resource usage from the database."},{"line_number":138,"context_line":"Even if this solution has some drawbacks, listed in the \u0027exceptions and"},{"line_number":139,"context_line":"caveats\u0027 section, it is more reliable than solutions such as:"},{"line_number":140,"context_line":"* Updating the usage counters with the new \u0027correct\u0027 value every time an"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_f66b56b7","line":137,"in_reply_to":"1af86dd1_6320824a","updated":"2015-06-17 19:53:40.000000000","message":"the handlers will not block anything, they simply report that there has been a change in usage data. They pretty much do cache invalidation.\n\nFor objects not added by API consumers, we are not enforcing quotas nowadays and we won\u0027t as a result of this blueprint. Enforcing quota in operations like add_router_interface would require the addition of a layer between the API request processing and the plugin processing. I don\u0027t want to add this architectural change here. This was advocated by plugin-perestroika spec. (note: I wrote it but I was not meant to be the assignee)","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"0b7c93298ea5f767a1483df32cebdec60e8e99a0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  subtracted from resource usage. As in most cases there won\u0027t be any"},{"line_number":165,"context_line":"  expired reservation, this approach actually requires less DB operations than"},{"line_number":166,"context_line":"  doing a sum of non-expired, reserved resources for each request."},{"line_number":167,"context_line":"* For each resource calculated headroom for resource, and verify the requested"},{"line_number":168,"context_line":"  amount of resource is less than the headroom."},{"line_number":169,"context_line":"* If the above is true for all resource, the reservation is saved in the DB,"},{"line_number":170,"context_line":"  otherwise an OverQuotaLimit exception is raised."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_967938ff","line":167,"updated":"2015-06-29 19:21:51.000000000","message":"Is that supposed to be \"calculate\" or am I going \"googly eyed\" and  misunderstanding the sentence?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"aacb6bea7ba50c22e2a911dda3ffddbfb3eab94a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  subtracted from resource usage. As in most cases there won\u0027t be any"},{"line_number":165,"context_line":"  expired reservation, this approach actually requires less DB operations than"},{"line_number":166,"context_line":"  doing a sum of non-expired, reserved resources for each request."},{"line_number":167,"context_line":"* For each resource calculated headroom for resource, and verify the requested"},{"line_number":168,"context_line":"  amount of resource is less than the headroom."},{"line_number":169,"context_line":"* If the above is true for all resource, the reservation is saved in the DB,"},{"line_number":170,"context_line":"  otherwise an OverQuotaLimit exception is raised."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_5c0cc3eb","line":167,"in_reply_to":"ba3cc151_967938ff","updated":"2015-07-08 11:26:13.000000000","message":"Done","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":203,"context_line":"Reservations are not perennial. Eternal reservation would eventually exhaust"},{"line_number":204,"context_line":"tenants\u0027 quotas because they would never be removed when an API worker crashes"},{"line_number":205,"context_line":"whilst in the middle of an operation."},{"line_number":206,"context_line":"Reservation expiration is currently set to 60 seconds, and is not configurable,"},{"line_number":207,"context_line":"not yet at least. Expired reservations are not counted when calculating"},{"line_number":208,"context_line":"resource usage. While creating a reservation, if any expired reservation is"},{"line_number":209,"context_line":"found, all expired reservation for that tenant and resource will be removed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_a39e7a05","line":206,"updated":"2015-06-11 21:32:57.000000000","message":"nice solution","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"Reservations are not perennial. Eternal reservation would eventually exhaust"},{"line_number":204,"context_line":"tenants\u0027 quotas because they would never be removed when an API worker crashes"},{"line_number":205,"context_line":"whilst in the middle of an operation."},{"line_number":206,"context_line":"Reservation expiration is currently set to 60 seconds, and is not configurable,"},{"line_number":207,"context_line":"not yet at least. Expired reservations are not counted when calculating"},{"line_number":208,"context_line":"resource usage. While creating a reservation, if any expired reservation is"},{"line_number":209,"context_line":"found, all expired reservation for that tenant and resource will be removed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_369d3ebc","line":206,"in_reply_to":"1af86dd1_a39e7a05","updated":"2015-06-17 19:53:40.000000000","message":"indeed it\u0027s not my idea","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d20da67e0bc9c610f129f9a8c8d2be961b7fb5bc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Will ensure network, port, subnet and subnetpool resources are tracked."},{"line_number":236,"context_line":"In theory, it is possible to use this decorator multiple times, and not"},{"line_number":237,"context_line":"exclusively to __init__ methods. However, this would eventually lead to"},{"line_number":238,"context_line":"code readability and maintainability problems, so developers are strongly"},{"line_number":239,"context_line":"encourage to apply this decorator exclusively to the plugin\u0027s __init__"},{"line_number":240,"context_line":"method (or any other method which is called by the plugin only once"},{"line_number":241,"context_line":"during its initialization)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_a3d0baca","line":238,"updated":"2015-06-11 21:32:57.000000000","message":"I am wondering here and thats probably out of scope, but i assume that quota is usually important for actual usage of physical infrastructure, for example vCPU for VM\u0027s.\n\nDon\u0027t you think that in regards to network, network bandwidth is also kind of a quota ? (this intersect with QoS but i think is related)\n(Basically usage from the physical NIC)","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Will ensure network, port, subnet and subnetpool resources are tracked."},{"line_number":236,"context_line":"In theory, it is possible to use this decorator multiple times, and not"},{"line_number":237,"context_line":"exclusively to __init__ methods. However, this would eventually lead to"},{"line_number":238,"context_line":"code readability and maintainability problems, so developers are strongly"},{"line_number":239,"context_line":"encourage to apply this decorator exclusively to the plugin\u0027s __init__"},{"line_number":240,"context_line":"method (or any other method which is called by the plugin only once"},{"line_number":241,"context_line":"during its initialization)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_165b5af7","line":238,"in_reply_to":"1af86dd1_a3d0baca","updated":"2015-06-17 19:53:40.000000000","message":"I\u0027d say no.\nWe are interested in limiting resources that are managed by neutron. The vCPU analogy is good, because it\u0027s a compute resource that can be managed through the API. Still it\u0027s an attribute of a server resource, where as bandwidth quantifies traffic flowing through neutron ports.\n\nApart from the idelogical perspective, there is also the practical perspective that you would not be forced to scope bandwidth to a tenant, and that\u0027s what the quota engine does at the moment. For instance you would assign overall bandwidth for a network, or a for a group of ports in the same QoS pool.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9f866b482fee14e88c3b0541282c3d1bf5625753","unresolved":false,"context_lines":[{"line_number":248,"context_line":"RPC over AMQP APIs. In particular the RPC handlers call straight into the"},{"line_number":249,"context_line":"plugin, without doing any request authorisation or quota enforcement."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Therefore RPC handlers must explcitly indicate if they are going to call the"},{"line_number":252,"context_line":"plugin to create or delete any sort of resources. This is achieved in a simple"},{"line_number":253,"context_line":"way, by ensuring modified resources are marked as dirty after the RPC handler"},{"line_number":254,"context_line":"execution terminates. To this aim developers can use the mark_resources_dirty"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5803fab8","line":251,"updated":"2015-06-13 16:24:49.000000000","message":"explcitly -\u003e explicitly","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":248,"context_line":"RPC over AMQP APIs. In particular the RPC handlers call straight into the"},{"line_number":249,"context_line":"plugin, without doing any request authorisation or quota enforcement."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Therefore RPC handlers must explcitly indicate if they are going to call the"},{"line_number":252,"context_line":"plugin to create or delete any sort of resources. This is achieved in a simple"},{"line_number":253,"context_line":"way, by ensuring modified resources are marked as dirty after the RPC handler"},{"line_number":254,"context_line":"execution terminates. To this aim developers can use the mark_resources_dirty"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_b674ee67","line":251,"in_reply_to":"fa32b979_5803fab8","updated":"2015-06-17 19:53:40.000000000","message":"Done","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9a942c745862b11b40bef9ba3ebd83fec411af6b","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  should pay particular attention into ensuring resource names are correctly"},{"line_number":289,"context_line":"  specified."},{"line_number":290,"context_line":"* The code assumes usage trackers are a trusted source of truth: if they"},{"line_number":291,"context_line":"  report a usage counter and the dirty bit is not set, that counter is"},{"line_number":292,"context_line":"  correct. If it\u0027s dirty than surely that counter is out of sync."},{"line_number":293,"context_line":"  This is not very robust, as there might be issues when toggling the"},{"line_number":294,"context_line":"  use_tracked_resources configuration variable, as stale counters might be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_a351bb64","line":291,"updated":"2015-06-12 15:14:11.000000000","message":"can you explain how do you plan to handle the dirty bit? is it going to cause a resync or something like that?","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  should pay particular attention into ensuring resource names are correctly"},{"line_number":289,"context_line":"  specified."},{"line_number":290,"context_line":"* The code assumes usage trackers are a trusted source of truth: if they"},{"line_number":291,"context_line":"  report a usage counter and the dirty bit is not set, that counter is"},{"line_number":292,"context_line":"  correct. If it\u0027s dirty than surely that counter is out of sync."},{"line_number":293,"context_line":"  This is not very robust, as there might be issues when toggling the"},{"line_number":294,"context_line":"  use_tracked_resources configuration variable, as stale counters might be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_b6970e47","line":291,"in_reply_to":"1af86dd1_a351bb64","updated":"2015-06-17 19:53:40.000000000","message":"Normally that would be done with the event handlers describe above.\nI\u0027m talking about startup here. Basically what I\u0027m saying here is that I\u0027m trusting that nobody fiddled with the db since the last shutdown.\n\nGenerally speaking, a resync should be forced the first time a resource is counted for a given tenant. This is not a big deal, I\u0027ll do that as a follow-up patch. I just put the caveat here so I won\u0027t forget about it!","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9f866b482fee14e88c3b0541282c3d1bf5625753","unresolved":false,"context_lines":[{"line_number":295,"context_line":"  trusted upon for making reservation. Also, the same situation might occur"},{"line_number":296,"context_line":"  if a server crashes after the API operation is completed but before the"},{"line_number":297,"context_line":"  reservation is committed, as the actual resource usage is changed but"},{"line_number":298,"context_line":"  the corresponding usage tracker is not marked as dirty. "},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"References"},{"line_number":301,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_d8570ac9","line":298,"updated":"2015-06-13 16:24:49.000000000","message":"please remove the last space.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"  trusted upon for making reservation. Also, the same situation might occur"},{"line_number":296,"context_line":"  if a server crashes after the API operation is completed but before the"},{"line_number":297,"context_line":"  reservation is committed, as the actual resource usage is changed but"},{"line_number":298,"context_line":"  the corresponding usage tracker is not marked as dirty. "},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"References"},{"line_number":301,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_d6941244","line":298,"in_reply_to":"fa32b979_d8570ac9","updated":"2015-06-17 19:53:40.000000000","message":"Done","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9f866b482fee14e88c3b0541282c3d1bf5625753","unresolved":false,"context_lines":[{"line_number":305,"context_line":".. [#] Quota API extension controller: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/quotasv2.py#n40"},{"line_number":306,"context_line":".. [#] Neutron resource attribute map: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/attributes.py#n639"},{"line_number":307,"context_line":".. [#] Base controller class: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/base.py#n50"},{"line_number":308,"context_line":".. [#] http://lists.openstack.org/pipermail/openstack-dev/2015-February/057534.html "}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_586c5a9c","line":308,"updated":"2015-06-13 16:24:49.000000000","message":"please remove the last space.","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7c0a7697b723c2e89aa0382a8628cf73dde906d2","unresolved":false,"context_lines":[{"line_number":305,"context_line":".. [#] Quota API extension controller: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/quotasv2.py#n40"},{"line_number":306,"context_line":".. [#] Neutron resource attribute map: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/attributes.py#n639"},{"line_number":307,"context_line":".. [#] Base controller class: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/base.py#n50"},{"line_number":308,"context_line":".. [#] http://lists.openstack.org/pipermail/openstack-dev/2015-February/057534.html "}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_969a0a6d","line":308,"in_reply_to":"fa32b979_586c5a9c","updated":"2015-06-17 19:53:40.000000000","message":"Done","commit_id":"11dcb390cac526d6218d8694b95f00b07ed1a00e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"The Neutron API exposes an extension for managing such quotas. Quota limits are"},{"line_number":7,"context_line":"enforced at the API layer, before the request is dispatched to the plugin."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The quota limit specified in neutron.conf are defaults values. Admin users"},{"line_number":10,"context_line":"can override these default values on a per-tenant basis."},{"line_number":11,"context_line":"Configuration-based quota management, where every tenant gets the same quota"},{"line_number":12,"context_line":"limit specified in the configuration file, has been deprecated as of the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_136701b8","line":9,"updated":"2015-07-08 13:47:16.000000000","message":"I think this paragraph  is better written in the following way:\n\nPrior to the Liberty release, the Neuron API used configuration-based quota management, with default values specified in neutron.conf.  Admin users could override those defaults on a per-tenant basis.  With the Liberty release, this approach has been deprecated in favor of the quota management system documented here.","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"The Neutron API exposes an extension for managing such quotas. Quota limits are"},{"line_number":7,"context_line":"enforced at the API layer, before the request is dispatched to the plugin."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The quota limit specified in neutron.conf are defaults values. Admin users"},{"line_number":10,"context_line":"can override these default values on a per-tenant basis."},{"line_number":11,"context_line":"Configuration-based quota management, where every tenant gets the same quota"},{"line_number":12,"context_line":"limit specified in the configuration file, has been deprecated as of the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_bdea71d6","line":9,"in_reply_to":"ba3cc151_136701b8","updated":"2015-07-09 08:45:33.000000000","message":"I am simply documenting how quota management works here.\nThe work done with this series of patches is changing quota enforcement, not quota management.\n\nI will incorporate the rest of the feedback you provided here.","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Plugin and ML2 drivers are not supposed to enforce quotas for resources they"},{"line_number":22,"context_line":"manage. However, the subnet_allocation [#]_ extension is an exception and will"},{"line_number":23,"context_line":"be discussed later in this section."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_930eb18a","line":23,"updated":"2015-07-08 13:47:16.000000000","message":"nit: replace \"later in this section\" with \"below\"","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Plugin and ML2 drivers are not supposed to enforce quotas for resources they"},{"line_number":22,"context_line":"manage. However, the subnet_allocation [#]_ extension is an exception and will"},{"line_number":23,"context_line":"be discussed later in this section."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_5dbc85db","line":23,"in_reply_to":"ba3cc151_930eb18a","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"manage. However, the subnet_allocation [#]_ extension is an exception and will"},{"line_number":23,"context_line":"be discussed later in this section."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"},{"line_number":27,"context_line":"regardless of whether such resource belongs to Neutron core or advanced"},{"line_number":28,"context_line":"services."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_73ce8d2e","line":25,"updated":"2015-07-08 13:47:16.000000000","message":"nit: replace \"in this document\" with \"here\"","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"manage. However, the subnet_allocation [#]_ extension is an exception and will"},{"line_number":23,"context_line":"be discussed later in this section."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"},{"line_number":27,"context_line":"regardless of whether such resource belongs to Neutron core or advanced"},{"line_number":28,"context_line":"services."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_7dbf09d0","line":25,"in_reply_to":"ba3cc151_73ce8d2e","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"},{"line_number":27,"context_line":"regardless of whether such resource belongs to Neutron core or advanced"},{"line_number":28,"context_line":"services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"High level view"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_5353496b","line":27,"updated":"2015-07-08 13:47:16.000000000","message":"nit: replace \"belongs to Neutron core or advanced services\" with \"part of the Neutron core or one of its extensions\"","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The quota management and enforcement mechanisms discussed in this document"},{"line_number":26,"context_line":"apply to every resource which has been registered with the Quota engine,"},{"line_number":27,"context_line":"regardless of whether such resource belongs to Neutron core or advanced"},{"line_number":28,"context_line":"services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"High level view"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_1da91d90","line":27,"in_reply_to":"ba3cc151_5353496b","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"There are two main components in the Neutron quota system:"},{"line_number":34,"context_line":"* The Quota API extension;"},{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_0e5d9a14","line":35,"updated":"2015-07-08 13:47:16.000000000","message":"Add the quota driver as it is a dependent part of the system?","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"There are two main components in the Neutron quota system:"},{"line_number":34,"context_line":"* The Quota API extension;"},{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_dd973546","line":35,"in_reply_to":"ba3cc151_0e5d9a14","updated":"2015-07-09 08:45:33.000000000","message":"I can add that they both rely on a quota driver","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* The Quota API extension;"},{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_d3f4395c","line":37,"updated":"2015-07-08 13:47:16.000000000","message":"nit: use handles instead of perform or performs in this sentence","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* The Quota API extension;"},{"line_number":35,"context_line":"* The Quota Engine."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_bd983176","line":37,"in_reply_to":"ba3cc151_d3f4395c","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."},{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_b34bb586","line":40,"updated":"2015-07-08 13:47:16.000000000","message":"nit: \"In the Quota API, simple CRUD operations are used for managing tenant quotas\"","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"The Quota API extension perform quota management, whereas the Quota Engine"},{"line_number":38,"context_line":"component performs quota enforcement."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The Quota API simply performs CRUD operations for managing tenant quotas."},{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_1d803df6","line":40,"in_reply_to":"ba3cc151_b34bb586","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."},{"line_number":44,"context_line":"This API extension is loaded like any other extension. For this reason plugins"},{"line_number":45,"context_line":"must explicitly support it by including \"quotas\" in the"},{"line_number":46,"context_line":"support_extension_aliases attribute."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_2e15fe3e","line":44,"updated":"2015-07-08 13:47:16.000000000","message":"Bring the last two sentences of this paragraph up to the previous paragraph to help the flow","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"},{"line_number":42,"context_line":"quota limits for that tenant to configuration defaults. The API"},{"line_number":43,"context_line":"extension does not validate the tenant identifier with the identity service."},{"line_number":44,"context_line":"This API extension is loaded like any other extension. For this reason plugins"},{"line_number":45,"context_line":"must explicitly support it by including \"quotas\" in the"},{"line_number":46,"context_line":"support_extension_aliases attribute."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_5d91e545","line":44,"in_reply_to":"ba3cc151_2e15fe3e","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"RESTful API controllers, before sending a request to the plugin, try to obtain"},{"line_number":50,"context_line":"a reservation from the quota engine for the resources specified in the client"},{"line_number":51,"context_line":"request. If the reservation is successful, then it proceeds to dispatch the"},{"line_number":52,"context_line":"operation to the plugin."},{"line_number":53,"context_line":"For a reservation to be successful, the total amount of resources requested,"},{"line_number":54,"context_line":"plus the total amount of resources reserved, plus the total amount of resources"},{"line_number":55,"context_line":"already stored in the database should not exceed the tenant\u0027s quota limit."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_ae4eee6c","line":52,"updated":"2015-07-08 13:47:16.000000000","message":"Nit: is this a paragraph break? if not, join these lines up","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"RESTful API controllers, before sending a request to the plugin, try to obtain"},{"line_number":50,"context_line":"a reservation from the quota engine for the resources specified in the client"},{"line_number":51,"context_line":"request. If the reservation is successful, then it proceeds to dispatch the"},{"line_number":52,"context_line":"operation to the plugin."},{"line_number":53,"context_line":"For a reservation to be successful, the total amount of resources requested,"},{"line_number":54,"context_line":"plus the total amount of resources reserved, plus the total amount of resources"},{"line_number":55,"context_line":"already stored in the database should not exceed the tenant\u0027s quota limit."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_9dabed74","line":52,"in_reply_to":"ba3cc151_ae4eee6c","updated":"2015-07-09 08:45:33.000000000","message":"Yes, I will add a blank line","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"However, unlike the vast majority of Neutron extensions, it uses it own"},{"line_number":66,"context_line":"controller class [#]_."},{"line_number":67,"context_line":"This class does not implement the POST operation. List, get, update, and"},{"line_number":68,"context_line":"delete operations are implemented by the usual index, show, update and"},{"line_number":69,"context_line":"delete methods. These method pretty simply call into the quota driver"},{"line_number":70,"context_line":"for either fetching tenant quotas or updating them."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_ee52b6dd","line":67,"updated":"2015-07-08 13:47:16.000000000","message":"There needs to be a discussion of how POST is handled then...","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"However, unlike the vast majority of Neutron extensions, it uses it own"},{"line_number":66,"context_line":"controller class [#]_."},{"line_number":67,"context_line":"This class does not implement the POST operation. List, get, update, and"},{"line_number":68,"context_line":"delete operations are implemented by the usual index, show, update and"},{"line_number":69,"context_line":"delete methods. These method pretty simply call into the quota driver"},{"line_number":70,"context_line":"for either fetching tenant quotas or updating them."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_bdd4b1e8","line":67,"in_reply_to":"ba3cc151_ee52b6dd","updated":"2015-07-09 08:45:33.000000000","message":"what do you want to discuss? POST operations simply returns 405 I think. Would that be enough?","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"527e9ef8ca9d0071926f17f3f03b815f24f6ac2e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"controller class [#]_."},{"line_number":67,"context_line":"This class does not implement the POST operation. List, get, update, and"},{"line_number":68,"context_line":"delete operations are implemented by the usual index, show, update and"},{"line_number":69,"context_line":"delete methods. These method pretty simply call into the quota driver"},{"line_number":70,"context_line":"for either fetching tenant quotas or updating them."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The _update_attributes method is called only once in the controller lifetime."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_eebb960d","line":69,"updated":"2015-07-08 13:47:16.000000000","message":"nit: remove \"pretty\"","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"37e7e39af93ce928dbb3f9e9e3a2cee8b47e253a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"controller class [#]_."},{"line_number":67,"context_line":"This class does not implement the POST operation. List, get, update, and"},{"line_number":68,"context_line":"delete operations are implemented by the usual index, show, update and"},{"line_number":69,"context_line":"delete methods. These method pretty simply call into the quota driver"},{"line_number":70,"context_line":"for either fetching tenant quotas or updating them."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The _update_attributes method is called only once in the controller lifetime."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_7d094994","line":69,"in_reply_to":"ba3cc151_eebb960d","updated":"2015-07-09 08:45:33.000000000","message":"Done","commit_id":"6a8776dfe8207703318a84649353e621de7d2d00"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Quota management and enforcement"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Most resources exposed by the Neutron API are subject to quota limits."},{"line_number":6,"context_line":"The Neutron API exposes an extension for managing such quotas. Quota limits are"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_d919c2d8","line":3,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"resource which has been registered with the Quota engine, regardless of"},{"line_number":29,"context_line":"whether such resource belongs to the core Neutron API or one of its extensions."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"High level view"},{"line_number":32,"context_line":"---------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"There are two main components in the Neutron quota system:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_d967824b","line":31,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"whose task is basically to perform database operations."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Quota management"},{"line_number":69,"context_line":"----------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The quota management component is fairly straightforward."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_f9759ef9","line":69,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"902ff1f756bf841fb74c6cbee3be2ea00d33a1b1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"whose task is basically to perform database operations."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Quota management"},{"line_number":69,"context_line":"----------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The quota management component is fairly straightforward."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_aa203af8","line":69,"in_reply_to":"3a50d1a3_f9759ef9","updated":"2015-07-27 17:05:00.000000000","message":"thanks for noticing this.\nI don\u0027t know honestly why it would be important but I\u0027ll nevertheless do this.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"difference between CountableResource and TrackedResource."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Quota enforcement"},{"line_number":159,"context_line":"-----------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Before dispatching a request to the plugin, the Neutron \u0027base\u0027 controller [#]_"},{"line_number":162,"context_line":"attempts to make a reservation for requested resource(s)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_5954d251","line":159,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"from the database, thus avoiding build-up of expired reservations."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Setting up resource tracking for a plugin"},{"line_number":221,"context_line":"------------------------------------------"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"By default plugins do not leverage resource tracking. Having the plugin"},{"line_number":224,"context_line":"explicitly declare which resources should be tracked is a precise design"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_79cf4e29","line":221,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":14562,"name":"Zhi Chang","email":"changzhi2@lenovo.com","username":"changzhi"},"change_message_id":"1453f567c90a5729afbaa11d2c54263eac90816c","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Exceptions and caveats"},{"line_number":270,"context_line":"-----------------------"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Please be aware of the following limitations of the quota enforcement engine:"},{"line_number":273,"context_line":"* Subnet allocation from subnet pools, in particularly shared pools, is also"},{"line_number":274,"context_line":"subject to quota limit checks. However this checks are not enforced by the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_b9c95628","line":271,"updated":"2015-07-22 10:44:21.000000000","message":"Nit: Capitalize each word in this title sequence.","commit_id":"6d2f14be923092c3d77de05edbb19315006953f7"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"b09f3dd7b1d51d750e21e9f244f22abc566f0759","unresolved":false,"context_lines":[{"line_number":85,"context_line":"used, it is not possible to configure which users should be allowed to manage"},{"line_number":86,"context_line":"quotas using policy.json."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The driver operations dealing with quota management are:"},{"line_number":89,"context_line":"* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027"},{"line_number":90,"context_line":"table for a given tenant identifier;"},{"line_number":91,"context_line":"* update_quota_limit, which adds or updates an entry in the \u0027quotas\u0027 tenant for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a50d1a3_5a3acbce","line":88,"updated":"2015-07-26 23:08:21.000000000","message":"if this is supposed to be a bullet list, then you need a blank line before line 89 and then then indents on 90, 92, and 94 work.\n\nSame comment applies elsewhere where you have what look like bullet lists.\n\nOtherwise, feel free to ignore","commit_id":"282fb7297cc9ac53bb290e3ad7265f7ba2e1898b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"30061ee86462a8ded7a4c89b71a8683bf3122acb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"used, it is not possible to configure which users should be allowed to manage"},{"line_number":86,"context_line":"quotas using policy.json."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The driver operations dealing with quota management are:"},{"line_number":89,"context_line":"* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027"},{"line_number":90,"context_line":"table for a given tenant identifier;"},{"line_number":91,"context_line":"* update_quota_limit, which adds or updates an entry in the \u0027quotas\u0027 tenant for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a50d1a3_ea3f2223","line":88,"in_reply_to":"3a50d1a3_5a3acbce","updated":"2015-07-27 17:04:49.000000000","message":"nah you\u0027re right. I never look at the rendered docs!","commit_id":"282fb7297cc9ac53bb290e3ad7265f7ba2e1898b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"---------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"There are two main components in the Neutron quota system:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The Quota API extension;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The Quota Engine."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_b0e879b4","line":35,"updated":"2015-07-28 14:30:36.000000000","message":"how about (moved up against left margin)\n\n\u003cblank line\u003e\n * The Quota API extension;\n * The Quota Engine.\n\u003cblank line\u003e","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Both components rely on a quota driver. The neutron codebase currently defines"},{"line_number":41,"context_line":"two quota drivers:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* neutron.db.quota.driver.DbQuotaDriver"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* neutron.quota.ConfDriver"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_f0304158","line":42,"updated":"2015-07-28 14:30:36.000000000","message":"and (moved up against left margin)\n\n\u003cblank line\u003e\n * neutron.db.quota.driver.DbQuotaDriver\t\n * neutron.quota.ConfDriver\n\u003cblank line\u003e","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"quotas using policy.json."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The driver operations dealing with quota management are:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027"},{"line_number":95,"context_line":"table for a given tenant identifier;"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_70c8b155","line":93,"updated":"2015-07-28 14:30:36.000000000","message":"and\n\n\u003cblank line\u003e\n* delete_tenant_quota, which simply removes all entries from the \u0027quotas\u0027\n  table for a given tenant identifier,\n* update_quota_limit, which adds or updates an entry in the \u0027quotas\u0027 tenant\n  for a given tenant identifier and a given resource name;\n* _get_quotas, which fetches limits for a set of resource and a given tenant\n  identifier\n* _get_all_quotas, which behaves like _get_quotas, but for all tenants.\n\u003cblank line\u003e","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* Updating the usage counters with the new \u0027correct\u0027 value every time an"},{"line_number":160,"context_line":"operation completes."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Having a periodic task synchronising quota usage data with actual data in"},{"line_number":163,"context_line":"the Neutron DB."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_3099c979","line":161,"updated":"2015-07-28 14:30:36.000000000","message":"and\n\n\u003cblank line\u003e\n* Updating the usage counters with the new \u0027correct\u0027 value every time an\n  operation completes.\n* Having a periodic task synchronising quota usage data with actual data in\n  the Neutron DB.\n\u003cblank line\u003e","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Reservations are made by calling the make_reservation method in"},{"line_number":176,"context_line":"neutron.quota.QuotaEngine."},{"line_number":177,"context_line":"The process of making a reservation is fairly straightforward:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Get current resource usages. This is achieved by invoking the count method"},{"line_number":180,"context_line":"on every requested resource, and then retrieving the amount of reserved"},{"line_number":181,"context_line":"resources."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_b0e95981","line":178,"updated":"2015-07-28 14:30:36.000000000","message":"and\n\n\u003cblank line\u003e\n* Get current resource usages. This is achieved by invoking the count method\n  on every requested resource, and then retrieving the amount of reserved\n  resources.\n* Fetch current quota limits for requested resources, by invoking the\n  _get_tenant_quotas method.\n* Fetch expired reservations for selected resources. This amount will be\n  subtracted from resource usage. As in most cases there won\u0027t be any\n  expired reservation, this approach actually requires less DB operations than\n  doing a sum of non-expired, reserved resources for each request.\n* For each resource calculate its headroom, and verify the requested\t\n  amount of resource is less than the headroom.\t\n* If the above is true for all resource, the reservation is saved in the DB,\n  otherwise an OverQuotaLimit exception is raised.\n\u003cblank line\u003e","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5cb5a49433837178e195b0a4f5fa9264b1411b7","unresolved":false,"context_lines":[{"line_number":287,"context_line":"-----------------------"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Please be aware of the following limitations of the quota enforcement engine:"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* Subnet allocation from subnet pools, in particularly shared pools, is also"},{"line_number":292,"context_line":"subject to quota limit checks. However this checks are not enforced by the"},{"line_number":293,"context_line":"quota engine, but trough a mechanism implemented in the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a50d1a3_b0a07943","line":290,"updated":"2015-07-28 14:30:36.000000000","message":"and (well you get the idea)","commit_id":"b45ca42bb12d4be96ec48e91a3123c7e0624b31b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"68281cc24915b21710ea975fcebc528d739903e3","unresolved":false,"context_lines":[{"line_number":42,"context_line":" * neutron.db.quota.driver.DbQuotaDriver"},{"line_number":43,"context_line":" * neutron.quota.ConfDriver"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The latter driver is however deprecated."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The Quota API extension handles quota management, whereas the Quota Engine"},{"line_number":48,"context_line":"component handles quota enforcement. This API extension is loaded like any"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_032d22fd","line":45,"updated":"2015-07-29 18:02:23.000000000","message":"Should we mention here when we intend to remove it?","commit_id":"1167c7dff80d6726322e24193d15b6abbebcaf4c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"29a8bca14abd85a5d5114208185cf72f87d5e71c","unresolved":false,"context_lines":[{"line_number":42,"context_line":" * neutron.db.quota.driver.DbQuotaDriver"},{"line_number":43,"context_line":" * neutron.quota.ConfDriver"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The latter driver is however deprecated."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The Quota API extension handles quota management, whereas the Quota Engine"},{"line_number":48,"context_line":"component handles quota enforcement. This API extension is loaded like any"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_53405807","line":45,"in_reply_to":"3a50d1a3_032d22fd","updated":"2015-08-01 02:28:45.000000000","message":"+1","commit_id":"1167c7dff80d6726322e24193d15b6abbebcaf4c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"29a8bca14abd85a5d5114208185cf72f87d5e71c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"The Quota API extension handles quota management, whereas the Quota Engine"},{"line_number":48,"context_line":"component handles quota enforcement. This API extension is loaded like any"},{"line_number":49,"context_line":"other extension. For this reason plugins must explicitly support it by including"},{"line_number":50,"context_line":"\"quotas\" in the support_extension_aliases attribute."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"In the Quota API simple CRUD operations are used for managing tenant quotas."},{"line_number":53,"context_line":"Please note that the current behaviour when deleting a tenant quota is to reset"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_3346ec21","line":50,"updated":"2015-08-01 02:28:45.000000000","message":"Is it worth mentioning this in a Neutron meeting or with an email to the ML? If I\u0027ve missed such an email, please ignore my impolite pedantry.","commit_id":"1167c7dff80d6726322e24193d15b6abbebcaf4c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"064cc3cdf0393b71a0d2c5673705819dff5b5e5c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Reservations are not perennial. Eternal reservation would eventually exhaust"},{"line_number":219,"context_line":"tenants\u0027 quotas because they would never be removed when an API worker crashes"},{"line_number":220,"context_line":"whilst in the middle of an operation."},{"line_number":221,"context_line":"Reservation expiration is currently set to 60 seconds, and is not configurable,"},{"line_number":222,"context_line":"not yet at least. Expired reservations are not counted when calculating"},{"line_number":223,"context_line":"resource usage. While creating a reservation, if any expired reservation is"},{"line_number":224,"context_line":"found, all expired reservation for that tenant and resource will be removed"}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a4dcd0f_296c7635","line":221,"updated":"2015-08-14 17:08:36.000000000","message":"I thought the default was 120s?\n\nhttps://review.openstack.org/#/c/163659/22/neutron/db/quota/api.py L202","commit_id":"292d1e35576785b24a5d350aa813bed15cbb2b65"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e20d10312cf76ecbabaab6f7ed88adb473004803","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Reservations are not perennial. Eternal reservation would eventually exhaust"},{"line_number":219,"context_line":"tenants\u0027 quotas because they would never be removed when an API worker crashes"},{"line_number":220,"context_line":"whilst in the middle of an operation."},{"line_number":221,"context_line":"Reservation expiration is currently set to 60 seconds, and is not configurable,"},{"line_number":222,"context_line":"not yet at least. Expired reservations are not counted when calculating"},{"line_number":223,"context_line":"resource usage. While creating a reservation, if any expired reservation is"},{"line_number":224,"context_line":"found, all expired reservation for that tenant and resource will be removed"}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a4dcd0f_718d69d2","line":221,"in_reply_to":"1a4dcd0f_296c7635","updated":"2015-08-16 03:46:32.000000000","message":"I asked this question on the code side in prior patchsets and it\u0027s still not quite resolved one way or the other","commit_id":"292d1e35576785b24a5d350aa813bed15cbb2b65"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7019751ab1a79827cf51caa7ecb15180ab31a71d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Reservations are not perennial. Eternal reservation would eventually exhaust"},{"line_number":219,"context_line":"tenants\u0027 quotas because they would never be removed when an API worker crashes"},{"line_number":220,"context_line":"whilst in the middle of an operation."},{"line_number":221,"context_line":"Reservation expiration is currently set to 60 seconds, and is not configurable,"},{"line_number":222,"context_line":"not yet at least. Expired reservations are not counted when calculating"},{"line_number":223,"context_line":"resource usage. While creating a reservation, if any expired reservation is"},{"line_number":224,"context_line":"found, all expired reservation for that tenant and resource will be removed"}],"source_content_type":"text/x-rst","patch_set":19,"id":"fa1b9901_d9b6133d","line":221,"in_reply_to":"1a4dcd0f_718d69d2","updated":"2015-08-17 22:40:07.000000000","message":"I do apologize for this.\nI am a mess and I should be hanged upside down.","commit_id":"292d1e35576785b24a5d350aa813bed15cbb2b65"}]}
