)]}'
{"neutron/tests/functional/agent/test_firewall.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0a76e8cb03c5fdd8e1c36cb5de59e288649f1912","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                         direction\u003dself.tester.INGRESS)"},{"line_number":103,"context_line":"        self.tester.assert_no_connection(self.tester.EGRESS,"},{"line_number":104,"context_line":"                                         protocol\u003dself.tester.TCP)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_port_security_enabled_set_to_false(self):"},{"line_number":107,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":108,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a308872e","line":105,"updated":"2015-06-16 09:08:50.000000000","message":"test case that shows mac spoofing works without port security enabled?","commit_id":"52ef79610e6e804096dbc7eb4c7b05dbad5da605"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f977bd0bbff321101003922a35a70afbae166d1c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                         direction\u003dself.tester.INGRESS)"},{"line_number":103,"context_line":"        self.tester.assert_no_connection(self.tester.EGRESS,"},{"line_number":104,"context_line":"                                         protocol\u003dself.tester.TCP)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_port_security_enabled_set_to_false(self):"},{"line_number":107,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":108,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_fe3708ae","line":105,"in_reply_to":"fa32b979_a308872e","updated":"2015-06-16 09:17:36.000000000","message":"Yep, good idea.","commit_id":"52ef79610e6e804096dbc7eb4c7b05dbad5da605"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0a76e8cb03c5fdd8e1c36cb5de59e288649f1912","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        self._apply_security_group_rules(list())"},{"line_number":248,"context_line":"        self.tester.assert_established_connection(**connection)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_preventing_firewall_blink(self):"},{"line_number":251,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_43073b1c","line":250,"updated":"2015-06-16 09:08:50.000000000","message":"?","commit_id":"52ef79610e6e804096dbc7eb4c7b05dbad5da605"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f977bd0bbff321101003922a35a70afbae166d1c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        self._apply_security_group_rules(list())"},{"line_number":248,"context_line":"        self.tester.assert_established_connection(**connection)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_preventing_firewall_blink(self):"},{"line_number":251,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5eedd4ed","line":250,"in_reply_to":"fa32b979_43073b1c","updated":"2015-06-16 09:17:36.000000000","message":"Sorry, I forgot to mark this patch as WIP :) I will need to make some helper that will be capable of sending icmp echos asynchronously. While we update firewall, no icmp packet should get in.","commit_id":"52ef79610e6e804096dbc7eb4c7b05dbad5da605"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a3ee8333525be619bd119ce21e1856d54cc7317e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":288,"context_line":"                     \u0027protocol\u0027: \u0027tcp\u0027}]"},{"line_number":289,"context_line":"        self.tester.start_sending_icmp(direction)"},{"line_number":290,"context_line":"        self._apply_security_group_rules({})"},{"line_number":291,"context_line":"        self._apply_security_group_rules(sg_rules)"},{"line_number":292,"context_line":"        self.tester.stop_sending_icmp(direction)"},{"line_number":293,"context_line":"        packets_received \u003d self.tester.get_received_icmp_packets(direction)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_a2502cd5","line":290,"updated":"2015-06-17 18:32:48.000000000","message":"What ensures packets are send after sg rules applications? \n\nWhat ensures self.tester.get_sent_icmp_packets(...) \u003e0?","commit_id":"f9acd6d8aa668bcf59aafd17f68c7d181b2a6b2a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"476634876251be2b5536eaad25e92e57d64c41f5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":288,"context_line":"                     \u0027protocol\u0027: \u0027tcp\u0027}]"},{"line_number":289,"context_line":"        self.tester.start_sending_icmp(direction)"},{"line_number":290,"context_line":"        self._apply_security_group_rules({})"},{"line_number":291,"context_line":"        self._apply_security_group_rules(sg_rules)"},{"line_number":292,"context_line":"        self.tester.stop_sending_icmp(direction)"},{"line_number":293,"context_line":"        packets_received \u003d self.tester.get_received_icmp_packets(direction)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_269e42b9","line":290,"in_reply_to":"fa32b979_a2502cd5","updated":"2015-06-18 15:24:18.000000000","message":"1) The nature of Pinger class.\n\n2) Hmm, the same answer. I\u0027ll add an assert there to be sure.","commit_id":"f9acd6d8aa668bcf59aafd17f68c7d181b2a6b2a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b6b594df0158c1897ef0f1d5bf7271892a589f28","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.firewall \u003d getattr(self, self.create_firewall)()"},{"line_number":58,"context_line":"        vm_mac \u003d self.tester.vm_mac_address"},{"line_number":59,"context_line":"        vm_port_id \u003d self.tester.vm_port_id"},{"line_number":60,"context_line":"        self.src_port_desc \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":61,"context_line":"                              \u0027device\u0027: vm_port_id,"},{"line_number":62,"context_line":"                              \u0027device_owner\u0027: \u0027compute:None\u0027,"},{"line_number":63,"context_line":"                              \u0027fixed_ips\u0027: [self.tester.vm_ip_address],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_8e129857","line":60,"updated":"2015-06-19 14:05:21.000000000","message":"nit: _make_port_dict where you pass all the parameters or the tester itself?","commit_id":"2c2b107717cbcb7e8b90d64fa701856f328b1693"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c954c243c2e82bbb6d55f430895353a28420d3cd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.firewall \u003d getattr(self, self.create_firewall)()"},{"line_number":58,"context_line":"        vm_mac \u003d self.tester.vm_mac_address"},{"line_number":59,"context_line":"        vm_port_id \u003d self.tester.vm_port_id"},{"line_number":60,"context_line":"        self.src_port_desc \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":61,"context_line":"                              \u0027device\u0027: vm_port_id,"},{"line_number":62,"context_line":"                              \u0027device_owner\u0027: \u0027compute:None\u0027,"},{"line_number":63,"context_line":"                              \u0027fixed_ips\u0027: [self.tester.vm_ip_address],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_0e36a102","line":60,"in_reply_to":"fa32b979_8e129857","updated":"2015-06-25 15:10:27.000000000","message":"Yeah, good idea. I\u0027ll reuse it when testing remote group ids which will require to define the same on peer side.","commit_id":"2c2b107717cbcb7e8b90d64fa701856f328b1693"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"4ed3f67f21f66ba62803fbd5cdbccb44858ba71e","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._apply_security_group_rules(list())"},{"line_number":283,"context_line":"        self.tester.assert_established_connection(**connection)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_preventing_firewall_blink(self):"},{"line_number":286,"context_line":"        direction \u003d self.tester.INGRESS"},{"line_number":287,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_8ae024ce","line":284,"updated":"2015-06-26 16:38:34.000000000","message":"Here\u0027s an idea: Move the new async Pinger class and this test out to a new patch.\n\nPreviously:\n  Pinger\n  conn_testers\n  this_patch\n\nWith my suggestion:\n  conn_testers\n  this_patch_without_test_preventing_firewall_blink\n  patch_that_adds_test_preventing_firewall_blink_plus_Pinger_class\n\nThis will let us merge patches in this series faster, it also makes the patch ordering more correct. You don\u0027t really need the Pinger class for 99% of this patch.","commit_id":"2c2b107717cbcb7e8b90d64fa701856f328b1693"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7c713120e37ed4e0d2d4dba276d5c2593af7e08d","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._apply_security_group_rules(list())"},{"line_number":283,"context_line":"        self.tester.assert_established_connection(**connection)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_preventing_firewall_blink(self):"},{"line_number":286,"context_line":"        direction \u003d self.tester.INGRESS"},{"line_number":287,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_9ff84c4b","line":284,"in_reply_to":"fa32b979_8ae024ce","updated":"2015-06-30 12:36:28.000000000","message":"Done","commit_id":"2c2b107717cbcb7e8b90d64fa701856f328b1693"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c3c9b5ddfce4ad3fbd3eabd1c2649c219670b108","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation."},{"line_number":2,"context_line":"# Copyright 2015 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"},{"line_number":3,"context_line":"#                               \u003cisaku.yamahata at gmail com\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_f3784480","line":1,"updated":"2015-07-08 21:32:52.000000000","message":"You\u0027re giving copyright on a lot of new code here that was not written by Intel or Isaku. You could add a Red Hat copyright to solve this.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"13e21533086ee58b816486e94187df4b5bdedaca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel Corporation."},{"line_number":2,"context_line":"# Copyright 2015 Isaku Yamahata \u003cisaku.yamahata at intel com\u003e"},{"line_number":3,"context_line":"#                               \u003cisaku.yamahata at gmail com\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_c0a66caa","line":1,"in_reply_to":"ba3cc151_f3784480","updated":"2015-07-09 09:13:06.000000000","message":"I could but I don\u0027t understand what is it good for. Note that this file is moved from original neutron/tests/functional/agent/linux/test_iptables_firewall.py but gerrit doesn\u0027t show it as moved.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c3c9b5ddfce4ad3fbd3eabd1c2649c219670b108","unresolved":false,"context_lines":[{"line_number":42,"context_line":"class FirewallTestCase(base.BaseSudoTestCase):"},{"line_number":43,"context_line":"    FAKE_SECURITY_GROUP_ID \u003d \u0027fake_sg_id\u0027"},{"line_number":44,"context_line":"    scenarios \u003d [(\u0027IptablesFirewallDriver without ipset\u0027,"},{"line_number":45,"context_line":"                  {\u0027create_firewall\u0027: \u0027create_iptables_firewall\u0027,"},{"line_number":46,"context_line":"                   \u0027firewall_tester\u0027: conn_testers.LinuxBridgeConnectionTester,"},{"line_number":47,"context_line":"                   \u0027enable_ipset\u0027: False}"},{"line_number":48,"context_line":"                  ),"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_33d1cc57","line":45,"updated":"2015-07-08 21:32:52.000000000","message":"Seems like these two scenarios only differ by enable_ipset so you can just remove the other two keys for now.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"13e21533086ee58b816486e94187df4b5bdedaca","unresolved":false,"context_lines":[{"line_number":42,"context_line":"class FirewallTestCase(base.BaseSudoTestCase):"},{"line_number":43,"context_line":"    FAKE_SECURITY_GROUP_ID \u003d \u0027fake_sg_id\u0027"},{"line_number":44,"context_line":"    scenarios \u003d [(\u0027IptablesFirewallDriver without ipset\u0027,"},{"line_number":45,"context_line":"                  {\u0027create_firewall\u0027: \u0027create_iptables_firewall\u0027,"},{"line_number":46,"context_line":"                   \u0027firewall_tester\u0027: conn_testers.LinuxBridgeConnectionTester,"},{"line_number":47,"context_line":"                   \u0027enable_ipset\u0027: False}"},{"line_number":48,"context_line":"                  ),"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_a0fa4841","line":45,"in_reply_to":"ba3cc151_33d1cc57","updated":"2015-07-09 09:13:06.000000000","message":"*sigh* I don\u0027t understand what is the benefit of removing it and putting back later. I understand that YAGNI is a cool and in name these days but technically it doesn\u0027t harm to have things general. (I read interesting essay about yagni couple weeks ago and I found myself mostly agreeing. But I can\u0027t find the link.).","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c3c9b5ddfce4ad3fbd3eabd1c2649c219670b108","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   \u0027enable_ipset\u0027: True})]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def create_iptables_firewall(self):"},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027enable_ipset\u0027, self.enable_ipset,"},{"line_number":56,"context_line":"                              \u0027SECURITYGROUP\u0027)"},{"line_number":57,"context_line":"        return iptables_firewall.IptablesFirewallDriver("},{"line_number":58,"context_line":"            namespace\u003dself.tester.bridge_namespace)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_3338ec9f","line":55,"updated":"2015-07-08 21:32:52.000000000","message":"This should probably be set in setUp, not here.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"13e21533086ee58b816486e94187df4b5bdedaca","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   \u0027enable_ipset\u0027: True})]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def create_iptables_firewall(self):"},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027enable_ipset\u0027, self.enable_ipset,"},{"line_number":56,"context_line":"                              \u0027SECURITYGROUP\u0027)"},{"line_number":57,"context_line":"        return iptables_firewall.IptablesFirewallDriver("},{"line_number":58,"context_line":"            namespace\u003dself.tester.bridge_namespace)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_20e5d8da","line":55,"in_reply_to":"ba3cc151_3338ec9f","updated":"2015-07-09 09:13:06.000000000","message":"setUp() shouldn\u0027t be firewall specific but generic.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c3c9b5ddfce4ad3fbd3eabd1c2649c219670b108","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _apply_security_group_rules(self, sg_id, sg_rules):"},{"line_number":84,"context_line":"        with self.firewall.defer_apply():"},{"line_number":85,"context_line":"            self.firewall.update_security_group_rules(sg_id, sg_rules)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_ingress_icmp_secgroup(self):"},{"line_number":88,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_f30b64d3","line":85,"updated":"2015-07-08 21:32:52.000000000","message":"Should we also have coverage for the addition or removal of SG members? (Not in this patch though, it\u0027s large enough :)","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"13e21533086ee58b816486e94187df4b5bdedaca","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _apply_security_group_rules(self, sg_id, sg_rules):"},{"line_number":84,"context_line":"        with self.firewall.defer_apply():"},{"line_number":85,"context_line":"            self.firewall.update_security_group_rules(sg_id, sg_rules)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_ingress_icmp_secgroup(self):"},{"line_number":88,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_20fcf870","line":85,"in_reply_to":"ba3cc151_f30b64d3","updated":"2015-07-09 09:13:06.000000000","message":"Good idea, adding to my todo list. More stripes(tests) we have more adidas it gets. I\u0027m also thinking we should make this test more CRUD oriented.","commit_id":"0bf4ba3f5884079e47d4db2cf17bcde88b48c189"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ddf3ecebc0a3a10c2ec8221e3aea4d3a438f0543","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_ingress_icmp_secgroup(self):"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        setup firewall on bridge and send packet from src_veth and observe"},{"line_number":87,"context_line":"        if sent packet can be observed on dst_veth"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_4fb7bf20","line":86,"updated":"2015-09-07 22:29:34.000000000","message":"The correct format for docstring is:\n\n \"\"\"\u003cTITLE\u003e\n\n \u003cDETAILS\u003e\n \"\"\"","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4c53ae5b284393985203b0cf41cbc61aaef30fc6","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_ingress_icmp_secgroup(self):"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        setup firewall on bridge and send packet from src_veth and observe"},{"line_number":87,"context_line":"        if sent packet can be observed on dst_veth"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_dd906445","line":86,"in_reply_to":"da20952f_4fb7bf20","updated":"2015-09-08 06:40:50.000000000","message":"+1","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"167f32ee20a101c87722e1ee4ccc564c096aeb4d","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_ingress_icmp_secgroup(self):"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        setup firewall on bridge and send packet from src_veth and observe"},{"line_number":87,"context_line":"        if sent packet can be observed on dst_veth"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_b38281fd","line":86,"in_reply_to":"da20952f_dd906445","updated":"2015-09-08 08:08:46.000000000","message":"I will remove this docstring, I think it\u0027s obvious from test method name what\u0027s going on. The original documentation is taken from https://review.openstack.org/#/c/191148/11/neutron/tests/functional/agent/linux/test_iptables_firewall.py where it was done as a comment.","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ddf3ecebc0a3a10c2ec8221e3aea4d3a438f0543","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.tester.assert_no_connection(protocol\u003dself.tester.ICMP,"},{"line_number":115,"context_line":"                                         direction\u003dself.tester.EGRESS)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_mac_spoofing_works_wihout_port_security_enabled(self):"},{"line_number":118,"context_line":"        mac_spoofed \u003d \"fa:16:3e:9a:2f:48\""},{"line_number":119,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":120,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_6f6ac3b4","line":117,"updated":"2015-09-07 22:29:34.000000000","message":"wihout \u003d\u003e without","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"167f32ee20a101c87722e1ee4ccc564c096aeb4d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.tester.assert_no_connection(protocol\u003dself.tester.ICMP,"},{"line_number":115,"context_line":"                                         direction\u003dself.tester.EGRESS)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_mac_spoofing_works_wihout_port_security_enabled(self):"},{"line_number":118,"context_line":"        mac_spoofed \u003d \"fa:16:3e:9a:2f:48\""},{"line_number":119,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":120,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_d3905545","line":117,"in_reply_to":"da20952f_6f6ac3b4","updated":"2015-09-08 08:08:46.000000000","message":"Good eye!","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ddf3ecebc0a3a10c2ec8221e3aea4d3a438f0543","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_port_security_enabled_set_to_false(self):"},{"line_number":132,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":133,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"},{"line_number":134,"context_line":"        self.tester.assert_connection(protocol\u003dself.tester.ICMP,"},{"line_number":135,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_0fd54741","line":133,"updated":"2015-09-07 22:29:34.000000000","message":"imo, we should that update_port_filter really updates something by performing an assert_no_connection before update_port_filter call. Thoughts?","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"167f32ee20a101c87722e1ee4ccc564c096aeb4d","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_port_security_enabled_set_to_false(self):"},{"line_number":132,"context_line":"        self.src_port_desc[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":133,"context_line":"        self.firewall.update_port_filter(self.src_port_desc)"},{"line_number":134,"context_line":"        self.tester.assert_connection(protocol\u003dself.tester.ICMP,"},{"line_number":135,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_73514961","line":133,"in_reply_to":"da20952f_0fd54741","updated":"2015-09-08 08:08:46.000000000","message":"Done","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ddf3ecebc0a3a10c2ec8221e3aea4d3a438f0543","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_dhcp_requests_from_vm(self):"},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        DHCP uses source port 67, destination port 68 on ipv4"},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        # DHCPv4"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_0f3c6791","line":138,"updated":"2015-09-07 22:29:34.000000000","message":"itto","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"167f32ee20a101c87722e1ee4ccc564c096aeb4d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_dhcp_requests_from_vm(self):"},{"line_number":138,"context_line":"        \"\"\""},{"line_number":139,"context_line":"        DHCP uses source port 67, destination port 68 on ipv4"},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        # DHCPv4"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_13d9ed21","line":138,"in_reply_to":"da20952f_0f3c6791","updated":"2015-09-08 08:08:46.000000000","message":"Done","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ddf3ecebc0a3a10c2ec8221e3aea4d3a438f0543","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_ingress_rule(self):"},{"line_number":232,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def test_egress_rule(self):"},{"line_number":235,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_0f6307b2","line":233,"updated":"2015-09-07 22:29:34.000000000","message":"when i see test_ingress/egress_rule i am wondering if it\u0027s normally that they check different protocols","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"167f32ee20a101c87722e1ee4ccc564c096aeb4d","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_ingress_rule(self):"},{"line_number":232,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def test_egress_rule(self):"},{"line_number":235,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_f37d59e7","line":233,"in_reply_to":"da20952f_0f6307b2","updated":"2015-09-08 08:08:46.000000000","message":"Do you think permutations will bring better coverage in contrast to used resources? From my experience it can reveal bugs - like https://bugs.launchpad.net/neutron/+bug/1478847","commit_id":"12fea8ee765c39a45922521b77abc0856ee8209a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"51b02d7a7c147405ba7f3a32cf7b9c30a0053d99","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # update the sg_group to make ping pass"},{"line_number":86,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":87,"context_line":"                     \u0027protocol\u0027: \u0027icmp\u0027},"},{"line_number":88,"context_line":"                    {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027egress\u0027}]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.tester.assert_no_connection(protocol\u003dself.tester.ICMP,"},{"line_number":91,"context_line":"                                         direction\u003dself.tester.INGRESS)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_323420dd","line":88,"updated":"2015-09-12 15:02:14.000000000","message":"The ingress and egress rule are used again and again in file. You should avoid duplicated definition.","commit_id":"37fbee2d429eff8b6485f44fa54031f601d70dcf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c7dff68909cbff80433d9611697b69cfe8bf1a46","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # update the sg_group to make ping pass"},{"line_number":86,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":87,"context_line":"                     \u0027protocol\u0027: \u0027icmp\u0027},"},{"line_number":88,"context_line":"                    {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027egress\u0027}]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.tester.assert_no_connection(protocol\u003dself.tester.ICMP,"},{"line_number":91,"context_line":"                                         direction\u003dself.tester.INGRESS)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_a75f7f0d","line":88,"in_reply_to":"ba15a1d1_323420dd","updated":"2015-09-14 10:57:54.000000000","message":"Done","commit_id":"37fbee2d429eff8b6485f44fa54031f601d70dcf"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"51b02d7a7c147405ba7f3a32cf7b9c30a0053d99","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_mac_spoofing(self):"},{"line_number":97,"context_line":"        mac_spoofed \u003d \"fa:16:3e:9a:2f:48\""},{"line_number":98,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":99,"context_line":"                     \u0027protocol\u0027: \u0027icmp\u0027},"},{"line_number":100,"context_line":"                    {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027egress\u0027}]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_670c1c43","line":97,"updated":"2015-09-12 15:02:14.000000000","message":"In test_iptables_firewall, it\u0027s prepared as global various (MAC_SPOOFED) and it\u0027s able to be used repeatedly. Why did you change?","commit_id":"37fbee2d429eff8b6485f44fa54031f601d70dcf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c7dff68909cbff80433d9611697b69cfe8bf1a46","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                      direction\u003dself.tester.INGRESS)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_mac_spoofing(self):"},{"line_number":97,"context_line":"        mac_spoofed \u003d \"fa:16:3e:9a:2f:48\""},{"line_number":98,"context_line":"        sg_rules \u003d [{\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":99,"context_line":"                     \u0027protocol\u0027: \u0027icmp\u0027},"},{"line_number":100,"context_line":"                    {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027direction\u0027: \u0027egress\u0027}]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_67a087f5","line":97,"in_reply_to":"ba15a1d1_670c1c43","updated":"2015-09-14 10:57:54.000000000","message":"I think previously there was just a single test, thus having MAC_SPOOFED on class level was YAGNI.","commit_id":"37fbee2d429eff8b6485f44fa54031f601d70dcf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c3e7f2100ba1bb017eeb7c50dd9031e62059eba6","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                         direction\u003dnot_allowed_direction)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def test_ingress_rule(self):"},{"line_number":226,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_egress_rule(self):"},{"line_number":229,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_0e9d4065","line":226,"updated":"2015-09-08 08:24:37.000000000","message":"For reviewers: Please see Cedric\u0027s comment in previous PS and share your opinions :)","commit_id":"37fbee2d429eff8b6485f44fa54031f601d70dcf"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"06ac39c3cfec1b316b9eabee0b849bad16888593","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    proto \u003d \u0027ipv6-icmp\u0027"},{"line_number":104,"context_line":"                base \u003d {\u0027ethertype\u0027: version, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":105,"context_line":"                        \u0027protocol\u0027: proto}"},{"line_number":106,"context_line":"                sg_rules.append(copy.copy(base))"},{"line_number":107,"context_line":"                base[\u0027port_range_min\u0027] \u003d 50"},{"line_number":108,"context_line":"                base[\u0027port_range_max\u0027] \u003d 50"},{"line_number":109,"context_line":"                sg_rules.append(copy.copy(base))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_c6ee8421","line":106,"updated":"2015-12-03 11:07:00.000000000","message":"I know this code is not original from you, but if you have to respin: what about having an aux function create the rules, with optional port_range_min and port_range_max ?","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e05fda5a41e1c4e0ae27740838ff9927b735d051","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    proto \u003d \u0027ipv6-icmp\u0027"},{"line_number":104,"context_line":"                base \u003d {\u0027ethertype\u0027: version, \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":105,"context_line":"                        \u0027protocol\u0027: proto}"},{"line_number":106,"context_line":"                sg_rules.append(copy.copy(base))"},{"line_number":107,"context_line":"                base[\u0027port_range_min\u0027] \u003d 50"},{"line_number":108,"context_line":"                base[\u0027port_range_max\u0027] \u003d 50"},{"line_number":109,"context_line":"                sg_rules.append(copy.copy(base))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_5d07b1c9","line":106,"in_reply_to":"9a8ffd7b_c6ee8421","updated":"2015-12-03 14:51:30.000000000","message":"Done","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"06ac39c3cfec1b316b9eabee0b849bad16888593","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def test_ingress_rule(self):"},{"line_number":348,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_egress_rule(self):"},{"line_number":351,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_7180b0f7","line":349,"updated":"2015-12-03 11:07:00.000000000","message":"looking at previous Cedric comments:\nwhat about trying ingress + tcp \u0026 ingress + udp ?","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e05fda5a41e1c4e0ae27740838ff9927b735d051","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def test_ingress_rule(self):"},{"line_number":348,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_egress_rule(self):"},{"line_number":351,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_692d1ffd","line":349,"in_reply_to":"9a8ffd7b_7180b0f7","updated":"2015-12-03 14:51:30.000000000","message":"Done","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"06ac39c3cfec1b316b9eabee0b849bad16888593","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_egress_rule(self):"},{"line_number":351,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def test_connection_with_destination_port_range(self):"},{"line_number":354,"context_line":"        port_min \u003d 12345"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_b1913849","line":351,"updated":"2015-12-03 11:07:00.000000000","message":"and then\negress + tcp \u0026 egress + udp ?","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e05fda5a41e1c4e0ae27740838ff9927b735d051","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        self._test_rule(self.tester.INGRESS, self.tester.TCP)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_egress_rule(self):"},{"line_number":351,"context_line":"        self._test_rule(self.tester.EGRESS, self.tester.UDP)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def test_connection_with_destination_port_range(self):"},{"line_number":354,"context_line":"        port_min \u003d 12345"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_89308357","line":351,"in_reply_to":"9a8ffd7b_b1913849","updated":"2015-12-03 14:51:30.000000000","message":"Done","commit_id":"a8cf1a513df115e6c50486851558baceed3a6f1b"}]}
