)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"044c34794168bd06eb4ed22e3c33e89d17e0eb8f","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush_all(self):"},{"line_number":628,"context_line":"        \"\"\"Flush ARP table"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_934edc94","line":627,"updated":"2015-06-16 17:12:24.000000000","message":"This should support IPv6 as well, just like the other methods here.  The best option would be to change this to be called \u0027flush\u0027 and have two arguments, \u0027to\u0027 and \u0027ip_version\u0027","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ef444ca3e08dd688fa26762bce16f808b7f2f152","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush_all(self):"},{"line_number":628,"context_line":"        \"\"\"Flush ARP table"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c9e497e2","line":627,"in_reply_to":"fa32b979_934edc94","updated":"2015-06-17 08:55:44.000000000","message":"IIUC to is an address that will be flushed. I think we can determine ip_version from the address, right?","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1e42a618ff4c520dcc5d57a692ec59551044cbfd","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush_all(self):"},{"line_number":628,"context_line":"        \"\"\"Flush ARP table"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_08d2675c","line":627,"in_reply_to":"fa32b979_acf03668","updated":"2015-06-17 14:46:57.000000000","message":"Ack, I\u0027m not familiar with this command well so sorry for stupid questions :)","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51b9393f22566df754d7f6895f458b2fd52940a9","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush_all(self):"},{"line_number":628,"context_line":"        \"\"\"Flush ARP table"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_acf03668","line":627,"in_reply_to":"fa32b979_c9e497e2","updated":"2015-06-17 13:16:00.000000000","message":"We could if it was always an address, but if it\u0027s \"all\" what do we do?","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"044c34794168bd06eb4ed22e3c33e89d17e0eb8f","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"},{"line_number":631,"context_line":"        \"\"\""},{"line_number":632,"context_line":"        self._as_root([4], (\u0027flush\u0027, \u0027all\u0027))"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"class IpNetnsCommand(IpCommandBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5e0dbb35","line":632,"updated":"2015-06-16 17:12:24.000000000","message":"self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, to))","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ef444ca3e08dd688fa26762bce16f808b7f2f152","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        NOTE: ARP is used in IPv4 only"},{"line_number":631,"context_line":"        \"\"\""},{"line_number":632,"context_line":"        self._as_root([4], (\u0027flush\u0027, \u0027all\u0027))"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"class IpNetnsCommand(IpCommandBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_89ea0fab","line":632,"in_reply_to":"fa32b979_5e0dbb35","updated":"2015-06-17 08:55:44.000000000","message":"Done","commit_id":"0e1f071cef88fdafac6fdd6a6d6c524f63c66809"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a9aff7ae99753d01991f002f2e314b5f11273564","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, to):"},{"line_number":628,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, to))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_86ec15f4","line":627,"updated":"2015-06-17 21:01:57.000000000","message":"May be something different to \"to\" is more descriptive, I had to read the manual to understand what was \"to\" for.\n\nto-\u003eaddress_prefix ?\n\nA bit of docstring?","commit_id":"4a0428e00e299b1cc371b2d04e481d9180d7a2b0"},{"author":{"_account_id":16908,"name":"TianHuan","email":"tianhuan@unitedstack.com","username":"tianhuan"},"change_message_id":"fcd70a800d4dc9fea3539ecc5b7661d930e2cfa8","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, to):"},{"line_number":628,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, to))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c4320aa7","line":627,"updated":"2015-06-18 05:43:12.000000000","message":"ditto.","commit_id":"4a0428e00e299b1cc371b2d04e481d9180d7a2b0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a174efbf6b858a21082af48fe67bc2b00a8932d1","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, to):"},{"line_number":628,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, to))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_846949fb","line":627,"in_reply_to":"fa32b979_6a11845c","updated":"2015-06-18 15:19:16.000000000","message":"Done","commit_id":"4a0428e00e299b1cc371b2d04e481d9180d7a2b0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c229c3e3b5ee5976a0f861c563cdb2233d69295f","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, to):"},{"line_number":628,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, to))"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_6a11845c","line":627,"in_reply_to":"fa32b979_86ec15f4","updated":"2015-06-18 08:50:31.000000000","message":"I\u0027ll copy\u0026paste the text from man. Maybe address would be more accurate? I don\u0027t know, actually how I use it is to flush all entries, so it\u0027s called flush(4, \u0027all\u0027), and \u0027all\u0027 is not an address :)","commit_id":"4a0428e00e299b1cc371b2d04e481d9180d7a2b0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"48aa95a786e292e797e2e941612c6b654361dc61","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        According given address enrty is removed from neighbours list (ARP or"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_0033c5f6","line":627,"updated":"2015-06-19 07:10:14.000000000","message":"Sorry to go straight to the bike shed with this one, but flush shows up in our codebase quite a bit in the context of sql and it means something quite different from deleting an entry. Even though the ARP command is \u0027flush\u0027, what do you think of making this function more explicit by calling it \u0027remove\u0027 or \u0027delete\u0027?","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1c5dd129f257ea58ccf9694a97e091bf881e9122","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        According given address enrty is removed from neighbours list (ARP or"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_b6b26005","line":627,"in_reply_to":"fa32b979_0033c5f6","updated":"2015-06-19 10:30:20.000000000","message":"I think the method names are corresponding with parameters of \u0027ip\u0027 command. Also note that there exists \u0027delete\u0027 parameter in \u0027ip-neighbour\u0027 command so it might be confusing I guess.","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a2c91755c27108423f52c4c7002e8cf1664686a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        According given address enrty is removed from neighbours list (ARP or"},{"line_number":631,"context_line":"        NDP entries). To flush all entries pass string \u0027all\u0027 as an address."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_dacc098b","line":630,"updated":"2015-06-18 16:46:00.000000000","message":"I think with just a few textual nits I\u0027m fine with this, perhaps:\n\n\"Given address entry is removed from neighbour cache (ARP or NDP)\"","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1c5dd129f257ea58ccf9694a97e091bf881e9122","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        According given address enrty is removed from neighbours list (ARP or"},{"line_number":631,"context_line":"        NDP entries). To flush all entries pass string \u0027all\u0027 as an address."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_b6aee07f","line":630,"in_reply_to":"fa32b979_dacc098b","updated":"2015-06-19 10:30:20.000000000","message":"Done","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a2c91755c27108423f52c4c7002e8cf1664686a","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        NDP entries). To flush all entries pass string \u0027all\u0027 as an address."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"},{"line_number":634,"context_line":"        :param address: The prefix selecting the neighbours to list"},{"line_number":635,"context_line":"        \"\"\""},{"line_number":636,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, address))"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_dadba97a","line":634,"updated":"2015-06-18 16:46:00.000000000","message":"s/list/flush","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1c5dd129f257ea58ccf9694a97e091bf881e9122","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        NDP entries). To flush all entries pass string \u0027all\u0027 as an address."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"},{"line_number":634,"context_line":"        :param address: The prefix selecting the neighbours to list"},{"line_number":635,"context_line":"        \"\"\""},{"line_number":636,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027to\u0027, address))"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_56a9947a","line":634,"in_reply_to":"fa32b979_dadba97a","updated":"2015-06-19 10:30:20.000000000","message":"Eh, I copied it from man page \u0027show\u0027 section :)","commit_id":"72eed7ed48d5ca17759da2a61715d149971b4d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56223e69970243eba5f38814106480e54fb6f516","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        Given address entry is removed from neighbour cache (ARP or NDP). To"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_6e1634f3","line":627,"updated":"2015-06-19 14:00:04.000000000","message":"nit: s/address/ip_address to match the others here, but I wouldn\u0027t hold it for that, only if you update.  Don\u0027t know how my nit-finder didn\u0027t see that :)","commit_id":"8ebe21cc00ef27c2fb1c043578f7270d436da828"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"20518c4bb8323af39dddf914dab682dbeb581e91","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        Given address entry is removed from neighbour cache (ARP or NDP). To"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_2446d37b","line":627,"in_reply_to":"fa32b979_5a03e476","updated":"2015-06-27 16:32:01.000000000","message":"Done","commit_id":"8ebe21cc00ef27c2fb1c043578f7270d436da828"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbfce96af8f7979f80b8d903cf40d45a94b27c01","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        Given address entry is removed from neighbour cache (ARP or NDP). To"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_73193c22","line":627,"in_reply_to":"fa32b979_6e1634f3","updated":"2015-06-19 14:27:17.000000000","message":"I find address better as technically \u0027all\u0027 is not an ip address :) Also this is what is used in man page for ip-neighbour.","commit_id":"8ebe21cc00ef27c2fb1c043578f7270d436da828"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7d2ce5f194ffe876c189de9398d38cce0363c476","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                             (\u0027show\u0027,"},{"line_number":625,"context_line":"                              \u0027dev\u0027, self.name))"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def flush(self, ip_version, address):"},{"line_number":628,"context_line":"        \"\"\"Flush neighbour entries"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        Given address entry is removed from neighbour cache (ARP or NDP). To"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_5a03e476","line":627,"in_reply_to":"fa32b979_73193c22","updated":"2015-06-19 17:09:45.000000000","message":"+1 for ip_address as address can refer to an ip address or a mac address (even more in ARP/NDP context).","commit_id":"8ebe21cc00ef27c2fb1c043578f7270d436da828"}]}