)]}'
{"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":438,"context_line":"        return port"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":441,"context_line":"        session \u003d context.session"},{"line_number":442,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":443,"context_line":"            port \u003d super(LinuxBridgePluginV2, self).get_port(context,"},{"line_number":444,"context_line":"                                                             id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Ff5I%3D","line":441,"updated":"2013-01-18 11:06:09.000000000","message":"I don\u0027t have a big problem with the above line, but as you\u0027re using session only once probably we do not have a huge case for this assignment. (same for line 451)","commit_id":"4cfcfbd3503e1c28b7cdac4991f196d7d9779ae3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"95d347964c0c3fe33e75f0fa7e405cd71cef7176","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        return port"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":441,"context_line":"        session \u003d context.session"},{"line_number":442,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":443,"context_line":"            port \u003d super(LinuxBridgePluginV2, self).get_port(context,"},{"line_number":444,"context_line":"                                                             id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fe7Q%3D","line":441,"in_reply_to":"AAAAM3%2F%2Ff5I%3D","updated":"2013-01-19 02:47:35.000000000","message":"Done","commit_id":"4cfcfbd3503e1c28b7cdac4991f196d7d9779ae3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":456,"context_line":"            #TODO(nati) filter by security group"},{"line_number":457,"context_line":"            for port in ports:"},{"line_number":458,"context_line":"                self._extend_port_dict_security_group(context, port)"},{"line_number":459,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":460,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def create_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Ff5Q%3D","line":459,"updated":"2013-01-18 11:06:09.000000000","message":"I would probably consider doing the the self._fields call inside this loop, thus avoiding the second one.\n\nI know this is unrelated to your patch, but if you think that\u0027s worth, please do it. Otherwise just ignore this comment.","commit_id":"4cfcfbd3503e1c28b7cdac4991f196d7d9779ae3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"95d347964c0c3fe33e75f0fa7e405cd71cef7176","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            #TODO(nati) filter by security group"},{"line_number":457,"context_line":"            for port in ports:"},{"line_number":458,"context_line":"                self._extend_port_dict_security_group(context, port)"},{"line_number":459,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":460,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def create_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fe7M%3D","line":459,"in_reply_to":"AAAAM3%2F%2Ff5Q%3D","updated":"2013-01-19 02:47:35.000000000","message":"Done","commit_id":"4cfcfbd3503e1c28b7cdac4991f196d7d9779ae3"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"930cca169e7d725b9fc88f6b2fa342b4e60c99be","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            port \u003d super(OVSQuantumPluginV2, self).get_port(context,"},{"line_number":509,"context_line":"                                                            id,"},{"line_number":510,"context_line":"                                                            fields)"},{"line_number":511,"context_line":"            self._extend_port_dict_binding(context, port)"},{"line_number":512,"context_line":"        return self._fields(port, fields)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fi1k%3D","line":511,"updated":"2013-01-16 17:00:03.000000000","message":"_extend_port_dict_binding does not seem to be making any DB queries. If that is the case, then transaction block may not be required?","commit_id":"cfe2ef511b53757bd13a1c0b0a42b4e8cec97473"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"95d347964c0c3fe33e75f0fa7e405cd71cef7176","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            port \u003d super(OVSQuantumPluginV2, self).get_port(context,"},{"line_number":509,"context_line":"                                                            id,"},{"line_number":510,"context_line":"                                                            fields)"},{"line_number":511,"context_line":"            self._extend_port_dict_binding(context, port)"},{"line_number":512,"context_line":"        return self._fields(port, fields)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FgXk%3D","line":511,"in_reply_to":"AAAAM3%2F%2Fi1k%3D","updated":"2013-01-18 02:07:23.000000000","message":"you are right, I forgot this should add after securitygroup add for ovs https://review.openstack.org/#/c/19436/ , Let me review this now","commit_id":"cfe2ef511b53757bd13a1c0b0a42b4e8cec97473"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"930cca169e7d725b9fc88f6b2fa342b4e60c99be","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                                                              filters,"},{"line_number":519,"context_line":"                                                              fields)"},{"line_number":520,"context_line":"            for port in ports:"},{"line_number":521,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":522,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def update_port(self, context, id, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fi1c%3D","line":521,"updated":"2013-01-16 17:00:03.000000000","message":"Same as before.","commit_id":"cfe2ef511b53757bd13a1c0b0a42b4e8cec97473"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"95d347964c0c3fe33e75f0fa7e405cd71cef7176","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                                                              filters,"},{"line_number":519,"context_line":"                                                              fields)"},{"line_number":520,"context_line":"            for port in ports:"},{"line_number":521,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":522,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def update_port(self, context, id, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FgXg%3D","line":521,"in_reply_to":"AAAAM3%2F%2Fi1c%3D","updated":"2013-01-18 02:07:23.000000000","message":"Done","commit_id":"cfe2ef511b53757bd13a1c0b0a42b4e8cec97473"}]}