)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fe4ed986e7ae39d82011008e1cb6b82feb3cddb7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact: New metadata agent flag \u0027endpoint_url\u0027 set to None by default"},{"line_number":14,"context_line":"Closes-Bug: #1466258"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_6d00c966","line":13,"updated":"2015-06-18 01:44:38.000000000","message":"nit: the explanation is unnecessary.","commit_id":"9ce8d1e1701061eb1fae601674770ef4a5287bf4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"47874239edc362904effc7d1a54a45a80fbfc786","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow overriding of the neutron endpoint URL in metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow operators to set the endpoint url for neutron in the config"},{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_9063e441","line":10,"updated":"2015-06-18 02:14:00.000000000","message":"can you explain the use case a bit more?\n\nthe use of neutron api for this purpose is\nconsidered obsolete, preferring rpcs.","commit_id":"8f5b0029caa37430ad54b19ad344c2fb037a4728"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5d522a8c1b3c2bc521134148cc462607ebb4766b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow overriding of the neutron endpoint URL in metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow operators to set the endpoint url for neutron in the config"},{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_b3a712bc","line":10,"in_reply_to":"fa32b979_537b267b","updated":"2015-06-18 02:53:33.000000000","message":"I agree with yamamoto. Why doesn\u0027t the deployments put?","commit_id":"8f5b0029caa37430ad54b19ad344c2fb037a4728"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"397cb39048558dccc263633290cacdcfdd5aeae0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow overriding of the neutron endpoint URL in metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow operators to set the endpoint url for neutron in the config"},{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_f0f6f05b","line":10,"in_reply_to":"fa32b979_9063e441","updated":"2015-06-18 02:18:59.000000000","message":"The use case is described in the bug. Some deployments don\u0027t put the neutron endpoint into keystone and so they need to specify it in the config. Nova works this way to.","commit_id":"8f5b0029caa37430ad54b19ad344c2fb037a4728"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b77d6b6d330c1d5fff58ed3a9db9749bcddb9ae1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow overriding of the neutron endpoint URL in metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow operators to set the endpoint url for neutron in the config"},{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_537b267b","line":10,"in_reply_to":"fa32b979_f0f6f05b","updated":"2015-06-18 02:39:57.000000000","message":"i read the bug before writing the above comment.\n\ncan you explain:\n- why you can\u0027t use rpc\n- why you don\u0027t want to put it on catalog","commit_id":"8f5b0029caa37430ad54b19ad344c2fb037a4728"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6a70db3655b3c4e6d0359741edb2af53e1ddc6ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"overriding the url that comes from the keystone catalog."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775"},{"line_number":13,"context_line":"DocImpact:"},{"line_number":14,"context_line":"Closes-Bug: #1466258"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_7328aa33","line":13,"updated":"2015-06-18 02:46:26.000000000","message":"nit: please remove \":\"","commit_id":"89263323ee602968a2b02932db77bee2ced7dfa1"}],"neutron/agent/metadata/config.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"47874239edc362904effc7d1a54a45a80fbfc786","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                default\u003d\u0027adminURL\u0027,"},{"line_number":75,"context_line":"                help\u003d_(\"Network service endpoint type to pull from \""},{"line_number":76,"context_line":"                       \"the keystone catalog\")),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027endpoint_url\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"},{"line_number":79,"context_line":"               help\u003d_(\"Neutron endpoint URL, if not set will use endpoint \""},{"line_number":80,"context_line":"                      \"from the keystone catalog along with endpoint_type\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f0d590e4","line":77,"updated":"2015-06-18 02:14:00.000000000","message":"whitespace problem?","commit_id":"8f5b0029caa37430ad54b19ad344c2fb037a4728"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9fab45531dd47368ebc933f3e20aabdcba3cff0e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_shared_secret\u0027,"},{"line_number":87,"context_line":"           default\u003d\u0027\u0027,"},{"line_number":88,"context_line":"           help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":89,"context_line":"           secret\u003dTrue),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027nova_metadata_protocol\u0027,"},{"line_number":91,"context_line":"            default\u003d\u0027http\u0027,"},{"line_number":92,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_d35416cb","line":89,"updated":"2015-06-18 02:43:45.000000000","message":"indentation problems?","commit_id":"89263323ee602968a2b02932db77bee2ced7dfa1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6a70db3655b3c4e6d0359741edb2af53e1ddc6ff","unresolved":false,"context_lines":[{"line_number":88,"context_line":"           help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":89,"context_line":"           secret\u003dTrue),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027nova_metadata_protocol\u0027,"},{"line_number":91,"context_line":"            default\u003d\u0027http\u0027,"},{"line_number":92,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":93,"context_line":"               help\u003d_(\"Protocol to access nova metadata, http or https\")),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027nova_metadata_insecure\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_53256659","line":91,"updated":"2015-06-18 02:46:26.000000000","message":"ditto","commit_id":"89263323ee602968a2b02932db77bee2ced7dfa1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"714d1a45eb9caf1b5194ec0939219be105a86664","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":89,"context_line":"               secret\u003dTrue),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027nova_metadata_protocol\u0027,"},{"line_number":91,"context_line":"            default\u003d\u0027http\u0027,"},{"line_number":92,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],"},{"line_number":93,"context_line":"               help\u003d_(\"Protocol to access nova metadata, http or https\")),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027nova_metadata_insecure\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_7e7071a4","line":91,"updated":"2015-06-18 03:26:31.000000000","message":"indentation problem","commit_id":"ecb4e07bea3fb3eb78ad37fc36b2f25979de4e81"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"944c7af67c33e3cb42abca8a483dcb963388efbf","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"METADATA_PROXY_HANDLER_OPTS \u003d ["},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027admin_user\u0027,"},{"line_number":54,"context_line":"               help\u003d_(\"Admin user\")),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027admin_password\u0027,"},{"line_number":56,"context_line":"               help\u003d_(\"Admin password\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_29b81ae5","line":53,"updated":"2015-07-17 01:30:15.000000000","message":"Why all the reformatting?  Please avoid reformatting, even when you think the current formatting is wrong.  This just begs for merge conflicts and difficulty back-porting, etc.","commit_id":"14e1bff53ed92c3f1f998d65486b3dcd2f7e63c2"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fe4ed986e7ae39d82011008e1cb6b82feb3cddb7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"class TestNeutronClient(base.BaseTestCase):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_client_params(self):"},{"line_number":57,"context_line":"        fake_conf \u003d FakeConf"},{"line_number":58,"context_line":"        handler \u003d agent.MetadataProxyHandler(fake_conf)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6d5c497d","line":57,"updated":"2015-06-18 01:44:38.000000000","message":"please move to L.55 since L.79 also use the same.","commit_id":"9ce8d1e1701061eb1fae601674770ef4a5287bf4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fe4ed986e7ae39d82011008e1cb6b82feb3cddb7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                \u0027password\u0027: \u0027password\u0027,"},{"line_number":73,"context_line":"                \u0027endpoint_url\u0027: None,"},{"line_number":74,"context_line":"                \u0027auth_strategy\u0027: \u0027keystone\u0027,"},{"line_number":75,"context_line":"            }"},{"line_number":76,"context_line":"            mock_init.assert_called_once_with(**expected_params)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_client_with_endpoint_url(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_4dd065c9","line":75,"updated":"2015-06-18 01:44:38.000000000","message":"Can you gather expected_params since it\u0027s also used almost the same in L.86?","commit_id":"9ce8d1e1701061eb1fae601674770ef4a5287bf4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"678bf69c4baa91893bbc62580fd0f42ffedc9121","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            mock_init.assert_called_once_with(**self.expected_params)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_client_with_endpoint_url(self):"},{"line_number":79,"context_line":"        self.fake_conf.endpoint_url \u003d \u0027http://127.0.0.0:8776\u0027"},{"line_number":80,"context_line":"        handler \u003d agent.MetadataProxyHandler(self.fake_conf)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        expected_params \u003d self.expected_params.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_88831704","line":79,"updated":"2015-07-14 02:55:50.000000000","message":"please make a copy before modifying this.\nit\u0027s a bad practice to rely on the order of tests to run.","commit_id":"97f6a9378974170dd070f985805edcf55a983ea5"}]}