)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1719d33fa3ba471f17c1fdd6653963ea501c4034","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Check if the hostname is ipv6 and set the family appropriately. Replicating the"},{"line_number":10,"context_line":"change that was already merged in nova [1]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://review.openstack.org/#/c/19301/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I67166dc030e4ea0dd82888abfbc9db555747de27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2Fpao%3D","line":12,"updated":"2013-01-11 05:00:03.000000000","message":"nit: remove this before we merge it.","commit_id":"f2cc043cf85a589d88d753fc16b01c8c508fb1c5"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Check if the hostname is ipv6 and set the family appropriately. Replicating the"},{"line_number":10,"context_line":"change that was already merged in nova [1]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://review.openstack.org/#/c/19301/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I67166dc030e4ea0dd82888abfbc9db555747de27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FpEg%3D","line":12,"in_reply_to":"AAAAM3%2F%2Fpao%3D","updated":"2013-01-11 13:39:36.000000000","message":"Done","commit_id":"f2cc043cf85a589d88d753fc16b01c8c508fb1c5"}],"quantum/tests/unit/test_wsgi.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAM3%2F%2Fn5k%3D","line":3,"updated":"2013-01-12 06:57:39.000000000","message":"please change to 2013","commit_id":"0903b7ce6bb23cc44b563512c497a630a02e81ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import unittest"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum import wsgi"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAM3%2F%2Fn5g%3D","line":18,"updated":"2013-01-12 06:57:39.000000000","message":"can you please unittest2","commit_id":"0903b7ce6bb23cc44b563512c497a630a02e81ec"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantum import wsgi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestWSGIServer(unittest.TestCase):"},{"line_number":24,"context_line":"    \"\"\"WSGI server tests.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_start_random_port(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmZY%3D","line":23,"updated":"2013-01-14 16:25:04.000000000","message":"You need a test case validating link-local IPv6.","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantum import wsgi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestWSGIServer(unittest.TestCase):"},{"line_number":24,"context_line":"    \"\"\"WSGI server tests.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_start_random_port(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FkQw%3D","line":23,"in_reply_to":"AAAAM3%2F%2FmWo%3D","updated":"2013-01-15 19:48:36.000000000","message":"You can use mocks on self.pool.spawn() and eventlet.listen() to validate the the parameters passed are correct.  To actually spin up a server on the link-local address you need to know the IP and interface combo, but that would require an external dependency to query the system\u0027s interfaces.","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantum import wsgi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestWSGIServer(unittest.TestCase):"},{"line_number":24,"context_line":"    \"\"\"WSGI server tests.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_start_random_port(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmWo%3D","line":23,"in_reply_to":"AAAAM3%2F%2FmZY%3D","updated":"2013-01-14 16:38:25.000000000","message":"Any suggestion on what the the address would look like? (so it would work ok on the jenkins slaves?)","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"},{"line_number":67,"context_line":"                mock_app,"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAM3%2F%2FcyE%3D","line":64,"updated":"2013-01-22 02:29:38.000000000","message":"If we pass a link-local address to bind_addr, eventlet.listen raises socket.error. I believe this is what  Mark\u0027s comment said in the previous patch set. The following is a sample output on my machine.\n\nThus you need to change the test so that eventlet.listen mock raises socket.error.\n\n----\n$ ifconfig eth0\neth0      Link encap:Ethernet  HWaddr 52:54:00:d3:c6:30\n          inet6 addr: fe80::5054:ff:fed3:c630/64 Scope:Link\n          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1\n          RX packets:5318967 errors:0 dropped:0 overruns:0 frame:0\n          TX packets:1514066 errors:0 dropped:0 overruns:0 carrier:0\n          collisions:0 txqueuelen:1000\n          RX bytes:882725346 (882.7 MB)  TX bytes:326145832 (326.1 MB)\nIn [1]: import socket\n\nIn [2]: import eventlet\n\nIn [3]: info \u003d socket.getaddrinfo(\u0027fe80::5054:ff:fed3:c630\u0027, 8765, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n\nIn [4]: info\nOut[4]: (10, 1, 6, \u0027\u0027, (\u0027fe80::5054:ff:fed3:c630\u0027, 8765, 0, 0))\n\nIn [5]: try:\n   ...:     eventlet.listen(info[-1], info[0], backlog\u003d128)\n   ...: except Exception as e:\n   ...:     print type(e), str(e)\n   ...:\n\u003cclass \u0027socket.error\u0027\u003e [Errno 22] Invalid argument","commit_id":"c1db9d8fe804599f5228024b36b1e45c94b0b030"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"},{"line_number":67,"context_line":"                mock_app,"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAM3%2F%2FcvA%3D","line":64,"in_reply_to":"AAAAM3%2F%2FcwE%3D","updated":"2013-01-22 03:15:50.000000000","message":"Done","commit_id":"c1db9d8fe804599f5228024b36b1e45c94b0b030"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"},{"line_number":67,"context_line":"                mock_app,"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAM3%2F%2FcwE%3D","line":64,"in_reply_to":"AAAAM3%2F%2FcxM%3D","updated":"2013-01-22 02:57:19.000000000","message":"We don\u0027t need to validate the interface name. IMO, what we need to do is just to add try/except around eventlet.listen() in quantum/wsgi.py to catch socket.error, generate a human-friendly error message and exit the quantum server.\n\neventlet.listen() does a nice check, but \"socket.error: [Errno 22] Invalid argument\" is difficult to understand.","commit_id":"c1db9d8fe804599f5228024b36b1e45c94b0b030"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"},{"line_number":67,"context_line":"                mock_app,"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAM3%2F%2FcxM%3D","line":64,"in_reply_to":"AAAAM3%2F%2FcyE%3D","updated":"2013-01-22 02:42:00.000000000","message":"Akohiro, you need to qualify with the interface name like this \u0027fe80::5054:ff:fed3:c630%eth0\u0027\n\ndims@dims-laptop:~/openstack/nova$ ifconfig wlan0\nwlan0     Link encap:Ethernet  HWaddr a0:88:b4:71:d9:70  \n          inet addr:192.168.1.137  Bcast:192.168.1.255  Mask:255.255.255.0\n          inet6 addr: fda4:8e81:a32a:0:810b:628c:488f:a88e/64 Scope:Global\n          inet6 addr: fda4:8e81:a32a:0:a288:b4ff:fe71:d970/64 Scope:Global\n          inet6 addr: fe80::a288:b4ff:fe71:d970/64 Scope:Link\n          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1\n          RX packets:336128 errors:0 dropped:0 overruns:0 frame:0\n          TX packets:229020 errors:0 dropped:0 overruns:0 carrier:0\n          collisions:0 txqueuelen:1000 \n          RX bytes:212182208 (212.1 MB)  TX bytes:49291139 (49.2 MB)\n\ndims@dims-laptop:~/openstack/nova$ python\nPython 2.7.3 (default, Sep 26 2012, 21:53:58) \n[GCC 4.7.2] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e import socket\n\u003e\u003e\u003e import eventlet\n\u003e\u003e\u003e info \u003d socket.getaddrinfo(\u0027fe80::a288:b4ff:fe71:d970\u0027\u0027, 8765, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n  File \"\u003cstdin\u003e\", line 1\n    info \u003d socket.getaddrinfo(\u0027fe80::a288:b4ff:fe71:d970\u0027\u0027, 8765, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n                                                                                                         ^\nSyntaxError: EOL while scanning string literal\n\u003e\u003e\u003e info \u003d socket.getaddrinfo(\u0027fe80::a288:b4ff:fe71:d970\u0027, 8765, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n\u003e\u003e\u003e info\n(10, 1, 6, \u0027\u0027, (\u0027fe80::a288:b4ff:fe71:d970\u0027, 8765, 0, 0))\n\u003e\u003e\u003e eventlet.listen(info[-1], info[0], backlog\u003d128)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/local/lib/python2.7/dist-packages/eventlet/convenience.py\", line 38, in listen\n    sock.bind(addr)\n  File \"/usr/lib/python2.7/socket.py\", line 224, in meth\n    return getattr(self._sock,name)(*args)\nsocket.error: [Errno 22] Invalid argument\n\u003e\u003e\u003e info \u003d socket.getaddrinfo(\u0027fe80::a288:b4ff:fe71:d970%wlan0\u0027, 8765, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n\u003e\u003e\u003e eventlet.listen(info[-1], info[0], backlog\u003d128)\n\u003ceventlet.greenio.GreenSocket object at 0x86a69cc\u003e\n\u003e\u003e\u003e","commit_id":"c1db9d8fe804599f5228024b36b1e45c94b0b030"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.eventlet.assert_has_calls(["},{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAM3%2F%2Fcs0%3D","line":63,"updated":"2013-01-22 03:45:31.000000000","message":"Need to raise socket.error here.\nside_effect can be used to raise an exception.","commit_id":"b213fb889681c3f631dcb3876458fb512818d401"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.eventlet.assert_has_calls(["},{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"},{"line_number":65,"context_line":"            pool.spawn.assert_has_calls([mock.call("},{"line_number":66,"context_line":"                self.server._run,"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAM3%2F%2Fcrg%3D","line":63,"in_reply_to":"AAAAM3%2F%2Fcs0%3D","updated":"2013-01-22 04:11:52.000000000","message":"Akihiro, the objective of this test was to make sure if there is a correct link local address with the interface then the calls are correct. Please see Mark\u0027s comment in this review - https://review.openstack.org/#/c/19401/17/quantum/tests/unit/test_wsgi.py,unified . \n\nThanks,\ndims","commit_id":"b213fb889681c3f631dcb3876458fb512818d401"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"        with mock.patch.object(self.server, \u0027pool\u0027) as pool:"},{"line_number":57,"context_line":"            self.server.start(mock_app,"},{"line_number":58,"context_line":"                              0,"},{"line_number":59,"context_line":"                              host\u003d\"fe80::204:acff:fe96:da87%eth0\")"},{"line_number":60,"context_line":"            self.eventlet.assert_has_calls(["},{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAM3%2F%2FcAo%3D","line":59,"updated":"2013-01-22 16:38:06.000000000","message":"This unit test fails on systems without eth0. Fedora will use em1 on many current systems.","commit_id":"20314e0ba06588d3ac7855d1b4ae7f3c75cab1a1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"                              0,"},{"line_number":59,"context_line":"                              host\u003d\"fe80::204:acff:fe96:da87%eth0\")"},{"line_number":60,"context_line":"            self.eventlet.assert_has_calls(["},{"line_number":61,"context_line":"                mock.call.listen((\u0027fe80::204:acff:fe96:da87%eth0\u0027, 0, 0, 2),"},{"line_number":62,"context_line":"                                 backlog\u003d128,"},{"line_number":63,"context_line":"                                 family\u003d10)"},{"line_number":64,"context_line":"            ])"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAM3%2F%2FcAk%3D","line":61,"updated":"2013-01-22 16:38:06.000000000","message":"This unit test fails on systems where the ethernet device (eth0, or renamed to em1) is not at index 2.","commit_id":"20314e0ba06588d3ac7855d1b4ae7f3c75cab1a1"}],"quantum/wsgi.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            socket.inet_pton(socket.AF_INET6, host)"},{"line_number":57,"context_line":"            family \u003d socket.AF_INET6"},{"line_number":58,"context_line":"        except Exception:"},{"line_number":59,"context_line":"            family \u003d socket.AF_INET"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fo%2FM%3D","line":56,"updated":"2013-01-11 15:33:39.000000000","message":"This solution will fail when the host address is link-local\n(\u0027fe80::62c5:47ff:fe98:e7d6%eth0\u0027).  Python requires that you use the 4-tuple address variant when using scoped addresses.\n\nThis will work for all cases:\n\nfamily, _, _, _, addr \u003d socket.getaddrinfo(host, port, socket.AF_UNSPEC, socket.SOCK_STREAM)[0]\n\n_socket \u003d eventlet.listen(addr, family, backlog\u003dbacklog)","commit_id":"3b13db0246b6ab400b9dd0c1398e50807da48367"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        family \u003d ["},{"line_number":57,"context_line":"            addr[0] for addr in socket.getaddrinfo(host,"},{"line_number":58,"context_line":"                                                   port,"},{"line_number":59,"context_line":"                                                   socket.AF_UNSPEC,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fo6Q%3D","line":56,"updated":"2013-01-11 16:40:22.000000000","message":"I don\u0027t think that looping is the correct behavior here.  getaddrinfo() returns a list and you can safely take the first item in the list as you are specifying the desired protocol.  Also, it is important that you use the addr tuple that is returned as part of the call. Python\u0027s IPv6 implementation requires a 4-tuple addr in a few cases and getaddrinfo() will correctly build it for you.","commit_id":"0fe09a4eda0a1a3b44bb34e0de5945be509202f2"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        family \u003d ["},{"line_number":57,"context_line":"            addr[0] for addr in socket.getaddrinfo(host,"},{"line_number":58,"context_line":"                                                   port,"},{"line_number":59,"context_line":"                                                   socket.AF_UNSPEC,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Foi0%3D","line":56,"in_reply_to":"AAAAM3%2F%2Fo6Q%3D","updated":"2013-01-11 20:29:45.000000000","message":"Mark, I was trying to replicate the code i see in glance - https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L98 the ipv6 was the first step.","commit_id":"0fe09a4eda0a1a3b44bb34e0de5945be509202f2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAM3%2F%2Fnro%3D","line":55,"updated":"2013-01-12 16:36:15.000000000","message":"Any chance of using pythons netaddr library - you can make use of netaddr.valid_ipv4(addr, flags\u003d0) and netaddr.valid_ipv6(addr, flags\u003d0)","commit_id":"c15ecc1f3f8ca76a3f6ddc6c4804066a96f992f7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAM3%2F%2FnpA%3D","line":55,"in_reply_to":"AAAAM3%2F%2Fnro%3D","updated":"2013-01-12 18:31:39.000000000","message":"please see the main comments. won\u0027t work with ipv6 link local addresses","commit_id":"c15ecc1f3f8ca76a3f6ddc6c4804066a96f992f7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":"            family \u003d socket.AF_INET"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self._socket \u003d eventlet.listen(bind_addr, family, backlog\u003dbacklog)"},{"line_number":72,"context_line":"        self._server \u003d self.pool.spawn(self._run, application, self._socket)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def host(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FneA%3D","line":72,"updated":"2013-01-13 03:45:46.000000000","message":"why change spawn_n -\u003e spawn?","commit_id":"cb5571c408ddb9ca6402419fa8f1d3459753fc8d"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            family \u003d socket.AF_INET"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self._socket \u003d eventlet.listen(bind_addr, family, backlog\u003dbacklog)"},{"line_number":72,"context_line":"        self._server \u003d self.pool.spawn(self._run, application, self._socket)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def host(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2Fndw%3D","line":72,"in_reply_to":"AAAAM3%2F%2FneA%3D","updated":"2013-01-13 03:50:38.000000000","message":"note from the doc, need to be able to kill the thread hence the spawn.\n\nspawn_n(function, *args, **kwargs)\n\nCreate a greenthread to run the function, the same as spawn(). The difference is that spawn_n() returns None; the results of function are not retrievable.","commit_id":"cb5571c408ddb9ca6402419fa8f1d3459753fc8d"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def port(self):"},{"line_number":80,"context_line":"        return self._socket.getsockname()[1] if self._socket else self._port"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def stop(self):"},{"line_number":83,"context_line":"        self._server.kill()"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FnAY%3D","line":80,"updated":"2013-01-14 02:16:16.000000000","message":"Does getsockname() have to be invoked every time these properties are looked up?\n\nHow about:\n\ndef start(self,...):\n    ....\n    ....\n    self._server \u003d self.pool.spawn(...)\n    self._socket_info \u003d self._socket.getsockname()\n\n@property\ndef host(self):\n    return self._socket_info[0] if self._socket else self._host\n\n\n@property\ndef port(self):\n    return self._socket_info[1] if self._socket else self._port","commit_id":"da22223df875c863ae3d790b681dd4f620700ce1"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def port(self):"},{"line_number":80,"context_line":"        return self._socket.getsockname()[1] if self._socket else self._port"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def stop(self):"},{"line_number":83,"context_line":"        self._server.kill()"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2Fm%2B8%3D","line":80,"in_reply_to":"AAAAM3%2F%2Fm%2FM%3D","updated":"2013-01-14 02:53:10.000000000","message":"Does this mean you will address this? I can\u0027t see changes in patch 16.","commit_id":"da22223df875c863ae3d790b681dd4f620700ce1"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def port(self):"},{"line_number":80,"context_line":"        return self._socket.getsockname()[1] if self._socket else self._port"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def stop(self):"},{"line_number":83,"context_line":"        self._server.kill()"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2Fm%2FM%3D","line":80,"in_reply_to":"AAAAM3%2F%2FnAY%3D","updated":"2013-01-14 02:49:57.000000000","message":"Done","commit_id":"da22223df875c863ae3d790b681dd4f620700ce1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmaQ%3D","line":55,"updated":"2013-01-14 16:25:04.000000000","message":"I don\u0027t see these used anywhere else.  What\u0027s the purpose of storing host/port on the instance?","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmWc%3D","line":55,"in_reply_to":"AAAAM3%2F%2FmYI%3D","updated":"2013-01-14 16:38:25.000000000","message":"ok :) also please take a peek at review https://review.openstack.org/#/c/19561/ that adds ssl","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmYI%3D","line":55,"in_reply_to":"AAAAM3%2F%2FmaQ%3D","updated":"2013-01-14 16:33:53.000000000","message":"Missed that these are properties added below.  Please disregard the above comment.","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def start(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d128):"},{"line_number":54,"context_line":"        \"\"\"Run a WSGI server with the given application.\"\"\""},{"line_number":55,"context_line":"        self._host \u003d host"},{"line_number":56,"context_line":"        self._port \u003d port"},{"line_number":57,"context_line":"        bind_addr \u003d (self._host, self._port)"},{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FmWg%3D","line":55,"in_reply_to":"AAAAM3%2F%2FmaQ%3D","updated":"2013-01-14 16:38:25.000000000","message":"disregarding, per comment below.","commit_id":"743a6684698f903431fa564d4f0934d78ad2f767"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"},{"line_number":59,"context_line":"        # support IPv6 in getaddrinfo(). We need to get around this in the"},{"line_number":60,"context_line":"        # future or monitor upstream for a fix"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            info \u003d socket.getaddrinfo(self._host,"},{"line_number":63,"context_line":"                                      self._port,"},{"line_number":64,"context_line":"                                      socket.AF_UNSPEC,"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAM3%2F%2FctQ%3D","line":61,"updated":"2013-01-22 03:45:31.000000000","message":"eventlet.listen() also needs to be moved to try clause.\nIf link-local address is specifed eventlet.listen() raises an exception.","commit_id":"b213fb889681c3f631dcb3876458fb512818d401"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"7be50a0b3eaa02edb884ceae89d489cc5b71970c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # TODO(dims): eventlet\u0027s green dns/socket module does not actually"},{"line_number":59,"context_line":"        # support IPv6 in getaddrinfo(). We need to get around this in the"},{"line_number":60,"context_line":"        # future or monitor upstream for a fix"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            info \u003d socket.getaddrinfo(self._host,"},{"line_number":63,"context_line":"                                      self._port,"},{"line_number":64,"context_line":"                                      socket.AF_UNSPEC,"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAM3%2F%2Fcrk%3D","line":61,"in_reply_to":"AAAAM3%2F%2FctQ%3D","updated":"2013-01-22 04:11:52.000000000","message":"Done","commit_id":"b213fb889681c3f631dcb3876458fb512818d401"}]}
