)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"* Removes outdated doc string comments."},{"line_number":12,"context_line":"* Changes update_network so that it doesn\u0027t update the network name in nvp"},{"line_number":13,"context_line":"  since the name is retreved from the database."},{"line_number":14,"context_line":"* Fixes get_network to return the correct status from nvp. Perviously,"},{"line_number":15,"context_line":"  it was always returning ACTIVE."},{"line_number":16,"context_line":"Fixes bug 1097990"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2Fk9I%3D","line":14,"updated":"2013-01-15 09:46:03.000000000","message":"typo - Perviously","commit_id":"b393266bc2a3046032ac125529da22bc509758c7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* Removes outdated doc string comments."},{"line_number":12,"context_line":"* Changes update_network so that it doesn\u0027t update the network name in nvp"},{"line_number":13,"context_line":"  since the name is retreved from the database."},{"line_number":14,"context_line":"* Fixes get_network to return the correct status from nvp. Perviously,"},{"line_number":15,"context_line":"  it was always returning ACTIVE."},{"line_number":16,"context_line":"Fixes bug 1097990"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2Fjjk%3D","line":14,"in_reply_to":"AAAAM3%2F%2Fk9I%3D","updated":"2013-01-16 03:48:59.000000000","message":"Done","commit_id":"b393266bc2a3046032ac125529da22bc509758c7"}],"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7cd8749ed743f56f613d77428829d5ed70dd7357","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpoQ%3D","side":"PARENT","line":38,"updated":"2013-01-11 00:22:04.000000000","message":"This line is required after the quota ext refactor.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FmVo%3D","side":"PARENT","line":38,"in_reply_to":"AAAAM3%2F%2FoMc%3D","updated":"2013-01-14 16:42:46.000000000","message":"Yeah.. I\u0027ll work on adding a test for it.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FoMc%3D","side":"PARENT","line":38,"in_reply_to":"AAAAM3%2F%2FpBc%3D","updated":"2013-01-11 23:50:09.000000000","message":"Interesting, Is there anyway we could add a unit test to check for this? Seems like this can easily get broken without anyone noticing.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpBc%3D","side":"PARENT","line":38,"in_reply_to":"AAAAM3%2F%2FpNw%3D","updated":"2013-01-11 14:39:04.000000000","message":"We need to explicitly load the Quota model.  Previously the model and extension were loaded too late depending on the code path taken and caused strange behavior that varied with the path taken during migration, plugin loading, and unit testing.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpNw%3D","side":"PARENT","line":38,"in_reply_to":"AAAAM3%2F%2FpgY%3D","updated":"2013-01-11 10:21:33.000000000","message":"Is that because we need this import in order for migrations to work properly? (otherwise we\u0027d find drop_table(\u0027Quota\u0027) in the upgrade routine.)","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":36,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":37,"context_line":"from quantum.db import models_v2"},{"line_number":38,"context_line":"from quantum.db import quota_db"},{"line_number":39,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":40,"context_line":"from quantum.openstack.common import cfg"},{"line_number":41,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpgY%3D","side":"PARENT","line":38,"in_reply_to":"AAAAM3%2F%2FpoQ%3D","updated":"2013-01-11 02:14:52.000000000","message":"Hi Mark, \nsorry, I\u0027m not following what you are saying? I can run quantum quota-show fine without this.  Why is this line needed? quota_db isn\u0027t referenced anywhere else in this file so it shouldn\u0027t have any affect (am i missing something here)?","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":356,"context_line":"                                network create."},{"line_number":357,"context_line":"                   }"},{"line_number":358,"context_line":"        :raises: exception.NoImplementedError"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        net_data \u003d network[\u0027network\u0027].copy()"},{"line_number":361,"context_line":"        # Process the provider network extension"},{"line_number":362,"context_line":"        self._handle_provider_create(context, net_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpOM%3D","side":"PARENT","line":359,"updated":"2013-01-11 10:21:33.000000000","message":"Why are these comments being removed?\nNo big deal, as we have them in the superclass anyway.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                                network create."},{"line_number":357,"context_line":"                   }"},{"line_number":358,"context_line":"        :raises: exception.NoImplementedError"},{"line_number":359,"context_line":"        \"\"\""},{"line_number":360,"context_line":"        net_data \u003d network[\u0027network\u0027].copy()"},{"line_number":361,"context_line":"        # Process the provider network extension"},{"line_number":362,"context_line":"        self._handle_provider_create(context, net_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FoMQ%3D","side":"PARENT","line":359,"in_reply_to":"AAAAM3%2F%2FpOM%3D","updated":"2013-01-11 23:50:09.000000000","message":"A lot of them are somewhat out of date and they are in the superclass as you said. If you prefer I can update the comments instead.","commit_id":"ee7d1cbdaae8faa307f497b4e1bf10bffc90af0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":424,"context_line":"                        break"},{"line_number":425,"context_line":"                LOG.debug(_(\"Current network status:%(net_op_status)s; \""},{"line_number":426,"context_line":"                            \"Status in Quantum DB:%(quantum_status)s\")"},{"line_number":427,"context_line":"                          % locals())"},{"line_number":428,"context_line":"                if net_op_status !\u003d network.status:"},{"line_number":429,"context_line":"                    # update the network status"},{"line_number":430,"context_line":"                    network.status \u003d net_op_status"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpNk%3D","line":427,"updated":"2013-01-11 10:21:33.000000000","message":"I think the rules for logging, formatting, i18n, and such required us to use a coma instead of a \u0027%\u0027 in the previous line.","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":424,"context_line":"                        break"},{"line_number":425,"context_line":"                LOG.debug(_(\"Current network status:%(net_op_status)s; \""},{"line_number":426,"context_line":"                            \"Status in Quantum DB:%(quantum_status)s\")"},{"line_number":427,"context_line":"                          % locals())"},{"line_number":428,"context_line":"                if net_op_status !\u003d network.status:"},{"line_number":429,"context_line":"                    # update the network status"},{"line_number":430,"context_line":"                    network.status \u003d net_op_status"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpBU%3D","line":427,"in_reply_to":"AAAAM3%2F%2FpNk%3D","updated":"2013-01-11 14:39:04.000000000","message":"Either version is version is fine.  The \u0027%\u0027 operator is ultimately called under the hood.","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":619,"context_line":"            # Update fields obtained from quantum db (eg: MAC address)"},{"line_number":620,"context_line":"            port[\"port\"].update(quantum_db)"},{"line_number":621,"context_line":"            # We want port to be up in NVP"},{"line_number":622,"context_line":"            port[\"port\"][\"admin_state_up\"] \u003d True"},{"line_number":623,"context_line":"            port_data \u003d port[\u0027port\u0027]"},{"line_number":624,"context_line":"            # Fetch the network and network binding from Quantum db"},{"line_number":625,"context_line":"            network \u003d self._get_network(context, port_data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpNQ%3D","line":622,"updated":"2013-01-11 10:21:33.000000000","message":"This is probably the consequence of another, unrelated bug in the NVP plugin - we should set it back to the original expected state.\n\nAlso, let me know what you think of this: with this change the port created at line 618 will be automatically removed in case of exception. as the context manager will call an abort. If we set the status to \u0027up\u0027 there, optimistically, you might argue that there is the possibility that some applications might see a port which does not yet exist in NVP, and due to the current architecture of the NVP plugin, this might lead to errors.\n\nHowever, since you\u0027re now in a transaction, no other user outside of this transaction will see the newly added port until the transaction is committed. So is there a chance we can just leave the status to its original value, and avoid the update call at the end of the method? (this would have been the goal of the original #TODO)","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            # Update fields obtained from quantum db (eg: MAC address)"},{"line_number":620,"context_line":"            port[\"port\"].update(quantum_db)"},{"line_number":621,"context_line":"            # We want port to be up in NVP"},{"line_number":622,"context_line":"            port[\"port\"][\"admin_state_up\"] \u003d True"},{"line_number":623,"context_line":"            port_data \u003d port[\u0027port\u0027]"},{"line_number":624,"context_line":"            # Fetch the network and network binding from Quantum db"},{"line_number":625,"context_line":"            network \u003d self._get_network(context, port_data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FoLs%3D","line":622,"in_reply_to":"AAAAM3%2F%2FpNQ%3D","updated":"2013-01-11 23:50:09.000000000","message":"great, yes I completely agree. Good idea! I\u0027ll fix the admin_state to be the original expected state.","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":659,"context_line":"            except Exception:"},{"line_number":660,"context_line":"                # failed to create port in NVP delete port from quantum_db"},{"line_number":661,"context_line":"                # FIXME (arosen) or the plugin_interface call failed in which"},{"line_number":662,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":663,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the interface\""},{"line_number":664,"context_line":"                            \" in NVP for port %s\") % port_data[\u0027id\u0027]"},{"line_number":665,"context_line":"                LOG.exception(err_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FpNE%3D","line":662,"updated":"2013-01-11 10:21:33.000000000","message":"If you want to fix this, you can split the try except block in multiple blocks, but I am happy to leave it as #FIXME","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            except Exception:"},{"line_number":660,"context_line":"                # failed to create port in NVP delete port from quantum_db"},{"line_number":661,"context_line":"                # FIXME (arosen) or the plugin_interface call failed in which"},{"line_number":662,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":663,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the interface\""},{"line_number":664,"context_line":"                            \" in NVP for port %s\") % port_data[\u0027id\u0027]"},{"line_number":665,"context_line":"                LOG.exception(err_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FoLo%3D","line":662,"in_reply_to":"AAAAM3%2F%2FpNE%3D","updated":"2013-01-11 23:50:09.000000000","message":"I thought about that but breaking it into multiple excepts most likely won\u0027t fix the problem. For example, imagine this scenario. We create the port in nvp successfully and then we go to plug in  the port but fail. In this case we should probably call nvplib.delete_lport() to remove it from NVP... though it\u0027s probably unlikely that, that call will succeed giving  the previous command failed. We need to garbage collect these to get rid of them imo. What do you think?","commit_id":"b462ca040129a545a84edf38b8bb39f272f11be2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":416,"context_line":"                net_op_status \u003d constants.NET_STATUS_ACTIVE"},{"line_number":417,"context_line":"                quantum_status \u003d network.status"},{"line_number":418,"context_line":"                for lswitch in lswitches:"},{"line_number":419,"context_line":"                    lswitch_status \u003d lswitch.get(\u0027LogicalSwitchStatus\u0027, None)"},{"line_number":420,"context_line":"                    # FIXME(salvatore-orlando): Being unable to fetch the"},{"line_number":421,"context_line":"                    # logical switch status should be an exception."},{"line_number":422,"context_line":"                    if (lswitch_status and"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FndU%3D","line":419,"updated":"2013-01-13 05:33:48.000000000","message":"is this information that is retrieved form the database or via the NVP? If this is via the NVP then it could be quite a long time in the database transaction.","commit_id":"77c0ece3493b054fc98e3f07861f82ab60b5cb5d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":416,"context_line":"                net_op_status \u003d constants.NET_STATUS_ACTIVE"},{"line_number":417,"context_line":"                quantum_status \u003d network.status"},{"line_number":418,"context_line":"                for lswitch in lswitches:"},{"line_number":419,"context_line":"                    lswitch_status \u003d lswitch.get(\u0027LogicalSwitchStatus\u0027, None)"},{"line_number":420,"context_line":"                    # FIXME(salvatore-orlando): Being unable to fetch the"},{"line_number":421,"context_line":"                    # logical switch status should be an exception."},{"line_number":422,"context_line":"                    if (lswitch_status and"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fna4%3D","line":419,"in_reply_to":"AAAAM3%2F%2FndU%3D","updated":"2013-01-13 10:17:21.000000000","message":"It\u0027s a dict. The query on NVP API was performed at line 415. get_lswitches returns all the logical switches for a given quantum network (which in 99% of cases is just one switch)","commit_id":"77c0ece3493b054fc98e3f07861f82ab60b5cb5d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                net_op_status \u003d constants.NET_STATUS_ACTIVE"},{"line_number":417,"context_line":"                quantum_status \u003d network.status"},{"line_number":418,"context_line":"                for lswitch in lswitches:"},{"line_number":419,"context_line":"                    lswitch_status \u003d lswitch.get(\u0027LogicalSwitchStatus\u0027, None)"},{"line_number":420,"context_line":"                    # FIXME(salvatore-orlando): Being unable to fetch the"},{"line_number":421,"context_line":"                    # logical switch status should be an exception."},{"line_number":422,"context_line":"                    if (lswitch_status and"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FmO0%3D","line":419,"in_reply_to":"AAAAM3%2F%2FndU%3D","updated":"2013-01-14 17:27:26.000000000","message":"Right, good call I can probably reduce the amount of stuff in the transaction here.  I\u0027ll check it out, thanks.","commit_id":"77c0ece3493b054fc98e3f07861f82ab60b5cb5d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":631,"context_line":"                    cluster, network, network_binding, max_ports,"},{"line_number":632,"context_line":"                    allow_extra_lswitches)"},{"line_number":633,"context_line":"                lswitch_uuid \u003d selected_lswitch[\u0027uuid\u0027]"},{"line_number":634,"context_line":"                lport \u003d nvplib.create_lport(cluster,"},{"line_number":635,"context_line":"                                            lswitch_uuid,"},{"line_number":636,"context_line":"                                            port_data[\u0027tenant_id\u0027],"},{"line_number":637,"context_line":"                                            port_data[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FlAA%3D","line":634,"updated":"2013-01-15 08:52:20.000000000","message":"Is this interfacing with the NVP? If so is it something that we would want in the database transaction?","commit_id":"b393266bc2a3046032ac125529da22bc509758c7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0627fcf5b9e6751bcfa22316c395e86641541a69","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                    cluster, network, network_binding, max_ports,"},{"line_number":632,"context_line":"                    allow_extra_lswitches)"},{"line_number":633,"context_line":"                lswitch_uuid \u003d selected_lswitch[\u0027uuid\u0027]"},{"line_number":634,"context_line":"                lport \u003d nvplib.create_lport(cluster,"},{"line_number":635,"context_line":"                                            lswitch_uuid,"},{"line_number":636,"context_line":"                                            port_data[\u0027tenant_id\u0027],"},{"line_number":637,"context_line":"                                            port_data[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fjjo%3D","line":634,"in_reply_to":"AAAAM3%2F%2FlAA%3D","updated":"2013-01-16 03:48:59.000000000","message":"We want this as part of the database transaction because if nvp.create_lport() raises an exception the port will not actually be committed in the database. Otherwise we would have to try and delete the port if we were not able to successfully create it in nvp. Previously, this method would delete the port from the database if we couldn\u0027t create the port in nvp. Doing this in the transaction is safer though since we might not be able to delete the port from the database. I agree this can take some time to completely unfortunately. Do you see a better way to handle this?","commit_id":"b393266bc2a3046032ac125529da22bc509758c7"}]}
