)]}'
{"etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAM3%2F%2Fjk8%3D","line":106,"updated":"2013-01-17 17:36:41.000000000","message":"It is not the default value, so it should be uncommented to set firewall_driver here.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAM3%2F%2Fg4Y%3D","line":106,"in_reply_to":"AAAAM3%2F%2Fg%2BI%3D","updated":"2013-01-18 03:37:26.000000000","message":"Does quantum-gating require NoopFirewallDriver?\nThough NoopFirewall is a valid configuration, it would be better that security group is enabled by default.\nIf quantum-gating requires NoopFirewallDriver, it should be set in gating configuration (though I don\u0027t know we can do such optional configurations).","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAM3%2F%2FgTw%3D","line":106,"in_reply_to":"AAAAM3%2F%2Fg4Y%3D","updated":"2013-01-18 03:48:31.000000000","message":"I agree security group should be enabled by default.\nBut it needs bootstrapping. \nso current devstack enables nova\u0027s firewall by default, in that case quantum security group could fail.\nso if we enable security group config for now, it can\u0027t pass quantum-gate jobs.\nThus, we should do step by step\n1. Merge this patch\n2. Enable security group by default in devstack\n3. Update default config in conf in Quantum","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAM3%2F%2FcJg%3D","line":106,"in_reply_to":"AAAAM3%2F%2FgTw%3D","updated":"2013-01-22 15:50:34.000000000","message":"I agree with your plan. Once Daniel\u0027s nova vif patch has been merged, we can disable nova nwfilter by setting LIBVIRT_FIREWALL_DRIVER to NoopDriver. After that your plan sounds reasonable.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAAM3%2F%2Fg%2BI%3D","line":106,"in_reply_to":"AAAAM3%2F%2Fjk8%3D","updated":"2013-01-17 18:43:22.000000000","message":"IMO, it should be disabled by default quantum-gating with this functions works.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":14,"id":"AAAAM3%2F%2FUMM%3D","line":106,"updated":"2013-01-29 09:21:20.000000000","message":"the quantum.agent.firewall.NoopFirewallDriver is default driver, we should use it as default in ini file.\nAlso, why not use open flow to implement the fire wall for ovs bridge agent?","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":15,"id":"AAAAM3%2F%2FSsw%3D","line":106,"updated":"2013-01-30 00:30:07.000000000","message":"default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027 in code.","commit_id":"c22a57cc1dafc8a1a16bb72b1308bad0237fc85b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":15,"id":"AAAAM3%2F%2FJSk%3D","line":106,"in_reply_to":"AAAAM3%2F%2FKgo%3D","updated":"2013-02-05 18:05:54.000000000","message":"Thanks. I updated the bp","commit_id":"c22a57cc1dafc8a1a16bb72b1308bad0237fc85b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":15,"id":"AAAAM3%2F%2FKgo%3D","line":106,"in_reply_to":"AAAAM3%2F%2FSrg%3D","updated":"2013-02-05 04:55:25.000000000","message":"I agree with your plan. Could you add a note about your step-by-step plan about quantum-gating to the blueprint page? \nIt would be helpful for everyone. I asked the same question in the previous patch set :-)","commit_id":"c22a57cc1dafc8a1a16bb72b1308bad0237fc85b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[SECURITYGROUP]"},{"line_number":105,"context_line":"# Firewall driver for realizing quantum security group function"},{"line_number":106,"context_line":"# firewall_driver \u003d quantum.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":109,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":15,"id":"AAAAM3%2F%2FSrg%3D","line":106,"in_reply_to":"AAAAM3%2F%2FSsw%3D","updated":"2013-01-30 00:34:21.000000000","message":"I will update it step by step way.\nbecause now quanutm-gate is working, we need to modify devstack after this patch is meged.","commit_id":"c22a57cc1dafc8a1a16bb72b1308bad0237fc85b"}],"quantum/agent/firewall.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"\"\" Noop Firewall Driver."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    Firewall driver which do nothing."},{"line_number":112,"context_line":"    This driver is for disabling firewall function."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def prepare_port_filter(self, port):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FnUo%3D","line":112,"updated":"2013-01-13 15:37:42.000000000","message":"disabling firewall function \u003d\u003e disabling the firewall functionality","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"\"\" Noop Firewall Driver."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    Firewall driver which do nothing."},{"line_number":112,"context_line":"    This driver is for disabling firewall function."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def prepare_port_filter(self, port):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FmA8%3D","line":112,"in_reply_to":"AAAAM3%2F%2FnUo%3D","updated":"2013-01-14 20:57:35.000000000","message":"Done","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"class NoopFirewallDriver(FirewallDriver):"},{"line_number":109,"context_line":"    \"\"\" Noop Firewall Driver."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    Firewall driver which do nothing."},{"line_number":112,"context_line":"    This driver is for disabling the firewall functionality."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FcUQ%3D","line":111,"updated":"2013-01-22 16:45:01.000000000","message":"do -\u003e does","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"class NoopFirewallDriver(FirewallDriver):"},{"line_number":109,"context_line":"    \"\"\" Noop Firewall Driver."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    Firewall driver which do nothing."},{"line_number":112,"context_line":"    This driver is for disabling the firewall functionality."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FbPo%3D","line":111,"in_reply_to":"AAAAM3%2F%2FcUQ%3D","updated":"2013-01-23 00:12:27.000000000","message":"Done","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"}],"quantum/agent/linux/iptables_firewall.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"68e51ccc326e9813fdb13cd8cfc4a104e4ff98f2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return [\u0027-m\u0027, \u0027multiport\u0027,"},{"line_number":272,"context_line":"                    \u0027--%ss\u0027 % direction,"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"                    \u0027%s:%s\u0027 % (port_range_min, port_range_max)]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _ip_prefix_arg(self, direction, ip_prefix):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FpjQ%3D","line":273,"updated":"2013-01-11 01:31:16.000000000","message":"nit?","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"be70df985822e09b0eede3543d5c45792fb73648","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            return [\u0027-m\u0027, \u0027multiport\u0027,"},{"line_number":272,"context_line":"                    \u0027--%ss\u0027 % direction,"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"                    \u0027%s:%s\u0027 % (port_range_min, port_range_max)]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _ip_prefix_arg(self, direction, ip_prefix):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fph8%3D","line":273,"in_reply_to":"AAAAM3%2F%2FpjQ%3D","updated":"2013-01-11 01:51:22.000000000","message":"Done","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"68e51ccc326e9813fdb13cd8cfc4a104e4ff98f2","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":298,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027qvb\u0027"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fpi8%3D","line":298,"updated":"2013-01-11 01:31:16.000000000","message":"Maybe it would be better if globals went to the top.","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"be70df985822e09b0eede3543d5c45792fb73648","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":298,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027qvb\u0027"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fph4%3D","line":298,"in_reply_to":"AAAAM3%2F%2Fpi8%3D","updated":"2013-01-11 01:51:22.000000000","message":"Done","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027),"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"cfg.CONF.register_opts(agent_opts, \"AGENT\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"SG_CHAIN \u003d \u0027sg-chain\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpU0%3D","line":30,"updated":"2013-01-11 07:40:43.000000000","message":"OVS plugin already has root_helper option in AGENT section. Do we need to add it?","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027),"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"cfg.CONF.register_opts(agent_opts, \"AGENT\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"SG_CHAIN \u003d \u0027sg-chain\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fo0Q%3D","line":30,"in_reply_to":"AAAAM3%2F%2FpU0%3D","updated":"2013-01-11 19:21:40.000000000","message":"You are right. I removed this one","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"CHAIN_NAME_PREFIX \u003d {INGRESS_DIRECTION: \u0027i\u0027,"},{"line_number":37,"context_line":"                     EGRESS_DIRECTION: \u0027o\u0027}"},{"line_number":38,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":39,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027qvb\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesFirewallDriver(firewall.FirewallDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUY%3D","line":39,"updated":"2013-01-11 07:40:43.000000000","message":"OVS_HYBRID_TAP_PREFIX is specific to OVSHybridIptablesFirewallDriver, so I prefer to moving it into the class.\n\nclass OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):\n    OVS_HYBRID_TAP_PREFIX \u003d \u0027qvb\u0027","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"CHAIN_NAME_PREFIX \u003d {INGRESS_DIRECTION: \u0027i\u0027,"},{"line_number":37,"context_line":"                     EGRESS_DIRECTION: \u0027o\u0027}"},{"line_number":38,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":39,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027qvb\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesFirewallDriver(firewall.FirewallDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fo0E%3D","line":39,"in_reply_to":"AAAAM3%2F%2FpUY%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _iptables_direction(self):"},{"line_number":136,"context_line":"        return {INGRESS_DIRECTION: \u0027physdev-out\u0027,"},{"line_number":137,"context_line":"                EGRESS_DIRECTION: \u0027physdev-in\u0027}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _add_chain(self, port, direction):"},{"line_number":140,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUo%3D","line":137,"updated":"2013-01-11 07:40:43.000000000","message":"Make the dict a class constant. It should be placed before __init__().","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _iptables_direction(self):"},{"line_number":136,"context_line":"        return {INGRESS_DIRECTION: \u0027physdev-out\u0027,"},{"line_number":137,"context_line":"                EGRESS_DIRECTION: \u0027physdev-in\u0027}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _add_chain(self, port, direction):"},{"line_number":140,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fo0A%3D","line":137,"in_reply_to":"AAAAM3%2F%2FpUo%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def _get_device_name(self, port):"},{"line_number":300,"context_line":"        return (OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _iptables_direction(self):"},{"line_number":303,"context_line":"        return {INGRESS_DIRECTION: \u0027physdev-in\u0027,"},{"line_number":304,"context_line":"                EGRESS_DIRECTION: \u0027physdev-out\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUk%3D","line":302,"updated":"2013-01-11 07:40:43.000000000","message":"While I understand the background why the direction need to be flipped, it is a little tricky and you should add a note here.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def _get_device_name(self, port):"},{"line_number":300,"context_line":"        return (OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _iptables_direction(self):"},{"line_number":303,"context_line":"        return {INGRESS_DIRECTION: \u0027physdev-in\u0027,"},{"line_number":304,"context_line":"                EGRESS_DIRECTION: \u0027physdev-out\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Foz8%3D","line":302,"in_reply_to":"AAAAM3%2F%2FpUk%3D","updated":"2013-01-11 19:21:40.000000000","message":"This is from my misunderstandings about the driver.  This code works, but I simplified it on new patch set.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"CHAIN_NAME_PREFIX \u003d {INGRESS_DIRECTION: \u0027i\u0027,"},{"line_number":37,"context_line":"                     EGRESS_DIRECTION: \u0027o\u0027}"},{"line_number":38,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":39,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesFirewallDriver(firewall.FirewallDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpSo%3D","line":39,"updated":"2013-01-11 07:58:37.000000000","message":"Why is it changed from the previous patch? Doesn\u0027t a name of a tap device name created by Hybrid VIF driver start with \u0027qvb\u0027?","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"CHAIN_NAME_PREFIX \u003d {INGRESS_DIRECTION: \u0027i\u0027,"},{"line_number":37,"context_line":"                     EGRESS_DIRECTION: \u0027o\u0027}"},{"line_number":38,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":39,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesFirewallDriver(firewall.FirewallDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fn4Y%3D","line":39,"in_reply_to":"AAAAM3%2F%2FpRs%3D","updated":"2013-01-12 08:14:49.000000000","message":"Sound reasonable. Hybrid VIF driver creates a tap device for VM with the same way as Bridge VIF driver.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"CHAIN_NAME_PREFIX \u003d {INGRESS_DIRECTION: \u0027i\u0027,"},{"line_number":37,"context_line":"                     EGRESS_DIRECTION: \u0027o\u0027}"},{"line_number":38,"context_line":"LINUX_DEV_LEN \u003d 14"},{"line_number":39,"context_line":"OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesFirewallDriver(firewall.FirewallDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpRs%3D","line":39,"in_reply_to":"AAAAM3%2F%2FpSo%3D","updated":"2013-01-11 19:23:22.000000000","message":"Sorry I found the misunderstandings when I wrote doc.\nThe tap name starts with tap even if for hybrid VIF driver, so I changed back to the tap in Patchset 4.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"from quantum.common import constants"},{"line_number":23,"context_line":"from quantum.openstack.common import cfg"},{"line_number":24,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"SG_CHAIN \u003d \u0027sg-chain\u0027"},{"line_number":28,"context_line":"INGRESS_DIRECTION \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fm6I%3D","line":25,"updated":"2013-01-14 06:21:21.000000000","message":"HACKING.rst states that there should be two blank lines after imports","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"from quantum.common import constants"},{"line_number":23,"context_line":"from quantum.openstack.common import cfg"},{"line_number":24,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"SG_CHAIN \u003d \u0027sg-chain\u0027"},{"line_number":28,"context_line":"INGRESS_DIRECTION \u003d \u0027ingress\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FmA4%3D","line":25,"in_reply_to":"AAAAM3%2F%2Fm6I%3D","updated":"2013-01-14 20:57:35.000000000","message":"Done","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"},{"line_number":290,"context_line":"    OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _get_device_name(self, port):"},{"line_number":293,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fndc%3D","line":290,"updated":"2013-01-13 05:31:13.000000000","message":"This could be problematic. The tap device is created by Nova. How can we ensure that it has prefix tap?","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"},{"line_number":290,"context_line":"    OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _get_device_name(self, port):"},{"line_number":293,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Flyg%3D","line":290,"in_reply_to":"AAAAM3%2F%2Fl%2Fs%3D","updated":"2013-01-14 21:10:10.000000000","message":"We shouldn\u0027t be assuming that in the long term. As with other peices of similar information, Quantum should be passing its required VIF device name across to Nova. I have provided a recent patch to Nova which makes it possible for network drivers in Nova to inform hypervisor drivers what VIF device name to use\n\nIf Quantum can pass the name over to Nova, then you merely need update this logic here:\n\nhttps://review.openstack.org/#/c/19120/6/nova/network/quantumv2/api.py","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"},{"line_number":290,"context_line":"    OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _get_device_name(self, port):"},{"line_number":293,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FlmY%3D","line":290,"in_reply_to":"AAAAM3%2F%2Flyg%3D","updated":"2013-01-14 22:14:11.000000000","message":"OK we can fix this in another patch.","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"},{"line_number":290,"context_line":"    OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _get_device_name(self, port):"},{"line_number":293,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fl%2Fs%3D","line":290,"in_reply_to":"AAAAM3%2F%2Fndc%3D","updated":"2013-01-14 20:57:35.000000000","message":"Libvirt creates tap device prefixed with \u0027tap\u0027 on bridge connection. so we can assume this. Linuxbridge plugin doing same thing.  In future, IMO, tap name should be managed in server side.","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.iptables.defer_apply_off()"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"class OVSHybridIptablesFirewallDriver(IptablesFirewallDriver):"},{"line_number":291,"context_line":"    OVS_HYBRID_TAP_PREFIX \u003d \u0027tap\u0027"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _port_chain_name(self, port, direction):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FUMI%3D","line":290,"updated":"2013-01-29 09:21:20.000000000","message":"why not use open flow?\nI remember we introduce the LibvirtHybridOVSBridgeDriver on nova side because we cannot support the nova\u0027s SG feature by pure ovs bridge. Since we are implement the SG features here, why do we still use it? how about implementing it by pure open flow?","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # with extra prefix"},{"line_number":296,"context_line":"        # ( see comment in iptables_manager )"},{"line_number":297,"context_line":"        return \u0027%s%s\u0027 % (CHAIN_NAME_PREFIX[direction],"},{"line_number":298,"context_line":"                         port[\u0027device\u0027][0:10])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def _get_device_name(self, port):"},{"line_number":301,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2Fa%2BM%3D","line":298,"updated":"2013-01-23 04:49:16.000000000","message":"This logic is very confusing. I feel frustrated with logics handling these kind of length.\n\nMax length of a chain name should be ensured by iptables_manager. It should not depend on a logic of a user of iptables_manager (iptables_firewall here). A comment does not check the code!\n\nMy suggestion is:\n- iptables_manager ensures max length of a chain name is less than 28 chars.\n- _port_chain_name() here just generates a chain name:\n  CHAIN_NAME_PREFIX[direction] + port[\u0027device\u0027]\n- iptables_manager truncates the chain name\n\nIf you want to truncate a port chain name with 10 chars, first defined the maximum length of a port chain name in iptables_manager and refer to it here.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # with extra prefix"},{"line_number":296,"context_line":"        # ( see comment in iptables_manager )"},{"line_number":297,"context_line":"        return \u0027%s%s\u0027 % (CHAIN_NAME_PREFIX[direction],"},{"line_number":298,"context_line":"                         port[\u0027device\u0027][0:10])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def _get_device_name(self, port):"},{"line_number":301,"context_line":"        return (self.OVS_HYBRID_TAP_PREFIX + port[\u0027device\u0027])[:LINUX_DEV_LEN]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FZTA%3D","line":298,"in_reply_to":"AAAAM3%2F%2Fa%2BM%3D","updated":"2013-01-24 06:35:33.000000000","message":"I agree with your comment.\nI feel it should be in different patch, because it is kind of refactoring of iptables_manager.\nI filed this as a bug. https://bugs.launchpad.net/quantum/+bug/1103838","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"}],"quantum/agent/securitygroups_rpc.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ca28e7402218dc6da3a691cc11bed8906f87a3ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpQ4%3D","line":29,"updated":"2013-01-11 09:12:07.000000000","message":"If we write this option in \u0027etc/\u0027 configuration sample file that good for user","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpSk%3D","line":29,"updated":"2013-01-11 07:58:37.000000000","message":"It may be better firewall_driver option is defined in the firewall module since firewall module provides a variation of firewall implementations.\n\nHonestly I am not sure which is better.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fn4g%3D","line":29,"in_reply_to":"AAAAM3%2F%2FpRk%3D","updated":"2013-01-12 08:14:49.000000000","message":"Sounds reasonable","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpRk%3D","line":29,"in_reply_to":"AAAAM3%2F%2FpSk%3D","updated":"2013-01-11 19:23:22.000000000","message":"SecurityGroupAgentRpcMixin is only users of this parameter. so IMO we should place it here. \nFirewall driver could be placed anyware including outside of quantum.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpSg%3D","line":32,"updated":"2013-01-11 07:58:37.000000000","message":"register_opts is usually called in main() of each agent.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fn4c%3D","line":32,"in_reply_to":"AAAAM3%2F%2FpRo%3D","updated":"2013-01-12 08:14:49.000000000","message":"I just looked the style of dhcp-agent or some other agents. On the other hand OVS and LB agents are doing register_opts in module level. It is good to register_opts here.","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FpRo%3D","line":32,"in_reply_to":"AAAAM3%2F%2FpSg%3D","updated":"2013-01-11 19:23:22.000000000","message":"Security group extension is doing same thing.\nIs there any reason we should do it on main() ?","commit_id":"43f0ceafa55ad40386a2a6d4645d168559e7f96b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"SG_RPC_VERSION \u003d \"1.1\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FnUU%3D","line":28,"updated":"2013-01-13 15:37:42.000000000","message":"Can you please add this as a comment to the configuration file.","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"SG_RPC_VERSION \u003d \"1.1\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"security_group_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027quantum.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":31,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fl%2FU%3D","line":28,"in_reply_to":"AAAAM3%2F%2FnUU%3D","updated":"2013-01-14 20:57:35.000000000","message":"Done","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":"        LOG.debug(_(\"Init firewall settings\"))"},{"line_number":88,"context_line":"        driver_klass \u003d importutils.import_class("},{"line_number":89,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver)"},{"line_number":90,"context_line":"        self.firewall \u003d driver_klass()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def prepare_devices_filter(self, device_ids):"},{"line_number":93,"context_line":"        if not device_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FhHg%3D","line":90,"updated":"2013-01-17 17:36:41.000000000","message":"You can use import_object for this purpose.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":"        LOG.debug(_(\"Init firewall settings\"))"},{"line_number":88,"context_line":"        driver_klass \u003d importutils.import_class("},{"line_number":89,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver)"},{"line_number":90,"context_line":"        self.firewall \u003d driver_klass()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def prepare_devices_filter(self, device_ids):"},{"line_number":93,"context_line":"        if not device_ids:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg90%3D","line":90,"in_reply_to":"AAAAM3%2F%2FhHg%3D","updated":"2013-01-17 18:43:22.000000000","message":"Thanks!","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SecurityGroupServerRpcApiMixin(object):"},{"line_number":36,"context_line":"    \"\"\"A mix-in that enable SecurityGroup support in plugin rpc"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    def security_group_rules_for_devices(self, context, devices):"},{"line_number":39,"context_line":"        LOG.debug(_(\"Get security group rules \""},{"line_number":40,"context_line":"                    \"for devices via rpc %r\"), devices)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FUME%3D","line":37,"updated":"2013-01-29 09:21:20.000000000","message":"add sg_agent \u003d None\nso that we will not confused by the self.sg_agent access.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SecurityGroupServerRpcApiMixin(object):"},{"line_number":36,"context_line":"    \"\"\"A mix-in that enable SecurityGroup support in plugin rpc"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":"    def security_group_rules_for_devices(self, context, devices):"},{"line_number":39,"context_line":"        LOG.debug(_(\"Get security group rules \""},{"line_number":40,"context_line":"                    \"for devices via rpc %r\"), devices)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FTXk%3D","line":37,"in_reply_to":"AAAAM3%2F%2FUME%3D","updated":"2013-01-29 19:11:18.000000000","message":"Done","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"}],"quantum/db/l3_db.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":491,"context_line":"                        \u0027tenant than Floating IP %(floatingip_id)s and \u0027"},{"line_number":492,"context_line":"                        \u0027therefore cannot be bound.\u0027)"},{"line_number":493,"context_line":"            else:"},{"line_number":494,"context_line":"                msg \u003d _(\u0027Cannot create floating IP and bind it to \u0027"},{"line_number":495,"context_line":"                        \u0027Port %(port_id)s, since that port is owned by a \u0027"},{"line_number":496,"context_line":"                        \u0027different tenant.\u0027)"},{"line_number":497,"context_line":"            raise q_exc.BadRequest(resource\u003d\u0027floatingip\u0027, msg\u003dmsg % locals())"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FhHI%3D","line":494,"updated":"2013-01-17 17:36:41.000000000","message":"Hmm... It\u0027s not related to this patch.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":491,"context_line":"                        \u0027tenant than Floating IP %(floatingip_id)s and \u0027"},{"line_number":492,"context_line":"                        \u0027therefore cannot be bound.\u0027)"},{"line_number":493,"context_line":"            else:"},{"line_number":494,"context_line":"                msg \u003d _(\u0027Cannot create floating IP and bind it to \u0027"},{"line_number":495,"context_line":"                        \u0027Port %(port_id)s, since that port is owned by a \u0027"},{"line_number":496,"context_line":"                        \u0027different tenant.\u0027)"},{"line_number":497,"context_line":"            raise q_exc.BadRequest(resource\u003d\u0027floatingip\u0027, msg\u003dmsg % locals())"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg9w%3D","line":494,"in_reply_to":"AAAAM3%2F%2FhHI%3D","updated":"2013-01-17 18:43:22.000000000","message":"Sorry this is my mistake.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"}],"quantum/db/migration/alembic_migrations/versions/3cb5d900c5de_security_groups.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027quantum.plugins.linuxbridge.lb_quantum_plugin.LinuxBridgePluginV2\u0027,"},{"line_number":34,"context_line":"    \u0027quantum.plugins.openvswitch.ovs_quantum_plugin.OVSQuantumPluginV2\u0027"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FD%2Bg%3D","line":34,"updated":"2013-02-08 13:16:49.000000000","message":"You need to rebase since NVP security group support has been merged and the patch also updated this file.","commit_id":"1bedc6510c7a1660cf378a85efc2ce1596b933cc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027quantum.plugins.linuxbridge.lb_quantum_plugin.LinuxBridgePluginV2\u0027,"},{"line_number":34,"context_line":"    \u0027quantum.plugins.openvswitch.ovs_quantum_plugin.OVSQuantumPluginV2\u0027"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FDkg%3D","line":34,"in_reply_to":"AAAAM3%2F%2FD%2Bg%3D","updated":"2013-02-08 19:03:35.000000000","message":"Done","commit_id":"1bedc6510c7a1660cf378a85efc2ce1596b933cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027quantum.plugins.linuxbridge.lb_quantum_plugin.LinuxBridgePluginV2\u0027,"},{"line_number":34,"context_line":"    \u0027quantum.plugins.nicira.nicira_nvp_plugin.QuantumPlugin.NvpPluginV2\u0027"},{"line_number":35,"context_line":"    \u0027quantum.plugins.openvswitch.ovs_quantum_plugin.OVSQuantumPluginV2\u0027"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2FCi8%3D","line":34,"updated":"2013-02-09 22:41:46.000000000","message":"Needs a comma at the end of the line.","commit_id":"062c261946a2dd9ae2b85c85c42b5cf384334efc"}],"quantum/db/securitygroups_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":494,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":495,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":496,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":497,"context_line":"        #Note(nati): Need to notify port update here"},{"line_number":498,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FnTw%3D","line":497,"updated":"2013-01-13 15:37:42.000000000","message":"Any reason not to implement this now?","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":494,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":495,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":496,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":497,"context_line":"        #Note(nati): Need to notify port update here"},{"line_number":498,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fl%2B4%3D","line":497,"in_reply_to":"AAAAM3%2F%2FnTw%3D","updated":"2013-01-14 20:57:35.000000000","message":"I updated the confusing comment.\nThis means requesting notification for caller in order to remove duplicated notification call","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":495,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":496,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        #Note(nati): Request notification by retuning True for"},{"line_number":499,"context_line":"        # caller of this method,"},{"line_number":500,"context_line":"        # because another changes in port could invoke notification"},{"line_number":501,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FhHA%3D","line":498,"updated":"2013-01-17 17:36:41.000000000","message":"retuning -\u003e returning\n\nfor -\u003e to","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":495,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":496,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        #Note(nati): Request notification by retuning True for"},{"line_number":499,"context_line":"        # caller of this method,"},{"line_number":500,"context_line":"        # because another changes in port could invoke notification"},{"line_number":501,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg9o%3D","line":498,"in_reply_to":"AAAAM3%2F%2FhHA%3D","updated":"2013-01-17 18:43:22.000000000","message":"Done","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":486,"context_line":"            sgids \u003d [default_sg]"},{"line_number":487,"context_line":"        port[\u0027port\u0027][ext_sg.SECURITYGROUPS] \u003d sgids"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def update_security_group_on_port(self, context, id, port,"},{"line_number":490,"context_line":"                                      original_port, updated_port):"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        need_notify \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgPs%3D","line":489,"updated":"2013-01-18 04:31:26.000000000","message":"I believe this function should be in securitygroups_rpc_base.py not securitygroups_db since this function uses self.notifier","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":486,"context_line":"            sgids \u003d [default_sg]"},{"line_number":487,"context_line":"        port[\u0027port\u0027][ext_sg.SECURITYGROUPS] \u003d sgids"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def update_security_group_on_port(self, context, id, port,"},{"line_number":490,"context_line":"                                      original_port, updated_port):"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        need_notify \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdfk%3D","line":489,"in_reply_to":"AAAAM3%2F%2FgPs%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":508,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":509,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":510,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":513,"context_line":"        # caller of this method,"},{"line_number":514,"context_line":"        # because another changes in port could invoke notification"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgQI%3D","line":511,"updated":"2013-01-18 04:31:26.000000000","message":"Should need_notify \u003d True be set here if the ip address changes?","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":508,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":509,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":510,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":513,"context_line":"        # caller of this method,"},{"line_number":514,"context_line":"        # because another changes in port could invoke notification"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fde0%3D","line":511,"in_reply_to":"AAAAM3%2F%2FgQI%3D","updated":"2013-01-21 20:19:07.000000000","message":"Yes thanks","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":509,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":510,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":513,"context_line":"        # caller of this method,"},{"line_number":514,"context_line":"        # because another changes in port could invoke notification"},{"line_number":515,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgQQ%3D","line":512,"updated":"2013-01-18 04:31:26.000000000","message":"What do you mean by \"because another change in port could invoke notification\"? Isn\u0027t this only true if ext_sg.SECURITYGROUPS in port[\u0027port\u0027]?","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":509,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":510,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":513,"context_line":"        # caller of this method,"},{"line_number":514,"context_line":"        # because another changes in port could invoke notification"},{"line_number":515,"context_line":"        return need_notify"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdes%3D","line":512,"in_reply_to":"AAAAM3%2F%2FgQQ%3D","updated":"2013-01-21 20:19:07.000000000","message":"This code uses port_update notification, and port_update needs the case in which admin_states is updated","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":487,"context_line":"        port[\u0027port\u0027][ext_sg.SECURITYGROUPS] \u003d sgids"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def update_security_group_on_port(self, context, id, port,"},{"line_number":490,"context_line":"                                      original_port, updated_port):"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        need_notify \u003d False"},{"line_number":493,"context_line":"        if ext_sg.SECURITYGROUPS in port[\u0027port\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FcTA%3D","line":490,"updated":"2013-01-22 16:45:01.000000000","message":"In patch set 10 Aaron suggested it should be moved to security_group_rpc. I agree with Aaron since this notification is related to rpc to the agent.","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":487,"context_line":"        port[\u0027port\u0027][ext_sg.SECURITYGROUPS] \u003d sgids"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def update_security_group_on_port(self, context, id, port,"},{"line_number":490,"context_line":"                                      original_port, updated_port):"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        need_notify \u003d False"},{"line_number":493,"context_line":"        if ext_sg.SECURITYGROUPS in port[\u0027port\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FbPY%3D","line":490,"in_reply_to":"AAAAM3%2F%2FcTA%3D","updated":"2013-01-23 00:12:27.000000000","message":"My bad, I missed to delete this method","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"}],"quantum/db/securitygroups_rpc_base.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":83,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":84,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":85,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":86,"context_line":"            need_notify \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        #Note(nati): Request notification by returning True to"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FWCo%3D","line":85,"updated":"2013-01-28 04:37:19.000000000","message":"This method is called by plugins within a transaction context. I\u0027m not 100% sure about this, but shouldn\u0027t the notifier call be moved outside the transaction (i.e. made by the caller based on another returned flag, via a separate method on this class, or via logic in the plugin\u0027s update_port() code as before)?\n\nMy understanding is that we should try to have plugin API methods each do all their DB activity with a single DB transaction, and do anything that might block outside that transaction. I\u0027m not sure if notifier calls are guaranteed not to block, but its possible they are.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":83,"context_line":"                updated_port.get(ext_sg.SECURITYGROUPS))):"},{"line_number":84,"context_line":"            self.notifier.security_groups_member_updated("},{"line_number":85,"context_line":"                context, updated_port.get(ext_sg.SECURITYGROUPS))"},{"line_number":86,"context_line":"            need_notify \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        #Note(nati): Request notification by returning True to"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FTXA%3D","line":85,"in_reply_to":"AAAAM3%2F%2FWCo%3D","updated":"2013-01-29 19:11:18.000000000","message":"Done","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":89,"context_line":"        # caller of this method,"},{"line_number":90,"context_line":"        # because another changes in port could invoke notification"},{"line_number":91,"context_line":"        return need_notify"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FYzc%3D","line":90,"updated":"2013-01-24 14:47:33.000000000","message":"How about changing the description? It is still a little hard to understand.\n-----\nThis method returns a flag which indicates request notification is required and does not perform notification itself. It is because another changes for the port may require notification.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":89,"context_line":"        # caller of this method,"},{"line_number":90,"context_line":"        # because another changes in port could invoke notification"},{"line_number":91,"context_line":"        return need_notify"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FTVI%3D","line":90,"in_reply_to":"AAAAM3%2F%2FXmI%3D","updated":"2013-01-29 19:11:18.000000000","message":"I saw some #Note(name) in nova, so I used it.\n I have removed Note(nati). May be if this is quantum policy, we should write it on Hacking file.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        #Note(nati): Request notification by returning True to"},{"line_number":89,"context_line":"        # caller of this method,"},{"line_number":90,"context_line":"        # because another changes in port could invoke notification"},{"line_number":91,"context_line":"        return need_notify"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FXmI%3D","line":90,"in_reply_to":"AAAAM3%2F%2FYzc%3D","updated":"2013-01-25 05:41:32.000000000","message":"Also, imo adding #Note(nati): should not be included unless it\u0027s a TODO/FIXME. If you are adding your name in case someone has a question about this they can find you that is not needed since git blame will tell them who added this line.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"}],"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":397,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":398,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def __init__(self, context, agent):"},{"line_number":401,"context_line":"        self.context \u003d context"},{"line_number":402,"context_line":"        self.sg_agent \u003d agent"},{"line_number":403,"context_line":"        self.linux_br \u003d agent.linux_br"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FUL8%3D","line":400,"updated":"2013-01-29 09:21:20.000000000","message":"how about changing agent into sg_agent parameter name?","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":397,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":398,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def __init__(self, context, agent):"},{"line_number":401,"context_line":"        self.context \u003d context"},{"line_number":402,"context_line":"        self.sg_agent \u003d agent"},{"line_number":403,"context_line":"        self.linux_br \u003d agent.linux_br"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FTUM%3D","line":400,"in_reply_to":"AAAAM3%2F%2FUL8%3D","updated":"2013-01-29 19:11:18.000000000","message":"Line403 is not security group specific, so I would like to use agent here","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":135,"context_line":"    MAX_VLAN_TAG \u003d 4094"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":138,"context_line":"    # history"},{"line_number":139,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":140,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUU%3D","line":138,"updated":"2013-01-11 07:40:43.000000000","message":"Move 1.0 into the history.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":135,"context_line":"    MAX_VLAN_TAG \u003d 4094"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":138,"context_line":"    # history"},{"line_number":139,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":140,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fozs%3D","line":138,"in_reply_to":"AAAAM3%2F%2FpUU%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.setup_rpc(integ_br)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Security group agent supprot"},{"line_number":174,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpcMixin()"},{"line_number":175,"context_line":"        self.sg_agent.root_helper \u003d self.root_helper"},{"line_number":176,"context_line":"        self.sg_agent.plugin_rpc \u003d self.plugin_rpc"},{"line_number":177,"context_line":"        self.sg_agent.context \u003d self.context"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUM%3D","line":174,"updated":"2013-01-11 07:40:43.000000000","message":"Instantiating a Mix-in class is strange.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.setup_rpc(integ_br)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Security group agent supprot"},{"line_number":174,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpcMixin()"},{"line_number":175,"context_line":"        self.sg_agent.root_helper \u003d self.root_helper"},{"line_number":176,"context_line":"        self.sg_agent.plugin_rpc \u003d self.plugin_rpc"},{"line_number":177,"context_line":"        self.sg_agent.context \u003d self.context"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fozo%3D","line":174,"in_reply_to":"AAAAM3%2F%2FpUM%3D","updated":"2013-01-11 19:21:40.000000000","message":"I added new class here","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":101,"context_line":"    pass"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class OVSSecurityGroupAgent(sg_rpc.SecurityGroupAgentRpcMixin):"},{"line_number":105,"context_line":"    def __init__(self, context, plugin_rpc, root_helper):"},{"line_number":106,"context_line":"        self.context \u003d context"},{"line_number":107,"context_line":"        self.plugin_rpc \u003d plugin_rpc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fjl4%3D","line":104,"updated":"2013-01-17 17:36:41.000000000","message":"(Continued from patch set #3)\n\nIf we can instantiate SecurityGroupAgentRpcMixin without combining other classes, SecurityGroupAgentRpcMixin is no loger a mixin class. That is the reason I said instantiating a mixin class is strange in the previous comment.\n\nA brief explanation about mixin class is available at http://en.wikipedia.org/wiki/Mixin","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":101,"context_line":"    pass"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class OVSSecurityGroupAgent(sg_rpc.SecurityGroupAgentRpcMixin):"},{"line_number":105,"context_line":"    def __init__(self, context, plugin_rpc, root_helper):"},{"line_number":106,"context_line":"        self.context \u003d context"},{"line_number":107,"context_line":"        self.plugin_rpc \u003d plugin_rpc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg5A%3D","line":104,"in_reply_to":"AAAAM3%2F%2Fg9k%3D","updated":"2013-01-18 03:37:26.000000000","message":"Oh... that\u0027s my misread.\nSecurityGroupAgentRpcMixin depends on self.context (or some others if any) and self.context is set in __init__(). That sounds reasonable. Thanks for clarifying.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":101,"context_line":"    pass"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class OVSSecurityGroupAgent(sg_rpc.SecurityGroupAgentRpcMixin):"},{"line_number":105,"context_line":"    def __init__(self, context, plugin_rpc, root_helper):"},{"line_number":106,"context_line":"        self.context \u003d context"},{"line_number":107,"context_line":"        self.plugin_rpc \u003d plugin_rpc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg9k%3D","line":104,"in_reply_to":"AAAAM3%2F%2Fjl4%3D","updated":"2013-01-17 18:43:22.000000000","message":"IMO, security group agent rpc mixin should be mixin class to support LinuxBridge or the other plugins.\nI agree with you Mixin class sould not have instance directry, so I added OVSSecurityGroupAgent class here.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def port_update(self, context, **kwargs):"},{"line_number":222,"context_line":"        LOG.debug(_(\"port_update received\"))"},{"line_number":223,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":224,"context_line":"        if \u0027security_groups\u0027 in port:"},{"line_number":225,"context_line":"            self.sg_agent.refresh_firewall()"},{"line_number":226,"context_line":"        network_type \u003d kwargs.get(\u0027network_type\u0027)"},{"line_number":227,"context_line":"        segmentation_id \u003d kwargs.get(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgPA%3D","line":224,"updated":"2013-01-18 04:31:26.000000000","message":"ext_sg.SECURITYGROUPS","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def port_update(self, context, **kwargs):"},{"line_number":222,"context_line":"        LOG.debug(_(\"port_update received\"))"},{"line_number":223,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":224,"context_line":"        if \u0027security_groups\u0027 in port:"},{"line_number":225,"context_line":"            self.sg_agent.refresh_firewall()"},{"line_number":226,"context_line":"        network_type \u003d kwargs.get(\u0027network_type\u0027)"},{"line_number":227,"context_line":"        segmentation_id \u003d kwargs.get(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdec%3D","line":224,"in_reply_to":"AAAAM3%2F%2FgPA%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":39,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":40,"context_line":"from quantum.plugins.openvswitch.common import config"},{"line_number":41,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":42,"context_line":"from quantum.plugins.openvswitch.common import constants"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FFPA%3D","line":41,"updated":"2013-02-08 13:16:49.000000000","message":"This line should be after L.36","commit_id":"1bedc6510c7a1660cf378a85efc2ce1596b933cc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":39,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":40,"context_line":"from quantum.plugins.openvswitch.common import config"},{"line_number":41,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":42,"context_line":"from quantum.plugins.openvswitch.common import constants"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAM3%2F%2FDko%3D","line":41,"in_reply_to":"AAAAM3%2F%2FFPA%3D","updated":"2013-02-08 19:03:35.000000000","message":"Done","commit_id":"1bedc6510c7a1660cf378a85efc2ce1596b933cc"}],"quantum/plugins/openvswitch/ovs_db_v2.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"68e51ccc326e9813fdb13cd8cfc4a104e4ff98f2","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d []"},{"line_number":323,"context_line":"    for port_in_db, sg_id in port_and_sgs:"},{"line_number":324,"context_line":"        if sg_id:"},{"line_number":325,"context_line":"            port_dict[\u0027security_groups\u0027].append(sg_id)"},{"line_number":326,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"},{"line_number":327,"context_line":"    port_dict[\u0027security_group_source_groups\u0027] \u003d []"},{"line_number":328,"context_line":"    port_dict[\u0027fixed_ips\u0027] \u003d [ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fpis%3D","line":325,"updated":"2013-01-11 01:31:16.000000000","message":"How about:\n\nport_dict[\u0027security_groups\u0027] \u003d [x for _, x in port_and_sgs if x]","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"be70df985822e09b0eede3543d5c45792fb73648","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d []"},{"line_number":323,"context_line":"    for port_in_db, sg_id in port_and_sgs:"},{"line_number":324,"context_line":"        if sg_id:"},{"line_number":325,"context_line":"            port_dict[\u0027security_groups\u0027].append(sg_id)"},{"line_number":326,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"},{"line_number":327,"context_line":"    port_dict[\u0027security_group_source_groups\u0027] \u003d []"},{"line_number":328,"context_line":"    port_dict[\u0027fixed_ips\u0027] \u003d [ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fphs%3D","line":325,"in_reply_to":"AAAAM3%2F%2Fpis%3D","updated":"2013-01-11 01:51:22.000000000","message":"Done","commit_id":"439fc6d96b6b55fe0d3e66d5587fc61c722780f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":302,"context_line":"    return port"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"def get_port_with_securitygroups(port_id):"},{"line_number":306,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":307,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called\"))"},{"line_number":308,"context_line":"    session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUI%3D","line":305,"updated":"2013-01-11 07:40:43.000000000","message":"In linuxbridge a corresponding method is \"get_port_from_device\".  These methods do the same job though the argument is different. It is better to use a same name.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":302,"context_line":"    return port"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"def get_port_with_securitygroups(port_id):"},{"line_number":306,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":307,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called\"))"},{"line_number":308,"context_line":"    session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fozk%3D","line":305,"in_reply_to":"AAAAM3%2F%2FpUI%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":315,"context_line":"    query \u003d query.filter(models_v2.Port.id \u003d\u003d port_id)"},{"line_number":316,"context_line":"    port_and_sgs \u003d query.all()"},{"line_number":317,"context_line":"    if not port_and_sgs:"},{"line_number":318,"context_line":"        return"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpUE%3D","line":318,"updated":"2013-01-11 07:40:43.000000000","message":"return None would be better since this method returns a value.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":315,"context_line":"    query \u003d query.filter(models_v2.Port.id \u003d\u003d port_id)"},{"line_number":316,"context_line":"    port_and_sgs \u003d query.all()"},{"line_number":317,"context_line":"    if not port_and_sgs:"},{"line_number":318,"context_line":"        return"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fozg%3D","line":318,"in_reply_to":"AAAAM3%2F%2FpUE%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":316,"context_line":"    port_and_sgs \u003d query.all()"},{"line_number":317,"context_line":"    if not port_and_sgs:"},{"line_number":318,"context_line":"        return None"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FnTg%3D","line":319,"updated":"2013-01-13 15:37:42.000000000","message":"why not return the port here and then in the plugin append the data?","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":316,"context_line":"    port_and_sgs \u003d query.all()"},{"line_number":317,"context_line":"    if not port_and_sgs:"},{"line_number":318,"context_line":"        return None"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fl%2Bg%3D","line":319,"in_reply_to":"AAAAM3%2F%2FnTg%3D","updated":"2013-01-14 20:57:35.000000000","message":"because we are using port_and_sgs in 321, code looks simpler if we build dict here.","commit_id":"3b176606da52f890b9790cbfffd59ea97bb49888"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"def get_port_from_device(port_id):"},{"line_number":306,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":307,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called\"))"},{"line_number":308,"context_line":"    session \u003d db.get_session()"},{"line_number":309,"context_line":"    sg_binding_port \u003d sg_db.SecurityGroupPortBinding.port_id"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgO4%3D","line":307,"updated":"2013-01-18 04:31:26.000000000","message":"perhaps also including the port_id in this message would be helpful","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"def get_port_from_device(port_id):"},{"line_number":306,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":307,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called\"))"},{"line_number":308,"context_line":"    session \u003d db.get_session()"},{"line_number":309,"context_line":"    sg_binding_port \u003d sg_db.SecurityGroupPortBinding.port_id"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FdeQ%3D","line":307,"in_reply_to":"AAAAM3%2F%2FgO4%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":318,"context_line":"        return None"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["},{"line_number":323,"context_line":"        sg_id for port, sg_id in port_and_sgs if sg_id]"},{"line_number":324,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgOg%3D","line":321,"updated":"2013-01-18 04:31:26.000000000","message":"why not just import this from the db_base_plugin?","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":318,"context_line":"        return None"},{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["},{"line_number":323,"context_line":"        sg_id for port, sg_id in port_and_sgs if sg_id]"},{"line_number":324,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdds%3D","line":321,"in_reply_to":"AAAAM3%2F%2FgOg%3D","updated":"2013-01-21 20:19:07.000000000","message":"I\u0027m following what\u0027s rpc agent doing.","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["},{"line_number":323,"context_line":"        sg_id for port, sg_id in port_and_sgs if sg_id]"},{"line_number":324,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"},{"line_number":325,"context_line":"    port_dict[\u0027security_group_source_groups\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgOs%3D","line":322,"updated":"2013-01-18 04:31:26.000000000","message":"ext_sg.SECURITYGROUPS","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":319,"context_line":"    port \u003d port_and_sgs[0][0]"},{"line_number":320,"context_line":"    plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":321,"context_line":"    port_dict \u003d plugin._make_port_dict(port)"},{"line_number":322,"context_line":"    port_dict[\u0027security_groups\u0027] \u003d ["},{"line_number":323,"context_line":"        sg_id for port, sg_id in port_and_sgs if sg_id]"},{"line_number":324,"context_line":"    port_dict[\u0027security_group_rules\u0027] \u003d []"},{"line_number":325,"context_line":"    port_dict[\u0027security_group_source_groups\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fddo%3D","line":322,"in_reply_to":"AAAAM3%2F%2FgOs%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_port_from_device(port_id):"},{"line_number":307,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":308,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called:port_id: %s\"), port_id)"},{"line_number":309,"context_line":"    session \u003d db.get_session()"},{"line_number":310,"context_line":"    sg_binding_port \u003d sg_db.SecurityGroupPortBinding.port_id"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FYzk%3D","line":308,"updated":"2013-01-24 14:47:33.000000000","message":"(trivial) I prefer to \u0027called (port_id\u003d%s)\u0027 would be better.","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_port_from_device(port_id):"},{"line_number":307,"context_line":"    \"\"\"Get port from database\"\"\""},{"line_number":308,"context_line":"    LOG.debug(_(\"get_port_with_securitygroups() called:port_id: %s\"), port_id)"},{"line_number":309,"context_line":"    session \u003d db.get_session()"},{"line_number":310,"context_line":"    sg_binding_port \u003d sg_db.SecurityGroupPortBinding.port_id"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FTUA%3D","line":308,"in_reply_to":"AAAAM3%2F%2FYzk%3D","updated":"2013-01-29 19:11:18.000000000","message":"Done","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"                      l3_rpc_base.L3RpcCallbackMixin,"},{"line_number":57,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcCallbackMixin):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":60,"context_line":"    # history"},{"line_number":61,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpT8%3D","line":59,"updated":"2013-01-11 07:40:43.000000000","message":"Move 1.0 into the history.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"                      l3_rpc_base.L3RpcCallbackMixin,"},{"line_number":57,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcCallbackMixin):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":60,"context_line":"    # history"},{"line_number":61,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FozU%3D","line":59,"in_reply_to":"AAAAM3%2F%2FpT8%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":526,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":527,"context_line":"            self._ensure_default_security_group_on_port(context, port)"},{"line_number":528,"context_line":"            self._validate_security_groups_on_port(context, port)"},{"line_number":529,"context_line":"            sgids \u003d port[\u0027port\u0027].get(ext_sg.SECURITYGROUPS)"},{"line_number":530,"context_line":"            port \u003d super(OVSQuantumPluginV2, self).create_port(context, port)"},{"line_number":531,"context_line":"            self._process_port_create_security_group("},{"line_number":532,"context_line":"                context, port[\u0027id\u0027], sgids)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpT4%3D","line":529,"updated":"2013-01-11 07:40:43.000000000","message":"Aaron\u0027s patch which will be merged soon is removing _validate_security_groups_on_port(). Please check it.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":526,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":527,"context_line":"            self._ensure_default_security_group_on_port(context, port)"},{"line_number":528,"context_line":"            self._validate_security_groups_on_port(context, port)"},{"line_number":529,"context_line":"            sgids \u003d port[\u0027port\u0027].get(ext_sg.SECURITYGROUPS)"},{"line_number":530,"context_line":"            port \u003d super(OVSQuantumPluginV2, self).create_port(context, port)"},{"line_number":531,"context_line":"            self._process_port_create_security_group("},{"line_number":532,"context_line":"                context, port[\u0027id\u0027], sgids)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FozQ%3D","line":529,"in_reply_to":"AAAAM3%2F%2FpT4%3D","updated":"2013-01-11 19:21:40.000000000","message":"I got it. I\u0027ll remove this here.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":542,"context_line":"        port \u003d super(OVSQuantumPluginV2, self).get_port(context, id, fields)"},{"line_number":543,"context_line":"        self._extend_port_dict_security_group(context, port)"},{"line_number":544,"context_line":"        return self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":545,"context_line":"                            fields)"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpTg%3D","line":543,"updated":"2013-01-11 07:40:43.000000000","message":"Please use the same style as linux bridge.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":542,"context_line":"        port \u003d super(OVSQuantumPluginV2, self).get_port(context, id, fields)"},{"line_number":543,"context_line":"        self._extend_port_dict_security_group(context, port)"},{"line_number":544,"context_line":"        return self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":545,"context_line":"                            fields)"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Foy4%3D","line":543,"in_reply_to":"AAAAM3%2F%2FpTg%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":549,"context_line":"                                                          fields)"},{"line_number":550,"context_line":"        #TODO(nati) filter by security group"},{"line_number":551,"context_line":"        for port in ports:"},{"line_number":552,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":553,"context_line":"        return [self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":554,"context_line":"                             fields) for port in ports]"},{"line_number":555,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpTk%3D","line":552,"updated":"2013-01-11 07:40:43.000000000","message":"Please use the same style as linux bridge.","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":549,"context_line":"                                                          fields)"},{"line_number":550,"context_line":"        #TODO(nati) filter by security group"},{"line_number":551,"context_line":"        for port in ports:"},{"line_number":552,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":553,"context_line":"        return [self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":554,"context_line":"                             fields) for port in ports]"},{"line_number":555,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Foy0%3D","line":552,"in_reply_to":"AAAAM3%2F%2FpTk%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":560,"context_line":"        session \u003d context.session"},{"line_number":561,"context_line":"        port_updated \u003d False"},{"line_number":562,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":563,"context_line":"            # delete the port binding and read it with the new rules"},{"line_number":564,"context_line":"            if ext_sg.SECURITYGROUPS in port[\u0027port\u0027]:"},{"line_number":565,"context_line":"                self._delete_port_security_group_bindings(context, id)"},{"line_number":566,"context_line":"                self._process_port_create_security_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpTc%3D","line":563,"updated":"2013-01-11 07:40:43.000000000","message":"L.563-570 is exactly same as that in linux bridge. Can\u0027t we make it a common method?","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":560,"context_line":"        session \u003d context.session"},{"line_number":561,"context_line":"        port_updated \u003d False"},{"line_number":562,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":563,"context_line":"            # delete the port binding and read it with the new rules"},{"line_number":564,"context_line":"            if ext_sg.SECURITYGROUPS in port[\u0027port\u0027]:"},{"line_number":565,"context_line":"                self._delete_port_security_group_bindings(context, id)"},{"line_number":566,"context_line":"                self._process_port_create_security_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fovs%3D","line":563,"in_reply_to":"AAAAM3%2F%2FpTc%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":575,"context_line":"        if original_port[\u0027admin_state_up\u0027] !\u003d port[\u0027admin_state_up\u0027]:"},{"line_number":576,"context_line":"            port_updated \u003d True"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if (original_port[\u0027fixed_ips\u0027] !\u003d port[\u0027fixed_ips\u0027] or"},{"line_number":579,"context_line":"            not utils.compare_elements("},{"line_number":580,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":581,"context_line":"                port.get(ext_sg.SECURITYGROUPS))):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FpTQ%3D","line":578,"updated":"2013-01-11 07:40:43.000000000","message":"L.578-583 is exactly same as that in linux bridge. Can\u0027t we make it a common method?","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":575,"context_line":"        if original_port[\u0027admin_state_up\u0027] !\u003d port[\u0027admin_state_up\u0027]:"},{"line_number":576,"context_line":"            port_updated \u003d True"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if (original_port[\u0027fixed_ips\u0027] !\u003d port[\u0027fixed_ips\u0027] or"},{"line_number":579,"context_line":"            not utils.compare_elements("},{"line_number":580,"context_line":"                original_port.get(ext_sg.SECURITYGROUPS),"},{"line_number":581,"context_line":"                port.get(ext_sg.SECURITYGROUPS))):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fovo%3D","line":578,"in_reply_to":"AAAAM3%2F%2FpTQ%3D","updated":"2013-01-11 19:21:40.000000000","message":"Done","commit_id":"806add87d8d5870380f090354ee56ad237e25d2d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        session \u003d context.session"},{"line_number":429,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":430,"context_line":"            #set up default security groups"},{"line_number":431,"context_line":"            tenant_id \u003d self._get_tenant_id_for_create("},{"line_number":432,"context_line":"                context, network[\u0027network\u0027])"},{"line_number":433,"context_line":"            self._ensure_default_security_group(context, tenant_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgOc%3D","line":430,"updated":"2013-01-18 04:31:26.000000000","message":"nit: I would put lines 430-433 outside of the transaction since this might as well complete even of create_network fails, it also shortens the length of time the db needs to be locked for.","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        session \u003d context.session"},{"line_number":429,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":430,"context_line":"            #set up default security groups"},{"line_number":431,"context_line":"            tenant_id \u003d self._get_tenant_id_for_create("},{"line_number":432,"context_line":"                context, network[\u0027network\u0027])"},{"line_number":433,"context_line":"            self._ensure_default_security_group(context, tenant_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fddg%3D","line":430,"in_reply_to":"AAAAM3%2F%2FgOc%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":530,"context_line":"            self._process_port_create_security_group("},{"line_number":531,"context_line":"                context, port[\u0027id\u0027], sgids)"},{"line_number":532,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":533,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":534,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":535,"context_line":"        else:"},{"line_number":536,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgN0%3D","line":533,"updated":"2013-01-18 04:31:26.000000000","message":"What is the reason for lines 533-534?","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":530,"context_line":"            self._process_port_create_security_group("},{"line_number":531,"context_line":"                context, port[\u0027id\u0027], sgids)"},{"line_number":532,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":533,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":534,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":535,"context_line":"        else:"},{"line_number":536,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FddQ%3D","line":533,"in_reply_to":"AAAAM3%2F%2FgN0%3D","updated":"2013-01-21 20:19:07.000000000","message":"Security group should allow dhcp packet. so we need to notify ip creation of dhcp ips.","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":538,"context_line":"        return self._extend_port_dict_binding(context, port)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":541,"context_line":"        port \u003d super(OVSQuantumPluginV2, self).get_port(context, id, fields)"},{"line_number":542,"context_line":"        self._extend_port_dict_security_group(context, port)"},{"line_number":543,"context_line":"        self._extend_port_dict_binding(context, port)"},{"line_number":544,"context_line":"        return self._fields(port, fields)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgNo%3D","line":541,"updated":"2013-01-18 04:31:26.000000000","message":"Lines 541-543 should be within with session.begin(subtransactions\u003dTrue):","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":538,"context_line":"        return self._extend_port_dict_binding(context, port)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":541,"context_line":"        port \u003d super(OVSQuantumPluginV2, self).get_port(context, id, fields)"},{"line_number":542,"context_line":"        self._extend_port_dict_security_group(context, port)"},{"line_number":543,"context_line":"        self._extend_port_dict_binding(context, port)"},{"line_number":544,"context_line":"        return self._fields(port, fields)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FddI%3D","line":541,"in_reply_to":"AAAAM3%2F%2FgNo%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":544,"context_line":"        return self._fields(port, fields)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":547,"context_line":"        ports \u003d super(OVSQuantumPluginV2, self).get_ports(context, filters,"},{"line_number":548,"context_line":"                                                          fields)"},{"line_number":549,"context_line":"        #TODO(nati) filter by security group"},{"line_number":550,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgNc%3D","line":547,"updated":"2013-01-18 04:31:26.000000000","message":"Ditto above commit","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":544,"context_line":"        return self._fields(port, fields)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":547,"context_line":"        ports \u003d super(OVSQuantumPluginV2, self).get_ports(context, filters,"},{"line_number":548,"context_line":"                                                          fields)"},{"line_number":549,"context_line":"        #TODO(nati) filter by security group"},{"line_number":550,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdc0%3D","line":547,"in_reply_to":"AAAAM3%2F%2FgNc%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":553,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def update_port(self, context, id, port):"},{"line_number":556,"context_line":"        original_port \u003d super(OVSQuantumPluginV2, self).get_port(context, id)"},{"line_number":557,"context_line":"        session \u003d context.session"},{"line_number":558,"context_line":"        need_port_update_notify \u003d False"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgNE%3D","line":556,"updated":"2013-01-18 04:31:26.000000000","message":"Should be after line 560","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":553,"context_line":"        return [self._fields(port, fields) for port in ports]"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def update_port(self, context, id, port):"},{"line_number":556,"context_line":"        original_port \u003d super(OVSQuantumPluginV2, self).get_port(context, id)"},{"line_number":557,"context_line":"        session \u003d context.session"},{"line_number":558,"context_line":"        need_port_update_notify \u003d False"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdco%3D","line":556,"in_reply_to":"AAAAM3%2F%2FgNE%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":533,"context_line":"            self._process_port_create_security_group("},{"line_number":534,"context_line":"                context, port[\u0027id\u0027], sgids)"},{"line_number":535,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":536,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":537,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":538,"context_line":"        else:"},{"line_number":539,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FcS0%3D","line":536,"updated":"2013-01-22 16:45:01.000000000","message":"Could you add a note to describe why L.536-537 is required?\nIt would be helpful to maintain the code later.","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":533,"context_line":"            self._process_port_create_security_group("},{"line_number":534,"context_line":"                context, port[\u0027id\u0027], sgids)"},{"line_number":535,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":536,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":537,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":538,"context_line":"        else:"},{"line_number":539,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FbPA%3D","line":536,"in_reply_to":"AAAAM3%2F%2FcS0%3D","updated":"2013-01-23 00:12:27.000000000","message":"Done","commit_id":"b0f87bf699461d705522e737cf7efbb2a7400eaa"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":535,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":536,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":537,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":538,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":539,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":540,"context_line":"        else:"},{"line_number":541,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2Fa%2BE%3D","line":538,"updated":"2013-01-23 04:49:16.000000000","message":"We need to inform dhcp ip address when a port for dhcp server is deleted. enable_dhcp in subnet may be changed by update_subnet. The same thing can say to linux bridge plugin.\n\nThe logic like this is important, so it should be implemented as a common logic even if the logic is very short. security_group_rpc_base is a good place.\n\nDon\u0027t we need to take care the same thing for update_port? \nIMO, we do not need to take care of it since update device_owner is set by programs (nova vif plugiing, dhcp-agent or so on).","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":535,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":536,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":537,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":538,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":539,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":540,"context_line":"        else:"},{"line_number":541,"context_line":"            self.notifier.security_groups_member_updated("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAM3%2F%2FZSs%3D","line":538,"in_reply_to":"AAAAM3%2F%2Fa%2BE%3D","updated":"2013-01-24 06:35:33.000000000","message":"Thank you for your pointing this \nsince this affects linuxbridge, I\u0027ll work on this on separate patch\nhttps://bugs.launchpad.net/quantum/+bug/1103840","commit_id":"a0272c2cea42fb801e419b20a8b1bc7e2c7ec340"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"# @author: Dave Lapsley, Nicira Networks, Inc."},{"line_number":20,"context_line":"# @author: Aaron Rosen, Nicira Networks, Inc."},{"line_number":21,"context_line":"# @author: Bob Kukura, Red Hat, Inc."},{"line_number":22,"context_line":"# @author: Nachi Ueno, NTT MCL, Inc."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2FFnk%3D","line":22,"updated":"2013-02-07 14:44:58.000000000","message":"do we need these?","commit_id":"04b8e1c359bea3b026f44138b715ca5eb32b1d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"# @author: Dave Lapsley, Nicira Networks, Inc."},{"line_number":20,"context_line":"# @author: Aaron Rosen, Nicira Networks, Inc."},{"line_number":21,"context_line":"# @author: Bob Kukura, Red Hat, Inc."},{"line_number":22,"context_line":"# @author: Nachi Ueno, NTT MCL, Inc."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2FFP4%3D","line":22,"in_reply_to":"AAAAM3%2F%2FFnk%3D","updated":"2013-02-07 18:35:07.000000000","message":"I\u0027m not sure, I just folllow the style of this file. \nI\u0027ll remove this line :)","commit_id":"04b8e1c359bea3b026f44138b715ca5eb32b1d44"}],"quantum/tests/unit/openvswitch/test_ovs_security_group.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class TestOpenvswitchSecurityGroups(OpenvswitchSecurityGroupsTestCase,"},{"line_number":56,"context_line":"                                    test_sg.TestSecurityGroups):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_security_group_rule_updated(self):"},{"line_number":59,"context_line":"        name \u003d \u0027webservers\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FgMs%3D","line":56,"updated":"2013-01-18 04:31:26.000000000","message":"This is the same code that is here: https://github.com/openstack/quantum/blob/master/quantum/tests/unit/linuxbridge/test_lb_security_group.py#L58 \n\nWhy can\u0027t these tests go in https://github.com/openstack/quantum/blob/master/quantum/tests/unit/test_security_groups_rpc.py ?","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class TestOpenvswitchSecurityGroups(OpenvswitchSecurityGroupsTestCase,"},{"line_number":56,"context_line":"                                    test_sg.TestSecurityGroups):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_security_group_rule_updated(self):"},{"line_number":59,"context_line":"        name \u003d \u0027webservers\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Fdbg%3D","line":56,"in_reply_to":"AAAAM3%2F%2FgMs%3D","updated":"2013-01-21 20:19:07.000000000","message":"Done","commit_id":"7e23069dfdc501520dd2a9058cc2e63cb2d9eb56"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2FFng%3D","line":3,"updated":"2013-02-07 14:44:58.000000000","message":"2013","commit_id":"04b8e1c359bea3b026f44138b715ca5eb32b1d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAM3%2F%2FFPo%3D","line":3,"in_reply_to":"AAAAM3%2F%2FFng%3D","updated":"2013-02-07 18:35:07.000000000","message":"Done","commit_id":"04b8e1c359bea3b026f44138b715ca5eb32b1d44"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"    pass"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class TestOpenvswithSecurityGroupsXML(TestOpenvswitchSecurityGroups):"},{"line_number":62,"context_line":"    fmt \u003d \u0027xml\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2FCxE%3D","line":61,"updated":"2013-02-09 15:09:26.000000000","message":"Openvswith -\u003e Openvswitch","commit_id":"062c261946a2dd9ae2b85c85c42b5cf384334efc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":"                    res \u003d self.deserialize(self.fmt,"},{"line_number":82,"context_line":"                                           req.get_response(self.api))"},{"line_number":83,"context_line":"                    port_id \u003d res[\u0027port\u0027][\u0027id\u0027]"},{"line_number":84,"context_line":"                    port_dict \u003d ovs_db_v2.get_port_from_device("},{"line_number":85,"context_line":"                        port_id)"},{"line_number":86,"context_line":"                    self.assertEqual(port_id, port_dict[\u0027id\u0027])"},{"line_number":87,"context_line":"                    self.assertEqual([security_group_id],"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2FCic%3D","line":84,"updated":"2013-02-09 22:41:46.000000000","message":"It is better to call get_port_from_device in OVS plugin rather than ovs_db_v2. If so, we can SecurityGroupDB test into SecurityGroup test.","commit_id":"062c261946a2dd9ae2b85c85c42b5cf384334efc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(None, port_dict)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class TestOpenvswithSecurityGroupsDBXML(TestOpenvswitchSecurityGroupsDB):"},{"line_number":100,"context_line":"    fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2FCxA%3D","line":99,"updated":"2013-02-09 15:09:26.000000000","message":"Openvswith -\u003e Openvswitch","commit_id":"062c261946a2dd9ae2b85c85c42b5cf384334efc"}],"quantum/tests/unit/test_security_groups_rpc.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def _regex(self, value):"},{"line_number":1032,"context_line":"        value \u003d value.replace(\u0027physdev-INGRESS\u0027, self.PHYSDEV_INGRESS)"},{"line_number":1033,"context_line":"        value \u003d value.replace(\u0027physdev-EGRESS\u0027, self.PHYSDEV_EGRESS)"},{"line_number":1034,"context_line":"        value \u003d value.replace(\u0027\\n\u0027, \u0027\\\\n\u0027)"},{"line_number":1035,"context_line":"        value \u003d value.replace(\u0027[\u0027, \u0027\\[\u0027)"},{"line_number":1036,"context_line":"        value \u003d value.replace(\u0027]\u0027, \u0027\\]\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FhFs%3D","line":1033,"updated":"2013-01-17 17:36:41.000000000","message":"These are no longer needed?","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def _regex(self, value):"},{"line_number":1032,"context_line":"        value \u003d value.replace(\u0027physdev-INGRESS\u0027, self.PHYSDEV_INGRESS)"},{"line_number":1033,"context_line":"        value \u003d value.replace(\u0027physdev-EGRESS\u0027, self.PHYSDEV_EGRESS)"},{"line_number":1034,"context_line":"        value \u003d value.replace(\u0027\\n\u0027, \u0027\\\\n\u0027)"},{"line_number":1035,"context_line":"        value \u003d value.replace(\u0027[\u0027, \u0027\\[\u0027)"},{"line_number":1036,"context_line":"        value \u003d value.replace(\u0027]\u0027, \u0027\\]\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fg9c%3D","line":1033,"in_reply_to":"AAAAM3%2F%2FhFs%3D","updated":"2013-01-17 18:43:22.000000000","message":"When we support security group for router, this direction may be different, so I wanna keep this coding for extensibility.","commit_id":"c5a7b7ff08e45990108d23be9926aec826348fae"}]}
