)]}'
{"quantum/agent/common/validate.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Paul Michali, Cisco Systems, Inc."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def core_attributes(attributes):"},{"line_number":21,"context_line":"    \u0027\u0027\u0027Validate core configuration attributes."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Make sure that the mandatory core attributes are present and,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FdH4%3D","line":20,"updated":"2013-01-21 22:09:11.000000000","message":"Wouldn\u0027t be too keen on the terminology here - we call them \"config options\" in cfg so why refer to them as attributes in quantum?","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Paul Michali, Cisco Systems, Inc."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def core_attributes(attributes):"},{"line_number":21,"context_line":"    \u0027\u0027\u0027Validate core configuration attributes."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Make sure that the mandatory core attributes are present and,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcaI%3D","line":20,"in_reply_to":"AAAAM3%2F%2FdH4%3D","updated":"2013-01-22 13:24:12.000000000","message":"OK. New to OS, so not very familiar with the terminology. Thanks for the feedback.","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    if attributes.core_plugin is None:"},{"line_number":28,"context_line":"        raise Exception(_(\u0027Quantum core_plugin not configured!\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FdIA%3D","line":28,"updated":"2013-01-21 22:09:11.000000000","message":"Why not just mark core_plugin as required? i.e. declare it using:\n\n  cfg.StrOpt(\u0027core_plugin\u0027, required\u003dTrue)\n\nthen cfg will do this validation for you","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    if attributes.core_plugin is None:"},{"line_number":28,"context_line":"        raise Exception(_(\u0027Quantum core_plugin not configured!\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fb80%3D","line":28,"in_reply_to":"AAAAM3%2F%2FcUA%3D","updated":"2013-01-22 20:03:36.000000000","message":"OK, will work through that approach.  I see that the tests, load a test config file, without core_plugin set and then override it after the config.parse(). Will move override up and see how it works out.\n\nAlso, I see that the whole test suite seems to hang at quantum.tests.unit.nicira.test_nicra_plugin when running test_create_networks_bulk_native in class TestNiciraNeworkV2. Not sure why it totally hangs. Any comments?","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    if attributes.core_plugin is None:"},{"line_number":28,"context_line":"        raise Exception(_(\u0027Quantum core_plugin not configured!\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcUA%3D","line":28,"in_reply_to":"AAAAM3%2F%2FcaM%3D","updated":"2013-01-22 13:45:15.000000000","message":"One - it\u0027s hard to imagine any code in quantum that uses core_plugin but doesn\u0027t require it. If there is code that neither uses or require it, it should just ensure the option isn\u0027t registered at that point\n\nTwo - right, infrastructure can come when required\n\nThree - should be pretty straightforward to have core_plugin defined for all tests?","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    if attributes.core_plugin is None:"},{"line_number":28,"context_line":"        raise Exception(_(\u0027Quantum core_plugin not configured!\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcaM%3D","line":28,"in_reply_to":"AAAAM3%2F%2FdIA%3D","updated":"2013-01-22 13:24:12.000000000","message":"I looked at that briefly (based on a private message), however had three concerns/questions.\n\nOne, can we guarantee that this must *always* be required, or can there be cases where it is not required, for whatever reason?\n\nTwo, do we want to use the proposed patch set as a more generalized validation logic that can be used to check for inter-dependencies between config options in the future, or is this a case of YAGNI? IOW, wait for an actual requirement needed more validation?\n\nThree, I\u0027m concerned about the risk/impact of making that change. I tried this briefly, and there were many unit test cases that broke and the suite run actually hung at one point. I guess the test cases are setting up the bare minimum (and not this config item). Are we comfortable with the ripple that this change  would cause?","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FW18%3D","line":1,"updated":"2013-01-25 18:44:20.000000000","message":"This should be included here.","commit_id":"1232fc313319914daa9ac3294a8a167bfc32e97b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWzk%3D","line":1,"in_reply_to":"AAAAM3%2F%2FW18%3D","updated":"2013-01-25 19:12:50.000000000","message":"Mark, are you suggesting just the vim line or the env line as well?\n\nWhat is the convention here, as there is no main in this module  and I don\u0027t see other modules including the python line?\n\nThanks","commit_id":"1232fc313319914daa9ac3294a8a167bfc32e97b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWzE%3D","line":1,"in_reply_to":"AAAAM3%2F%2FWzk%3D","updated":"2013-01-25 19:21:23.000000000","message":"Sorry, misread. Did you mean to NOT include the python line (#1)","commit_id":"1232fc313319914daa9ac3294a8a167bfc32e97b"}],"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"import time"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"import eventlet"},{"line_number":30,"context_line":"import logging as std_logging"},{"line_number":31,"context_line":"import pyudev"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from quantum.agent.linux import ip_lib"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcJk%3D","line":30,"updated":"2013-01-22 15:50:58.000000000","message":"this should be line 26","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":617,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":620,"context_line":"    cfg.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":621,"context_line":"    try:"},{"line_number":622,"context_line":"        interface_mappings \u003d q_utils.parse_mappings("},{"line_number":623,"context_line":"            cfg.CONF.LINUX_BRIDGE.physical_interface_mappings)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fafo%3D","line":620,"updated":"2013-01-23 14:12:25.000000000","message":"Not sure why we need the std_logging here? Would it not be better to have this flag as part of the common logging (not part of this patch set but it looks a bit messy)","commit_id":"53a1bc6f7b28067e83fc453aa94717c3d7d5dcd6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":620,"context_line":"    cfg.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":621,"context_line":"    try:"},{"line_number":622,"context_line":"        interface_mappings \u003d q_utils.parse_mappings("},{"line_number":623,"context_line":"            cfg.CONF.LINUX_BRIDGE.physical_interface_mappings)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FaZM%3D","line":620,"in_reply_to":"AAAAM3%2F%2FaZ8%3D","updated":"2013-01-23 15:58:54.000000000","message":"Yeah, I don\u0027t know why this isn\u0027t in the quantum logging. Don\u0027t know if others can enlighten us, but I see this in several places.","commit_id":"53a1bc6f7b28067e83fc453aa94717c3d7d5dcd6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":617,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":620,"context_line":"    cfg.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":621,"context_line":"    try:"},{"line_number":622,"context_line":"        interface_mappings \u003d q_utils.parse_mappings("},{"line_number":623,"context_line":"            cfg.CONF.LINUX_BRIDGE.physical_interface_mappings)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FaZ8%3D","line":620,"in_reply_to":"AAAAM3%2F%2FadM%3D","updated":"2013-01-23 15:43:02.000000000","message":"Thanks for addressing the comment. I was just wondering why we had to include the log module to get the logging.DEBUG flag. I was hoping that this could be part of openstack common logging module.","commit_id":"53a1bc6f7b28067e83fc453aa94717c3d7d5dcd6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":617,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":620,"context_line":"    cfg.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":621,"context_line":"    try:"},{"line_number":622,"context_line":"        interface_mappings \u003d q_utils.parse_mappings("},{"line_number":623,"context_line":"            cfg.CONF.LINUX_BRIDGE.physical_interface_mappings)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FadM%3D","line":620,"in_reply_to":"AAAAM3%2F%2Fafo%3D","updated":"2013-01-23 15:24:07.000000000","message":"The intent was to display the configuration options that the user selected via all the config files specified (since we cannot tell if configs are missing, as there are defaults used).\n\nAre you suggesting that a command line arg be used to do that dumping?\n\nIf so, is there some existing mechanism available already?\n\nIf no mechanism, are you suggesting a separate bug to add that common logging capability?","commit_id":"53a1bc6f7b28067e83fc453aa94717c3d7d5dcd6"}],"quantum/plugins/nec/agent/nec_quantum_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":"import logging as std_logging"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.agent.common import validate"},{"line_number":30,"context_line":"from quantum.agent.linux import ovs_lib"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcJs%3D","line":27,"updated":"2013-01-22 15:50:58.000000000","message":"This should be line 25","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import eventlet"},{"line_number":27,"context_line":"import logging as std_logging"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.agent.common import validate"},{"line_number":30,"context_line":"from quantum.agent.linux import ip_lib"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcJ0%3D","line":27,"updated":"2013-01-22 15:50:58.000000000","message":"This should be line 23","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"}],"quantum/plugins/ryu/agent/ryu_quantum_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import logging as std_logging"},{"line_number":28,"context_line":"import netifaces"},{"line_number":29,"context_line":"from ryu.app import client"},{"line_number":30,"context_line":"from ryu.app import conf_switch_key"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FcJw%3D","line":27,"updated":"2013-01-22 15:50:58.000000000","message":"This should be line 24","commit_id":"d1f9440faa38eb244e6723bdd7c01bbbe98747c6"}],"quantum/server/__init__.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6918f8027d81db8be75f58a6669de9cc171dfa14","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# it will override what happens to be installed in /usr/(local/)lib/python..."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.common import config"},{"line_number":26,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fl1k%3D","line":23,"updated":"2013-01-14 20:53:10.000000000","message":"Please use the common logging module:\n\nfrom quantum.openstack.common import log as logging","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# it will override what happens to be installed in /usr/(local/)lib/python..."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.common import config"},{"line_number":26,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Flwk%3D","line":23,"in_reply_to":"AAAAM3%2F%2Fl1k%3D","updated":"2013-01-14 21:36:32.000000000","message":"Done","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6918f8027d81db8be75f58a6669de9cc171dfa14","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def main():"},{"line_number":33,"context_line":"    # the configuration will be read into the cfg.CONF global data structure"},{"line_number":34,"context_line":"    config.parse(sys.argv[1:])"},{"line_number":35,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":36,"context_line":"    if not cfg.CONF.config_file:"},{"line_number":37,"context_line":"        sys.exit(\"ERROR: Unable to find configuration file via the default\""},{"line_number":38,"context_line":"                 \" search paths (~/.quantum/, ~/, /etc/quantum/, /etc/) and\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fl0s%3D","line":35,"updated":"2013-01-14 20:53:10.000000000","message":"What about the call https://github.com/openstack/quantum/blob/master/quantum/service.py#L87?","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def main():"},{"line_number":33,"context_line":"    # the configuration will be read into the cfg.CONF global data structure"},{"line_number":34,"context_line":"    config.parse(sys.argv[1:])"},{"line_number":35,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":36,"context_line":"    if not cfg.CONF.config_file:"},{"line_number":37,"context_line":"        sys.exit(\"ERROR: Unable to find configuration file via the default\""},{"line_number":38,"context_line":"                 \" search paths (~/.quantum/, ~/, /etc/quantum/, /etc/) and\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Flws%3D","line":35,"in_reply_to":"AAAAM3%2F%2Fl0s%3D","updated":"2013-01-14 21:36:32.000000000","message":"Are you suggesting that one could be removed? It is called later in the process. Is there any risk of someone creating a QuantumApiService, outside of the quantum-server process?","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def main():"},{"line_number":33,"context_line":"    # the configuration will be read into the cfg.CONF global data structure"},{"line_number":34,"context_line":"    config.parse(sys.argv[1:])"},{"line_number":35,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":36,"context_line":"    if not cfg.CONF.config_file:"},{"line_number":37,"context_line":"        sys.exit(\"ERROR: Unable to find configuration file via the default\""},{"line_number":38,"context_line":"                 \" search paths (~/.quantum/, ~/, /etc/quantum/, /etc/) and\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Flr4%3D","line":35,"in_reply_to":"AAAAM3%2F%2Flws%3D","updated":"2013-01-14 21:50:19.000000000","message":"Or were you suggesting I move the config file check to this location?","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"c4b9c393412641f61a9a1d5d89b09846b0cb71b5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    if len(cfg.CONF.config_file) \u003d\u003d 1:"},{"line_number":41,"context_line":"        LOG.warning(_(\"Expecting both general and plugin settings config \""},{"line_number":42,"context_line":"                      \"files specified. Only see \u0027{}\u0027\"."},{"line_number":43,"context_line":"                      format(cfg.CONF.config_file[0])))"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        quantum_service \u003d service.serve_wsgi(service.QuantumApiService)"},{"line_number":46,"context_line":"        quantum_service.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fl90%3D","line":43,"updated":"2013-01-14 19:30:28.000000000","message":"A plugin configuration file is not a mandatory requirement for a plugin (though it\u0027s true that all current plugins do use one). I would suggest the warning to say something to the effect of \"No plugin specific config file(s) provided.\"","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"    if len(cfg.CONF.config_file) \u003d\u003d 1:"},{"line_number":41,"context_line":"        LOG.warning(_(\"Expecting both general and plugin settings config \""},{"line_number":42,"context_line":"                      \"files specified. Only see \u0027{}\u0027\"."},{"line_number":43,"context_line":"                      format(cfg.CONF.config_file[0])))"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        quantum_service \u003d service.serve_wsgi(service.QuantumApiService)"},{"line_number":46,"context_line":"        quantum_service.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fils%3D","line":43,"in_reply_to":"AAAAM3%2F%2Fl6Q%3D","updated":"2013-01-16 19:03:13.000000000","message":"I believe there is no default conf at least for the \"core_plugin\", hence the general config file will always be required.","commit_id":"ac4db7c006905fa371612688f79357501617116c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8925a35c639f8971a35ff5a960b3333c77a1dedb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    if len(cfg.CONF.config_file) \u003d\u003d 1:"},{"line_number":41,"context_line":"        LOG.warning(_(\"Expecting both general and plugin settings config \""},{"line_number":42,"context_line":"                      \"files specified. Only see \u0027{}\u0027\"."},{"line_number":43,"context_line":"                      format(cfg.CONF.config_file[0])))"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        quantum_service \u003d service.serve_wsgi(service.QuantumApiService)"},{"line_number":46,"context_line":"        quantum_service.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fl6Q%3D","line":43,"in_reply_to":"AAAAM3%2F%2Fl90%3D","updated":"2013-01-14 21:36:32.000000000","message":"Sure, I can do that for both files. From the bug report, the submitter had omitted the config file and it affected operation.\n\nIs there a way to tell that it is the plugin agent config, that is missing, if one config file is specified?\n\nIs there ever a case where the user could specify the plugin config file w/o the general config file, or can it be \"assumed\" that, the general one will always be there (seems like a default is used, if none entered on command line)?","commit_id":"ac4db7c006905fa371612688f79357501617116c"}]}
