)]}'
{"neutron/extensions/securitygroup.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"208512798ddc93975b3aa4e0bc1fdd65c712528a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                              \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":231,"context_line":"                              \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":232,"context_line":"        \u0027remote_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":233,"context_line":"                            \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":234,"context_line":"                            \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":235,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":236,"context_line":"                      \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_08086b2b","line":233,"updated":"2015-06-30 21:10:55.000000000","message":"This needs to be UUID or None.","commit_id":"a1ae6a10a6f52a690a3fcc70b946930f9c5e4255"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"a52c562cafef3512e5987f1f35fbc3532c03f23a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                              \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":231,"context_line":"                              \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":232,"context_line":"        \u0027remote_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":233,"context_line":"                            \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":234,"context_line":"                            \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":235,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":236,"context_line":"                      \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_fd08b02f","line":233,"in_reply_to":"ba3cc151_08086b2b","updated":"2015-07-16 23:22:40.000000000","message":"Derp - thanks","commit_id":"a1ae6a10a6f52a690a3fcc70b946930f9c5e4255"}],"neutron/tests/api/test_security_groups_negative.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"66620e8767baf7af639215eb1dc364f0d5478515","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        group_ids \u003d [\u0027bad_group_id\u0027, non_exist_id]"},{"line_number":96,"context_line":"        for remote_group_id in group_ids:"},{"line_number":97,"context_line":"            self.assertRaises("},{"line_number":98,"context_line":"                lib_exc.BadRequest, self.client.create_security_group_rule,"},{"line_number":99,"context_line":"                security_group_id\u003dgroup_create_body[\u0027security_group\u0027][\u0027id\u0027],"},{"line_number":100,"context_line":"                protocol\u003d\u0027tcp\u0027, direction\u003d\u0027ingress\u0027, ethertype\u003dself.ethertype,"},{"line_number":101,"context_line":"                remote_group_id\u003dremote_group_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_f56f29fa","line":98,"updated":"2015-07-18 07:19:15.000000000","message":"looks like this is getting NotFound exceptions for the non existent id so you will have to separate them out.\n\nid_exceptions \u003d [(\u0027bad_group_id\u0027, lib_exc.BadRequest),\n                 (non_exist_id, lib_exc.NotFound)]\nfor remote_group_id, exc in id_exceptions:\n    self.assertRaises(\n        exc, self.client.create_sec...","commit_id":"03c9fc841315404482521bd633c5b860a39437f6"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"cdbe7cc6182fb56c372a4f8c9ddb3712059ea0dd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        group_ids \u003d [\u0027bad_group_id\u0027, non_exist_id]"},{"line_number":96,"context_line":"        for remote_group_id in group_ids:"},{"line_number":97,"context_line":"            self.assertRaises("},{"line_number":98,"context_line":"                lib_exc.BadRequest, self.client.create_security_group_rule,"},{"line_number":99,"context_line":"                security_group_id\u003dgroup_create_body[\u0027security_group\u0027][\u0027id\u0027],"},{"line_number":100,"context_line":"                protocol\u003d\u0027tcp\u0027, direction\u003d\u0027ingress\u0027, ethertype\u003dself.ethertype,"},{"line_number":101,"context_line":"                remote_group_id\u003dremote_group_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ab7bd57a","line":98,"in_reply_to":"9a41bdd9_f56f29fa","updated":"2015-07-19 05:42:26.000000000","message":"I agree with kevin, there will be two tests, one is security-group-id is not a vaild uuid, one is security-group-id is a vaild uuid, but it does not exist!","commit_id":"03c9fc841315404482521bd633c5b860a39437f6"}]}
