)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a858125ecfee698983aed0b08401d0bc96560355","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihiro MOTOKI \u003cmotoki@da.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-16 01:51:45 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Port Binding Extension in NEC plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit also adds a common test case for Port Binding Extension"},{"line_number":10,"context_line":"which can be used in each plugin implementation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FkCE%3D","line":7,"updated":"2013-01-15 21:33:00.000000000","message":"The one line summary obscures the fact that other plugin tests have been refactored.  Need to rephrase it or consider having this change dependent on commit that refactors the existing tests and adds the common test case.","commit_id":"3e09b3c4abae4f27666f9d9d88d8299d8c041003"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihiro MOTOKI \u003cmotoki@da.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-16 01:51:45 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Port Binding Extension in NEC plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit also adds a common test case for Port Binding Extension"},{"line_number":10,"context_line":"which can be used in each plugin implementation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FjsM%3D","line":7,"in_reply_to":"AAAAM3%2F%2FkCE%3D","updated":"2013-01-16 00:56:18.000000000","message":"Agreed. I will split the commit.","commit_id":"3e09b3c4abae4f27666f9d9d88d8299d8c041003"}],"quantum/plugins/nec/nec_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a60ce0a2224994a16289a88e027c403bb2f63020","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        super(NECPluginV2, self).delete_port(context, id)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":389,"context_line":"        port \u003d super(NECPluginV2, self).get_port(context, id, fields)"},{"line_number":390,"context_line":"        return self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":391,"context_line":"                            fields)"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FfQ4%3D","line":389,"updated":"2013-01-21 00:12:29.000000000","message":"Should these be wrapped in transactions, so if a port is deleted after you do the get_port you\u0027ll at least see the port_binding values?","commit_id":"b8dae6a881a51a6e286be5c92775ddb639edb518"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":386,"context_line":"        super(NECPluginV2, self).delete_port(context, id)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":389,"context_line":"        port \u003d super(NECPluginV2, self).get_port(context, id, fields)"},{"line_number":390,"context_line":"        return self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":391,"context_line":"                            fields)"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeFg%3D","line":389,"in_reply_to":"AAAAM3%2F%2FeRI%3D","updated":"2013-01-21 10:05:13.000000000","message":"Actually extend_port_dict_binding() requires no database access, so we don\u0027t need to wrap this in transactions. But in many cases extend_* methods access database and they should be wrapped in transaction since the port may be deleted after get_port by another delete_port call.\n\nI noticed it just after I posted the new patchset.","commit_id":"b8dae6a881a51a6e286be5c92775ddb639edb518"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":386,"context_line":"        super(NECPluginV2, self).delete_port(context, id)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":389,"context_line":"        port \u003d super(NECPluginV2, self).get_port(context, id, fields)"},{"line_number":390,"context_line":"        return self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":391,"context_line":"                            fields)"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeRI%3D","line":389,"in_reply_to":"AAAAM3%2F%2FfQ4%3D","updated":"2013-01-21 04:58:02.000000000","message":"Nice catch! You are correct.\n\nOVS and Linux Bridge plugins have the same issue. I will fix them in another patch.","commit_id":"b8dae6a881a51a6e286be5c92775ddb639edb518"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a60ce0a2224994a16289a88e027c403bb2f63020","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                            fields)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":394,"context_line":"        ports \u003d super(NECPluginV2, self).get_ports(context, filters, fields)"},{"line_number":395,"context_line":"        return [self._fields(self._extend_port_dict_binding(context, port),"},{"line_number":396,"context_line":"                             fields) for port in ports]"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FfQ0%3D","line":394,"updated":"2013-01-21 00:12:29.000000000","message":"ditto","commit_id":"b8dae6a881a51a6e286be5c92775ddb639edb518"}]}
