)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1b1a4a7a69043ff54cd38a038fce85a49844119d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement QoS plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initial implementation of the QoS service plugin that just implments"},{"line_number":10,"context_line":"CRUD for policy and rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The callbacks are registered but not working properly yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba3cc151_0866c4ba","line":9,"updated":"2015-07-09 06:34:54.000000000","message":"typo: implements","commit_id":"32ff07494252f0aa5dc970483605f85b6ff7284f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There are no tests yet."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"path_prefix is now provided as an attribute to the plugin base, since"},{"line_number":19,"context_line":"that\u0027s required by the COMMON_PREFIXES removal from master branch."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Partially-implements: blueprint quantum-qos-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a41bdd9_bf86b711","line":18,"updated":"2015-07-10 22:52:09.000000000","message":"I don\u0027t see it in the patch","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0af0502e9ce3a83f10299e2b6f1352685cf96f37","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There are no tests yet."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"path_prefix is now provided as an attribute to the plugin base, since"},{"line_number":19,"context_line":"that\u0027s required by the COMMON_PREFIXES removal from master branch."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Partially-implements: blueprint quantum-qos-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a41bdd9_82fec669","line":18,"in_reply_to":"9a41bdd9_42a43ea5","updated":"2015-07-13 09:53:06.000000000","message":"Is it the same that we already have as QOS_PREFIX?","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"885186ce1d613f398f1fe8ea7b32baa43c7b80ab","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There are no tests yet."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"path_prefix is now provided as an attribute to the plugin base, since"},{"line_number":19,"context_line":"that\u0027s required by the COMMON_PREFIXES removal from master branch."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Partially-implements: blueprint quantum-qos-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a41bdd9_e7e244d5","line":18,"in_reply_to":"9a41bdd9_bf86b711","updated":"2015-07-13 09:34:52.000000000","message":"correct, looking at the process errors to re-add it","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7c2f1454ab8ba5c0f8ac53ed9d3c2a16acfe71df","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There are no tests yet."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"path_prefix is now provided as an attribute to the plugin base, since"},{"line_number":19,"context_line":"that\u0027s required by the COMMON_PREFIXES removal from master branch."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Partially-implements: blueprint quantum-qos-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a41bdd9_42a43ea5","line":18,"in_reply_to":"9a41bdd9_e7e244d5","updated":"2015-07-13 09:51:22.000000000","message":"This should be added in the /extension/qos.py (where base plugin is defined). At least this what we did during  remote troubleshooting session :-)","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"}],"neutron/extensions/qos.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1224ca201478c7a59ba20c6dac7b912112185043","unresolved":false,"context_lines":[{"line_number":99,"context_line":"class Qos(extensions.ExtensionDescriptor):"},{"line_number":100,"context_line":"    \"\"\"Quality of service API extension.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    path_prefix \u003d QOS_PREFIX"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a41bdd9_cca640c1","line":102,"updated":"2015-07-13 10:44:24.000000000","message":"Shouldn\u0027t this be defined under QoSPluginBase?","commit_id":"97fe65b6b7fc1af011b6d672b26da871ccd1184a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4aa329af32693237773fb3709c0d48c96446ad03","unresolved":false,"context_lines":[{"line_number":99,"context_line":"class Qos(extensions.ExtensionDescriptor):"},{"line_number":100,"context_line":"    \"\"\"Quality of service API extension.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    path_prefix \u003d QOS_PREFIX"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @classmethod"},{"line_number":105,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a41bdd9_da09092e","line":102,"in_reply_to":"9a41bdd9_cca640c1","updated":"2015-07-13 12:24:46.000000000","message":"Yeah, I think you\u0027re right.","commit_id":"97fe65b6b7fc1af011b6d672b26da871ccd1184a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0852a347a20fe3d0ee4e244036f46125cf53261d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @abc.abstractmethod"},{"line_number":229,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id, rule):"},{"line_number":230,"context_line":"        pass"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a41bdd9_bca28a97","line":229,"updated":"2015-07-15 12:00:24.000000000","message":"Adding a docstring to abstract methods is a good practice to clarify method perimeter, expected inputs/outputs","commit_id":"5167ca2e3fa20cd98320e68dd3afd01576c1b1c7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03aaa7e8854b902b9c168f285e2fce763a02d605","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        pass"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @abc.abstractmethod"},{"line_number":229,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id, rule):"},{"line_number":230,"context_line":"        pass"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a41bdd9_bf76fcd4","line":229,"in_reply_to":"9a41bdd9_bca28a97","updated":"2015-07-15 12:22:51.000000000","message":"Thanks. We\u0027ll add that in cleanup phase once we have the branch functionally ready for merge.","commit_id":"5167ca2e3fa20cd98320e68dd3afd01576c1b1c7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8bb2733795d70dd8f195890d73b26103299a6bd1","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @abc.abstractmethod"},{"line_number":228,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":229,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":230,"context_line":"        pass"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_362c2598","side":"PARENT","line":229,"updated":"2015-07-16 09:12:29.000000000","message":"Apparently the rename is not working since API controller passes args as kwargs.","commit_id":"e19eb49c1c066c8fa4a3c19183bca1daef553a5c"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ae7a8dd8daca97f53bd4a2d03ed2c566d87f04f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        policy.create()"},{"line_number":122,"context_line":"        return policy.to_dict()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def update_policy(self, context, policy_id, qos_policy):"},{"line_number":125,"context_line":"        policy \u003d policy_object.QosPolicy(context, **qos_policy[\u0027policy\u0027])"},{"line_number":126,"context_line":"        policy.id \u003d policy_id"},{"line_number":127,"context_line":"        policy.update()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_4c4172a8","line":124,"updated":"2015-07-08 12:27:19.000000000","message":"it\u0027s better if arg names are the same in all those methods (either qos_policy or policy).","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fbd82f790681c354d70f08246d9a872abfb4efdd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        policy.create()"},{"line_number":122,"context_line":"        return policy.to_dict()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def update_policy(self, context, policy_id, qos_policy):"},{"line_number":125,"context_line":"        policy \u003d policy_object.QosPolicy(context, **qos_policy[\u0027policy\u0027])"},{"line_number":126,"context_line":"        policy.id \u003d policy_id"},{"line_number":127,"context_line":"        policy.update()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_b3897528","line":124,"in_reply_to":"ba3cc151_4c4172a8","updated":"2015-07-10 14:01:00.000000000","message":"I agree, but I need to find out how API layers will call us, if using **kwargs, or via ordered args...","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ae7a8dd8daca97f53bd4a2d03ed2c566d87f04f","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def get_policy(self, context, policy_id, fields\u003dNone):"},{"line_number":136,"context_line":"        # TODO(QoS): Support the fields parameter"},{"line_number":137,"context_line":"        return policy_object.QosPolicy.get_by_id(context, policy_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_policies(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":140,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_6c255607","line":137,"updated":"2015-07-08 12:27:19.000000000","message":"Should we .to_dict() here too?","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d40e7f4c267a44ba6e2589141238e274b2f868ba","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":147,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":148,"context_line":"        import ipdb;ipdb.set_trace()"},{"line_number":149,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":150,"context_line":"            context, qos_policy_id\u003dpolicy_id,"},{"line_number":151,"context_line":"            **bandwidth_limit_rule[\u0027bandwidth_limit_rule\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_0ec8a973","line":148,"updated":"2015-07-06 15:28:15.000000000","message":"Is this change supposed to be marked WIP? I assume you didn\u0027t intend to merge code with debug included.","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c0c15f84caed40ef667cceb3b447766914fca191","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":147,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":148,"context_line":"        import ipdb;ipdb.set_trace()"},{"line_number":149,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":150,"context_line":"            context, qos_policy_id\u003dpolicy_id,"},{"line_number":151,"context_line":"            **bandwidth_limit_rule[\u0027bandwidth_limit_rule\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_8bdf6739","line":148,"in_reply_to":"ba3cc151_0ec8a973","updated":"2015-07-08 10:10:23.000000000","message":"It\u0027s POC-essential for the feature/qos branch, but definitely we should remove the traces :)\n\nThanks!, I will remove it while assembling the poc","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ae7a8dd8daca97f53bd4a2d03ed2c566d87f04f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # TODO(QoS): Support the fields parameter"},{"line_number":170,"context_line":"        return rule_object.QosBandwidthLimitRule.get_by_id(context, rule_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_policy_bandwidth_limit_rules(self, context, policy_id,"},{"line_number":173,"context_line":"                                         filters\u003dNone, fields\u003dNone,"},{"line_number":174,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":175,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_2c498eb7","line":172,"updated":"2015-07-08 12:27:19.000000000","message":"I have a dream: one day we have the plugin catch calls to all types with a single method, and handle it universally. Not in this patch obviously.","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e5ef37b7276f35af72eac6ed591ec69118a0a14c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # TODO(QoS): Support the fields parameter"},{"line_number":170,"context_line":"        return rule_object.QosBandwidthLimitRule.get_by_id(context, rule_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_policy_bandwidth_limit_rules(self, context, policy_id,"},{"line_number":173,"context_line":"                                         filters\u003dNone, fields\u003dNone,"},{"line_number":174,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":175,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_5f76f2d7","line":172,"in_reply_to":"ba3cc151_2c498eb7","updated":"2015-07-08 12:55:13.000000000","message":"+1 I totally agree.\n\nWe may need to build an additional layer on the extension interface definition to route them down to a single call per request type.","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ab8d97604e8bf8557277e2b132d8acf23b66a16","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # TODO(QoS): Support the fields parameter"},{"line_number":170,"context_line":"        return rule_object.QosBandwidthLimitRule.get_by_id(context, rule_id)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_policy_bandwidth_limit_rules(self, context, policy_id,"},{"line_number":173,"context_line":"                                         filters\u003dNone, fields\u003dNone,"},{"line_number":174,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":175,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_3d15363f","line":172,"in_reply_to":"ba3cc151_5f76f2d7","updated":"2015-07-08 13:31:45.000000000","message":"Not really. We can just catch access to the plugin attribute with python means and proxy it to proper direction.","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ae7a8dd8daca97f53bd4a2d03ed2c566d87f04f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":175,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":176,"context_line":"        # TODO(QoS): Support all the optional parameters"},{"line_number":177,"context_line":"        return rule_object.QosBandwidthLimitRule.get_objects(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_4cddf2de","line":177,"updated":"2015-07-08 12:27:19.000000000","message":"to_dict()?","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e5ef37b7276f35af72eac6ed591ec69118a0a14c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":175,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":176,"context_line":"        # TODO(QoS): Support all the optional parameters"},{"line_number":177,"context_line":"        return rule_object.QosBandwidthLimitRule.get_objects(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_df1e826f","line":177,"in_reply_to":"ba3cc151_4cddf2de","updated":"2015-07-08 12:55:13.000000000","message":"yes, I\u0027ll fix it to the new interface.\n\nWe also may want to pass down filters/sorts/limit/etc.. so we can get the database layer info in specific orders/limits/filters in follow up patches.","commit_id":"c4bb4504446b0daf850b6fd740b5be134529cb21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f75b21d13fa5932e499d733dad08f86d9e45306","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":164,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":165,"context_line":"        if old_policy is not None:"},{"line_number":166,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"},{"line_number":167,"context_line":"        self._save_port_policy(context, port)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def register_net_callbacks(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_7338cdee","line":166,"updated":"2015-07-08 13:46:52.000000000","message":"So we use two transactions to switch profile. Can it be a problem if users expect the change to be atomic on the agent side? If so, we may want to have .attach_* methods to detach on their own.\n\nMaybe add a TODO to revisit it.","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"118126b0ff920d0a1eb0003ba193b40329ac5ddf","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":164,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":165,"context_line":"        if old_policy is not None:"},{"line_number":166,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"},{"line_number":167,"context_line":"        self._save_port_policy(context, port)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def register_net_callbacks(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_6834defa","line":166,"in_reply_to":"ba3cc151_7338cdee","updated":"2015-07-10 14:01:13.000000000","message":"Yeah, I will add a TODO,\nprobably a fetch \u0026 update may work better, or handling it all at db api layer.","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f75b21d13fa5932e499d733dad08f86d9e45306","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":196,"context_line":"        self._save_network_policy(context, network)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _update_network_policy_data(self, resource, event, trigger, **kwargs):"},{"line_number":199,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":200,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":201,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_network_policy("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_ee8dd67c","line":198,"updated":"2015-07-08 13:46:52.000000000","message":"those network and port methods are so similar that it suggests we should reuse some common code. Add TODO.","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"118126b0ff920d0a1eb0003ba193b40329ac5ddf","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":196,"context_line":"        self._save_network_policy(context, network)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _update_network_policy_data(self, resource, event, trigger, **kwargs):"},{"line_number":199,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":200,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":201,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_network_policy("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_835343e2","line":198,"in_reply_to":"ba3cc151_ee8dd67c","updated":"2015-07-10 14:01:13.000000000","message":"I think this may go with the above todo, and handle update as part of the binding, so we only need _save... the low level will do the switch if there\u0027s already another binding.","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f75b21d13fa5932e499d733dad08f86d9e45306","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        return rule"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":243,"context_line":"                                           policy_id, rule):"},{"line_number":244,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":245,"context_line":"        rule.id \u003d rule_id"},{"line_number":246,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_ae5fcee3","line":243,"updated":"2015-07-08 13:46:52.000000000","message":"So id is not passed in \u0027rule\u0027 dict?..","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"118126b0ff920d0a1eb0003ba193b40329ac5ddf","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        return rule"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":243,"context_line":"                                           policy_id, rule):"},{"line_number":244,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":245,"context_line":"        rule.id \u003d rule_id"},{"line_number":246,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_63a4ffb8","line":243,"in_reply_to":"ba3cc151_ae5fcee3","updated":"2015-07-10 14:01:13.000000000","message":"This is API layers auto generated methods and parameters from registered resources. \n\nIf it\u0027s wrong we\u0027ll find it soon and correct in follow up.","commit_id":"d1c27a9a0a7557b3ca3711348c767dda27874904"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1b1a4a7a69043ff54cd38a038fce85a49844119d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.register_port_callbacks()"},{"line_number":113,"context_line":"        self.register_net_callbacks()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _inline_test(self):"},{"line_number":116,"context_line":"        #TODO(gampel) remove inline unitesting"},{"line_number":117,"context_line":"        self.ctx \u003d None"},{"line_number":118,"context_line":"        kwargs \u003d {\u0027context\u0027: self.ctx}"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_081484e6","line":115,"updated":"2015-07-09 06:34:54.000000000","message":"Can we already remove inline test?","commit_id":"32ff07494252f0aa5dc970483605f85b6ff7284f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1b1a4a7a69043ff54cd38a038fce85a49844119d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        port[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _save_port_policy(self, context, port):"},{"line_number":151,"context_line":"        if (\u0027qos_policy_id\u0027 in port"},{"line_number":152,"context_line":"            and port[\u0027qos_policy_id\u0027] is not None):"},{"line_number":153,"context_line":"            policy \u003d self.get_policy(context, port[\u0027qos_policy_id\u0027])"},{"line_number":154,"context_line":"            policy.attach_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_6880b0f7","line":151,"updated":"2015-07-09 06:34:54.000000000","message":"I think you can do the following\n\npolicy_id \u003d port.get(\u0027qos_policy_id\u0027, None)\nif policy_id:\n   xxxx","commit_id":"32ff07494252f0aa5dc970483605f85b6ff7284f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1b1a4a7a69043ff54cd38a038fce85a49844119d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def _update_port_policy_data(self, resource, event, trigger, **kwargs):"},{"line_number":162,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":163,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":164,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":165,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":166,"context_line":"        if old_policy is not None:"},{"line_number":167,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_e8d92023","line":164,"updated":"2015-07-09 06:34:54.000000000","message":"Why not keep it consistent? For other callbacks you get parameters and then invoke method to deal with logic.","commit_id":"32ff07494252f0aa5dc970483605f85b6ff7284f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":143,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":144,"context_line":"        policy \u003d policy_object.QosPolicy.get_port_policy(context, port[\u0027id\u0027])"},{"line_number":145,"context_line":"        port[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _save_port_policy(self, context, port):"},{"line_number":148,"context_line":"        qos_policy_id \u003d port.get(\u0027qos_policy_id\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_9ffdf370","line":145,"updated":"2015-07-10 22:52:09.000000000","message":"policy is not None -\u003e policy","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":143,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":144,"context_line":"        policy \u003d policy_object.QosPolicy.get_port_policy(context, port[\u0027id\u0027])"},{"line_number":145,"context_line":"        port[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _save_port_policy(self, context, port):"},{"line_number":148,"context_line":"        qos_policy_id \u003d port.get(\u0027qos_policy_id\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_d09fc65d","line":145,"in_reply_to":"9a41bdd9_9ffdf370","updated":"2015-07-12 22:46:50.000000000","message":"is \"derreferencing\" pointer ;), \n\nYeah, \n\"policy.id if policy else None \" \nis cleaner :)","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":143,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":144,"context_line":"        policy \u003d policy_object.QosPolicy.get_port_policy(context, port[\u0027id\u0027])"},{"line_number":145,"context_line":"        port[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _save_port_policy(self, context, port):"},{"line_number":148,"context_line":"        qos_policy_id \u003d port.get(\u0027qos_policy_id\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_e279d294","line":145,"in_reply_to":"9a41bdd9_d09fc65d","updated":"2015-07-13 10:08:16.000000000","message":"Done","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":161,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":162,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":163,"context_line":"        if old_policy is not None:"},{"line_number":164,"context_line":"            #TODO(QoS): this means two transactions. One for detaching"},{"line_number":165,"context_line":"            #           one for re-attaching, we may want to update"},{"line_number":166,"context_line":"            #           within a single transaction instead, or put"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_df2a9be7","line":163,"updated":"2015-07-10 22:52:09.000000000","message":"if old_policy","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":161,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":162,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":163,"context_line":"        if old_policy is not None:"},{"line_number":164,"context_line":"            #TODO(QoS): this means two transactions. One for detaching"},{"line_number":165,"context_line":"            #           one for re-attaching, we may want to update"},{"line_number":166,"context_line":"            #           within a single transaction instead, or put"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_f09c4a6b","line":163,"in_reply_to":"9a41bdd9_df2a9be7","updated":"2015-07-12 22:46:50.000000000","message":"+1","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        port \u003d kwargs[\u0027port\u0027]"},{"line_number":161,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":162,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":163,"context_line":"        if old_policy is not None:"},{"line_number":164,"context_line":"            #TODO(QoS): this means two transactions. One for detaching"},{"line_number":165,"context_line":"            #           one for re-attaching, we may want to update"},{"line_number":166,"context_line":"            #           within a single transaction instead, or put"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_826ec6c7","line":163,"in_reply_to":"9a41bdd9_f09c4a6b","updated":"2015-07-13 10:08:16.000000000","message":"Done","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":187,"context_line":"        policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":188,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":189,"context_line":"        network[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_ff08bf93","line":189,"updated":"2015-07-10 22:52:09.000000000","message":"policy is not None -\u003e policy","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":187,"context_line":"        policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":188,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":189,"context_line":"        network[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_42699ebd","line":189,"in_reply_to":"9a41bdd9_90885e24","updated":"2015-07-13 10:08:16.000000000","message":"Done","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":187,"context_line":"        policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":188,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":189,"context_line":"        network[\u0027qos_policy_id\u0027] \u003d policy.id if policy is not None else None"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_90885e24","line":189,"in_reply_to":"9a41bdd9_ff08bf93","updated":"2015-07-12 22:46:50.000000000","message":"+1","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"},{"line_number":193,"context_line":"            and network[\u0027qos_policy_id\u0027] is not None):"},{"line_number":194,"context_line":"            policy \u003d self._get_policy_obj(context, network[\u0027qos_policy_id\u0027])"},{"line_number":195,"context_line":"            policy.attach_network(network[\u0027id\u0027])"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_3f4627c0","line":193,"updated":"2015-07-10 22:52:09.000000000","message":"ditto. Also, I suppose _save_network_policy and _save_port_policy should be almost the same, while they are not.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"},{"line_number":193,"context_line":"            and network[\u0027qos_policy_id\u0027] is not None):"},{"line_number":194,"context_line":"            policy \u003d self._get_policy_obj(context, network[\u0027qos_policy_id\u0027])"},{"line_number":195,"context_line":"            policy.attach_network(network[\u0027id\u0027])"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_f073ea4b","line":193,"in_reply_to":"9a41bdd9_3f4627c0","updated":"2015-07-12 22:46:50.000000000","message":"Yes, we should look at the differences, I\u0027ll insertt a TODO(QoS) here, since looking at ports is enough for POC.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _save_network_policy(self, context, network):"},{"line_number":192,"context_line":"        if (\u0027qos_policy_id\u0027 in network"},{"line_number":193,"context_line":"            and network[\u0027qos_policy_id\u0027] is not None):"},{"line_number":194,"context_line":"            policy \u003d self._get_policy_obj(context, network[\u0027qos_policy_id\u0027])"},{"line_number":195,"context_line":"            policy.attach_network(network[\u0027id\u0027])"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_c29b6ec8","line":193,"in_reply_to":"9a41bdd9_f073ea4b","updated":"2015-07-13 10:08:16.000000000","message":"I just did it now, simple change.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":209,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":210,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":211,"context_line":"        if old_policy is not None:"},{"line_number":212,"context_line":"            old_policy.detach_network(network[\u0027id\u0027])"},{"line_number":213,"context_line":"        self._save_network_policy(context, network)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_bf39d743","line":211,"updated":"2015-07-10 22:52:09.000000000","message":"ditto","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":209,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":210,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":211,"context_line":"        if old_policy is not None:"},{"line_number":212,"context_line":"            old_policy.detach_network(network[\u0027id\u0027])"},{"line_number":213,"context_line":"        self._save_network_policy(context, network)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_e2a0f2f6","line":211,"in_reply_to":"9a41bdd9_908ffe22","updated":"2015-07-13 10:08:16.000000000","message":"Done","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        network \u003d kwargs[\u0027network\u0027]"},{"line_number":209,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_network_policy("},{"line_number":210,"context_line":"            context, network[\u0027id\u0027])"},{"line_number":211,"context_line":"        if old_policy is not None:"},{"line_number":212,"context_line":"            old_policy.detach_network(network[\u0027id\u0027])"},{"line_number":213,"context_line":"        self._save_network_policy(context, network)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_908ffe22","line":211,"in_reply_to":"9a41bdd9_bf39d743","updated":"2015-07-12 22:46:50.000000000","message":"+1","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return [policy_obj.to_dict() for policy_obj in"},{"line_number":243,"context_line":"                policy_object.QosPolicy.get_objects(context)]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":246,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":247,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":248,"context_line":"            context, qos_policy_id\u003dpolicy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_ff7d1fe8","line":245,"updated":"2015-07-10 22:52:09.000000000","message":"Since you respin anyway, please add TODO to consider implementing a proxy catch-all handler that would handle requests for all types.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return [policy_obj.to_dict() for policy_obj in"},{"line_number":243,"context_line":"                policy_object.QosPolicy.get_objects(context)]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":246,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":247,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":248,"context_line":"            context, qos_policy_id\u003dpolicy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_820fa6e0","line":245,"in_reply_to":"9a41bdd9_b0948237","updated":"2015-07-13 10:08:16.000000000","message":"Done","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return [policy_obj.to_dict() for policy_obj in"},{"line_number":243,"context_line":"                policy_object.QosPolicy.get_objects(context)]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":246,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":247,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":248,"context_line":"            context, qos_policy_id\u003dpolicy_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_b0948237","line":245,"in_reply_to":"9a41bdd9_ff7d1fe8","updated":"2015-07-12 22:46:50.000000000","message":"I will, ack.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7669be41bf400e4050493e78b3da766e84421567","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return rule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":254,"context_line":"                                           policy_id, rule):"},{"line_number":255,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":256,"context_line":"        rule.id \u003d rule_id"},{"line_number":257,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_3f1dc7bd","line":254,"updated":"2015-07-10 22:52:09.000000000","message":"style wise, we\u0027ll need to revisit names for args, probably making them identical, f..e \u0027values\u0027. Please add TODO for that.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"43fbd57e08825513a2d5c3724e4f4d2739dd1df8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return rule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":254,"context_line":"                                           policy_id, rule):"},{"line_number":255,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":256,"context_line":"        rule.id \u003d rule_id"},{"line_number":257,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_b4e7ac11","line":254,"in_reply_to":"9a41bdd9_3f1dc7bd","updated":"2015-07-12 09:35:07.000000000","message":"this may break the expected API call. This method is derived from QoSPluginBase defined in /extensions/qos/py","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5147d0e01e6e1c0924a1f383993e1583eb97513e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return rule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":254,"context_line":"                                           policy_id, rule):"},{"line_number":255,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":256,"context_line":"        rule.id \u003d rule_id"},{"line_number":257,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_02dcf610","line":254,"in_reply_to":"9a41bdd9_709efa57","updated":"2015-07-13 10:08:16.000000000","message":"Well, some api calls are handled with \"bandwidth_limit_rule, others with \"rule\",\n\nmade it uniform to rule, will fix later if we need.","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2a768ac98db69ce8c295ca965f8bf0cc0000fae8","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return rule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":254,"context_line":"                                           policy_id, rule):"},{"line_number":255,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":256,"context_line":"        rule.id \u003d rule_id"},{"line_number":257,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_709efa57","line":254,"in_reply_to":"9a41bdd9_b4e7ac11","updated":"2015-07-12 22:46:50.000000000","message":"I\u0027m not sure if API layers call us with a kwargs, or via ordered parameters. I\u0027ll check","commit_id":"030ab89677745c4612a831d1dc5221b4b1fb5c04"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1224ca201478c7a59ba20c6dac7b912112185043","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        policy.create()"},{"line_number":218,"context_line":"        return policy.to_dict()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def update_policy(self, context, policy_id, qos_policy):"},{"line_number":221,"context_line":"        policy \u003d policy_object.QosPolicy(context, **qos_policy[\u0027policy\u0027])"},{"line_number":222,"context_line":"        policy.id \u003d policy_id"},{"line_number":223,"context_line":"        policy.update()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a41bdd9_8c3a7835","line":220,"updated":"2015-07-13 10:44:24.000000000","message":"you need to align names with QosBasePlugin in /extensions/qos.py. These methods are derived from Base class","commit_id":"97fe65b6b7fc1af011b6d672b26da871ccd1184a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4aa329af32693237773fb3709c0d48c96446ad03","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        policy.create()"},{"line_number":218,"context_line":"        return policy.to_dict()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def update_policy(self, context, policy_id, qos_policy):"},{"line_number":221,"context_line":"        policy \u003d policy_object.QosPolicy(context, **qos_policy[\u0027policy\u0027])"},{"line_number":222,"context_line":"        policy.id \u003d policy_id"},{"line_number":223,"context_line":"        policy.update()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a41bdd9_3a2a757f","line":220,"in_reply_to":"9a41bdd9_8c3a7835","updated":"2015-07-13 12:24:46.000000000","message":"Agreed.","commit_id":"97fe65b6b7fc1af011b6d672b26da871ccd1184a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb06a62c765d1b86fb7427fdf5f97faf86eb7e9d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    def update_port_policy(self, context, port):"},{"line_number":134,"context_line":"        old_policy \u003d policy_object.QosPolicy.get_port_policy("},{"line_number":135,"context_line":"            context, port[\u0027id\u0027])"},{"line_number":136,"context_line":"        if old_policy is not None:"},{"line_number":137,"context_line":"            #TODO(QoS): this means two transactions. One for detaching"},{"line_number":138,"context_line":"            #           one for re-attaching, we may want to update"},{"line_number":139,"context_line":"            #           within a single transaction instead, or put"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a41bdd9_9ded4db9","line":136,"updated":"2015-07-15 09:19:06.000000000","message":"if old_policy:","commit_id":"5167ca2e3fa20cd98320e68dd3afd01576c1b1c7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb06a62c765d1b86fb7427fdf5f97faf86eb7e9d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            old_policy.detach_port(port[\u0027id\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        qos_policy_id \u003d port.get(\u0027qos_policy_id\u0027)"},{"line_number":145,"context_line":"        if qos_policy_id is not None:"},{"line_number":146,"context_line":"            policy \u003d self._get_policy_obj(context, qos_policy_id)"},{"line_number":147,"context_line":"            policy.attach_port(port[\u0027id\u0027])"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a41bdd9_bd4131ab","line":145,"updated":"2015-07-15 09:19:06.000000000","message":"if qos_policy_id:","commit_id":"5167ca2e3fa20cd98320e68dd3afd01576c1b1c7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8bb2733795d70dd8f195890d73b26103299a6bd1","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    #           we capture the API function call, and just pass"},{"line_number":204,"context_line":"    #           the rule type as a parameter removing lots of"},{"line_number":205,"context_line":"    #           future code duplication when we have more rules."},{"line_number":206,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id, rule):"},{"line_number":207,"context_line":"        #TODO(QoS): avoid creation of severan bandwidth limit rules"},{"line_number":208,"context_line":"        #           in the future we need an inter-rule validation"},{"line_number":209,"context_line":"        #           mechanism to verify all created rules will"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_d66cd9d1","line":206,"updated":"2015-07-16 09:12:29.000000000","message":"arg name should be reverted","commit_id":"ebd645337ba3f6ce0235ed10e2eec6bf876f891d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8bb2733795d70dd8f195890d73b26103299a6bd1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        return rule"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id,"},{"line_number":218,"context_line":"                                           policy_id, rule):"},{"line_number":219,"context_line":"        rule \u003d rule_object.QosBandwidthLimitRule(context, **rule[\u0027rule\u0027])"},{"line_number":220,"context_line":"        rule.id \u003d rule_id"},{"line_number":221,"context_line":"        rule.update()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_1677a1a0","line":218,"updated":"2015-07-16 09:12:29.000000000","message":"ditto","commit_id":"ebd645337ba3f6ce0235ed10e2eec6bf876f891d"}]}
