)]}'
{"neutron/tests/api/test_address_scope.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"da693158388c9455213b7a3ae7c918404bb3ce41","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @test.idempotent_id(\u0027045f9294-8b1a-4848-b6a8-edf1b41e9d06\u0027)"},{"line_number":73,"context_line":"    def test_tenant_create_list_address_scope(self):"},{"line_number":74,"context_line":"        name, address_scope_id \u003d self._create_address_scope(self.client)"},{"line_number":75,"context_line":"        self.addCleanup(self.client.delete_address_scope, address_scope_id)"},{"line_number":76,"context_line":"        body \u003d self.client.list_address_scopes()"},{"line_number":77,"context_line":"        address_scopes \u003d body[\u0027address_scopes\u0027]"},{"line_number":78,"context_line":"        self.assertIn(address_scope_id, [a_s[\u0027id\u0027] for a_s in address_scopes],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_92cb48a5","line":75,"updated":"2015-07-21 13:38:11.000000000","message":"I think it is better to move addCleanUp in self._create_address_scope() as we have it in all tests except test_delete_address_scope.","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"7826738b693506638abff8e86915e7803ac509c6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @test.idempotent_id(\u0027045f9294-8b1a-4848-b6a8-edf1b41e9d06\u0027)"},{"line_number":73,"context_line":"    def test_tenant_create_list_address_scope(self):"},{"line_number":74,"context_line":"        name, address_scope_id \u003d self._create_address_scope(self.client)"},{"line_number":75,"context_line":"        self.addCleanup(self.client.delete_address_scope, address_scope_id)"},{"line_number":76,"context_line":"        body \u003d self.client.list_address_scopes()"},{"line_number":77,"context_line":"        address_scopes \u003d body[\u0027address_scopes\u0027]"},{"line_number":78,"context_line":"        self.assertIn(address_scope_id, [a_s[\u0027id\u0027] for a_s in address_scopes],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_977f7716","line":75,"in_reply_to":"3a50d1a3_3718e374","updated":"2015-07-22 14:03:17.000000000","message":"Yup, just put the cleanup after line 52.\n\nBetter yet, take a look at:\nneutron/tests/api/base.py.","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1586373a8d9b754db6cde034e6fcf59b483abfc1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @test.idempotent_id(\u0027045f9294-8b1a-4848-b6a8-edf1b41e9d06\u0027)"},{"line_number":73,"context_line":"    def test_tenant_create_list_address_scope(self):"},{"line_number":74,"context_line":"        name, address_scope_id \u003d self._create_address_scope(self.client)"},{"line_number":75,"context_line":"        self.addCleanup(self.client.delete_address_scope, address_scope_id)"},{"line_number":76,"context_line":"        body \u003d self.client.list_address_scopes()"},{"line_number":77,"context_line":"        address_scopes \u003d body[\u0027address_scopes\u0027]"},{"line_number":78,"context_line":"        self.assertIn(address_scope_id, [a_s[\u0027id\u0027] for a_s in address_scopes],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_3718e374","line":75,"in_reply_to":"3a50d1a3_92cb48a5","updated":"2015-07-22 13:58:28.000000000","message":"but we need to know the address_scope_id.....","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"da693158388c9455213b7a3ae7c918404bb3ce41","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self._test_update_address_scope_helper(self.admin_client, shared\u003dTrue)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class AddressScopeTestNegative(AddressScopeTestBase):"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":128,"context_line":"    @test.idempotent_id(\u00279c92ec34-0c50-4104-aa47-9ce98d5088df\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_320034aa","line":125,"updated":"2015-07-21 13:38:11.000000000","message":"negative tests are always created in a separate file.","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1586373a8d9b754db6cde034e6fcf59b483abfc1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self._test_update_address_scope_helper(self.admin_client, shared\u003dTrue)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class AddressScopeTestNegative(AddressScopeTestBase):"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":128,"context_line":"    @test.idempotent_id(\u00279c92ec34-0c50-4104-aa47-9ce98d5088df\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_856f442a","line":125,"in_reply_to":"3a50d1a3_320034aa","updated":"2015-07-22 13:58:28.000000000","message":"+1","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"da693158388c9455213b7a3ae7c918404bb3ce41","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # address scope methods"},{"line_number":213,"context_line":"    def create_address_scope(self, post_data):"},{"line_number":214,"context_line":"        body \u003d self.serialize_list(post_data, \"address_scopes\","},{"line_number":215,"context_line":"                                   \"address_scope\")"},{"line_number":216,"context_line":"        uri \u003d self.get_uri(\"address_scopes\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_3273544f","line":213,"updated":"2015-07-21 13:38:11.000000000","message":"Do we really need this? _creater, _deleter, _updater does not work?","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1586373a8d9b754db6cde034e6fcf59b483abfc1","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # address scope methods"},{"line_number":213,"context_line":"    def create_address_scope(self, post_data):"},{"line_number":214,"context_line":"        body \u003d self.serialize_list(post_data, \"address_scopes\","},{"line_number":215,"context_line":"                                   \"address_scope\")"},{"line_number":216,"context_line":"        uri \u003d self.get_uri(\"address_scopes\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_65b47834","line":213,"in_reply_to":"3a50d1a3_3273544f","updated":"2015-07-22 13:58:28.000000000","message":"Agree with Ann. I see nothing special in these methods.\nHaving subnetpool related methods here also looks inappropriate.","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"3d9b13a5140fa0a8f22b1bb552eb8eb3c1e8255b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # address scope methods"},{"line_number":213,"context_line":"    def create_address_scope(self, post_data):"},{"line_number":214,"context_line":"        body \u003d self.serialize_list(post_data, \"address_scopes\","},{"line_number":215,"context_line":"                                   \"address_scope\")"},{"line_number":216,"context_line":"        uri \u003d self.get_uri(\"address_scopes\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_35f6dbd7","line":213,"in_reply_to":"3a50d1a3_3273544f","updated":"2015-07-22 14:11:19.000000000","message":"Agree. I will remove these functions. I wasn\u0027t aware of this. thanks for pointing out.\n\nMay be I will cleanup the functions related to subnetpools in this review - https://review.openstack.org/#/c/202419/","commit_id":"0eb9b5bf26c0d8acb581eebeef1a86c6020aaaec"}]}