)]}'
{"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d5062afcf870ac15996c4b66327922f363ad5eee","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            has_ip \u003d self._ip_on_port(ret_port)"},{"line_number":736,"context_line":"            # checks if security groups were updated adding/modifying"},{"line_number":737,"context_line":"            # security groups, port security is set and port has ip"},{"line_number":738,"context_line":"            if (has_security_groups and (not ret_port[psec.PORTSECURITY]"},{"line_number":739,"context_line":"                                         or not has_ip)):"},{"line_number":740,"context_line":"                raise psec.PortSecurityAndIPRequiredForSecurityGroups()"},{"line_number":741,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FhPo%3D","line":738,"updated":"2013-01-17 16:03:14.000000000","message":"lines 738-740 and 744-747 accomplish the same thing.  Consider:\n\n\nif has_security_groups:\n    if not (has_ip and ret_port[psec.PORTSECURITY]):\n        raise psec.PortSecurityAndIPRequiredForSecurityGroups()","commit_id":"553bcdd7c8bc09db1da3eb5cc2237f0f67cb7915"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            has_ip \u003d self._ip_on_port(ret_port)"},{"line_number":736,"context_line":"            # checks if security groups were updated adding/modifying"},{"line_number":737,"context_line":"            # security groups, port security is set and port has ip"},{"line_number":738,"context_line":"            if (has_security_groups and (not ret_port[psec.PORTSECURITY]"},{"line_number":739,"context_line":"                                         or not has_ip)):"},{"line_number":740,"context_line":"                raise psec.PortSecurityAndIPRequiredForSecurityGroups()"},{"line_number":741,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fg9Q%3D","line":738,"in_reply_to":"AAAAM3%2F%2FhPo%3D","updated":"2013-01-17 18:43:11.000000000","message":"Thanks, Done","commit_id":"553bcdd7c8bc09db1da3eb5cc2237f0f67cb7915"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":122,"context_line":"    supported_extension_aliases \u003d [\"provider\", \"quotas\", \"port-security\","},{"line_number":123,"context_line":"                                   \"security-group\"]"},{"line_number":124,"context_line":"    sg_supported_protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":125,"context_line":"    sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    __native_bulk_support \u003d True"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2Fcr8%3D","line":125,"updated":"2013-01-22 04:38:39.000000000","message":"sg_supported_protocols and sg_supported_ethertypes are now defined in extension/securitygroup and it is used by attribute validation.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    supported_extension_aliases \u003d [\"provider\", \"quotas\", \"port-security\","},{"line_number":123,"context_line":"                                   \"security-group\"]"},{"line_number":124,"context_line":"    sg_supported_protocols \u003d [\u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":125,"context_line":"    sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    __native_bulk_support \u003d True"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbZc%3D","line":125,"in_reply_to":"AAAAM3%2F%2Fcr8%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":672,"context_line":"            port_data[ext_sg.SECURITYGROUPS] \u003d ("},{"line_number":673,"context_line":"                self._get_security_groups_on_port(context, port))"},{"line_number":674,"context_line":"            self._process_port_create_security_group("},{"line_number":675,"context_line":"                context, quantum_db[\u0027id\u0027], port_data[ext_sg.SECURITYGROUPS])"},{"line_number":676,"context_line":"            # provider networking extension checks"},{"line_number":677,"context_line":"            # Fetch the network and network binding from Quantum db"},{"line_number":678,"context_line":"            network \u003d self._get_network(context, port_data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcrU%3D","line":675,"updated":"2013-01-22 04:38:39.000000000","message":"L.666-675 looks a common logic among plugins. Can we move it to security_groups.db?\n(note that it is not required in this patch)\n\nWe can know if port security extension is enabled by self.supported_extension_aliases contains \u0027port-security\u0027 (though I have not tested).","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":739,"context_line":"            ret_port.update(port[\u0027port\u0027])"},{"line_number":740,"context_line":"            tenant_id \u003d self._get_tenant_id_for_create(context, ret_port)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"            # populate port_security setting"},{"line_number":743,"context_line":"            if psec.PORTSECURITY not in port[\u0027port\u0027]:"},{"line_number":744,"context_line":"                ret_port[psec.PORTSECURITY] \u003d self._get_port_security_binding("},{"line_number":745,"context_line":"                    context, id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcrQ%3D","line":742,"updated":"2013-01-22 04:38:39.000000000","message":"L.742-766: same as the above.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":670,"context_line":"            port_data[ext_sg.SECURITYGROUPS] \u003d ("},{"line_number":671,"context_line":"                self._get_security_groups_on_port(context, port))"},{"line_number":672,"context_line":"            self._process_port_create_security_group("},{"line_number":673,"context_line":"                context, quantum_db[\u0027id\u0027], port_data[ext_sg.SECURITYGROUPS])"},{"line_number":674,"context_line":"            # provider networking extension checks"},{"line_number":675,"context_line":"            # Fetch the network and network binding from Quantum db"},{"line_number":676,"context_line":"            network \u003d self._get_network(context, port_data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FaiE%3D","line":673,"updated":"2013-01-23 13:54:34.000000000","message":"L.664-673 looks common among plugins, but port security ext and sec group ext are tightly coupled, so I am not sure these should be moved to security_group_db....\n\nAt the moment what code is common among plugins is not clear. we can go unchanged in this patch and refactor later if necessary.\n\nSame thing can be said to update_port and *_security_group methods.","commit_id":"f0b65284a40b7232303a68c80454251d4814cbc4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            port_data[ext_sg.SECURITYGROUPS] \u003d ("},{"line_number":671,"context_line":"                self._get_security_groups_on_port(context, port))"},{"line_number":672,"context_line":"            self._process_port_create_security_group("},{"line_number":673,"context_line":"                context, quantum_db[\u0027id\u0027], port_data[ext_sg.SECURITYGROUPS])"},{"line_number":674,"context_line":"            # provider networking extension checks"},{"line_number":675,"context_line":"            # Fetch the network and network binding from Quantum db"},{"line_number":676,"context_line":"            network \u003d self._get_network(context, port_data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FaKc%3D","line":673,"in_reply_to":"AAAAM3%2F%2FaiE%3D","updated":"2013-01-23 17:33:18.000000000","message":"I agree, my vote is to refactor this later if you guys are okay with that.","commit_id":"f0b65284a40b7232303a68c80454251d4814cbc4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":"from quantum.openstack.common import cfg"},{"line_number":45,"context_line":"from quantum.openstack.common import rpc"},{"line_number":46,"context_line":"from quantum import policy"},{"line_number":47,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import (securitygroups"},{"line_number":48,"context_line":"                                                             as nvp_sec)"},{"line_number":49,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import config"},{"line_number":50,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import (exceptions"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOS0%3D","line":47,"updated":"2013-02-01 14:46:43.000000000","message":"quantum.plugins should come before quantum.policy\n\nGosh I hate being pedant :/","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from quantum.openstack.common import cfg"},{"line_number":45,"context_line":"from quantum.openstack.common import rpc"},{"line_number":46,"context_line":"from quantum import policy"},{"line_number":47,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import (securitygroups"},{"line_number":48,"context_line":"                                                             as nvp_sec)"},{"line_number":49,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import config"},{"line_number":50,"context_line":"from quantum.plugins.nicira.nicira_nvp_plugin.common import (exceptions"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FN1I%3D","line":47,"in_reply_to":"AAAAM3%2F%2FOS0%3D","updated":"2013-02-01 21:52:29.000000000","message":"Done","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":760,"context_line":"                    raise psec.PortSecurityPortHasSecurityGroup()"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"            if (delete_security_groups or has_security_groups):"},{"line_number":763,"context_line":"                # delete the port binding and read it with the new rules."},{"line_number":764,"context_line":"                self._delete_port_security_group_bindings(context, id)"},{"line_number":765,"context_line":"                sgids \u003d self._get_security_groups_on_port(context, port)"},{"line_number":766,"context_line":"                self._process_port_create_security_group(context, id, sgids)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOSE%3D","line":763,"updated":"2013-02-01 14:46:43.000000000","message":"Just a question: is there a case for wrapping the three lines below in a transaction?","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":760,"context_line":"                    raise psec.PortSecurityPortHasSecurityGroup()"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"            if (delete_security_groups or has_security_groups):"},{"line_number":763,"context_line":"                # delete the port binding and read it with the new rules."},{"line_number":764,"context_line":"                self._delete_port_security_group_bindings(context, id)"},{"line_number":765,"context_line":"                sgids \u003d self._get_security_groups_on_port(context, port)"},{"line_number":766,"context_line":"                self._process_port_create_security_group(context, id, sgids)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FKF4%3D","line":763,"in_reply_to":"AAAAM3%2F%2FN1A%3D","updated":"2013-02-05 10:25:22.000000000","message":"Sorry I did not see the enclosing one at line 735. I agree with you.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                    raise psec.PortSecurityPortHasSecurityGroup()"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"            if (delete_security_groups or has_security_groups):"},{"line_number":763,"context_line":"                # delete the port binding and read it with the new rules."},{"line_number":764,"context_line":"                self._delete_port_security_group_bindings(context, id)"},{"line_number":765,"context_line":"                sgids \u003d self._get_security_groups_on_port(context, port)"},{"line_number":766,"context_line":"                self._process_port_create_security_group(context, id, sgids)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FN1A%3D","line":763,"in_reply_to":"AAAAM3%2F%2FOSE%3D","updated":"2013-02-01 21:52:29.000000000","message":"Yes, they all modify/query the db. If the call on line 777 to nvp i want these commands to be reverted.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":550,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":551,"context_line":"            quantum_lports \u003d super(NvpPluginV2, self).get_ports("},{"line_number":552,"context_line":"                context, filters)"},{"line_number":553,"context_line":"            for quantum_lport in quantum_lports:"},{"line_number":554,"context_line":"                self._extend_port_port_security_dict(context, quantum_lport)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        vm_filter \u003d \"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FKp0%3D","line":553,"updated":"2013-02-05 02:00:52.000000000","message":"Don\u0027t we need _extend_port_security_group_dict here?","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":551,"context_line":"            quantum_lports \u003d super(NvpPluginV2, self).get_ports("},{"line_number":552,"context_line":"                context, filters)"},{"line_number":553,"context_line":"            for quantum_lport in quantum_lports:"},{"line_number":554,"context_line":"                self._extend_port_port_security_dict(context, quantum_lport)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        vm_filter \u003d \"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FKnk%3D","line":553,"in_reply_to":"AAAAM3%2F%2FKp0%3D","updated":"2013-02-05 02:33:32.000000000","message":"good catch, i\u0027ll also add  a unit test","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":661,"context_line":"                context, port_data)"},{"line_number":662,"context_line":"            port_data[psec.PORTSECURITY] \u003d port_security"},{"line_number":663,"context_line":"            self._process_port_security_create(context, port_data)"},{"line_number":664,"context_line":"            # security group extension checks"},{"line_number":665,"context_line":"            if (attr.is_attr_set(port_data.get(ext_sg.SECURITYGROUPS)) and"},{"line_number":666,"context_line":"                not (port_security and has_ip)):"},{"line_number":667,"context_line":"                raise psec.PortSecurityAndIPRequiredForSecurityGroups()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJcw%3D","line":664,"updated":"2013-02-05 17:31:28.000000000","message":"Consider re-ordering the logic in lines 665-669\n\nif port_security and has_ip:\n    self._ensure_default_security_group_on_port(context, port)\nelif attr.is_attr_set(port_data.get(ext_sg.SECURITYGROUPS):\n    raise psec.PortSecurityAndIPRequiredForSecurityGroups()","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":661,"context_line":"                context, port_data)"},{"line_number":662,"context_line":"            port_data[psec.PORTSECURITY] \u003d port_security"},{"line_number":663,"context_line":"            self._process_port_security_create(context, port_data)"},{"line_number":664,"context_line":"            # security group extension checks"},{"line_number":665,"context_line":"            if (attr.is_attr_set(port_data.get(ext_sg.SECURITYGROUPS)) and"},{"line_number":666,"context_line":"                not (port_security and has_ip)):"},{"line_number":667,"context_line":"                raise psec.PortSecurityAndIPRequiredForSecurityGroups()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJAA%3D","line":664,"in_reply_to":"AAAAM3%2F%2FJcw%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":753,"context_line":"                # Update did not have security groups passed in. Check"},{"line_number":754,"context_line":"                # that port does not have any security groups already on it."},{"line_number":755,"context_line":"                filters \u003d {\u0027port_id\u0027: [id]}"},{"line_number":756,"context_line":"                security_groups \u003d (super(NvpPluginV2, self)."},{"line_number":757,"context_line":"                                   _get_port_security_group_bindings("},{"line_number":758,"context_line":"                                   context, filters))"},{"line_number":759,"context_line":"                if security_groups and not delete_security_groups:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJck%3D","line":756,"updated":"2013-02-05 17:31:28.000000000","message":"readability nit:\n\nsecurity_groups \u003d (\n    super(NvpPluginV2, self)._get_port_security_group_bindings(\n        context, filters\n    )\n)","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":840,"context_line":"        group and we don\u0027t need to check if one exists."},{"line_number":841,"context_line":"        \"\"\""},{"line_number":842,"context_line":"        s \u003d security_group.get(\u0027security_group\u0027)"},{"line_number":843,"context_line":"        if (cfg.CONF.SECURITYGROUP.proxy_mode and not context.is_admin):"},{"line_number":844,"context_line":"            raise ext_sg.SecurityGroupProxyModeNotAdmin()"},{"line_number":845,"context_line":"        if (cfg.CONF.SECURITYGROUP.proxy_mode and not s.get(\u0027external_id\u0027)):"},{"line_number":846,"context_line":"            raise ext_sg.SecurityGroupProxyMode()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJbw%3D","line":843,"updated":"2013-02-05 17:31:28.000000000","message":"Consider refactoring to make logic progression easier to follow:\n\nif cfg.CONF.SECURITYGROUP.proxy_mode:\n    if not context.is_admin:\n         raise ext_sg.SecurityGroupProxyModeNotAdmin()\n    elif not s.get(\u0027external_id\u0027):\n         raise ext_sg.SecurityGroupProxyMode()\nelif s.get(\u0027external_id\u0027):\n    raise ext_sg.SecurityGroupNotProxyMode()","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":840,"context_line":"        group and we don\u0027t need to check if one exists."},{"line_number":841,"context_line":"        \"\"\""},{"line_number":842,"context_line":"        s \u003d security_group.get(\u0027security_group\u0027)"},{"line_number":843,"context_line":"        if (cfg.CONF.SECURITYGROUP.proxy_mode and not context.is_admin):"},{"line_number":844,"context_line":"            raise ext_sg.SecurityGroupProxyModeNotAdmin()"},{"line_number":845,"context_line":"        if (cfg.CONF.SECURITYGROUP.proxy_mode and not s.get(\u0027external_id\u0027)):"},{"line_number":846,"context_line":"            raise ext_sg.SecurityGroupProxyMode()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FI%2B0%3D","line":843,"in_reply_to":"AAAAM3%2F%2FJbw%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":852,"context_line":"            self._ensure_default_security_group(context, tenant_id,"},{"line_number":853,"context_line":"                                                security_group)"},{"line_number":854,"context_line":"        if s.get(\u0027external_id\u0027):"},{"line_number":855,"context_line":"            filters \u003d {\u0027external_id\u0027: [(s.get(\u0027external_id\u0027))]}"},{"line_number":856,"context_line":"            security_groups \u003d super(NvpPluginV2, self).get_security_groups("},{"line_number":857,"context_line":"                context, filters\u003dfilters)"},{"line_number":858,"context_line":"            if security_groups:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJbk%3D","line":855,"updated":"2013-02-05 17:31:28.000000000","message":"extra parens.\n\nfilters \u003d {\u0027external_id\u0027: [s.get(\u0027external_id\u0027)]}","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":852,"context_line":"            self._ensure_default_security_group(context, tenant_id,"},{"line_number":853,"context_line":"                                                security_group)"},{"line_number":854,"context_line":"        if s.get(\u0027external_id\u0027):"},{"line_number":855,"context_line":"            filters \u003d {\u0027external_id\u0027: [(s.get(\u0027external_id\u0027))]}"},{"line_number":856,"context_line":"            security_groups \u003d super(NvpPluginV2, self).get_security_groups("},{"line_number":857,"context_line":"                context, filters\u003dfilters)"},{"line_number":858,"context_line":"            if security_groups:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FI%2Bo%3D","line":855,"in_reply_to":"AAAAM3%2F%2FJbk%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"}],"quantum/plugins/nicira/nicira_nvp_plugin/common/securitygroups.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    return nvp_rules"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _get_security_group_rules_nvp_format(self, context, security_group_id,"},{"line_number":63,"context_line":"                                         with_id\u003dFalse):"},{"line_number":64,"context_line":"        \"\"\"Query quantum db for security group rules. If external_id is"},{"line_number":65,"context_line":"        provided the external_id will also be returned."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fg9M%3D","line":62,"updated":"2013-01-17 18:43:11.000000000","message":"Changing all references to self to inst in this file.","commit_id":"553bcdd7c8bc09db1da3eb5cc2237f0f67cb7915"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Aaron Rosen, Nicira Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.db.securitygroups_db import (SecurityGroupDbMixin"},{"line_number":21,"context_line":"                                          as securitygroups_db)"},{"line_number":22,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Protocol number look up for supported protocols"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2Fcq0%3D","line":21,"updated":"2013-01-22 04:38:39.000000000","message":"module level import is used in our convention.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Aaron Rosen, Nicira Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.db.securitygroups_db import (SecurityGroupDbMixin"},{"line_number":21,"context_line":"                                          as securitygroups_db)"},{"line_number":22,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Protocol number look up for supported protocols"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbWw%3D","line":21,"in_reply_to":"AAAAM3%2F%2Fcq0%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":74,"context_line":"                   \u0027direction\u0027: [\u0027ingress\u0027]}"},{"line_number":75,"context_line":"        ingress_rules \u003d securitygroups_db.get_security_group_rules("},{"line_number":76,"context_line":"            inst, context, filters, fields)"},{"line_number":77,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":78,"context_line":"                   \u0027direction\u0027: [\u0027egress\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcrI%3D","line":75,"updated":"2013-01-22 04:38:39.000000000","message":"securitygroups_db is an alias of secgroup mixin class. I think it is not a little tricky to call a method of mixin class directly, though it works in python.\n\nOne idea is to prepare Mixin class which inherits SecurityGroupDbMixin and define _get_security_group_rules_nvp_format and _get_profile_uuid. Then NVP plugin inherits this class instead of SecurityGroupDbMixin.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":74,"context_line":"                   \u0027direction\u0027: [\u0027ingress\u0027]}"},{"line_number":75,"context_line":"        ingress_rules \u003d securitygroups_db.get_security_group_rules("},{"line_number":76,"context_line":"            inst, context, filters, fields)"},{"line_number":77,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":78,"context_line":"                   \u0027direction\u0027: [\u0027egress\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbXo%3D","line":75,"in_reply_to":"AAAAM3%2F%2FcrI%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"            inst, context, filters, fields)"},{"line_number":77,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":78,"context_line":"                   \u0027direction\u0027: [\u0027egress\u0027]}"},{"line_number":79,"context_line":"        egress_rules \u003d securitygroups_db.get_security_group_rules("},{"line_number":80,"context_line":"            inst, context, filters, fields)"},{"line_number":81,"context_line":"        rules \u003d {\u0027logical_port_ingress_rules\u0027: egress_rules,"},{"line_number":82,"context_line":"                 \u0027logical_port_egress_rules\u0027: ingress_rules}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcrE%3D","line":79,"updated":"2013-01-22 04:38:39.000000000","message":"Ditto.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            inst, context, filters, fields)"},{"line_number":77,"context_line":"        filters \u003d {\u0027security_group_id\u0027: [security_group_id],"},{"line_number":78,"context_line":"                   \u0027direction\u0027: [\u0027egress\u0027]}"},{"line_number":79,"context_line":"        egress_rules \u003d securitygroups_db.get_security_group_rules("},{"line_number":80,"context_line":"            inst, context, filters, fields)"},{"line_number":81,"context_line":"        rules \u003d {\u0027logical_port_ingress_rules\u0027: egress_rules,"},{"line_number":82,"context_line":"                 \u0027logical_port_egress_rules\u0027: ingress_rules}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbXk%3D","line":79,"in_reply_to":"AAAAM3%2F%2FcrE%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _get_profile_uuid(inst, context, source_group_id):"},{"line_number":87,"context_line":"    \"\"\"Return profile id from novas group id. \"\"\""},{"line_number":88,"context_line":"    security_group \u003d securitygroups_db.get_security_group("},{"line_number":89,"context_line":"        inst, context, source_group_id)"},{"line_number":90,"context_line":"    if not security_group:"},{"line_number":91,"context_line":"        raise ext_sg.SecurityGroupNotFound(id\u003dsource_group_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcrA%3D","line":88,"updated":"2013-01-22 04:38:39.000000000","message":"Ditto","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _get_profile_uuid(inst, context, source_group_id):"},{"line_number":87,"context_line":"    \"\"\"Return profile id from novas group id. \"\"\""},{"line_number":88,"context_line":"    security_group \u003d securitygroups_db.get_security_group("},{"line_number":89,"context_line":"        inst, context, source_group_id)"},{"line_number":90,"context_line":"    if not security_group:"},{"line_number":91,"context_line":"        raise ext_sg.SecurityGroupNotFound(id\u003dsource_group_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbXg%3D","line":88,"in_reply_to":"AAAAM3%2F%2FcrA%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"class NVPSecurityGroups(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _convert_to_nvp_rule(self, rule, with_id\u003dFalse):"},{"line_number":29,"context_line":"        \"\"\"Converts Qauntum API security group rule to NVP API.\"\"\""},{"line_number":30,"context_line":"        nvp_rule \u003d {}"},{"line_number":31,"context_line":"        params \u003d [\u0027source_ip_prefix\u0027, \u0027protocol\u0027,"},{"line_number":32,"context_line":"                  \u0027source_group_id\u0027, \u0027port_range_min\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FaiY%3D","line":29,"updated":"2013-01-23 13:54:34.000000000","message":"Qauntum -\u003e Quantum","commit_id":"f0b65284a40b7232303a68c80454251d4814cbc4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class NVPSecurityGroups(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _convert_to_nvp_rule(self, rule, with_id\u003dFalse):"},{"line_number":29,"context_line":"        \"\"\"Converts Qauntum API security group rule to NVP API.\"\"\""},{"line_number":30,"context_line":"        nvp_rule \u003d {}"},{"line_number":31,"context_line":"        params \u003d [\u0027source_ip_prefix\u0027, \u0027protocol\u0027,"},{"line_number":32,"context_line":"                  \u0027source_group_id\u0027, \u0027port_range_min\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FaKQ%3D","line":29,"in_reply_to":"AAAAM3%2F%2FaiY%3D","updated":"2013-01-23 17:33:18.000000000","message":"Done","commit_id":"f0b65284a40b7232303a68c80454251d4814cbc4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return merged_rules"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _remove_security_group_with_id_and_id_field(self, rules, id):"},{"line_number":108,"context_line":"        \"\"\"This function recieves all of the current rule associated with a"},{"line_number":109,"context_line":"        security group and then removes the rule that matches the id. In"},{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"},{"line_number":111,"context_line":"        should not be passed to nvp."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOR4%3D","line":108,"updated":"2013-02-01 14:46:43.000000000","message":"receives","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return merged_rules"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _remove_security_group_with_id_and_id_field(self, rules, id):"},{"line_number":108,"context_line":"        \"\"\"This function recieves all of the current rule associated with a"},{"line_number":109,"context_line":"        security group and then removes the rule that matches the id. In"},{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"},{"line_number":111,"context_line":"        should not be passed to nvp."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FN08%3D","line":108,"in_reply_to":"AAAAM3%2F%2FOR4%3D","updated":"2013-02-01 21:52:29.000000000","message":"Done","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":128,"context_line":"            del egress_rules[i][\u0027id\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if found_index \u003e\u003d 0:"},{"line_number":131,"context_line":"            del egress_rules[found_index]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FORQ%3D","line":131,"updated":"2013-02-01 14:46:43.000000000","message":"There\u0027s some code repetition here for ingress/egress rules. can we do a quick refactoring?","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        for param in params:"},{"line_number":38,"context_line":"            value \u003d rule.get(param)"},{"line_number":39,"context_line":"            if not value and param in rule:"},{"line_number":40,"context_line":"                continue"},{"line_number":41,"context_line":"            elif \u0027source_ip_prefix\u0027 \u003d\u003d param and param in rule:"},{"line_number":42,"context_line":"                nvp_rule[\u0027ip_prefix\u0027] \u003d rule[\u0027source_ip_prefix\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJYo%3D","line":39,"updated":"2013-02-05 17:31:28.000000000","message":"You\u0027re testing for param in rule 4 times.  Consider \n\nif param not in rule:\n    nvp_rule[param] \u003d value\nelif not value:\n    pass\nelif param \u003d\u003d \u0027source_ip_prefix\u0027:\n    nvp_rule[\u0027ip_prefix\u0027] \u003d rule[\u0027source_ip_prefix\u0027]\nelif param \u003d\u003d \u0027source_group_id\u0027:\n    nvp_rule[\u0027profile_uuid\u0027] \u003d rule[\u0027source_group_id\u0027]\nelif param \u003d\u003d \u0027protocol\u0027\n    nvp_rule[\u0027protocol\u0027] \u003d protocol_num_look_up[rule[\u0027protocol\u0027]]","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        for param in params:"},{"line_number":38,"context_line":"            value \u003d rule.get(param)"},{"line_number":39,"context_line":"            if not value and param in rule:"},{"line_number":40,"context_line":"                continue"},{"line_number":41,"context_line":"            elif \u0027source_ip_prefix\u0027 \u003d\u003d param and param in rule:"},{"line_number":42,"context_line":"                nvp_rule[\u0027ip_prefix\u0027] \u003d rule[\u0027source_ip_prefix\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FI%2Bc%3D","line":39,"in_reply_to":"AAAAM3%2F%2FJYo%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    self._convert_to_nvp_rule(rule))"},{"line_number":105,"context_line":"        return merged_rules"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _remove_security_group_with_id_and_id_field(self, rules, id):"},{"line_number":108,"context_line":"        \"\"\"This function receives all of the current rule associated with a"},{"line_number":109,"context_line":"        security group and then removes the rule that matches the id. In"},{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJXY%3D","line":107,"updated":"2013-02-05 17:31:28.000000000","message":"id is python builtin method.  Consider renaming to rule_id.","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    self._convert_to_nvp_rule(rule))"},{"line_number":105,"context_line":"        return merged_rules"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _remove_security_group_with_id_and_id_field(self, rules, id):"},{"line_number":108,"context_line":"        \"\"\"This function receives all of the current rule associated with a"},{"line_number":109,"context_line":"        security group and then removes the rule that matches the id. In"},{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJA0%3D","line":107,"in_reply_to":"AAAAM3%2F%2FJXY%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"},{"line_number":111,"context_line":"        should not be passed to nvp."},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        found_index \u003d -1"},{"line_number":114,"context_line":"        found_direction \u003d -1"},{"line_number":115,"context_line":"        for direction in [\u0027logical_port_ingress_rules\u0027,"},{"line_number":116,"context_line":"                          \u0027logical_port_egress_rules\u0027]:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJXk%3D","line":113,"updated":"2013-02-05 17:31:28.000000000","message":"Consider replacing 113-125.\n\nfor rule_direction in rules:\n    for i, value in enumerate(rule_direction):\n        if value[\u0027id\u0027] \u003d\u003d id:\n            del rule_direction[i]\n            break","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"},{"line_number":111,"context_line":"        should not be passed to nvp."},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        found_index \u003d -1"},{"line_number":114,"context_line":"        found_direction \u003d -1"},{"line_number":115,"context_line":"        for direction in [\u0027logical_port_ingress_rules\u0027,"},{"line_number":116,"context_line":"                          \u0027logical_port_egress_rules\u0027]:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FIv4%3D","line":113,"in_reply_to":"AAAAM3%2F%2FJA4%3D","updated":"2013-02-05 23:10:17.000000000","message":"Ok. But what happens when more than one match?  The last found_index is the only one rule that is deleted.  Should the other matches be deleted too?\n\nIf you just want to remove the id key then consider:\n\nfor rule_direction in rules:\n    for port_rule in rule_direction:\n        if port_rule[\u0027id\u0027] \u003d\u003d id:\n            del port_rule[\u0027id\u0027]","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        addition it removes the id field in the dict with each rule since that"},{"line_number":111,"context_line":"        should not be passed to nvp."},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        found_index \u003d -1"},{"line_number":114,"context_line":"        found_direction \u003d -1"},{"line_number":115,"context_line":"        for direction in [\u0027logical_port_ingress_rules\u0027,"},{"line_number":116,"context_line":"                          \u0027logical_port_egress_rules\u0027]:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJA4%3D","line":113,"in_reply_to":"AAAAM3%2F%2FJXk%3D","updated":"2013-02-05 21:00:51.000000000","message":"I don\u0027t want to actually break out of this though because I want to remove the id field from all the rules. This is needed since i don\u0027t want to send the id to nvp. Leaving what i have for now.","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"}],"quantum/plugins/nicira/nicira_nvp_plugin/nvplib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":628,"context_line":"        security_profile.get(\u0027external_id\u0027), tags)"},{"line_number":629,"context_line":"    # Allow all dhcp responses in"},{"line_number":630,"context_line":"    dhcp \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":631,"context_line":"                                           \u0027protocol\u0027: 17,"},{"line_number":632,"context_line":"                                           \u0027port_range_min\u0027: 68,"},{"line_number":633,"context_line":"                                           \u0027port_range_max\u0027: 68,"},{"line_number":634,"context_line":"                                           \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027}],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcqU%3D","line":631,"updated":"2013-01-22 04:38:39.000000000","message":"It would better to define a constant instead of using 17 directly.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        security_profile.get(\u0027external_id\u0027), tags)"},{"line_number":629,"context_line":"    # Allow all dhcp responses in"},{"line_number":630,"context_line":"    dhcp \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":631,"context_line":"                                           \u0027protocol\u0027: 17,"},{"line_number":632,"context_line":"                                           \u0027port_range_min\u0027: 68,"},{"line_number":633,"context_line":"                                           \u0027port_range_max\u0027: 68,"},{"line_number":634,"context_line":"                                           \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027}],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbXY%3D","line":631,"in_reply_to":"AAAAM3%2F%2FcqU%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":643,"context_line":"        LOG.error(format_exception(\"Unknown\", e, locals()))"},{"line_number":644,"context_line":"        raise exception.QuantumException()"},{"line_number":645,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":646,"context_line":"        # If if security group is default allow ip traffic between"},{"line_number":647,"context_line":"        # members of the same security profile."},{"line_number":648,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":649,"context_line":"                                                \u0027profile_uuid\u0027: rsp[\u0027uuid\u0027]},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2Fcqg%3D","line":646,"updated":"2013-01-22 04:38:39.000000000","message":"If if -\u003e if","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        LOG.error(format_exception(\"Unknown\", e, locals()))"},{"line_number":644,"context_line":"        raise exception.QuantumException()"},{"line_number":645,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":646,"context_line":"        # If if security group is default allow ip traffic between"},{"line_number":647,"context_line":"        # members of the same security profile."},{"line_number":648,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":649,"context_line":"                                                \u0027profile_uuid\u0027: rsp[\u0027uuid\u0027]},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbW8%3D","line":646,"in_reply_to":"AAAAM3%2F%2Fcqg%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    :param kwargs: the key/value pirs to be dumped into a json string."},{"line_number":586,"context_line":"    :returns: a json string.\"\"\""},{"line_number":587,"context_line":"    return unicode(json.dumps(dict(**kwargs)))"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"def set_tenant_id_tag(tenant_id, taglist\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FZto%3D","line":587,"updated":"2013-01-23 22:10:27.000000000","message":"By default json.dumps will always return ascii.  If you want possible unicode.  Also, kwargs is already a dict().  Consider:\n\nreturn json.dumps(kwargs, ensure_ascii\u003dFalse)","commit_id":"26ca3f1ac837ecf9a2304fbefb1b7cf134ca2b9c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    :param kwargs: the key/value pirs to be dumped into a json string."},{"line_number":586,"context_line":"    :returns: a json string.\"\"\""},{"line_number":587,"context_line":"    return unicode(json.dumps(dict(**kwargs)))"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"def set_tenant_id_tag(tenant_id, taglist\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FZlA%3D","line":587,"in_reply_to":"AAAAM3%2F%2FZto%3D","updated":"2013-01-24 02:17:56.000000000","message":"Done","commit_id":"26ca3f1ac837ecf9a2304fbefb1b7cf134ca2b9c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":557,"context_line":"    :param etype: a string describing the exception type."},{"line_number":558,"context_line":"    :param e: the exception."},{"line_number":559,"context_line":"    :param request: the request object."},{"line_number":560,"context_line":"    :param locals_: calling context local variable dict."},{"line_number":561,"context_line":"    :returns: a formatted string."},{"line_number":562,"context_line":"    \"\"\""},{"line_number":563,"context_line":"    msg \u003d [\"Error. %s exception: %s.\" % (etype, e)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOQo%3D","line":560,"updated":"2013-02-01 14:46:43.000000000","message":"I am curious why you are adding an underscore as suffix","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    :param etype: a string describing the exception type."},{"line_number":558,"context_line":"    :param e: the exception."},{"line_number":559,"context_line":"    :param request: the request object."},{"line_number":560,"context_line":"    :param locals_: calling context local variable dict."},{"line_number":561,"context_line":"    :returns: a formatted string."},{"line_number":562,"context_line":"    \"\"\""},{"line_number":563,"context_line":"    msg \u003d [\"Error. %s exception: %s.\" % (etype, e)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FN0Q%3D","line":560,"in_reply_to":"AAAAM3%2F%2FOQo%3D","updated":"2013-02-01 21:52:29.000000000","message":"Done","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":648,"context_line":"    except NvpApiClient.NvpApiException as e:"},{"line_number":649,"context_line":"        LOG.error(format_exception(\"Unknown\", e, locals()))"},{"line_number":650,"context_line":"        raise exception.QuantumException()"},{"line_number":651,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":652,"context_line":"        # If security group is default allow ip traffic between"},{"line_number":653,"context_line":"        # members of the same security profile."},{"line_number":654,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOQc%3D","line":651,"updated":"2013-02-01 14:46:43.000000000","message":"This is the only bit that made me sligtlhy concerned.\nI just want your opinion here, no need to change code.\n\nIf a client creates a security groups with name \u0027default\u0027 what happens? Is that forbidden by the API? Or does it end up being treated as a \u0027default\u0027 security group by applying the rules I see here?\n\nIf that happens, do you reckon it\u0027s ok?","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":648,"context_line":"    except NvpApiClient.NvpApiException as e:"},{"line_number":649,"context_line":"        LOG.error(format_exception(\"Unknown\", e, locals()))"},{"line_number":650,"context_line":"        raise exception.QuantumException()"},{"line_number":651,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":652,"context_line":"        # If security group is default allow ip traffic between"},{"line_number":653,"context_line":"        # members of the same security profile."},{"line_number":654,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FKFA%3D","line":651,"in_reply_to":"AAAAM3%2F%2FNx8%3D","updated":"2013-02-05 10:25:22.000000000","message":"I understand the \u0027special treatment\u0027 for the default security group in nvp. I was concerned about the fact that the fact which is a \u0027default\u0027 security group is hardcoded in the name. This kind of thing leads to confusion (for instance if one creates a security group named \u0027Default\u0027). I personally would prefer a boolean flag, but then we have to see whether this is feasible with nova integration.\n\nThis is however beyond the scope of this patch. If there is a case for doing this change we still have time before the final release.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":648,"context_line":"    except NvpApiClient.NvpApiException as e:"},{"line_number":649,"context_line":"        LOG.error(format_exception(\"Unknown\", e, locals()))"},{"line_number":650,"context_line":"        raise exception.QuantumException()"},{"line_number":651,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":652,"context_line":"        # If security group is default allow ip traffic between"},{"line_number":653,"context_line":"        # members of the same security profile."},{"line_number":654,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FNx8%3D","line":651,"in_reply_to":"AAAAM3%2F%2FOQc%3D","updated":"2013-02-01 21:52:29.000000000","message":"Yes, this is not allowed via the api https://github.com/openstack/quantum/blob/master/quantum/extensions/securitygroup.py#L159 . That line of code always raises. The reason for that is because any command via quantum as a user will create a default security group for them. This is the way nova does it too. \n\nthese rules for the db are generated here: \n\nThe reason why this code is here is because we create the security group in vnp first then the db. In order to create a security group and have a rule in with the profile_uuid being that of the sg_group have to create the security group in nvp and then add the rule (with the sg_profile_uuid). The database layer is able to do this in one short since it can just do uuid.uuid4() and use that. \n\nHere is where the db does it if it helps. https://github.com/openstack/quantum/blob/master/quantum/db/securitygroups_db.py#L128","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"def delete_security_profile(cluster, spid):"},{"line_number":687,"context_line":"    path \u003d \"/ws.v1/security-profile/%s\" % spid"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    try:"},{"line_number":690,"context_line":"        do_request(\"DELETE\", path, cluster\u003dcluster)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOQU%3D","line":687,"updated":"2013-02-01 14:46:43.000000000","message":"have you tried using _build_uri_path?\nIf you find it not useful we might just remove it.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"def delete_security_profile(cluster, spid):"},{"line_number":687,"context_line":"    path \u003d \"/ws.v1/security-profile/%s\" % spid"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    try:"},{"line_number":690,"context_line":"        do_request(\"DELETE\", path, cluster\u003dcluster)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FKE0%3D","line":687,"in_reply_to":"AAAAM3%2F%2FNx4%3D","updated":"2013-02-05 10:25:22.000000000","message":"No problem.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"def delete_security_profile(cluster, spid):"},{"line_number":687,"context_line":"    path \u003d \"/ws.v1/security-profile/%s\" % spid"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    try:"},{"line_number":690,"context_line":"        do_request(\"DELETE\", path, cluster\u003dcluster)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FNx4%3D","line":687,"in_reply_to":"AAAAM3%2F%2FOQU%3D","updated":"2013-02-01 21:52:29.000000000","message":"No I have not tried it. There are a lot of methods in here that don\u0027t use that. I\u0027d prefer to make all of them use it if we want to use that. IMO we should make this change so that all of them use _build_uri_path in a different patch if that\u0027s okay with you.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":430,"context_line":"        lport_obj[\"allowed_address_pairs\"].append("},{"line_number":431,"context_line":"            {\"mac_address\": mac_address,"},{"line_number":432,"context_line":"             \"ip_address\": \"0.0.0.0\"})"},{"line_number":433,"context_line":"    if security_profiles:"},{"line_number":434,"context_line":"        lport_obj[\u0027security_profiles\u0027] \u003d list(security_profiles)"},{"line_number":435,"context_line":"    else:"},{"line_number":436,"context_line":"        lport_obj[\u0027security_profiles\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJXI%3D","line":433,"updated":"2013-02-05 17:31:28.000000000","message":"Instead of 433-436, consider:\n\nlport_obj[\u0027security_profiles\u0027] \u003d list(security_profiles or [])","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        lport_obj[\"allowed_address_pairs\"].append("},{"line_number":431,"context_line":"            {\"mac_address\": mac_address,"},{"line_number":432,"context_line":"             \"ip_address\": \"0.0.0.0\"})"},{"line_number":433,"context_line":"    if security_profiles:"},{"line_number":434,"context_line":"        lport_obj[\u0027security_profiles\u0027] \u003d list(security_profiles)"},{"line_number":435,"context_line":"    else:"},{"line_number":436,"context_line":"        lport_obj[\u0027security_profiles\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJAQ%3D","line":433,"in_reply_to":"AAAAM3%2F%2FJXI%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":552,"context_line":"TENANT_ID_SCOPE \u003d \u0027os_tid\u0027"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"def format_exception(etype, e, locals, request\u003dNone):"},{"line_number":556,"context_line":"    \"\"\"Consistent formatting for exceptions."},{"line_number":557,"context_line":"    :param etype: a string describing the exception type."},{"line_number":558,"context_line":"    :param e: the exception."}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJWg%3D","line":555,"updated":"2013-02-05 17:31:28.000000000","message":"locals is a builtin python method.  Consider renaming exception_locals or something else.","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":552,"context_line":"TENANT_ID_SCOPE \u003d \u0027os_tid\u0027"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"def format_exception(etype, e, locals, request\u003dNone):"},{"line_number":556,"context_line":"    \"\"\"Consistent formatting for exceptions."},{"line_number":557,"context_line":"    :param etype: a string describing the exception type."},{"line_number":558,"context_line":"    :param e: the exception."}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FI94%3D","line":555,"in_reply_to":"AAAAM3%2F%2FJWg%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":565,"context_line":"        msg.append(\"request\u003d[%s]\" % request)"},{"line_number":566,"context_line":"        if request.body:"},{"line_number":567,"context_line":"            msg.append(\"request.body\u003d[%s]\" % str(request.body))"},{"line_number":568,"context_line":"    l \u003d dict(locals)"},{"line_number":569,"context_line":"    if \"request\" in l:"},{"line_number":570,"context_line":"        l.pop(\"request\")"},{"line_number":571,"context_line":"    msg.append(\"locals\u003d[%s]\" % str(l))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJW0%3D","line":568,"updated":"2013-02-05 17:31:28.000000000","message":"l \u003d dict((k, v) for k, v in locals if k !\u003d \u0027request\u0027)","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        msg.append(\"request\u003d[%s]\" % request)"},{"line_number":566,"context_line":"        if request.body:"},{"line_number":567,"context_line":"            msg.append(\"request.body\u003d[%s]\" % str(request.body))"},{"line_number":568,"context_line":"    l \u003d dict(locals)"},{"line_number":569,"context_line":"    if \"request\" in l:"},{"line_number":570,"context_line":"        l.pop(\"request\")"},{"line_number":571,"context_line":"    msg.append(\"locals\u003d[%s]\" % str(l))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJAM%3D","line":568,"in_reply_to":"AAAAM3%2F%2FJW0%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"}],"quantum/tests/unit/nicira/fake_nvpapiclient.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":237,"context_line":"        (res_type, s_uuid, p_uuid, sec_uuid) \u003d self._get_resource_type("},{"line_number":238,"context_line":"            parsedurl.path)"},{"line_number":239,"context_line":"        target_uuid \u003d p_uuid or s_uuid or sec_uuid"},{"line_number":240,"context_line":"        print sec_uuid"},{"line_number":241,"context_line":"        print res_type"},{"line_number":242,"context_line":"        response_file \u003d self.FAKE_PUT_RESPONSES.get(res_type)"},{"line_number":243,"context_line":"        if not response_file:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJWQ%3D","line":240,"updated":"2013-02-05 17:31:28.000000000","message":"Ooops.  print statement","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        (res_type, s_uuid, p_uuid, sec_uuid) \u003d self._get_resource_type("},{"line_number":238,"context_line":"            parsedurl.path)"},{"line_number":239,"context_line":"        target_uuid \u003d p_uuid or s_uuid or sec_uuid"},{"line_number":240,"context_line":"        print sec_uuid"},{"line_number":241,"context_line":"        print res_type"},{"line_number":242,"context_line":"        response_file \u003d self.FAKE_PUT_RESPONSES.get(res_type)"},{"line_number":243,"context_line":"        if not response_file:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJAc%3D","line":240,"in_reply_to":"AAAAM3%2F%2FJWQ%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":238,"context_line":"            parsedurl.path)"},{"line_number":239,"context_line":"        target_uuid \u003d p_uuid or s_uuid or sec_uuid"},{"line_number":240,"context_line":"        print sec_uuid"},{"line_number":241,"context_line":"        print res_type"},{"line_number":242,"context_line":"        response_file \u003d self.FAKE_PUT_RESPONSES.get(res_type)"},{"line_number":243,"context_line":"        if not response_file:"},{"line_number":244,"context_line":"            raise Exception(\"resource not found\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJWM%3D","line":241,"updated":"2013-02-05 17:31:28.000000000","message":"ditto","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            parsedurl.path)"},{"line_number":239,"context_line":"        target_uuid \u003d p_uuid or s_uuid or sec_uuid"},{"line_number":240,"context_line":"        print sec_uuid"},{"line_number":241,"context_line":"        print res_type"},{"line_number":242,"context_line":"        response_file \u003d self.FAKE_PUT_RESPONSES.get(res_type)"},{"line_number":243,"context_line":"        if not response_file:"},{"line_number":244,"context_line":"            raise Exception(\"resource not found\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAM3%2F%2FJAY%3D","line":241,"in_reply_to":"AAAAM3%2F%2FJWM%3D","updated":"2013-02-05 21:00:51.000000000","message":"Done","commit_id":"c25f3fb40d74414bd799ce3a6a42de976ee0765d"}],"quantum/tests/unit/nicira/test_nicira_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import quantum.common.test_lib as test_lib"},{"line_number":23,"context_line":"from quantum import context"},{"line_number":24,"context_line":"from quantum.extensions import securitygroup as secgrp"},{"line_number":25,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":26,"context_line":"from quantum import manager"},{"line_number":27,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcqI%3D","line":24,"updated":"2013-01-22 04:38:39.000000000","message":"This should be moved after L.25","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import quantum.common.test_lib as test_lib"},{"line_number":23,"context_line":"from quantum import context"},{"line_number":24,"context_line":"from quantum.extensions import securitygroup as secgrp"},{"line_number":25,"context_line":"from quantum.extensions import providernet as pnet"},{"line_number":26,"context_line":"from quantum import manager"},{"line_number":27,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FbW0%3D","line":24,"in_reply_to":"AAAAM3%2F%2FcqI%3D","updated":"2013-01-22 22:51:39.000000000","message":"Done","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    _plugin_name \u003d (\u0027%s.QuantumPlugin.NvpPluginV2\u0027 % NICIRA_PKG_PATH)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def setUp(self):"},{"line_number":214,"context_line":"        etc_path \u003d os.path.join(os.path.dirname(__file__), \u0027etc\u0027)"},{"line_number":215,"context_line":"        test_lib.test_config[\u0027config_files\u0027] \u003d [os.path.join(etc_path,"},{"line_number":216,"context_line":"                                                             \u0027nvp.ini.test\u0027)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FOQQ%3D","line":213,"updated":"2013-02-01 14:46:43.000000000","message":"Can\u0027t just inherit from NiciraPluginV2TestCase?\nI think you can...","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    _plugin_name \u003d (\u0027%s.QuantumPlugin.NvpPluginV2\u0027 % NICIRA_PKG_PATH)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def setUp(self):"},{"line_number":214,"context_line":"        etc_path \u003d os.path.join(os.path.dirname(__file__), \u0027etc\u0027)"},{"line_number":215,"context_line":"        test_lib.test_config[\u0027config_files\u0027] \u003d [os.path.join(etc_path,"},{"line_number":216,"context_line":"                                                             \u0027nvp.ini.test\u0027)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FKEw%3D","line":213,"in_reply_to":"AAAAM3%2F%2FNxo%3D","updated":"2013-02-05 10:25:22.000000000","message":"No problem. We\u0027ll fix this later.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"6d574af4c9291328e1e643ca2fc40b9779421dfb","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    _plugin_name \u003d (\u0027%s.QuantumPlugin.NvpPluginV2\u0027 % NICIRA_PKG_PATH)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def setUp(self):"},{"line_number":214,"context_line":"        etc_path \u003d os.path.join(os.path.dirname(__file__), \u0027etc\u0027)"},{"line_number":215,"context_line":"        test_lib.test_config[\u0027config_files\u0027] \u003d [os.path.join(etc_path,"},{"line_number":216,"context_line":"                                                             \u0027nvp.ini.test\u0027)]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAM3%2F%2FNxo%3D","line":213,"in_reply_to":"AAAAM3%2F%2FOQQ%3D","updated":"2013-02-01 21:52:29.000000000","message":"Hrm, I tried this but I\u0027m not quite sure what i\u0027m doing wrong here..spent the last 30 min trying to get this to work :/ . would it be alright with you to fix this in another patch? It seems like the same thing should be done for NiciraPortSecurityTestCase above.","commit_id":"d55b3ddaf4fe28d068e22616aeb3f4ff49ea6789"}],"quantum/tests/unit/test_extension_security_group.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def tearDown(self):"},{"line_number":211,"context_line":"        del test_config[\u0027plugin_name_v2\u0027]"},{"line_number":212,"context_line":"        super(SecurityGroupDBTestCase, self).tearDown()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class TestSecurityGroups(SecurityGroupDBTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FcqQ%3D","line":212,"updated":"2013-01-22 04:38:39.000000000","message":"Nice catch.","commit_id":"c7ed490ab9c75dfa6dd92a337fc7071de3096c5a"}]}
