)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jason Zhang \u003czhesen@nttmcl.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-21 18:37:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added the device owner option for port creation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user can specify the device owner of the"},{"line_number":10,"context_line":"probe port by the --device_owner option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FaeA%3D","line":7,"updated":"2013-01-23 14:33:57.000000000","message":"Could you change the commit message to describe this commit is a patch for quantum-debug: \u0027Allow probe-create to specify device_owner\u0027 or  \u0027Added device_owner option to probe-create\u0027","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":4184,"name":"Jason Zhang","email":"zhesen@nttmcl.com","username":"zzs"},"change_message_id":"f7daa060e73589792653dffae0701e4aac62ee73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jason Zhang \u003czhesen@nttmcl.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-21 18:37:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added the device owner option for port creation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user can specify the device owner of the"},{"line_number":10,"context_line":"probe port by the --device_owner option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FQnc%3D","line":7,"in_reply_to":"AAAAM3%2F%2FaeA%3D","updated":"2013-01-31 02:51:53.000000000","message":"sure, will do","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow probe-create to specify device_owner."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The device owner of the probe port can be"},{"line_number":10,"context_line":"specified by the --device_owner option."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"There are two values for device_owner option,"},{"line_number":13,"context_line":"network or compute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2FCyA%3D","line":10,"updated":"2013-02-09 14:28:33.000000000","message":"Needs to change to \u0027--device-owner\u0027","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"}],"quantum/debug/commands.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--device_owner\u0027,"},{"line_number":49,"context_line":"            default\u003d\u0027network\u0027, choices\u003d[\u0027network\u0027, \u0027compute\u0027],"},{"line_number":50,"context_line":"            help\u003d\u0027the owner of the device: network/compute\u0027)"},{"line_number":51,"context_line":"        return parser"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fad0%3D","line":50,"updated":"2013-01-23 14:33:57.000000000","message":"the owner of the device -\u003e owner type of the device\n\n\u0027the\u0027 before \u0027owner\u0027 is not required.","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"            \u0027id\u0027, metavar\u003d\u0027network_id\u0027,"},{"line_number":46,"context_line":"            help\u003d_(\u0027ID of network to probe\u0027))"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--device_owner\u0027,"},{"line_number":49,"context_line":"            default\u003d\u0027network\u0027, choices\u003d[\u0027network\u0027, \u0027compute\u0027],"},{"line_number":50,"context_line":"            help\u003d_(\u0027owner type of the device: network/compute\u0027))"},{"line_number":51,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FCyM%3D","line":48,"updated":"2013-02-09 14:28:33.000000000","message":"Please use a hyphen like \u0027--device-owner\u0027. \nAn underscore is deprecated. This convention is common across openstack CLIs.","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"}],"quantum/debug/debug_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"DEVICE_OWNER_NETWORK_PROBE \u003d \u0027network:probe\u0027"},{"line_number":33,"context_line":"DEVICE_OWNER_NOVA_PROBE \u003d \u0027compute:probe\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QuantumDebugAgent():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fad4%3D","line":33,"updated":"2013-01-23 14:33:57.000000000","message":"NOVA_PROBE -\u003e COMPUTE_PROBE\n\ndevice_owner set by nova-compute has a format \u0027compute:\u003cavailability_zone\u003e\u0027. \u0027nova\u0027 in \u0027compute:nova\u0027 is just a name of availability_zone.","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":4184,"name":"Jason Zhang","email":"zhesen@nttmcl.com","username":"zzs"},"change_message_id":"f7daa060e73589792653dffae0701e4aac62ee73","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"DEVICE_OWNER_NETWORK_PROBE \u003d \u0027network:probe\u0027"},{"line_number":33,"context_line":"DEVICE_OWNER_NOVA_PROBE \u003d \u0027compute:probe\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QuantumDebugAgent():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQnw%3D","line":33,"in_reply_to":"AAAAM3%2F%2Fad4%3D","updated":"2013-01-31 02:51:53.000000000","message":"Thank you very much, I will change it.","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DEVICE_OWNER_NETWORK_PROBE \u003d \u0027network:probe\u0027"},{"line_number":34,"context_line":"DEVICE_OWNER_COMPUTE_PROBE \u003d \u0027compute:probe\u0027"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FC%2Bc%3D","line":32,"updated":"2013-02-09 03:22:28.000000000","message":"Nit: You should either group these or there should be an extra blank line here.","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"}],"quantum/tests/unit/test_debug_commands.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"438963ec20e4023fcd2a7273738292ae410bf775","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                 client_inst,"},{"line_number":104,"context_line":"                                                 mock_driver)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_create_probe(self):"},{"line_number":107,"context_line":"        cmd \u003d commands.CreateProbe(self.app, None)"},{"line_number":108,"context_line":"        cmd_parser \u003d cmd.get_parser(\u0027create_probe\u0027)"},{"line_number":109,"context_line":"        args \u003d [\u0027fake_net\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FcKM%3D","line":106,"updated":"2013-01-22 15:43:10.000000000","message":"There is a lot of repeated code in this test.  You should refactor this into a common helper method and two tests.","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"438963ec20e4023fcd2a7273738292ae410bf775","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                                        [\u002710.0.0.3/24\u0027],"},{"line_number":160,"context_line":"                                                        namespace\u003dnamespace"},{"line_number":161,"context_line":"                                                        )])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_create_probe_external(self):"},{"line_number":164,"context_line":"        fake_network \u003d {\u0027network\u0027: {\u0027id\u0027: \u0027fake_net\u0027,"},{"line_number":165,"context_line":"                                    \u0027tenant_id\u0027: \u0027fake_tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FcKQ%3D","line":162,"updated":"2013-01-22 15:43:10.000000000","message":"There is a lot of repeated code in this test.  You should refactor this into a common helper method and two tests.","commit_id":"1670ac8421f4b83879d2d1a7f2a6ef99f16834b6"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"from quantum.agent.linux import interface"},{"line_number":25,"context_line":"from quantum.debug import commands"},{"line_number":26,"context_line":"from quantum.debug.debug_agent import DEVICE_OWNER_NETWORK_PROBE"},{"line_number":27,"context_line":"from quantum.debug.debug_agent import DEVICE_OWNER_COMPUTE_PROBE"},{"line_number":28,"context_line":"from quantum.debug.debug_agent import QuantumDebugAgent"},{"line_number":29,"context_line":"from quantum.openstack.common import cfg"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FC%2FI%3D","line":27,"updated":"2013-02-09 03:22:28.000000000","message":"Nit: Order of above imports should be reversed","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"        cmd \u003d commands.CreateProbe(self.app, None)"},{"line_number":109,"context_line":"        cmd_parser \u003d cmd.get_parser(\u0027create_probe\u0027)"},{"line_number":110,"context_line":"        if device_owner \u003d\u003d DEVICE_OWNER_COMPUTE_PROBE:"},{"line_number":111,"context_line":"            args \u003d [\u0027fake_net\u0027, \u0027--device_owner\u0027, \u0027compute\u0027]"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            args \u003d [\u0027fake_net\u0027]"},{"line_number":114,"context_line":"        parsed_args \u003d cmd_parser.parse_args(args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FCyI%3D","line":111,"updated":"2013-02-09 14:28:33.000000000","message":"--device-owner","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":152,"context_line":"        cmd \u003d commands.CreateProbe(self.app, None)"},{"line_number":153,"context_line":"        cmd_parser \u003d cmd.get_parser(\u0027create_probe\u0027)"},{"line_number":154,"context_line":"        if device_owner \u003d\u003d DEVICE_OWNER_COMPUTE_PROBE:"},{"line_number":155,"context_line":"            args \u003d [\u0027fake_net\u0027, \u0027--device_owner\u0027, \u0027compute\u0027]"},{"line_number":156,"context_line":"        else:"},{"line_number":157,"context_line":"            args \u003d [\u0027fake_net\u0027]"},{"line_number":158,"context_line":"        parsed_args \u003d cmd_parser.parse_args(args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FCyE%3D","line":155,"updated":"2013-02-09 14:28:33.000000000","message":"--device-owner","commit_id":"cca683f70ad7f336cdebab3c2f75c0c2e899b6eb"}]}
