)]}'
{"quantum/api/extensions.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                        attr_map[resource].update(resource_attrs)"},{"line_number":437,"context_line":"                    else:"},{"line_number":438,"context_line":"                        attr_map[resource] \u003d resource_attrs"},{"line_number":439,"context_line":"                    attr_map[constants.EXT_NS][ext.get_alias()] \u003d ("},{"line_number":440,"context_line":"                        ext.get_namespace())"},{"line_number":441,"context_line":"            except AttributeError:"},{"line_number":442,"context_line":"                LOG.exception(_(\"Error fetching extended attributes for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgUQ%3D","line":439,"updated":"2013-01-18 04:35:50.000000000","message":"This does not need to be inside of this for loop.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                        attr_map[resource].update(resource_attrs)"},{"line_number":437,"context_line":"                    else:"},{"line_number":438,"context_line":"                        attr_map[resource] \u003d resource_attrs"},{"line_number":439,"context_line":"                    attr_map[constants.EXT_NS][ext.get_alias()] \u003d ("},{"line_number":440,"context_line":"                        ext.get_namespace())"},{"line_number":441,"context_line":"            except AttributeError:"},{"line_number":442,"context_line":"                LOG.exception(_(\"Error fetching extended attributes for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgI4%3D","line":439,"in_reply_to":"AAAAM3%2F%2FgUQ%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/api/v2/attributes.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":402,"context_line":"# mechanism, ie: there might be rules which refer to this attribute."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":405,"context_line":"    constants.EXT_NS: {},"},{"line_number":406,"context_line":"    \u0027networks\u0027: {"},{"line_number":407,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":408,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeGU%3D","line":405,"updated":"2013-01-21 12:22:10.000000000","message":"i do not understand why this is here. can you please explain.","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":402,"context_line":"# mechanism, ie: there might be rules which refer to this attribute."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":405,"context_line":"    constants.EXT_NS: {},"},{"line_number":406,"context_line":"    \u0027networks\u0027: {"},{"line_number":407,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":408,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fd4M%3D","line":405,"in_reply_to":"AAAAM3%2F%2FeGU%3D","updated":"2013-01-23 00:39:17.000000000","message":"every extension has alias, which is prefix and namespace. we have to have a place to record it. extensions.py has enumerated the extensions when loading them, where can can store their alias and namespace here.","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":402,"context_line":"# mechanism, ie: there might be rules which refer to this attribute."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":405,"context_line":"    constants.EXT_NS: {},"},{"line_number":406,"context_line":"    \u0027networks\u0027: {"},{"line_number":407,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":408,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOIQ%3D","line":405,"updated":"2013-02-01 16:23:58.000000000","message":"This has been the subject of previous discussion so I apologise if I come back to this topic.\nIt seems this entry is used only in get_attr_metadata.\nAs it\u0027s a bit not really in the right place - I won\u0027t expect to find namespace in RESOURCE_ATTRIBUTE_MAP.\n\nCan\u0027t we just return it in get_attr_metadata without having this element in RESOURCE ATTRIBUTE MAP?\n\nOne of the reason is that I think in the future we might have API processes that iterate over this data structure for generating resources, and it\u0027s not ideal to have there something which is not a resource.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":402,"context_line":"# mechanism, ie: there might be rules which refer to this attribute."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":405,"context_line":"    constants.EXT_NS: {},"},{"line_number":406,"context_line":"    \u0027networks\u0027: {"},{"line_number":407,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":408,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOGM%3D","line":405,"in_reply_to":"AAAAM3%2F%2FOIQ%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"}],"quantum/api/v2/base.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"XML_NS_V20 \u003d constants.XML_NS_V20"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"FAULT_MAP \u003d {exceptions.NotFound: webob.exc.HTTPNotFound,"},{"line_number":35,"context_line":"             exceptions.Conflict: webob.exc.HTTPConflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgUU%3D","line":32,"updated":"2013-01-18 04:35:50.000000000","message":"I don\u0027t think this is needed anymore","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"XML_NS_V20 \u003d constants.XML_NS_V20"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"FAULT_MAP \u003d {exceptions.NotFound: webob.exc.HTTPNotFound,"},{"line_number":35,"context_line":"             exceptions.Conflict: webob.exc.HTTPConflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgI0%3D","line":32,"in_reply_to":"AAAAM3%2F%2FgUU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/api/v2/resource.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    deserializer \u003d wsgi.XMLDeserializer(attributes.get_attr_metadata())"},{"line_number":80,"context_line":"    default_deserializers \u003d {\u0027application/xml\u0027: deserializer,"},{"line_number":81,"context_line":"                             \u0027application/json\u0027: wsgi.JSONDeserializer()}"},{"line_number":82,"context_line":"    serializer \u003d wsgi.XMLDictSerializer(attributes.get_attr_metadata())"},{"line_number":83,"context_line":"    default_serializers \u003d {\u0027application/xml\u0027: serializer,"},{"line_number":84,"context_line":"                           \u0027application/json\u0027: wsgi.JSONDictSerializer()}"},{"line_number":85,"context_line":"    format_types \u003d {\u0027xml\u0027: \u0027application/xml\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgT4%3D","line":82,"updated":"2013-01-18 04:35:50.000000000","message":"xml_serializer \u003d","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    deserializer \u003d wsgi.XMLDeserializer(attributes.get_attr_metadata())"},{"line_number":80,"context_line":"    default_deserializers \u003d {\u0027application/xml\u0027: deserializer,"},{"line_number":81,"context_line":"                             \u0027application/json\u0027: wsgi.JSONDeserializer()}"},{"line_number":82,"context_line":"    serializer \u003d wsgi.XMLDictSerializer(attributes.get_attr_metadata())"},{"line_number":83,"context_line":"    default_serializers \u003d {\u0027application/xml\u0027: serializer,"},{"line_number":84,"context_line":"                           \u0027application/json\u0027: wsgi.JSONDictSerializer()}"},{"line_number":85,"context_line":"    format_types \u003d {\u0027xml\u0027: \u0027application/xml\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIw%3D","line":82,"in_reply_to":"AAAAM3%2F%2FgT4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"17a1ad8fb9c556fbca23a43ebac3b55642fc5147","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Request(webob.Request):"},{"line_number":35,"context_line":"    \"\"\"Add some Openstack API-specific logic to the base webob.Request.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def best_match_content_type(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FUSc%3D","line":34,"updated":"2013-01-29 11:05:04.000000000","message":"why we define two Request class at here and in quantum.wsgi?And those two class is same. But I think is out of the scope this patch","commit_id":"2be9594abffcf194ffd8bb0b965c7d018028bbac"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Request(webob.Request):"},{"line_number":35,"context_line":"    \"\"\"Add some Openstack API-specific logic to the base webob.Request.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def best_match_content_type(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FUFQ%3D","line":34,"in_reply_to":"AAAAM3%2F%2FUSc%3D","updated":"2013-01-29 12:38:11.000000000","message":"it is a complicated case. we can refactor it in new patch.","commit_id":"2be9594abffcf194ffd8bb0b965c7d018028bbac"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Add some Openstack API-specific logic to the base webob.Request.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def best_match_content_type(self):"},{"line_number":38,"context_line":"        # First lookup http request"},{"line_number":39,"context_line":"        parts \u003d self.path.rsplit(\u0027.\u0027, 1)"},{"line_number":40,"context_line":"        if len(parts) \u003e 1:"},{"line_number":41,"context_line":"            _format \u003d parts[1]"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOOs%3D","line":38,"updated":"2013-02-01 16:23:58.000000000","message":"Perhaps you mean request URI","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if len(parts) \u003e 1:"},{"line_number":41,"context_line":"            _format \u003d parts[1]"},{"line_number":42,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":43,"context_line":"                return \u0027application/{0}\u0027.format(parts[1])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOOo%3D","line":43,"updated":"2013-02-01 16:23:58.000000000","message":"IMHO if one specifies .jton instead of moving to the content header we should return an error \u0027invalid request format\u0027","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if len(parts) \u003e 1:"},{"line_number":41,"context_line":"            _format \u003d parts[1]"},{"line_number":42,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":43,"context_line":"                return \u0027application/{0}\u0027.format(parts[1])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOF4%3D","line":43,"in_reply_to":"AAAAM3%2F%2FOOo%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":43,"context_line":"                return \u0027application/{0}\u0027.format(parts[1])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"},{"line_number":47,"context_line":"        if type_from_header:"},{"line_number":48,"context_line":"            return type_from_header"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOOc%3D","line":45,"updated":"2013-02-01 16:23:58.000000000","message":"content-type (just for pedantry)","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":43,"context_line":"                return \u0027application/{0}\u0027.format(parts[1])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"},{"line_number":47,"context_line":"        if type_from_header:"},{"line_number":48,"context_line":"            return type_from_header"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOF8%3D","line":45,"in_reply_to":"AAAAM3%2F%2FOOc%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"},{"line_number":47,"context_line":"        if type_from_header:"},{"line_number":48,"context_line":"            return type_from_header"},{"line_number":49,"context_line":"        ctypes \u003d [\u0027application/json\u0027, \u0027application/xml\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        #Finally search in Accept-* headers"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOOk%3D","line":48,"updated":"2013-02-01 16:23:58.000000000","message":"I would validate the type from header too as you did for the suffix in the URI path.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"},{"line_number":47,"context_line":"        if type_from_header:"},{"line_number":48,"context_line":"            return type_from_header"},{"line_number":49,"context_line":"        ctypes \u003d [\u0027application/json\u0027, \u0027application/xml\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        #Finally search in Accept-* headers"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOCg%3D","line":48,"in_reply_to":"AAAAM3%2F%2FOFo%3D","updated":"2013-02-01 17:24:10.000000000","message":"sorry I missed that","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        #Then look up content header"},{"line_number":46,"context_line":"        type_from_header \u003d self.get_content_type()"},{"line_number":47,"context_line":"        if type_from_header:"},{"line_number":48,"context_line":"            return type_from_header"},{"line_number":49,"context_line":"        ctypes \u003d [\u0027application/json\u0027, \u0027application/xml\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        #Finally search in Accept-* headers"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOFo%3D","line":48,"in_reply_to":"AAAAM3%2F%2FOOk%3D","updated":"2013-02-01 17:06:31.000000000","message":"I think We have done it in get_content_type()","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"}],"quantum/common/constants.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"EXT_NS \u003d \u0027_extension_ns\u0027"},{"line_number":38,"context_line":"XML_NS_V20 \u003d \u0027http://openstack.org/quantum/api/v2.0\u0027"},{"line_number":39,"context_line":"XSI_NAMESPACE \u003d \"http://www.w3.org/2001/XMLSchema-instance\""},{"line_number":40,"context_line":"XSI_ATTR \u003d \"xsi:nil\""},{"line_number":41,"context_line":"XSI_XMLNS \u003d \"xmlns:xsi\""},{"line_number":42,"context_line":"TYPE_XMLNS \u003d \"xmlns:quantum\""},{"line_number":43,"context_line":"TYPE_ATTR \u003d \"quantum:type\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOJ8%3D","line":40,"updated":"2013-02-01 16:23:58.000000000","message":"I\u0027d change this into XSI_NIL_ATTR","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"EXT_NS \u003d \u0027_extension_ns\u0027"},{"line_number":38,"context_line":"XML_NS_V20 \u003d \u0027http://openstack.org/quantum/api/v2.0\u0027"},{"line_number":39,"context_line":"XSI_NAMESPACE \u003d \"http://www.w3.org/2001/XMLSchema-instance\""},{"line_number":40,"context_line":"XSI_ATTR \u003d \"xsi:nil\""},{"line_number":41,"context_line":"XSI_XMLNS \u003d \"xmlns:xsi\""},{"line_number":42,"context_line":"TYPE_XMLNS \u003d \"xmlns:quantum\""},{"line_number":43,"context_line":"TYPE_ATTR \u003d \"quantum:type\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOFk%3D","line":40,"in_reply_to":"AAAAM3%2F%2FOJ8%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"XSI_XMLNS \u003d \"xmlns:xsi\""},{"line_number":42,"context_line":"TYPE_XMLNS \u003d \"xmlns:quantum\""},{"line_number":43,"context_line":"TYPE_ATTR \u003d \"quantum:type\""},{"line_number":44,"context_line":"VIRUTUAL_ROOT_KEY \u003d \"_v_root\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"TYPE_BOOL \u003d \"bool\""},{"line_number":47,"context_line":"TYPE_INT \u003d \"int\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOMQ%3D","line":44,"updated":"2013-02-01 16:23:58.000000000","message":"VIRTUAL?","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"XSI_XMLNS \u003d \"xmlns:xsi\""},{"line_number":42,"context_line":"TYPE_XMLNS \u003d \"xmlns:quantum\""},{"line_number":43,"context_line":"TYPE_ATTR \u003d \"quantum:type\""},{"line_number":44,"context_line":"VIRUTUAL_ROOT_KEY \u003d \"_v_root\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"TYPE_BOOL \u003d \"bool\""},{"line_number":47,"context_line":"TYPE_INT \u003d \"int\""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOFg%3D","line":44,"in_reply_to":"AAAAM3%2F%2FOMQ%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"}],"quantum/db/quota_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            tenant_quota[quota[\u0027resource\u0027]] \u003d quota[\u0027limit\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return all_tenant_quotas.values()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @staticmethod"},{"line_number":109,"context_line":"    def update_quota_limit(context, tenant_id, resource, limit):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOOI%3D","line":106,"updated":"2013-02-01 16:23:58.000000000","message":"I do not understand how this change relates to xml support. Can you enlighten me?","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            tenant_quota[quota[\u0027resource\u0027]] \u003d quota[\u0027limit\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return all_tenant_quotas.values()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @staticmethod"},{"line_number":109,"context_line":"    def update_quota_limit(context, tenant_id, resource, limit):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOFI%3D","line":106,"in_reply_to":"AAAAM3%2F%2FOOI%3D","updated":"2013-02-01 17:06:31.000000000","message":"serilizer need to tell the type of data: if isinstance(data, list): xxx\nthe original itervalues() is not list, it is an iterator.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"}],"quantum/extensions/l3.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    @classmethod"},{"line_number":184,"context_line":"    def get_resources(cls):"},{"line_number":185,"context_line":"        \"\"\" Returns Ext Resources \"\"\""},{"line_number":186,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":187,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":188,"context_line":"        exts \u003d []"},{"line_number":189,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTk%3D","line":186,"updated":"2013-01-18 04:35:50.000000000","message":"This should be factored out in to method in quantum.api.v2.attributes that updates the plurals given a map.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    @classmethod"},{"line_number":184,"context_line":"    def get_resources(cls):"},{"line_number":185,"context_line":"        \"\"\" Returns Ext Resources \"\"\""},{"line_number":186,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":187,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":188,"context_line":"        exts \u003d []"},{"line_number":189,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIs%3D","line":186,"in_reply_to":"AAAAM3%2F%2FgTk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Don\u0027t understand very much, can u show me what to do?","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/extensions/loadbalancer.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @classmethod"},{"line_number":258,"context_line":"    def get_resources(cls):"},{"line_number":259,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":260,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":261,"context_line":"        resources \u003d []"},{"line_number":262,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTg%3D","line":259,"updated":"2013-01-18 04:35:50.000000000","message":"same as before","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @classmethod"},{"line_number":258,"context_line":"    def get_resources(cls):"},{"line_number":259,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":260,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":261,"context_line":"        resources \u003d []"},{"line_number":262,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIo%3D","line":259,"in_reply_to":"AAAAM3%2F%2FgTg%3D","updated":"2013-01-18 07:14:22.000000000","message":"please give me an example how to fix it. thanks","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/extensions/securitygroup.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    @classmethod"},{"line_number":268,"context_line":"    def get_resources(cls):"},{"line_number":269,"context_line":"        \"\"\" Returns Ext Resources \"\"\""},{"line_number":270,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":271,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":272,"context_line":"        exts \u003d []"},{"line_number":273,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTc%3D","line":270,"updated":"2013-01-18 04:35:50.000000000","message":"same as before","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    @classmethod"},{"line_number":268,"context_line":"    def get_resources(cls):"},{"line_number":269,"context_line":"        \"\"\" Returns Ext Resources \"\"\""},{"line_number":270,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":271,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":272,"context_line":"        exts \u003d []"},{"line_number":273,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIk%3D","line":270,"in_reply_to":"AAAAM3%2F%2FgTc%3D","updated":"2013-01-18 07:14:22.000000000","message":"same","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/cisco/test_network_plugin_xml.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTY%3D","line":1,"updated":"2013-01-18 04:35:50.000000000","message":"Why are we adding a new file.  This should be in the same file with the other tests.  If there are in two files, they are likely to missed.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIU%3D","line":1,"in_reply_to":"AAAAM3%2F%2FgTY%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":21,"context_line":"        super(TestCiscoPortsV2XML, self).__init__("},{"line_number":22,"context_line":"            methodName\u003dmethodName)"},{"line_number":23,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestCiscoNetworksV2XML(test_network_plugin.TestCiscoNetworksV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTU%3D","line":23,"updated":"2013-01-18 04:35:50.000000000","message":"You don\u0027t need the much boiler plate.  You can use a class var. For example the whole declaration can be replaced with:\n\nTestCiscoPortsV2XML(test_network_plugin.TestCiscoPortsV2):\n    fmt \u003d \u0027xml\u0027","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":21,"context_line":"        super(TestCiscoPortsV2XML, self).__init__("},{"line_number":22,"context_line":"            methodName\u003dmethodName)"},{"line_number":23,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestCiscoNetworksV2XML(test_network_plugin.TestCiscoNetworksV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIg%3D","line":23,"in_reply_to":"AAAAM3%2F%2FgTU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestCiscoNetworksV2XML(test_network_plugin.TestCiscoNetworksV2):"},{"line_number":27,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":28,"context_line":"        super(TestCiscoNetworksV2XML, self).__init__("},{"line_number":29,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTQ%3D","line":26,"updated":"2013-01-18 04:35:50.000000000","message":"see above","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestCiscoNetworksV2XML(test_network_plugin.TestCiscoNetworksV2):"},{"line_number":27,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":28,"context_line":"        super(TestCiscoNetworksV2XML, self).__init__("},{"line_number":29,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIc%3D","line":26,"in_reply_to":"AAAAM3%2F%2FgTQ%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestCiscoSubnetsV2XML(test_network_plugin.TestCiscoSubnetsV2):"},{"line_number":34,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":35,"context_line":"        super(TestCiscoSubnetsV2XML, self).__init__("},{"line_number":36,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTM%3D","line":33,"updated":"2013-01-18 04:35:50.000000000","message":"same","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.fmt \u003d \u0027xml\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestCiscoSubnetsV2XML(test_network_plugin.TestCiscoSubnetsV2):"},{"line_number":34,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":35,"context_line":"        super(TestCiscoSubnetsV2XML, self).__init__("},{"line_number":36,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIY%3D","line":33,"in_reply_to":"AAAAM3%2F%2FgTM%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"17a1ad8fb9c556fbca23a43ebac3b55642fc5147","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return os.path.join(ETCDIR, *p)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class LoadBalancerPluginDbTestCase(unittest2.TestCase):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FSIw%3D","line":57,"updated":"2013-01-30 10:53:44.000000000","message":"This class can be subclass of testlib_api.WebTestCase","commit_id":"5ba1a066251c2db0c2ca0f4e39c9740d349f4e57"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return os.path.join(ETCDIR, *p)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class LoadBalancerPluginDbTestCase(unittest2.TestCase):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FSGo%3D","line":57,"in_reply_to":"AAAAM3%2F%2FSIw%3D","updated":"2013-01-30 11:12:10.000000000","message":"Done","commit_id":"5ba1a066251c2db0c2ca0f4e39c9740d349f4e57"}],"quantum/tests/unit/test_api_v2.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":769,"context_line":"            self.assertEqual(expected, mynotifier.call_args_list)"},{"line_number":770,"context_line":"        self.assertEqual(res.status_int, expected_code)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def test_network_create_notifer(self):"},{"line_number":773,"context_line":"        self._resource_op_notifier(\u0027create\u0027, \u0027network\u0027)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_network_delete_notifer(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSg%3D","side":"PARENT","line":772,"updated":"2013-01-18 04:35:50.000000000","message":"Why is this test being deleted?  The bug is that method in 781 is named wrong.","commit_id":"c13eff55be51ea34f2f6ac96dfd620a728575865"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":769,"context_line":"            self.assertEqual(expected, mynotifier.call_args_list)"},{"line_number":770,"context_line":"        self.assertEqual(res.status_int, expected_code)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def test_network_create_notifer(self):"},{"line_number":773,"context_line":"        self._resource_op_notifier(\u0027create\u0027, \u0027network\u0027)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_network_delete_notifer(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgHo%3D","side":"PARENT","line":772,"in_reply_to":"AAAAM3%2F%2FgSg%3D","updated":"2013-01-18 07:14:22.000000000","message":"change name. Done","commit_id":"c13eff55be51ea34f2f6ac96dfd620a728575865"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        )"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    def _test_list(self, req_tenant_id, real_tenant_id):"},{"line_number":724,"context_line":"        env \u003d {}"},{"line_number":725,"context_line":"        if req_tenant_id:"},{"line_number":726,"context_line":"            env \u003d {\u0027quantum.context\u0027: context.Context(\u0027\u0027, req_tenant_id)}"},{"line_number":727,"context_line":"        input_dict \u003d {\u0027id\u0027: _uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTI%3D","line":724,"updated":"2013-01-18 04:35:50.000000000","message":"if req_tenant_id:\n   env \u003d {\u0027quantum.context\u0027: context.Context(\u0027\u0027, req_tenant_id)}\nelse:\n   env \u003d {}","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        )"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    def _test_list(self, req_tenant_id, real_tenant_id):"},{"line_number":724,"context_line":"        env \u003d {}"},{"line_number":725,"context_line":"        if req_tenant_id:"},{"line_number":726,"context_line":"            env \u003d {\u0027quantum.context\u0027: context.Context(\u0027\u0027, req_tenant_id)}"},{"line_number":727,"context_line":"        input_dict \u003d {\u0027id\u0027: _uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIQ%3D","line":724,"in_reply_to":"AAAAM3%2F%2FgTI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        res \u003d self.api.get(_get_path(\u0027networks\u0027, fmt\u003d\"xml\"), extra_environ\u003denv)"},{"line_number":738,"context_line":"        data \u003d self.deserializer.deserialize(res.body)[\u0027body\u0027]"},{"line_number":739,"context_line":"        if \u0027xmlns\u0027 in data[\u0027networks\u0027]:"},{"line_number":740,"context_line":"            del data[\u0027networks\u0027][\u0027xmlns\u0027]"},{"line_number":741,"context_line":"        self.assertTrue(\u0027networks\u0027 in data)"},{"line_number":742,"context_line":"        if not req_tenant_id or req_tenant_id \u003d\u003d real_tenant_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTE%3D","line":739,"updated":"2013-01-18 04:35:50.000000000","message":"replace 739-740\n\ndata[\u0027networks\u0027].pop(\u0027xmlns\u0027, None)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        res \u003d self.api.get(_get_path(\u0027networks\u0027, fmt\u003d\"xml\"), extra_environ\u003denv)"},{"line_number":738,"context_line":"        data \u003d self.deserializer.deserialize(res.body)[\u0027body\u0027]"},{"line_number":739,"context_line":"        if \u0027xmlns\u0027 in data[\u0027networks\u0027]:"},{"line_number":740,"context_line":"            del data[\u0027networks\u0027][\u0027xmlns\u0027]"},{"line_number":741,"context_line":"        self.assertTrue(\u0027networks\u0027 in data)"},{"line_number":742,"context_line":"        if not req_tenant_id or req_tenant_id \u003d\u003d real_tenant_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgIA%3D","line":739,"in_reply_to":"AAAAM3%2F%2FgTE%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        data \u003d self.deserializer.deserialize(res.body)[\u0027body\u0027]"},{"line_number":739,"context_line":"        if \u0027xmlns\u0027 in data[\u0027networks\u0027]:"},{"line_number":740,"context_line":"            del data[\u0027networks\u0027][\u0027xmlns\u0027]"},{"line_number":741,"context_line":"        self.assertTrue(\u0027networks\u0027 in data)"},{"line_number":742,"context_line":"        if not req_tenant_id or req_tenant_id \u003d\u003d real_tenant_id:"},{"line_number":743,"context_line":"            # expect full list returned"},{"line_number":744,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgTA%3D","line":741,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027networks\u0027, data)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        data \u003d self.deserializer.deserialize(res.body)[\u0027body\u0027]"},{"line_number":739,"context_line":"        if \u0027xmlns\u0027 in data[\u0027networks\u0027]:"},{"line_number":740,"context_line":"            del data[\u0027networks\u0027][\u0027xmlns\u0027]"},{"line_number":741,"context_line":"        self.assertTrue(\u0027networks\u0027 in data)"},{"line_number":742,"context_line":"        if not req_tenant_id or req_tenant_id \u003d\u003d real_tenant_id:"},{"line_number":743,"context_line":"            # expect full list returned"},{"line_number":744,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgH8%3D","line":741,"in_reply_to":"AAAAM3%2F%2FgTA%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            # expect full list returned"},{"line_number":744,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 1)"},{"line_number":745,"context_line":"            output_dict \u003d data[\u0027networks\u0027][0]"},{"line_number":746,"context_line":"            input_dict[\u0027shared\u0027] \u003d False"},{"line_number":747,"context_line":"            self.assertEqual(len(input_dict), len(output_dict))"},{"line_number":748,"context_line":"            for k, v in input_dict.iteritems():"},{"line_number":749,"context_line":"                self.assertEqual(v, output_dict[k])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgS8%3D","line":746,"updated":"2013-01-18 04:35:50.000000000","message":"Replace 747-749\n\nself.assertEqual(input_dict, output_dict)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            # expect full list returned"},{"line_number":744,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 1)"},{"line_number":745,"context_line":"            output_dict \u003d data[\u0027networks\u0027][0]"},{"line_number":746,"context_line":"            input_dict[\u0027shared\u0027] \u003d False"},{"line_number":747,"context_line":"            self.assertEqual(len(input_dict), len(output_dict))"},{"line_number":748,"context_line":"            for k, v in input_dict.iteritems():"},{"line_number":749,"context_line":"                self.assertEqual(v, output_dict[k])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgH4%3D","line":746,"in_reply_to":"AAAAM3%2F%2FgS8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":748,"context_line":"            for k, v in input_dict.iteritems():"},{"line_number":749,"context_line":"                self.assertEqual(v, output_dict[k])"},{"line_number":750,"context_line":"        else:"},{"line_number":751,"context_line":"            # expect no results"},{"line_number":752,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 0)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    def test_list_noauth(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgS4%3D","line":751,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertFalse(data[\u0027networks\u0027])","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":748,"context_line":"            for k, v in input_dict.iteritems():"},{"line_number":749,"context_line":"                self.assertEqual(v, output_dict[k])"},{"line_number":750,"context_line":"        else:"},{"line_number":751,"context_line":"            # expect no results"},{"line_number":752,"context_line":"            self.assertEqual(len(data[\u0027networks\u0027]), 0)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    def test_list_noauth(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgH0%3D","line":751,"in_reply_to":"AAAAM3%2F%2FgS4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        net \u003d data[\u0027network\u0027]"},{"line_number":816,"context_line":"        self.assertEqual(net[\u0027id\u0027], net_id)"},{"line_number":817,"context_line":"        self.serializer.serialize(data)"},{"line_number":818,"context_line":"        self.assertEqual(net[\u0027admin_state_up\u0027], True)"},{"line_number":819,"context_line":"        self.assertEqual(net[\u0027status\u0027], \"ACTIVE\")"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_create_no_keystone_env(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSs%3D","line":818,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertTrue(net[\u0027admin_state_up\u0027])","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        net \u003d data[\u0027network\u0027]"},{"line_number":816,"context_line":"        self.assertEqual(net[\u0027id\u0027], net_id)"},{"line_number":817,"context_line":"        self.serializer.serialize(data)"},{"line_number":818,"context_line":"        self.assertEqual(net[\u0027admin_state_up\u0027], True)"},{"line_number":819,"context_line":"        self.assertEqual(net[\u0027status\u0027], \"ACTIVE\")"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_create_no_keystone_env(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgHs%3D","line":818,"in_reply_to":"AAAAM3%2F%2FgSs%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"17a1ad8fb9c556fbca23a43ebac3b55642fc5147","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"# Note: since all resources use the same controller and validation"},{"line_number":711,"context_line":"# logic, we actually get really good coverage from testing just networks."},{"line_number":712,"context_line":"class XMLV2TestCase(APIv2TestBase):"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def setUp(self):"},{"line_number":715,"context_line":"        super(XMLV2TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FUIc%3D","line":712,"updated":"2013-01-29 11:05:04.000000000","message":"Can we share the code XMLV2TestCase and JSONV2TestCase? It looks like just use different deserializer and serializer.","commit_id":"2be9594abffcf194ffd8bb0b965c7d018028bbac"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"# Note: since all resources use the same controller and validation"},{"line_number":711,"context_line":"# logic, we actually get really good coverage from testing just networks."},{"line_number":712,"context_line":"class XMLV2TestCase(APIv2TestBase):"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def setUp(self):"},{"line_number":715,"context_line":"        super(XMLV2TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FUFM%3D","line":712,"in_reply_to":"AAAAM3%2F%2FUIc%3D","updated":"2013-01-29 12:38:11.000000000","message":"Done","commit_id":"2be9594abffcf194ffd8bb0b965c7d018028bbac"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class QuantumDbPluginV2TestCase(unittest2.TestCase):"},{"line_number":64,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":65,"context_line":"        super(QuantumDbPluginV2TestCase, self).__init__("},{"line_number":66,"context_line":"            methodName\u003dmethodName)"},{"line_number":67,"context_line":"        self.fmt \u003d \u0027json\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSU%3D","line":64,"updated":"2013-01-18 04:35:50.000000000","message":"As before this can be done with a class var.\n\n    fmt \u003d \u0027json\u0027","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class QuantumDbPluginV2TestCase(unittest2.TestCase):"},{"line_number":64,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":65,"context_line":"        super(QuantumDbPluginV2TestCase, self).__init__("},{"line_number":66,"context_line":"            methodName\u003dmethodName)"},{"line_number":67,"context_line":"        self.fmt \u003d \u0027json\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgHk%3D","line":64,"in_reply_to":"AAAAM3%2F%2FgSU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                              method,"},{"line_number":161,"context_line":"                              query_string\u003dparams)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def new_create_request(self, resource, data, fmt\u003dNone):"},{"line_number":164,"context_line":"        return self._req(\u0027POST\u0027, resource, data, fmt)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def new_list_request(self, resource, fmt\u003dNone, params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSQ%3D","line":163,"updated":"2013-01-18 04:35:50.000000000","message":"Why do we need to change the default here?","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                              method,"},{"line_number":161,"context_line":"                              query_string\u003dparams)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def new_create_request(self, resource, data, fmt\u003dNone):"},{"line_number":164,"context_line":"        return self._req(\u0027POST\u0027, resource, data, fmt)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def new_list_request(self, resource, fmt\u003dNone, params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgHg%3D","line":163,"in_reply_to":"AAAAM3%2F%2FgSQ%3D","updated":"2013-01-18 07:14:22.000000000","message":"because they will set when called anyway. I have to change the fmt to self.fmt if the parameter is not set when called.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027, \u0027shared\u0027) +"},{"line_number":229,"context_line":"                    (arg_list or ())):"},{"line_number":230,"context_line":"            # Arg must be present and not empty"},{"line_number":231,"context_line":"            if arg in kwargs:"},{"line_number":232,"context_line":"                data[\u0027network\u0027][arg] \u003d kwargs[arg]"},{"line_number":233,"context_line":"        network_req \u003d self.new_create_request(\u0027networks\u0027, data, fmt)"},{"line_number":234,"context_line":"        if (kwargs.get(\u0027set_context\u0027) and \u0027tenant_id\u0027 in kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSM%3D","line":231,"updated":"2013-01-18 04:35:50.000000000","message":"The comment also said that the value must not be empty.  Why drop the \u0027and\u0027 part?","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        for arg in ((\u0027admin_state_up\u0027, \u0027tenant_id\u0027, \u0027shared\u0027) +"},{"line_number":229,"context_line":"                    (arg_list or ())):"},{"line_number":230,"context_line":"            # Arg must be present and not empty"},{"line_number":231,"context_line":"            if arg in kwargs:"},{"line_number":232,"context_line":"                data[\u0027network\u0027][arg] \u003d kwargs[arg]"},{"line_number":233,"context_line":"        network_req \u003d self.new_create_request(\u0027networks\u0027, data, fmt)"},{"line_number":234,"context_line":"        if (kwargs.get(\u0027set_context\u0027) and \u0027tenant_id\u0027 in kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgG8%3D","line":231,"in_reply_to":"AAAAM3%2F%2FgSM%3D","updated":"2013-01-18 07:14:22.000000000","message":"In fact, we should allow none to be passed in. API should be able to deal with it.\nbut anyway, we have so such cases yet, I will move it back.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def _list(self, resource, fmt\u003dNone, quantum_context\u003dNone,"},{"line_number":413,"context_line":"              query_params\u003dNone):"},{"line_number":414,"context_line":"        if not fmt:"},{"line_number":415,"context_line":"            fmt \u003d self.fmt"},{"line_number":416,"context_line":"        req \u003d self.new_list_request(resource, fmt, query_params)"},{"line_number":417,"context_line":"        if quantum_context:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSE%3D","line":414,"updated":"2013-01-18 04:35:50.000000000","message":"unnecessary... see below","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def _list(self, resource, fmt\u003dNone, quantum_context\u003dNone,"},{"line_number":413,"context_line":"              query_params\u003dNone):"},{"line_number":414,"context_line":"        if not fmt:"},{"line_number":415,"context_line":"            fmt \u003d self.fmt"},{"line_number":416,"context_line":"        req \u003d self.new_list_request(resource, fmt, query_params)"},{"line_number":417,"context_line":"        if quantum_context:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGc%3D","line":414,"in_reply_to":"AAAAM3%2F%2FgSE%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            req.environ[\u0027quantum.context\u0027] \u003d quantum_context"},{"line_number":419,"context_line":"        res \u003d req.get_response(self._api_for_resource(resource))"},{"line_number":420,"context_line":"        self.assertEqual(res.status_int, webob.exc.HTTPOk.code)"},{"line_number":421,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _do_side_effect(self, patched_plugin, orig, *args, **kwargs):"},{"line_number":424,"context_line":"        \"\"\" Invoked by test cases for injecting failures in plugin \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSI%3D","line":421,"updated":"2013-01-18 04:35:50.000000000","message":"return self.deserialize(fmt or self.fmt, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            req.environ[\u0027quantum.context\u0027] \u003d quantum_context"},{"line_number":419,"context_line":"        res \u003d req.get_response(self._api_for_resource(resource))"},{"line_number":420,"context_line":"        self.assertEqual(res.status_int, webob.exc.HTTPOk.code)"},{"line_number":421,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _do_side_effect(self, patched_plugin, orig, *args, **kwargs):"},{"line_number":424,"context_line":"        \"\"\" Invoked by test cases for injecting failures in plugin \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGg%3D","line":421,"in_reply_to":"AAAAM3%2F%2FgSI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                **kwargs):"},{"line_number":460,"context_line":"        if not fmt:"},{"line_number":461,"context_line":"            fmt \u003d self.fmt"},{"line_number":462,"context_line":"        network \u003d self._make_network(fmt, name, admin_status_up, **kwargs)"},{"line_number":463,"context_line":"        try:"},{"line_number":464,"context_line":"            yield network"},{"line_number":465,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgSA%3D","line":462,"updated":"2013-01-18 04:35:50.000000000","message":"network \u003d self._make_network(fmt or self.fmt, name, admin_status_up, **kwargs)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                **kwargs):"},{"line_number":460,"context_line":"        if not fmt:"},{"line_number":461,"context_line":"            fmt \u003d self.fmt"},{"line_number":462,"context_line":"        network \u003d self._make_network(fmt, name, admin_status_up, **kwargs)"},{"line_number":463,"context_line":"        try:"},{"line_number":464,"context_line":"            yield network"},{"line_number":465,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGY%3D","line":462,"in_reply_to":"AAAAM3%2F%2FgSA%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":487,"context_line":"              else dummy_context_func()) as network_to_use:"},{"line_number":488,"context_line":"            if network:"},{"line_number":489,"context_line":"                network_to_use \u003d network"},{"line_number":490,"context_line":"            subnet \u003d self._make_subnet(fmt,"},{"line_number":491,"context_line":"                                       network_to_use,"},{"line_number":492,"context_line":"                                       gateway_ip,"},{"line_number":493,"context_line":"                                       cidr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgR8%3D","line":490,"updated":"2013-01-18 04:35:50.000000000","message":"subnet \u003d self._make_subnet(fmt or self.fmt,","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":487,"context_line":"              else dummy_context_func()) as network_to_use:"},{"line_number":488,"context_line":"            if network:"},{"line_number":489,"context_line":"                network_to_use \u003d network"},{"line_number":490,"context_line":"            subnet \u003d self._make_subnet(fmt,"},{"line_number":491,"context_line":"                                       network_to_use,"},{"line_number":492,"context_line":"                                       gateway_ip,"},{"line_number":493,"context_line":"                                       cidr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGU%3D","line":490,"in_reply_to":"AAAAM3%2F%2FgR8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            if subnet:"},{"line_number":513,"context_line":"                subnet_to_use \u003d subnet"},{"line_number":514,"context_line":"            net_id \u003d subnet_to_use[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":515,"context_line":"            port \u003d self._make_port(fmt, net_id, **kwargs)"},{"line_number":516,"context_line":"            try:"},{"line_number":517,"context_line":"                yield port"},{"line_number":518,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgR4%3D","line":515,"updated":"2013-01-18 04:35:50.000000000","message":"port \u003d self._make_port(fmt or self.fmt, net_id, **kwargs)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            if subnet:"},{"line_number":513,"context_line":"                subnet_to_use \u003d subnet"},{"line_number":514,"context_line":"            net_id \u003d subnet_to_use[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":515,"context_line":"            port \u003d self._make_port(fmt, net_id, **kwargs)"},{"line_number":516,"context_line":"            try:"},{"line_number":517,"context_line":"                yield port"},{"line_number":518,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGQ%3D","line":515,"in_reply_to":"AAAAM3%2F%2FgR4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        fmt \u003d self.fmt"},{"line_number":896,"context_line":"        with self.subnet(cidr\u003d\u002710.0.0.0/32\u0027) as subnet:"},{"line_number":897,"context_line":"            id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":898,"context_line":"            res \u003d self._create_port(fmt, id)"},{"line_number":899,"context_line":"            data \u003d self.deserialize(fmt, res)"},{"line_number":900,"context_line":"            msg \u003d str(q_exc.IpAddressGenerationFailure(net_id\u003did))"},{"line_number":901,"context_line":"            self.assertEqual(data[\u0027QuantumError\u0027], msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRw%3D","line":898,"updated":"2013-01-18 04:35:50.000000000","message":"res \u003d self._create_port(self.fmt, id)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        fmt \u003d self.fmt"},{"line_number":896,"context_line":"        with self.subnet(cidr\u003d\u002710.0.0.0/32\u0027) as subnet:"},{"line_number":897,"context_line":"            id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":898,"context_line":"            res \u003d self._create_port(fmt, id)"},{"line_number":899,"context_line":"            data \u003d self.deserialize(fmt, res)"},{"line_number":900,"context_line":"            msg \u003d str(q_exc.IpAddressGenerationFailure(net_id\u003did))"},{"line_number":901,"context_line":"            self.assertEqual(data[\u0027QuantumError\u0027], msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGM%3D","line":898,"in_reply_to":"AAAAM3%2F%2FgRw%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":896,"context_line":"        with self.subnet(cidr\u003d\u002710.0.0.0/32\u0027) as subnet:"},{"line_number":897,"context_line":"            id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":898,"context_line":"            res \u003d self._create_port(fmt, id)"},{"line_number":899,"context_line":"            data \u003d self.deserialize(fmt, res)"},{"line_number":900,"context_line":"            msg \u003d str(q_exc.IpAddressGenerationFailure(net_id\u003did))"},{"line_number":901,"context_line":"            self.assertEqual(data[\u0027QuantumError\u0027], msg)"},{"line_number":902,"context_line":"            self.assertEqual(res.status_int, 409)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRk%3D","line":899,"updated":"2013-01-18 04:35:50.000000000","message":"data \u003d self.deserialize(self.fmt, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":896,"context_line":"        with self.subnet(cidr\u003d\u002710.0.0.0/32\u0027) as subnet:"},{"line_number":897,"context_line":"            id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"},{"line_number":898,"context_line":"            res \u003d self._create_port(fmt, id)"},{"line_number":899,"context_line":"            data \u003d self.deserialize(fmt, res)"},{"line_number":900,"context_line":"            msg \u003d str(q_exc.IpAddressGenerationFailure(net_id\u003did))"},{"line_number":901,"context_line":"            self.assertEqual(data[\u0027QuantumError\u0027], msg)"},{"line_number":902,"context_line":"            self.assertEqual(res.status_int, 409)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGI%3D","line":899,"in_reply_to":"AAAAM3%2F%2FgRk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            self.assertTrue(mac.startswith(base_mac))"},{"line_number":975,"context_line":"            kwargs \u003d {\"mac_address\": mac}"},{"line_number":976,"context_line":"            net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":977,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":978,"context_line":"            port2 \u003d self.deserialize(fmt, res)"},{"line_number":979,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRg%3D","line":977,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            self.assertTrue(mac.startswith(base_mac))"},{"line_number":975,"context_line":"            kwargs \u003d {\"mac_address\": mac}"},{"line_number":976,"context_line":"            net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":977,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":978,"context_line":"            port2 \u003d self.deserialize(fmt, res)"},{"line_number":979,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFc%3D","line":977,"in_reply_to":"AAAAM3%2F%2FgRg%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            kwargs \u003d {\"mac_address\": mac}"},{"line_number":976,"context_line":"            net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":977,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":978,"context_line":"            port2 \u003d self.deserialize(fmt, res)"},{"line_number":979,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    def test_mac_generation(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRc%3D","line":978,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            kwargs \u003d {\"mac_address\": mac}"},{"line_number":976,"context_line":"            net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":977,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":978,"context_line":"            port2 \u003d self.deserialize(fmt, res)"},{"line_number":979,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    def test_mac_generation(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFY%3D","line":978,"in_reply_to":"AAAAM3%2F%2FgRc%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        fmt \u003d self.fmt"},{"line_number":1013,"context_line":"        with mock.patch.object(quantum.db.db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":1014,"context_line":"                               \u0027_generate_mac\u0027, new\u003dfake_gen_mac):"},{"line_number":1015,"context_line":"            res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net1\u0027,"},{"line_number":1016,"context_line":"                                       admin_status_up\u003dTrue)"},{"line_number":1017,"context_line":"            network \u003d self.deserialize(fmt, res)"},{"line_number":1018,"context_line":"            net_id \u003d network[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRY%3D","line":1015,"updated":"2013-01-18 04:35:50.000000000","message":"fmt \u003d self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        fmt \u003d self.fmt"},{"line_number":1013,"context_line":"        with mock.patch.object(quantum.db.db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":1014,"context_line":"                               \u0027_generate_mac\u0027, new\u003dfake_gen_mac):"},{"line_number":1015,"context_line":"            res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net1\u0027,"},{"line_number":1016,"context_line":"                                       admin_status_up\u003dTrue)"},{"line_number":1017,"context_line":"            network \u003d self.deserialize(fmt, res)"},{"line_number":1018,"context_line":"            net_id \u003d network[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFU%3D","line":1015,"in_reply_to":"AAAAM3%2F%2FgRY%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            network_req \u003d self.new_create_request(\u0027networks\u0027, data)"},{"line_number":1852,"context_line":"            req \u003d network_req.get_response(self.api)"},{"line_number":1853,"context_line":"            self.assertEqual(req.status_int, v[2])"},{"line_number":1854,"context_line":"            if v[2] \u003d\u003d 201:"},{"line_number":1855,"context_line":"                res \u003d self.deserialize(fmt, req)"},{"line_number":1856,"context_line":"                self.assertEqual(res[\u0027network\u0027][\u0027admin_state_up\u0027], v[1])"},{"line_number":1857,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRQ%3D","line":1854,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            network_req \u003d self.new_create_request(\u0027networks\u0027, data)"},{"line_number":1852,"context_line":"            req \u003d network_req.get_response(self.api)"},{"line_number":1853,"context_line":"            self.assertEqual(req.status_int, v[2])"},{"line_number":1854,"context_line":"            if v[2] \u003d\u003d 201:"},{"line_number":1855,"context_line":"                res \u003d self.deserialize(fmt, req)"},{"line_number":1856,"context_line":"                self.assertEqual(res[\u0027network\u0027][\u0027admin_state_up\u0027], v[1])"},{"line_number":1857,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFM%3D","line":1854,"in_reply_to":"AAAAM3%2F%2FgRQ%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        # Create new network"},{"line_number":2042,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2043,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2044,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2045,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2046,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2047,"context_line":"        req \u003d self.new_delete_request(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRM%3D","line":2044,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        # Create new network"},{"line_number":2042,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2043,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2044,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2045,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2046,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2047,"context_line":"        req \u003d self.new_delete_request(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFI%3D","line":2044,"in_reply_to":"AAAAM3%2F%2FgRM%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        cidr \u003d \u002710.0.0.0/24\u0027"},{"line_number":2054,"context_line":"        fmt \u003d self.fmt"},{"line_number":2055,"context_line":"        # Create new network"},{"line_number":2056,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2057,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2058,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2059,"context_line":"        network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRI%3D","line":2056,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        cidr \u003d \u002710.0.0.0/24\u0027"},{"line_number":2054,"context_line":"        fmt \u003d self.fmt"},{"line_number":2055,"context_line":"        # Create new network"},{"line_number":2056,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2057,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2058,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2059,"context_line":"        network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFE%3D","line":2056,"in_reply_to":"AAAAM3%2F%2FgRI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        # Create new network"},{"line_number":2056,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2057,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2058,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2059,"context_line":"        network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":2060,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2061,"context_line":"                                   cidr, ip_version\u003d4)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRE%3D","line":2058,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        # Create new network"},{"line_number":2056,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2057,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2058,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2059,"context_line":"        network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":2060,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2061,"context_line":"                                   cidr, ip_version\u003d4)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFA%3D","line":2058,"in_reply_to":"AAAAM3%2F%2FgRE%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"        # Create new network"},{"line_number":2085,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2086,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2087,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2088,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2089,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2090,"context_line":"        req \u003d self.new_delete_request(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgRA%3D","line":2087,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"        # Create new network"},{"line_number":2085,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2086,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2087,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2088,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2089,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2090,"context_line":"        req \u003d self.new_delete_request(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgE8%3D","line":2087,"in_reply_to":"AAAAM3%2F%2FgRA%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2085,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2086,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2087,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2088,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2089,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2090,"context_line":"        req \u003d self.new_delete_request(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":2091,"context_line":"        res \u003d req.get_response(self.api)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQ8%3D","line":2088,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2085,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2086,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2087,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2088,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2089,"context_line":"                                   cidr, ip_version\u003d4)"},{"line_number":2090,"context_line":"        req \u003d self.new_delete_request(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":2091,"context_line":"        res \u003d req.get_response(self.api)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgE4%3D","line":2088,"in_reply_to":"AAAAM3%2F%2FgQ8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2307,"context_line":"            # Check fixed IP not in allocation range"},{"line_number":2308,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":2309,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.10\u0027}]}"},{"line_number":2310,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":2311,"context_line":"            self.assertEqual(res.status_int, 201)"},{"line_number":2312,"context_line":"            port \u003d self.deserialize(self.fmt, res)"},{"line_number":2313,"context_line":"            port_id \u003d port[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQ4%3D","line":2310,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2307,"context_line":"            # Check fixed IP not in allocation range"},{"line_number":2308,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":2309,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.10\u0027}]}"},{"line_number":2310,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":2311,"context_line":"            self.assertEqual(res.status_int, 201)"},{"line_number":2312,"context_line":"            port \u003d self.deserialize(self.fmt, res)"},{"line_number":2313,"context_line":"            port_id \u003d port[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGE%3D","line":2310,"in_reply_to":"AAAAM3%2F%2FgQ4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"            # Check when fixed IP is gateway"},{"line_number":2318,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":2319,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.1\u0027}]}"},{"line_number":2320,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":2321,"context_line":"            self.assertEqual(res.status_int, 201)"},{"line_number":2322,"context_line":"            port \u003d self.deserialize(self.fmt, res)"},{"line_number":2323,"context_line":"            port_id \u003d port[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQ0%3D","line":2320,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"            # Check when fixed IP is gateway"},{"line_number":2318,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":2319,"context_line":"                                     \u0027ip_address\u0027: \u002710.0.0.1\u0027}]}"},{"line_number":2320,"context_line":"            res \u003d self._create_port(fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":2321,"context_line":"            self.assertEqual(res.status_int, 201)"},{"line_number":2322,"context_line":"            port \u003d self.deserialize(self.fmt, res)"},{"line_number":2323,"context_line":"            port_id \u003d port[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgGA%3D","line":2320,"in_reply_to":"AAAAM3%2F%2FgQ0%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"        # Create new network"},{"line_number":2852,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2853,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2854,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2855,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2856,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2857,"context_line":"                                   dns_nameservers\u003ddns_nameservers)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQw%3D","line":2854,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2852,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2853,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2854,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2855,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2856,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2857,"context_line":"                                   dns_nameservers\u003ddns_nameservers)"},{"line_number":2858,"context_line":"        req \u003d self.new_delete_request(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQs%3D","line":2855,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2866,"context_line":"        host_routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"},{"line_number":2867,"context_line":"                        \u0027nexthop\u0027: \u00271.2.3.4\u0027}]"},{"line_number":2868,"context_line":"        # Create new network"},{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQo%3D","line":2869,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2866,"context_line":"        host_routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"},{"line_number":2867,"context_line":"                        \u0027nexthop\u0027: \u00271.2.3.4\u0027}]"},{"line_number":2868,"context_line":"        # Create new network"},{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgF0%3D","line":2869,"in_reply_to":"AAAAM3%2F%2FgQo%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2868,"context_line":"        # Create new network"},{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2873,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2874,"context_line":"                                   host_routes\u003dhost_routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQk%3D","line":2871,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2868,"context_line":"        # Create new network"},{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2873,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2874,"context_line":"                                   host_routes\u003dhost_routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFw%3D","line":2871,"in_reply_to":"AAAAM3%2F%2FgQk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2873,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2874,"context_line":"                                   host_routes\u003dhost_routes)"},{"line_number":2875,"context_line":"        req \u003d self.new_delete_request(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQg%3D","line":2872,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2869,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2870,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2871,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2872,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2873,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2874,"context_line":"                                   host_routes\u003dhost_routes)"},{"line_number":2875,"context_line":"        req \u003d self.new_delete_request(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFs%3D","line":2872,"in_reply_to":"AAAAM3%2F%2FgQg%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2884,"context_line":"        host_routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"},{"line_number":2885,"context_line":"                        \u0027nexthop\u0027: \u00271.2.3.4\u0027}]"},{"line_number":2886,"context_line":"        # Create new network"},{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQc%3D","line":2887,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2884,"context_line":"        host_routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"},{"line_number":2885,"context_line":"                        \u0027nexthop\u0027: \u00271.2.3.4\u0027}]"},{"line_number":2886,"context_line":"        # Create new network"},{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFo%3D","line":2887,"in_reply_to":"AAAAM3%2F%2FgQc%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2886,"context_line":"        # Create new network"},{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2891,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2892,"context_line":"                                   dns_nameservers\u003ddns_nameservers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQY%3D","line":2889,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2886,"context_line":"        # Create new network"},{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2891,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2892,"context_line":"                                   dns_nameservers\u003ddns_nameservers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFk%3D","line":2889,"in_reply_to":"AAAAM3%2F%2FgQY%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2891,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2892,"context_line":"                                   dns_nameservers\u003ddns_nameservers,"},{"line_number":2893,"context_line":"                                   host_routes\u003dhost_routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQU%3D","line":2890,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":2887,"context_line":"        res \u003d self._create_network(fmt\u003dfmt, name\u003d\u0027net\u0027,"},{"line_number":2888,"context_line":"                                   admin_status_up\u003dTrue)"},{"line_number":2889,"context_line":"        network \u003d self.deserialize(fmt, res)"},{"line_number":2890,"context_line":"        subnet \u003d self._make_subnet(fmt, network, gateway_ip,"},{"line_number":2891,"context_line":"                                   cidr, ip_version\u003d4,"},{"line_number":2892,"context_line":"                                   dns_nameservers\u003ddns_nameservers,"},{"line_number":2893,"context_line":"                                   host_routes\u003dhost_routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgFg%3D","line":2890,"in_reply_to":"AAAAM3%2F%2FgQU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_db_plugin_xml.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack, LLC."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQM%3D","line":1,"updated":"2013-01-18 04:35:50.000000000","message":"This should be in the same file as the JSON cases.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack, LLC."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgE0%3D","line":1,"in_reply_to":"AAAAM3%2F%2FgQM%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.tests.unit import test_db_plugin"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestBasicGetXML(test_db_plugin.TestBasicGet):"},{"line_number":22,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":23,"context_line":"        super(TestBasicGetXML, self).__init__("},{"line_number":24,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQE%3D","line":21,"updated":"2013-01-18 04:35:50.000000000","message":"Can simplify this- please use a class variable.\n    fmt \u003d \u0027xml\u0027","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.tests.unit import test_db_plugin"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestBasicGetXML(test_db_plugin.TestBasicGet):"},{"line_number":22,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":23,"context_line":"        super(TestBasicGetXML, self).__init__("},{"line_number":24,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEw%3D","line":21,"in_reply_to":"AAAAM3%2F%2FgQE%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestNetworksV2XML(test_db_plugin.TestNetworksV2):"},{"line_number":29,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":30,"context_line":"        super(TestNetworksV2XML, self).__init__("},{"line_number":31,"context_line":"            methodName\u003dmethodName)"},{"line_number":32,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgQA%3D","line":29,"updated":"2013-01-18 04:35:50.000000000","message":"same as above","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class TestNetworksV2XML(test_db_plugin.TestNetworksV2):"},{"line_number":29,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":30,"context_line":"        super(TestNetworksV2XML, self).__init__("},{"line_number":31,"context_line":"            methodName\u003dmethodName)"},{"line_number":32,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEs%3D","line":29,"in_reply_to":"AAAAM3%2F%2FgQA%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class TestPortsV2XML(test_db_plugin.TestPortsV2):"},{"line_number":36,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":37,"context_line":"        super(TestPortsV2XML, self).__init__("},{"line_number":38,"context_line":"            methodName\u003dmethodName)"},{"line_number":39,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgP8%3D","line":36,"updated":"2013-01-18 04:35:50.000000000","message":"same","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class TestPortsV2XML(test_db_plugin.TestPortsV2):"},{"line_number":36,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":37,"context_line":"        super(TestPortsV2XML, self).__init__("},{"line_number":38,"context_line":"            methodName\u003dmethodName)"},{"line_number":39,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEo%3D","line":36,"in_reply_to":"AAAAM3%2F%2FgP8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestSubnetsV2XML(test_db_plugin.TestSubnetsV2):"},{"line_number":43,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":44,"context_line":"        super(TestSubnetsV2XML, self).__init__("},{"line_number":45,"context_line":"            methodName\u003dmethodName)"},{"line_number":46,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgP4%3D","line":43,"updated":"2013-01-18 04:35:50.000000000","message":"same","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestSubnetsV2XML(test_db_plugin.TestSubnetsV2):"},{"line_number":43,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":44,"context_line":"        super(TestSubnetsV2XML, self).__init__("},{"line_number":45,"context_line":"            methodName\u003dmethodName)"},{"line_number":46,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEk%3D","line":43,"in_reply_to":"AAAAM3%2F%2FgP4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestV2HTTPResponseXML(test_db_plugin.TestV2HTTPResponse):"},{"line_number":50,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":51,"context_line":"        super(TestV2HTTPResponseXML, self).__init__("},{"line_number":52,"context_line":"            methodName\u003dmethodName)"},{"line_number":53,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgP0%3D","line":50,"updated":"2013-01-18 04:35:50.000000000","message":"same","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestV2HTTPResponseXML(test_db_plugin.TestV2HTTPResponse):"},{"line_number":50,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":51,"context_line":"        super(TestV2HTTPResponseXML, self).__init__("},{"line_number":52,"context_line":"            methodName\u003dmethodName)"},{"line_number":53,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEg%3D","line":50,"in_reply_to":"AAAAM3%2F%2FgP0%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":362,"context_line":"               fmt\u003dNone, tenant_id\u003d_uuid(), set_context\u003dFalse):"},{"line_number":363,"context_line":"        if not fmt:"},{"line_number":364,"context_line":"            fmt \u003d self.fmt"},{"line_number":365,"context_line":"        router \u003d self._make_router(fmt, tenant_id, name,"},{"line_number":366,"context_line":"                                   admin_status_up, set_context)"},{"line_number":367,"context_line":"        try:"},{"line_number":368,"context_line":"            yield router"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPk%3D","line":365,"updated":"2013-01-18 04:35:50.000000000","message":"router \u003d self._make_router(fmt or self.fmt, tenant_id, name,","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":362,"context_line":"               fmt\u003dNone, tenant_id\u003d_uuid(), set_context\u003dFalse):"},{"line_number":363,"context_line":"        if not fmt:"},{"line_number":364,"context_line":"            fmt \u003d self.fmt"},{"line_number":365,"context_line":"        router \u003d self._make_router(fmt, tenant_id, name,"},{"line_number":366,"context_line":"                                   admin_status_up, set_context)"},{"line_number":367,"context_line":"        try:"},{"line_number":368,"context_line":"            yield router"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEc%3D","line":365,"in_reply_to":"AAAAM3%2F%2FgPk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":871,"context_line":"    def test_router_delete_with_port_existed_returns_409(self):"},{"line_number":872,"context_line":"        fmt \u003d self.fmt"},{"line_number":873,"context_line":"        with self.subnet() as subnet:"},{"line_number":874,"context_line":"            res \u003d self._create_router(fmt, _uuid())"},{"line_number":875,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":876,"context_line":"            self._router_interface_action(\u0027add\u0027,"},{"line_number":877,"context_line":"                                          router[\u0027router\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPg%3D","line":874,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":871,"context_line":"    def test_router_delete_with_port_existed_returns_409(self):"},{"line_number":872,"context_line":"        fmt \u003d self.fmt"},{"line_number":873,"context_line":"        with self.subnet() as subnet:"},{"line_number":874,"context_line":"            res \u003d self._create_router(fmt, _uuid())"},{"line_number":875,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":876,"context_line":"            self._router_interface_action(\u0027add\u0027,"},{"line_number":877,"context_line":"                                          router[\u0027router\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgD4%3D","line":874,"in_reply_to":"AAAAM3%2F%2FgPg%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        fmt \u003d self.fmt"},{"line_number":873,"context_line":"        with self.subnet() as subnet:"},{"line_number":874,"context_line":"            res \u003d self._create_router(fmt, _uuid())"},{"line_number":875,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":876,"context_line":"            self._router_interface_action(\u0027add\u0027,"},{"line_number":877,"context_line":"                                          router[\u0027router\u0027][\u0027id\u0027],"},{"line_number":878,"context_line":"                                          subnet[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPc%3D","line":875,"updated":"2013-01-18 04:35:50.000000000","message":"self.fmt","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        fmt \u003d self.fmt"},{"line_number":873,"context_line":"        with self.subnet() as subnet:"},{"line_number":874,"context_line":"            res \u003d self._create_router(fmt, _uuid())"},{"line_number":875,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":876,"context_line":"            self._router_interface_action(\u0027add\u0027,"},{"line_number":877,"context_line":"                                          router[\u0027router\u0027][\u0027id\u0027],"},{"line_number":878,"context_line":"                                          subnet[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgD8%3D","line":875,"in_reply_to":"AAAAM3%2F%2FgPc%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                            \u0027add\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":1012,"context_line":"                            private_sub[\u0027subnet\u0027][\u0027id\u0027], None)"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"                        floatingip \u003d self._make_floatingip("},{"line_number":1015,"context_line":"                            fmt,"},{"line_number":1016,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1017,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPY%3D","line":1014,"updated":"2013-01-18 04:35:50.000000000","message":"fmt or self.fmt,","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                            \u0027add\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":1012,"context_line":"                            private_sub[\u0027subnet\u0027][\u0027id\u0027], None)"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"                        floatingip \u003d self._make_floatingip("},{"line_number":1015,"context_line":"                            fmt,"},{"line_number":1016,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1017,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEY%3D","line":1014,"in_reply_to":"AAAAM3%2F%2FgPY%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"                                                  private_sub[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":1045,"context_line":"                                                  None)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"                    floatingip \u003d self._make_floatingip("},{"line_number":1048,"context_line":"                        fmt,"},{"line_number":1049,"context_line":"                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1050,"context_line":"                        set_context\u003dset_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPU%3D","line":1047,"updated":"2013-01-18 04:35:50.000000000","message":"fmt or self.fmt,","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"                                                  private_sub[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":1045,"context_line":"                                                  None)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"                    floatingip \u003d self._make_floatingip("},{"line_number":1048,"context_line":"                        fmt,"},{"line_number":1049,"context_line":"                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1050,"context_line":"                        set_context\u003dset_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEU%3D","line":1047,"in_reply_to":"AAAAM3%2F%2FgPU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                        pl.side_effect \u003d q_exc.BadRequest("},{"line_number":1092,"context_line":"                            resource\u003d\u0027floatingip\u0027,"},{"line_number":1093,"context_line":"                            msg\u003d\u0027fake_error\u0027)"},{"line_number":1094,"context_line":"                        res \u003d self._create_floatingip("},{"line_number":1095,"context_line":"                            fmt,"},{"line_number":1096,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1097,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgPI%3D","line":1094,"updated":"2013-01-18 04:35:50.000000000","message":"fmt or self.fmt,","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                        pl.side_effect \u003d q_exc.BadRequest("},{"line_number":1092,"context_line":"                            resource\u003d\u0027floatingip\u0027,"},{"line_number":1093,"context_line":"                            msg\u003d\u0027fake_error\u0027)"},{"line_number":1094,"context_line":"                        res \u003d self._create_floatingip("},{"line_number":1095,"context_line":"                            fmt,"},{"line_number":1096,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":1097,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgEQ%3D","line":1094,"in_reply_to":"AAAAM3%2F%2FgPI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_l3_plugin_xml.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.tests.unit import test_l3_plugin"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class L3NatDBTestCaseXML(test_l3_plugin.L3NatDBTestCase):"},{"line_number":22,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":23,"context_line":"        super(L3NatDBTestCaseXML, self).__init__("},{"line_number":24,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgO8%3D","line":21,"updated":"2013-01-18 04:35:50.000000000","message":"same comment as before about class variable","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.tests.unit import test_l3_plugin"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class L3NatDBTestCaseXML(test_l3_plugin.L3NatDBTestCase):"},{"line_number":22,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":23,"context_line":"        super(L3NatDBTestCaseXML, self).__init__("},{"line_number":24,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgD0%3D","line":21,"in_reply_to":"AAAAM3%2F%2FgO8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_loadbalancer_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class LoadBalancerExtensionTestCase(unittest2.TestCase):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":56,"context_line":"        self.fmt \u003d \u0027json\u0027"},{"line_number":57,"context_line":"        super(LoadBalancerExtensionTestCase, self).__init__("},{"line_number":58,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOw%3D","line":55,"updated":"2013-01-18 04:35:50.000000000","message":"fmt \u003d \u0027json\u0027","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class LoadBalancerExtensionTestCase(unittest2.TestCase):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":56,"context_line":"        self.fmt \u003d \u0027json\u0027"},{"line_number":57,"context_line":"        super(LoadBalancerExtensionTestCase, self).__init__("},{"line_number":58,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgDk%3D","line":55,"in_reply_to":"AAAAM3%2F%2FgOw%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        ext_mgr \u003d LoadBalancerTestExtensionManager()"},{"line_number":89,"context_line":"        self.ext_mdw \u003d test_extensions.setup_extensions_middleware(ext_mgr)"},{"line_number":90,"context_line":"        self.api \u003d webtest.TestApp(self.ext_mdw)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def deserialize(self, response):"},{"line_number":93,"context_line":"        ctype \u003d \u0027application/%s\u0027 % self.fmt"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgM4%3D","line":90,"updated":"2013-01-18 04:35:50.000000000","message":"You have lots of boilerplate additions for serialization and deserialization.  Why not write a WebTest wrapper that handles that for you?","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        ext_mgr \u003d LoadBalancerTestExtensionManager()"},{"line_number":89,"context_line":"        self.ext_mdw \u003d test_extensions.setup_extensions_middleware(ext_mgr)"},{"line_number":90,"context_line":"        self.api \u003d webtest.TestApp(self.ext_mdw)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def deserialize(self, response):"},{"line_number":93,"context_line":"        ctype \u003d \u0027application/%s\u0027 % self.fmt"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgDc%3D","line":90,"in_reply_to":"AAAAM3%2F%2FgM4%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                                               vip\u003dupdate_data)"},{"line_number":169,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":170,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":171,"context_line":"        self.assertTrue(\u0027vip\u0027 in res)"},{"line_number":172,"context_line":"        self.assertEqual(res[\u0027vip\u0027], return_value)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_vip_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOU%3D","line":171,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027vip\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                                               vip\u003dupdate_data)"},{"line_number":169,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":170,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":171,"context_line":"        self.assertTrue(\u0027vip\u0027 in res)"},{"line_number":172,"context_line":"        self.assertEqual(res[\u0027vip\u0027], return_value)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_vip_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgDQ%3D","line":171,"in_reply_to":"AAAAM3%2F%2FgOU%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                            fields\u003dmock.ANY)"},{"line_number":189,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":190,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":191,"context_line":"        self.assertTrue(\u0027vip\u0027 in res)"},{"line_number":192,"context_line":"        self.assertEqual(res[\u0027vip\u0027], return_value)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_vip_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOM%3D","line":191,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027vip\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                            fields\u003dmock.ANY)"},{"line_number":189,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":190,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":191,"context_line":"        self.assertTrue(\u0027vip\u0027 in res)"},{"line_number":192,"context_line":"        self.assertEqual(res[\u0027vip\u0027], return_value)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_vip_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgDA%3D","line":191,"in_reply_to":"AAAAM3%2F%2FgOM%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                                pool\u003ddata)"},{"line_number":224,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":225,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":226,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":227,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_pool_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOI%3D","line":226,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027pool\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                                pool\u003ddata)"},{"line_number":224,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":225,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":226,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":227,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_pool_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgC4%3D","line":226,"in_reply_to":"AAAAM3%2F%2FgOI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                                                pool\u003dupdate_data)"},{"line_number":262,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":263,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":264,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":265,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_pool_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOE%3D","line":264,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027pool\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                                                pool\u003dupdate_data)"},{"line_number":262,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":263,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":264,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":265,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_pool_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgC0%3D","line":264,"in_reply_to":"AAAAM3%2F%2FgOE%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                                             fields\u003dmock.ANY)"},{"line_number":282,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":283,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":284,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":285,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_pool_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgOA%3D","line":284,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027pool\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                                             fields\u003dmock.ANY)"},{"line_number":282,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":283,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":284,"context_line":"        self.assertTrue(\u0027pool\u0027 in res)"},{"line_number":285,"context_line":"        self.assertEqual(res[\u0027pool\u0027], return_value)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_pool_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCw%3D","line":284,"in_reply_to":"AAAAM3%2F%2FgOA%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        instance.stats.assert_called_with(mock.ANY, pool_id)"},{"line_number":308,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":309,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":310,"context_line":"        self.assertTrue(\u0027stats\u0027 in res)"},{"line_number":311,"context_line":"        self.assertEqual(res[\u0027stats\u0027], stats[\u0027stats\u0027])"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def test_member_create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgN8%3D","line":310,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027stats\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        instance.stats.assert_called_with(mock.ANY, pool_id)"},{"line_number":308,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":309,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":310,"context_line":"        self.assertTrue(\u0027stats\u0027 in res)"},{"line_number":311,"context_line":"        self.assertEqual(res[\u0027stats\u0027], stats[\u0027stats\u0027])"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def test_member_create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCs%3D","line":310,"in_reply_to":"AAAAM3%2F%2FgN8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                                  member\u003ddata)"},{"line_number":331,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":332,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":333,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":334,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_member_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNw%3D","line":333,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027member\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                                  member\u003ddata)"},{"line_number":331,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":332,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":333,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":334,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def test_member_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCo%3D","line":333,"in_reply_to":"AAAAM3%2F%2FgNw%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  member\u003dupdate_data)"},{"line_number":369,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":370,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":371,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":372,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test_member_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNk%3D","line":371,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027member\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  member\u003dupdate_data)"},{"line_number":369,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":370,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":371,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":372,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test_member_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCk%3D","line":371,"in_reply_to":"AAAAM3%2F%2FgNk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                                               fields\u003dmock.ANY)"},{"line_number":389,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":390,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":391,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":392,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test_member_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNg%3D","line":391,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027member\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                                               fields\u003dmock.ANY)"},{"line_number":389,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":390,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":391,"context_line":"        self.assertTrue(\u0027member\u0027 in res)"},{"line_number":392,"context_line":"        self.assertEqual(res[\u0027member\u0027], return_value)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test_member_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCg%3D","line":391,"in_reply_to":"AAAAM3%2F%2FgNg%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                                          health_monitor\u003ddata)"},{"line_number":426,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":427,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":428,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":429,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def test_health_monitor_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNY%3D","line":428,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027health_monitor\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                                          health_monitor\u003ddata)"},{"line_number":426,"context_line":"        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":427,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":428,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":429,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def test_health_monitor_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCc%3D","line":428,"in_reply_to":"AAAAM3%2F%2FgNY%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            mock.ANY, health_monitor_id, health_monitor\u003dupdate_data)"},{"line_number":466,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":467,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":468,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":469,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    def test_health_monitor_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNQ%3D","line":468,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027health_monitor\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            mock.ANY, health_monitor_id, health_monitor\u003dupdate_data)"},{"line_number":466,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":467,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":468,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":469,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    def test_health_monitor_get(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCY%3D","line":468,"in_reply_to":"AAAAM3%2F%2FgNQ%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            mock.ANY, health_monitor_id, fields\u003dmock.ANY)"},{"line_number":488,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":489,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":490,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":491,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_health_monitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgNI%3D","line":490,"updated":"2013-01-18 04:35:50.000000000","message":"self.assertIn(\u0027health_monitor\u0027, res)","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            mock.ANY, health_monitor_id, fields\u003dmock.ANY)"},{"line_number":488,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":489,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":490,"context_line":"        self.assertTrue(\u0027health_monitor\u0027 in res)"},{"line_number":491,"context_line":"        self.assertEqual(res[\u0027health_monitor\u0027], return_value)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_health_monitor_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCU%3D","line":490,"in_reply_to":"AAAAM3%2F%2FgNI%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"class LoadBalancerExtensionTestCaseXML(LoadBalancerExtensionTestCase):"},{"line_number":536,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":537,"context_line":"        super(LoadBalancerExtensionTestCaseXML, self).__init__("},{"line_number":538,"context_line":"            methodName\u003dmethodName)"},{"line_number":539,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgM8%3D","line":536,"updated":"2013-01-18 04:35:50.000000000","message":"same as before.. a class variable would be preferred.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"class LoadBalancerExtensionTestCaseXML(LoadBalancerExtensionTestCase):"},{"line_number":536,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":537,"context_line":"        super(LoadBalancerExtensionTestCaseXML, self).__init__("},{"line_number":538,"context_line":"            methodName\u003dmethodName)"},{"line_number":539,"context_line":"        self.fmt \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCQ%3D","line":536,"in_reply_to":"AAAAM3%2F%2FgM8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_quota_per_tenant_ext.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class QuotaExtensionTestCase(unittest.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":29,"context_line":"        self.fmt \u003d \u0027json\u0027"},{"line_number":30,"context_line":"        super(QuotaExtensionTestCase, self).__init__(methodName\u003dmethodName)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgMo%3D","line":28,"updated":"2013-01-18 04:35:50.000000000","message":"Same as before.  A class var is preferred.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class QuotaExtensionTestCase(unittest.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":29,"context_line":"        self.fmt \u003d \u0027json\u0027"},{"line_number":30,"context_line":"        super(QuotaExtensionTestCase, self).__init__(methodName\u003dmethodName)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCA%3D","line":28,"in_reply_to":"AAAAM3%2F%2FgMo%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        l2network_db_v2.initialize()"},{"line_number":75,"context_line":"        app \u003d config.load_paste_app(\u0027extensions_test_app\u0027)"},{"line_number":76,"context_line":"        ext_middleware \u003d extensions.ExtensionMiddleware(app, ext_mgr\u003dext_mgr)"},{"line_number":77,"context_line":"        self.api \u003d webtest.TestApp(ext_middleware)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def deserialize(self, response):"},{"line_number":80,"context_line":"        ctype \u003d \u0027application/%s\u0027 % self.fmt"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgMk%3D","line":77,"updated":"2013-01-18 04:35:50.000000000","message":"WebTest wrapper?","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        l2network_db_v2.initialize()"},{"line_number":75,"context_line":"        app \u003d config.load_paste_app(\u0027extensions_test_app\u0027)"},{"line_number":76,"context_line":"        ext_middleware \u003d extensions.ExtensionMiddleware(app, ext_mgr\u003dext_mgr)"},{"line_number":77,"context_line":"        self.api \u003d webtest.TestApp(ext_middleware)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def deserialize(self, response):"},{"line_number":80,"context_line":"        ctype \u003d \u0027application/%s\u0027 % self.fmt"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCE%3D","line":77,"in_reply_to":"AAAAM3%2F%2FgMk%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class QuotaExtensionTestCaseXML(QuotaExtensionTestCase):"},{"line_number":180,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":181,"context_line":"        super(QuotaExtensionTestCaseXML, self).__init__("},{"line_number":182,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgMg%3D","line":179,"updated":"2013-01-18 04:35:50.000000000","message":"same as before.. class var preferred","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class QuotaExtensionTestCaseXML(QuotaExtensionTestCase):"},{"line_number":180,"context_line":"    def __init__(self, methodName\u003d\u0027runTest\u0027):"},{"line_number":181,"context_line":"        super(QuotaExtensionTestCaseXML, self).__init__("},{"line_number":182,"context_line":"            methodName\u003dmethodName)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgCI%3D","line":179,"in_reply_to":"AAAAM3%2F%2FgMg%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"}],"quantum/tests/unit/test_wsgi.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                 {\u0027test2\u0027: 2, \u0027test3\u0027: 3}]}"},{"line_number":33,"context_line":"           }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"### Above dict will be serialized into the XMl String as followings"},{"line_number":36,"context_line":"### We are using quantum:type to tell serializer and deserilizer some"},{"line_number":37,"context_line":"### meta data stuff"},{"line_number":38,"context_line":"NETWORK_XML \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeD0%3D","line":35,"updated":"2013-01-21 12:22:10.000000000","message":"XMl \u003d XML","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                 {\u0027test2\u0027: 2, \u0027test3\u0027: 3}]}"},{"line_number":33,"context_line":"           }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"### Above dict will be serialized into the XMl String as followings"},{"line_number":36,"context_line":"### We are using quantum:type to tell serializer and deserilizer some"},{"line_number":37,"context_line":"### meta data stuff"},{"line_number":38,"context_line":"NETWORK_XML \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fd4I%3D","line":35,"in_reply_to":"AAAAM3%2F%2FeD0%3D","updated":"2013-01-23 00:39:17.000000000","message":"Done","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"           }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"### Above dict will be serialized into the XMl String as followings"},{"line_number":36,"context_line":"### We are using quantum:type to tell serializer and deserilizer some"},{"line_number":37,"context_line":"### meta data stuff"},{"line_number":38,"context_line":"NETWORK_XML \u003d \"\"\""},{"line_number":39,"context_line":"\u003cnetwork xmlns\u003d\"http://openstack.org/quantum/api/v2.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeD4%3D","line":36,"updated":"2013-01-21 12:22:10.000000000","message":"deserilizer - deserializer","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":33,"context_line":"           }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"### Above dict will be serialized into the XMl String as followings"},{"line_number":36,"context_line":"### We are using quantum:type to tell serializer and deserilizer some"},{"line_number":37,"context_line":"### meta data stuff"},{"line_number":38,"context_line":"NETWORK_XML \u003d \"\"\""},{"line_number":39,"context_line":"\u003cnetwork xmlns\u003d\"http://openstack.org/quantum/api/v2.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fd4E%3D","line":36,"in_reply_to":"AAAAM3%2F%2FeD4%3D","updated":"2013-01-23 00:39:17.000000000","message":"Done","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"}],"quantum/wsgi.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            else:"},{"line_number":235,"context_line":"                root_key \u003d constants.VIRUTUAL_ROOT_KEY"},{"line_number":236,"context_line":"                root_value \u003d data"},{"line_number":237,"context_line":"            doc \u003d minidom.Document()"},{"line_number":238,"context_line":"            used_prefixes \u003d []"},{"line_number":239,"context_line":"            node \u003d self._to_xml_node(doc, self.metadata, root_key,"},{"line_number":240,"context_line":"                                     root_value, used_prefixes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgME%3D","line":237,"updated":"2013-01-18 04:35:50.000000000","message":"Do not use minidom.  It\u0027s is a very old python lib and not performant.  Please use xml.etree.ElementTree.","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            else:"},{"line_number":235,"context_line":"                root_key \u003d constants.VIRUTUAL_ROOT_KEY"},{"line_number":236,"context_line":"                root_value \u003d data"},{"line_number":237,"context_line":"            doc \u003d minidom.Document()"},{"line_number":238,"context_line":"            used_prefixes \u003d []"},{"line_number":239,"context_line":"            node \u003d self._to_xml_node(doc, self.metadata, root_key,"},{"line_number":240,"context_line":"                                     root_value, used_prefixes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgB4%3D","line":237,"in_reply_to":"AAAAM3%2F%2FgME%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"9c39b11c2bffc6ef0defbe42b1e0b38df45f5093","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            return None"},{"line_number":446,"context_line":"        plurals \u003d set(self.metadata.get(\u0027plurals\u0027, {}))"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            node \u003d minidom.parseString(datastring).childNodes[0]"},{"line_number":449,"context_line":"            result \u003d self._from_xml_node(node, plurals)"},{"line_number":450,"context_line":"            if node.nodeName \u003d\u003d constants.VIRUTUAL_ROOT_KEY:"},{"line_number":451,"context_line":"                return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgL8%3D","line":448,"updated":"2013-01-18 04:35:50.000000000","message":"same as above","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            return None"},{"line_number":446,"context_line":"        plurals \u003d set(self.metadata.get(\u0027plurals\u0027, {}))"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            node \u003d minidom.parseString(datastring).childNodes[0]"},{"line_number":449,"context_line":"            result \u003d self._from_xml_node(node, plurals)"},{"line_number":450,"context_line":"            if node.nodeName \u003d\u003d constants.VIRUTUAL_ROOT_KEY:"},{"line_number":451,"context_line":"                return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FgB0%3D","line":448,"in_reply_to":"AAAAM3%2F%2FgL8%3D","updated":"2013-01-18 07:14:22.000000000","message":"Done","commit_id":"e0c50d6f3a1b259ab7751973bda40717bbbecbf7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.metadata \u003d metadata or {}"},{"line_number":218,"context_line":"        if not xmlns:"},{"line_number":219,"context_line":"            xmlns \u003d self.metadata.get(\u0027xmlns\u0027)"},{"line_number":220,"context_line":"        if not xmlns:"},{"line_number":221,"context_line":"            xmlns \u003d constants.XML_NS_V20"},{"line_number":222,"context_line":"        self.xmlns \u003d xmlns"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fd9w%3D","line":220,"updated":"2013-01-21 12:22:10.000000000","message":"why the second if?","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.metadata \u003d metadata or {}"},{"line_number":218,"context_line":"        if not xmlns:"},{"line_number":219,"context_line":"            xmlns \u003d self.metadata.get(\u0027xmlns\u0027)"},{"line_number":220,"context_line":"        if not xmlns:"},{"line_number":221,"context_line":"            xmlns \u003d constants.XML_NS_V20"},{"line_number":222,"context_line":"        self.xmlns \u003d xmlns"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fd4A%3D","line":220,"in_reply_to":"AAAAM3%2F%2Fd9w%3D","updated":"2013-01-23 00:39:17.000000000","message":"in case metadata has no xmlns set.","commit_id":"f41721ad059e3c90d296a2fa0748d23a9e107307"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":258,"context_line":"        # We expect data to contain a single key which is the XML root,"},{"line_number":259,"context_line":"        # non root"},{"line_number":260,"context_line":"        # or empty {}"},{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            key_len \u003d len(data.keys())"},{"line_number":263,"context_line":"            if (key_len \u003d\u003d 1):"},{"line_number":264,"context_line":"                root_key \u003d data.keys()[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FXLU%3D","line":261,"updated":"2013-01-25 15:13:53.000000000","message":"Can you check that data is not None. There are lots of cases when data is None and the exception is logged","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        # We expect data to contain a single key which is the XML root,"},{"line_number":259,"context_line":"        # non root"},{"line_number":260,"context_line":"        # or empty {}"},{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            key_len \u003d len(data.keys())"},{"line_number":263,"context_line":"            if (key_len \u003d\u003d 1):"},{"line_number":264,"context_line":"                root_key \u003d data.keys()[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWfI%3D","line":261,"in_reply_to":"AAAAM3%2F%2FXLU%3D","updated":"2013-01-26 00:00:51.000000000","message":"Done","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":342,"context_line":"                result.set("},{"line_number":343,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":344,"context_line":"                    constants.TYPE_BOOL)"},{"line_number":345,"context_line":"            elif isinstance(data, int):"},{"line_number":346,"context_line":"                result.set("},{"line_number":347,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":348,"context_line":"                    constants.TYPE_INT)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FXNE%3D","line":345,"updated":"2013-01-25 15:04:12.000000000","message":"ip_version is of type \u0027long\u0027 this is not treated","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                result.set("},{"line_number":343,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":344,"context_line":"                    constants.TYPE_BOOL)"},{"line_number":345,"context_line":"            elif isinstance(data, int):"},{"line_number":346,"context_line":"                result.set("},{"line_number":347,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":348,"context_line":"                    constants.TYPE_INT)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWfA%3D","line":345,"in_reply_to":"AAAAM3%2F%2FXNE%3D","updated":"2013-01-26 00:00:51.000000000","message":"Done","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":345,"context_line":"            elif isinstance(data, int):"},{"line_number":346,"context_line":"                result.set("},{"line_number":347,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":348,"context_line":"                    constants.TYPE_INT)"},{"line_number":349,"context_line":"            result.text \u003d str(data)"},{"line_number":350,"context_line":"        return result"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FXNI%3D","line":348,"updated":"2013-01-25 15:04:12.000000000","message":"Can you please add in an else here and log the type - this will help us debug.","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"9921b60b0605251c6db666be966ad7bea4554e14","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            elif isinstance(data, int):"},{"line_number":346,"context_line":"                result.set("},{"line_number":347,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":348,"context_line":"                    constants.TYPE_INT)"},{"line_number":349,"context_line":"            result.text \u003d str(data)"},{"line_number":350,"context_line":"        return result"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWfE%3D","line":348,"in_reply_to":"AAAAM3%2F%2FXNI%3D","updated":"2013-01-26 00:00:51.000000000","message":"Done","commit_id":"761b816fdcd42b8ad55d5ab6f0696171a87b9a66"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"17a1ad8fb9c556fbca23a43ebac3b55642fc5147","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        node.set(\u0027xmlns\u0027, self.xmlns)"},{"line_number":293,"context_line":"        node.set(constants.TYPE_XMLNS, self.xmlns)"},{"line_number":294,"context_line":"        if has_atom:"},{"line_number":295,"context_line":"            node.setAttribute(\u0027xmlns:atom\u0027, \"http://www.w3.org/2005/Atom\")"},{"line_number":296,"context_line":"        node.set(constants.XSI_XMLNS, constants.XSI_NAMESPACE)"},{"line_number":297,"context_line":"        ext_ns \u003d self.metadata.get(constants.EXT_NS, {})"},{"line_number":298,"context_line":"        for prefix in used_prefixes:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FSIc%3D","line":295,"updated":"2013-01-30 10:56:07.000000000","message":"This should be node.set(..),  although this code needn\u0027t now.","commit_id":"5ba1a066251c2db0c2ca0f4e39c9740d349f4e57"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":292,"context_line":"        node.set(\u0027xmlns\u0027, self.xmlns)"},{"line_number":293,"context_line":"        node.set(constants.TYPE_XMLNS, self.xmlns)"},{"line_number":294,"context_line":"        if has_atom:"},{"line_number":295,"context_line":"            node.setAttribute(\u0027xmlns:atom\u0027, \"http://www.w3.org/2005/Atom\")"},{"line_number":296,"context_line":"        node.set(constants.XSI_XMLNS, constants.XSI_NAMESPACE)"},{"line_number":297,"context_line":"        ext_ns \u003d self.metadata.get(constants.EXT_NS, {})"},{"line_number":298,"context_line":"        for prefix in used_prefixes:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FSGs%3D","line":295,"in_reply_to":"AAAAM3%2F%2FSIc%3D","updated":"2013-01-30 11:12:10.000000000","message":"Done","commit_id":"5ba1a066251c2db0c2ca0f4e39c9740d349f4e57"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":179,"context_line":"        if len(parts) \u003e 1:"},{"line_number":180,"context_line":"            _format \u003d parts[1]"},{"line_number":181,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":182,"context_line":"                return \u0027application/{0}\u0027.format(_format)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        #Then look up content header"},{"line_number":185,"context_line":"        type_from_header \u003d self.get_content_type()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FON4%3D","line":182,"updated":"2013-02-01 16:23:58.000000000","message":"I think I\u0027ve seen this code in another module too. Any chance we can refactor?","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":179,"context_line":"        if len(parts) \u003e 1:"},{"line_number":180,"context_line":"            _format \u003d parts[1]"},{"line_number":181,"context_line":"            if _format in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":182,"context_line":"                return \u0027application/{0}\u0027.format(_format)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        #Then look up content header"},{"line_number":185,"context_line":"        type_from_header \u003d self.get_content_type()"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOFA%3D","line":182,"in_reply_to":"AAAAM3%2F%2FON4%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":306,"context_line":"            used_prefixes.append(nodename.split(\":\", 1)[0])"},{"line_number":307,"context_line":"        #TODO(bcwaldon): accomplish this without a type-check"},{"line_number":308,"context_line":"        if isinstance(data, list):"},{"line_number":309,"context_line":"            if not data:"},{"line_number":310,"context_line":"                result.set("},{"line_number":311,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":312,"context_line":"                    constants.TYPE_LIST)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOJg%3D","line":309,"updated":"2013-02-01 16:23:58.000000000","message":"populate lists will not receive the type attribute.\nI think this is by design in your patch. I think however it will cause validation issue once one day people will start using XSD schemas (and I think will happen)","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":306,"context_line":"            used_prefixes.append(nodename.split(\":\", 1)[0])"},{"line_number":307,"context_line":"        #TODO(bcwaldon): accomplish this without a type-check"},{"line_number":308,"context_line":"        if isinstance(data, list):"},{"line_number":309,"context_line":"            if not data:"},{"line_number":310,"context_line":"                result.set("},{"line_number":311,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":312,"context_line":"                    constants.TYPE_LIST)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FNdo%3D","line":309,"in_reply_to":"AAAAM3%2F%2FOCs%3D","updated":"2013-02-02 05:15:02.000000000","message":"When it is populated, system know if it is a list, dict, or string. so we don\u0027t need quantum:type \u003d list|dict","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":306,"context_line":"            used_prefixes.append(nodename.split(\":\", 1)[0])"},{"line_number":307,"context_line":"        #TODO(bcwaldon): accomplish this without a type-check"},{"line_number":308,"context_line":"        if isinstance(data, list):"},{"line_number":309,"context_line":"            if not data:"},{"line_number":310,"context_line":"                result.set("},{"line_number":311,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":312,"context_line":"                    constants.TYPE_LIST)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOCs%3D","line":309,"in_reply_to":"AAAAM3%2F%2FOEA%3D","updated":"2013-02-01 17:24:10.000000000","message":"I meant list with elements. I wrote \u0027populate\u0027 instead of \u0027populated\u0027","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":306,"context_line":"            used_prefixes.append(nodename.split(\":\", 1)[0])"},{"line_number":307,"context_line":"        #TODO(bcwaldon): accomplish this without a type-check"},{"line_number":308,"context_line":"        if isinstance(data, list):"},{"line_number":309,"context_line":"            if not data:"},{"line_number":310,"context_line":"                result.set("},{"line_number":311,"context_line":"                    constants.TYPE_ATTR,"},{"line_number":312,"context_line":"                    constants.TYPE_LIST)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOEA%3D","line":309,"in_reply_to":"AAAAM3%2F%2FOJg%3D","updated":"2013-02-01 17:06:31.000000000","message":"populate lists will not receive the type attribute. I don\u0027t understand.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":494,"context_line":"            # Python2.6"},{"line_number":495,"context_line":"            elif isinstance(e, expat.ExpatError):"},{"line_number":496,"context_line":"                parseError \u003d True"},{"line_number":497,"context_line":"            if parseError:"},{"line_number":498,"context_line":"                msg \u003d _(\"Cannot understand XML\")"},{"line_number":499,"context_line":"                raise exception.MalformedRequestBody(reason\u003dmsg)"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOLs%3D","line":497,"updated":"2013-02-01 16:23:58.000000000","message":"If parseError \u003d\u003d False we should probably re-raise.\nIf not, please add a comment that the only possible exceptions that can occur here ar ExpatError (2.6) or ParseError(2.7)","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":494,"context_line":"            # Python2.6"},{"line_number":495,"context_line":"            elif isinstance(e, expat.ExpatError):"},{"line_number":496,"context_line":"                parseError \u003d True"},{"line_number":497,"context_line":"            if parseError:"},{"line_number":498,"context_line":"                msg \u003d _(\"Cannot understand XML\")"},{"line_number":499,"context_line":"                raise exception.MalformedRequestBody(reason\u003dmsg)"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOE4%3D","line":497,"in_reply_to":"AAAAM3%2F%2FOLs%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":505,"context_line":"                          be considered list items."},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        attrNil \u003d node.get(str(etree.QName(constants.XSI_NAMESPACE, \"nil\")))"},{"line_number":509,"context_line":"        attrType \u003d node.get(str(etree.QName("},{"line_number":510,"context_line":"            self.metadata.get(\u0027xmlns\u0027), \"type\")))"},{"line_number":511,"context_line":"        if (attrNil and attrNil.lower() \u003d\u003d \u0027true\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOKI%3D","line":508,"updated":"2013-02-01 16:23:58.000000000","message":"I\u0027ve seen your code for parsing the xml input also converts values. I was just wondering if we really needs this. The API layer, where these data are fed, will also make a similar conversion.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":505,"context_line":"                          be considered list items."},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        attrNil \u003d node.get(str(etree.QName(constants.XSI_NAMESPACE, \"nil\")))"},{"line_number":509,"context_line":"        attrType \u003d node.get(str(etree.QName("},{"line_number":510,"context_line":"            self.metadata.get(\u0027xmlns\u0027), \"type\")))"},{"line_number":511,"context_line":"        if (attrNil and attrNil.lower() \u003d\u003d \u0027true\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FNdk%3D","line":508,"in_reply_to":"AAAAM3%2F%2FOCo%3D","updated":"2013-02-02 05:15:02.000000000","message":"yes. but that is for data to our API server. If we are getting out the data, and we have no type information, we just can deserialize it into string. our test cases are such users. For them to run right, I have to make sure what is passed in, what is passed out. otherwise all the assertEuqal(data[\u0027subnet\u0027][\u0027gateway_ip\u0027], res[\u0027subnet\u0027][\u0027gateway_ip\u0027]) will fail.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":505,"context_line":"                          be considered list items."},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        attrNil \u003d node.get(str(etree.QName(constants.XSI_NAMESPACE, \"nil\")))"},{"line_number":509,"context_line":"        attrType \u003d node.get(str(etree.QName("},{"line_number":510,"context_line":"            self.metadata.get(\u0027xmlns\u0027), \"type\")))"},{"line_number":511,"context_line":"        if (attrNil and attrNil.lower() \u003d\u003d \u0027true\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOCo%3D","line":508,"in_reply_to":"AAAAM3%2F%2FOEo%3D","updated":"2013-02-01 17:24:10.000000000","message":"My point was that whatever you pass in the xml tag, this is still going to be validated and converted by the quantum API.\n\nConsider gateway_ip for subnet\n\u003cgateway_ip quantum:type\u003dint\u003e4\u003c/gateway_ip\u003e\n\u003cgateway_ip quantum:type\u003dstring\u003e4\u003c/gateway_ip\u003e\n\nare still going to be converted into the integer 4 because we have a converter in the quantum API. Is that right?","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":505,"context_line":"                          be considered list items."},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        attrNil \u003d node.get(str(etree.QName(constants.XSI_NAMESPACE, \"nil\")))"},{"line_number":509,"context_line":"        attrType \u003d node.get(str(etree.QName("},{"line_number":510,"context_line":"            self.metadata.get(\u0027xmlns\u0027), \"type\")))"},{"line_number":511,"context_line":"        if (attrNil and attrNil.lower() \u003d\u003d \u0027true\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOEo%3D","line":508,"in_reply_to":"AAAAM3%2F%2FOKI%3D","updated":"2013-02-01 17:06:31.000000000","message":"the purpose of (de)serializer is just like a tool to transport the data. We need to keep data\u0027s type and value. If my data is integer 5, we cannot get a string 5 after we deserialize it.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":516,"context_line":"            elif (attrType and attrType \u003d\u003d constants.TYPE_LIST):"},{"line_number":517,"context_line":"                return []"},{"line_number":518,"context_line":"            else:"},{"line_number":519,"context_line":"                return \u0027\u0027"},{"line_number":520,"context_line":"        elif (len(node) \u003d\u003d 0 and node.text):"},{"line_number":521,"context_line":"            nodevalue \u003d node.text"},{"line_number":522,"context_line":"            if attrType and attrType \u003d\u003d constants.TYPE_BOOL:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOLg%3D","line":519,"updated":"2013-02-01 16:23:58.000000000","message":"In which case will we hit line 519?","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":516,"context_line":"            elif (attrType and attrType \u003d\u003d constants.TYPE_LIST):"},{"line_number":517,"context_line":"                return []"},{"line_number":518,"context_line":"            else:"},{"line_number":519,"context_line":"                return \u0027\u0027"},{"line_number":520,"context_line":"        elif (len(node) \u003d\u003d 0 and node.text):"},{"line_number":521,"context_line":"            nodevalue \u003d node.text"},{"line_number":522,"context_line":"            if attrType and attrType \u003d\u003d constants.TYPE_BOOL:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOEc%3D","line":519,"in_reply_to":"AAAAM3%2F%2FOLg%3D","updated":"2013-02-01 17:06:31.000000000","message":"\u003cstringdata/\u003e","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":522,"context_line":"            if attrType and attrType \u003d\u003d constants.TYPE_BOOL:"},{"line_number":523,"context_line":"                return nodevalue.lower() \u003d\u003d \u0027true\u0027"},{"line_number":524,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_INT:"},{"line_number":525,"context_line":"                return int(nodevalue)"},{"line_number":526,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_LONG:"},{"line_number":527,"context_line":"                return long(nodevalue)"},{"line_number":528,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_FLOAT:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOK4%3D","line":525,"updated":"2013-02-01 16:23:58.000000000","message":"how do you see making this code a bit more generic using:\n\n getattr(__builtins__,  attrType)(nodevalue)\n\nit will work with anything but bool","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":522,"context_line":"            if attrType and attrType \u003d\u003d constants.TYPE_BOOL:"},{"line_number":523,"context_line":"                return nodevalue.lower() \u003d\u003d \u0027true\u0027"},{"line_number":524,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_INT:"},{"line_number":525,"context_line":"                return int(nodevalue)"},{"line_number":526,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_LONG:"},{"line_number":527,"context_line":"                return long(nodevalue)"},{"line_number":528,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_FLOAT:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOEQ%3D","line":525,"in_reply_to":"AAAAM3%2F%2FOK4%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":528,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_FLOAT:"},{"line_number":529,"context_line":"                return float(nodevalue)"},{"line_number":530,"context_line":"            else:"},{"line_number":531,"context_line":"                return nodevalue"},{"line_number":532,"context_line":"        elif self._get_key(node.tag) in listnames:"},{"line_number":533,"context_line":"            return [self._from_xml_node(n, listnames) for n in node]"},{"line_number":534,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOKg%3D","line":531,"updated":"2013-02-01 16:23:58.000000000","message":"consider a factory pattern with a dict instead of a cascaded if\n\nconverters \u003d { constants.TYPE_BOOL: lambda x:x.lower() \u003d\u003dtrue,\nconstants.TYPE_INT: lambda x:int(x),\nconstants.TYPE_LONG: lambda x:long(x),\nconstants.TYPE_FLOAT: lambda x:float(x)\n}\n\nand then return converters[attrType](nodevalue)\n\nIf really want to make me a happy man, you can combine this comment with the previous, but that\u0027s up to you. I won\u0027t mind either way.","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":528,"context_line":"            elif attrType and attrType \u003d\u003d constants.TYPE_FLOAT:"},{"line_number":529,"context_line":"                return float(nodevalue)"},{"line_number":530,"context_line":"            else:"},{"line_number":531,"context_line":"                return nodevalue"},{"line_number":532,"context_line":"        elif self._get_key(node.tag) in listnames:"},{"line_number":533,"context_line":"            return [self._from_xml_node(n, listnames) for n in node]"},{"line_number":534,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAM3%2F%2FOEM%3D","line":531,"in_reply_to":"AAAAM3%2F%2FOKg%3D","updated":"2013-02-01 17:06:31.000000000","message":"Done","commit_id":"5a4741e13c2956230fb0b867514c57cb7ae995d6"}]}
