)]}'
{"neutron/tests/unit/test_ipam.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d71cb73dffe9dcaadedf6e17b279468b57cfe8ca","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_ipam_driver_is_loaded_from_ipam_driver_config_value(self):"},{"line_number":279,"context_line":"        ipam_driver \u003d self._load_ipam_driver(\u0027fake\u0027, None)"},{"line_number":280,"context_line":"        class_type \u003d type if six.PY3 else types.ClassType"},{"line_number":281,"context_line":"        self.assertIsInstance("},{"line_number":282,"context_line":"            ipam_driver, (fake_driver.FakeDriver, class_type),"},{"line_number":283,"context_line":"            \"loaded ipam driver should be of type FakeDriver\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_023c2c92","line":280,"updated":"2015-07-10 23:22:11.000000000","message":"Honestly, I don\u0027t see any reason for both tests you touch to check that FakeDriver subclass is also a class. Seems redundant, right? How about just killing those redundant checks?","commit_id":"a5499c5762550b968cef8e8479df2561d09eb5d7"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"31ad361e3e08f382649d208e40be1958741bfd72","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_ipam_driver_is_loaded_from_ipam_driver_config_value(self):"},{"line_number":279,"context_line":"        ipam_driver \u003d self._load_ipam_driver(\u0027fake\u0027, None)"},{"line_number":280,"context_line":"        class_type \u003d type if six.PY3 else types.ClassType"},{"line_number":281,"context_line":"        self.assertIsInstance("},{"line_number":282,"context_line":"            ipam_driver, (fake_driver.FakeDriver, class_type),"},{"line_number":283,"context_line":"            \"loaded ipam driver should be of type FakeDriver\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_bfce9881","line":280,"in_reply_to":"9a41bdd9_023c2c92","updated":"2015-07-12 17:19:31.000000000","message":"+1","commit_id":"a5499c5762550b968cef8e8479df2561d09eb5d7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"0e88e3d5b5492911ef81b2e016845d49fe7025b6","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_ipam_driver_is_loaded_from_ipam_driver_config_value(self):"},{"line_number":279,"context_line":"        ipam_driver \u003d self._load_ipam_driver(\u0027fake\u0027, None)"},{"line_number":280,"context_line":"        class_type \u003d type if six.PY3 else types.ClassType"},{"line_number":281,"context_line":"        self.assertIsInstance("},{"line_number":282,"context_line":"            ipam_driver, (fake_driver.FakeDriver, class_type),"},{"line_number":283,"context_line":"            \"loaded ipam driver should be of type FakeDriver\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_0986dada","line":280,"in_reply_to":"9a41bdd9_023c2c92","updated":"2015-07-15 11:46:17.000000000","message":"What is the purpose of testing properties of mocks?","commit_id":"a5499c5762550b968cef8e8479df2561d09eb5d7"}]}