)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"580a47e696cd5c5c2db8166abed5cbd3763900ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nmagnezi \u003cnmagnezi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-13 16:23:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds garp_master_repeat and garp_master_refresh to keepalived.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to solve an issue when, in some cases, the L3 agent might"},{"line_number":10,"context_line":"start before the OVS agent during a node boot process."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_479deb57","line":7,"updated":"2015-07-14 12:25:48.000000000","message":"Personally, I don\u0027t prefer adding new configuration params, but the bug report says that these values should be configurable with some default values. Can you please check with @Assaf to get his views.","commit_id":"4aa62e7d2c3ff7ce6f9fdcc8e9af5b3d43f9428e"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"4a6a5fb60917bf9b27498c1d80c322c8f74721e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nmagnezi \u003cnmagnezi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-13 16:23:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds garp_master_repeat and garp_master_refresh to keepalived.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aims to solve an issue when, in some cases, the L3 agent might"},{"line_number":10,"context_line":"start before the OVS agent during a node boot process."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_1cd351d6","line":7,"in_reply_to":"9a41bdd9_479deb57","updated":"2015-07-23 12:11:35.000000000","message":"Done, Added amuller as reviewer.","commit_id":"4aa62e7d2c3ff7ce6f9fdcc8e9af5b3d43f9428e"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"f498c1902db92013a45a73dcd75be11d219c3536","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                  \u0027    interface %s\u0027 % self.interface,"},{"line_number":251,"context_line":"                  \u0027    virtual_router_id %s\u0027 % self.vrouter_id,"},{"line_number":252,"context_line":"                  \u0027    priority %s\u0027 % self.priority,"},{"line_number":253,"context_line":"                  \u0027    garp_master_repeat %s\u0027 % self.garp_master_repeat,"},{"line_number":254,"context_line":"                  \u0027    garp_master_refresh %s\u0027 % self.garp_master_refresh]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if self.nopreempt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_336a73b4","line":253,"updated":"2015-07-21 15:04:33.000000000","message":"No Action Required: garp_master_repeat is added in version 1.2.14, but no issues even when using older versions of keepalived as it simply ignores the unknown configuration parameters.","commit_id":"141560b4221b9b58fd34405a8f94e826f92f35ff"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"27449954870468a6ffaf56e28a9b8f75c3a99616","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                  \u0027    interface %s\u0027 % self.interface,"},{"line_number":251,"context_line":"                  \u0027    virtual_router_id %s\u0027 % self.vrouter_id,"},{"line_number":252,"context_line":"                  \u0027    priority %s\u0027 % self.priority,"},{"line_number":253,"context_line":"                  \u0027    garp_master_repeat %s\u0027 % self.garp_master_repeat,"},{"line_number":254,"context_line":"                  \u0027    garp_master_refresh %s\u0027 % self.garp_master_refresh]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if self.nopreempt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ad0b5b8d","line":253,"in_reply_to":"3a50d1a3_336a73b4","updated":"2015-07-23 12:12:45.000000000","message":"thank you for that info Sridhar! much appreciated.","commit_id":"141560b4221b9b58fd34405a8f94e826f92f35ff"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"f498c1902db92013a45a73dcd75be11d219c3536","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                  \u0027    virtual_router_id %s\u0027 % self.vrouter_id,"},{"line_number":252,"context_line":"                  \u0027    priority %s\u0027 % self.priority,"},{"line_number":253,"context_line":"                  \u0027    garp_master_repeat %s\u0027 % self.garp_master_repeat,"},{"line_number":254,"context_line":"                  \u0027    garp_master_refresh %s\u0027 % self.garp_master_refresh]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if self.nopreempt:"},{"line_number":257,"context_line":"            config.append(\u0027    nopreempt\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1856765c","line":254,"updated":"2015-07-21 15:04:33.000000000","message":"No Action Required: garp_master_refresh was added in 1.2.10 version of keepalived. So apart from IPv6 use-case [1], we now have another reason to move to version 1.2.10 \n\n[1] - https://review.openstack.org/#/c/168781/","commit_id":"141560b4221b9b58fd34405a8f94e826f92f35ff"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"27449954870468a6ffaf56e28a9b8f75c3a99616","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                  \u0027    virtual_router_id %s\u0027 % self.vrouter_id,"},{"line_number":252,"context_line":"                  \u0027    priority %s\u0027 % self.priority,"},{"line_number":253,"context_line":"                  \u0027    garp_master_repeat %s\u0027 % self.garp_master_repeat,"},{"line_number":254,"context_line":"                  \u0027    garp_master_refresh %s\u0027 % self.garp_master_refresh]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if self.nopreempt:"},{"line_number":257,"context_line":"            config.append(\u0027    nopreempt\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_6d01d369","line":254,"in_reply_to":"3a50d1a3_1856765c","updated":"2015-07-23 12:12:45.000000000","message":"thank you for that info Sridhar! much appreciated.","commit_id":"141560b4221b9b58fd34405a8f94e826f92f35ff"}]}