)]}'
{"quantum/db/loadbalancer/loadbalancer_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a0b3dc3d37adc56ee9fc84961a9c670becdaf2d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Famo%3D","line":70,"updated":"2013-01-23 12:53:22.000000000","message":"Why no UDP and or IP.\nThat would have all bases covered.","commit_id":"2e1c9a0426f98681924c659e216e5bb0a35ffd8e"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"ed8e5a4c432c51f035d33d924c2a66185d73fb81","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fadk%3D","line":70,"in_reply_to":"AAAAM3%2F%2Famo%3D","updated":"2013-01-24 09:50:48.000000000","message":"Can you please check out this thread in the development mailing list http://lists.openstack.org/pipermail/openstack-dev/2013-January/004815.html ?\n\nThe goal for Grizzly is to add support of these three protocols because they are supported by HAProxy. After Grizzly is released we will think about implementing a framework that will allow drivers to extend the API features (i.e. supported protocols).\n\nThe problem is that we cannot predict what protocols are supported by the drivers without direct interaction with them.","commit_id":"2e1c9a0426f98681924c659e216e5bb0a35ffd8e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FSbk%3D","line":70,"updated":"2013-01-30 05:14:36.000000000","message":"I think this should be vips_protocol ? (I haven\u0027t run this though)\n\nhttps://github.com/openstack/quantum/blob/master/quantum/db/model_base.py#L68","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FQcE%3D","line":70,"in_reply_to":"AAAAM3%2F%2FR0w%3D","updated":"2013-01-31 05:29:39.000000000","message":"Thanks for the information mark. It seems to me like postgres should abstract/optimize this away automatically and just use w/e enum type you you provide to display to the user as the name. Any idea why it doesn\u0027t?","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FR0w%3D","line":70,"in_reply_to":"AAAAM3%2F%2FSao%3D","updated":"2013-01-30 14:50:13.000000000","message":"Correct.  Posgres actually creates a user defined type for enums (\\dT will list them).  If the enums had different symbols, postgres would raise an error when the schema is loaded.\n\nLet\u0027s change to lb_protocols.","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FSao%3D","line":70,"in_reply_to":"AAAAM3%2F%2FSbI%3D","updated":"2013-01-30 05:48:27.000000000","message":"interesting, I didn\u0027t actually know what that name field does. I just figured it should be the convention of what the first patch related to postgres did related to the name. I like lb_protocols better but i\u0027m ok with vip_protocol. \n\nThis name would matter though if the columns had a different types though right? I read though http://docs.sqlalchemy.org/en/rel_0_8/core/types.html but that doesn\u0027t seem to actually explain why they need it. \n\nname – The name of this type. This is required for Postgresql and any future supported database which requires an explicitly named type, or an explicitly named constraint in order to generate the type and/or a table that uses it.","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":67,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":68,"context_line":"    address \u003d sa.Column(sa.String(64))"},{"line_number":69,"context_line":"    port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":73,"context_line":"    session_persistence \u003d orm.relationship(SessionPersistence,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FSbI%3D","line":70,"in_reply_to":"AAAAM3%2F%2FSbk%3D","updated":"2013-01-30 05:24:21.000000000","message":"The name is arbitrary. Both columns can share the same enum datatype.  MySQL ignores the names, but postgres is particular about it.  Would name\u003d\"lb_protocols\" work?","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":97,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":98,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":99,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":100,"context_line":"                         nullable\u003dFalse)"},{"line_number":101,"context_line":"    lb_method \u003d sa.Column(sa.Enum(\"ROUND_ROBIN\","},{"line_number":102,"context_line":"                                  \"LEAST_CONNECTIONS\","}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FSb4%3D","line":99,"updated":"2013-01-30 05:14:36.000000000","message":"The name here is definitely wrong. I think this should be pools_protocol.","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":97,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":98,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":99,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"vip_protocol\"),"},{"line_number":100,"context_line":"                         nullable\u003dFalse)"},{"line_number":101,"context_line":"    lb_method \u003d sa.Column(sa.Enum(\"ROUND_ROBIN\","},{"line_number":102,"context_line":"                                  \"LEAST_CONNECTIONS\","}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FSbM%3D","line":99,"in_reply_to":"AAAAM3%2F%2FSb4%3D","updated":"2013-01-30 05:24:21.000000000","message":"see above","commit_id":"f2ce83a5b805adadf8334b7af74f6792219fa233"}],"quantum/extensions/loadbalancer.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"                 \u0027convert_to\u0027: attr.convert_to_int,"},{"line_number":83,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":84,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":85,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: [\u0027TCP\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027]},"},{"line_number":86,"context_line":"                     \u0027is_visible\u0027: True},"},{"line_number":87,"context_line":"        \u0027pool_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":88,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FZEU%3D","line":85,"updated":"2013-01-24 10:31:17.000000000","message":"Any chance if having this and line 125 as common data?\nMaybe a global data structure?","commit_id":"223fdf52b3860788f88280decc38ad4af603cc0b"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"ed8e5a4c432c51f035d33d924c2a66185d73fb81","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                 \u0027convert_to\u0027: attr.convert_to_int,"},{"line_number":83,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":84,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":85,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: [\u0027TCP\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027]},"},{"line_number":86,"context_line":"                     \u0027is_visible\u0027: True},"},{"line_number":87,"context_line":"        \u0027pool_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":88,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FZB4%3D","line":85,"in_reply_to":"AAAAM3%2F%2FZEU%3D","updated":"2013-01-24 11:21:23.000000000","message":"I agree with you. Having a common structure that describes a set of supported protocols seems to be reasonable. However, it\u0027s also reasonable to use the same structure for defining the schema of the database. Implementing this is not limited to defining a common data structure here, but also requires some additional modifications to be done.\n\nAs long as we consider this as a temporary solution for Grizzly, I do not think it\u0027s a reasonable to add a lot of modifications: After Grizzly is released we will remake this completely to allow drivers extending the API.","commit_id":"223fdf52b3860788f88280decc38ad4af603cc0b"}],"quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":387,"context_line":"                (\u0027status\u0027, \u0027PENDING_CREATE\u0027)]"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        vip \u003d self.vip(name\u003dname, protocol\u003d\u0027UNSUPPORTED\u0027)"},{"line_number":390,"context_line":"        self.assertRaises(webob.exc.HTTPClientError, vip.__enter__)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        with self.vip(name\u003dname) as vip:"},{"line_number":393,"context_line":"            for k, v in keys:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FWyQ%3D","line":390,"updated":"2013-01-25 19:40:21.000000000","message":"Would have preferred a separate test case for unsupported protocol.","commit_id":"223fdf52b3860788f88280decc38ad4af603cc0b"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"ed8e5a4c432c51f035d33d924c2a66185d73fb81","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                (\u0027status\u0027, \u0027PENDING_CREATE\u0027)]"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        vip \u003d self.vip(name\u003dname, protocol\u003d\u0027UNSUPPORTED\u0027)"},{"line_number":390,"context_line":"        self.assertRaises(webob.exc.HTTPClientError, vip.__enter__)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        with self.vip(name\u003dname) as vip:"},{"line_number":393,"context_line":"            for k, v in keys:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FUG4%3D","line":390,"in_reply_to":"AAAAM3%2F%2FUxo%3D","updated":"2013-01-29 12:01:15.000000000","message":"Done","commit_id":"223fdf52b3860788f88280decc38ad4af603cc0b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":387,"context_line":"                (\u0027status\u0027, \u0027PENDING_CREATE\u0027)]"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        vip \u003d self.vip(name\u003dname, protocol\u003d\u0027UNSUPPORTED\u0027)"},{"line_number":390,"context_line":"        self.assertRaises(webob.exc.HTTPClientError, vip.__enter__)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        with self.vip(name\u003dname) as vip:"},{"line_number":393,"context_line":"            for k, v in keys:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FUxo%3D","line":390,"in_reply_to":"AAAAM3%2F%2FWyQ%3D","updated":"2013-01-28 22:56:34.000000000","message":"I agree with Sumit that the failing test case should be separated into a standalone test.","commit_id":"223fdf52b3860788f88280decc38ad4af603cc0b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":398,"context_line":"                (\u0027admin_state_up\u0027, True),"},{"line_number":399,"context_line":"                (\u0027status\u0027, \u0027PENDING_CREATE\u0027)]"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        vip \u003d self.vip(name\u003dname, protocol\u003d\u0027UNSUPPORTED\u0027)"},{"line_number":402,"context_line":"        self.assertRaises(webob.exc.HTTPClientError, vip.__enter__)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        with self.vip(name\u003dname) as vip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FT18%3D","line":401,"updated":"2013-01-29 15:24:44.000000000","message":"Looks like this is covered by lines 411-412 and can be removed.","commit_id":"43ab17d804a331fad0eb48c3bfdae9406f4479d3"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"ed8e5a4c432c51f035d33d924c2a66185d73fb81","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                (\u0027admin_state_up\u0027, True),"},{"line_number":399,"context_line":"                (\u0027status\u0027, \u0027PENDING_CREATE\u0027)]"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        vip \u003d self.vip(name\u003dname, protocol\u003d\u0027UNSUPPORTED\u0027)"},{"line_number":402,"context_line":"        self.assertRaises(webob.exc.HTTPClientError, vip.__enter__)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        with self.vip(name\u003dname) as vip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FTzU%3D","line":401,"in_reply_to":"AAAAM3%2F%2FT18%3D","updated":"2013-01-29 15:38:10.000000000","message":"Whoops. You\u0027re right. Will remove them in the next patch set.","commit_id":"43ab17d804a331fad0eb48c3bfdae9406f4479d3"}]}
