)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"434e072a79f808f57bbe0eac44373e7c39f732ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-15 19:28:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l3_db: not sue l3 plugin _get_subnet unnecessarily"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_32299a8a","line":7,"updated":"2015-07-16 04:41:53.000000000","message":"Typo.  sue \u003d use","commit_id":"d4902c7965de5abb615b27ded2c079e49c1d7eae"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e80fff905038cd74757da09e96187229ce102a54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaku Yamahata \u003cisaku.yamahata@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-15 19:28:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l3_db: not sue l3 plugin _get_subnet unnecessarily"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_022aec7e","line":7,"in_reply_to":"9a41bdd9_32299a8a","updated":"2015-07-16 14:29:15.000000000","message":"Done","commit_id":"d4902c7965de5abb615b27ded2c079e49c1d7eae"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"434e072a79f808f57bbe0eac44373e7c39f732ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."},{"line_number":11,"context_line":"In that case, l2 plugin or ML2 mechanism driver will be confused."},{"line_number":12,"context_line":"This patch replace _get_subnet with get_subnet method where possible."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I85769e639a408a292b5bd70a9d9a1ac292e2b51c"},{"line_number":15,"context_line":"Related-Bug: #1475093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_522c5e98","line":12,"updated":"2015-07-16 04:41:53.000000000","message":"replace \u003d replaces","commit_id":"d4902c7965de5abb615b27ded2c079e49c1d7eae"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e80fff905038cd74757da09e96187229ce102a54","unresolved":false,"context_lines":[{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."},{"line_number":11,"context_line":"In that case, l2 plugin or ML2 mechanism driver will be confused."},{"line_number":12,"context_line":"This patch replace _get_subnet with get_subnet method where possible."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I85769e639a408a292b5bd70a9d9a1ac292e2b51c"},{"line_number":15,"context_line":"Related-Bug: #1475093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_a29d400c","line":12,"in_reply_to":"9a41bdd9_522c5e98","updated":"2015-07-16 14:29:15.000000000","message":"Done","commit_id":"d4902c7965de5abb615b27ded2c079e49c1d7eae"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"244927fb5e624d7fb234409c0063477e4d53a5f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l3_db: not use l2 plugin _get_subnet unnecessarily"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."},{"line_number":11,"context_line":"In that case, l2 plugin or ML2 mechanism driver will be confused."},{"line_number":12,"context_line":"This patch replaces _get_subnet with get_subnet method where possible."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_0f68b1b9","line":10,"updated":"2015-07-17 05:36:02.000000000","message":"same question.","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c52f4814ad2b9be803cc2bcfd53fc453666d4896","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l3_db: not use l2 plugin _get_subnet unnecessarily"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"l3_db uses l2 plugin _get_subnet method unnecessarily."},{"line_number":10,"context_line":"It\u0027s dangerous because it may update subnet db without notifying l2 plugin."},{"line_number":11,"context_line":"In that case, l2 plugin or ML2 mechanism driver will be confused."},{"line_number":12,"context_line":"This patch replaces _get_subnet with get_subnet method where possible."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_15e6ad43","line":10,"in_reply_to":"9a41bdd9_0f68b1b9","updated":"2015-07-23 18:22:02.000000000","message":"Done","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"d7c3e22f4dcddd424d62036d564d82aeaeb8c837","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":184,"context_line":"        return subnet_qry.filter_by(network_id\u003dnetwork_id).all()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":189,"context_line":"                subnet_qry.filter_by(network_id\u003dnetwork_id).all()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_e87247b0","line":186,"updated":"2015-07-16 14:43:06.000000000","message":"nit: This new routine is not mentioned in the commit message.","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c52f4814ad2b9be803cc2bcfd53fc453666d4896","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":184,"context_line":"        return subnet_qry.filter_by(network_id\u003dnetwork_id).all()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":189,"context_line":"                subnet_qry.filter_by(network_id\u003dnetwork_id).all()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_15bd4d01","line":186,"in_reply_to":"9a41bdd9_e87247b0","updated":"2015-07-23 18:22:02.000000000","message":"Done","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f7414cdb6b89165cab0b22ea569230b3d49bbc6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":189,"context_line":"                subnet_qry.filter_by(network_id\u003dnetwork_id).all()]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _get_subnets_by_subnetpool(self, context, subnetpool_id):"},{"line_number":192,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_076b55b8","line":189,"updated":"2015-07-22 04:23:34.000000000","message":"why don\u0027t you use _get_subnets_by_network to implement this?","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c52f4814ad2b9be803cc2bcfd53fc453666d4896","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":189,"context_line":"                subnet_qry.filter_by(network_id\u003dnetwork_id).all()]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _get_subnets_by_subnetpool(self, context, subnetpool_id):"},{"line_number":192,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_d53925a5","line":189,"in_reply_to":"3a50d1a3_076b55b8","updated":"2015-07-23 18:22:02.000000000","message":"Done","commit_id":"15f10f93515b63dd28f649a040f974274765ffbc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87a118b81eae06310f671ec75dd96cbe866e21dc","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return subnet_qry.filter_by(network_id\u003dnetwork_id).all()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":191,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":192,"context_line":"                self._get_subnets_by_network(context, network_id)]"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_b40e9830","line":190,"updated":"2015-07-24 22:44:35.000000000","message":"Shouldn\u0027t this live over in db_base_plugin_v2.py ?","commit_id":"219b3fcf2cec24f118e8be9dbeb44d1f83796b3e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a8a0cb7c285c5ab8fa2dd449373b82998f9377ff","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        subnet_qry \u003d context.session.query(models_v2.Subnet)"},{"line_number":188,"context_line":"        return subnet_qry.filter_by(network_id\u003dnetwork_id).all()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def get_subnets_by_network(self, context, network_id):"},{"line_number":191,"context_line":"        return [self._make_subnet_dict(subnet_db) for subnet_db in"},{"line_number":192,"context_line":"                self._get_subnets_by_network(context, network_id)]"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_21131d0f","line":190,"in_reply_to":"3a50d1a3_b40e9830","updated":"2015-08-04 17:27:27.000000000","message":"Done","commit_id":"219b3fcf2cec24f118e8be9dbeb44d1f83796b3e"}]}
