)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c360dddf0f0115c84d37782d2622aaae9910a16f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Python 3: Wrap map() in a list call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"map() returns an iterator in python 3. In a case that a list is expected,"},{"line_number":10,"context_line":"we wrap map() in a list call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I623d854c410176c8ec43b732dc8f4e087dadefd9"},{"line_number":13,"context_line":"Blueprint: neutron-python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_53c66d17","line":10,"updated":"2015-07-17 00:17:06.000000000","message":"why not using list comprehension which is more pythonic?","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"821d152ab9fdc3132c3ffa21a16c750841665fba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Python 3: Wrap map() in a list call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"map() returns an iterator in python 3. In a case that a list is expected,"},{"line_number":10,"context_line":"we wrap map() in a list call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I623d854c410176c8ec43b732dc8f4e087dadefd9"},{"line_number":13,"context_line":"Blueprint: neutron-python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_1e09c531","line":10,"in_reply_to":"9a41bdd9_53c66d17","updated":"2015-07-17 05:20:11.000000000","message":"It\u0027s coming from https://docs.python.org/3.3/library/2to3.html#2to3fixer-map.\nI am good in both.","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9c0df180f0fe77573b822a9e967f665daf30c32e","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                    in_(AUTO_DELETE_PORT_OWNERS)))"},{"line_number":613,"context_line":"            network_ports \u003d qry_network_ports.all()"},{"line_number":614,"context_line":"            if network_ports:"},{"line_number":615,"context_line":"                list(map(context.session.delete, network_ports))"},{"line_number":616,"context_line":"            # Check if there are more IP allocations, unless"},{"line_number":617,"context_line":"            # is_auto_address_subnet is True. In that case the check is"},{"line_number":618,"context_line":"            # unnecessary. This additional check not only would be wasteful"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_41bebbae","line":615,"updated":"2015-07-16 12:22:19.000000000","message":"for-loop is simpler where the result is not necessary.","commit_id":"d1ddf560dabc0df4b231ec649e4dac62f3659790"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"103be16dccd55c25e8d12a9eaccd26e89b36e96e","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                    in_(AUTO_DELETE_PORT_OWNERS)))"},{"line_number":613,"context_line":"            network_ports \u003d qry_network_ports.all()"},{"line_number":614,"context_line":"            if network_ports:"},{"line_number":615,"context_line":"                list(map(context.session.delete, network_ports))"},{"line_number":616,"context_line":"            # Check if there are more IP allocations, unless"},{"line_number":617,"context_line":"            # is_auto_address_subnet is True. In that case the check is"},{"line_number":618,"context_line":"            # unnecessary. This additional check not only would be wasteful"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_f0221701","line":615,"in_reply_to":"9a41bdd9_41bebbae","updated":"2015-07-16 23:41:46.000000000","message":"Done","commit_id":"d1ddf560dabc0df4b231ec649e4dac62f3659790"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3c58c14ecfb54efbbde0bff8283400c7bb41d298","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                    in_(AUTO_DELETE_PORT_OWNERS)))"},{"line_number":613,"context_line":"            network_ports \u003d qry_network_ports.all()"},{"line_number":614,"context_line":"            if network_ports:"},{"line_number":615,"context_line":"                for port in network_ports:"},{"line_number":616,"context_line":"                    context.session.delete(port)"},{"line_number":617,"context_line":"            # Check if there are more IP allocations, unless"},{"line_number":618,"context_line":"            # is_auto_address_subnet is True. In that case the check is"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_f62e73a4","line":615,"updated":"2015-07-17 13:18:08.000000000","message":"why need to change this?","commit_id":"24521055df02bb2bdb0e0d984a5c101a9c0bad64"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"48999fb2ccd2c13a87b5d0c43ea1edc389c8af46","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                    in_(AUTO_DELETE_PORT_OWNERS)))"},{"line_number":613,"context_line":"            network_ports \u003d qry_network_ports.all()"},{"line_number":614,"context_line":"            if network_ports:"},{"line_number":615,"context_line":"                for port in network_ports:"},{"line_number":616,"context_line":"                    context.session.delete(port)"},{"line_number":617,"context_line":"            # Check if there are more IP allocations, unless"},{"line_number":618,"context_line":"            # is_auto_address_subnet is True. In that case the check is"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_8f901350","line":615,"in_reply_to":"9a41bdd9_f62e73a4","updated":"2015-07-17 22:45:50.000000000","message":"in py3K, map returns an iterator so execute nothing because we don\u0027t iterate on map result.\n\n2 alternatives: use list(map()) to iterate over map result, it\u0027s not really elegant as it builds a useless list or transform map in a for loop (the proposed code) which avoids to create a useless list and is more readable","commit_id":"24521055df02bb2bdb0e0d984a5c101a9c0bad64"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"05618f0e4cd3973da5d1a7fe0861cf476c31f063","unresolved":false,"context_lines":[{"line_number":846,"context_line":"        while True:"},{"line_number":847,"context_line":"            with session.begin(subtransactions\u003dTrue):"},{"line_number":848,"context_line":"                record \u003d self._get_subnet(context, id)"},{"line_number":849,"context_line":"                subnet \u003d self._make_subnet_dict(record, None)"},{"line_number":850,"context_line":"                qry_allocated \u003d (session.query(models_v2.IPAllocation)."},{"line_number":851,"context_line":"                                 filter_by(subnet_id\u003did)."},{"line_number":852,"context_line":"                                 join(models_v2.Port))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_9f739415","line":849,"range":{"start_line":849,"start_character":16,"end_line":849,"end_character":22},"updated":"2015-07-17 02:48:11.000000000","message":"please avoid conflicting with this \"subnet\" variable.","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"821d152ab9fdc3132c3ffa21a16c750841665fba","unresolved":false,"context_lines":[{"line_number":846,"context_line":"        while True:"},{"line_number":847,"context_line":"            with session.begin(subtransactions\u003dTrue):"},{"line_number":848,"context_line":"                record \u003d self._get_subnet(context, id)"},{"line_number":849,"context_line":"                subnet \u003d self._make_subnet_dict(record, None)"},{"line_number":850,"context_line":"                qry_allocated \u003d (session.query(models_v2.IPAllocation)."},{"line_number":851,"context_line":"                                 filter_by(subnet_id\u003did)."},{"line_number":852,"context_line":"                                 join(models_v2.Port))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_3ee609e9","line":849,"in_reply_to":"9a41bdd9_9f739415","updated":"2015-07-17 05:20:11.000000000","message":"Oh, I was not aware it. Thank you.","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"473d96239a1dffe80b8d310eeb8415d29ed164b4","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                # Delete all the IPAllocation that can be auto-deleted"},{"line_number":866,"context_line":"                if allocated:"},{"line_number":867,"context_line":"                    for x in allocated:"},{"line_number":868,"context_line":"                        session.delete(x)"},{"line_number":869,"context_line":"                LOG.debug(\"Ports to auto-deallocate: %s\", allocated)"},{"line_number":870,"context_line":"                # Check if there are more IP allocations, unless"},{"line_number":871,"context_line":"                # is_auto_address_subnet is True. In that case the check is"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_dddcba76","line":868,"updated":"2015-07-17 08:48:48.000000000","message":"Is this change needed? For me the map version works just fine in py3k.","commit_id":"24521055df02bb2bdb0e0d984a5c101a9c0bad64"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"45aeb534b1f19c34ad090accc857ebcb2cfb110e","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                # Delete all the IPAllocation that can be auto-deleted"},{"line_number":866,"context_line":"                if allocated:"},{"line_number":867,"context_line":"                    for x in allocated:"},{"line_number":868,"context_line":"                        session.delete(x)"},{"line_number":869,"context_line":"                LOG.debug(\"Ports to auto-deallocate: %s\", allocated)"},{"line_number":870,"context_line":"                # Check if there are more IP allocations, unless"},{"line_number":871,"context_line":"                # is_auto_address_subnet is True. In that case the check is"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_2ff2279b","line":868,"in_reply_to":"9a41bdd9_dddcba76","updated":"2015-07-17 22:55:42.000000000","message":"I think its because map in py3k will just return an iterator without executing it.","commit_id":"24521055df02bb2bdb0e0d984a5c101a9c0bad64"}],"neutron/tests/api/test_routers.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c360dddf0f0115c84d37782d2622aaae9910a16f","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            CONF.network.public_network_id)"},{"line_number":190,"context_line":"        public_subnet_id \u003d public_net_body[\u0027network\u0027][\u0027subnets\u0027][0]"},{"line_number":191,"context_line":"        self.assertIn(public_subnet_id,"},{"line_number":192,"context_line":"                      list(map(lambda x: x[\u0027subnet_id\u0027], fixed_ips)))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":195,"context_line":"    @test.idempotent_id(\u00276cc285d8-46bf-4f36-9b1a-783e3008ba79\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_33d5e9b8","line":192,"updated":"2015-07-17 00:17:06.000000000","message":"The following seems really more readable and avoid a lambda function:\n\n   [x[\u0027subnet_id\u0027] for x in fixed_ips]","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"821d152ab9fdc3132c3ffa21a16c750841665fba","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            CONF.network.public_network_id)"},{"line_number":190,"context_line":"        public_subnet_id \u003d public_net_body[\u0027network\u0027][\u0027subnets\u0027][0]"},{"line_number":191,"context_line":"        self.assertIn(public_subnet_id,"},{"line_number":192,"context_line":"                      list(map(lambda x: x[\u0027subnet_id\u0027], fixed_ips)))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":195,"context_line":"    @test.idempotent_id(\u00276cc285d8-46bf-4f36-9b1a-783e3008ba79\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_3e0b697f","line":192,"in_reply_to":"9a41bdd9_33d5e9b8","updated":"2015-07-17 05:20:11.000000000","message":"Yes, certainly.","commit_id":"ab2af01e35da3149cccfc2159a6387d548374d8c"}]}