)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shiv Haris \u003csharis@brocade.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-29 03:20:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: blueprint brocade-quantum-plugin"},{"line_number":8,"context_line":" With changes based on review comments"},{"line_number":9,"context_line":"https://blueprints.launchpad.net/quantum/+spec/brocade-quantum-plugin"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FUW0%3D","line":7,"updated":"2013-01-29 05:40:43.000000000","message":"nit: change title to something like \"Adds brocade plugin implemenation\"","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-01-29 03:20:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: blueprint brocade-quantum-plugin"},{"line_number":8,"context_line":" With changes based on review comments"},{"line_number":9,"context_line":"https://blueprints.launchpad.net/quantum/+spec/brocade-quantum-plugin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This is a NETCONF based plugin. Included here are:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FQdo%3D","line":8,"updated":"2013-01-31 04:59:02.000000000","message":"to add to Aaron\u0027s comments, keep the first line of the commit down to \u003c\u003d 50 characters per required convention.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: blueprint brocade-quantum-plugin"},{"line_number":8,"context_line":" With changes based on review comments"},{"line_number":9,"context_line":"https://blueprints.launchpad.net/quantum/+spec/brocade-quantum-plugin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This is a NETCONF based plugin. Included here are:"},{"line_number":12,"context_line":"plugin - quantum/plugins/brocade"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FUWw%3D","line":9,"updated":"2013-01-29 05:40:43.000000000","message":"blueprint brocade-quantum-plugin\n\nAdd the line above and that will automatically link you to the blueprint on launchpad.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":8,"context_line":" With changes based on review comments"},{"line_number":9,"context_line":"https://blueprints.launchpad.net/quantum/+spec/brocade-quantum-plugin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This is a NETCONF based plugin. Included here are:"},{"line_number":12,"context_line":"plugin - quantum/plugins/brocade"},{"line_number":13,"context_line":"unit tests - quantum/tests/unit/brocade"},{"line_number":14,"context_line":"sample config - etc/quantum/plugins/brocade/brocade.ini"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FUWs%3D","line":11,"updated":"2013-01-29 05:40:43.000000000","message":"Don\u0027t need 11-14","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-01-31 22:12:08 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Brocade Plugin implementation"},{"line_number":8,"context_line":"blueprint brocade-quantum-plugin"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ia8c91ba0e70d3dc7fa79e7f0e09f869542846954"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2FM70%3D","line":8,"updated":"2013-02-03 07:34:34.000000000","message":"Please add a new line after line 7","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-02-05 19:50:00 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Brocade Plugin implementation"},{"line_number":8,"context_line":"blueprint brocade-quantum-plugin"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ia8c91ba0e70d3dc7fa79e7f0e09f869542846954"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FINM%3D","line":8,"updated":"2013-02-06 09:36:06.000000000","message":"Please add a new line between line 7 and 8","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-02-05 19:50:00 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Brocade Plugin implementation"},{"line_number":8,"context_line":"blueprint brocade-quantum-plugin"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ia8c91ba0e70d3dc7fa79e7f0e09f869542846954"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAM3%2F%2FFeU%3D","line":8,"in_reply_to":"AAAAM3%2F%2FINM%3D","updated":"2013-02-07 16:28:37.000000000","message":"ok. will do.","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"}],"etc/quantum/plugins/brocade/brocade.ini":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[SWITCH]"},{"line_number":2,"context_line":"username \u003d admin"},{"line_number":3,"context_line":"password \u003d password"},{"line_number":4,"context_line":"address  \u003d 10.24.84.38"},{"line_number":5,"context_line":"port     \u003d 80"},{"line_number":6,"context_line":"ostype   \u003d NOS"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAM3%2F%2Fa54%3D","line":4,"updated":"2013-01-23 05:59:50.000000000","message":"probably don\u0027t want the default to be an actual ip.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"port     \u003d 80"},{"line_number":6,"context_line":"ostype   \u003d NOS"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#[DATABASE]"},{"line_number":9,"context_line":"#name \u003d brcd_quantum"},{"line_number":10,"context_line":"#user \u003d root"},{"line_number":11,"context_line":"#pass \u003d pass"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAM3%2F%2Fa8o%3D","line":8,"updated":"2013-01-23 05:57:17.000000000","message":"Can you please delete these","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[DATABASE]"},{"line_number":17,"context_line":"sql_connection \u003d mysql://root:pass@127.0.0.1:3306/brcd_quantum"},{"line_number":18,"context_line":"# sql_connection \u003d sqlite://"},{"line_number":19,"context_line":"# Enable the use of eventlet\u0027s db_pool for MySQL. The flags sql_min_pool_size,"},{"line_number":20,"context_line":"# sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled."}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAM3%2F%2Fa8k%3D","line":17,"updated":"2013-01-23 05:57:17.000000000","message":"Is this the default value? Will this work out of the box?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[LINUX_BRIDGE]"},{"line_number":41,"context_line":"physical_interface_mappings \u003d physnet1:em1"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAM3%2F%2Fa50%3D","line":42,"updated":"2013-01-23 05:59:50.000000000","message":"nit extra new line.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[SWITCH]"},{"line_number":2,"context_line":"username \u003d admin"},{"line_number":3,"context_line":"password \u003d password"},{"line_number":4,"context_line":"address  \u003d 10.24.84.38"},{"line_number":5,"context_line":"port     \u003d 80"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FUWk%3D","line":2,"updated":"2013-01-29 05:40:43.000000000","message":"these defaults should probably be commented out as well.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"port     \u003d 80"},{"line_number":6,"context_line":"ostype   \u003d NOS"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#[DATABASE]"},{"line_number":9,"context_line":"#name \u003d brcd_quantum"},{"line_number":10,"context_line":"#user \u003d root"},{"line_number":11,"context_line":"#pass \u003d pass"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FTqE%3D","line":8,"updated":"2013-01-29 16:54:22.000000000","message":"Please delete these comments","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[DATABASE]"},{"line_number":17,"context_line":"sql_connection \u003d mysql://root:pass@127.0.0.1:3306/brcd_quantum"},{"line_number":18,"context_line":"# sql_connection \u003d sqlite://"},{"line_number":19,"context_line":"# Enable the use of eventlet\u0027s db_pool for MySQL. The flags sql_min_pool_size,"},{"line_number":20,"context_line":"# sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled."}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FTqA%3D","line":17,"updated":"2013-01-29 16:54:22.000000000","message":"in general we do not have the actual value the user should configure them","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[PHYSICAL_INTERFACE]"},{"line_number":32,"context_line":"physical_interface \u003d physnet1"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[VLANS]"},{"line_number":35,"context_line":"network_vlan_ranges \u003d physnet1:1000:2999"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FTp8%3D","line":32,"updated":"2013-01-29 16:54:22.000000000","message":"ditto with these.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"physical_interface \u003d physnet1"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[VLANS]"},{"line_number":35,"context_line":"network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[AGENT]"},{"line_number":38,"context_line":"rpc \u003d True"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FQdk%3D","line":35,"updated":"2013-01-31 04:59:02.000000000","message":"Are the switches limited to using VLANs 1000 to 2999?","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[AGENT]"},{"line_number":38,"context_line":"rpc \u003d True"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[LINUX_BRIDGE]"},{"line_number":41,"context_line":"physical_interface_mappings \u003d physnet1:em1"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAM3%2F%2FTps%3D","line":38,"updated":"2013-01-29 16:54:22.000000000","message":"i do not think that this flag is used any more. the rpc is the only supporte method at the moment. we dropped this at the beginning of grizzly","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# Example:"},{"line_number":38,"context_line":"# network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[AGENT]"},{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FM7o%3D","line":39,"updated":"2013-02-03 07:34:34.000000000","message":"Question - do you want the agent to use this ini file or for it to continue with the linuxbridge agent ini file?","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# Example:"},{"line_number":38,"context_line":"# network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[AGENT]"},{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FMzY%3D","line":39,"in_reply_to":"AAAAM3%2F%2FM7o%3D","updated":"2013-02-04 05:37:53.000000000","message":"I do not intend to use the linux bridge ini file, I want to have all the configurations in the brocade.ini file. That way we can have a better control over all the brocade specific configuration we need.\n\nAgent will be started with --config-file ...quantum.conf --config-file ...brocade.ini (like the quantum-server)","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"# Example:"},{"line_number":38,"context_line":"# network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[AGENT]"},{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FM7w%3D","line":40,"updated":"2013-02-03 07:34:34.000000000","message":"Do you need this if the pugin is going to make use of the linux bridge agent?","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# Example:"},{"line_number":38,"context_line":"# network_vlan_ranges \u003d physnet1:1000:2999"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[AGENT]"},{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FMzU%3D","line":40,"in_reply_to":"AAAAM3%2F%2FM7w%3D","updated":"2013-02-04 05:37:53.000000000","message":"ditto","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[LINUX_BRIDGE]"},{"line_number":45,"context_line":"# physical_interface_mappings \u003d \u003cphysical network name\u003e:\u003clocal interface\u003e"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# Example:"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FM7s%3D","line":44,"updated":"2013-02-03 07:34:34.000000000","message":"This is agent specific - so I do not think that you need this.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Example:"},{"line_number":42,"context_line":"# root_helper \u003d sudo /usr/local/bin/quantum-rootwrap /etc/quantum/rootwrap.conf"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[LINUX_BRIDGE]"},{"line_number":45,"context_line":"# physical_interface_mappings \u003d \u003cphysical network name\u003e:\u003clocal interface\u003e"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# Example:"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAM3%2F%2FMzQ%3D","line":44,"in_reply_to":"AAAAM3%2F%2FM7s%3D","updated":"2013-02-04 05:37:53.000000000","message":"ditto","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"}],"quantum/plugins/brocade/.gitignore":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.pyc"},{"line_number":2,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa8g%3D","line":1,"updated":"2013-01-23 05:57:17.000000000","message":"Do we need to add this file?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.pyc"},{"line_number":2,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa5k%3D","line":1,"updated":"2013-01-23 05:59:50.000000000","message":"I don\u0027t believe having this .gitignore file does anything. *.pyc is already in the .gitignore of the repo.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.pyc"},{"line_number":2,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FaVY%3D","line":1,"in_reply_to":"AAAAM3%2F%2Fa5k%3D","updated":"2013-01-23 16:40:59.000000000","message":"Yeah this file should be dropped.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/QuantumPlugin.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAc%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"# (Some parts adapted from LinuxBridge Plugin)"},{"line_number":23,"context_line":"# TODO (shiv) need support for security groups"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"import ConfigParser"},{"line_number":26,"context_line":"import json"},{"line_number":27,"context_line":"import hashlib"},{"line_number":28,"context_line":"import logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa8E%3D","line":25,"updated":"2013-01-23 05:57:17.000000000","message":"Why not use the OpenStack cfg module.\n\nWhen the Quantum service is invoked it will receive a list of the configuration files as input for exampe --config-file /etc/quantum/quantum.conf --config-file /etc/quantum/plugins/brocade/brocade.ini","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import sys"},{"line_number":32,"context_line":"import traceback"},{"line_number":33,"context_line":"import urllib"},{"line_number":34,"context_line":"import uuid"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbA8%3D","line":34,"updated":"2013-01-23 04:44:04.000000000","message":"Should not directly import uuid. Import quantum.openstack.common.uuidutils instead.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from quantum.common import rpc as q_rpc"},{"line_number":43,"context_line":"from quantum.common import topics"},{"line_number":44,"context_line":"from quantum.common import utils"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"from quantum.db import api as db"},{"line_number":47,"context_line":"from quantum.db import api as db_api"},{"line_number":48,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAM%3D","line":45,"updated":"2013-01-23 04:44:04.000000000","message":"delete blank line","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from quantum.db import models_v2"},{"line_number":54,"context_line":"from quantum.db import quota_db"},{"line_number":55,"context_line":"from quantum.db import securitygroups_rpc_base as sg_db_rpc"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"from quantum.openstack.common import cfg"},{"line_number":58,"context_line":"from quantum.openstack.common import context"},{"line_number":59,"context_line":"from quantum.openstack.common import rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAI%3D","line":56,"updated":"2013-01-23 04:44:04.000000000","message":"delete blank line","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"from quantum.openstack.common import rpc"},{"line_number":60,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":61,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"from quantum.plugins.brocade import vlanbm as vbm"},{"line_number":64,"context_line":"from quantum.plugins.brocade.db import models as brcd_db"},{"line_number":65,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAE%3D","line":62,"updated":"2013-01-23 04:44:04.000000000","message":"delete blank line","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":63,"context_line":"from quantum.plugins.brocade import vlanbm as vbm"},{"line_number":64,"context_line":"from quantum.plugins.brocade.db import models as brcd_db"},{"line_number":65,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONFIG_FILE \u003d \"brocade.ini\""},{"line_number":68,"context_line":"CONFIG_FILE_PATH \u003d \"/etc/quantum/plugins/brocade/\""},{"line_number":69,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAQ%3D","line":66,"updated":"2013-01-23 04:44:04.000000000","message":"two blank lines after imports","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"from quantum.plugins.brocade.db import models as brcd_db"},{"line_number":65,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONFIG_FILE \u003d \"brocade.ini\""},{"line_number":68,"context_line":"CONFIG_FILE_PATH \u003d \"/etc/quantum/plugins/brocade/\""},{"line_number":69,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":70,"context_line":"PLUGIN_VERSION \u003d 0.88"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa78%3D","line":67,"updated":"2013-01-23 05:57:17.000000000","message":"If you use cfg module then you will not require these - i.e. CONFIG_FILE and CONFIG_FILE_PATH","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"AGENT_OWNER_PREFIX \u003d \"network:\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class LinuxBridgeRpcCallbacks(dhcp_rpc_base.DhcpRpcCallbackMixin,"},{"line_number":75,"context_line":"                              l3_rpc_base.L3RpcCallbackMixin,"},{"line_number":76,"context_line":"                              sg_db_rpc.SecurityGroupServerRpcCallbackMixin):"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7s%3D","line":74,"updated":"2013-01-23 05:57:17.000000000","message":"Consider changing the name of the class.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        agent_id \u003d kwargs.get(\u0027agent_id\u0027)"},{"line_number":128,"context_line":"        device \u003d kwargs.get(\u0027device\u0027)"},{"line_number":129,"context_line":"        LOG.debug(_(\"Device %(device)s no longer exists on %(agent_id)s\"),"},{"line_number":130,"context_line":"                  locals())"},{"line_number":131,"context_line":"        port \u003d self.get_port_from_device(device)"},{"line_number":132,"context_line":"        if port:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbBk%3D","line":129,"updated":"2013-01-23 04:44:04.000000000","message":"Shouldn\u0027t this line be placed after line 136?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":177,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":178,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":182,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7I%3D","line":179,"updated":"2013-01-23 05:57:17.000000000","message":"Please note that there are some extentions that are missing:\n - port bindings - required for Nova to support the plaugin\n - do you want to support:\n    - provider networks?\n    - quotas?\n    - security groups?\n    - l3 agent?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":189,"context_line":"        and db configuration."},{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        config \u003d ConfigParser.ConfigParser()"},{"line_number":192,"context_line":"        configfile \u003d CONFIG_FILE_PATH + CONFIG_FILE"},{"line_number":193,"context_line":"        LOG.debug(\"Using BQP configuration file: %s\" % configfile)"},{"line_number":194,"context_line":"        config.read(configfile)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7k%3D","line":191,"updated":"2013-01-23 05:57:17.000000000","message":"This should all be dealt with by the cfg module","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":207,"context_line":"        self._drv \u003d nos.NOSdriver()"},{"line_number":208,"context_line":"        self._vbm \u003d vbm.VlanBitmap()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        self.agent_rpc \u003d True"},{"line_number":211,"context_line":"        self._setup_rpc()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def _setup_rpc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7g%3D","line":210,"updated":"2013-01-23 05:57:17.000000000","message":"do we need this flag?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def create_network(self, context, network, policy\u003dNone):"},{"line_number":228,"context_line":"        \"\"\"This call to create network translate to creation of"},{"line_number":229,"context_line":"        port-profile on the physical switch."},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        net \u003d network[\u0027network\u0027]"},{"line_number":232,"context_line":"        tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":233,"context_line":"        network_name \u003d net[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaSY%3D","line":230,"updated":"2013-01-23 16:40:59.000000000","message":"For consistency, you should do these calls within the same transaction context and pass that context to brcd_db.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":233,"context_line":"        network_name \u003d net[\u0027name\u0027]"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        net_uuid \u003d str(uuid.uuid4())"},{"line_number":236,"context_line":"        vlan_id \u003d self._vbm.getNextVlan(None)"},{"line_number":237,"context_line":"        sw \u003d self._switch"},{"line_number":238,"context_line":"        self._drv.create_network(sw[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbA4%3D","line":235,"updated":"2013-01-23 04:44:04.000000000","message":"net_uuid \u003d uuidutils.generate_uuid()","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                     sw[\u0027username\u0027],"},{"line_number":257,"context_line":"                                     sw[\u0027password\u0027],"},{"line_number":258,"context_line":"                                     vlan_id)"},{"line_number":259,"context_line":"        except Exception as ex:"},{"line_number":260,"context_line":"            raise"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        brcd_db.delete_network(id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaYY%3D","line":259,"updated":"2013-01-23 16:40:59.000000000","message":"Actually the try/except is unnecessary since you\u0027re immediately re-raising the exception.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                     sw[\u0027username\u0027],"},{"line_number":257,"context_line":"                                     sw[\u0027password\u0027],"},{"line_number":258,"context_line":"                                     vlan_id)"},{"line_number":259,"context_line":"        except Exception as ex:"},{"line_number":260,"context_line":"            raise"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        brcd_db.delete_network(id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7c%3D","line":259,"updated":"2013-01-23 05:57:17.000000000","message":"You do not need \"as ex\" here - it is not used.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":259,"context_line":"        except Exception as ex:"},{"line_number":260,"context_line":"            raise"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        brcd_db.delete_network(id)"},{"line_number":263,"context_line":"        self._vbm.releaseVlan(int(vlan_id))"},{"line_number":264,"context_line":"        result \u003d super(BrcdPluginV2, self).delete_network(context, id)"},{"line_number":265,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaSc%3D","line":262,"updated":"2013-01-23 16:40:59.000000000","message":"For consistency, you should do these calls within the same transaction context and pass that context to brcd_db.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":269,"context_line":"        up the vlan that was configured when this network was created"},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if filters.get(\"shared\") \u003d\u003d [True]:"},{"line_number":273,"context_line":"            return []"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        nets \u003d super(BrcdPluginV2, self).get_networks(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7U%3D","line":272,"updated":"2013-01-23 05:57:17.000000000","message":"Can you please add a comment explaining this.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":272,"context_line":"        if filters.get(\"shared\") \u003d\u003d [True]:"},{"line_number":273,"context_line":"            return []"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        nets \u003d super(BrcdPluginV2, self).get_networks(context)"},{"line_number":276,"context_line":"        for net in nets:"},{"line_number":277,"context_line":"            bnet \u003d brcd_db.get_network(net[\u0027id\u0027])"},{"line_number":278,"context_line":"            net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaYE%3D","line":275,"updated":"2013-01-23 16:40:59.000000000","message":"For consistency, you should do these calls within the same transaction context and pass that context to brcd_db.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":282,"context_line":"        \"\"\"Get a specific port-profile.\"\"\""},{"line_number":283,"context_line":"        net \u003d super(BrcdPluginV2, self).get_network(context, id, None)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        bnet \u003d brcd_db.get_network(id)"},{"line_number":286,"context_line":"        net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5Q%3D","line":283,"updated":"2013-01-23 05:59:50.000000000","message":"probably should wrap this in a transaction. (283- 285)","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    def create_port(self, context, port):"},{"line_number":297,"context_line":"        \"\"\"Creat logical port on the switch.\"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        port_id \u003d str(uuid.uuid4())"},{"line_number":300,"context_line":"        port_id \u003d port_id[0:8]"},{"line_number":301,"context_line":"        port[\u0027port\u0027][\u0027id\u0027] \u003d port_id"},{"line_number":302,"context_line":"        admin_state_up \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAs%3D","line":299,"updated":"2013-01-23 04:44:04.000000000","message":"port_id \u003d uuidutils.generate_uuid()","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        physical_interface \u003d self.physical_interface"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        bnet \u003d brcd_db.get_network(network_id)"},{"line_number":312,"context_line":"        vlan_id \u003d bnet[\u0027vlan\u0027]"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaX8%3D","line":311,"updated":"2013-01-23 16:40:59.000000000","message":"311- 338 should be in same transaction.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":312,"context_line":"        vlan_id \u003d bnet[\u0027vlan\u0027]"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        try:"},{"line_number":315,"context_line":"            quantum_db \u003d super(BrcdPluginV2, self).create_port(context, port)"},{"line_number":316,"context_line":"        except Exception as e:"},{"line_number":317,"context_line":"            raise e"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa7E%3D","line":315,"updated":"2013-01-23 05:57:17.000000000","message":"consider - quantum_port instead of quantum_db","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        try:"},{"line_number":315,"context_line":"            quantum_db \u003d super(BrcdPluginV2, self).create_port(context, port)"},{"line_number":316,"context_line":"        except Exception as e:"},{"line_number":317,"context_line":"            raise e"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        network \u003d self.get_network(context, network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAk%3D","line":316,"updated":"2013-01-23 04:44:04.000000000","message":"This catches everything and just raises it again. Are you planning to add more logic to this block?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                           sw[\u0027password\u0027],"},{"line_number":330,"context_line":"                                           vlan_id,"},{"line_number":331,"context_line":"                                           mac)"},{"line_number":332,"context_line":"        p \u003d super(BrcdPluginV2, self).update_port(context,"},{"line_number":333,"context_line":"                                                  port[\"port\"][\"id\"],"},{"line_number":334,"context_line":"                                                  port_update)"},{"line_number":335,"context_line":"        p[\u0027vlan\u0027] \u003d vlan_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa64%3D","line":332,"updated":"2013-01-23 05:57:17.000000000","message":"Can you please clarify why you do the port update?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":337,"context_line":"                            vlan_id, tenant_id, admin_state_up)"},{"line_number":338,"context_line":"        return p"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def update_port(self, context, id, port):"},{"line_number":341,"context_line":"        #"},{"line_number":342,"context_line":"        # Currently this does nothing for the physical switch"},{"line_number":343,"context_line":"        # we will support this for g-vlan (in future)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa60%3D","line":340,"updated":"2013-01-23 05:57:17.000000000","message":"i think that if you do not need to make changes then you can remove these calls","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":344,"context_line":"        #"},{"line_number":345,"context_line":"        return super(BrcdPluginV2, self).update_port(context, id, port)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def delete_port(self, context, id):"},{"line_number":348,"context_line":"        brcd_db.delete_port(id)"},{"line_number":349,"context_line":"        return super(BrcdPluginV2, self).delete_port(context, id)"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXk%3D","line":347,"updated":"2013-01-23 16:40:59.000000000","message":"This should be in same transaction context.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":348,"context_line":"        brcd_db.delete_port(id)"},{"line_number":349,"context_line":"        return super(BrcdPluginV2, self).delete_port(context, id)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":352,"context_line":"        quantum_db \u003d super(BrcdPluginV2, self).get_port(context, id, fields)"},{"line_number":353,"context_line":"        return quantum_db"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa6s%3D","line":351,"updated":"2013-01-23 05:57:17.000000000","message":"ditto","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"# (Some parts adapted from LinuxBridge Plugin)"},{"line_number":23,"context_line":"# TODO (shiv) need support for security groups"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import hashlib"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSz8%3D","line":25,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"# TODO (shiv) need support for security groups"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import hashlib"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FS0E%3D","line":26,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import hashlib"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSz4%3D","line":27,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import hashlib"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzw%3D","line":28,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"import hashlib"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzs%3D","line":29,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FS0I%3D","line":30,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSz0%3D","line":31,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import sqlalchemy as sa"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FS0U%3D","line":32,"updated":"2013-01-30 04:05:22.000000000","message":"pdb should not be in production code.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import traceback"},{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import sqlalchemy as sa"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FTpo%3D","line":32,"updated":"2013-01-29 16:54:22.000000000","message":"please move this to after line 28 (HACKING rules are alpahbetical order)","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"import urllib"},{"line_number":32,"context_line":"import pdb"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import sqlalchemy as sa"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from quantum.agent import securitygroups_rpc as sg_rpc"},{"line_number":37,"context_line":"from quantum.api.v2 import attributes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzo%3D","line":34,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"import sqlalchemy as sa"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from quantum.agent import securitygroups_rpc as sg_rpc"},{"line_number":37,"context_line":"from quantum.api.v2 import attributes"},{"line_number":38,"context_line":"from quantum.common import constants as q_const"},{"line_number":39,"context_line":"from quantum.common import exceptions as q_exc"},{"line_number":40,"context_line":"from quantum.common import rpc as q_rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzU%3D","line":37,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"from quantum.agent import securitygroups_rpc as sg_rpc"},{"line_number":37,"context_line":"from quantum.api.v2 import attributes"},{"line_number":38,"context_line":"from quantum.common import constants as q_const"},{"line_number":39,"context_line":"from quantum.common import exceptions as q_exc"},{"line_number":40,"context_line":"from quantum.common import rpc as q_rpc"},{"line_number":41,"context_line":"from quantum.common import topics"},{"line_number":42,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzQ%3D","line":39,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":"from quantum.common import exceptions as q_exc"},{"line_number":40,"context_line":"from quantum.common import rpc as q_rpc"},{"line_number":41,"context_line":"from quantum.common import topics"},{"line_number":42,"context_line":"from quantum.common import utils"},{"line_number":43,"context_line":"from quantum.db import api as db"},{"line_number":44,"context_line":"from quantum.db import api as db_api"},{"line_number":45,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzc%3D","line":42,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"from quantum.common import topics"},{"line_number":42,"context_line":"from quantum.common import utils"},{"line_number":43,"context_line":"from quantum.db import api as db"},{"line_number":44,"context_line":"from quantum.db import api as db_api"},{"line_number":45,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":46,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":47,"context_line":"from quantum.db import l3_db"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzk%3D","line":44,"updated":"2013-01-30 04:05:22.000000000","message":"Why are you importing the same module twice as different names?","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":47,"context_line":"from quantum.db import l3_db"},{"line_number":48,"context_line":"from quantum.db import l3_rpc_base"},{"line_number":49,"context_line":"from quantum.db import model_base"},{"line_number":50,"context_line":"from quantum.db import models_v2"},{"line_number":51,"context_line":"from quantum.db import quota_db"},{"line_number":52,"context_line":"from quantum.db import securitygroups_rpc_base as sg_db_rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzg%3D","line":49,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":"from quantum.db import l3_db"},{"line_number":48,"context_line":"from quantum.db import l3_rpc_base"},{"line_number":49,"context_line":"from quantum.db import model_base"},{"line_number":50,"context_line":"from quantum.db import models_v2"},{"line_number":51,"context_line":"from quantum.db import quota_db"},{"line_number":52,"context_line":"from quantum.db import securitygroups_rpc_base as sg_db_rpc"},{"line_number":53,"context_line":"from quantum.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzM%3D","line":50,"updated":"2013-01-30 04:05:22.000000000","message":"unused import","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":"from quantum.openstack.common import context"},{"line_number":56,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":57,"context_line":"from quantum.openstack.common import rpc"},{"line_number":58,"context_line":"from quantum.openstack.common import uuidutils as uu_utils"},{"line_number":59,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":60,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":61,"context_line":"from quantum.plugins.brocade import vlanbm as vbm"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQdY%3D","line":58,"updated":"2013-01-31 04:59:02.000000000","message":"I believe this should go after line 60","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # function, securitygroup_rules_for_devices() needs to pass"},{"line_number":96,"context_line":"        # context to us"},{"line_number":97,"context_line":"        #"},{"line_number":98,"context_line":"        port \u003d brcd_db.get_port(context, device[cls.TAP_PREFIX_LEN:])"},{"line_number":99,"context_line":"        #"},{"line_number":100,"context_line":"        # TODO(shiv): need to extend the db model to include device owners"},{"line_number":101,"context_line":"        # make it appears that the device owner is of type network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FTpQ%3D","line":98,"updated":"2013-01-29 16:54:22.000000000","message":"I suggest that you chat with arosen about this. why not used the rpc context?","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # function, securitygroup_rules_for_devices() needs to pass"},{"line_number":96,"context_line":"        # context to us"},{"line_number":97,"context_line":"        #"},{"line_number":98,"context_line":"        port \u003d brcd_db.get_port(context, device[cls.TAP_PREFIX_LEN:])"},{"line_number":99,"context_line":"        #"},{"line_number":100,"context_line":"        # TODO(shiv): need to extend the db model to include device owners"},{"line_number":101,"context_line":"        # make it appears that the device owner is of type network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSzA%3D","line":98,"updated":"2013-01-30 04:05:22.000000000","message":"The context you\u0027re passing here is actually the from quantum.openstack.common.context module and not a context instance.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":202,"context_line":"        physical_interface_opts \u003d ["},{"line_number":203,"context_line":"            cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        cfg.CONF.register_opts(switch_opts, \"SWITCH\")"},{"line_number":206,"context_line":"        cfg.CONF.register_opts(physical_interface_opts, \"PHYSICAL_INTERFACE\")"},{"line_number":207,"context_line":"        cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyk%3D","line":205,"updated":"2013-01-30 04:05:22.000000000","message":"These options should be configured in the module and not inside of class instantiation.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":203,"context_line":"            cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        cfg.CONF.register_opts(switch_opts, \"SWITCH\")"},{"line_number":206,"context_line":"        cfg.CONF.register_opts(physical_interface_opts, \"PHYSICAL_INTERFACE\")"},{"line_number":207,"context_line":"        cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self._switch[\u0027address\u0027] \u003d cfg.CONF.SWITCH.address"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyg%3D","line":206,"updated":"2013-01-30 04:05:22.000000000","message":"ditto","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        cfg.CONF.register_opts(switch_opts, \"SWITCH\")"},{"line_number":206,"context_line":"        cfg.CONF.register_opts(physical_interface_opts, \"PHYSICAL_INTERFACE\")"},{"line_number":207,"context_line":"        cfg.CONF(project\u003d\u0027quantum\u0027)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self._switch[\u0027address\u0027] \u003d cfg.CONF.SWITCH.address"},{"line_number":210,"context_line":"        self._switch[\u0027username\u0027] \u003d cfg.CONF.SWITCH.username"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyc%3D","line":207,"updated":"2013-01-30 04:05:22.000000000","message":"Moving the option registrations outside the instance will eliminate the need for this line.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        port-profile on the physical switch."},{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        context.session.begin(subtransactions\u003dTrue)"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            net_uuid \u003d uu_utils.generate_uuid()"},{"line_number":243,"context_line":"            vlan_id \u003d self._vbm.get_next_vlan(None)"},{"line_number":244,"context_line":"            sw \u003d self._switch"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUWY%3D","line":241,"updated":"2013-01-29 05:40:43.000000000","message":"consider: if you use with  context.session.begin(subtransactions\u003dTrue): you don\u0027t need the try except: context.sessoin.rollback()","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":238,"context_line":"        port-profile on the physical switch."},{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        context.session.begin(subtransactions\u003dTrue)"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            net_uuid \u003d uu_utils.generate_uuid()"},{"line_number":243,"context_line":"            vlan_id \u003d self._vbm.get_next_vlan(None)"},{"line_number":244,"context_line":"            sw \u003d self._switch"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyY%3D","line":241,"in_reply_to":"AAAAM3%2F%2FUWY%3D","updated":"2013-01-30 04:05:22.000000000","message":"+1","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        context.session.begin(subtransactions\u003dTrue)"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            net_uuid \u003d uu_utils.generate_uuid()"},{"line_number":243,"context_line":"            vlan_id \u003d self._vbm.get_next_vlan(None)"},{"line_number":244,"context_line":"            sw \u003d self._switch"},{"line_number":245,"context_line":"            self._drv.create_network(sw[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQdQ%3D","line":242,"updated":"2013-01-31 04:59:02.000000000","message":"base plugin will generat a uuid for you, do you need to do this here?","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":271,"context_line":"                                     id)"},{"line_number":272,"context_line":"            brcd_db.delete_network(context, id)"},{"line_number":273,"context_line":"            result \u003d super(BrcdPluginV2, self).delete_network(context, id)"},{"line_number":274,"context_line":"            context.session.commit()"},{"line_number":275,"context_line":"        except:"},{"line_number":276,"context_line":"            context.session.rollback()"},{"line_number":277,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FTo4%3D","line":274,"updated":"2013-01-29 16:54:22.000000000","message":"why do we need the commit()?","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"},{"line_number":306,"context_line":"        return net"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def update_network(self, context, id, network):"},{"line_number":309,"context_line":"        \"\"\"We do nothing here for now; in future we will change the vlan,"},{"line_number":310,"context_line":"        ACL or QOS for the network."},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUWQ%3D","line":308,"updated":"2013-01-29 05:40:43.000000000","message":"perhaps call the super() class so that you can change the network name.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":305,"context_line":"        net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"},{"line_number":306,"context_line":"        return net"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def update_network(self, context, id, network):"},{"line_number":309,"context_line":"        \"\"\"We do nothing here for now; in future we will change the vlan,"},{"line_number":310,"context_line":"        ACL or QOS for the network."},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyU%3D","line":308,"in_reply_to":"AAAAM3%2F%2FUWQ%3D","updated":"2013-01-30 04:05:22.000000000","message":"Or drop this method until you plan on augmenting the builtin version.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        physical_interface \u003d self.physical_interface"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        context.session.begin(subtransactions\u003dTrue)"},{"line_number":327,"context_line":"        try:"},{"line_number":328,"context_line":"            bnet \u003d brcd_db.get_network(context, network_id)"},{"line_number":329,"context_line":"            vlan_id \u003d bnet[\u0027vlan\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyQ%3D","line":326,"updated":"2013-01-30 04:05:22.000000000","message":"with context.session.begin(subtransaction\u003dTrue) instead of try/except.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":364,"context_line":"        return p"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def delete_port(self, context, id):"},{"line_number":367,"context_line":"        context.session.begin(subtransactions\u003dTrue)"},{"line_number":368,"context_line":"        try:"},{"line_number":369,"context_line":"            brcd_db.delete_port(context, id)"},{"line_number":370,"context_line":"            super(BrcdPluginV2, self).delete_port(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyM%3D","line":367,"updated":"2013-01-30 04:05:22.000000000","message":"same as above","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":182,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":183,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":187,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM7U%3D","line":184,"updated":"2013-02-03 07:34:34.000000000","message":"Question - do you want to support bulk creation commands?","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":182,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":183,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":187,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMzM%3D","line":184,"in_reply_to":"AAAAM3%2F%2FM7U%3D","updated":"2013-02-04 05:37:53.000000000","message":"No. In which case can I safely delete the teo functions above that do fanout_cast?","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":182,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":183,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":187,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMTk%3D","line":184,"in_reply_to":"AAAAM3%2F%2FMzM%3D","updated":"2013-02-04 08:03:54.000000000","message":"No. The functions above are not used for the bulk operations. Please see https://github.com/openstack/quantum/blob/master/quantum/plugins/linuxbridge/lb_quantum_plugin.py#L189","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"            interface_mac \u003d quantum_port[\u0027mac_address\u0027]"},{"line_number":300,"context_line":"            port_id \u003d quantum_port[\u0027id\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            swtch \u003d self._switch"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM7Q%3D","line":302,"updated":"2013-02-03 07:34:34.000000000","message":"swtch - is it possible to change to switch?","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            interface_mac \u003d quantum_port[\u0027mac_address\u0027]"},{"line_number":300,"context_line":"            port_id \u003d quantum_port[\u0027id\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            swtch \u003d self._switch"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMzI%3D","line":302,"in_reply_to":"AAAAM3%2F%2FM7Q%3D","updated":"2013-02-04 05:37:53.000000000","message":"ok.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":319,"context_line":"        # apply any extensions"},{"line_number":320,"context_line":"        quantum_port[\u0027vlan\u0027] \u003d vlan_id"},{"line_number":321,"context_line":"        self._extend_port_dict_binding(context, quantum_port)"},{"line_number":322,"context_line":"        LOG.warning(\"CreatePORT done\")"},{"line_number":323,"context_line":"        return quantum_port"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM7M%3D","line":322,"updated":"2013-02-03 07:34:34.000000000","message":"Why do we need a warning here?\n\nPlease also can you make sure that the i18n format is used.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        # apply any extensions"},{"line_number":320,"context_line":"        quantum_port[\u0027vlan\u0027] \u003d vlan_id"},{"line_number":321,"context_line":"        self._extend_port_dict_binding(context, quantum_port)"},{"line_number":322,"context_line":"        LOG.warning(\"CreatePORT done\")"},{"line_number":323,"context_line":"        return quantum_port"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMzE%3D","line":322,"in_reply_to":"AAAAM3%2F%2FM7M%3D","updated":"2013-02-04 05:37:53.000000000","message":"This was for some debugging. Not needed now.\n\nI18n: Only one other place was missing, fixed.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":"    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIM4%3D","line":58,"updated":"2013-02-06 09:36:06.000000000","message":"just to be consistant with the rest of the code in tree can you please move ] to the new line","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FHw0%3D","line":58,"in_reply_to":"AAAAM3%2F%2FIM4%3D","updated":"2013-02-06 15:54:15.000000000","message":"I don\u0027t believe this qualifies as a nit. Openstack should not make these things as requirements.","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FHq8%3D","line":58,"in_reply_to":"AAAAM3%2F%2FIM4%3D","updated":"2013-02-06 17:00:26.000000000","message":"Tried moving ] this to the next line, emacs\u0027s auto-indentation does not match pep8\u0027s concept of indentation requirements. Maybe leaving the ] where it is should also be fine.","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"cfg.CONF.register_opts(SWITCH_OPTS, \"SWITCH\")"},{"line_number":64,"context_line":"cfg.CONF.register_opts(PHYSICAL_INTERFACE_OPTS, \"PHYSICAL_INTERFACE\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIM0%3D","line":61,"updated":"2013-02-06 09:36:06.000000000","message":"ditto","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":194,"context_line":"        and db configuration."},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        self._switch \u003d {}"},{"line_number":197,"context_line":"        self._switch[\u0027address\u0027] \u003d cfg.CONF.SWITCH.address"},{"line_number":198,"context_line":"        self._switch[\u0027username\u0027] \u003d cfg.CONF.SWITCH.username"},{"line_number":199,"context_line":"        self._switch[\u0027password\u0027] \u003d cfg.CONF.SWITCH.password"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIKE%3D","line":196,"updated":"2013-02-06 09:36:06.000000000","message":"Consider:\nself._switch \u003d {\u0027address\u0027: cfg.CONF.SWITCH.address,\n                        \u0027username\u0027: cfg.CONF.SWITCH.username,\n                        \u0027password\u0027: cfg.CONF.SWITCH.password}\nThen we can delete lines 197-199","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":194,"context_line":"        and db configuration."},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        self._switch \u003d {}"},{"line_number":197,"context_line":"        self._switch[\u0027address\u0027] \u003d cfg.CONF.SWITCH.address"},{"line_number":198,"context_line":"        self._switch[\u0027username\u0027] \u003d cfg.CONF.SWITCH.username"},{"line_number":199,"context_line":"        self._switch[\u0027password\u0027] \u003d cfg.CONF.SWITCH.password"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FHvw%3D","line":196,"in_reply_to":"AAAAM3%2F%2FIKE%3D","updated":"2013-02-06 17:00:26.000000000","message":"ok","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._switch[\u0027username\u0027] \u003d cfg.CONF.SWITCH.username"},{"line_number":199,"context_line":"        self._switch[\u0027password\u0027] \u003d cfg.CONF.SWITCH.password"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        self.physical_interface \u003d \\"},{"line_number":202,"context_line":"            cfg.CONF.PHYSICAL_INTERFACE.physical_interface"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIKA%3D","line":201,"updated":"2013-02-06 09:36:06.000000000","message":"Any chance of writing this without the \\","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        db.configure_db()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self._drv \u003d nos.NOSdriver()"},{"line_number":207,"context_line":"        self._vbm \u003d vbm.VlanBitmap()"},{"line_number":208,"context_line":"        self._setup_rpc()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIJs%3D","line":206,"updated":"2013-02-06 09:36:06.000000000","message":"Consider passing the _switch here as a parameter and then all usage of this will no longer need to pass the switch structure.","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        db.configure_db()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self._drv \u003d nos.NOSdriver()"},{"line_number":207,"context_line":"        self._vbm \u003d vbm.VlanBitmap()"},{"line_number":208,"context_line":"        self._setup_rpc()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FHwY%3D","line":206,"in_reply_to":"AAAAM3%2F%2FIJs%3D","updated":"2013-02-06 15:54:15.000000000","message":"This is how our internal APIs are defined. This change as suggested has a significant other repercussions for us. Do you think we should go that route? Opinion?","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":230,"context_line":"            net_uuid \u003d net[\u0027id\u0027]"},{"line_number":231,"context_line":"            vlan_id \u003d self._vbm.get_next_vlan(None)"},{"line_number":232,"context_line":"            switch \u003d self._switch"},{"line_number":233,"context_line":"            self._drv.create_network(switch[\u0027address\u0027],"},{"line_number":234,"context_line":"                                     switch[\u0027username\u0027],"},{"line_number":235,"context_line":"                                     switch[\u0027password\u0027],"},{"line_number":236,"context_line":"                                     vlan_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIJ8%3D","line":233,"updated":"2013-02-06 09:36:06.000000000","message":"If we have the _drv class with the switch structure then there is no need to pass these parameters","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            net_uuid \u003d net[\u0027id\u0027]"},{"line_number":231,"context_line":"            vlan_id \u003d self._vbm.get_next_vlan(None)"},{"line_number":232,"context_line":"            switch \u003d self._switch"},{"line_number":233,"context_line":"            self._drv.create_network(switch[\u0027address\u0027],"},{"line_number":234,"context_line":"                                     switch[\u0027username\u0027],"},{"line_number":235,"context_line":"                                     switch[\u0027password\u0027],"},{"line_number":236,"context_line":"                                     vlan_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FHv8%3D","line":233,"in_reply_to":"AAAAM3%2F%2FIJ8%3D","updated":"2013-02-06 17:00:26.000000000","message":"This is how our internal APIs are defined. This change as suggested has a significant other repercussions for us. Do you think we should go that route? Opinion?\n\nThe lower level driver (nos driver) publishes an API so others (non Openstack) can use the interface. This can have impact in other places.","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":246,"context_line":"            net \u003d brcd_db.get_network(context, net_id)"},{"line_number":247,"context_line":"            vlan_id \u003d net[\u0027vlan\u0027]"},{"line_number":248,"context_line":"            switch \u003d self._switch"},{"line_number":249,"context_line":"            self._drv.delete_network(switch[\u0027address\u0027],"},{"line_number":250,"context_line":"                                     switch[\u0027username\u0027],"},{"line_number":251,"context_line":"                                     switch[\u0027password\u0027],"},{"line_number":252,"context_line":"                                     net_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIJo%3D","line":249,"updated":"2013-02-06 09:36:06.000000000","message":"ditto","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"},{"line_number":306,"context_line":"            mac \u003d mac[0:4] + \".\" + mac[4:8] + \".\" + mac[8:12]"},{"line_number":307,"context_line":"            self._drv.associate_mac_to_network(switch[\u0027address\u0027],"},{"line_number":308,"context_line":"                                               switch[\u0027username\u0027],"},{"line_number":309,"context_line":"                                               switch[\u0027password\u0027],"},{"line_number":310,"context_line":"                                               vlan_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FIJk%3D","line":307,"updated":"2013-02-06 09:36:06.000000000","message":"ditto","commit_id":"50c1c02da3a196a911b8b997a9693522658b0134"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class BridgeRpcCallbacks(dhcp_rpc_base.DhcpRpcCallbackMixin,"},{"line_number":68,"context_line":"                         l3_rpc_base.L3RpcCallbackMixin,"},{"line_number":69,"context_line":"                         sg_db_rpc.SecurityGroupServerRpcCallbackMixin):"},{"line_number":70,"context_line":"    \"\"\"Agent callback.\"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEpw%3D","line":69,"updated":"2013-02-08 00:04:43.000000000","message":"Why rpc only supports security groups?","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class BridgeRpcCallbacks(dhcp_rpc_base.DhcpRpcCallbackMixin,"},{"line_number":68,"context_line":"                         l3_rpc_base.L3RpcCallbackMixin,"},{"line_number":69,"context_line":"                         sg_db_rpc.SecurityGroupServerRpcCallbackMixin):"},{"line_number":70,"context_line":"    \"\"\"Agent callback.\"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC1k%3D","line":69,"in_reply_to":"AAAAM3%2F%2FEpw%3D","updated":"2013-02-09 22:16:04.000000000","message":"API version 1.1 only has support for security groups.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":183,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":187,"context_line":"    \"\"\""},{"line_number":188,"context_line":"    BrcdluginV2 is a Quantum plugin that provides L2 Virtual Network"},{"line_number":189,"context_line":"    functionality using VDX."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEqE%3D","line":186,"updated":"2013-02-08 00:04:43.000000000","message":"nit: I don\u0027t prefer abbr.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BrcdPluginV2(db_base_plugin_v2.QuantumDbPluginV2):"},{"line_number":187,"context_line":"    \"\"\""},{"line_number":188,"context_line":"    BrcdluginV2 is a Quantum plugin that provides L2 Virtual Network"},{"line_number":189,"context_line":"    functionality using VDX."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEnA%3D","line":186,"in_reply_to":"AAAAM3%2F%2FEqE%3D","updated":"2013-02-09 22:16:04.000000000","message":"Take 1: This will impact changes to devstack as well (as this is the class name). Do you feel very strongly about this? Other than this, additionally  I have removed abbreviations from many other places - using your suggestion as a guiding principle.\n\nTake2: I have made this change and also applied changes to devstack and the other changes made in Take 1.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        db.configure_db()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self._drv \u003d nos.NOSdriver()"},{"line_number":207,"context_line":"        self._vbm \u003d vbm.VlanBitmap()"},{"line_number":208,"context_line":"        self._setup_rpc()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEqA%3D","line":206,"updated":"2013-02-08 00:04:43.000000000","message":"nit: i prefer _driver","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        db.configure_db()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self._drv \u003d nos.NOSdriver()"},{"line_number":207,"context_line":"        self._vbm \u003d vbm.VlanBitmap()"},{"line_number":208,"context_line":"        self._setup_rpc()"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEm8%3D","line":206,"in_reply_to":"AAAAM3%2F%2FEqA%3D","updated":"2013-02-09 22:16:04.000000000","message":"ok, will change as suggested.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":276,"context_line":"    def get_network(self, context, net_id, fields\u003dNone):"},{"line_number":277,"context_line":"        \"\"\"Get a specific port-profile.\"\"\""},{"line_number":278,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":279,"context_line":"            net \u003d super(BrcdPluginV2, self).get_network(context, net_id, None)"},{"line_number":280,"context_line":"            bnet \u003d brcd_db.get_network(context, net_id)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEa4%3D","line":279,"updated":"2013-02-08 03:59:20.000000000","message":"Why are you ignoring the fields passed in?  Seems like this should be passed too.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    def get_network(self, context, net_id, fields\u003dNone):"},{"line_number":277,"context_line":"        \"\"\"Get a specific port-profile.\"\"\""},{"line_number":278,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":279,"context_line":"            net \u003d super(BrcdPluginV2, self).get_network(context, net_id, None)"},{"line_number":280,"context_line":"            bnet \u003d brcd_db.get_network(context, net_id)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        net[\u0027vlan\u0027] \u003d bnet[\u0027vlan\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FDOk%3D","line":279,"in_reply_to":"AAAAM3%2F%2FEa4%3D","updated":"2013-02-09 22:16:04.000000000","message":"mea culpa. thanks for catching.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"},{"line_number":306,"context_line":"            mac \u003d mac[0:4] + \".\" + mac[4:8] + \".\" + mac[8:12]"},{"line_number":307,"context_line":"            self._drv.associate_mac_to_network(switch[\u0027address\u0027],"},{"line_number":308,"context_line":"                                               switch[\u0027username\u0027],"},{"line_number":309,"context_line":"                                               switch[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEpo%3D","line":306,"updated":"2013-02-08 00:04:43.000000000","message":"This should be in helper function","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"},{"line_number":306,"context_line":"            mac \u003d mac[0:4] + \".\" + mac[4:8] + \".\" + mac[8:12]"},{"line_number":307,"context_line":"            self._drv.associate_mac_to_network(switch[\u0027address\u0027],"},{"line_number":308,"context_line":"                                               switch[\u0027username\u0027],"},{"line_number":309,"context_line":"                                               switch[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC1c%3D","line":306,"in_reply_to":"AAAAM3%2F%2FEbI%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"},{"line_number":306,"context_line":"            mac \u003d mac[0:4] + \".\" + mac[4:8] + \".\" + mac[8:12]"},{"line_number":307,"context_line":"            self._drv.associate_mac_to_network(switch[\u0027address\u0027],"},{"line_number":308,"context_line":"                                               switch[\u0027username\u0027],"},{"line_number":309,"context_line":"                                               switch[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEbI%3D","line":306,"in_reply_to":"AAAAM3%2F%2FEpo%3D","updated":"2013-02-08 03:59:20.000000000","message":"+1","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            # Transform mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":305,"context_line":"            mac \u003d interface_mac.replace(\":\", \"\")"},{"line_number":306,"context_line":"            mac \u003d mac[0:4] + \".\" + mac[4:8] + \".\" + mac[8:12]"},{"line_number":307,"context_line":"            self._drv.associate_mac_to_network(switch[\u0027address\u0027],"},{"line_number":308,"context_line":"                                               switch[\u0027username\u0027],"},{"line_number":309,"context_line":"                                               switch[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC1g%3D","line":306,"in_reply_to":"AAAAM3%2F%2FEpo%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":310,"context_line":"                                               vlan_id,"},{"line_number":311,"context_line":"                                               mac)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"            port_id \u003d port_id[0:11]"},{"line_number":314,"context_line":"            # save to brcd persistent db"},{"line_number":315,"context_line":"            brcd_db.create_port(context, port_id, network_id,"},{"line_number":316,"context_line":"                                physical_interface,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEa0%3D","line":313,"updated":"2013-02-08 03:59:20.000000000","message":"What is the purpose of truncating port_id value here?  Seems like this should be done in brcd_db.create_port.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                                               vlan_id,"},{"line_number":311,"context_line":"                                               mac)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"            port_id \u003d port_id[0:11]"},{"line_number":314,"context_line":"            # save to brcd persistent db"},{"line_number":315,"context_line":"            brcd_db.create_port(context, port_id, network_id,"},{"line_number":316,"context_line":"                                physical_interface,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FCqs%3D","line":313,"in_reply_to":"AAAAM3%2F%2FEa0%3D","updated":"2013-02-09 22:16:04.000000000","message":"done. Also added comments saying why this is needed.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCVA%3D","line":56,"updated":"2013-02-10 09:32:18.000000000","message":"SWITCH_OPTS \u003d [\n    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)\n]\n\nThis should pass the pep8","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FApU%3D","line":56,"in_reply_to":"AAAAM3%2F%2FCVA%3D","updated":"2013-02-13 06:14:25.000000000","message":"How about this?\n\nSWITCH_OPTS \u003d [\n    cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027username\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027password\u0027, default\u003d\u0027\u0027),\n    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)\n    ]\n\nThis passes both emacs and pep8","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"cfg.CONF.register_opts(SWITCH_OPTS, \"SWITCH\")"},{"line_number":62,"context_line":"cfg.CONF.register_opts(PHYSICAL_INTERFACE_OPTS, \"PHYSICAL_INTERFACE\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCU8%3D","line":59,"updated":"2013-02-10 09:32:18.000000000","message":"PHYSICAL_INTERFACE_OPTS \u003d [\n    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)\n]\nThis should pass pep8","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.StrOpt(\u0027ostype\u0027, default\u003d\u0027NOS\u0027)]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"PHYSICAL_INTERFACE_OPTS \u003d ["},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027physical_interface\u0027, default\u003d\u0027eth0\u0027)]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"cfg.CONF.register_opts(SWITCH_OPTS, \"SWITCH\")"},{"line_number":62,"context_line":"cfg.CONF.register_opts(PHYSICAL_INTERFACE_OPTS, \"PHYSICAL_INTERFACE\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FApE%3D","line":59,"in_reply_to":"AAAAM3%2F%2FCU8%3D","updated":"2013-02-13 06:14:25.000000000","message":"same comment as above.","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":197,"context_line":"                        \u0027password\u0027: cfg.CONF.SWITCH.password"},{"line_number":198,"context_line":"                        }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.physical_interface \u003d \\"},{"line_number":201,"context_line":"            cfg.CONF.PHYSICAL_INTERFACE.physical_interface"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCU4%3D","line":200,"updated":"2013-02-10 09:32:18.000000000","message":"Can we please try and write this without the \\\nFor example:\n        self.physical_interface \u003d (cfg.CONF.PHYSICAL_INTERFACE.\n                                   physical_interface)","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                        \u0027password\u0027: cfg.CONF.SWITCH.password"},{"line_number":198,"context_line":"                        }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.physical_interface \u003d \\"},{"line_number":201,"context_line":"            cfg.CONF.PHYSICAL_INTERFACE.physical_interface"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FApo%3D","line":200,"in_reply_to":"AAAAM3%2F%2FCU4%3D","updated":"2013-02-13 06:14:25.000000000","message":"Done","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":47,"context_line":"from quantum.plugins.brocade import vlanbm as vbm"},{"line_number":48,"context_line":"from quantum.plugins.brocade.db import models as brocade_db"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"PLUGIN_VERSION \u003d 0.88"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9RA%3D","line":49,"updated":"2013-02-13 08:47:47.000000000","message":"missing (please see comments later on in file)\nfrom quantum import policy","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":47,"context_line":"from quantum.plugins.brocade import vlanbm as vbm"},{"line_number":48,"context_line":"from quantum.plugins.brocade.db import models as brocade_db"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":52,"context_line":"PLUGIN_VERSION \u003d 0.88"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8xA%3D","line":49,"in_reply_to":"AAAAM3%2F%2B9RA%3D","updated":"2013-02-14 07:01:54.000000000","message":"Maybe you are pointing to the last two - and it is mis-ordered based on the Q-import policy. The brocade two should be swapped.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.fanout_cast(context,"},{"line_number":183,"context_line":"                         self.make_msg(\u0027port_update\u0027,"},{"line_number":184,"context_line":"                                       port\u003dport,"},{"line_number":185,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":186,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":187,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9QE%3D","line":185,"updated":"2013-02-13 08:47:47.000000000","message":"This is a bit fishy - the linux bridge will use this interface for the bridge creation. Not sure how this will would if you are passing in a different interface.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.fanout_cast(context,"},{"line_number":183,"context_line":"                         self.make_msg(\u0027port_update\u0027,"},{"line_number":184,"context_line":"                                       port\u003dport,"},{"line_number":185,"context_line":"                                       physical_network\u003dphysical_network,"},{"line_number":186,"context_line":"                                       vlan_id\u003dvlan_id),"},{"line_number":187,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B7Mc%3D","line":185,"in_reply_to":"AAAAM3%2F%2B9QE%3D","updated":"2013-02-14 07:01:54.000000000","message":"Dont have a good answer for this. The actual setup should match the configuration. This should be documented.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":202,"context_line":"        and db configuration."},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self._switch \u003d {\u0027address\u0027: cfg.CONF.SWITCH.address,"},{"line_number":208,"context_line":"                        \u0027username\u0027: cfg.CONF.SWITCH.username,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Qw%3D","line":205,"updated":"2013-02-13 08:47:47.000000000","message":"Missing \"binding\" - this is for the vif binding extension\n\nYou will aslo need to add:\n    binding_view \u003d \"extension:port_binding:view\"\n    binding_set \u003d \"extension:port_binding:set\"","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        and db configuration."},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self._switch \u003d {\u0027address\u0027: cfg.CONF.SWITCH.address,"},{"line_number":208,"context_line":"                        \u0027username\u0027: cfg.CONF.SWITCH.username,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8wU%3D","line":205,"in_reply_to":"AAAAM3%2F%2B9Qw%3D","updated":"2013-02-14 07:01:54.000000000","message":"Done","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self._switch \u003d {\u0027address\u0027: cfg.CONF.SWITCH.address,"},{"line_number":208,"context_line":"                        \u0027username\u0027: cfg.CONF.SWITCH.username,"},{"line_number":209,"context_line":"                        \u0027password\u0027: cfg.CONF.SWITCH.password"},{"line_number":210,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9P0%3D","line":207,"updated":"2013-02-13 08:47:47.000000000","message":"Consider having the brocade specific code in a an init function of its own - then it will be easier to just mock that function instead of having to do the entire init function.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self._switch \u003d {\u0027address\u0027: cfg.CONF.SWITCH.address,"},{"line_number":208,"context_line":"                        \u0027username\u0027: cfg.CONF.SWITCH.username,"},{"line_number":209,"context_line":"                        \u0027password\u0027: cfg.CONF.SWITCH.password"},{"line_number":210,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8sE%3D","line":207,"in_reply_to":"AAAAM3%2F%2B9P0%3D","updated":"2013-02-14 07:01:54.000000000","message":"Done","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.ctxt.session \u003d db.get_session()"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        self._driver \u003d importutils.import_object(NOS_DRIVER)"},{"line_number":219,"context_line":"        self._vlan_bitmap \u003d vbm.VlanBitmap(self.ctxt)"},{"line_number":220,"context_line":"        self._setup_rpc()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _setup_rpc(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Pw%3D","line":219,"updated":"2013-02-13 08:47:47.000000000","message":"Why does this need the context? Why not do that internally in the VLAN code","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.ctxt.session \u003d db.get_session()"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        self._driver \u003d importutils.import_object(NOS_DRIVER)"},{"line_number":219,"context_line":"        self._vlan_bitmap \u003d vbm.VlanBitmap(self.ctxt)"},{"line_number":220,"context_line":"        self._setup_rpc()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _setup_rpc(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8zU%3D","line":219,"in_reply_to":"AAAAM3%2F%2B9Pw%3D","updated":"2013-02-14 07:01:54.000000000","message":"Context is need to look up the database of allocated vlans at startup (allocated from a previous run of the quantum plugin) - assuming openstack crashed/restarted the new vlans allocated will match the world of the physical switch. This assumes that the db is not wiped clean at startup of openstack-quantum.\n\nIt would be very disruptive to power cycle the switch.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   vlan_id, tenant_id, admin_state_up)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # apply any extensions"},{"line_number":319,"context_line":"        quantum_port \u003d self._extend_port_dict_binding(context, quantum_port)"},{"line_number":320,"context_line":"        return quantum_port"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Qs%3D","line":319,"updated":"2013-02-13 08:47:47.000000000","message":"you can just do return self._extend_port_dict_binding(context, quantum_port)","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   vlan_id, tenant_id, admin_state_up)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # apply any extensions"},{"line_number":319,"context_line":"        quantum_port \u003d self._extend_port_dict_binding(context, quantum_port)"},{"line_number":320,"context_line":"        return quantum_port"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete_port(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8zQ%3D","line":319,"in_reply_to":"AAAAM3%2F%2B9Qs%3D","updated":"2013-02-14 07:01:54.000000000","message":"Done","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":365,"context_line":"            port \u003d super(BrocadePluginV2, self).get_port("},{"line_number":366,"context_line":"                context, port_id, fields)"},{"line_number":367,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":368,"context_line":"            if context.is_admin:"},{"line_number":369,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        return self._fields(port, fields)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Qo%3D","line":368,"updated":"2013-02-13 08:47:47.000000000","message":"This line (line 368) is not needed - this check is done in the extend_port_dict code","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            port \u003d super(BrocadePluginV2, self).get_port("},{"line_number":366,"context_line":"                context, port_id, fields)"},{"line_number":367,"context_line":"            self._extend_port_dict_security_group(context, port)"},{"line_number":368,"context_line":"            if context.is_admin:"},{"line_number":369,"context_line":"                self._extend_port_dict_binding(context, port)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        return self._fields(port, fields)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8zA%3D","line":368,"in_reply_to":"AAAAM3%2F%2B9Qo%3D","updated":"2013-02-14 07:01:54.000000000","message":"ok","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":378,"context_line":"                                                           fields)"},{"line_number":379,"context_line":"            for port in ports:"},{"line_number":380,"context_line":"                self._extend_port_dict_security_group(context, port)"},{"line_number":381,"context_line":"                if context.is_admin:"},{"line_number":382,"context_line":"                    self._extend_port_dict_binding(context, port)"},{"line_number":383,"context_line":"                res_ports.append(self._fields(port, fields))"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Qg%3D","line":381,"updated":"2013-02-13 08:47:47.000000000","message":"ditto","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                                                           fields)"},{"line_number":379,"context_line":"            for port in ports:"},{"line_number":380,"context_line":"                self._extend_port_dict_security_group(context, port)"},{"line_number":381,"context_line":"                if context.is_admin:"},{"line_number":382,"context_line":"                    self._extend_port_dict_binding(context, port)"},{"line_number":383,"context_line":"                res_ports.append(self._fields(port, fields))"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8y8%3D","line":381,"in_reply_to":"AAAAM3%2F%2B9Qg%3D","updated":"2013-02-14 07:01:54.000000000","message":"ok","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.notifier.port_update(context, port,"},{"line_number":391,"context_line":"                                  bport.physical_interface,"},{"line_number":392,"context_line":"                                  bport.vlan_id)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":395,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":396,"context_line":"        port[\u0027binding:vif_type\u0027] \u003d portbindings.VIF_TYPE_BRIDGE"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9QY%3D","line":393,"updated":"2013-02-13 08:47:47.000000000","message":"You need to add:\n\n    def _check_view_auth(self, context, resource, action):\n        return policy.check(context, action, resource)","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.notifier.port_update(context, port,"},{"line_number":391,"context_line":"                                  bport.physical_interface,"},{"line_number":392,"context_line":"                                  bport.vlan_id)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":395,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":396,"context_line":"        port[\u0027binding:vif_type\u0027] \u003d portbindings.VIF_TYPE_BRIDGE"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B7MQ%3D","line":393,"in_reply_to":"AAAAM3%2F%2B9QY%3D","updated":"2013-02-14 07:01:54.000000000","message":"Done","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":391,"context_line":"                                  bport.physical_interface,"},{"line_number":392,"context_line":"                                  bport.vlan_id)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":395,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":396,"context_line":"        port[\u0027binding:vif_type\u0027] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":397,"context_line":"        port[portbindings.CAPABILITIES] \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9QU%3D","line":394,"updated":"2013-02-13 08:47:47.000000000","message":"Code should be:\n\n     def _extend_port_dict_binding(self, context, port):\n        if self._check_view_auth(context, port, self.binding_view):\n            port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_BRIDGE\n            port[portbindings.CAPABILITIES] \u003d {\n                portbindings.CAP_PORT_FILTER:\n                \u0027security-group\u0027 in self.supported_extension_aliases}\n         return port","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                                  bport.physical_interface,"},{"line_number":392,"context_line":"                                  bport.vlan_id)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":395,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":396,"context_line":"        port[\u0027binding:vif_type\u0027] \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":397,"context_line":"        port[portbindings.CAPABILITIES] \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B7MM%3D","line":394,"in_reply_to":"AAAAM3%2F%2B9QU%3D","updated":"2013-02-14 07:01:54.000000000","message":"Done","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":203,"context_line":"        and db configuration."},{"line_number":204,"context_line":"        \"\"\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":207,"context_line":"        self.binding_view \u003d \"extension:port_binding:view\""},{"line_number":208,"context_line":"        self.binding_set \u003d \"extension:port_binding:set\""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2B7Jk%3D","line":206,"updated":"2013-02-14 09:03:58.000000000","message":"Please add \"binding\".","commit_id":"e50f5dae8f92ecd42932a023b3ff13b6ee4ac7f8"}],"quantum/plugins/brocade/README":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":73,"context_line":"the configuration file specified in the brocade.ini files:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        % cat /etc/quantum/plugins/brocade/brocade.ini"},{"line_number":76,"context_line":"        "},{"line_number":77,"context_line":"        [SWITCH]"},{"line_number":78,"context_line":"        username \u003d admin"},{"line_number":79,"context_line":"        password \u003d password"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa5M%3D","line":76,"updated":"2013-01-23 05:59:50.000000000","message":"nit whitespaces in this file.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":73,"context_line":"the configuration file specified in the brocade.ini files:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        % cat /etc/quantum/plugins/brocade/brocade.ini"},{"line_number":76,"context_line":"        "},{"line_number":77,"context_line":"        [SWITCH]"},{"line_number":78,"context_line":"        username \u003d admin"},{"line_number":79,"context_line":"        password \u003d password"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa6o%3D","line":76,"updated":"2013-01-23 05:57:17.000000000","message":"whitespace","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":"        password \u003d password"},{"line_number":80,"context_line":"        address  \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":81,"context_line":"        ostype   \u003d NOS"},{"line_number":82,"context_line":"        "},{"line_number":83,"context_line":"        [DATABASE]"},{"line_number":84,"context_line":"        sql_connection \u003d mysql://root:pass@localhost/brcd_quantum?charset\u003dutf8"},{"line_number":85,"context_line":"        "}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa6k%3D","line":82,"updated":"2013-01-23 05:57:17.000000000","message":"whitesopace","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"        "},{"line_number":83,"context_line":"        [DATABASE]"},{"line_number":84,"context_line":"        sql_connection \u003d mysql://root:pass@localhost/brcd_quantum?charset\u003dutf8"},{"line_number":85,"context_line":"        "},{"line_number":86,"context_line":"        (please see list of more configuration parameters in the brocade.ini file)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Running Setup.py"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fa6g%3D","line":85,"updated":"2013-01-23 05:57:17.000000000","message":"whitespace","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/README.md":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Brocade Openstack Quantum Plugin"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* up-to-date version of these instructions are located at:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAM3%2F%2FaVU%3D","line":1,"updated":"2013-01-23 16:40:59.000000000","message":"Why do we have the same README in both text and markdown?  The markdown version is readable enough.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":72,"context_line":"the configuration file specified in the brocade.ini files:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        % cat /etc/quantum/plugins/brocade/brocade.ini"},{"line_number":75,"context_line":"        "},{"line_number":76,"context_line":"        [SWITCH]"},{"line_number":77,"context_line":"        username \u003d admin"},{"line_number":78,"context_line":"        password \u003d password"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAM3%2F%2Fa5I%3D","line":75,"updated":"2013-01-23 05:59:50.000000000","message":"ditto.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"the configuration file specified in the brocade.ini files:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        % cat /etc/quantum/plugins/brocade/brocade.ini"},{"line_number":75,"context_line":"        "},{"line_number":76,"context_line":"        [SWITCH]"},{"line_number":77,"context_line":"        username \u003d admin"},{"line_number":78,"context_line":"        password \u003d password"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAM3%2F%2Fa6c%3D","line":75,"updated":"2013-01-23 05:57:17.000000000","message":"white space","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":"        password \u003d password"},{"line_number":79,"context_line":"        address  \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":80,"context_line":"        ostype   \u003d NOS"},{"line_number":81,"context_line":"        "},{"line_number":82,"context_line":"        [DATABASE]"},{"line_number":83,"context_line":"        sql_connection \u003d mysql://root:pass@localhost/brcd_quantum?charset\u003dutf8"},{"line_number":84,"context_line":"        "}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAM3%2F%2Fa6Y%3D","line":81,"updated":"2013-01-23 05:57:17.000000000","message":"whitespace","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":"        "},{"line_number":82,"context_line":"        [DATABASE]"},{"line_number":83,"context_line":"        sql_connection \u003d mysql://root:pass@localhost/brcd_quantum?charset\u003dutf8"},{"line_number":84,"context_line":"        "},{"line_number":85,"context_line":"        (please see list of more configuration parameters in the brocade.ini file)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Running Setup.py"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"AAAAM3%2F%2Fa6U%3D","line":84,"updated":"2013-01-23 05:57:17.000000000","message":"whitespace","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   1. VDX 67xx series of switches"},{"line_number":17,"context_line":"   2. VDX 87xx series of switches"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Brocade Quantum plugin implements the Quantum v2.0 API. It uses NETCONF at the backend"},{"line_number":20,"context_line":"to configure the Brocade switch."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"AAAAM3%2F%2FEpk%3D","line":18,"updated":"2013-02-08 00:04:43.000000000","message":"Could you add this summary on the commit message?","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   1. VDX 67xx series of switches"},{"line_number":17,"context_line":"   2. VDX 87xx series of switches"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Brocade Quantum plugin implements the Quantum v2.0 API. It uses NETCONF at the backend"},{"line_number":20,"context_line":"to configure the Brocade switch."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"AAAAM3%2F%2FEkg%3D","line":18,"in_reply_to":"AAAAM3%2F%2FEpk%3D","updated":"2013-02-09 22:16:04.000000000","message":"I had more description before, Aaron did not want to see that message. I can add this in the commit message but I feel someone else may not like it. I\u0027ll add it and wait for further comments.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"(this paragraph is relevant ONLY if you have download the Brocade Quantum Plugin from:"},{"line_number":37,"context_line":"http://www.github.com/brocade/brocade, if this came to you as part of openstack-quantum"},{"line_number":38,"context_line":"you can ignore this)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Normally you will have your Openstack directory structure as follows:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"AAAAM3%2F%2FEpY%3D","line":38,"updated":"2013-02-08 00:04:43.000000000","message":"if so, could you remove this part?","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"(this paragraph is relevant ONLY if you have download the Brocade Quantum Plugin from:"},{"line_number":37,"context_line":"http://www.github.com/brocade/brocade, if this came to you as part of openstack-quantum"},{"line_number":38,"context_line":"you can ignore this)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Normally you will have your Openstack directory structure as follows:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"AAAAM3%2F%2FEik%3D","line":38,"in_reply_to":"AAAAM3%2F%2FEpY%3D","updated":"2013-02-09 22:16:04.000000000","message":"ok","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"}],"quantum/plugins/brocade/config/brocade.ini":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"port     \u003d 80"},{"line_number":6,"context_line":"ostype   \u003d NOS"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#[DATABASE]"},{"line_number":9,"context_line":"#name \u003d brcd_quantum"},{"line_number":10,"context_line":"#user \u003d root"},{"line_number":11,"context_line":"#pass \u003d pass"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAM3%2F%2Fa6Q%3D","line":8,"updated":"2013-01-23 05:57:17.000000000","message":"i think you can delete this","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/db/__init__.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAg%3D","line":2,"updated":"2013-01-23 04:44:04.000000000","message":"# Copyright 2013 Brocade Communications System, Inc.\n\n# All rights reserved.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/db/models.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":5,"context_line":"# All rights reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAY%3D","line":4,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Shiv Haris (sharis@brocade.com)"},{"line_number":21,"context_line":"# Varma Bhupatiraju (vbhupati@#brocade.com)"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"import logging"},{"line_number":24,"context_line":"import sqlalchemy as sa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.db import api as db"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa6M%3D","line":23,"updated":"2013-01-23 05:57:17.000000000","message":"please use the common logging","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from quantum.db import api as db"},{"line_number":27,"context_line":"from quantum.db import model_base"},{"line_number":28,"context_line":"from quantum.db import models_v2"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbAU%3D","line":29,"updated":"2013-01-23 04:44:04.000000000","message":"two blank lines after imports","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Brcd_Network(model_base.BASEV2):"},{"line_number":34,"context_line":"    id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":35,"context_line":"    vlan \u003d sa.Column(sa.String(10))"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5A%3D","line":33,"updated":"2013-01-23 05:59:50.000000000","message":"Brcd_Network should extend models_v2.HasId and then remove line 34.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"    vlan \u003d sa.Column(sa.String(10))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def create_network(id, vlan):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    session \u003d db.get_session()"},{"line_number":41,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWk%3D","line":38,"updated":"2013-01-23 16:40:59.000000000","message":"Should accept the callers context and use that session and not create a new one from the database.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":"    return net"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def delete_network(id):"},{"line_number":51,"context_line":"    session \u003d db.get_session()"},{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        net \u003d (session.query(Brcd_Network).filter_by(id\u003did).one())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWc%3D","line":50,"updated":"2013-01-23 16:40:59.000000000","message":"same as above.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"net_id: %s\" % id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def get_network(id):"},{"line_number":62,"context_line":"    session \u003d db.get_session()"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        return (session.query(Brcd_Network)."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaVs%3D","line":61,"updated":"2013-01-23 16:40:59.000000000","message":"same","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        return (session.query(Brcd_Network)."},{"line_number":65,"context_line":"                filter_by(id\u003did)."},{"line_number":66,"context_line":"                one())"},{"line_number":67,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":68,"context_line":"        return None"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaVo%3D","line":66,"updated":"2013-01-23 16:40:59.000000000","message":"You should use first() instead of one().  If nothing is round first() returns None.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return None"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def get_networks():"},{"line_number":72,"context_line":"    session \u003d db.get_session()"},{"line_number":73,"context_line":"    try:"},{"line_number":74,"context_line":"        nets \u003d session.query(Brcd_Network).all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWM%3D","line":71,"updated":"2013-01-23 16:40:59.000000000","message":"same","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"        nets \u003d session.query(Brcd_Network).all()"},{"line_number":75,"context_line":"        return nets"},{"line_number":76,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":77,"context_line":"        return None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class Brcd_Port(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWA%3D","line":77,"updated":"2013-01-23 16:40:59.000000000","message":".all()  will return an empty list if no results are found.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class Brcd_Port(model_base.BASEV2):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":83,"context_line":"    network_id \u003d sa.Column(sa.String(36))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXg%3D","line":80,"updated":"2013-01-23 16:40:59.000000000","message":"For consistency with the rest of the code base, please put all models at the top of the file.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class Brcd_Port(model_base.BASEV2):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":83,"context_line":"    network_id \u003d sa.Column(sa.String(36))"},{"line_number":84,"context_line":"    admin_state_up \u003d sa.Column(sa.String(36))"},{"line_number":85,"context_line":"    physical_interface \u003d sa.Column(sa.String(36))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXc%3D","line":82,"updated":"2013-01-23 16:40:59.000000000","message":"Shouldn\u0027t this have an foreign key relationship to Port model?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":80,"context_line":"class Brcd_Port(model_base.BASEV2):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":83,"context_line":"    network_id \u003d sa.Column(sa.String(36))"},{"line_number":84,"context_line":"    admin_state_up \u003d sa.Column(sa.String(36))"},{"line_number":85,"context_line":"    physical_interface \u003d sa.Column(sa.String(36))"},{"line_number":86,"context_line":"    vlan_id \u003d sa.Column(sa.String(36))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXQ%3D","line":83,"updated":"2013-01-23 16:40:59.000000000","message":"This should have an FK relationship to Network.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":87,"context_line":"    tenant_id \u003d sa.Column(sa.String(36))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def create_port(port_id, network_id, physical_interface,"},{"line_number":91,"context_line":"                vlan_id, tenant_id, admin_state_up):"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWs%3D","line":90,"updated":"2013-01-23 16:40:59.000000000","message":"You should accept the context here, so that the transaction context is shared.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":101,"context_line":"                         tenant_id\u003dtenant_id)"},{"line_number":102,"context_line":"        session.add(port)"},{"line_number":103,"context_line":"        session.flush()"},{"line_number":104,"context_line":"    except Exception as ex:"},{"line_number":105,"context_line":"        raise"},{"line_number":106,"context_line":"    return port"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaVc%3D","line":104,"updated":"2013-01-23 16:40:59.000000000","message":"unless you\u0027re actively handling the exception, you should not wrap try/except.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":"    return port"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def get_port(port_id):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    session \u003d db.get_session()"},{"line_number":112,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaW0%3D","line":109,"updated":"2013-01-23 16:40:59.000000000","message":"You should pass the context from the caller here, so that the session can be shared.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    session \u003d db.get_session()"},{"line_number":112,"context_line":"    try:"},{"line_number":113,"context_line":"        x \u003d (session.query(Brcd_Port)."},{"line_number":114,"context_line":"             filter_by(port_id\u003dport_id)."},{"line_number":115,"context_line":"             one())"},{"line_number":116,"context_line":"        return (session.query(Brcd_Port)."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXI%3D","line":113,"updated":"2013-01-23 16:40:59.000000000","message":"Why run the query twice?\n\nreturn (session.query(Brcd_Port).filter_by(port_id\u003dport_id).one())","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":115,"context_line":"             one())"},{"line_number":116,"context_line":"        return (session.query(Brcd_Port)."},{"line_number":117,"context_line":"                filter_by(port_id\u003dport_id)."},{"line_number":118,"context_line":"                one())"},{"line_number":119,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":120,"context_line":"        return None"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaVk%3D","line":118,"updated":"2013-01-23 16:40:59.000000000","message":"one() -\u003e first()","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"                filter_by(port_id\u003dport_id)."},{"line_number":118,"context_line":"                one())"},{"line_number":119,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":120,"context_line":"        return None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    return None"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXE%3D","line":120,"updated":"2013-01-23 16:40:59.000000000","message":"return None is not needed.  Use pass","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":119,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":120,"context_line":"        return None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    return None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"def delete_port(port_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaXA%3D","line":122,"updated":"2013-01-23 16:40:59.000000000","message":"You can drop this.  All methods that return without an explicit return value return None.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":122,"context_line":"    return None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"def delete_port(port_id):"},{"line_number":126,"context_line":"    session \u003d db.get_session()"},{"line_number":127,"context_line":"    try:"},{"line_number":128,"context_line":"        port \u003d (session.query(Brcd_Port).filter_by(port_id\u003dport_id).one())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaWo%3D","line":125,"updated":"2013-01-23 16:40:59.000000000","message":"same note about context.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"def create_network(context, id, vlan):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    session \u003d context.session"},{"line_number":39,"context_line":"    session.begin(subtransactions\u003dTrue)"},{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        net \u003d Brcd_Network(id\u003did, vlan\u003dvlan)"},{"line_number":42,"context_line":"        session.add(net)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyI%3D","line":39,"updated":"2013-01-30 04:05:22.000000000","message":"replace 38-40:\n\nwith context.session.begin(subtransactions\u003dTrue):","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def delete_network(context, id):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    session \u003d context.session"},{"line_number":52,"context_line":"    session.begin(subtransactions\u003dTrue)"},{"line_number":53,"context_line":"    try:"},{"line_number":54,"context_line":"        net \u003d (session.query(Brcd_Network).filter_by(id\u003did)."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSyA%3D","line":51,"updated":"2013-01-30 04:05:22.000000000","message":"same as above","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return None"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class Brcd_Port(model_base.BASEV2):"},{"line_number":82,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":83,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"brcd_networks.id\"),"},{"line_number":84,"context_line":"                           nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSx8%3D","line":81,"updated":"2013-01-30 04:05:22.000000000","message":"For consistency, please move the models to the top of this file.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class Brcd_Port(model_base.BASEV2):"},{"line_number":82,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue, default\u003d\"\")"},{"line_number":83,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"brcd_networks.id\"),"},{"line_number":84,"context_line":"                           nullable\u003dFalse)"},{"line_number":85,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSek%3D","line":82,"updated":"2013-01-30 04:05:22.000000000","message":"Is this port_id the same as a Quantum port_id?  Should there be a foreign key relationship?  If so, you can use cascading and not need to explicitly delete this port latter.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         admin_state_up\u003dadmin_state_up,"},{"line_number":101,"context_line":"                         tenant_id\u003dtenant_id)"},{"line_number":102,"context_line":"        session.add(port)"},{"line_number":103,"context_line":"        session.flush()"},{"line_number":104,"context_line":"    except sa.exc.SQLAlchemyError:"},{"line_number":105,"context_line":"        raise"},{"line_number":106,"context_line":"    return port"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSeo%3D","line":103,"updated":"2013-01-30 04:05:22.000000000","message":"Why the explicit flush.  Seem the implicit transaction handling by the caller should suffice.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":115,"context_line":"    return port"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def delete_port(context, port_id):"},{"line_number":119,"context_line":"    session \u003d context.session"},{"line_number":120,"context_line":"    try:"},{"line_number":121,"context_line":"        port \u003d (session.query(Brcd_Port).filter_by(port_id\u003dport_id).one())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSeg%3D","line":118,"updated":"2013-01-30 04:05:22.000000000","message":"See note about possible use of cascade above.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from quantum.db import model_base"},{"line_number":29,"context_line":"from quantum.db import models_v2"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM7E%3D","line":30,"updated":"2013-02-03 07:34:34.000000000","message":"this is not used","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from quantum.db import model_base"},{"line_number":29,"context_line":"from quantum.db import models_v2"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMzA%3D","line":30,"in_reply_to":"AAAAM3%2F%2FM7E%3D","updated":"2013-02-04 05:37:53.000000000","message":"wanted to leave this in for future work and debugging efforts. When someone does add logging we have the right framework in place. I dont believe this should be an issue? Anyways removing it.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.db import models_v2"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class BrcdNetwork(model_base.BASEV2, models_v2.HasId):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM68%3D","line":32,"updated":"2013-02-03 07:34:34.000000000","message":"this is not used","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.db import models_v2"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class BrcdNetwork(model_base.BASEV2, models_v2.HasId):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMy8%3D","line":32,"in_reply_to":"AAAAM3%2F%2FM68%3D","updated":"2013-02-04 05:37:53.000000000","message":"removed\n(would have changed this to __name__)","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.db import models_v2"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(\"BrocadeQuantumAgent\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class BrcdNetwork(model_base.BASEV2, models_v2.HasId):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMTg%3D","line":32,"in_reply_to":"AAAAM3%2F%2FMy8%3D","updated":"2013-02-04 08:03:54.000000000","message":"ok, even better :)","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    session \u003d context.session"},{"line_number":63,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":64,"context_line":"        net \u003d (session.query(BrcdNetwork).filter_by(id\u003dnet_id)."},{"line_number":65,"context_line":"               one())"},{"line_number":66,"context_line":"        session.delete(net)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEac%3D","line":64,"updated":"2013-02-08 03:59:20.000000000","message":"lines 64\u002665 should all fit on one line.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    session \u003d context.session"},{"line_number":63,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":64,"context_line":"        net \u003d (session.query(BrcdNetwork).filter_by(id\u003dnet_id)."},{"line_number":65,"context_line":"               one())"},{"line_number":66,"context_line":"        session.delete(net)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC6c%3D","line":64,"in_reply_to":"AAAAM3%2F%2FEac%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"def get_network(context, net_id):"},{"line_number":72,"context_line":"    \"\"\"Get brcd specific network, with vlan extension.\"\"\""},{"line_number":73,"context_line":"    session \u003d context.session"},{"line_number":74,"context_line":"    return (session.query(BrcdNetwork)."},{"line_number":75,"context_line":"            filter_by(id\u003dnet_id)."},{"line_number":76,"context_line":"            first())"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEaY%3D","line":74,"updated":"2013-02-08 03:59:20.000000000","message":"lines 74-75 should fit on one line too","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"def get_network(context, net_id):"},{"line_number":72,"context_line":"    \"\"\"Get brcd specific network, with vlan extension.\"\"\""},{"line_number":73,"context_line":"    session \u003d context.session"},{"line_number":74,"context_line":"    return (session.query(BrcdNetwork)."},{"line_number":75,"context_line":"            filter_by(id\u003dnet_id)."},{"line_number":76,"context_line":"            first())"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC6Y%3D","line":74,"in_reply_to":"AAAAM3%2F%2FEaY%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":104,"context_line":"def get_port(context, port_id):"},{"line_number":105,"context_line":"    \"\"\"get a brcd specific port.\"\"\""},{"line_number":106,"context_line":"    session \u003d context.session"},{"line_number":107,"context_line":"    port \u003d (session.query(BrcdPort)."},{"line_number":108,"context_line":"            filter_by(port_id\u003dport_id)."},{"line_number":109,"context_line":"            first())"},{"line_number":110,"context_line":"    return port"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEaQ%3D","line":107,"updated":"2013-02-08 03:59:20.000000000","message":"lines 107-109 should fit on one line","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"def get_port(context, port_id):"},{"line_number":105,"context_line":"    \"\"\"get a brcd specific port.\"\"\""},{"line_number":106,"context_line":"    session \u003d context.session"},{"line_number":107,"context_line":"    port \u003d (session.query(BrcdPort)."},{"line_number":108,"context_line":"            filter_by(port_id\u003dport_id)."},{"line_number":109,"context_line":"            first())"},{"line_number":110,"context_line":"    return port"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC6U%3D","line":107,"in_reply_to":"AAAAM3%2F%2FEaQ%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def get_port_from_device(session, port_id):"},{"line_number":123,"context_line":"    \"\"\"get port from the tap device.\"\"\""},{"line_number":124,"context_line":"    port \u003d (session.query(BrcdPort)."},{"line_number":125,"context_line":"            filter_by(port_id\u003dport_id)."},{"line_number":126,"context_line":"            first())"},{"line_number":127,"context_line":"    return port"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEaM%3D","line":124,"updated":"2013-02-08 03:59:20.000000000","message":"124-126 should fit on one line","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def get_port_from_device(session, port_id):"},{"line_number":123,"context_line":"    \"\"\"get port from the tap device.\"\"\""},{"line_number":124,"context_line":"    port \u003d (session.query(BrcdPort)."},{"line_number":125,"context_line":"            filter_by(port_id\u003dport_id)."},{"line_number":126,"context_line":"            first())"},{"line_number":127,"context_line":"    return port"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC6Q%3D","line":124,"in_reply_to":"AAAAM3%2F%2FEaM%3D","updated":"2013-02-09 22:16:04.000000000","message":"Done","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port \u003d (session.query(BrocadePort).filter_by(port_id\u003dport_id).first())"},{"line_number":118,"context_line":"        if port is not None:"},{"line_number":119,"context_line":"            session.delete(port)"},{"line_number":120,"context_line":"    return"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_port_from_device(session, port_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCVM%3D","line":120,"updated":"2013-02-10 09:32:18.000000000","message":"we do not need the return here","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port \u003d (session.query(BrocadePort).filter_by(port_id\u003dport_id).first())"},{"line_number":118,"context_line":"        if port is not None:"},{"line_number":119,"context_line":"            session.delete(port)"},{"line_number":120,"context_line":"    return"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_port_from_device(session, port_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FAo0%3D","line":120,"in_reply_to":"AAAAM3%2F%2FCVM%3D","updated":"2013-02-13 06:14:25.000000000","message":"correct. will do.","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"}],"quantum/plugins/brocade/nos/__init__.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2012 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2FM%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/nos/nctemplates.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2012 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2FI%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/nos/nosdriver.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2FE%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"Quantum network life-cycle management"},{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import logging"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ncclient import manager"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa6A%3D","line":27,"updated":"2013-01-23 05:57:17.000000000","message":"please use the common logging module","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"Quantum network life-cycle management"},{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ncclient import manager"},{"line_number":28,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":29,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQdI%3D","line":27,"updated":"2013-01-31 04:59:02.000000000","message":"3rd party imports need to be separated by a blank line","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":"from ncclient import manager"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6k%3D","line":29,"updated":"2013-02-03 07:34:34.000000000","message":"this is not used","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":"from ncclient import manager"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMy4%3D","line":29,"in_reply_to":"AAAAM3%2F%2FM6k%3D","updated":"2013-02-04 05:37:53.000000000","message":"wanted to leave this in for future work. When someone does add logging we have the right framework in place. I dont believe this should be an issue? Anyways removing.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"SSH_PORT \u003d 22"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6o%3D","line":32,"updated":"2013-02-03 07:34:34.000000000","message":"List is not used","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nctemplates as template"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"SSH_PORT \u003d 22"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMy0%3D","line":32,"in_reply_to":"AAAAM3%2F%2FM6o%3D","updated":"2013-02-04 05:37:53.000000000","message":"ditto","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def nos_unknown_host_cb(host, fingerprint):"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    An unknown host callback returns `True` if it finds the key acceptable,"},{"line_number":37,"context_line":"    and `False` if not. This default callback for NOS always returns \u0027True\u0027"},{"line_number":38,"context_line":"    (i.e. trusts all hosts for now)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCU0%3D","line":35,"updated":"2013-02-10 09:32:18.000000000","message":"Please have the docstrings updated as follows:\n\n\"\"\"This is an example.\"\"\"\n\n\"\"\"This is an example that is on more than one \nline.\"\"\"","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def nos_unknown_host_cb(host, fingerprint):"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    An unknown host callback returns `True` if it finds the key acceptable,"},{"line_number":37,"context_line":"    and `False` if not. This default callback for NOS always returns \u0027True\u0027"},{"line_number":38,"context_line":"    (i.e. trusts all hosts for now)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FAow%3D","line":35,"in_reply_to":"AAAAM3%2F%2FCU0%3D","updated":"2013-02-13 06:14:25.000000000","message":"Done","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Creates a new virtual network.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        name \u003d template.OS_PORT_PROFILE_NAME.format(id\u003dnet_id)"},{"line_number":67,"context_line":"        with self.connect(host, username, password) as mgr:"},{"line_number":68,"context_line":"            self.create_vlan_interface(mgr, net_id)"},{"line_number":69,"context_line":"            self.create_port_profile(mgr, name)"},{"line_number":70,"context_line":"            self.create_vlan_profile_for_port_profile(mgr, name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9XE%3D","line":67,"updated":"2013-02-13 07:24:19.000000000","message":"I don\u0027t see any exceptions at all in this driver. What is going to be the behavior if the ncclient fails or if the switch fails accepting the configuration.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Creates a new virtual network.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        name \u003d template.OS_PORT_PROFILE_NAME.format(id\u003dnet_id)"},{"line_number":67,"context_line":"        with self.connect(host, username, password) as mgr:"},{"line_number":68,"context_line":"            self.create_vlan_interface(mgr, net_id)"},{"line_number":69,"context_line":"            self.create_port_profile(mgr, name)"},{"line_number":70,"context_line":"            self.create_vlan_profile_for_port_profile(mgr, name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B7aQ%3D","line":67,"in_reply_to":"AAAAM3%2F%2B9XE%3D","updated":"2013-02-14 07:01:54.000000000","message":"Made some changes.\nSending you logs to show how exceptions are being handled.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"}],"quantum/plugins/brocade/setup.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaU8%3D","line":1,"updated":"2013-01-23 16:40:59.000000000","message":"This file should be dropped.  You should update the main Quantum setup.py file to copy the configuration files to the proper place.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2FA%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/tests/noscli.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2012 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2B0%3D","line":1,"updated":"2013-01-23 04:44:04.000000000","message":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2012 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2B4%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import argparse"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5c%3D","line":28,"updated":"2013-01-23 05:57:17.000000000","message":"please use common logging","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import argparse"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa58%3D","line":28,"updated":"2013-01-23 05:57:17.000000000","message":"please use common logging module","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"44513b49d0e36d3970fe813e22a3b8e20012a632","unresolved":false,"context_lines":[{"line_number":88,"context_line":"parser.add_argument(\u0027otherargs\u0027, nargs\u003d\u0027*\u0027)"},{"line_number":89,"context_line":"args \u003d parser.parse_args()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"#print args"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"noscli \u003d NOSCli(args.ip, args.username, args.password)"},{"line_number":94,"context_line":"noscli.execute(args.cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUWI%3D","line":91,"updated":"2013-01-29 05:40:43.000000000","message":"nit: remove","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"import argparse"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6c%3D","line":29,"updated":"2013-02-03 07:34:34.000000000","message":"ditto","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import argparse"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMyw%3D","line":29,"in_reply_to":"AAAAM3%2F%2FM6c%3D","updated":"2013-02-04 05:37:53.000000000","message":"wanted to leave this in for future work. When someone does add logging we have the right framework in place. I dont believe this should be an issue? Anyways, removing it.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class NOSCli(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6g%3D","line":32,"updated":"2013-02-03 07:34:34.000000000","message":"not used","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.plugins.brocade.nos import nosdriver as nos"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class NOSCli(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMys%3D","line":32,"in_reply_to":"AAAAM3%2F%2FM6g%3D","updated":"2013-02-04 05:37:53.000000000","message":"ditto","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"}],"quantum/plugins/brocade/tests/nostest.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 Brocade Communications Systems, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bw%3D","line":1,"updated":"2013-01-23 04:44:04.000000000","message":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\n\n2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # AMPP enumeration"},{"line_number":42,"context_line":"    with driver.connect(host, username, password) as mgr:"},{"line_number":43,"context_line":"        print driver.get_port_profiles(mgr)"},{"line_number":44,"context_line":"        print driver.get_port_profile(mgr, \u0027default\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":47,"context_line":"    nostest(sys.argv[1], sys.argv[2], sys.argv[3])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQdM%3D","line":44,"updated":"2013-01-31 04:59:02.000000000","message":"nit: there needs to be an additional blank line here","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"}],"quantum/plugins/brocade/tests/run_tests.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaUk%3D","line":1,"updated":"2013-01-23 16:40:59.000000000","message":"This file should be dropped because tests should be run by main test runner.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bs%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"}],"quantum/plugins/brocade/vlanbm.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Brocade Communications System, Inc."},{"line_number":4,"context_line":"# All rights reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bo%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Shiv Haris (sharis@brocade.com)"},{"line_number":20,"context_line":"# Varma Bhupatiraju (vbhupati@#brocade.com)"},{"line_number":21,"context_line":"# (Some parts adapted from LinuxBridge Plugin)"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5o%3D","line":22,"updated":"2013-01-23 05:57:17.000000000","message":"new line","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Keep track of the vlans that have been allocated/de-allocated"},{"line_number":32,"context_line":"    # uses a bitmap to do this"},{"line_number":33,"context_line":"    vlans \u003d {}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        for x in xrange(2, 4094):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaUI%3D","line":33,"updated":"2013-01-23 16:40:59.000000000","message":"Do you really want a class variable vs an instance var?  The init before will clear the contents of the dict.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"    # uses a bitmap to do this"},{"line_number":33,"context_line":"    vlans \u003d {}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        for x in xrange(2, 4094):"},{"line_number":37,"context_line":"            self.vlans[x] \u003d None"},{"line_number":38,"context_line":"        nets \u003d brcd_db.get_networks()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaUA%3D","line":35,"updated":"2013-01-23 16:40:59.000000000","message":"This can be simplified and you can dict\u0027s get method to make a more compact data structure.\n\ndef __init__(self):\n    self.vlans \u003d {}\n\n    for net in brcd_db.get_networks():\n        if net[\u0027vlan\u0027]:\n            self.vlans[int(clan)] \u003d True","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"            vlan \u003d net[\u0027vlan\u0027]"},{"line_number":42,"context_line":"            if vlan is not None:"},{"line_number":43,"context_line":"                self.vlans[int(vlan)] \u003d 1"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def getNextVlan(self, vlan_id):"},{"line_number":47,"context_line":"        if vlan_id is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaUU%3D","line":44,"updated":"2013-01-23 16:40:59.000000000","message":"This return is unnecessary because you\u0027re at the end of the method.","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"                self.vlans[int(vlan)] \u003d 1"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def getNextVlan(self, vlan_id):"},{"line_number":47,"context_line":"        if vlan_id is None:"},{"line_number":48,"context_line":"            for x in xrange(2, 4094):"},{"line_number":49,"context_line":"                if self.vlans[x] is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTk%3D","line":46,"updated":"2013-01-23 16:40:59.000000000","message":"PEP8 method name and can simplify this method\n\ndef get_next_vlan(self, vlan_id\u003dNone):\n    for x in xrange(vlan_id or 2, (x and x+1) or 4094):\n        if self.vlans.get(x) is None:\n            self.vlans[x] \u003d 1\n            return x","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                return None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def releaseVlan(self, vlan_id):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if self.vlans[vlan_id] is not None:"},{"line_number":62,"context_line":"            self.vlans[vlan_id] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTc%3D","line":59,"updated":"2013-01-23 16:40:59.000000000","message":"PEP8 method name and need to change to go with above changes.\n\ndef release_vlan(self, vlan_id):\n   if self.vlans.get(vlan_id) is not None:\n        del self.vlans[vlan_id]","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if self.vlans[vlan_id] is not None:"},{"line_number":62,"context_line":"            self.vlans[vlan_id] \u003d None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5g%3D","line":64,"updated":"2013-01-23 05:57:17.000000000","message":"you do not need the return here","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"from quantum.openstack.common import context"},{"line_number":27,"context_line":"from quantum.plugins.brocade.db import models as brcd_db"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class VlanBitmap(object):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Keep track of the vlans that have been allocated/de-allocated"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSd8%3D","line":29,"updated":"2013-01-30 04:05:22.000000000","message":"MIN_VLAN \u003d 2\n\nMAX_VLAN \u003d 4094","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        self.vlans \u003d {}"},{"line_number":37,"context_line":"        # Expliclity set all vlan slots to None"},{"line_number":38,"context_line":"        for x in xrange(2, 4094):"},{"line_number":39,"context_line":"            self.vlans[x] \u003d None"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        context.session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSeQ%3D","line":38,"updated":"2013-01-30 04:05:22.000000000","message":"You do not need to need to initialize all of the keys of the dict.  In fact, a set would be better data structure to use because member indicates that it is active.\n\ndef __init__(self):\n    self.vlans \u003d set(\n        int(net[\u0027vlan\u0027]) for net in brcd_db.get_networks(context) if net[\u0027vlan\u0027]\n    )","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if vlan is not None:"},{"line_number":47,"context_line":"                self.vlans[int(vlan)] \u003d 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_next_vlan(self, vlan_id\u003dNone):"},{"line_number":50,"context_line":"        if vlan_id is None:"},{"line_number":51,"context_line":"            for x in xrange(2, 4094):"},{"line_number":52,"context_line":"                if self.vlans[x] is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSd0%3D","line":49,"updated":"2013-01-30 04:05:22.000000000","message":"Same comment as the first patch set.  You should reduce duplicative code. Consider:\n\ndef get_next_vlan(self, vlan_id\u003dNone):\n    min_vlan_search \u003d vlan_id or MIN_VLAN\n    max_vlan_search \u003d (vlan_id and vlan_id+1) or MAX_VLAN\n\n    for x in xrange(min_vlan_search, max_vlan_search):\n        if x not in self.vlans:\n            self.vlans.add(x)\n            return x","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"                return None"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def release_vlan(self, vlan_id):"},{"line_number":63,"context_line":"        if self.vlans[vlan_id] is not None:"},{"line_number":64,"context_line":"            self.vlans[vlan_id] \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSdw%3D","line":63,"updated":"2013-01-30 04:05:22.000000000","message":"def release_vlan(self, vlan_id):\n    if vlan_id in self.vlans:\n        self.vlans.remove(vlan_id)","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"},{"line_number":40,"context_line":"        \"\"\"initialize the vlan as a set.\"\"\""},{"line_number":41,"context_line":"        db.configure_db()"},{"line_number":42,"context_line":"        context.session \u003d db.get_session()"},{"line_number":43,"context_line":"        self.vlans \u003d set(int(net[\u0027vlan\u0027])"},{"line_number":44,"context_line":"                         for net in brocade_db.get_networks(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCVI%3D","line":41,"updated":"2013-02-10 09:32:18.000000000","message":"Why do we need to call this here? It has already been called in the plugin.","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"},{"line_number":40,"context_line":"        \"\"\"initialize the vlan as a set.\"\"\""},{"line_number":41,"context_line":"        db.configure_db()"},{"line_number":42,"context_line":"        context.session \u003d db.get_session()"},{"line_number":43,"context_line":"        self.vlans \u003d set(int(net[\u0027vlan\u0027])"},{"line_number":44,"context_line":"                         for net in brocade_db.get_networks(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FA74%3D","line":41,"in_reply_to":"AAAAM3%2F%2FCVI%3D","updated":"2013-02-13 06:14:25.000000000","message":"restructured the code to not need this.","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":"from quantum.db import api as db"},{"line_number":27,"context_line":"from quantum.openstack.common import context"},{"line_number":28,"context_line":"from quantum.plugins.brocade.db import models as brocade_db"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MIN_VLAN \u003d 2"},{"line_number":31,"context_line":"MAX_VLAN \u003d 4094"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9W8%3D","line":28,"updated":"2013-02-13 07:24:19.000000000","message":"I dont see imports db and context to be used in this file","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":"from quantum.db import api as db"},{"line_number":27,"context_line":"from quantum.openstack.common import context"},{"line_number":28,"context_line":"from quantum.plugins.brocade.db import models as brocade_db"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MIN_VLAN \u003d 2"},{"line_number":31,"context_line":"MAX_VLAN \u003d 4094"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8io%3D","line":28,"in_reply_to":"AAAAM3%2F%2B9W8%3D","updated":"2013-02-14 07:01:54.000000000","message":"good point, i recently restructured the code and now there is no need for those. thanks for catching.\n\nremoved.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"}],"quantum/tests/unit/brocade/__init__.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bk%3D","line":3,"updated":"2013-01-23 04:44:04.000000000","message":"2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Just init."},{"line_number":20,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6Y%3D","line":18,"updated":"2013-02-03 07:34:34.000000000","message":"i do not think that you need this comment","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Just init."},{"line_number":20,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMyo%3D","line":18,"in_reply_to":"AAAAM3%2F%2FM6Y%3D","updated":"2013-02-04 05:37:53.000000000","message":"ok","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"}],"quantum/tests/unit/brocade/test_brocade_db.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bg%3D","line":1,"updated":"2013-01-23 04:44:04.000000000","message":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\n\n2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"        db.configure_db()"},{"line_number":35,"context_line":"        self.session \u003d db.get_session()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def network_tests(self):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        net_id \u003d str(uuid.uuid4())"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTQ%3D","line":37,"updated":"2013-01-23 16:40:59.000000000","message":"def test_create_network(self):","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # Delete the network"},{"line_number":50,"context_line":"        brcd_db.delete_network(net[\u0027id\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def port_tests(self):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        net_id \u003d str(uuid.uuid4())"},{"line_number":55,"context_line":"        port_id \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTM%3D","line":52,"updated":"2013-01-23 16:40:59.000000000","message":"def test_create_port(self):","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"                            TEST_VLAN, tenant_id, admin_state_up)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        port \u003d brcd_db.get_port(port_id)"},{"line_number":65,"context_line":"        self.assertEqual(port[\u0027port_id\u0027], port_id)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Delete Port"},{"line_number":68,"context_line":"        brcd_db.delete_port(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa5w%3D","line":65,"updated":"2013-01-23 05:57:17.000000000","message":"can you please add validity checks for the other values set","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONFIG_FILE_PATH \u003d \"/etc/quantum/plugins/brocade/\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestBrocadeDb(unittest.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6U%3D","line":34,"updated":"2013-02-03 07:34:34.000000000","message":"This should be based on test_plugin.QuantumDbPluginV2TestCase","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONFIG_FILE_PATH \u003d \"/etc/quantum/plugins/brocade/\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestBrocadeDb(unittest.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMyk%3D","line":34,"in_reply_to":"AAAAM3%2F%2FM6U%3D","updated":"2013-02-04 05:37:53.000000000","message":"ok","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"class TestBrocadeDb(unittest.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        sql_connection \u003d \u0027sqlite:///:memory:\u0027"},{"line_number":39,"context_line":"        options \u003d {\"sql_connection\": sql_connection}"},{"line_number":40,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FM6Q%3D","line":37,"updated":"2013-02-03 07:34:34.000000000","message":"No need for this.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class TestBrocadeDb(unittest.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        sql_connection \u003d \u0027sqlite:///:memory:\u0027"},{"line_number":39,"context_line":"        options \u003d {\"sql_connection\": sql_connection}"},{"line_number":40,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMuo%3D","line":37,"in_reply_to":"AAAAM3%2F%2FM6Q%3D","updated":"2013-02-04 05:37:53.000000000","message":"sql_connection and options not needed. I do need the db.configure_db() and the context setup creation.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"class TestBrocadeDb(unittest.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        sql_connection \u003d \u0027sqlite:///:memory:\u0027"},{"line_number":39,"context_line":"        options \u003d {\"sql_connection\": sql_connection}"},{"line_number":40,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FMTc%3D","line":37,"in_reply_to":"AAAAM3%2F%2FMuo%3D","updated":"2013-02-04 08:03:54.000000000","message":"if you base it on the class above then it will be done automagically.","commit_id":"9dcbf3738b687115c4533b0511f85943ee9c320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestBrocadeDb(test_plugin.QuantumDbPluginV2TestCase):"},{"line_number":34,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create_network(self):"},{"line_number":37,"context_line":"        \"\"\"Test brocade specific network db.\"\"\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FCUw%3D","line":35,"updated":"2013-02-10 09:32:18.000000000","message":"This is nearly there. There are just a few minor chnages to make here to ensure that it runs all of the base plugin tests through the brocade plugin:\n\nfrom quantum.extensions import portbindings\nfrom quantum.tests.unit import _test_extension_portbindings as test_bindings\nfrom quantum.tests.unit import test_db_plugin as test_plugin\n\nPLUGIN_NAME \u003d (\u0027quantum.plugins.brocade.\u0027\n               \u0027QuantumPlugin.BrocadePluginV2\u0027)\n\n\nclass BrocadePluginV2TestCase(test_plugin.QuantumDbPluginV2TestCase):\n    _plugin_name \u003d PLUGIN_NAME\n\n    def setUp(self):\n        super(LinuxBridgePluginV2TestCase, self).setUp(PLUGIN_NAME)\n\n\nclass TestBrocadeBasicGet(test_plugin.TestBasicGet,\n                              BrocadePluginV2TestCase):\n    pass\n\n\nclass TestBrocadeV2HTTPResponse(test_plugin.TestV2HTTPResponse,\n                                    BrocadePluginV2TestCase):\n    pass\n\n\nclass TestBrocadePortsV2(test_plugin.TestPortsV2,\n                             BrocadePluginV2TestCase,\n                             test_bindings.PortBindingsTestCase):\n\n    VIF_TYPE \u003d portbindings.VIF_TYPE_BRIDGE\n    HAS_PORT_FILTER \u003d True\n\n# You can add in the specific port test here (please make sure that the name is unique)\n\nclass TestBrocadeNetworksV2(test_plugin.TestNetworksV2,\n                                BrocadePluginV2TestCase):\n\n# You can add in your specific network test here","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestBrocadeDb(test_plugin.QuantumDbPluginV2TestCase):"},{"line_number":34,"context_line":"    \"\"\"Test brocade db functionality\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create_network(self):"},{"line_number":37,"context_line":"        \"\"\"Test brocade specific network db.\"\"\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9f4%3D","line":35,"in_reply_to":"AAAAM3%2F%2FCUw%3D","updated":"2013-02-13 06:14:25.000000000","message":"I implemented the mock (patch) for the  hardware facing driver and overcame the need for the ncclient!! Now I have incorporated the plugin tests as well.","commit_id":"d9ad012a6645c1bdaf7f2fa2f9fa3d1e349c0cd2"}],"quantum/tests/unit/brocade/test_brocade_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        def new_brocade_init(self):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            self._switch \u003d {\u0027address\u0027: FAKE_IPADDRESS,"},{"line_number":49,"context_line":"                            \u0027username\u0027: FAKE_USERNAME,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9QA%3D","line":46,"updated":"2013-02-13 08:47:47.000000000","message":"missing the bindings.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        def new_brocade_init(self):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            self.supported_extension_aliases \u003d [\"security-group\"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            self._switch \u003d {\u0027address\u0027: FAKE_IPADDRESS,"},{"line_number":49,"context_line":"                            \u0027username\u0027: FAKE_USERNAME,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8ik%3D","line":46,"in_reply_to":"AAAAM3%2F%2B9QA%3D","updated":"2013-02-14 07:01:54.000000000","message":"no need in the next revision, since the brocade specific init is separated out.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self._driver \u003d importutils.import_object(NOS_DRIVER)"},{"line_number":60,"context_line":"            self._vlan_bitmap \u003d vbm.VlanBitmap(self.ctxt)"},{"line_number":61,"context_line":"            self._setup_rpc()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        with mock.patch.object(brocade_plugin.BrocadePluginV2,"},{"line_number":64,"context_line":"                               \u0027__init__\u0027, new\u003dnew_brocade_init):"},{"line_number":65,"context_line":"            super(BrocadePluginV2TestCase, self).setUp(self._plugin_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9P8%3D","line":62,"updated":"2013-02-13 08:47:47.000000000","message":"I think that you could do this a lot simpler. Please look at comment on plugin file. You could just then mock the brocade specific function","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self._driver \u003d importutils.import_object(NOS_DRIVER)"},{"line_number":60,"context_line":"            self._vlan_bitmap \u003d vbm.VlanBitmap(self.ctxt)"},{"line_number":61,"context_line":"            self._setup_rpc()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        with mock.patch.object(brocade_plugin.BrocadePluginV2,"},{"line_number":64,"context_line":"                               \u0027__init__\u0027, new\u003dnew_brocade_init):"},{"line_number":65,"context_line":"            super(BrocadePluginV2TestCase, self).setUp(self._plugin_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8ig%3D","line":62,"in_reply_to":"AAAAM3%2F%2B9P8%3D","updated":"2013-02-14 07:01:54.000000000","message":"ok.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":83,"context_line":"    HAS_PORT_FILTER \u003d True"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # TODO(shiv)"},{"line_number":86,"context_line":"    # We run all 35+ port tests accept this one"},{"line_number":87,"context_line":"    # it appears the RPC parameters get filtered (view) and"},{"line_number":88,"context_line":"    # the portbinding is dropped in this mode"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B9Pk%3D","line":85,"updated":"2013-02-13 08:47:47.000000000","message":"I tried to investigate why this happens - after making the changes I suggested int he plugin code the create port returns the VIF binding. For some reason the vif binding is dropped along the way. I did not have time to investigate this further. I will try a bit later","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":83,"context_line":"    HAS_PORT_FILTER \u003d True"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # TODO(shiv)"},{"line_number":86,"context_line":"    # We run all 35+ port tests accept this one"},{"line_number":87,"context_line":"    # it appears the RPC parameters get filtered (view) and"},{"line_number":88,"context_line":"    # the portbinding is dropped in this mode"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8hU%3D","line":85,"in_reply_to":"AAAAM3%2F%2B9Pk%3D","updated":"2013-02-14 07:01:54.000000000","message":"I know precisely why it is getting dropped. sending info in separate email.","commit_id":"82cdeef39a15d1e6a697e677bba83a62447db958"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"    VIF_TYPE \u003d portbindings.VIF_TYPE_BRIDGE"},{"line_number":69,"context_line":"    HAS_PORT_FILTER \u003d True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # TODO(shiv)"},{"line_number":72,"context_line":"    # We run all 35+ port tests accept this one"},{"line_number":73,"context_line":"    # it appears the RPC parameters get filtered (view) and"},{"line_number":74,"context_line":"    # the portbinding is dropped in this mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2B7Jc%3D","line":71,"updated":"2013-02-14 09:03:58.000000000","message":"This can be removed once you have the \"binding\" added.","commit_id":"e50f5dae8f92ecd42932a023b3ff13b6ee4ac7f8"}],"quantum/tests/unit/brocade/test_brocade_vlan.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2Bc%3D","line":1,"updated":"2013-01-23 04:44:04.000000000","message":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\n\n2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"exercise Vlan bitmap .\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        self.vbm_ \u003d vbm.VlanBitmap()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def vlan_tests(self):"},{"line_number":35,"context_line":"        vlan_id \u003d self.vbm_.getNextVlan(None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTA%3D","line":32,"updated":"2013-01-23 16:40:59.000000000","message":"Why are you using a setUp when this is only used in one test?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        self.vbm_ \u003d vbm.VlanBitmap()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def vlan_tests(self):"},{"line_number":35,"context_line":"        vlan_id \u003d self.vbm_.getNextVlan(None)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # First vlan is always 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaTI%3D","line":34,"updated":"2013-01-23 16:40:59.000000000","message":"def test_vlan(self):","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import contextlib"},{"line_number":19,"context_line":"import unittest2 as unittest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSdU%3D","line":18,"updated":"2013-01-30 04:05:22.000000000","message":"There should be a newline between lines 18 and 19.","commit_id":"02dd8060bdcd4e487cef68f7a30223b0ea0ac993"}],"quantum/tests/unit/brocade/test_defaults.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"7c66a808b795f02fca64e6bf9281e396c32808da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fa%2BY%3D","line":1,"updated":"2013-01-23 04:44:04.000000000","message":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\n\n2013","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"from quantum.plugins.linuxbridge.common import config"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BrocadeConfigTest(unittest.TestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_defaults(self):"},{"line_number":25,"context_line":"        self.assertEqual(\u0027sqlite://\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaSo%3D","line":22,"updated":"2013-01-23 16:40:59.000000000","message":"Do we need this test?","commit_id":"c19e626e46017b2e032032c9593608b9a02da6b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"from quantum.openstack.common import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class BrocadeConfigTest(unittest.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_defaults(self):"},{"line_number":30,"context_line":"        self.assertEqual(\u0027sqlite://\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FEZc%3D","line":27,"updated":"2013-02-08 03:59:20.000000000","message":"This test does not stand on its own.  cfg.CONF.DATABASE is defined in quantum.db.api.  cfg.CONF.LINUX_BRIDGE is defined in the linux bridge plugin.  You can drop this file because it does not test any of the functionality of your plugin.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"8ce67d0f0dd2417ee613d9b0ea927b5d43fa1dcd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from quantum.openstack.common import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class BrocadeConfigTest(unittest.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_defaults(self):"},{"line_number":30,"context_line":"        self.assertEqual(\u0027sqlite://\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FC5U%3D","line":27,"in_reply_to":"AAAAM3%2F%2FEZc%3D","updated":"2013-02-09 22:16:04.000000000","message":"agreed.","commit_id":"68d323399f08c77b0528355d1988ea1d9148344f"}]}
