)]}'
{"neutron/db/qos/models.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"03f9d423a153df832fd832c8ee4a4f28e4983062","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                           nullable\u003dFalse,"},{"line_number":45,"context_line":"                           unique\u003dTrue,"},{"line_number":46,"context_line":"                           primary_key\u003dTrue)"},{"line_number":47,"context_line":"    network \u003d sa.orm.relationship("},{"line_number":48,"context_line":"        models_v2.Network,"},{"line_number":49,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":50,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_6be70d13","line":47,"updated":"2015-07-19 06:16:12.000000000","message":"does this not require a migration?","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59ab296b7d98c4653500c6dbd56c26b808d9726f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                           nullable\u003dFalse,"},{"line_number":45,"context_line":"                           unique\u003dTrue,"},{"line_number":46,"context_line":"                           primary_key\u003dTrue)"},{"line_number":47,"context_line":"    network \u003d sa.orm.relationship("},{"line_number":48,"context_line":"        models_v2.Network,"},{"line_number":49,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":50,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_8b929956","line":47,"in_reply_to":"3a50d1a3_6be70d13","updated":"2015-07-19 06:24:47.000000000","message":"No, relationships are SQLA only, they instruct it to join data from the table on network and port fetch.","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"03f9d423a153df832fd832c8ee4a4f28e4983062","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        nullable\u003dFalse,"},{"line_number":64,"context_line":"                        unique\u003dTrue,"},{"line_number":65,"context_line":"                        primary_key\u003dTrue)"},{"line_number":66,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":67,"context_line":"        models_v2.Port,"},{"line_number":68,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":69,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_2bf105ce","line":66,"updated":"2015-07-19 06:16:12.000000000","message":"ditto","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59ab296b7d98c4653500c6dbd56c26b808d9726f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        nullable\u003dFalse,"},{"line_number":64,"context_line":"                        unique\u003dTrue,"},{"line_number":65,"context_line":"                        primary_key\u003dTrue)"},{"line_number":66,"context_line":"    port \u003d sa.orm.relationship("},{"line_number":67,"context_line":"        models_v2.Port,"},{"line_number":68,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":69,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_2b9fc560","line":66,"in_reply_to":"3a50d1a3_2bf105ce","updated":"2015-07-19 06:24:47.000000000","message":"Same","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"}],"neutron/plugins/ml2/extensions/qos.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5e9c2394350119517dda4f8850780d9ab63e576d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    process_update_port \u003d process_create_port"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def extend_network_dict(self, session, db_data, result):"},{"line_number":43,"context_line":"        result[\u0027qos_policy_id\u0027] \u003d db_data[\u0027qos_policy\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    extend_port_dict \u003d extend_network_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_af3ab7e5","line":43,"updated":"2015-07-17 23:11:44.000000000","message":"qos.QOS_POLICY_ID","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e70eebc2f86612c8d6660c91fcdbf6c39800787a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    process_update_port \u003d process_create_port"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def extend_network_dict(self, session, db_data, result):"},{"line_number":43,"context_line":"        result[\u0027qos_policy_id\u0027] \u003d db_data[\u0027qos_policy\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    extend_port_dict \u003d extend_network_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_b2821cc7","line":43,"in_reply_to":"9a41bdd9_af3ab7e5","updated":"2015-07-17 23:36:51.000000000","message":"Done","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5e9c2394350119517dda4f8850780d9ab63e576d","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        if \u0027qos\u0027 not in drivers:"},{"line_number":729,"context_line":"            drivers +\u003d [\u0027qos\u0027]"},{"line_number":730,"context_line":"        LOG.info(_LI(\"Configured extension driver names: %s\"),"},{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_0f98831a","line":731,"updated":"2015-07-17 23:11:44.000000000","message":"was this left behind intentionally?","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e70eebc2f86612c8d6660c91fcdbf6c39800787a","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        if \u0027qos\u0027 not in drivers:"},{"line_number":729,"context_line":"            drivers +\u003d [\u0027qos\u0027]"},{"line_number":730,"context_line":"        LOG.info(_LI(\"Configured extension driver names: %s\"),"},{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_b20bfc7c","line":731,"in_reply_to":"9a41bdd9_0f98831a","updated":"2015-07-17 23:36:51.000000000","message":"It was. We will revisit it later once we get the extension enabled in gate for feature/qos branch.","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5e9c2394350119517dda4f8850780d9ab63e576d","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"},{"line_number":735,"context_line":"                                               drivers,"},{"line_number":736,"context_line":"                                               invoke_on_load\u003dTrue,"},{"line_number":737,"context_line":"                                               name_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_cfa13b48","line":734,"updated":"2015-07-17 23:11:44.000000000","message":"ditto","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e70eebc2f86612c8d6660c91fcdbf6c39800787a","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"},{"line_number":735,"context_line":"                                               drivers,"},{"line_number":736,"context_line":"                                               invoke_on_load\u003dTrue,"},{"line_number":737,"context_line":"                                               name_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_7226d417","line":734,"in_reply_to":"9a41bdd9_cfa13b48","updated":"2015-07-17 23:36:51.000000000","message":"Same","commit_id":"c393bac57bfc7b4da48a6708665aedfc55b9e371"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"03f9d423a153df832fd832c8ee4a4f28e4983062","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        if \u0027qos\u0027 not in drivers:"},{"line_number":729,"context_line":"            drivers +\u003d [\u0027qos\u0027]"},{"line_number":730,"context_line":"        LOG.info(_LI(\"Configured extension driver names: %s\"),"},{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_0bd8c952","line":731,"updated":"2015-07-19 06:16:12.000000000","message":"please remove this comment","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59ab296b7d98c4653500c6dbd56c26b808d9726f","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        if \u0027qos\u0027 not in drivers:"},{"line_number":729,"context_line":"            drivers +\u003d [\u0027qos\u0027]"},{"line_number":730,"context_line":"        LOG.info(_LI(\"Configured extension driver names: %s\"),"},{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_4b9c9169","line":731,"in_reply_to":"3a50d1a3_0bd8c952","updated":"2015-07-19 06:24:47.000000000","message":"Those will be reverted after https://review.openstack.org/203352 is merged.","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"03f9d423a153df832fd832c8ee4a4f28e4983062","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                 #cfg.CONF.ml2.extension_drivers)"},{"line_number":732,"context_line":"                 drivers)"},{"line_number":733,"context_line":"        super(ExtensionManager, self).__init__(\u0027neutron.ml2.extension_drivers\u0027,"},{"line_number":734,"context_line":"                                               #cfg.CONF.ml2.extension_drivers,"},{"line_number":735,"context_line":"                                               drivers,"},{"line_number":736,"context_line":"                                               invoke_on_load\u003dTrue,"},{"line_number":737,"context_line":"                                               name_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_cbe18100","line":734,"updated":"2015-07-19 06:16:12.000000000","message":"ditto","commit_id":"323de96c75d298fe81b934c85e7efa91c1a07226"}]}