)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"67388ddf872c2b497e9010969de8936de1c2bf33","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-21 18:38:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_d48c4b81","line":8,"updated":"2015-07-21 22:16:39.000000000","message":"You\u0027ll need to add the new generated file to .gitignore.","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"6e09815c6a191f91bb00f1b702cc272748071f8a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-21 18:38:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_2b1b9e74","line":8,"in_reply_to":"3a50d1a3_d48c4b81","updated":"2015-07-22 14:49:36.000000000","message":"Done","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"67388ddf872c2b497e9010969de8936de1c2bf33","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_b4565fd0","line":9,"updated":"2015-07-21 22:16:39.000000000","message":"Can you add a README-neutron.conf like Nova has, that explains how to generate the missing conf file?","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"11d12c8d5284e1f4b36807dbd53e66cba6c665dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_a44cd89e","line":9,"in_reply_to":"3a50d1a3_b4565fd0","updated":"2015-07-22 07:33:16.000000000","message":"+1.","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"6e09815c6a191f91bb00f1b702cc272748071f8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_eb005603","line":9,"in_reply_to":"3a50d1a3_b4565fd0","updated":"2015-07-22 14:49:36.000000000","message":"Done","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"67388ddf872c2b497e9010969de8936de1c2bf33","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":14,"context_line":"Implements: blueprint autogen-neutron-conf-file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_74753796","line":11,"updated":"2015-07-21 22:16:39.000000000","message":"Is there a reason not to remove neutron.conf in this patch?","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"6e09815c6a191f91bb00f1b702cc272748071f8a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. After this"},{"line_number":11,"context_line":"is merged, we can remove the static configuration file from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":14,"context_line":"Implements: blueprint autogen-neutron-conf-file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_3001c906","line":11,"in_reply_to":"3a50d1a3_74753796","updated":"2015-07-22 14:49:36.000000000","message":"Devstack requires an etc/neutron.conf in-tree to copy from. My thought is that we can first get the generation working, then modify devstack to generate the file and use it. After that is done, we can remove it.","commit_id":"e55685d8bc21552f5b6f51556fbd29fc948db62a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e2ba2e2e84907344296b09dacf57cce6a6857a31","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":16,"context_line":"Depends-On: Ic37a16b6cf8eb92030649f1fc8b198738a8cc104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_c94a3826","line":13,"updated":"2015-07-22 18:43:44.000000000","message":"Partially-implements. Because I have added some work items to the blueprint.","commit_id":"606915a05fe8b1ce0333110b4f67981e3d1071ce"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"d37aadfbfd05366a525305e06cb69c98c249cf84","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":16,"context_line":"Depends-On: Ic37a16b6cf8eb92030649f1fc8b198738a8cc104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_298abc1b","line":13,"in_reply_to":"3a50d1a3_c94a3826","updated":"2015-07-22 18:48:20.000000000","message":"Good catch. Thanks for updating the bp","commit_id":"606915a05fe8b1ce0333110b4f67981e3d1071ce"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"ae78d40aca6a0710f1934e26d614e56305c48867","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_2616def1","line":12,"updated":"2015-11-10 01:13:55.000000000","message":"I really want to see this work land, but this BP is apparently not approved for Mitaka yet (or at least it\u0027s not targeted in Mitaka). We need to fix this, I encourage you to poke armax to get this rectified.","commit_id":"93d7959d0e90ed06e9b35ee46f8368950220d6b3"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"fb52665c0934f092e0351a2b5a02be222ecf8098","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_9cf25f6e","line":12,"in_reply_to":"da85f559_2616def1","updated":"2015-11-10 14:41:09.000000000","message":"Sure.","commit_id":"93d7959d0e90ed06e9b35ee46f8368950220d6b3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"481a21487430ca6689f3b841a920f7dda22ad6b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 16:20:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_f9b92216","line":7,"updated":"2015-11-10 23:04:45.000000000","message":"neutron.conf.sample","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"712fa6afd3dde06aee36c5ef5e763487635a48dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 16:20:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automatically generate neutron.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_7a071282","line":7,"in_reply_to":"da85f559_f9b92216","updated":"2015-11-12 10:40:43.000000000","message":"Updated.","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f69bebb1a3ec414652ff646fc3973c2de8d635cf","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":16,"context_line":"Partial-bug: #1199963"},{"line_number":17,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_db889673","line":17,"updated":"2015-11-12 01:53:44.000000000","message":"co-authored-by yourself?","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"712fa6afd3dde06aee36c5ef5e763487635a48dd","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":16,"context_line":"Partial-bug: #1199963"},{"line_number":17,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_7a2e32fc","line":17,"in_reply_to":"da85f559_db889673","updated":"2015-11-12 10:40:43.000000000","message":"Author was unintentionally updated. Replaced back as Louis.","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"73457a54b02bc39d5caf5e0c629076fb10e9df50","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da85f559_afa4514a","line":11,"updated":"2015-11-12 12:55:35.000000000","message":"\"This paves the way for removing the static configuration file from the tree.\"?","commit_id":"3ea0d323446a44048920e3b1f03374fdd4fe4259"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1c59265dcad34be4f3ab551d5d33732940dc6a1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates a sample"},{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator. The static"},{"line_number":11,"context_line":"configuration file is also removed from tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da85f559_22e62544","line":11,"in_reply_to":"da85f559_afa4514a","updated":"2015-11-12 17:19:21.000000000","message":"Sure, good point. Removing the sentence for the time being as the neutron.conf file is be retained until the patch is finished.","commit_id":"3ea0d323446a44048920e3b1f03374fdd4fe4259"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e4285d760efa5cc9c18574e021585aa39ce842cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":15,"context_line":"Partial-bug: #1199963"},{"line_number":16,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da85f559_bb36c04e","line":13,"updated":"2015-11-12 18:28:15.000000000","message":"Can you please add DocImpact and provide instructions on how to run this so it can be documented","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b8f71590e2b8c0682ae60c521c2767950778a597","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron.conf configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1c6dc4e7d479f1b7c755597caded24a0f018c712"},{"line_number":15,"context_line":"Partial-bug: #1199963"},{"line_number":16,"context_line":"Co-Authored-By: Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da85f559_953fd2d5","line":13,"in_reply_to":"da85f559_bb36c04e","updated":"2015-11-13 18:06:09.000000000","message":"Sure, done. Alaso comment that devref will be updated.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":"It will also add details to devref on how to update config files."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba8a016a_8c141f4d","line":12,"updated":"2015-11-19 13:10:04.000000000","message":"Mention that you also update some configuration option help messages to reflect useful details that were missing in the code but were present in config files before.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":"It will also add details to devref on how to update config files."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint autogen-neutron-conf-file"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba8a016a_cbf16603","line":12,"in_reply_to":"ba8a016a_8c141f4d","updated":"2015-11-20 14:43:32.000000000","message":"Sure, will do.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"9a8ffd7b_4d956ce2","line":12,"updated":"2015-11-25 00:35:53.000000000","message":"I would prefer such updates in a parent change to differentiate the autogen part and \"help realign\" part","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"9a8ffd7b_4b20e29b","line":12,"in_reply_to":"9a8ffd7b_4d956ce2","updated":"2015-11-25 12:57:24.000000000","message":"Sure, I would have preferred it this way. However, the overall opinion was that all changes be delivered in the one patch.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-25 12:55:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Automatically generate neutron core configuration files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_688595ab","line":7,"updated":"2015-11-25 16:06:48.000000000","message":"Still WIP?","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-25 12:55:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Automatically generate neutron core configuration files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a new tox environment, genconfig, which generates sample"},{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_db843f0c","line":7,"in_reply_to":"9a8ffd7b_688595ab","updated":"2015-11-26 18:24:02.000000000","message":"Removed now.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"4714f7e350b7c274ffe4a3fd4858fc16d2bca9ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_4ed21902","line":13,"updated":"2015-11-25 16:05:59.000000000","message":"I originally planned on creating a patch for help string updates after this patch merges, but implementing auto-generation revealed issues with some help strings that lead to fixing them in this patch. So, we can take one of two approaches with this patch:\n\n1) Only update help strings that potentially degrade content from the original (manual-generation) configuration files.\n\n2) Update all (or at least most) help strings to improve overall content in auto-generation configuration files.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"13144542697d113e2b48cf65b877a4ea0097f23e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_18d45245","line":13,"in_reply_to":"9a8ffd7b_02194588","updated":"2015-11-25 16:43:03.000000000","message":"How would you define the list of options that need some kind of love? I am not clear what you try to achieve here.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_9b25570a","line":13,"in_reply_to":"9a8ffd7b_18d45245","updated":"2015-11-26 18:24:02.000000000","message":"Previously updated help strings that potentially degraded content from the original (manual-generation) configuration files.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fe3c044be842892d2068f85e3ee590e05631e10","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_6e503d5f","line":13,"in_reply_to":"9a8ffd7b_4ed21902","updated":"2015-11-25 16:07:58.000000000","message":"I think we took 1 approach here. 2 would be out of scope for the feature.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"3b29a8c7ab78eddd1e49cb8df6b8f7f16e287cdb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"neutron core configuration file using oslo-config-generator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updates to some configuration option help messages to reflect useful"},{"line_number":13,"context_line":"details that were missing in the code but were present in config files."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also adds details to devref on how to update config files."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a8ffd7b_02194588","line":13,"in_reply_to":"9a8ffd7b_6e503d5f","updated":"2015-11-25 16:23:44.000000000","message":"In that case, I\u0027ll review this patch with approach 1 in mind and then create a separate patch for updating all help strings after this patch merges.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"doc/source/devref/contribute.rst":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this"},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"ba8a016a_2cfc136f","line":370,"updated":"2015-11-19 13:10:04.000000000","message":"This goal should be validated with PTL.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this"},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"ba8a016a_73c63a4b","line":370,"in_reply_to":"ba8a016a_2cfc136f","updated":"2015-11-20 14:43:32.000000000","message":"Sure. I will add a note here to make sure I sync-up with PTL.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":388,"context_line":"instead to generate the configuration files::"},{"line_number":389,"context_line":"./tools/generate_config_file_samples.sh"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Liberty Steps"}],"source_content_type":"text/x-rst","patch_set":16,"id":"ba8a016a_8c0e5f8a","line":389,"updated":"2015-11-19 13:10:04.000000000","message":"Thanks for documenting the script too. It may be useful for packagers.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":388,"context_line":"instead to generate the configuration files::"},{"line_number":389,"context_line":"./tools/generate_config_file_samples.sh"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Liberty Steps"}],"source_content_type":"text/x-rst","patch_set":16,"id":"ba8a016a_b39ca25e","line":389,"in_reply_to":"ba8a016a_8c0e5f8a","updated":"2015-11-20 14:43:32.000000000","message":"No problem.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_cd771cd3","line":370,"updated":"2015-11-25 00:35:53.000000000","message":"IMO, there is no need to reference mitaka cycle so this sentence can be removed","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"843517b9afdc4ec8c59e97f4a2d9298d1e4b5ba7","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_f4efe4e6","line":370,"in_reply_to":"9a8ffd7b_42f8b249","updated":"2015-11-26 14:21:28.000000000","message":"Good alternative. Changed sentences to be similar to this.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eaa7f58a6242ca36555315818d28e7f873c49aa8","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_42f8b249","line":370,"in_reply_to":"9a8ffd7b_abd86e54","updated":"2015-11-25 15:23:05.000000000","message":"You can probably say \u0027Since Mitaka, configuration files are not maintained in the git tree, but should be generated as follows:\u0027","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_abd86e54","line":370,"in_reply_to":"9a8ffd7b_cd771cd3","updated":"2015-11-25 12:57:24.000000000","message":"I wonder is it best to say in what cycle this is to happen? L69 follows this pattern.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_2dbb4874","line":371,"updated":"2015-11-25 00:35:53.000000000","message":"trailing space","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle we aim to remove all sample configuration files from the"},{"line_number":371,"context_line":"repository. Sample configuration files can be generated by executing this "},{"line_number":372,"context_line":"command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_8bd32a38","line":371,"in_reply_to":"9a8ffd7b_2dbb4874","updated":"2015-11-25 12:57:24.000000000","message":"Fixed.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle, we aim to remove all core sample configuration files"},{"line_number":371,"context_line":"from the repository. Sample configuration files can be generated by executing"},{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_7347c61d","line":370,"updated":"2015-11-25 16:06:48.000000000","message":"This is \u0027Integrating with the Neutron system\u0027 section, it is about how 3rd parties follow the neutron way of doing things. So there is no need to mention specific .sample files as in line 375 and below. Instead the section should talk about how 3rd party subprojects should handle their config files, leveraging the tox target, using the .sh script you added, etc.\n\nAlso note that \u0027It\u0027s advised that subprojects do not keep their configuration files in their respective trees and instead generate them using similar approach as Neutron does.\u0027","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle, we aim to remove all core sample configuration files"},{"line_number":371,"context_line":"from the repository. Sample configuration files can be generated by executing"},{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_172c18aa","line":370,"in_reply_to":"9a8ffd7b_7347c61d","updated":"2015-11-25 20:18:01.000000000","message":"+1","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  config files, duplicate settings will collide. It is therefore recommended to"},{"line_number":368,"context_line":"  prefix section names with a third-party string, e.g. [vendor_foo]."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle, we aim to remove all core sample configuration files"},{"line_number":371,"context_line":"from the repository. Sample configuration files can be generated by executing"},{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_d7f50257","line":370,"in_reply_to":"9a8ffd7b_7347c61d","updated":"2015-11-26 18:24:02.000000000","message":"+1","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle, we aim to remove all core sample configuration files"},{"line_number":371,"context_line":"from the repository. Sample configuration files can be generated by executing"},{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"The command will generate the following configuration files::"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_930fcae0","line":372,"updated":"2015-11-25 16:06:48.000000000","message":"You need a newline after :: otherwise it renders badly.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"For the Mitaka cycle, we aim to remove all core sample configuration files"},{"line_number":371,"context_line":"from the repository. Sample configuration files can be generated by executing"},{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"The command will generate the following configuration files::"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_17f86a48","line":372,"in_reply_to":"9a8ffd7b_930fcae0","updated":"2015-11-26 18:24:02.000000000","message":"Added line.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"The command will generate the following configuration files::"},{"line_number":376,"context_line":"./etc/dhcp_agent.ini.sample"},{"line_number":377,"context_line":"./etc/neutron/plugins/ml2/linuxbridge_agent.ini.sample"},{"line_number":378,"context_line":"./etc/l3_agent.ini.sample"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_f36176a9","line":375,"updated":"2015-11-25 16:06:48.000000000","message":"Unneeded section as per above","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":372,"context_line":"this command from the top neutron directory::"},{"line_number":373,"context_line":"``tox -e genconfig``"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"The command will generate the following configuration files::"},{"line_number":376,"context_line":"./etc/dhcp_agent.ini.sample"},{"line_number":377,"context_line":"./etc/neutron/plugins/ml2/linuxbridge_agent.ini.sample"},{"line_number":378,"context_line":"./etc/l3_agent.ini.sample"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_779d3609","line":375,"in_reply_to":"9a8ffd7b_f36176a9","updated":"2015-11-26 18:24:02.000000000","message":"Section removed.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":385,"context_line":"./etc/neutron/plugins/ml2/sriov_agent.ini.sample"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":388,"context_line":"instead to generate the configuration files::"},{"line_number":389,"context_line":"./tools/generate_config_file_samples.sh"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_131bda1c","line":388,"updated":"2015-11-25 16:06:48.000000000","message":"newline after :: needed","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"./etc/neutron/plugins/ml2/sriov_agent.ini.sample"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":388,"context_line":"instead to generate the configuration files::"},{"line_number":389,"context_line":"./tools/generate_config_file_samples.sh"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a8ffd7b_b7be3e63","line":388,"in_reply_to":"9a8ffd7b_131bda1c","updated":"2015-11-26 18:24:02.000000000","message":"Added line.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"etc/README-neutron.conf.txt":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"36084d7f35ba411bfac88ba355e812780e940cec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample neutron.conf file, run the following"},{"line_number":2,"context_line":"command from the top level of the nova directory:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tox -e genconfig"}],"source_content_type":"text/plain","patch_set":4,"id":"3a50d1a3_7fa5d244","line":2,"updated":"2015-07-22 19:43:48.000000000","message":"neutron, not nova :)","commit_id":"1d4fe92853fb76f3255aebde928d5f15d0309e2f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f69bebb1a3ec414652ff646fc3973c2de8d635cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample neutron.conf file, run the following"},{"line_number":2,"context_line":"command from the top level of the nova directory:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tox -e genconfig"}],"source_content_type":"text/plain","patch_set":8,"id":"da85f559_980e948a","line":2,"range":{"start_line":2,"start_character":34,"end_line":2,"end_character":38},"updated":"2015-11-12 01:53:44.000000000","message":"s/nova/neutron/","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"712fa6afd3dde06aee36c5ef5e763487635a48dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample neutron.conf file, run the following"},{"line_number":2,"context_line":"command from the top level of the nova directory:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tox -e genconfig"}],"source_content_type":"text/plain","patch_set":8,"id":"da85f559_1a25a607","line":2,"in_reply_to":"da85f559_980e948a","updated":"2015-11-12 10:40:43.000000000","message":"Updated.","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample neutron.conf file, run the following"},{"line_number":2,"context_line":"command from the top level of the neutron directory:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tox -e genconfig"}],"source_content_type":"text/plain","patch_set":16,"id":"ba8a016a_0c726f11","line":1,"updated":"2015-11-19 13:10:04.000000000","message":"Should it refer to neutron.conf now that we generate more files with the command?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample neutron.conf file, run the following"},{"line_number":2,"context_line":"command from the top level of the neutron directory:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tox -e genconfig"}],"source_content_type":"text/plain","patch_set":16,"id":"ba8a016a_f9d68b26","line":1,"in_reply_to":"ba8a016a_0c726f11","updated":"2015-11-20 14:43:32.000000000","message":"Sure, updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a8ffd7b_b3ae8e96","updated":"2015-11-25 16:06:48.000000000","message":"I am still not sure README-neutron.conf.txt name is the best. Since the file documents it for all config files, not just for neutron.conf.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a8ffd7b_1a5e4f12","in_reply_to":"9a8ffd7b_2ea3e701","updated":"2015-11-26 18:24:02.000000000","message":"Filename changed.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88c36ce28714a68954b0ac3ed5ed12e1cd1993c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a8ffd7b_2ea3e701","in_reply_to":"9a8ffd7b_773c84e2","updated":"2015-11-26 11:01:04.000000000","message":"I like README.txt name.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a8ffd7b_773c84e2","in_reply_to":"9a8ffd7b_b3ae8e96","updated":"2015-11-25 20:18:01.000000000","message":"I agree. I think this applies to the original patch that only auto-generated the neutron.conf file. Maybe just a README.txt in the \u0027etc\u0027 directory that previously included static files?","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"tox -e genconfig"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":7,"context_line":"instead to generate the configuration files:"},{"line_number":8,"context_line":"./tools/generate_config_file_samples.sh"}],"source_content_type":"text/plain","patch_set":20,"id":"9a8ffd7b_93b4aaf2","line":7,"updated":"2015-11-25 16:06:48.000000000","message":"please add newline after :","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"tox -e genconfig"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"If a \u0027tox\u0027 environment is unavailable, then you can run the following script"},{"line_number":7,"context_line":"instead to generate the configuration files:"},{"line_number":8,"context_line":"./tools/generate_config_file_samples.sh"}],"source_content_type":"text/plain","patch_set":20,"id":"9a8ffd7b_9aa8ffdc","line":7,"in_reply_to":"9a8ffd7b_93b4aaf2","updated":"2015-11-26 18:24:02.000000000","message":"Line added.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"etc/neutron-config-generator.conf":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f29a2f4ddaffccc92b52669531be885b4e8412da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d etc/neutron.conf.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron"}],"source_content_type":"text/plain","patch_set":4,"id":"3a50d1a3_0f0b03d7","line":2,"updated":"2015-07-23 16:36:37.000000000","message":"Current neutron config is splitted in multiple config files, the generator will put all options in a unique file?","commit_id":"1d4fe92853fb76f3255aebde928d5f15d0309e2f"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"bd41db48b19422b249acb08b57b534b4a651a874","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"output_file \u003d etc/neutron.conf.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron"}],"source_content_type":"text/plain","patch_set":4,"id":"3a50d1a3_afd74122","line":2,"in_reply_to":"3a50d1a3_0f0b03d7","updated":"2015-07-24 13:12:19.000000000","message":"No, this is just generating a replacement for the current neturon.conf. Later patches can generate the other config files.","commit_id":"1d4fe92853fb76f3255aebde928d5f15d0309e2f"}],"etc/oslo-config-generator/dhcp_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.dhcp.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_0ce02f95","line":7,"updated":"2015-11-19 13:10:04.000000000","message":"oslo.log is imported into neutron.conf that is meant to be read by all services, so I don\u0027t think it should be imported into each service specific config file.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6f22877dd609c0672bd98b37936e72c077e00eda","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.dhcp.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_9f5afcf0","line":7,"in_reply_to":"ba8a016a_0ce02f95","updated":"2015-11-19 13:11:42.000000000","message":"Or should it? I can\u0027t make my mind now that I understand that debug option belongs there. Sigh.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.dhcp.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_990adf78","line":7,"in_reply_to":"ba8a016a_9f5afcf0","updated":"2015-11-20 14:43:32.000000000","message":"I am confused myself. Some of the config files include it so I am following that pattern for the moment.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.dhcp.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":19,"id":"9a8ffd7b_cd0cfc44","line":7,"updated":"2015-11-25 00:35:53.000000000","message":"Why do we need oslo.log?","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.dhcp.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":19,"id":"9a8ffd7b_8bb6cada","line":7,"in_reply_to":"9a8ffd7b_cd0cfc44","updated":"2015-11-25 12:57:24.000000000","message":"\"debug\" item is specified in \u0027dhcp_agent.ini\u0027, so following the current config file.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"}],"etc/oslo-config-generator/l3_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.l3.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_acf1e36c","line":7,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.base.agent"},{"line_number":6,"context_line":"namespace \u003d neutron.l3.agent"},{"line_number":7,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_b986c3d9","line":7,"in_reply_to":"ba8a016a_acf1e36c","updated":"2015-11-20 14:43:32.000000000","message":"Same response WRT some config files included it.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"etc/oslo-config-generator/linuxbridge_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/neutron/plugins/ml2/linuxbridge_agent.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.ml2.linuxbridge.agent"}],"source_content_type":"text/x-properties","patch_set":20,"id":"9a8ffd7b_13775a3b","line":5,"updated":"2015-11-25 16:06:48.000000000","message":"so if we have oslo.log in other files, why not everywhere?","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/neutron/plugins/ml2/linuxbridge_agent.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.ml2.linuxbridge.agent"}],"source_content_type":"text/x-properties","patch_set":20,"id":"9a8ffd7b_97a9e8e1","line":5,"in_reply_to":"9a8ffd7b_13775a3b","updated":"2015-11-25 20:18:01.000000000","message":"Same comment applies to other L2 agent configuration files. I think they use logging options from neutron.conf. However, supporting separate logging options for L2 agents makes sense because they typically log to separate files like other agents.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/neutron/plugins/ml2/linuxbridge_agent.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.ml2.linuxbridge.agent"}],"source_content_type":"text/x-properties","patch_set":20,"id":"9a8ffd7b_453f1c24","line":5,"in_reply_to":"9a8ffd7b_97a9e8e1","updated":"2015-11-26 18:24:02.000000000","message":"Following consensus on IRC, oslo.log settings to be added to all config files.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"etc/oslo-config-generator/metadata_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.metadata.agent"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_4c015737","line":6,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.metadata.agent"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_394ad3ad","line":6,"in_reply_to":"ba8a016a_4c015737","updated":"2015-11-20 14:43:32.000000000","message":"Same response WRT some config files included it.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"etc/oslo-config-generator/metering_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.metering.agent"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_ac98031d","line":6,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.metering.agent"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_b9d483bd","line":6,"in_reply_to":"ba8a016a_ac98031d","updated":"2015-11-20 14:43:32.000000000","message":"Same response WRT some config files included it.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"etc/oslo-config-generator/neutron.conf":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"5525ff3b5e5c37113ffa381c8d059b62083a715d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"namespace \u003d neutron.extensions"},{"line_number":9,"context_line":"namespace \u003d neutron.qos"},{"line_number":10,"context_line":"namespace \u003d nova.auth"},{"line_number":11,"context_line":"namespace \u003d oslo.log"},{"line_number":12,"context_line":"namespace \u003d oslo.db"},{"line_number":13,"context_line":"namespace \u003d oslo.policy"},{"line_number":14,"context_line":"namespace \u003d oslo.concurrency"}],"source_content_type":"text/plain","patch_set":20,"id":"9a8ffd7b_65a93b7b","line":11,"updated":"2015-11-25 20:30:40.000000000","message":"it means oslo.log options will be in neutron.conf and agent conf?","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"namespace \u003d neutron.extensions"},{"line_number":9,"context_line":"namespace \u003d neutron.qos"},{"line_number":10,"context_line":"namespace \u003d nova.auth"},{"line_number":11,"context_line":"namespace \u003d oslo.log"},{"line_number":12,"context_line":"namespace \u003d oslo.db"},{"line_number":13,"context_line":"namespace \u003d oslo.policy"},{"line_number":14,"context_line":"namespace \u003d oslo.concurrency"}],"source_content_type":"text/plain","patch_set":20,"id":"9a8ffd7b_658100c3","line":11,"in_reply_to":"9a8ffd7b_4e7f4b66","updated":"2015-11-26 18:24:02.000000000","message":"oslo.log stays then.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88c36ce28714a68954b0ac3ed5ed12e1cd1993c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"namespace \u003d neutron.extensions"},{"line_number":9,"context_line":"namespace \u003d neutron.qos"},{"line_number":10,"context_line":"namespace \u003d nova.auth"},{"line_number":11,"context_line":"namespace \u003d oslo.log"},{"line_number":12,"context_line":"namespace \u003d oslo.db"},{"line_number":13,"context_line":"namespace \u003d oslo.policy"},{"line_number":14,"context_line":"namespace \u003d oslo.concurrency"}],"source_content_type":"text/plain","patch_set":20,"id":"9a8ffd7b_4e7f4b66","line":11,"in_reply_to":"9a8ffd7b_65a93b7b","updated":"2015-11-26 11:01:04.000000000","message":"As it\u0027s currently the case for some (most? all?) agent config files.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"neutron/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ROOT_HELPER_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027,"},{"line_number":30,"context_line":"               help\u003d_(\"Root helper application.\""},{"line_number":31,"context_line":"                      \"Use \u0027sudo neutron-rootwrap /etc/neutron/rootwrap.conf\u0027 \""},{"line_number":32,"context_line":"                      \"to use the real root filter facility. Change to \u0027sudo\u0027 \""},{"line_number":33,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":34,"context_line":"                      \"directly.\")),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_e6845fb2","line":31,"updated":"2015-11-14 17:36:17.000000000","message":"You miss a space before Use","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ROOT_HELPER_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027,"},{"line_number":30,"context_line":"               help\u003d_(\"Root helper application.\""},{"line_number":31,"context_line":"                      \"Use \u0027sudo neutron-rootwrap /etc/neutron/rootwrap.conf\u0027 \""},{"line_number":32,"context_line":"                      \"to use the real root filter facility. Change to \u0027sudo\u0027 \""},{"line_number":33,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":34,"context_line":"                      \"directly.\")),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e5625c16","line":31,"in_reply_to":"da85f559_e6845fb2","updated":"2015-11-16 14:31:54.000000000","message":"Added.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":71,"context_line":"IPTABLES_OPTS \u003d ["},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027comment_iptables_rules\u0027, default\u003dTrue,"},{"line_number":73,"context_line":"                help\u003d_(\"Add comments to iptables rules.\""},{"line_number":74,"context_line":"                       \"Set to true to add comments to generated iptables \""},{"line_number":75,"context_line":"                       \"rules that describe each rule\u0027s purpose. (System must \""},{"line_number":76,"context_line":"                       \"support the iptables comments module.)\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_869313fa","line":74,"updated":"2015-11-14 17:36:17.000000000","message":"space before Set missing. Also, I think the wording here is not ideal since True is the default value, so it\u0027s not correct to suggest to set it to some value if comments are to be used.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":71,"context_line":"IPTABLES_OPTS \u003d ["},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027comment_iptables_rules\u0027, default\u003dTrue,"},{"line_number":73,"context_line":"                help\u003d_(\"Add comments to iptables rules.\""},{"line_number":74,"context_line":"                       \"Set to true to add comments to generated iptables \""},{"line_number":75,"context_line":"                       \"rules that describe each rule\u0027s purpose. (System must \""},{"line_number":76,"context_line":"                       \"support the iptables comments module.)\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_77413f39","line":74,"in_reply_to":"da85f559_869313fa","updated":"2015-11-16 14:31:54.000000000","message":"Space added. Text rewritten to describe the setting of False value.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DHCP_AGENT_OPTS \u003d ["},{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"The DHCP agent will resync its state with Neutron to \""},{"line_number":22,"context_line":"                      \"recover from any transient notification or rpc errors. \""},{"line_number":23,"context_line":"                      \"seconds between attempts.\")),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027neutron.agent.linux.dhcp.Dnsmasq\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_273e6cc1","line":22,"updated":"2015-11-19 13:10:04.000000000","message":"rpc -\u003e RPC","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DHCP_AGENT_OPTS \u003d ["},{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"The DHCP agent will resync its state with Neutron to \""},{"line_number":22,"context_line":"                      \"recover from any transient notification or rpc errors. \""},{"line_number":23,"context_line":"                      \"seconds between attempts.\")),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027neutron.agent.linux.dhcp.Dnsmasq\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_64c3d28b","line":22,"in_reply_to":"ba8a016a_273e6cc1","updated":"2015-11-20 14:43:32.000000000","message":"Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"The DHCP agent will resync its state with Neutron to \""},{"line_number":22,"context_line":"                      \"recover from any transient notification or rpc errors. \""},{"line_number":23,"context_line":"                      \"seconds between attempts.\")),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027neutron.agent.linux.dhcp.Dnsmasq\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\"The driver used to manage the DHCP server.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_e74aa454","line":23,"updated":"2015-11-19 13:10:04.000000000","message":"I guess \u0027seconds\u0027 should be upper case, and maybe a verb is missing here (like \u0027Stands for seconds between attempts.\u0027)","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"The DHCP agent will resync its state with Neutron to \""},{"line_number":22,"context_line":"                      \"recover from any transient notification or rpc errors. \""},{"line_number":23,"context_line":"                      \"seconds between attempts.\")),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027neutron.agent.linux.dhcp.Dnsmasq\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\"The driver used to manage the DHCP server.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_24bdca02","line":23,"in_reply_to":"ba8a016a_e74aa454","updated":"2015-11-20 14:43:32.000000000","message":"Yes, some words missing indeed! :) Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \"121). This option doesn\u0027t have any effect when \""},{"line_number":36,"context_line":"                       \"force_metadata is set to True.\")),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027force_metadata\u0027, default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d_(\"In some cases the neutron router is not present to \""},{"line_number":39,"context_line":"                       \"provide the metadata IP but the DHCP server can be \""},{"line_number":40,"context_line":"                       \"used to provide this info. Setting this value will \""},{"line_number":41,"context_line":"                       \"force the DHCP server to append specific host routes \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_075d6814","line":38,"updated":"2015-11-19 13:10:04.000000000","message":"neutron -\u003e Neutron","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \"121). This option doesn\u0027t have any effect when \""},{"line_number":36,"context_line":"                       \"force_metadata is set to True.\")),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027force_metadata\u0027, default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d_(\"In some cases the neutron router is not present to \""},{"line_number":39,"context_line":"                       \"provide the metadata IP but the DHCP server can be \""},{"line_number":40,"context_line":"                       \"used to provide this info. Setting this value will \""},{"line_number":41,"context_line":"                       \"force the DHCP server to append specific host routes \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_c444fe1c","line":38,"in_reply_to":"ba8a016a_075d6814","updated":"2015-11-20 14:43:32.000000000","message":"Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":41,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":42,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":43,"context_line":"                      \"linux bridge. When this parameter is set, each L3 \""},{"line_number":44,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":45,"context_line":"                      \"network.This option is deprecated and will be removed \""},{"line_number":46,"context_line":"                      \"in the M release.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_e78f0473","line":43,"updated":"2015-11-19 13:10:04.000000000","message":"linux bridge -\u003e Linux Bridge","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":41,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":42,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":43,"context_line":"                      \"linux bridge. When this parameter is set, each L3 \""},{"line_number":44,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":45,"context_line":"                      \"network.This option is deprecated and will be removed \""},{"line_number":46,"context_line":"                      \"in the M release.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_84e35605","line":43,"in_reply_to":"ba8a016a_e78f0473","updated":"2015-11-20 14:43:32.000000000","message":"Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":43,"context_line":"                      \"linux bridge. When this parameter is set, each L3 \""},{"line_number":44,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":45,"context_line":"                      \"network.This option is deprecated and will be removed \""},{"line_number":46,"context_line":"                      \"in the M release.\")),"},{"line_number":47,"context_line":"    cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":48,"context_line":"                default\u003d9697,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_67f23408","line":45,"updated":"2015-11-19 13:10:04.000000000","message":"missing space before \u0027This\u0027","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \"traffic. This should be set to an empty value for the \""},{"line_number":43,"context_line":"                      \"linux bridge. When this parameter is set, each L3 \""},{"line_number":44,"context_line":"                      \"agent can be associated with no more than one external \""},{"line_number":45,"context_line":"                      \"network.This option is deprecated and will be removed \""},{"line_number":46,"context_line":"                      \"in the M release.\")),"},{"line_number":47,"context_line":"    cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":48,"context_line":"                default\u003d9697,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_c4b71ef4","line":45,"in_reply_to":"ba8a016a_67f23408","updated":"2015-11-20 14:43:32.000000000","message":"Space added.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90154f9db3e794a033049820d487bb66503eec75","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \"with DVR.  This mode must be used for an L3 agent \""},{"line_number":37,"context_line":"                      \"running on a centralized node (or in single-host \""},{"line_number":38,"context_line":"                      \"deployments, e.g. devstack)\")),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":40,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":41,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":42,"context_line":"                      \"traffic. This option is deprecated and will be removed \""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a8ffd7b_69fb00c2","side":"PARENT","line":39,"updated":"2015-11-27 08:11:25.000000000","message":"You should also add the option to the list, f.e. with + at the end. Otherwise gate jobs fail for you.","commit_id":"749089115727a42185bd0e99407887a99968901e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"77b9032dfd7077919a13e2bfe76c48834907ec10","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \"with DVR.  This mode must be used for an L3 agent \""},{"line_number":37,"context_line":"                      \"running on a centralized node (or in single-host \""},{"line_number":38,"context_line":"                      \"deployments, e.g. devstack)\")),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":40,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":41,"context_line":"               help\u003d_(\"Name of bridge used for external network \""},{"line_number":42,"context_line":"                      \"traffic. This option is deprecated and will be removed \""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a8ffd7b_99530839","side":"PARENT","line":39,"in_reply_to":"9a8ffd7b_69fb00c2","updated":"2015-11-27 11:55:29.000000000","message":"Unsure what you mean. Could you elaborate please? There was a bug in neutron/cmd/ovs_cleanup.py which should fix the gate issue.","commit_id":"749089115727a42185bd0e99407887a99968901e"}],"neutron/agent/ovsdb/api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               help\u003d_(\u0027The interface for interacting with the OVSDB\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027tcp:127.0.0.1:6640\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027The connection string for the native OVSDB backend\u0027))"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":"cfg.CONF.register_opts(OPTS, \u0027OVS\u0027)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_27ebcce0","line":35,"updated":"2015-11-19 13:10:04.000000000","message":"I guess we may want to note that it\u0027s used when native ovsdb_interface is enabled, only.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               help\u003d_(\u0027The interface for interacting with the OVSDB\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027tcp:127.0.0.1:6640\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027The connection string for the native OVSDB backend\u0027))"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":"cfg.CONF.register_opts(OPTS, \u0027OVS\u0027)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_ff298b8a","line":35,"in_reply_to":"ba8a016a_27ebcce0","updated":"2015-11-20 14:43:32.000000000","message":"Added sentence.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/agent/ovsdb/impl_idl.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(twilson) DEFAULT.ovs_vsctl_timeout should be OVS.vsctl_timeout"},{"line_number":30,"context_line":"cfg.CONF.import_opt(\u0027ovs_vsctl_timeout\u0027, \u0027neutron.agent.common.ovs_lib\u0027)"},{"line_number":31,"context_line":"cfg.CONF.import_opt(\u0027ovsdb_connection\u0027, \u0027neutron.agent.ovsdb.api\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_e775c431","line":31,"updated":"2015-11-19 13:10:04.000000000","message":"It is not a compatible change: you miss OVS section for the option. So setups with the url configured under [ovs] would be broken by the change.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(twilson) DEFAULT.ovs_vsctl_timeout should be OVS.vsctl_timeout"},{"line_number":30,"context_line":"cfg.CONF.import_opt(\u0027ovs_vsctl_timeout\u0027, \u0027neutron.agent.common.ovs_lib\u0027)"},{"line_number":31,"context_line":"cfg.CONF.import_opt(\u0027ovsdb_connection\u0027, \u0027neutron.agent.ovsdb.api\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_3fc4f35d","line":31,"in_reply_to":"ba8a016a_e775c431","updated":"2015-11-20 14:43:32.000000000","message":"Changed it to register the opts to OVS.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class OvsdbIdl(api.API):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    ovsdb_connection \u003d connection.Connection(cfg.CONF.ovsdb_connection,"},{"line_number":114,"context_line":"                                             cfg.CONF.ovs_vsctl_timeout,"},{"line_number":115,"context_line":"                                             \u0027Open_vSwitch\u0027)"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_879b9865","line":113,"updated":"2015-11-19 13:10:04.000000000","message":"and that line reveals there is a problem with the change above.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class OvsdbIdl(api.API):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    ovsdb_connection \u003d connection.Connection(cfg.CONF.ovsdb_connection,"},{"line_number":114,"context_line":"                                             cfg.CONF.ovs_vsctl_timeout,"},{"line_number":115,"context_line":"                                             \u0027Open_vSwitch\u0027)"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7f911b52","line":113,"in_reply_to":"ba8a016a_879b9865","updated":"2015-11-20 14:43:32.000000000","message":"Change made to OVS.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \"extensions:/path/to/more/exts:/even/more/exts. \""},{"line_number":49,"context_line":"                      \"The __path__ of neutron.extensions is appended to \""},{"line_number":50,"context_line":"                      \"this, so if your extensions are in there you don\u0027t \""},{"line_number":51,"context_line":"                      \"need to specify them here \")),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_66bf0f61","line":51,"updated":"2015-11-14 17:36:17.000000000","message":"Trailing space. Instead, add a dot there.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \"extensions:/path/to/more/exts:/even/more/exts. \""},{"line_number":49,"context_line":"                      \"The __path__ of neutron.extensions is appended to \""},{"line_number":50,"context_line":"                      \"this, so if your extensions are in there you don\u0027t \""},{"line_number":51,"context_line":"                      \"need to specify them here \")),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_2a76f33e","line":51,"in_reply_to":"da85f559_66bf0f61","updated":"2015-11-16 14:31:54.000000000","message":"Done.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use\""},{"line_number":56,"context_line":"                      \"Neutron core plugin entrypoint to be loaded from the \""},{"line_number":57,"context_line":"                      \"neutron.core_plugins namespace. See setup.cfg for the \""},{"line_number":58,"context_line":"                      \"entrypoint names of the plugins included in the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_06b6438a","line":55,"updated":"2015-11-14 17:36:17.000000000","message":"You miss a dot and a space at the end","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use\""},{"line_number":56,"context_line":"                      \"Neutron core plugin entrypoint to be loaded from the \""},{"line_number":57,"context_line":"                      \"neutron.core_plugins namespace. See setup.cfg for the \""},{"line_number":58,"context_line":"                      \"entrypoint names of the plugins included in the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_eab54bd0","line":55,"in_reply_to":"da85f559_06b6438a","updated":"2015-11-16 14:31:54.000000000","message":"Done.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \"neutron source distribution. For compatibility with \""},{"line_number":60,"context_line":"                      \"previous versions, the class name of a plugin can be \""},{"line_number":61,"context_line":"                      \"specified instead of its entrypoint name. \""},{"line_number":62,"context_line":"                      \"Example: core_plugin \u003d ml2\")),"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":64,"context_line":"                help\u003d_(\"The service plugins Neutron will use. \""},{"line_number":65,"context_line":"                       \"List of service plugin entrypoints to be loaded from \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_4663eb1a","line":62,"updated":"2015-11-14 17:36:17.000000000","message":"I don\u0027t believe that \u0027Example ...\u0027 piece belongs anywhere. It is also misleading because it seems like you suggest using a class name, and then give an example with alias.\n\nI also don\u0027t believe we should advertise using class names in any way. Yes, it works, but it\u0027s not strictly supported.\n\nI don\u0027t even like the reference to setup.cfg because it\u0027s not usually available to deployers using binary packages. Yes, deployers probably need some user friendly way to detect what\u0027s available on the system, but it should not require reading source code.\n\nHonestly, I would ditch the update for the option and leave it as is.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \"neutron source distribution. For compatibility with \""},{"line_number":60,"context_line":"                      \"previous versions, the class name of a plugin can be \""},{"line_number":61,"context_line":"                      \"specified instead of its entrypoint name. \""},{"line_number":62,"context_line":"                      \"Example: core_plugin \u003d ml2\")),"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":64,"context_line":"                help\u003d_(\"The service plugins Neutron will use. \""},{"line_number":65,"context_line":"                       \"List of service plugin entrypoints to be loaded from \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_0ae20fd6","line":62,"in_reply_to":"da85f559_4663eb1a","updated":"2015-11-16 14:31:54.000000000","message":"Ok, removed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                       \"with previous versions, the class name of a plugin \""},{"line_number":70,"context_line":"                       \"can be specified instead of its entrypoint name.\""},{"line_number":71,"context_line":"                       \"Example: service_plugins \u003d \""},{"line_number":72,"context_line":"                       \"router,firewall,lbaas,vpnaas,metering,qos\")),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","},{"line_number":74,"context_line":"               help\u003d_(\"The base MAC address Neutron will use for VIFs. \""},{"line_number":75,"context_line":"                      \"The first 3 octets will remain unchanged. If the 4th \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_06440372","line":72,"updated":"2015-11-14 17:36:17.000000000","message":"Same.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                       \"with previous versions, the class name of a plugin \""},{"line_number":70,"context_line":"                       \"can be specified instead of its entrypoint name.\""},{"line_number":71,"context_line":"                       \"Example: service_plugins \u003d \""},{"line_number":72,"context_line":"                       \"router,firewall,lbaas,vpnaas,metering,qos\")),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","},{"line_number":74,"context_line":"               help\u003d_(\"The base MAC address Neutron will use for VIFs. \""},{"line_number":75,"context_line":"                      \"The first 3 octets will remain unchanged. If the 4th \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_aafd0370","line":72,"in_reply_to":"da85f559_06440372","updated":"2015-11-16 14:31:54.000000000","message":"Ok, removed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                      \"octet is not 00, it will also be used. The others \""},{"line_number":77,"context_line":"                      \"will be randomly generated. \""},{"line_number":78,"context_line":"                      \"3 octet, base_mac \u003d fa:16:3e:00:00:00\""},{"line_number":79,"context_line":"                      \"4 octet, base_mac \u003d fa:16:3e:4f:00:00\")),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027mac_generation_retries\u0027, default\u003d16,"},{"line_number":81,"context_line":"               help\u003d_(\"How many times Neutron will retry MAC generation\")),"},{"line_number":82,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_e620dfb2","line":79,"updated":"2015-11-14 17:36:17.000000000","message":"The text addition is helpful, but I am not sure I get these two lines. Can anyone decipher it, and if not, why is it here?","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                      \"octet is not 00, it will also be used. The others \""},{"line_number":77,"context_line":"                      \"will be randomly generated. \""},{"line_number":78,"context_line":"                      \"3 octet, base_mac \u003d fa:16:3e:00:00:00\""},{"line_number":79,"context_line":"                      \"4 octet, base_mac \u003d fa:16:3e:4f:00:00\")),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027mac_generation_retries\u0027, default\u003d16,"},{"line_number":81,"context_line":"               help\u003d_(\"How many times Neutron will retry MAC generation\")),"},{"line_number":82,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_ea11cbb0","line":79,"in_reply_to":"da85f559_e620dfb2","updated":"2015-11-16 14:31:54.000000000","message":"Ok, removed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":98,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port. This option \""},{"line_number":99,"context_line":"                      \"is deprecated and will be removed in the N \""},{"line_number":100,"context_line":"                      \"release.\")),"},{"line_number":101,"context_line":"    cfg.StrOpt(\u0027default_ipv4_subnet_pool\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":102,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_811d3d68","line":101,"updated":"2015-11-14 17:36:17.000000000","message":"thanks for marking it properly!","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":98,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port. This option \""},{"line_number":99,"context_line":"                      \"is deprecated and will be removed in the N \""},{"line_number":100,"context_line":"                      \"release.\")),"},{"line_number":101,"context_line":"    cfg.StrOpt(\u0027default_ipv4_subnet_pool\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":102,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_2a2033f7","line":101,"in_reply_to":"da85f559_811d3d68","updated":"2015-11-16 14:31:54.000000000","message":"Sure,it actually was a rebase catch! :)","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":102,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_212331a9","line":105,"updated":"2015-11-14 17:36:17.000000000","message":"Not sure what \u0027subnet-create\u0027 is in neutron context. I guess we refer to neutronclient CLI command, but it\u0027s not exposed into API in that way (it\u0027s just a POST for subnet resource), so I think we better use some neutron language that does not refer to particular client.\n\nSame in multiple cases below.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":102,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_4a55771b","line":105,"in_reply_to":"da85f559_212331a9","updated":"2015-11-16 14:31:54.000000000","message":"Updated here and below.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""},{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_8606b31e","line":106,"updated":"2015-11-14 17:36:17.000000000","message":"None? I am not sure we should mention the internal details (the fact that oslo.config represents default values with None) in user visible options. Instead, let\u0027s say smth neutral, like \u0027If not set, no pool will be used...\u0027","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""},{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_aa11835f","line":106,"in_reply_to":"da85f559_8606b31e","updated":"2015-11-16 14:31:54.000000000","message":"Updated.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""},{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""},{"line_number":110,"context_line":"                      \"pool; it will be considered part of the tenant\u0027s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_41ff5501","line":107,"updated":"2015-11-14 17:36:17.000000000","message":"Any reason for two spaces?","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      \"Specifies by UUID the pool to be used in case of \""},{"line_number":105,"context_line":"                      \"subnet-create being called without a subnet-pool ID. \""},{"line_number":106,"context_line":"                      \"The default of None means that no pool will be used \""},{"line_number":107,"context_line":"                      \"unless passed explicitly to subnet create.  If no \""},{"line_number":108,"context_line":"                      \"pool is used, then a CIDR must be passed to create a \""},{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""},{"line_number":110,"context_line":"                      \"pool; it will be considered part of the tenant\u0027s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_e5fedc04","line":107,"in_reply_to":"da85f559_41ff5501","updated":"2015-11-16 14:31:54.000000000","message":"One space removed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""},{"line_number":110,"context_line":"                      \"pool; it will be considered part of the tenant\u0027s \""},{"line_number":111,"context_line":"                      \"private address space. This option is deprecated for \""},{"line_number":112,"context_line":"                      \"removal in the N release\")),"},{"line_number":113,"context_line":"    cfg.StrOpt(\u0027default_ipv6_subnet_pool\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":114,"context_line":"               help\u003d_(\"Default IPv6 subnet-pool to be used for automatic \""},{"line_number":115,"context_line":"                      \"subnet CIDR allocation.\""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_210c913a","line":112,"updated":"2015-11-14 17:36:17.000000000","message":"please add a dot to the end.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                      \"subnet and that subnet will not be allocated from any \""},{"line_number":110,"context_line":"                      \"pool; it will be considered part of the tenant\u0027s \""},{"line_number":111,"context_line":"                      \"private address space. This option is deprecated for \""},{"line_number":112,"context_line":"                      \"removal in the N release\")),"},{"line_number":113,"context_line":"    cfg.StrOpt(\u0027default_ipv6_subnet_pool\u0027, deprecated_for_removal\u003dTrue,"},{"line_number":114,"context_line":"               help\u003d_(\"Default IPv6 subnet-pool to be used for automatic \""},{"line_number":115,"context_line":"                      \"subnet CIDR allocation.\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_4531e8eb","line":112,"in_reply_to":"da85f559_210c913a","updated":"2015-11-16 14:31:54.000000000","message":"Done.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.BoolOpt(\u0027ipv6_pd_enabled\u0027, default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d_(\"Enables IPv6 Prefix Delegation for automatic subnet \""},{"line_number":123,"context_line":"                       \"CIDR allocation.\""},{"line_number":124,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_c13a65cd","line":124,"updated":"2015-11-14 17:36:17.000000000","message":"You miss space before Set","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.BoolOpt(\u0027ipv6_pd_enabled\u0027, default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d_(\"Enables IPv6 Prefix Delegation for automatic subnet \""},{"line_number":123,"context_line":"                       \"CIDR allocation.\""},{"line_number":124,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_053c4092","line":124,"in_reply_to":"da85f559_c13a65cd","updated":"2015-11-16 14:31:54.000000000","message":"Added.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                help\u003d_(\"Enables IPv6 Prefix Delegation for automatic subnet \""},{"line_number":123,"context_line":"                       \"CIDR allocation.\""},{"line_number":124,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""},{"line_number":128,"context_line":"                       \"cidr via the Prefix Delegation mechanism. Note that \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_a12f2187","line":125,"updated":"2015-11-14 17:36:17.000000000","message":"why is there a dash in \u0027subnet allocation\u0027?","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                help\u003d_(\"Enables IPv6 Prefix Delegation for automatic subnet \""},{"line_number":123,"context_line":"                       \"CIDR allocation.\""},{"line_number":124,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""},{"line_number":128,"context_line":"                       \"cidr via the Prefix Delegation mechanism. Note that \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_a540d408","line":125,"in_reply_to":"da85f559_a12f2187","updated":"2015-11-16 14:31:54.000000000","message":"Removed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""},{"line_number":128,"context_line":"                       \"cidr via the Prefix Delegation mechanism. Note that \""},{"line_number":129,"context_line":"                       \"enabling PD will override the behavior of the default \""},{"line_number":130,"context_line":"                       \"IPv6 subnetpool.\")),"},{"line_number":131,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_duration\u0027, default\u003d86400,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_01570d03","line":128,"updated":"2015-11-14 17:36:17.000000000","message":"cidr -\u003e CIDR","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                       \"subnet-allocation in a PD-capable environment. Users \""},{"line_number":126,"context_line":"                       \"making subnet-create requests for v6 subnets without \""},{"line_number":127,"context_line":"                       \"providing a cidr or subnetpool ID will be given a \""},{"line_number":128,"context_line":"                       \"cidr via the Prefix Delegation mechanism. Note that \""},{"line_number":129,"context_line":"                       \"enabling PD will override the behavior of the default \""},{"line_number":130,"context_line":"                       \"IPv6 subnetpool.\")),"},{"line_number":131,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_duration\u0027, default\u003d86400,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_2555c4c5","line":128,"in_reply_to":"da85f559_01570d03","updated":"2015-11-16 14:31:54.000000000","message":"Changed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                       \" notification to DHCP agent\")),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027allow_overlapping_ips\u0027, default\u003dFalse,"},{"line_number":142,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron.\""},{"line_number":143,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":144,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":145,"context_line":"                       \"nova security groups.\")),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_e13c49c1","line":143,"updated":"2015-11-14 17:36:17.000000000","message":"Missing space before Attention","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                       \" notification to DHCP agent\")),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027allow_overlapping_ips\u0027, default\u003dFalse,"},{"line_number":142,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron.\""},{"line_number":143,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":144,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":145,"context_line":"                       \"nova security groups.\")),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_050a00d3","line":143,"in_reply_to":"da85f559_e13c49c1","updated":"2015-11-16 14:31:54.000000000","message":"Added.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron.\""},{"line_number":143,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":144,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":145,"context_line":"                       \"nova security groups.\")),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"},{"line_number":147,"context_line":"               help\u003d_(\"Hostname to be used by the neutron server, agents and \""},{"line_number":148,"context_line":"                      \"services running on this machine. All the agents and \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_814bfd58","line":145,"updated":"2015-11-14 17:36:17.000000000","message":"nova -\u003e Nova","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                help\u003d_(\"Allow overlapping IP support in Neutron.\""},{"line_number":143,"context_line":"                       \"Attention: the following parameter MUST be set to \""},{"line_number":144,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":145,"context_line":"                       \"nova security groups.\")),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"},{"line_number":147,"context_line":"               help\u003d_(\"Hostname to be used by the neutron server, agents and \""},{"line_number":148,"context_line":"                      \"services running on this machine. All the agents and \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_65f98cc8","line":145,"in_reply_to":"da85f559_814bfd58","updated":"2015-11-16 14:31:54.000000000","message":"Changed.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to be \""},{"line_number":171,"context_line":"                      \"loaded from the neutron.ipam_drivers namespace. \""},{"line_number":172,"context_line":"                      \"See setup.cfg for the entry point names. \""},{"line_number":173,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":174,"context_line":"                      \"driver is used. Example: ipam_driver \u003d \""},{"line_number":175,"context_line":"                      \"In order to use the reference implementation of \""},{"line_number":176,"context_line":"                      \"neutron ipam driver, use \u0027internal\u0027. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_6177f99f","line":173,"updated":"2015-11-14 17:36:17.000000000","message":"I believe the only worthy addition here is 1) describing of default behaviour; 2) alias for internal implementation.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to be \""},{"line_number":171,"context_line":"                      \"loaded from the neutron.ipam_drivers namespace. \""},{"line_number":172,"context_line":"                      \"See setup.cfg for the entry point names. \""},{"line_number":173,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":174,"context_line":"                      \"driver is used. Example: ipam_driver \u003d \""},{"line_number":175,"context_line":"                      \"In order to use the reference implementation of \""},{"line_number":176,"context_line":"                      \"neutron ipam driver, use \u0027internal\u0027. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_45c1e82d","line":173,"in_reply_to":"da85f559_6177f99f","updated":"2015-11-16 14:31:54.000000000","message":"Updated.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use.\")),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":57,"context_line":"                help\u003d_(\"The service plugins Neutron will use.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_87e958b9","line":55,"updated":"2015-11-19 13:10:04.000000000","message":"no reason for the change, and you change a translatable message, so better avoid it.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\"The type of authentication to use\")),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use.\")),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":57,"context_line":"                help\u003d_(\"The service plugins Neutron will use.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7f9fdb50","line":55,"in_reply_to":"ba8a016a_87e958b9","updated":"2015-11-20 14:43:32.000000000","message":"ok, \u0027.\u0027 removed.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use.\")),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":57,"context_line":"                help\u003d_(\"The service plugins Neutron will use.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","},{"line_number":59,"context_line":"               help\u003d_(\"The base MAC address Neutron will use for VIFs. \""},{"line_number":60,"context_line":"                      \"The first 3 octets will remain unchanged. If the 4th \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_e7daa416","line":57,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027core_plugin\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\"The core plugin Neutron will use.\")),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[],"},{"line_number":57,"context_line":"                help\u003d_(\"The service plugins Neutron will use.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027base_mac\u0027, default\u003d\"fa:16:3e:00:00:00\","},{"line_number":59,"context_line":"               help\u003d_(\"The base MAC address Neutron will use for VIFs. \""},{"line_number":60,"context_line":"                      \"The first 3 octets will remain unchanged. If the 4th \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_3fa9537c","line":57,"in_reply_to":"ba8a016a_e7daa416","updated":"2015-11-20 14:43:32.000000000","message":"repeated as above.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":87,"context_line":"                      \"Specifies by UUID the pool to be used in case where \""},{"line_number":88,"context_line":"                      \"creation of a subnet is being called without a \""},{"line_number":89,"context_line":"                      \"subnet pool ID. The not set then no pool \""},{"line_number":90,"context_line":"                      \"will be used unless passed explicitly to subnet \""},{"line_number":91,"context_line":"                      \"create. If no pool is used, then a CIDR must be passed \""},{"line_number":92,"context_line":"                      \"to create a subnet and that subnet will not be \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_47f7f08a","line":89,"updated":"2015-11-19 13:10:04.000000000","message":"The not set?.. Probably not in English? ;)","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                      \"subnet CIDR allocation. \""},{"line_number":87,"context_line":"                      \"Specifies by UUID the pool to be used in case where \""},{"line_number":88,"context_line":"                      \"creation of a subnet is being called without a \""},{"line_number":89,"context_line":"                      \"subnet pool ID. The not set then no pool \""},{"line_number":90,"context_line":"                      \"will be used unless passed explicitly to subnet \""},{"line_number":91,"context_line":"                      \"create. If no pool is used, then a CIDR must be passed \""},{"line_number":92,"context_line":"                      \"to create a subnet and that subnet will not be \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7ff4bb86","line":89,"in_reply_to":"ba8a016a_47f7f08a","updated":"2015-11-20 14:43:32.000000000","message":"Probably not!:) Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       \"CIDR allocation. \""},{"line_number":107,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":108,"context_line":"                       \"subnet allocation in a PD-capable environment. Users \""},{"line_number":109,"context_line":"                       \"making subnet creation requests for v6 subnets \""},{"line_number":110,"context_line":"                       \"without providing a CIDR or subnetpool ID will be \""},{"line_number":111,"context_line":"                       \"given a CIDR via the Prefix Delegation mechanism. \""},{"line_number":112,"context_line":"                       \"Note that enabling PD will override the behavior of \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_473e1029","line":109,"updated":"2015-11-19 13:10:04.000000000","message":"v6 -\u003e IPv6","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       \"CIDR allocation. \""},{"line_number":107,"context_line":"                       \"Set to True to enable IPv6 Prefix Delegation for \""},{"line_number":108,"context_line":"                       \"subnet allocation in a PD-capable environment. Users \""},{"line_number":109,"context_line":"                       \"making subnet creation requests for v6 subnets \""},{"line_number":110,"context_line":"                       \"without providing a CIDR or subnetpool ID will be \""},{"line_number":111,"context_line":"                       \"given a CIDR via the Prefix Delegation mechanism. \""},{"line_number":112,"context_line":"                       \"Note that enabling PD will override the behavior of \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_3f45d3b2","line":109,"in_reply_to":"ba8a016a_473e1029","updated":"2015-11-20 14:43:32.000000000","message":"Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":128,"context_line":"                       \"Nova security groups.\")),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"},{"line_number":130,"context_line":"               sample_default\u003dutils.get_hostname(),"},{"line_number":131,"context_line":"               help\u003d_(\"Hostname to be used by the neutron server, agents and \""},{"line_number":132,"context_line":"                      \"services running on this machine. All the agents and \""},{"line_number":133,"context_line":"                      \"services running on this machine must use the same \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_07724811","line":130,"updated":"2015-11-19 13:10:04.000000000","message":"That\u0027s not what I suggested. You should use some static string for sample_default, like sample_default\u003d\u0027example.domain\u0027","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       \"False if Neutron is being used in conjunction with \""},{"line_number":128,"context_line":"                       \"Nova security groups.\")),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"},{"line_number":130,"context_line":"               sample_default\u003dutils.get_hostname(),"},{"line_number":131,"context_line":"               help\u003d_(\"Hostname to be used by the neutron server, agents and \""},{"line_number":132,"context_line":"                      \"services running on this machine. All the agents and \""},{"line_number":133,"context_line":"                      \"services running on this machine must use the same \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_9f587f8c","line":130,"in_reply_to":"ba8a016a_07724811","updated":"2015-11-20 14:43:32.000000000","message":"Ok, changed.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                       \u0027when the network\\\u0027s preferred MTU is known.\u0027)),"},{"line_number":151,"context_line":"    cfg.StrOpt(\u0027ipam_driver\u0027,"},{"line_number":152,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":153,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":154,"context_line":"                      \"driver is used. In order to use the reference \""},{"line_number":155,"context_line":"                      \"implementation of neutron ipam driver, \""},{"line_number":156,"context_line":"                      \"use \u0027internal\u0027.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2758ac87","line":153,"updated":"2015-11-19 13:10:04.000000000","message":"ipam -\u003e IPAM","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                       \u0027when the network\\\u0027s preferred MTU is known.\u0027)),"},{"line_number":151,"context_line":"    cfg.StrOpt(\u0027ipam_driver\u0027,"},{"line_number":152,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":153,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":154,"context_line":"                      \"driver is used. In order to use the reference \""},{"line_number":155,"context_line":"                      \"implementation of neutron ipam driver, \""},{"line_number":156,"context_line":"                      \"use \u0027internal\u0027.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_5fda17eb","line":153,"in_reply_to":"ba8a016a_2758ac87","updated":"2015-11-20 14:43:32.000000000","message":"Done.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":153,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":154,"context_line":"                      \"driver is used. In order to use the reference \""},{"line_number":155,"context_line":"                      \"implementation of neutron ipam driver, \""},{"line_number":156,"context_line":"                      \"use \u0027internal\u0027.\")),"},{"line_number":157,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":158,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0749e8b6","line":155,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":153,"context_line":"                      \"If ipam_driver is not set (default behavior), no ipam \""},{"line_number":154,"context_line":"                      \"driver is used. In order to use the reference \""},{"line_number":155,"context_line":"                      \"implementation of neutron ipam driver, \""},{"line_number":156,"context_line":"                      \"use \u0027internal\u0027.\")),"},{"line_number":157,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":158,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7fd7dbbf","line":155,"in_reply_to":"ba8a016a_0749e8b6","updated":"2015-11-20 14:43:32.000000000","message":"Done.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      \u0027scheduled.\u0027)),"},{"line_number":53,"context_line":"    cfg.IntOpt(\u0027min_l3_agents_per_router\u0027,"},{"line_number":54,"context_line":"               default\u003dconstants.MINIMUM_AGENTS_FOR_HA,"},{"line_number":55,"context_line":"               help\u003d_(\"Maximum number of l3 agents which a HA router will be \""},{"line_number":56,"context_line":"                      \"scheduled on. If it is set to 0 the router will be \""},{"line_number":57,"context_line":"                      \"scheduled on every agent.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027l3_ha_net_cidr\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_c16825bd","line":55,"updated":"2015-11-14 17:36:17.000000000","message":"l3 agents -\u003e L3 agents. Also, I believe you switched the meaning from Minimum to maximum here by mistake.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      \u0027scheduled.\u0027)),"},{"line_number":53,"context_line":"    cfg.IntOpt(\u0027min_l3_agents_per_router\u0027,"},{"line_number":54,"context_line":"               default\u003dconstants.MINIMUM_AGENTS_FOR_HA,"},{"line_number":55,"context_line":"               help\u003d_(\"Maximum number of l3 agents which a HA router will be \""},{"line_number":56,"context_line":"                      \"scheduled on. If it is set to 0 the router will be \""},{"line_number":57,"context_line":"                      \"scheduled on every agent.\")),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027l3_ha_net_cidr\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_17bf93d1","line":55,"in_reply_to":"da85f559_c16825bd","updated":"2015-11-16 14:31:54.000000000","message":"Updated to L3 agents. Changed to Minimum.  Copy/paste from neutron.conf so old inherited error! :)","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"}],"neutron/db/migration/cli.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        alembic_util.err(_(\"Cannot specify both --service and --subproject.\"))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def get_engine_config():"},{"line_number":681,"context_line":"    return [obj for obj in _db_opts if obj.name \u003d\u003d \u0027engine\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_52124c58","line":680,"updated":"2015-11-19 13:10:04.000000000","message":"(No action required) An alternative would be to split _db_opts into two pieces.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        alembic_util.err(_(\"Cannot specify both --service and --subproject.\"))"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def get_engine_config():"},{"line_number":681,"context_line":"    return [obj for obj in _db_opts if obj.name \u003d\u003d \u0027engine\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7f859bab","line":680,"in_reply_to":"ba8a016a_52124c58","updated":"2015-11-20 14:43:32.000000000","message":"Sure, thanks. Will leave as is for the moment unless others want it changed.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/debug/debug_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NeutronDebugAgent(object):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        # Needed for drivers"},{"line_number":41,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":42,"context_line":"                   deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d264fcb9","side":"PARENT","line":39,"updated":"2015-11-19 13:10:04.000000000","message":"See my comment in the next file.","commit_id":"364abc81c88e3e52652fea5e70de71440f94b37d"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NeutronDebugAgent(object):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    OPTS \u003d ["},{"line_number":40,"context_line":"        # Needed for drivers"},{"line_number":41,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":42,"context_line":"                   deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0a78cf8e","side":"PARENT","line":39,"in_reply_to":"ba8a016a_d264fcb9","updated":"2015-11-20 14:43:32.000000000","message":"Referenced and comments added.","commit_id":"364abc81c88e3e52652fea5e70de71440f94b37d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class NeutronDebugAgent(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    OPTS \u003d ["},{"line_number":39,"context_line":"        # Needed for drivers"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":41,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":42,"context_line":"                   help\u003d_(\"Name of bridge used for external network \""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_f32e56f9","side":"PARENT","line":39,"updated":"2015-11-25 16:06:48.000000000","message":"This change is unneeded, it also will expose irrrelevant options to neutron-debug command, which is not optimal.","commit_id":"13f59c40dfe325e5e4c63acca3e2623b6e6d3e76"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class NeutronDebugAgent(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    OPTS \u003d ["},{"line_number":39,"context_line":"        # Needed for drivers"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":41,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":42,"context_line":"                   help\u003d_(\"Name of bridge used for external network \""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_60a9ee8f","side":"PARENT","line":39,"in_reply_to":"9a8ffd7b_981cc214","updated":"2015-11-26 18:24:02.000000000","message":"Agreed, probably best to centralise it in common. Moved config definition.","commit_id":"13f59c40dfe325e5e4c63acca3e2623b6e6d3e76"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d3826bb16a521efe1940bdfc47cbfd45e13beb34","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class NeutronDebugAgent(object):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    OPTS \u003d ["},{"line_number":39,"context_line":"        # Needed for drivers"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"},{"line_number":41,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":42,"context_line":"                   help\u003d_(\"Name of bridge used for external network \""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_981cc214","side":"PARENT","line":39,"in_reply_to":"9a8ffd7b_f32e56f9","updated":"2015-11-25 17:30:35.000000000","message":"OK, I am wrong on that one. Indeed we can catch DuplicatedOptError from oslo.config in tests unless we reuse the same definition everywhere. Note that you updated the option help message in l3_config but not here, so oslo.config complains that it\u0027s not identical (if it would be the same, it would ignore the new option registration).\n\nThe proper way to handle it is to move external_network_bridge definition from l3_config into e.g. neutron/agent/common/config.py and reuse it from there for both l3_config and in shell.py. I just validated the approach locally, and it works fine.","commit_id":"13f59c40dfe325e5e4c63acca3e2623b6e6d3e76"}],"neutron/debug/shell.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":73,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"},{"line_number":75,"context_line":"        cfg.CONF.register_opts(l3_config.OPTS)"},{"line_number":76,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":77,"context_line":"        config.register_use_namespaces_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d2d95c58","line":75,"updated":"2015-11-19 13:10:04.000000000","message":"I am not sure about this change: you now introduce a lot more options from l3.config.OPTS than is probably needed for the debug-agent.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":73,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"},{"line_number":75,"context_line":"        cfg.CONF.register_opts(l3_config.OPTS)"},{"line_number":76,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":77,"context_line":"        config.register_use_namespaces_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_6a407b36","line":75,"in_reply_to":"ba8a016a_d2d95c58","updated":"2015-11-20 14:43:32.000000000","message":"Sure, good point. I did however start getting errors during tox run that was saying \u0027external_network_bridge\u0027 options already loaded. I will leave it in for this PS and revisit it in next PS.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":72,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":73,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(debug_agent.NeutronDebugAgent.OPTS)"},{"line_number":75,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"},{"line_number":77,"context_line":"        config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_3345beb2","side":"PARENT","line":74,"updated":"2015-11-25 16:06:48.000000000","message":"unneeded as per prior comments","commit_id":"13f59c40dfe325e5e4c63acca3e2623b6e6d3e76"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":72,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":73,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"},{"line_number":74,"context_line":"        cfg.CONF.register_opts(debug_agent.NeutronDebugAgent.OPTS)"},{"line_number":75,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"},{"line_number":77,"context_line":"        config.setup_logging()"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_407cea1e","side":"PARENT","line":74,"in_reply_to":"9a8ffd7b_3345beb2","updated":"2015-11-26 18:24:02.000000000","message":"ok, done.","commit_id":"13f59c40dfe325e5e4c63acca3e2623b6e6d3e76"}],"neutron/openstack/common/cache/cache.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    from oslo_config import cfg"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return ["},{"line_number":51,"context_line":"        cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":52,"context_line":"                   help\u003d\u0027URL to connect to the cache back end. \u0027"},{"line_number":53,"context_line":"                        \u0027default_ttl\u003d0 parameter will cause cache entries \u0027"},{"line_number":54,"context_line":"                        \u0027to never expire. Otherwise default_ttl specifies \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d2c2bce8","line":51,"updated":"2015-11-19 13:10:04.000000000","message":"I don\u0027t see where you expose the option into generated config files. It should be put into metadata agent file.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    from oslo_config import cfg"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return ["},{"line_number":51,"context_line":"        cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":52,"context_line":"                   help\u003d\u0027URL to connect to the cache back end. \u0027"},{"line_number":53,"context_line":"                        \u0027default_ttl\u003d0 parameter will cause cache entries \u0027"},{"line_number":54,"context_line":"                        \u0027to never expire. Otherwise default_ttl specifies \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7af7e68c","line":51,"in_reply_to":"ba8a016a_d2c2bce8","updated":"2015-11-20 14:43:32.000000000","message":"From, looking  it would seem \"cache_url\" option is already being generated in \u0027metadata_agent.ini.sample\u0027.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return ["},{"line_number":51,"context_line":"        cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":52,"context_line":"                   help\u003d\u0027URL to connect to the cache back end. \u0027"},{"line_number":53,"context_line":"                        \u0027default_ttl\u003d0 parameter will cause cache entries \u0027"},{"line_number":54,"context_line":"                        \u0027to never expire. Otherwise default_ttl specifies \u0027"},{"line_number":55,"context_line":"                        \u0027time in seconds a cache entry is valid for. No cache \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_b298581d","line":52,"updated":"2015-11-19 13:10:04.000000000","message":"We should not touch the file because it comes from oslo-incubator: https://specs.openstack.org/openstack/oslo-specs/specs/policy/incubator.html#developer-impact\n\nPlease revert the change.\n\nIdeally, we should switch from oslo.cache to something different, like dogpile: https://bugs.launchpad.net/neutron/+bug/1517883","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return ["},{"line_number":51,"context_line":"        cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":52,"context_line":"                   help\u003d\u0027URL to connect to the cache back end. \u0027"},{"line_number":53,"context_line":"                        \u0027default_ttl\u003d0 parameter will cause cache entries \u0027"},{"line_number":54,"context_line":"                        \u0027to never expire. Otherwise default_ttl specifies \u0027"},{"line_number":55,"context_line":"                        \u0027time in seconds a cache entry is valid for. No cache \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_1a8c9a34","line":52,"in_reply_to":"ba8a016a_b298581d","updated":"2015-11-20 14:43:32.000000000","message":"ok, rolled back.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/opts.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b7bf2c75fc97df0c53c0424b8303a9fd2fefa2a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"def list_db_opts():"},{"line_number":65,"context_line":"    return ["},{"line_number":66,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":67,"context_line":"            itertools.chain("},{"line_number":68,"context_line":"                neutron.db.agents_db.AGENT_OPTS,"},{"line_number":69,"context_line":"                neutron.db.extraroute_db.extra_route_opts,"},{"line_number":70,"context_line":"                neutron.db.l3_gwmode_db.OPTS,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_370405c5","line":67,"updated":"2015-11-13 11:11:35.000000000","message":"the indentation here is not in line with other entries.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b8f71590e2b8c0682ae60c521c2767950778a597","unresolved":false,"context_lines":[{"line_number":64,"context_line":"def list_db_opts():"},{"line_number":65,"context_line":"    return ["},{"line_number":66,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":67,"context_line":"            itertools.chain("},{"line_number":68,"context_line":"                neutron.db.agents_db.AGENT_OPTS,"},{"line_number":69,"context_line":"                neutron.db.extraroute_db.extra_route_opts,"},{"line_number":70,"context_line":"                neutron.db.l3_gwmode_db.OPTS,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_e2b55031","line":67,"in_reply_to":"da85f559_370405c5","updated":"2015-11-13 18:06:09.000000000","message":"Fixed.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CONF \u003d cfg.CONF"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"deprecations \u003d {\u0027nova.cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":65,"context_line":"                                                  group\u003dNOVA_GROUP)],"},{"line_number":66,"context_line":"                \u0027nova.insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":67,"context_line":"                                                    group\u003dNOVA_GROUP)],"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_926f54fb","line":64,"updated":"2015-11-19 13:10:04.000000000","message":"Do you know when we can clean it up?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CONF \u003d cfg.CONF"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"deprecations \u003d {\u0027nova.cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":65,"context_line":"                                                  group\u003dNOVA_GROUP)],"},{"line_number":66,"context_line":"                \u0027nova.insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":67,"context_line":"                                                    group\u003dNOVA_GROUP)],"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_da8612db","line":64,"in_reply_to":"ba8a016a_926f54fb","updated":"2015-11-20 14:43:32.000000000","message":"Off hand no. I can look into it further and update when information is available.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def list_agent_opts():"},{"line_number":76,"context_line":"    return ["},{"line_number":77,"context_line":"        (\u0027agent\u0027,"},{"line_number":78,"context_line":"         itertools.chain("},{"line_number":79,"context_line":"             neutron.agent.common.config.ROOT_HELPER_OPTS,"},{"line_number":80,"context_line":"             neutron.agent.common.config.AGENT_STATE_OPTS,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_52400c34","line":77,"updated":"2015-11-19 13:10:04.000000000","message":"(No action required) I think it would be great to introduce some constants for section names and reuse them in all places. Probably something for a follow up patch.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def list_agent_opts():"},{"line_number":76,"context_line":"    return ["},{"line_number":77,"context_line":"        (\u0027agent\u0027,"},{"line_number":78,"context_line":"         itertools.chain("},{"line_number":79,"context_line":"             neutron.agent.common.config.ROOT_HELPER_OPTS,"},{"line_number":80,"context_line":"             neutron.agent.common.config.AGENT_STATE_OPTS,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7a3e062b","line":77,"in_reply_to":"ba8a016a_52400c34","updated":"2015-11-20 14:43:32.000000000","message":"Sure, lets see after this patch.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CONF \u003d cfg.CONF"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"deprecations \u003d {\u0027nova.cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":65,"context_line":"                                                  group\u003dNOVA_GROUP)],"},{"line_number":66,"context_line":"                \u0027nova.insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":67,"context_line":"                                                    group\u003dNOVA_GROUP)],"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_e84bee29","line":64,"updated":"2015-11-25 00:35:53.000000000","message":"According to current neutron.common.config, these deprecated options no more exist","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CONF \u003d cfg.CONF"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"deprecations \u003d {\u0027nova.cafile\u0027: [cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":65,"context_line":"                                                  group\u003dNOVA_GROUP)],"},{"line_number":66,"context_line":"                \u0027nova.insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":67,"context_line":"                                                    group\u003dNOVA_GROUP)],"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_eb4676be","line":64,"in_reply_to":"9a8ffd7b_e84bee29","updated":"2015-11-25 12:57:24.000000000","message":"I talked to core in oslo project and nova are due to remove the \u0027cafile\u0027, \u0027insecure\u0027 and \u0027timeout\u0027 config items but have not done yet. The suggestion is to continue as \"DeprecatedOpt\".","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def list_auth_opts():"},{"line_number":276,"context_line":"    list \u003d copy.deepcopy(_nova_options)"},{"line_number":277,"context_line":"    list.insert(0, auth.get_common_conf_options()[0])"},{"line_number":278,"context_line":"    # NOTE(mhickey): There are a lot of auth plugins, we just generate"},{"line_number":279,"context_line":"    # the config options for a few common ones"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_081e720c","line":276,"updated":"2015-11-25 00:35:53.000000000","message":"don\u0027t use builtin name(list) as var name","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def list_auth_opts():"},{"line_number":276,"context_line":"    list \u003d copy.deepcopy(_nova_options)"},{"line_number":277,"context_line":"    list.insert(0, auth.get_common_conf_options()[0])"},{"line_number":278,"context_line":"    # NOTE(mhickey): There are a lot of auth plugins, we just generate"},{"line_number":279,"context_line":"    # the config options for a few common ones"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_0b0dfa3d","line":276,"in_reply_to":"9a8ffd7b_081e720c","updated":"2015-11-25 12:57:24.000000000","message":"ok, changed.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    plugins \u003d [\u0027password\u0027, \u0027v2password\u0027, \u0027v3password\u0027]"},{"line_number":281,"context_line":"    for name in plugins:"},{"line_number":282,"context_line":"        for plugin_option in auth.get_plugin_class(name).get_options():"},{"line_number":283,"context_line":"            found \u003d False"},{"line_number":284,"context_line":"            for option in list:"},{"line_number":285,"context_line":"                if option.name \u003d\u003d plugin_option.name:"},{"line_number":286,"context_line":"                    found \u003d True"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_e87c4e22","line":283,"updated":"2015-11-25 00:35:53.000000000","message":"found is not needed:\n\n     if all(option.name !\u003d plugin_option.name for option in list):\n       list.append(plugin_option)\n\nand the faster/shorter solution:\n\n  tmp \u003d {option.name: option\n         for name in plugins\n         for option in auth.get_plugin_class(name).get_options()}\n  list \u003d tmp.values()","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    plugins \u003d [\u0027password\u0027, \u0027v2password\u0027, \u0027v3password\u0027]"},{"line_number":281,"context_line":"    for name in plugins:"},{"line_number":282,"context_line":"        for plugin_option in auth.get_plugin_class(name).get_options():"},{"line_number":283,"context_line":"            found \u003d False"},{"line_number":284,"context_line":"            for option in list:"},{"line_number":285,"context_line":"                if option.name \u003d\u003d plugin_option.name:"},{"line_number":286,"context_line":"                    found \u003d True"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_679b9a73","line":283,"in_reply_to":"9a8ffd7b_e87c4e22","updated":"2015-11-25 12:57:24.000000000","message":"Thanks for code suggestions. Updated.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                    break"},{"line_number":288,"context_line":"            if not found:"},{"line_number":289,"context_line":"                list.append(plugin_option)"},{"line_number":290,"context_line":"    list.sort(key\u003dlambda x: x.name)"},{"line_number":291,"context_line":"    return [(NOVA_GROUP, list)]"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_e8720e7c","line":290,"updated":"2015-11-25 00:35:53.000000000","message":"prefer:\n\n list.sort(key\u003doperator.attrgetter(\u0027name\u0027))","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                    break"},{"line_number":288,"context_line":"            if not found:"},{"line_number":289,"context_line":"                list.append(plugin_option)"},{"line_number":290,"context_line":"    list.sort(key\u003dlambda x: x.name)"},{"line_number":291,"context_line":"    return [(NOVA_GROUP, list)]"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_e7854a07","line":290,"in_reply_to":"9a8ffd7b_e8720e7c","updated":"2015-11-25 12:57:24.000000000","message":"Thanks for code suggestions. Updated.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"}],"neutron/plugins/ml2/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027encapsulated Neutron traffic is sent. \u0027"},{"line_number":45,"context_line":"                      \u0027Drivers calculate maximum viable MTU for validating \u0027"},{"line_number":46,"context_line":"                      \u0027tenant requests based on this value (typically, \u0027"},{"line_number":47,"context_line":"                      \u0027path_mtu - max encap header size). If \u003c\u003d 0, \u0027"},{"line_number":48,"context_line":"                      \u0027the path MTU is indeterminate and no calculation \u0027"},{"line_number":49,"context_line":"                      \u0027takes place.\u0027)),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027segment_mtu\u0027, default\u003d0,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d2371cfd","line":47,"updated":"2015-11-19 13:10:04.000000000","message":"max encap -\u003e maximum encapsulation ?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027encapsulated Neutron traffic is sent. \u0027"},{"line_number":45,"context_line":"                      \u0027Drivers calculate maximum viable MTU for validating \u0027"},{"line_number":46,"context_line":"                      \u0027tenant requests based on this value (typically, \u0027"},{"line_number":47,"context_line":"                      \u0027path_mtu - max encap header size). If \u003c\u003d 0, \u0027"},{"line_number":48,"context_line":"                      \u0027the path MTU is indeterminate and no calculation \u0027"},{"line_number":49,"context_line":"                      \u0027takes place.\u0027)),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027segment_mtu\u0027, default\u003d0,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_fa619612","line":47,"in_reply_to":"ba8a016a_d2371cfd","updated":"2015-11-20 14:43:32.000000000","message":"Can\u0027t be sure but worth a try! :) Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027segment_mtu\u0027, default\u003d0,"},{"line_number":51,"context_line":"               help\u003d_(\u0027The maximum permissible size of an unfragmented \u0027"},{"line_number":52,"context_line":"                      \u0027packet travelling a L2 network segment.  If \u003c\u003d 0, the \u0027"},{"line_number":53,"context_line":"                      \u0027segment MTU is indeterminate. and no calculation takes \u0027"},{"line_number":54,"context_line":"                      \u0027place.\u0027)),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027physical_network_mtus\u0027,"},{"line_number":56,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7211905c","line":53,"updated":"2015-11-19 13:10:04.000000000","message":"dot -\u003e comma?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027segment_mtu\u0027, default\u003d0,"},{"line_number":51,"context_line":"               help\u003d_(\u0027The maximum permissible size of an unfragmented \u0027"},{"line_number":52,"context_line":"                      \u0027packet travelling a L2 network segment.  If \u003c\u003d 0, the \u0027"},{"line_number":53,"context_line":"                      \u0027segment MTU is indeterminate. and no calculation takes \u0027"},{"line_number":54,"context_line":"                      \u0027place.\u0027)),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027physical_network_mtus\u0027,"},{"line_number":56,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_ba422e67","line":53,"in_reply_to":"ba8a016a_7211905c","updated":"2015-11-20 14:43:32.000000000","message":"Neither, just space. Updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \"group addresses may be specified by using CIDR \""},{"line_number":36,"context_line":"                      \"notation. Specifying a range allows different VNIs to \""},{"line_number":37,"context_line":"                      \"use different group addresses, reducing or eliminating \""},{"line_number":38,"context_line":"                      \" spurious broadcast traffic to the tunnel endpoints. \""},{"line_number":39,"context_line":"                      \"To reserve a unique group for each possible \""},{"line_number":40,"context_line":"                      \"(24-bit) VNI, use a /8 such as 239.0.0.0/8. This \""},{"line_number":41,"context_line":"                      \"setting must be the same on all the agents.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_12012406","line":38,"updated":"2015-11-19 13:10:04.000000000","message":"redundant leading space","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \"group addresses may be specified by using CIDR \""},{"line_number":36,"context_line":"                      \"notation. Specifying a range allows different VNIs to \""},{"line_number":37,"context_line":"                      \"use different group addresses, reducing or eliminating \""},{"line_number":38,"context_line":"                      \" spurious broadcast traffic to the tunnel endpoints. \""},{"line_number":39,"context_line":"                      \"To reserve a unique group for each possible \""},{"line_number":40,"context_line":"                      \"(24-bit) VNI, use a /8 such as 239.0.0.0/8. This \""},{"line_number":41,"context_line":"                      \"setting must be the same on all the agents.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2d4a8a56","line":38,"in_reply_to":"ba8a016a_12012406","updated":"2015-11-20 14:43:32.000000000","message":"Removed.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":74,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"},{"line_number":75,"context_line":"                help\u003d_(\"Comma-separated list of \""},{"line_number":76,"context_line":"                       \"\u003cnetwork_device\u003e:\u003cvfs__to_exclude\u003e tuples, mapping \""},{"line_number":77,"context_line":"                       \"network_device to the agent\u0027s node-specific list of \""},{"line_number":78,"context_line":"                       \"virtual functions that should not be used for virtual \""},{"line_number":79,"context_line":"                       \"networking. vfs_to_exclude is a semicolon-separated \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_8d597937","line":76,"updated":"2015-11-19 13:10:04.000000000","message":"why two underscores","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":74,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"},{"line_number":75,"context_line":"                help\u003d_(\"Comma-separated list of \""},{"line_number":76,"context_line":"                       \"\u003cnetwork_device\u003e:\u003cvfs__to_exclude\u003e tuples, mapping \""},{"line_number":77,"context_line":"                       \"network_device to the agent\u0027s node-specific list of \""},{"line_number":78,"context_line":"                       \"virtual functions that should not be used for virtual \""},{"line_number":79,"context_line":"                       \"networking. vfs_to_exclude is a semicolon-separated \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_adf19a03","line":76,"in_reply_to":"ba8a016a_8d597937","updated":"2015-11-20 14:43:32.000000000","message":"Not sure, possibly mistake in the old config file. Changed.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":38,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":39,"context_line":"                      \"PCI ID Repository. Default enables support for Intel \""},{"line_number":40,"context_line":"                      \"and Mellanox SR-IOV capable NICs\")),"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(sriov_opts, \"ml2_sriov\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0d5d8914","line":40,"updated":"2015-11-19 13:10:04.000000000","message":"while at it, you may want to add a dot at the end of the help message","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":38,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":39,"context_line":"                      \"PCI ID Repository. Default enables support for Intel \""},{"line_number":40,"context_line":"                      \"and Mellanox SR-IOV capable NICs\")),"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"cfg.CONF.register_opts(sriov_opts, \"ml2_sriov\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_cdcdfeb8","line":40,"in_reply_to":"ba8a016a_0d5d8914","updated":"2015-11-20 14:43:32.000000000","message":"Added.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                      \"to their network connectivity.\")),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027tunnel_bridge\u0027, default\u003d\u0027br-tun\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\"Tunnel bridge to use. Only used for the agent if \""},{"line_number":40,"context_line":"                      \"tunnel_id_ranges is not empty for the server. In most \""},{"line_number":41,"context_line":"                      \"cases, the default value should be fine.\")),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027int_peer_patch_port\u0027, default\u003d\u0027patch-tun\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"Peer patch port in integration bridge for tunnel \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_edbda502","line":40,"updated":"2015-11-19 13:10:04.000000000","message":"I believe tunnel_id_ranges is GRE only, while tunnel_bridge is used for VXLAN too, right? So the message is not strictly correct. [It\u0027s vni_ranges for VXLAN and Geneve].","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                      \"to their network connectivity.\")),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027tunnel_bridge\u0027, default\u003d\u0027br-tun\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\"Tunnel bridge to use. Only used for the agent if \""},{"line_number":40,"context_line":"                      \"tunnel_id_ranges is not empty for the server. In most \""},{"line_number":41,"context_line":"                      \"cases, the default value should be fine.\")),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027int_peer_patch_port\u0027, default\u003d\u0027patch-tun\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"Peer patch port in integration bridge for tunnel \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2dc36a3a","line":40,"in_reply_to":"ba8a016a_edbda502","updated":"2015-11-20 14:43:32.000000000","message":"ok, updated.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                default\u003dDEFAULT_BRIDGE_MAPPINGS,"},{"line_number":52,"context_line":"                help\u003d_(\"Comma-separated list of \u003cphysical_network\u003e:\u003cbridge\u003e \""},{"line_number":53,"context_line":"                       \"tuples mapping physical network names to the agent\u0027s \""},{"line_number":54,"context_line":"                       \"node-specific OVS bridge names to be used for flat \""},{"line_number":55,"context_line":"                       \"and VLAN networks. The length of bridge names should \""},{"line_number":56,"context_line":"                       \"be no more than 11. Each bridge must exist, and \""},{"line_number":57,"context_line":"                       \"should have a physical network interface configured \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0dfee9ad","line":54,"updated":"2015-11-19 13:10:04.000000000","message":"OVS -\u003e Open vSwitch","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                default\u003dDEFAULT_BRIDGE_MAPPINGS,"},{"line_number":52,"context_line":"                help\u003d_(\"Comma-separated list of \u003cphysical_network\u003e:\u003cbridge\u003e \""},{"line_number":53,"context_line":"                       \"tuples mapping physical network names to the agent\u0027s \""},{"line_number":54,"context_line":"                       \"node-specific OVS bridge names to be used for flat \""},{"line_number":55,"context_line":"                       \"and VLAN networks. The length of bridge names should \""},{"line_number":56,"context_line":"                       \"be no more than 11. Each bridge must exist, and \""},{"line_number":57,"context_line":"                       \"should have a physical network interface configured \""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_4d734e16","line":54,"in_reply_to":"ba8a016a_0dfee9ad","updated":"2015-11-20 14:43:32.000000000","message":"Replaced.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027use_veth_interconnection\u0027, default\u003dFalse,"},{"line_number":65,"context_line":"                help\u003d_(\"Use veths instead of patch ports to interconnect the \""},{"line_number":66,"context_line":"                       \"integration bridge to physical networks. \""},{"line_number":67,"context_line":"                       \"Support kernel without ovs patch port support so long \""},{"line_number":68,"context_line":"                       \"as it is set to True.\")),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027of_interface\u0027, default\u003d\u0027ovs-ofctl\u0027,"},{"line_number":70,"context_line":"               choices\u003d[\u0027ovs-ofctl\u0027, \u0027native\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_cd0b01d5","line":67,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.StrOpt(\u0027datapath_type\u0027, default\u003dconstants.OVS_DATAPATH_SYSTEM,"},{"line_number":73,"context_line":"               choices\u003d[constants.OVS_DATAPATH_SYSTEM,"},{"line_number":74,"context_line":"                        constants.OVS_DATAPATH_NETDEV],"},{"line_number":75,"context_line":"               help\u003d_(\"OVS datapath to use. \u0027system\u0027 is the default value and \""},{"line_number":76,"context_line":"                      \"corresponds to the kernel datapath. To enable the \""},{"line_number":77,"context_line":"                      \"userspace datapath set this value to \u0027netdev\u0027\")),"},{"line_number":78,"context_line":"    cfg.IPOpt(\u0027of_listen_address\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2d240d5c","line":75,"updated":"2015-11-19 13:10:04.000000000","message":"ditto","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.StrOpt(\u0027datapath_type\u0027, default\u003dconstants.OVS_DATAPATH_SYSTEM,"},{"line_number":73,"context_line":"               choices\u003d[constants.OVS_DATAPATH_SYSTEM,"},{"line_number":74,"context_line":"                        constants.OVS_DATAPATH_NETDEV],"},{"line_number":75,"context_line":"               help\u003d_(\"OVS datapath to use. \u0027system\u0027 is the default value and \""},{"line_number":76,"context_line":"                      \"corresponds to the kernel datapath. To enable the \""},{"line_number":77,"context_line":"                      \"userspace datapath set this value to \u0027netdev\u0027\")),"},{"line_number":78,"context_line":"    cfg.IPOpt(\u0027of_listen_address\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_cd5dfe7a","line":75,"in_reply_to":"ba8a016a_2d240d5c","updated":"2015-11-20 14:43:32.000000000","message":"Replaced.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                        constants.OVS_DATAPATH_NETDEV],"},{"line_number":75,"context_line":"               help\u003d_(\"OVS datapath to use. \u0027system\u0027 is the default value and \""},{"line_number":76,"context_line":"                      \"corresponds to the kernel datapath. To enable the \""},{"line_number":77,"context_line":"                      \"userspace datapath set this value to \u0027netdev\u0027\")),"},{"line_number":78,"context_line":"    cfg.IPOpt(\u0027of_listen_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":79,"context_line":"              help\u003d_(\"Address to listen on for OpenFlow connections. \""},{"line_number":80,"context_line":"                     \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_6ddc5546","line":77,"updated":"2015-11-19 13:10:04.000000000","message":"add a dot to the end of the message","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                        constants.OVS_DATAPATH_NETDEV],"},{"line_number":75,"context_line":"               help\u003d_(\"OVS datapath to use. \u0027system\u0027 is the default value and \""},{"line_number":76,"context_line":"                      \"corresponds to the kernel datapath. To enable the \""},{"line_number":77,"context_line":"                      \"userspace datapath set this value to \u0027netdev\u0027\")),"},{"line_number":78,"context_line":"    cfg.IPOpt(\u0027of_listen_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":79,"context_line":"              help\u003d_(\"Address to listen on for OpenFlow connections. \""},{"line_number":80,"context_line":"                     \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0df22670","line":77,"in_reply_to":"ba8a016a_6ddc5546","updated":"2015-11-20 14:43:32.000000000","message":"Added.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \"attached to this bridge and then \u0027patched\u0027 according \""},{"line_number":37,"context_line":"                      \"to their network connectivity.\")),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027tunnel_bridge\u0027, default\u003d\u0027br-tun\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\"Tunnel bridge to use. It is vni_ranges for VXLAN and \""},{"line_number":40,"context_line":"                      \"Geneve.\")),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027int_peer_patch_port\u0027, default\u003d\u0027patch-tun\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\"Peer patch port in integration bridge for tunnel \""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_88e262d4","line":39,"updated":"2015-11-25 00:35:53.000000000","message":"This sentence seems incorrect?","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \"attached to this bridge and then \u0027patched\u0027 according \""},{"line_number":37,"context_line":"                      \"to their network connectivity.\")),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027tunnel_bridge\u0027, default\u003d\u0027br-tun\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\"Tunnel bridge to use. It is vni_ranges for VXLAN and \""},{"line_number":40,"context_line":"                      \"Geneve.\")),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027int_peer_patch_port\u0027, default\u003d\u0027patch-tun\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\"Peer patch port in integration bridge for tunnel \""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_a722e2ff","line":39,"in_reply_to":"9a8ffd7b_88e262d4","updated":"2015-11-25 12:57:24.000000000","message":"Removing.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"}],"neutron/plugins/ml2/drivers/type_geneve.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \"value is used to calculate the maximum MTU \""},{"line_number":39,"context_line":"                      \"for the driver. \""},{"line_number":40,"context_line":"                      \"This is the sum of the sizes of the outer \""},{"line_number":41,"context_line":"                      \"ETH + IP + UDP + GENEVE header sizes. \""},{"line_number":42,"context_line":"                      \"The default size for this field is 50, which is the \""},{"line_number":43,"context_line":"                      \"size of the Geneve header without any additional \""},{"line_number":44,"context_line":"                      \"option headers.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2d996d7c","line":41,"updated":"2015-11-19 13:10:04.000000000","message":"(No action required) The message does not consider non-Ethernet networks.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \"value is used to calculate the maximum MTU \""},{"line_number":39,"context_line":"                      \"for the driver. \""},{"line_number":40,"context_line":"                      \"This is the sum of the sizes of the outer \""},{"line_number":41,"context_line":"                      \"ETH + IP + UDP + GENEVE header sizes. \""},{"line_number":42,"context_line":"                      \"The default size for this field is 50, which is the \""},{"line_number":43,"context_line":"                      \"size of the Geneve header without any additional \""},{"line_number":44,"context_line":"                      \"option headers.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_cdebbe77","line":41,"in_reply_to":"ba8a016a_2d996d7c","updated":"2015-11-20 14:43:32.000000000","message":"ok.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}],"releasenotes/notes/config-file-generation-2eafc6602d57178e.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   Generation of sample Neutron core configuration files."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_535f2241","line":6,"updated":"2015-11-25 16:06:48.000000000","message":"Release notes are more about releases, so better not refer a repository at all.\n\nSuggest: \"Neutron now does not ship sample configuration files. Instead, users should generate them using the following command: ...\"","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88c36ce28714a68954b0ac3ed5ed12e1cd1993c1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   Generation of sample Neutron core configuration files."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_2ef1a701","line":6,"in_reply_to":"9a8ffd7b_535f2241","updated":"2015-11-26 11:01:04.000000000","message":"Sorry, I obviously meant \u0027release notes are not about *repositories*\u0027","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   Generation of sample Neutron core configuration files."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_d7a530b5","line":6,"in_reply_to":"9a8ffd7b_535f2241","updated":"2015-11-25 20:18:01.000000000","message":"Suggestion:\n\nNeutron no longer includes static example configuration files. Instead, use tools/generate_config_file_samples.sh to generate them.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"   Generation of sample Neutron core configuration files."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_cb2d5b96","line":6,"in_reply_to":"9a8ffd7b_d7a530b5","updated":"2015-11-26 18:24:02.000000000","message":"Updated with suggestion from Matthew.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"},{"line_number":10,"context_line":"    \u003chttp://docs.openstack.org/developer/neutron/devref/contribute.html#configu"},{"line_number":11,"context_line":"    ration-files\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_b33e8ed8","line":8,"updated":"2015-11-25 16:06:48.000000000","message":"I don\u0027t believe it\u0027s a great idea to refer users to developer docs.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"},{"line_number":10,"context_line":"    \u003chttp://docs.openstack.org/developer/neutron/devref/contribute.html#configu"},{"line_number":11,"context_line":"    ration-files\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_f76dd498","line":8,"in_reply_to":"9a8ffd7b_b33e8ed8","updated":"2015-11-25 20:18:01.000000000","message":"Correct, non-developers should refer to the documentation at docs.openstack.org. In most cases, distribution packages and deployment tools should generate these configuration files or build their own.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Neutron now supports auto-generation of sample core configuration files."},{"line_number":6,"context_line":"    This replaces providing multiple sample config files in its repository."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - For more information on the usage of this feature, see the"},{"line_number":9,"context_line":"    `Neutron Developer Guide"},{"line_number":10,"context_line":"    \u003chttp://docs.openstack.org/developer/neutron/devref/contribute.html#configu"},{"line_number":11,"context_line":"    ration-files\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_60100e5a","line":8,"in_reply_to":"9a8ffd7b_f76dd498","updated":"2015-11-26 18:24:02.000000000","message":"OK, Section removed.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"releasenotes/notes/deprecated-features-e3963d21c36a1157.yaml":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    During Mitaka, some Neutron sample core configuration files were"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_483a3a38","line":4,"updated":"2015-11-25 00:35:53.000000000","message":"deprecated or removed?\n\nNo need to mention Mitaka","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    During Mitaka, some Neutron sample core configuration files were"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_aa3dc7bc","line":4,"in_reply_to":"9a8ffd7b_483a3a38","updated":"2015-11-25 12:57:24.000000000","message":"Updated.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eaa7f58a6242ca36555315818d28e7f873c49aa8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    During Mitaka, some Neutron sample core configuration files were"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"},{"line_number":8,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":9,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_a244fe73","line":6,"updated":"2015-11-25 15:23:05.000000000","message":"removed","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"843517b9afdc4ec8c59e97f4a2d9298d1e4b5ba7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    During Mitaka, some Neutron sample core configuration files were"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"},{"line_number":8,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":9,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_34fb2c7b","line":6,"in_reply_to":"9a8ffd7b_a244fe73","updated":"2015-11-26 14:21:28.000000000","message":"Agree as with Cedric. Updated. I have however kept deprecated in the \"prelude\" as this file can contain entries for deprecations also of apis, config items etc.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"},{"line_number":8,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":9,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"},{"line_number":10,"context_line":"        ./etc/l3_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_28fed66b","line":7,"updated":"2015-11-25 00:35:53.000000000","message":"repository","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"    - The following sample core configuration files will be deprecated from"},{"line_number":7,"context_line":"      the Neutron respoistory:"},{"line_number":8,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":9,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"},{"line_number":10,"context_line":"        ./etc/l3_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_2a78f78e","line":7,"in_reply_to":"9a8ffd7b_28fed66b","updated":"2015-11-25 12:57:24.000000000","message":"Changed.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ./etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":18,"context_line":"      Going forward, sample core configuration files will be auto-generated."},{"line_number":19,"context_line":"      For more information, see the `Neutron Developer Guide"},{"line_number":20,"context_line":"      \u003chttp://docs.openstack.org/developer/neutron/devref/contribute.html#conf"},{"line_number":21,"context_line":"      iguration-files\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_a8772601","line":20,"updated":"2015-11-25 00:35:53.000000000","message":"I doubt it\u0027s a good idea to add a link/anchor which doesn\u0027t seem to be a permalink ... nothing ensures it will still be valid after the release, imo we should refer to the git repository for a specific commit (which is a permalink)","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ./etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":18,"context_line":"      Going forward, sample core configuration files will be auto-generated."},{"line_number":19,"context_line":"      For more information, see the `Neutron Developer Guide"},{"line_number":20,"context_line":"      \u003chttp://docs.openstack.org/developer/neutron/devref/contribute.html#conf"},{"line_number":21,"context_line":"      iguration-files\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a8ffd7b_ad85e1ad","line":20,"in_reply_to":"9a8ffd7b_a8772601","updated":"2015-11-25 12:57:24.000000000","message":"I just followed some examples that were used for the Liberty release. I am open to best approach to use.  I have updated to use git repository link. I would be interested in feedback from other reviewers also.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a8ffd7b_ce2609ba","updated":"2015-11-25 16:06:48.000000000","message":"Do we really need two release notes for the same thing? I would better kill that one since the first one should already cover all that users need to know about the change. While we indeed will keep those config files in tree before devstack switches to using generator, it\u0027s internal gating thing and if that would be not the case, we would kill them right away.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_b7ef4c86","line":3,"updated":"2015-11-25 20:18:01.000000000","message":"Suggestion:\n\nReplace static example core configuration files with auto-generated files using oslo-config-generator.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_ebfa9f42","line":3,"in_reply_to":"9a8ffd7b_b22d1a48","updated":"2015-11-26 18:24:02.000000000","message":"Removed deprecations.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_ab97b7ea","line":3,"in_reply_to":"9a8ffd7b_b7ef4c86","updated":"2015-11-26 18:24:02.000000000","message":"Updated content with suggestion.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"5525ff3b5e5c37113ffa381c8d059b62083a715d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_b22d1a48","line":3,"in_reply_to":"9a8ffd7b_b7ef4c86","updated":"2015-11-25 20:30:40.000000000","message":"Which deprecations?","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"},{"line_number":7,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":8,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"},{"line_number":9,"context_line":"        ./etc/l3_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_77b7a486","line":6,"updated":"2015-11-25 20:18:01.000000000","message":"Suggestion:\n\nReplace the following static example core configuration files with auto-generated files using the .sample extension:","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Some Neutron deprecation and removals."},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - The following sample core configuration files will be removed from"},{"line_number":6,"context_line":"      the Neutron repository"},{"line_number":7,"context_line":"        ./etc/dhcp_agent.ini"},{"line_number":8,"context_line":"        ./etc/neutron/plugins/ml2/linuxbridge_agent.ini"},{"line_number":9,"context_line":"        ./etc/l3_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_cbf55b57","line":6,"in_reply_to":"9a8ffd7b_77b7a486","updated":"2015-11-26 18:24:02.000000000","message":"Updated content with suggestion.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"95fa6832f53cc72030b440972b908f35fa6eee6b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        ./etc/neutron.conf"},{"line_number":15,"context_line":"        ./etc/neutron/plugins/ml2/openvswitch_agent.ini"},{"line_number":16,"context_line":"        ./etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":17,"context_line":"      Going forward, sample core configuration files will be auto-generated."},{"line_number":18,"context_line":"      For more information, see the `Neutron Git Repository"},{"line_number":19,"context_line":"      \u003chttps://git.openstack.org/cgit/openstack/neutron/commit/?id\u003d1c6dc4e7d479f1b7c755597caded24a0f018c712`_."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_f7ab941b","line":17,"updated":"2015-11-25 20:18:01.000000000","message":"Probably don\u0027t need this sentence.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        ./etc/neutron.conf"},{"line_number":15,"context_line":"        ./etc/neutron/plugins/ml2/openvswitch_agent.ini"},{"line_number":16,"context_line":"        ./etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":17,"context_line":"      Going forward, sample core configuration files will be auto-generated."},{"line_number":18,"context_line":"      For more information, see the `Neutron Git Repository"},{"line_number":19,"context_line":"      \u003chttps://git.openstack.org/cgit/openstack/neutron/commit/?id\u003d1c6dc4e7d479f1b7c755597caded24a0f018c712`_."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_2b8c27d9","line":17,"in_reply_to":"9a8ffd7b_f7ab941b","updated":"2015-11-26 18:24:02.000000000","message":"Removed.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"90154f9db3e794a033049820d487bb66503eec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron removals."},{"line_number":4,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9a8ffd7b_093354ac","line":1,"updated":"2015-11-27 08:11:25.000000000","message":"Can you clarify why we need two release notes?","commit_id":"c6c8897a0303565302fb7db6622fa0a479cb4b47"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"77b9032dfd7077919a13e2bfe76c48834907ec10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Some Neutron removals."},{"line_number":4,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9a8ffd7b_394c5c9d","line":1,"in_reply_to":"9a8ffd7b_093354ac","updated":"2015-11-27 11:55:29.000000000","message":"I added this originally to specify the sample files that are to be removed. I suppose it might be unnecessary now as the text has become less explicit and files and more on the new functionality. The other release note probably covers it, so will remove this note.","commit_id":"c6c8897a0303565302fb7db6622fa0a479cb4b47"}],"setup.cfg":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b7bf2c75fc97df0c53c0424b8303a9fd2fefa2a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    neutron.openstack.common.notifier.rpc_notifier \u003d oslo_messaging.notify._impl_messaging:MessagingDriver"},{"line_number":165,"context_line":"    neutron.openstack.common.notifier.test_notifier \u003d oslo_messaging.notify._impl_test:TestDriver"},{"line_number":166,"context_line":"oslo.config.opts \u003d"},{"line_number":167,"context_line":"    neutron \u003d neutron.opts:list_opts"},{"line_number":168,"context_line":"    neutron.agent \u003d neutron.opts:list_agent_opts"},{"line_number":169,"context_line":"    neutron.extensions \u003d neutron.opts:list_extension_opts"},{"line_number":170,"context_line":"    neutron.db \u003d neutron.opts:list_db_opts"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"da85f559_f7dbdd4d","line":167,"updated":"2015-11-13 11:11:35.000000000","message":"should it be e.g. \u0027neutron.server\u0027?","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b8f71590e2b8c0682ae60c521c2767950778a597","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    neutron.openstack.common.notifier.rpc_notifier \u003d oslo_messaging.notify._impl_messaging:MessagingDriver"},{"line_number":165,"context_line":"    neutron.openstack.common.notifier.test_notifier \u003d oslo_messaging.notify._impl_test:TestDriver"},{"line_number":166,"context_line":"oslo.config.opts \u003d"},{"line_number":167,"context_line":"    neutron \u003d neutron.opts:list_opts"},{"line_number":168,"context_line":"    neutron.agent \u003d neutron.opts:list_agent_opts"},{"line_number":169,"context_line":"    neutron.extensions \u003d neutron.opts:list_extension_opts"},{"line_number":170,"context_line":"    neutron.db \u003d neutron.opts:list_db_opts"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"da85f559_82ed6490","line":167,"in_reply_to":"da85f559_f7dbdd4d","updated":"2015-11-13 18:06:09.000000000","message":"I took a look at the other projects and they do not use \".server\" in the name space for the common  configuration of the project. They tend to use the project name as the name space. I will continue this nomenclature if that is ok?","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"}],"tools/generate_config_file_samples.sh":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-sh","patch_set":16,"id":"ba8a016a_2d62cd0a","line":1,"updated":"2015-11-19 13:10:04.000000000","message":"there is nothing bash-y here, you can replace with /bin/sh","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-sh","patch_set":16,"id":"ba8a016a_8dacd636","line":1,"in_reply_to":"ba8a016a_2d62cd0a","updated":"2015-11-20 14:43:32.000000000","message":"correct, done.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"dab05c06cb47f3f130579b1e8c2f596713170746","unresolved":false,"context_lines":[{"line_number":15,"context_line":"set -e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"for file in `ls etc/oslo-config-generator/*`; do"},{"line_number":18,"context_line":"    oslo-config-generator --config-file\u003d$file"},{"line_number":19,"context_line":"done"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -x"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9a8ffd7b_e8dbeeeb","line":18,"updated":"2015-11-25 00:35:53.000000000","message":"we should not handle the case where oslo_config-generator is not installed (iirc, this change states that we can use this script without tox)?","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"843517b9afdc4ec8c59e97f4a2d9298d1e4b5ba7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"set -e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"for file in `ls etc/oslo-config-generator/*`; do"},{"line_number":18,"context_line":"    oslo-config-generator --config-file\u003d$file"},{"line_number":19,"context_line":"done"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -x"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9a8ffd7b_b47b9cf4","line":18,"in_reply_to":"9a8ffd7b_2d30ffe7","updated":"2015-11-26 14:21:28.000000000","message":"Agree but also agree with Cedric as probably best practice. Updated anyways in PS 20.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eaa7f58a6242ca36555315818d28e7f873c49aa8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"set -e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"for file in `ls etc/oslo-config-generator/*`; do"},{"line_number":18,"context_line":"    oslo-config-generator --config-file\u003d$file"},{"line_number":19,"context_line":"done"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -x"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9a8ffd7b_2d30ffe7","line":18,"in_reply_to":"9a8ffd7b_87dc7ee5","updated":"2015-11-25 15:23:05.000000000","message":"Not sure it\u0027s really needed as long as the script fails with \u0027command not found\u0027. But meh.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"e1ec18108e731de319e2ca922fe91d6d6eeef227","unresolved":false,"context_lines":[{"line_number":15,"context_line":"set -e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"for file in `ls etc/oslo-config-generator/*`; do"},{"line_number":18,"context_line":"    oslo-config-generator --config-file\u003d$file"},{"line_number":19,"context_line":"done"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -x"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9a8ffd7b_87dc7ee5","line":18,"in_reply_to":"9a8ffd7b_e8dbeeeb","updated":"2015-11-25 12:57:24.000000000","message":"Good idea. Added check and error handle.","commit_id":"2194670e4af794c41ab6a3821774a0de8afbccc0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed5658997c3c8a27117feeba1750653cea937f68","unresolved":false,"context_lines":[{"line_number":17,"context_line":"GEN_CMD\u003doslo-config-generator"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if ! type \"$GEN_CMD\" \u003e /dev/null; then"},{"line_number":20,"context_line":"    echo \"ERROR: $GEN_CMD not installed on the system.\""},{"line_number":21,"context_line":"    exit 1"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":20,"id":"9a8ffd7b_8ef3210a","line":20,"updated":"2015-11-25 16:06:48.000000000","message":"(No action required) Ah right, we need the check so that we don\u0027t iterate thru each config to fail with \u0027command not found\u0027. Thanks for the change.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"91cb4c8461ccbf347c22992ac9cb9665f804341c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"GEN_CMD\u003doslo-config-generator"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if ! type \"$GEN_CMD\" \u003e /dev/null; then"},{"line_number":20,"context_line":"    echo \"ERROR: $GEN_CMD not installed on the system.\""},{"line_number":21,"context_line":"    exit 1"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":20,"id":"9a8ffd7b_6b6b0ff2","line":20,"in_reply_to":"9a8ffd7b_8ef3210a","updated":"2015-11-26 18:24:02.000000000","message":"No bother. Thank Cedric.","commit_id":"d71fb18ec5740de0d72960974eb9012bebf7bcc5"}],"tox.ini":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f69bebb1a3ec414652ff646fc3973c2de8d635cf","unresolved":false,"context_lines":[{"line_number":144,"context_line":"commands \u003d {posargs}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d "},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/neutron-config-generator.conf"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-properties","patch_set":8,"id":"da85f559_18d624f1","line":147,"updated":"2015-11-12 01:53:44.000000000","message":"extra whitespace","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"712fa6afd3dde06aee36c5ef5e763487635a48dd","unresolved":false,"context_lines":[{"line_number":144,"context_line":"commands \u003d {posargs}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d "},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/neutron-config-generator.conf"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-properties","patch_set":8,"id":"da85f559_da715e0d","line":147,"in_reply_to":"da85f559_18d624f1","updated":"2015-11-12 10:40:43.000000000","message":"Removed","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f69bebb1a3ec414652ff646fc3973c2de8d635cf","unresolved":false,"context_lines":[{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d "},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/neutron-config-generator.conf"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"[testenv:docs-constraints]"},{"line_number":152,"context_line":"install_command \u003d {[testenv:common-constraints]install_command}"}],"source_content_type":"text/x-properties","patch_set":8,"id":"da85f559_7b6deaca","line":149,"updated":"2015-11-12 01:53:44.000000000","message":"why you generate it in docs?","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"712fa6afd3dde06aee36c5ef5e763487635a48dd","unresolved":false,"context_lines":[{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d "},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/neutron-config-generator.conf"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"[testenv:docs-constraints]"},{"line_number":152,"context_line":"install_command \u003d {[testenv:common-constraints]install_command}"}],"source_content_type":"text/x-properties","patch_set":8,"id":"da85f559_1a012638","line":149,"in_reply_to":"da85f559_7b6deaca","updated":"2015-11-12 10:40:43.000000000","message":"Interesting question, thanks. I am following the current pattern used by nova. I think it is still up for debate if we want it this. Leaving it in for the moment.","commit_id":"df72fc8e4cea2f266114fb4b33cc5859c0182509"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b7bf2c75fc97df0c53c0424b8303a9fd2fefa2a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d"},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/oslo-config-generator/neutron-config-generator.conf"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"[testenv:docs-constraints]"},{"line_number":152,"context_line":"install_command \u003d {[testenv:common-constraints]install_command}"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da85f559_17022170","line":149,"updated":"2015-11-13 11:11:35.000000000","message":"I still don\u0027t get why it\u0027s in docs. I suggest you move it into pep8 if it\u0027s just to make gate validate it since that\u0027s the usual place for random validations. Also please replace it with the common tool invocation that I suggest below.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b8f71590e2b8c0682ae60c521c2767950778a597","unresolved":false,"context_lines":[{"line_number":146,"context_line":"[testenv:docs]"},{"line_number":147,"context_line":"commands \u003d"},{"line_number":148,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":149,"context_line":"    oslo-config-generator --config-file\u003detc/oslo-config-generator/neutron-config-generator.conf"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"[testenv:docs-constraints]"},{"line_number":152,"context_line":"install_command \u003d {[testenv:common-constraints]install_command}"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da85f559_8c54b6ca","line":149,"in_reply_to":"da85f559_17022170","updated":"2015-11-13 18:06:09.000000000","message":"Ok, moved to pep8.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5b7bf2c75fc97df0c53c0424b8303a9fd2fefa2a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"local-check-factory \u003d neutron.hacking.checks.factory"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"[testenv:genconfig]"},{"line_number":176,"context_line":"commands \u003d oslo-config-generator --config-file\u003detc/oslo-config-generator/neutron-config-generator.conf"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da85f559_37dc0518","line":176,"updated":"2015-11-13 11:11:35.000000000","message":"can we have the command moved into some tools/*.sh file with a generic name like \u0027generate_config_file_samples.sh\u0027? We\u0027ll need more of those invocations per config file, so it\u0027s better to come up with some interface that would hide details. It would be better to have smth like:\n\nfor file in `ls etc/oslo-config-generator/*`; do\n    oslo-config-generator --config-file\u003d$file\ndone\n\nThe script could receive the topdir to operate on, so that 3party subprojects can reuse it with ease.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"b8f71590e2b8c0682ae60c521c2767950778a597","unresolved":false,"context_lines":[{"line_number":173,"context_line":"local-check-factory \u003d neutron.hacking.checks.factory"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"[testenv:genconfig]"},{"line_number":176,"context_line":"commands \u003d oslo-config-generator --config-file\u003detc/oslo-config-generator/neutron-config-generator.conf"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da85f559_2c5caaec","line":176,"in_reply_to":"da85f559_37dc0518","updated":"2015-11-13 18:06:09.000000000","message":"Makes sense. Added to script.","commit_id":"8e0e320628cae6e248ac92f608b280aa0edd889a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e01564f67dce5dc5791361806fc39fe5ce85130","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  flake8"},{"line_number":108,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":109,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":110,"context_line":"  sh ./tools/generate_config_file_samples.sh"},{"line_number":111,"context_line":"whitelist_externals \u003d"},{"line_number":112,"context_line":"  sh"},{"line_number":113,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":11,"id":"da85f559_c196e593","line":110,"updated":"2015-11-14 17:36:17.000000000","message":"You don\u0027t need sh if you add +x mode to the script. Also, if it\u0027s enough to have \u0027sh\u0027 for it, then change the shebang to use \u0027sh\u0027, in the script.","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"0c4c5b1ead1c8be9d013d7c527b4a30bdc642991","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  flake8"},{"line_number":108,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":109,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":110,"context_line":"  sh ./tools/generate_config_file_samples.sh"},{"line_number":111,"context_line":"whitelist_externals \u003d"},{"line_number":112,"context_line":"  sh"},{"line_number":113,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":11,"id":"ba8a016a_57743bfc","line":110,"in_reply_to":"da85f559_c196e593","updated":"2015-11-16 14:31:54.000000000","message":"shebang is sh in the script and +x mode. It will run from shell but not within the tox.ini without sh before it. Not sure why?","commit_id":"f895724fd9607fa3554ff27b03877b403ca348ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  flake8"},{"line_number":108,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":109,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":110,"context_line":"  sh ./tools/generate_config_file_samples.sh"},{"line_number":111,"context_line":"whitelist_externals \u003d"},{"line_number":112,"context_line":"  sh"},{"line_number":113,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_4dd071f6","line":110,"updated":"2015-11-19 13:10:04.000000000","message":"(No action required) It would be cool if you could refer to \u0027genconfig\u0027 commands section here, as it\u0027s done in line 153.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  flake8"},{"line_number":108,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":109,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":110,"context_line":"  sh ./tools/generate_config_file_samples.sh"},{"line_number":111,"context_line":"whitelist_externals \u003d"},{"line_number":112,"context_line":"  sh"},{"line_number":113,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_3005fd13","line":110,"in_reply_to":"ba8a016a_4dd071f6","updated":"2015-11-20 14:43:32.000000000","message":"Sorry but unsure what you are suggesting?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  {toxinidir}/tools/check_unit_test_structure.sh"},{"line_number":124,"context_line":"  # Checks for coding and style guidelines"},{"line_number":125,"context_line":"  flake8"},{"line_number":126,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":127,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":128,"context_line":"whitelist_externals \u003d {[testenv:pep8]whitelist_externals}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_0dd6e9f0","line":126,"updated":"2015-11-19 13:10:04.000000000","message":"You should update this section too","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"20c64647426dfd0f7fa0ac59a4c6183ddd51bccc","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  {toxinidir}/tools/check_unit_test_structure.sh"},{"line_number":124,"context_line":"  # Checks for coding and style guidelines"},{"line_number":125,"context_line":"  flake8"},{"line_number":126,"context_line":"  sh ./tools/coding-checks.sh --pylint \u0027{posargs}\u0027"},{"line_number":127,"context_line":"  neutron-db-manage --config-file neutron/tests/etc/neutron.conf check_migration"},{"line_number":128,"context_line":"whitelist_externals \u003d {[testenv:pep8]whitelist_externals}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_0bfe8e05","line":126,"in_reply_to":"ba8a016a_0dd6e9f0","updated":"2015-11-20 14:43:32.000000000","message":"Sorry but unsure what you are suggesting?","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"575ef436ede046e69fad44411df9b8e004aed69e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"local-check-factory \u003d neutron.hacking.checks.factory"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"[testenv:genconfig]"},{"line_number":176,"context_line":"commands \u003d sh ./tools/generate_config_file_samples.sh"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ba8a016a_2d7badc2","line":176,"updated":"2015-11-19 13:10:04.000000000","message":"To fix your issues with script not working from inside tox env, use \u0027{toxinidir}/tools/generate_config_file_samples.sh\u0027 for the commands.","commit_id":"4ccb0f7a93921ae3d48bef7680ca783948a2dfa6"}]}
