)]}'
{"etc/logrotate.d/iptables":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    postrotate"},{"line_number":9,"context_line":"        reload rsyslog \u003e/dev/null 2\u003e\u00261 || true"},{"line_number":10,"context_line":"    endscript"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a4dcd0f_b78e5377","line":11,"updated":"2015-08-05 15:36:01.000000000","message":"I think logrotate files should be a package/distro thing, as I don\u0027t see any for existing services.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7f49343445d40f1f47452980f7cde97f15b7de3d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    postrotate"},{"line_number":9,"context_line":"        reload rsyslog \u003e/dev/null 2\u003e\u00261 || true"},{"line_number":10,"context_line":"    endscript"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa1b9901_5909a694","line":11,"in_reply_to":"1a4dcd0f_7005da11","updated":"2015-08-17 21:40:21.000000000","message":"I\u0027m saying I don\u0027t think this file belongs at all, things like log rotate config files and options shouldn\u0027t be in the neutron tree, they should be in the Ubuntu, Red Hat, etc package that is shipping neutron.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    postrotate"},{"line_number":9,"context_line":"        reload rsyslog \u003e/dev/null 2\u003e\u00261 || true"},{"line_number":10,"context_line":"    endscript"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a4dcd0f_7005da11","line":11,"in_reply_to":"1a4dcd0f_b78e5377","updated":"2015-08-07 08:44:23.000000000","message":"I don\u0027t really understand your comment. Could you please explain more detail about your expectation? For current implementation, logrotate will run on destination server log.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"5b25bced98813cc94c6d7ae6a3a767774ad0b7ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    postrotate"},{"line_number":9,"context_line":"        reload rsyslog \u003e/dev/null 2\u003e\u00261 || true"},{"line_number":10,"context_line":"    endscript"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa1b9901_04e5e535","line":11,"in_reply_to":"fa1b9901_5909a694","updated":"2015-08-18 11:42:27.000000000","message":"Yes, you\u0027re right. This file is just used for reference in Central logging server as RedHat or Ubuntu.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}],"etc/rsyslog.d/10-iptables.conf":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Logging kernel generated security group log messages to file"},{"line_number":2,"context_line":":msg,contains,\"[sg]:[\" /var/log/neutron/security-group/security-group.log"},{"line_number":3,"context_line":"\u0026 ~"}],"source_content_type":"text/plain","patch_set":2,"id":"1a4dcd0f_d7e2ff2e","line":3,"updated":"2015-08-05 15:36:01.000000000","message":"Same comment as the logrotate file.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Logging kernel generated security group log messages to file"},{"line_number":2,"context_line":":msg,contains,\"[sg]:[\" /var/log/neutron/security-group/security-group.log"},{"line_number":3,"context_line":"\u0026 ~"}],"source_content_type":"text/plain","patch_set":2,"id":"1a4dcd0f_50a1bef6","line":3,"in_reply_to":"1a4dcd0f_d7e2ff2e","updated":"2015-08-07 08:44:23.000000000","message":"These configuration files will be generated when the service running automatically. So this file will be removed in PS3.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}],"neutron/agent/linux/iptables_comments.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"PORT_SEC_ACCEPT \u003d \u0027Accept all packets when port security is disabled.\u0027"},{"line_number":36,"context_line":"IPV6_RA_DROP \u003d \u0027Drop IPv6 Router Advts from VM Instance.\u0027"},{"line_number":37,"context_line":"IPV6_ICMP_ALLOW \u003d \u0027Allow IPv6 ICMP traffic.\u0027"},{"line_number":38,"context_line":"LOG_SEC_INGRESS_RULE \u003d \u0027Security groups logging for ingress rules.\u0027"},{"line_number":39,"context_line":"LOG_SEC_EGRESS_RULE \u003d \u0027Security groups logging for egress rules.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_f7437b40","line":38,"updated":"2015-08-05 15:36:01.000000000","message":"s/groups/group","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"PORT_SEC_ACCEPT \u003d \u0027Accept all packets when port security is disabled.\u0027"},{"line_number":36,"context_line":"IPV6_RA_DROP \u003d \u0027Drop IPv6 Router Advts from VM Instance.\u0027"},{"line_number":37,"context_line":"IPV6_ICMP_ALLOW \u003d \u0027Allow IPv6 ICMP traffic.\u0027"},{"line_number":38,"context_line":"LOG_SEC_INGRESS_RULE \u003d \u0027Security groups logging for ingress rules.\u0027"},{"line_number":39,"context_line":"LOG_SEC_EGRESS_RULE \u003d \u0027Security groups logging for egress rules.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cdae992d","line":38,"in_reply_to":"1a4dcd0f_f7437b40","updated":"2015-08-07 08:44:23.000000000","message":"Done","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        args +\u003d self._port_arg(\u0027dport\u0027,"},{"line_number":736,"context_line":"                               sg_rule.get(\u0027protocol\u0027),"},{"line_number":737,"context_line":"                               sg_rule.get(\u0027port_range_min\u0027),"},{"line_number":738,"context_line":"                               sg_rule.get(\u0027port_range_max\u0027))"},{"line_number":739,"context_line":"        args +\u003d target"},{"line_number":740,"context_line":"        log_rule \u003d [\u0027 \u0027.join(args)]"},{"line_number":741,"context_line":"        return log_rule"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_d4b43d36","line":738,"updated":"2015-08-05 15:36:01.000000000","message":"From L730 to here can be replaced with a call to _generate_protocol_and_port_args()\n\nActually, I think it would be better to modify _generate_plain_rule_args() since it does all of this, it just adds a \u0027-j RETURN\u0027, but that can be re-factored into a generic method that doesn\u0027t do it, and then maybe add:\n\ndef _generate_plain_return_rule_args(self, sg_rule):\n    return _generate_plain_rule_args() + [\u0027-j RETURN\u0027]\n\netc.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        args +\u003d self._port_arg(\u0027dport\u0027,"},{"line_number":736,"context_line":"                               sg_rule.get(\u0027protocol\u0027),"},{"line_number":737,"context_line":"                               sg_rule.get(\u0027port_range_min\u0027),"},{"line_number":738,"context_line":"                               sg_rule.get(\u0027port_range_max\u0027))"},{"line_number":739,"context_line":"        args +\u003d target"},{"line_number":740,"context_line":"        log_rule \u003d [\u0027 \u0027.join(args)]"},{"line_number":741,"context_line":"        return log_rule"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cd23f9bb","line":738,"in_reply_to":"1a4dcd0f_d4b43d36","updated":"2015-08-07 08:44:23.000000000","message":"Thanks for your suggestion. I will update in new patch-set.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}],"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        else:"},{"line_number":261,"context_line":"            devices \u003d self.plugin_rpc.security_group_rules_for_devices("},{"line_number":262,"context_line":"                self.context, device_ids)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        with self.firewall.defer_apply():"},{"line_number":265,"context_line":"            for device in devices.values():"},{"line_number":266,"context_line":"                LOG.debug(\"Update port filter for %s\", device[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_f4fa9974","side":"PARENT","line":263,"updated":"2015-08-05 15:36:01.000000000","message":"random whitespace change","commit_id":"95f88313444cd9eb40f0470d2733ab7ff1086fce"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        else:"},{"line_number":261,"context_line":"            devices \u003d self.plugin_rpc.security_group_rules_for_devices("},{"line_number":262,"context_line":"                self.context, device_ids)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        with self.firewall.defer_apply():"},{"line_number":265,"context_line":"            for device in devices.values():"},{"line_number":266,"context_line":"                LOG.debug(\"Update port filter for %s\", device[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_2d4dbd99","side":"PARENT","line":263,"in_reply_to":"1a4dcd0f_f4fa9974","updated":"2015-08-07 08:44:23.000000000","message":"Done","commit_id":"95f88313444cd9eb40f0470d2733ab7ff1086fce"}],"neutron/db/migration/alembic_migrations/versions/liberty/contract/22c95f2c0569_packet_logging.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"950e2d87c5072759cd58d0a8ad6f2e6b90c538b0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"down_revision \u003d \u00274ffceebfada\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_1375cc62","line":29,"updated":"2015-07-22 09:14:02.000000000","message":"There is no need to create empty contact migration. Remove it. You can have only expand one.","commit_id":"cc88a074ecd39ce5defd6381dc3bbb986913614b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"a81e9c84449a43437c70db49cdd4b3d27b49b4e5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"down_revision \u003d \u00274ffceebfada\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_656d6730","line":29,"in_reply_to":"3a50d1a3_1375cc62","updated":"2015-07-22 09:42:25.000000000","message":"Thank you so much for reviewing. \nI will update it soon.","commit_id":"cc88a074ecd39ce5defd6381dc3bbb986913614b"}],"neutron/db/packetlogging_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        #warning in case logging fwass if user input log level not equal \u0027info\u0027"},{"line_number":81,"context_line":"        if ((service_type \u003d\u003d \u0027fw\u0027 or service_type \u003d\u003d \u0027fw-rule\u0027)"},{"line_number":82,"context_line":"            and (log_level !\u003d \u0027info\u0027)):"},{"line_number":83,"context_line":"            LOG.warn(_LW(\"Logging level is not affected for\""},{"line_number":84,"context_line":"                         \"firewall service.\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if not self._check_logging_object_exists(context, object_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_74c9a925","line":83,"updated":"2015-08-05 15:36:01.000000000","message":"Missing a trailing space here.","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        #warning in case logging fwass if user input log level not equal \u0027info\u0027"},{"line_number":81,"context_line":"        if ((service_type \u003d\u003d \u0027fw\u0027 or service_type \u003d\u003d \u0027fw-rule\u0027)"},{"line_number":82,"context_line":"            and (log_level !\u003d \u0027info\u0027)):"},{"line_number":83,"context_line":"            LOG.warn(_LW(\"Logging level is not affected for\""},{"line_number":84,"context_line":"                         \"firewall service.\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if not self._check_logging_object_exists(context, object_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b0b2824a","line":83,"in_reply_to":"1a4dcd0f_74c9a925","updated":"2015-08-07 08:44:23.000000000","message":"Done","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}],"neutron/extensions/packetlogging.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7e5492b78e23868ac21ec7f306d2073d2b41f25","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Attribute Map"},{"line_number":47,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":48,"context_line":"    \u0027packet_loggings\u0027: {"},{"line_number":49,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":50,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":51,"context_line":"               \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_9438f5f0","line":48,"updated":"2015-08-05 15:36:01.000000000","message":"packet_logging right ?","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6e7055379b63370392e0489d25d477267a87fbe9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Attribute Map"},{"line_number":47,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":48,"context_line":"    \u0027packet_loggings\u0027: {"},{"line_number":49,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":50,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":51,"context_line":"               \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_f0c80aaa","line":48,"in_reply_to":"1a4dcd0f_9438f5f0","updated":"2015-08-07 08:44:23.000000000","message":"We are still discussing to get the best name for this. We are thinking to use \"packet-loggers\" as Ryan\u0027s suggested. Do you have any suggestion for the name?","commit_id":"9f89c3850e88c45c3b6162d1d569baa0ff5817b6"}]}
