)]}'
{"quantum/db/securitygroups_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"4eb20bd72092bb3d2bc4a6c3f2d13e13d58eb41a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        return self._make_security_group_dict(security_group_db)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_security_groups(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":142,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":143,"context_line":"            security_groups \u003d self._get_collection("},{"line_number":144,"context_line":"                context, SecurityGroup, self._make_security_group_dict,"},{"line_number":145,"context_line":"                filters\u003dfilters, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FWe0%3D","line":142,"updated":"2013-01-25 23:36:45.000000000","message":"Why not just update the _make_security_group_dict to add the security_group_rules.  You are passing the SQLAlchemy object which already has access to the rules via the backref relationship created in the models.\n\nYou should only need to tweak line 206 and add this key to attr map as forbidden from post and put.\n\nsecurity_group[\u0027security_group_rules\u0027] \u003d  [self._make_security_group_rule_dict(r) for r in security_group.rules.all()]","commit_id":"a0672fb6fe5f016d3c1779c0000e3d38f3984b43"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"cee24d40db5b7eccd026f4a5956bc54822bdde71","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        return self._make_security_group_dict(security_group_db)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_security_groups(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":142,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":143,"context_line":"            security_groups \u003d self._get_collection("},{"line_number":144,"context_line":"                context, SecurityGroup, self._make_security_group_dict,"},{"line_number":145,"context_line":"                filters\u003dfilters, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FVGA%3D","line":142,"in_reply_to":"AAAAM3%2F%2FWe0%3D","updated":"2013-01-28 19:50:38.000000000","message":"Thanks mark, I agree changing _make_security_group_rule_dict() is better. I made this change. post/post is already forbidden for security_groups_rules on security_groups.","commit_id":"a0672fb6fe5f016d3c1779c0000e3d38f3984b43"}]}