)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"f2201d157a8faa12efe66207faac645c04d4778d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-24 10:06:59 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replacing print with print() for py 2/3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id92a7d292b832f07c79da8a42ac90b99d8c2c0cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_ff7d626d","line":8,"updated":"2015-07-28 18:52:21.000000000","message":"if it is indeed necessary .. you might want to reference Blueprint: neutron-python3 here as Cedric had suggested on ps1","commit_id":"501624bbc12e0945d0cb84eb77b7dc0ff8dd5280"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ccb3cd20c32209e1262fd7fd6af49c228ddd01ff","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-24 10:06:59 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replacing print with print() for py 2/3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id92a7d292b832f07c79da8a42ac90b99d8c2c0cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_88bb5ac4","line":8,"in_reply_to":"3a50d1a3_ff7d626d","updated":"2015-08-04 08:01:23.000000000","message":"+1","commit_id":"501624bbc12e0945d0cb84eb77b7dc0ff8dd5280"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b951e54c13cd284c15c8a5b9e105408baed0798","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sonu.kumar \u003csonu.kumar@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-04 14:19:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces print with print() for py 2/3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch replaces print with print() to comply with"},{"line_number":10,"context_line":"the newer python version i.e. python3."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_f06a4aec","line":7,"updated":"2015-08-13 06:42:15.000000000","message":"This patch only touches the document and comments, so it should be mentioned. This doesn\u0027t help anything from code perspective, but I think it is worth matching documents and codes. This is the reason of -1.","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"}],"doc/source/devref/callbacks.rst":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"36907e0bbf0f2dc962ded6daa2820635a51fb2d1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"      registry.notify(resources.ROUTER, events.BEFORE_CREATE, do_notify, **kwargs)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  print \u0027Notifying...\u0027"},{"line_number":189,"context_line":"  try:"},{"line_number":190,"context_line":"      do_notify()"},{"line_number":191,"context_line":"  except exceptions.CallbackFailure as e:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_3735dff6","line":188,"updated":"2015-07-24 02:03:31.000000000","message":"missed here","commit_id":"1aa3daf9ebbf07d9787487ef4f4a04ab39b1d501"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a2f385290f1a03206f908d0b00f463d94a14a2b2","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"In practical terms this scenario would be translated in the code below:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  from neutron.callbacks import events"},{"line_number":92,"context_line":"  from neutron.callbacks import resources"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_4acc7135","line":89,"updated":"2015-08-26 22:05:06.000000000","message":"+1 to the future import. Otherwise it does change the output of the print statement","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b951e54c13cd284c15c8a5b9e105408baed0798","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"In practical terms this scenario would be translated in the code below:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  from neutron.callbacks import events"},{"line_number":92,"context_line":"  from neutron.callbacks import resources"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_5b047f13","line":89,"updated":"2015-08-13 06:42:15.000000000","message":"For Python code completeness, don\u0027t we need the following?\n\n  from __future__ import print_function\n\nI am not sure it is worth making changes like this, so I am okay with either.","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b951e54c13cd284c15c8a5b9e105408baed0798","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"In practical terms this scenario would be translated in the code below:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  from neutron.callbacks import events"},{"line_number":92,"context_line":"  from neutron.callbacks import resources"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_fb06ab1a","line":89,"updated":"2015-08-13 06:42:15.000000000","message":"For Python code completeness, don\u0027t we need the following?\n\n  from __future__ import print_function\n\nI am not sure it is worth making changes like this, so I am okay with either.","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ec6697baa8b9f16f22ab1d6b27b910fb7ea82161","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"In practical terms this scenario would be translated in the code below:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  from neutron.callbacks import events"},{"line_number":92,"context_line":"  from neutron.callbacks import resources"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_7fbd9eaf","line":89,"in_reply_to":"1a4dcd0f_fb06ab1a","updated":"2015-08-13 10:24:21.000000000","message":"iirc, it\u0027s not strictly required but it changes a bit the output:\n\n \u003e\u003e\u003e kwargs \u003d \u0027blah\u0027\n \u003e\u003e\u003e print \u0027kwargs: \u0027, kwargs\n kwargs: blah\n \u003e\u003e\u003e print(\u0027kwargs: \u0027, kwargs)\n (\u0027kwargs: \u0027, \u0027blah\u0027)\n # because print outputs a tuple\n\n \u003e\u003e\u003efrom __future__ import print_function\n \u003e\u003e\u003e kwargs \u003d \u0027blah\u0027\n \u003e\u003e\u003e print(\u0027kwargs: \u0027, kwargs)\n kwargs: blah\n # because print outputs multiple arguments","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"}],"neutron/agent/linux/async_process.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"39256d1c9699090cb3617060d8bdf37be04c4d3b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e time.sleep(5)"},{"line_number":51,"context_line":"    \u003e\u003e\u003e proc.stop()"},{"line_number":52,"context_line":"    \u003e\u003e\u003e for line in proc.iter_stdout():"},{"line_number":53,"context_line":"    ...     print(line)"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __init__(self, cmd, run_as_root\u003dFalse, respawn_interval\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_f4552efa","line":53,"updated":"2015-07-24 05:21:23.000000000","message":"Do we really need to change this in comment? I feel the comment should be more from algorithm perspective rather than actual code implementation.","commit_id":"501624bbc12e0945d0cb84eb77b7dc0ff8dd5280"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d09ce0f21b71a3e9900b6c25db7fd8c0445e0f91","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e time.sleep(5)"},{"line_number":51,"context_line":"    \u003e\u003e\u003e proc.stop()"},{"line_number":52,"context_line":"    \u003e\u003e\u003e for line in proc.iter_stdout():"},{"line_number":53,"context_line":"    ...     print(line)"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __init__(self, cmd, run_as_root\u003dFalse, respawn_interval\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_f9306eea","line":53,"updated":"2015-08-05 06:57:07.000000000","message":"Reiterating my previous comment from PS2 : \"Do we really need to change this in comment? I feel the comment should be more from algorithm perspective rather than actual code implementation.\"","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"},{"author":{"_account_id":15699,"name":"sonu","email":"sonu.bhumca11@gmail.com","username":"sonu.kumar"},"change_message_id":"0eadbbbfb8249a812ca27f53197741b92ce38a06","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e time.sleep(5)"},{"line_number":51,"context_line":"    \u003e\u003e\u003e proc.stop()"},{"line_number":52,"context_line":"    \u003e\u003e\u003e for line in proc.iter_stdout():"},{"line_number":53,"context_line":"    ...     print(line)"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __init__(self, cmd, run_as_root\u003dFalse, respawn_interval\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_f972ae48","line":53,"in_reply_to":"1a4dcd0f_f9306eea","updated":"2015-08-12 04:20:40.000000000","message":"May be. If someone try these examples just by doing copy and paste . If we are giving python syntax in examples then why cannot we provide proper print syntax. Algo can also be provided with pseudo code. But here we are using all python language constructs.","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3b951e54c13cd284c15c8a5b9e105408baed0798","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e time.sleep(5)"},{"line_number":51,"context_line":"    \u003e\u003e\u003e proc.stop()"},{"line_number":52,"context_line":"    \u003e\u003e\u003e for line in proc.iter_stdout():"},{"line_number":53,"context_line":"    ...     print(line)"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __init__(self, cmd, run_as_root\u003dFalse, respawn_interval\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_907ae6b8","line":53,"in_reply_to":"1a4dcd0f_f972ae48","updated":"2015-08-13 06:42:15.000000000","message":"I think it is better to match documents with codes.","commit_id":"3c50f4ea1fa5b519e174a15ede21b25768de3542"}],"neutron/agent/linux/ip_monitor.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"39256d1c9699090cb3617060d8bdf37be04c4d3b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        m.start()"},{"line_number":65,"context_line":"        for iterable in m:"},{"line_number":66,"context_line":"            event \u003d IPMonitorEvent.from_text(iterable)"},{"line_number":67,"context_line":"            print(event, event.added, event.interface, event.cidr)"},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def __init__(self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_145bfa2f","line":67,"updated":"2015-07-24 05:21:23.000000000","message":"Do we really need to change this in comment? I feel the comment should be more from algorithm perspective rather than actual code implementation.","commit_id":"501624bbc12e0945d0cb84eb77b7dc0ff8dd5280"}]}