)]}'
{"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a988f9a5e400b6d7e80f52e330a452ea20bdac59","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                                                       interface_name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def delete(self, agent):"},{"line_number":355,"context_line":"        self.state_change_callback(self.router_id, \u0027backup\u0027)"},{"line_number":356,"context_line":"        self.destroy_state_change_monitor(self.process_monitor)"},{"line_number":357,"context_line":"        self.ha_network_removed()"},{"line_number":358,"context_line":"        self.disable_keepalived()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b616fa49","line":355,"updated":"2015-08-07 08:43:51.000000000","message":"If it is deleted from this agent, it should not be backup, it should not be in l3-agent-hosting-router-list result at all.","commit_id":"8c1b4588d220191793b792eb8592e45b94d70202"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"5298d20d4bb1be4028cf82dfcfc8741cab670c92","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                                                       interface_name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def delete(self, agent):"},{"line_number":355,"context_line":"        self.state_change_callback(self.router_id, \u0027backup\u0027)"},{"line_number":356,"context_line":"        self.destroy_state_change_monitor(self.process_monitor)"},{"line_number":357,"context_line":"        self.ha_network_removed()"},{"line_number":358,"context_line":"        self.disable_keepalived()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b748ea88","line":355,"in_reply_to":"1a4dcd0f_b616fa49","updated":"2015-08-10 09:10:49.000000000","message":"@gongysh, the current behavior is such that when we schedule an HA Router to two or more agents and mark one of the agents admin_state_up as False, the HA router is deleted on the agent but the db (i.e., ha_router_agent_port_bindings) still has the entry. When we bring up the agent back (i.e., by setting admin_state_up\u003dTrue) the HA router is re-scheduled back on the agent. \n\nI\u0027m not sure of all the use-cases associated with admin_state_up. I initially thought of deleting the HA router from the db but felt that it may have some effect on the other use-cases associated with admin_state_up - so took the approach of updating the HA router state to \u0027backup\u0027 in this patch which would fix the issue described in the bug report.","commit_id":"8c1b4588d220191793b792eb8592e45b94d70202"}]}
