)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"dd2f1c9d71ccf6bc4a621ffbd2089ed176b63314","unresolved":false,"context_lines":[{"line_number":10,"context_line":"midonet networks from others when using midonet as a mechanism driver"},{"line_number":11,"context_line":"with the ML2 plugin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: bug/1481595"},{"line_number":14,"context_line":"Signed-off-by: Joe Mills \u003cjoe@midokura.com\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4f5f38571c7aeb2c15477725cd9bb6e066d71dbf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_76af8d94","line":13,"updated":"2015-08-05 06:48:01.000000000","message":"Closes-Bug: #1481595\n\nso that gerrit creates a link","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":156,"name":"Ryu Ishimoto","email":"ryu@midokura.com","username":"ryu-midokura"},"change_message_id":"0ca4048717981b4f3550e7d4bd45c5095f1066af","unresolved":false,"context_lines":[{"line_number":10,"context_line":"midonet networks from others when using midonet as a mechanism driver"},{"line_number":11,"context_line":"with the ML2 plugin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: bug/1481595"},{"line_number":14,"context_line":"Signed-off-by: Joe Mills \u003cjoe@midokura.com\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4f5f38571c7aeb2c15477725cd9bb6e066d71dbf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_82d6bcef","line":13,"in_reply_to":"1a4dcd0f_76af8d94","updated":"2015-08-10 14:31:17.000000000","message":"Done","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"}],"neutron/plugins/ml2/drivers/type_midonet.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"dd2f1c9d71ccf6bc4a621ffbd2089ed176b63314","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MidonetTypeDriver(api.TypeDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_96901945","line":23,"updated":"2015-08-05 06:48:01.000000000","message":"why not in plugins/common/constants.py?","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":156,"name":"Ryu Ishimoto","email":"ryu@midokura.com","username":"ryu-midokura"},"change_message_id":"0ca4048717981b4f3550e7d4bd45c5095f1066af","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MidonetTypeDriver(api.TypeDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_592f4ba1","line":23,"in_reply_to":"1a4dcd0f_96901945","updated":"2015-08-10 14:31:17.000000000","message":"Done","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"dd2f1c9d71ccf6bc4a621ffbd2089ed176b63314","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MidonetTypeDriver(api.TypeDriver):"},{"line_number":27,"context_line":"    \"\"\"Type driver for Midonet networks"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This type driver differentiates midonet networks from other types."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7639cd40","line":29,"updated":"2015-08-05 06:48:01.000000000","message":"iirc midonet supports a few tunnel types.\nwhich one (or all?) maps to this type?","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"31fbec570df4f7934fb40017dd79f8c42ac6c250","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MidonetTypeDriver(api.TypeDriver):"},{"line_number":27,"context_line":"    \"\"\"Type driver for Midonet networks"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This type driver differentiates midonet networks from other types."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_79245eae","line":29,"in_reply_to":"1a4dcd0f_7639cd40","updated":"2015-08-05 07:01:14.000000000","message":"I do not think its something to inform the user, its more MidoNet side setting","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"dd2f1c9d71ccf6bc4a621ffbd2089ed176b63314","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def validate_provider_segment(self, segment):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def reserve_provider_segment(self, session, segment):"},{"line_number":48,"context_line":"        return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d6c5413c","line":45,"updated":"2015-08-05 06:48:01.000000000","message":"you can validate that the segment has no extra attributes.","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":156,"name":"Ryu Ishimoto","email":"ryu@midokura.com","username":"ryu-midokura"},"change_message_id":"0ca4048717981b4f3550e7d4bd45c5095f1066af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def validate_provider_segment(self, segment):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def reserve_provider_segment(self, session, segment):"},{"line_number":48,"context_line":"        return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_629ff05f","line":45,"in_reply_to":"1a4dcd0f_79f77ef5","updated":"2015-08-10 14:31:17.000000000","message":"Done","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"31fbec570df4f7934fb40017dd79f8c42ac6c250","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def validate_provider_segment(self, segment):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def reserve_provider_segment(self, session, segment):"},{"line_number":48,"context_line":"        return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_79f77ef5","line":45,"in_reply_to":"1a4dcd0f_d6c5413c","updated":"2015-08-05 07:01:14.000000000","message":"+1. You can validate similar to https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_local.py#L49","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"},{"author":{"_account_id":156,"name":"Ryu Ishimoto","email":"ryu@midokura.com","username":"ryu-midokura"},"change_message_id":"0ca4048717981b4f3550e7d4bd45c5095f1066af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def validate_provider_segment(self, segment):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def reserve_provider_segment(self, session, segment):"},{"line_number":48,"context_line":"        return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_428bd41e","line":45,"in_reply_to":"1a4dcd0f_d6c5413c","updated":"2015-08-10 14:31:17.000000000","message":"Done","commit_id":"139790113e438dae6d721ba816aba2133f6959a6"}]}
