)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9b49e7f4696fe8518e7e881d5a125abf92264f16","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.openstack.org/#/c/182283"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I206f58a21c36e55de957d8a23993aa9bc26d1595"},{"line_number":23,"context_line":"Partial-Bug: #1480979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da6ed579_f64aadab","line":22,"updated":"2016-01-13 14:32:39.000000000","message":"Please add DocImpact and a release note","commit_id":"5c0a480ed4b6f7c4142d19251ff39ed700777d44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9d1c6a9121de6c75bca38ec7694bc9f2c0b011da","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://review.openstack.org/#/c/182283"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":"Change-Id: I206f58a21c36e55de957d8a23993aa9bc26d1595"},{"line_number":25,"context_line":"Partial-Bug: #1480979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5a5ae5dd_471c85c1","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":9},"updated":"2016-02-09 02:19:46.000000000","message":"Consider adding a DocImpact only to one patch of the series. As per Doc guidelines the DocImpact flag must be followed by a sentence that describes the content of the patch. This was announced a while back during our team meetings.\n\nI suspect a patch in the series also need a release note.","commit_id":"a6021f6d9b15bf7dcf906ddf0c112bc62396a80e"}],"neutron/extensions/portbindings.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2077907013deea1562f7689f98eb4380b6d1d387","unresolved":false,"context_lines":[{"line_number":77,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":78,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":79,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":80,"context_line":"VIF_TYPE_MACVTAP \u003d \u0027macvtap\u0027"},{"line_number":81,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"VNIC_NORMAL \u003d \u0027normal\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dae33548_ea21d7a0","line":80,"updated":"2016-02-16 16:21:05.000000000","message":"I think you should add a small comment explaining the difference between VIF_TYPE_MACVTAP and VNIC_MACVTAP so that people don\u0027t get confused :)","commit_id":"3f9ba78409d2883f28209f5c5af0f4b3a7bbc12a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c49af94b37ec393d47a1a778dd7bb5b85f204821","unresolved":false,"context_lines":[{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif-type macvtap: Tells Nova that it should use the macvtap vif_driver to"},{"line_number":86,"context_line":"#                   create a vif.It does not require the VNIC_TYPE_MACVTAP,"},{"line_number":87,"context_line":"#                   which is defined further below. E.g. Macvtap agent uses"},{"line_number":88,"context_line":"#                   vnic_type \u0027normal\u0027."},{"line_number":89,"context_line":"VIF_TYPE_MACVTAP \u003d \u0027macvtap\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_f346bc79","line":86,"updated":"2016-02-17 14:44:10.000000000","message":"nit space after \u0027.\u0027","commit_id":"5618afad092945ecfb0b0bb88607de13b6e7085c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c49af94b37ec393d47a1a778dd7bb5b85f204821","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#                   vnic_type \u0027normal\u0027."},{"line_number":89,"context_line":"VIF_TYPE_MACVTAP \u003d \u0027macvtap\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# VNIC_TYPES: can be provided via the Neutron API to have some control over"},{"line_number":92,"context_line":"#             which mechanism is used for realizing a vnic. If non is chosen,"},{"line_number":93,"context_line":"#             always \u0027normal\u0027  is assumed (linuxbridge and ovs use \u0027normal\u0027)."},{"line_number":94,"context_line":"#             This allows having different l2 agents running on the same host,"}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_93a81022","line":91,"updated":"2016-02-17 14:44:10.000000000","message":"I\u0027d keep it short: \"It\u0027s used to determine which mechanism driver to use to bind a port. Default is normal, used by OVS and LinuxBridge agent.\"","commit_id":"5618afad092945ecfb0b0bb88607de13b6e7085c"}],"neutron/plugins/ml2/drivers/macvtap/mech_driver/mech_macvtap.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a58b378032642828d79c9ad6424a2b6b8167434a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            context.set_binding(segment[api.ID], self.vif_type,"},{"line_number":77,"context_line":"                                vif_details_segment)"},{"line_number":78,"context_line":"            return True"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_3f70d80a","line":79,"updated":"2015-11-26 18:05:56.000000000","message":"the else is not really needed :)","commit_id":"8b8738d33f9e133ddde0627a88071ef6524cc01a"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"74f3ea8a00a874a46e8fbdb8b1106ba5accc5f40","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            context.set_binding(segment[api.ID], self.vif_type,"},{"line_number":77,"context_line":"                                vif_details_segment)"},{"line_number":78,"context_line":"            return True"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_60e69b16","line":79,"in_reply_to":"9a8ffd7b_3f70d80a","updated":"2015-11-27 15:52:28.000000000","message":"agree","commit_id":"8b8738d33f9e133ddde0627a88071ef6524cc01a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9b49e7f4696fe8518e7e881d5a125abf92264f16","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.macvtap import macvtap_common"},{"line_number":24,"context_line":"from neutron.plugins.ml2.drivers import mech_agent"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_36ffe535","line":25,"updated":"2016-01-13 14:32:39.000000000","message":"one too many new lines","commit_id":"5c0a480ed4b6f7c4142d19251ff39ed700777d44"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2077907013deea1562f7689f98eb4380b6d1d387","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"            vif_details_segment[\u0027physical_interface\u0027] \u003d interface"},{"line_number":71,"context_line":"            vif_details_segment[\u0027macvtap_source\u0027] \u003d macvtap_src"},{"line_number":72,"context_line":"            vif_details_segment[\u0027macvtap_mode\u0027] \u003d \"bridge\""},{"line_number":73,"context_line":"            LOG.debug(\"Macvtap vif_details added to context binding: %s\","},{"line_number":74,"context_line":"                      vif_details_segment)"},{"line_number":75,"context_line":"            context.set_binding(segment[api.ID], self.vif_type,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dae33548_ca869312","line":72,"updated":"2016-02-16 16:21:05.000000000","message":"what\u0027s \"bridge\" ? maybe we should define the allowed macvtap modes as constants","commit_id":"3f9ba78409d2883f28209f5c5af0f4b3a7bbc12a"}],"neutron/plugins/ml2/drivers/mech_macvtap/macvtap_common.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1cbf82ecf682a313c1b774b064030466a824386a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    dev-name will be smaller than 15 chars."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    if len(src_dev) \u003e 10:"},{"line_number":36,"context_line":"        prefix \u003d src_dev[:3]"},{"line_number":37,"context_line":"        separator \u003d \u0027..\u0027"},{"line_number":38,"context_line":"        identifier \u003d src_dev[-5:]"},{"line_number":39,"context_line":"        src_dev \u003d \u0027%s%s%s\u0027 % (prefix, separator, identifier)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_955116db","line":36,"updated":"2015-09-15 08:48:37.000000000","message":"imo, this homemade hash method is not bulletproof, i would prefer we reuse the hash from ovs agent[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1011-L1036","commit_id":"06bd07812c5854cbff1450f70c71b0e0a4262dae"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e8d02b78344dfbfb0bef150751e71d6ff9b3ee2d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    dev-name will be smaller than 15 chars."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    if len(src_dev) \u003e 10:"},{"line_number":36,"context_line":"        prefix \u003d src_dev[:3]"},{"line_number":37,"context_line":"        separator \u003d \u0027..\u0027"},{"line_number":38,"context_line":"        identifier \u003d src_dev[-5:]"},{"line_number":39,"context_line":"        src_dev \u003d \u0027%s%s%s\u0027 % (prefix, separator, identifier)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8fa226fc","line":36,"in_reply_to":"ba15a1d1_91bfe3fa","updated":"2015-09-16 13:01:04.000000000","message":"will make that use the following method if it gets merged: https://review.openstack.org/224064","commit_id":"06bd07812c5854cbff1450f70c71b0e0a4262dae"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e49d4f556eef63dda184b9a3f024bef78b166062","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    dev-name will be smaller than 15 chars."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    if len(src_dev) \u003e 10:"},{"line_number":36,"context_line":"        prefix \u003d src_dev[:3]"},{"line_number":37,"context_line":"        separator \u003d \u0027..\u0027"},{"line_number":38,"context_line":"        identifier \u003d src_dev[-5:]"},{"line_number":39,"context_line":"        src_dev \u003d \u0027%s%s%s\u0027 % (prefix, separator, identifier)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_91bfe3fa","line":36,"in_reply_to":"ba15a1d1_955116db","updated":"2015-09-15 11:19:10.000000000","message":"thanks for this pointer!\nI see your point that using a real hash method is much more bullet proof. But the intention of this piece of code was to keep a relationship between eth device and corresponding vlan device by name to simplify debugging (e.g. eth-device: eth_abcdefgh --\u003e vlan device: eth..defgh.xxxx).\n\nHowever, I will think about your proposal a little more and see what\u0027s doable! Thanks","commit_id":"06bd07812c5854cbff1450f70c71b0e0a4262dae"}],"neutron/plugins/ml2/drivers/mech_macvtap/mech_driver/mech_macvtap.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1cbf82ecf682a313c1b774b064030466a824386a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            {portbindings.CAP_PORT_FILTER: False})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_allowed_network_types(self, agent):"},{"line_number":47,"context_line":"        return ([p_constants.TYPE_LOCAL, p_constants.TYPE_FLAT,"},{"line_number":48,"context_line":"                 p_constants.TYPE_VLAN])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_mappings(self, agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_95ffd6a9","line":47,"updated":"2015-09-15 08:48:37.000000000","message":"parenthesis are useless","commit_id":"06bd07812c5854cbff1450f70c71b0e0a4262dae"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e49d4f556eef63dda184b9a3f024bef78b166062","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            {portbindings.CAP_PORT_FILTER: False})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_allowed_network_types(self, agent):"},{"line_number":47,"context_line":"        return ([p_constants.TYPE_LOCAL, p_constants.TYPE_FLAT,"},{"line_number":48,"context_line":"                 p_constants.TYPE_VLAN])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_mappings(self, agent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7d9468e1","line":47,"in_reply_to":"ba15a1d1_95ffd6a9","updated":"2015-09-15 11:19:10.000000000","message":"Done in next patchset","commit_id":"06bd07812c5854cbff1450f70c71b0e0a4262dae"}],"neutron/tests/unit/plugins/ml2/drivers/macvtap/test_macvtap_common.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a58b378032642828d79c9ad6424a2b6b8167434a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MockSHA(object):"},{"line_number":27,"context_line":"            def hexdigest(self):"},{"line_number":28,"context_line":"                return MOCKED_HASH"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_bb061b1a","line":27,"updated":"2015-11-26 18:05:56.000000000","message":"indentation?","commit_id":"8b8738d33f9e133ddde0627a88071ef6524cc01a"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"74f3ea8a00a874a46e8fbdb8b1106ba5accc5f40","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MockSHA(object):"},{"line_number":27,"context_line":"            def hexdigest(self):"},{"line_number":28,"context_line":"                return MOCKED_HASH"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_a0b6c3f6","line":27,"in_reply_to":"9a8ffd7b_bb061b1a","updated":"2015-11-27 15:52:28.000000000","message":"yup, will fix","commit_id":"8b8738d33f9e133ddde0627a88071ef6524cc01a"}],"neutron/tests/unit/plugins/ml2/drivers/mech_macvtap/mech_driver/test_mech_macvtap.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0c20eddfba337ad141a7449a4ce9668e25ab9717","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright (c) 2015 IBM Corp."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_a1d092ca","line":1,"updated":"2015-09-22 10:56:49.000000000","message":"It seems the 1st line should be removed?","commit_id":"c026d9850992221cdec1ff40031d7234eed9f599"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0c20eddfba337ad141a7449a4ce9668e25ab9717","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertIsNone(vif_details.get(portbindings.VIF_DETAILS_VLAN))"},{"line_number":73,"context_line":"        self.assertEqual(vif_details.get("},{"line_number":74,"context_line":"                    portbindings.VIF_DETAILS_MACVTAP_MODE), \"bridge\")"},{"line_number":75,"context_line":"        self.assertEqual(vif_details.get("},{"line_number":76,"context_line":"                     portbindings.VIF_DETAILS_PHYSICAL_INTERFACE), \"fake_if\")"},{"line_number":77,"context_line":"        self.assertEqual(vif_details.get("},{"line_number":78,"context_line":"                     portbindings.VIF_DETAILS_MACVTAP_SOURCE), \"fake_if\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_7c49bcb6","line":75,"updated":"2015-09-22 10:56:49.000000000","message":"it should be:\n\n  self.assertEqual(expected, observed)","commit_id":"c026d9850992221cdec1ff40031d7234eed9f599"}]}
