)]}'
{"quantum/api/api_common.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                      in the underlying switching fabric"},{"line_number":38,"context_line":"        UNKNOWN: the plugin does not support the operational status concept."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    UP \u003d \"UP\""},{"line_number":41,"context_line":"    DOWN \u003d \"DOWN\""},{"line_number":42,"context_line":"    PROVISIONING \u003d \"PROVISIONING\""},{"line_number":43,"context_line":"    UNKNOWN \u003d \"UNKNOWN\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F9aI%3D","line":40,"updated":"2011-12-13 10:35:40.000000000","message":"One other thing... its kind of confusing that admin status has \"ACTIVE\" and \"DOWN\", while op-status has \"UP\" and \"DOWN\".  I personally prefer \"UP\", but \"ACTIVE\" is already set in stone... I don\u0027t feel strongly here, bukt thought it was worth mentioning, as it already tripped me up.","commit_id":"67e07c74ab9c15d542ef712d711d4014ecd25a75"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"class OperationalStatus:"},{"line_number":31,"context_line":"    \"\"\" Enumeration for operational status"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        UP : the resource is available (operationall up)"},{"line_number":34,"context_line":"        DOWN : the resource is not operational; this might indicate"},{"line_number":35,"context_line":"               a failure in the underlying switching fabric."},{"line_number":36,"context_line":"        PROVISIONING: the plugin is creating or updating the resource"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAC3%2F%2F9XE%3D","line":33,"updated":"2011-12-13 15:54:27.000000000","message":"I think you mean \"operationally\" :)","commit_id":"6e38dcb70ebdf7eae955402908c62f0ae048ccf6"}],"quantum/api/networks.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    _serialization_metadata \u003d {"},{"line_number":158,"context_line":"            \"attributes\": {"},{"line_number":159,"context_line":"                \"network\": [\"id\", \"name\", \"op-status\"],"},{"line_number":160,"context_line":"                \"port\": [\"id\", \"state\", \"opstatus\"],"},{"line_number":161,"context_line":"                \"attachment\": [\"id\"]},"},{"line_number":162,"context_line":"            \"plurals\": {\"networks\": \"network\","},{"line_number":163,"context_line":"                        \"ports\": \"port\"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F90s%3D","line":160,"updated":"2011-12-11 08:23:06.000000000","message":"why is one \"op-status\" and the other \"opstatus\"? Seems like they should be the same.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"    _serialization_metadata \u003d {"},{"line_number":158,"context_line":"            \"attributes\": {"},{"line_number":159,"context_line":"                \"network\": [\"id\", \"name\", \"op-status\"],"},{"line_number":160,"context_line":"                \"port\": [\"id\", \"state\", \"opstatus\"],"},{"line_number":161,"context_line":"                \"attachment\": [\"id\"]},"},{"line_number":162,"context_line":"            \"plurals\": {\"networks\": \"network\","},{"line_number":163,"context_line":"                        \"ports\": \"port\"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9w4%3D","line":160,"in_reply_to":"AAAAC3%2F%2F90s%3D","updated":"2011-12-12 09:56:07.000000000","message":"This is indeed an error. \nThey should be both op-status.\n\nI started with \u0027opstatus\u0027 and then changed to \u0027op-status\u0027, but forgot to update this line. \nThanks for spotting this, and I will also try to ensure a unit tests captures this issue.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"}],"quantum/api/ports.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    _serialization_metadata \u003d {"},{"line_number":153,"context_line":"            \"attributes\": {"},{"line_number":154,"context_line":"                \"port\": [\"id\", \"state\", \"opstatus\"],"},{"line_number":155,"context_line":"                \"attachment\": [\"id\"]},"},{"line_number":156,"context_line":"            \"plurals\": {\"ports\": \"port\"}"},{"line_number":157,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F90c%3D","line":154,"updated":"2011-12-11 08:23:06.000000000","message":"\"opstatus\" (no dash) again.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    _serialization_metadata \u003d {"},{"line_number":153,"context_line":"            \"attributes\": {"},{"line_number":154,"context_line":"                \"port\": [\"id\", \"state\", \"opstatus\"],"},{"line_number":155,"context_line":"                \"attachment\": [\"id\"]},"},{"line_number":156,"context_line":"            \"plurals\": {\"ports\": \"port\"}"},{"line_number":157,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9w0%3D","line":154,"in_reply_to":"AAAAC3%2F%2F90c%3D","updated":"2011-12-12 09:56:07.000000000","message":"See previous reply.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"}],"quantum/api/views/networks.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                     OperationalStatus.UNKNOWN)"},{"line_number":78,"context_line":"        return dict(network\u003d{\u0027id\u0027: network_data[\u0027net-id\u0027],"},{"line_number":79,"context_line":"                             \u0027name\u0027: network_data[\u0027net-name\u0027],"},{"line_number":80,"context_line":"                             \u0027op-status\u0027: op_status})"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _build_port(self, port_data):"},{"line_number":83,"context_line":"        \"\"\"Return details about a specific logical port.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F90o%3D","line":80,"updated":"2011-12-11 08:23:06.000000000","message":"op-status vs. opstatus seems inconsistent with metadata","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                     OperationalStatus.UNKNOWN)"},{"line_number":78,"context_line":"        return dict(network\u003d{\u0027id\u0027: network_data[\u0027net-id\u0027],"},{"line_number":79,"context_line":"                             \u0027name\u0027: network_data[\u0027net-name\u0027],"},{"line_number":80,"context_line":"                             \u0027op-status\u0027: op_status})"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _build_port(self, port_data):"},{"line_number":83,"context_line":"        \"\"\"Return details about a specific logical port.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9ws%3D","line":80,"in_reply_to":"AAAAC3%2F%2F90o%3D","updated":"2011-12-12 09:56:07.000000000","message":"The \u0027correct\u0027 name for the attribute should be \"op-status\".\nAs I wrote in a previous comment, I started without the dash, and then added it. \nUnfortunately I updated only the bits of code which were covered by unit tests, apparently.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"}],"quantum/api/views/ports.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return port"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class ViewBuilder11(ViewBuilder10):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def build(self, port_data, port_details\u003dFalse, att_details\u003dFalse):"},{"line_number":51,"context_line":"        \"\"\"Generates a port entity with operation status info\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAC3%2F%2F9XA%3D","line":48,"updated":"2011-12-13 15:54:27.000000000","message":"When this grows we might want to condense the newer ones to call super(build) and then just add its new data (op-status).. but not a big deal for now.","commit_id":"6e38dcb70ebdf7eae955402908c62f0ae048ccf6"}],"quantum/client/cli_lib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"list_nets\":      \"Virtual Networks for Tenant %(tenant_id)s\\n\" +"},{"line_number":97,"context_line":"                          \"%(networks|\\tNetwork ID: %(id)s)s\","},{"line_number":98,"context_line":"        \"show_net\":       \"Network ID: %(network.id)s\\n\" +"},{"line_number":99,"context_line":"                          \"network Name: %(network.name)s\\n\","},{"line_number":100,"context_line":"        \"create_net\":     \"Created a new Virtual Network with ID: \" +"},{"line_number":101,"context_line":"                          \"%(network_id)s\\n\" +"},{"line_number":102,"context_line":"                          \"for Tenant: %(tenant_id)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F90k%3D","line":99,"updated":"2011-12-11 08:23:06.000000000","message":"adding newline here seems inconsistent with other commands below, which do not print out a newline for the final line of the template.  Is show_net different in some way?","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"list_nets\":      \"Virtual Networks for Tenant %(tenant_id)s\\n\" +"},{"line_number":97,"context_line":"                          \"%(networks|\\tNetwork ID: %(id)s)s\","},{"line_number":98,"context_line":"        \"show_net\":       \"Network ID: %(network.id)s\\n\" +"},{"line_number":99,"context_line":"                          \"network Name: %(network.name)s\\n\","},{"line_number":100,"context_line":"        \"create_net\":     \"Created a new Virtual Network with ID: \" +"},{"line_number":101,"context_line":"                          \"%(network_id)s\\n\" +"},{"line_number":102,"context_line":"                          \"for Tenant: %(tenant_id)s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9wo%3D","line":99,"in_reply_to":"AAAAC3%2F%2F90k%3D","updated":"2011-12-12 09:56:07.000000000","message":"My apologies, this is a leftover from me trying to update the CLI as well in this branch.\nWill be removed.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"}],"quantum/tests/unit/test_api.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                          \u0027op-status\u0027: \u0027UP\u0027,"},{"line_number":82,"context_line":"                          \u0027attachment\u0027: {\u0027id\u0027: kwargs[\u0027interface_id\u0027]}},"},{"line_number":83,"context_line":"                         kwargs[\u0027port_data\u0027])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(APITestV11, self).setUp(\u0027quantum.api.APIRouterV11\u0027,"},{"line_number":87,"context_line":"             {test_api.NETS: nets.ControllerV11._serialization_metadata,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F90g%3D","line":84,"updated":"2011-12-11 08:23:06.000000000","message":"that\u0027s a nice design to handling the differences between v1.0 and v1.1","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":"                          \u0027op-status\u0027: \u0027UP\u0027,"},{"line_number":82,"context_line":"                          \u0027attachment\u0027: {\u0027id\u0027: kwargs[\u0027interface_id\u0027]}},"},{"line_number":83,"context_line":"                         kwargs[\u0027port_data\u0027])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(APITestV11, self).setUp(\u0027quantum.api.APIRouterV11\u0027,"},{"line_number":87,"context_line":"             {test_api.NETS: nets.ControllerV11._serialization_metadata,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9wk%3D","line":84,"in_reply_to":"AAAAC3%2F%2F90g%3D","updated":"2011-12-12 09:56:07.000000000","message":"I initially though testing both API 1.0 and 1.1 with unit tests looked a bit paranoid, but then realized that it is actually the right thing to do.","commit_id":"3afa4914fb37e21776e91dc3aec689c0df8c3aa9"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"9e4f79df240b9e985b5f8225eaec71e054a6df92","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertEqual({\u0027id\u0027: kwargs[\u0027id\u0027], \u0027state\u0027: kwargs[\u0027state\u0027],"},{"line_number":81,"context_line":"                          \u0027op-status\u0027: \u0027UP\u0027,"},{"line_number":82,"context_line":"                          \u0027attachment\u0027: {\u0027id\u0027: kwargs[\u0027interface_id\u0027]}},"},{"line_number":83,"context_line":"                         kwargs[\u0027port_data\u0027])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(APITestV11, self).setUp(\u0027quantum.api.APIRouterV11\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F9as%3D","line":83,"updated":"2011-12-13 08:38:23.000000000","message":"I didn\u0027t notice that you had hard-coded the operational status here to be \u0027UP\u0027.  I don\u0027t think this will work given that you have to run these tests with other plugins.  In fact, given that in the unit tests we are running a plugin that is not connected to a switch, if anything the port op-status should probably be down :)  At least that is the case with the OVS plugin.","commit_id":"67e07c74ab9c15d542ef712d711d4014ecd25a75"}]}