)]}'
{"neutron/services/trunk_port/plugin.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5c442346f1c3b7ac547692857ce8aa9b6bbad0c9","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_log import log as logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.db.trunk_port_trunk import TrunkPortDbMixin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d5f13302","line":15,"updated":"2015-08-07 12:20:51.000000000","message":"Do not import objects, only modules\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"42efd1cb6b89242f8bef94b2c47addfcd2483cfe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a709168db1229d8a37145ca85fb5864163b0c90b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_log import log as logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.db.trunk_port_trunk import TrunkPortDbMixin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4410c94e","line":15,"in_reply_to":"1a4dcd0f_d5f13302","updated":"2015-08-12 15:09:27.000000000","message":"Done, fix coming in the next patch set.","commit_id":"42efd1cb6b89242f8bef94b2c47addfcd2483cfe"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5c442346f1c3b7ac547692857ce8aa9b6bbad0c9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def get_plugin_type(self):"},{"line_number":26,"context_line":"        # FIXME(bence romsics): Define constant in"},{"line_number":27,"context_line":"        # neutron/plugins/common/constants.py?"},{"line_number":28,"context_line":"        return \u0027trunk-port\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_plugin_description(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_350bb7d7","line":27,"updated":"2015-08-07 12:20:51.000000000","message":"yes, why not? or you can add a common constants module for the trunk-port plugin","commit_id":"42efd1cb6b89242f8bef94b2c47addfcd2483cfe"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a709168db1229d8a37145ca85fb5864163b0c90b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def get_plugin_type(self):"},{"line_number":26,"context_line":"        # FIXME(bence romsics): Define constant in"},{"line_number":27,"context_line":"        # neutron/plugins/common/constants.py?"},{"line_number":28,"context_line":"        return \u0027trunk-port\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_plugin_description(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_068c84d8","line":27,"in_reply_to":"1a4dcd0f_350bb7d7","updated":"2015-08-12 15:09:27.000000000","message":"I\u0027m having some problems with two plugins (eh, one of them is a ml2 extension driver) implementing together the same extension. Please see the first comment in the extension file about it.","commit_id":"42efd1cb6b89242f8bef94b2c47addfcd2483cfe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8d66ee267d67c5e4e91e73f9064658b2758f5235","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def create_trunk_port(self, context, trunk_port):"},{"line_number":34,"context_line":"        # TODO(Lajos Katona): Keep in mind to just return when"},{"line_number":35,"context_line":"        # everything is ready"},{"line_number":36,"context_line":"        return super(TrunkPortPlugin, self).create_trunk_port("},{"line_number":37,"context_line":"            context, trunk_port)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def update_trunk_port(self, context, id, trunk_port):"},{"line_number":40,"context_line":"        # TODO(Lajos Katona): Keep in mind to just return when"},{"line_number":41,"context_line":"        # everything is ready"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_5ba6bfc1","line":38,"range":{"start_line":36,"start_character":9,"end_line":38,"end_character":0},"updated":"2015-08-13 06:55:34.000000000","message":"In a convention in Python and Neutron, if subclass does nothing more than the parent class, we don\u0027t write nothing for such methods.\n\nI am okay with the current version since it is under development, but if so I would like to see TODO or NOTE comment like this. This applies to the methods below.","commit_id":"1c1b1537416e6cd81573930fa817450097dfaba7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"c4d4b7386be117dae2ac0a29c14086bb244811cd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # everything is ready"},{"line_number":36,"context_line":"        return super(TrunkPortPlugin, self).create_trunk_port("},{"line_number":37,"context_line":"            context, trunk_port)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def update_trunk_port(self, context, id, trunk_port):"},{"line_number":40,"context_line":"        # TODO(Lajos Katona): Keep in mind to just return when"},{"line_number":41,"context_line":"        # everything is ready"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_828b6ec2","line":38,"in_reply_to":"1a4dcd0f_5ba6bfc1","updated":"2015-08-13 12:39:48.000000000","message":"Done","commit_id":"1c1b1537416e6cd81573930fa817450097dfaba7"}]}