)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"eb3aada47b5031fa73ffb94d88f27ddfcc13e5c4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"check_changed_vlans doesn\u0027t need registered_ports since the"},{"line_number":10,"context_line":"ports processed by the agent are accessible from local_vlan_map"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I279dcaff469337c553b358f6f5476c7238e89a59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_1537e8ff","line":11,"updated":"2015-08-12 03:35:24.000000000","message":"Add blueprint","commit_id":"dbc921061a4ce7ac091c999f1407ab4f73343079"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"67ade7c97fcf763138fe5d99af404978a9d49d2a","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        port_info \u003d self._get_port_info(registered_ports, cur_ports)"},{"line_number":1140,"context_line":"        if updated_ports is None:"},{"line_number":1141,"context_line":"            updated_ports \u003d set()"},{"line_number":1142,"context_line":"        updated_ports.update(self.check_changed_vlans())"},{"line_number":1143,"context_line":"        if updated_ports:"},{"line_number":1144,"context_line":"            # Some updated ports might have been removed in the"},{"line_number":1145,"context_line":"            # meanwhile, and therefore should not be processed."}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_df1d9810","line":1142,"updated":"2015-08-27 04:01:34.000000000","message":"registered_ports will be empty if the ovsdb restarted (L1636), so if we removed this, it will be different.","commit_id":"038cbf1d6aea9de0f992e9015cafd694a1ad40d5"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a8883363911e60aadd4d347f7c667c615cece44b","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        port_info \u003d self._get_port_info(registered_ports, cur_ports)"},{"line_number":1140,"context_line":"        if updated_ports is None:"},{"line_number":1141,"context_line":"            updated_ports \u003d set()"},{"line_number":1142,"context_line":"        updated_ports.update(self.check_changed_vlans())"},{"line_number":1143,"context_line":"        if updated_ports:"},{"line_number":1144,"context_line":"            # Some updated ports might have been removed in the"},{"line_number":1145,"context_line":"            # meanwhile, and therefore should not be processed."}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_f1a40cba","line":1142,"in_reply_to":"da20952f_3d0cc541","updated":"2015-09-03 08:13:22.000000000","message":"I need this change for the dependent patches, specifically for https://review.openstack.org/#/c/211192/","commit_id":"038cbf1d6aea9de0f992e9015cafd694a1ad40d5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"4217272dd09157144662ce280977a0b8ac79ff2b","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        port_info \u003d self._get_port_info(registered_ports, cur_ports)"},{"line_number":1140,"context_line":"        if updated_ports is None:"},{"line_number":1141,"context_line":"            updated_ports \u003d set()"},{"line_number":1142,"context_line":"        updated_ports.update(self.check_changed_vlans())"},{"line_number":1143,"context_line":"        if updated_ports:"},{"line_number":1144,"context_line":"            # Some updated ports might have been removed in the"},{"line_number":1145,"context_line":"            # meanwhile, and therefore should not be processed."}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_3d0cc541","line":1142,"in_reply_to":"da20952f_6a727fe7","updated":"2015-09-02 11:56:12.000000000","message":"since the result wil be the same and there was an improvement, why change it (if I follow you)?","commit_id":"038cbf1d6aea9de0f992e9015cafd694a1ad40d5"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5837a5999647ffc613a6c653797b957064e4caa5","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        port_info \u003d self._get_port_info(registered_ports, cur_ports)"},{"line_number":1140,"context_line":"        if updated_ports is None:"},{"line_number":1141,"context_line":"            updated_ports \u003d set()"},{"line_number":1142,"context_line":"        updated_ports.update(self.check_changed_vlans())"},{"line_number":1143,"context_line":"        if updated_ports:"},{"line_number":1144,"context_line":"            # Some updated ports might have been removed in the"},{"line_number":1145,"context_line":"            # meanwhile, and therefore should not be processed."}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_6a727fe7","line":1142,"in_reply_to":"da20952f_df1d9810","updated":"2015-08-27 08:55:54.000000000","message":"if ovs restarted registered_ports will be empty and added ports will be cur_ports (see line 1131) .  What is returned by check_changed_vlans is added to updated_ports, which will be then added to \u0027added\u0027 ports (see line \t1394) . But since \u0027added\u0027 port contains all the ports on the machine, what is returned by check_changed_vlans won\u0027t make any difference. What could be improved is to skip check_changed_vlans altogether if ovs restarted.","commit_id":"038cbf1d6aea9de0f992e9015cafd694a1ad40d5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7d93567e27e7aecf8012aa93124bfbe4aa1bae4b","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        port_info \u003d self._get_port_info(registered_ports, cur_ports)"},{"line_number":1140,"context_line":"        if updated_ports is None:"},{"line_number":1141,"context_line":"            updated_ports \u003d set()"},{"line_number":1142,"context_line":"        updated_ports.update(self.check_changed_vlans())"},{"line_number":1143,"context_line":"        if updated_ports:"},{"line_number":1144,"context_line":"            # Some updated ports might have been removed in the"},{"line_number":1145,"context_line":"            # meanwhile, and therefore should not be processed."}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_17f3b09f","line":1142,"in_reply_to":"da20952f_f1a40cba","updated":"2015-09-03 09:13:07.000000000","message":"it makes sense for this patch","commit_id":"038cbf1d6aea9de0f992e9015cafd694a1ad40d5"}]}