)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ac7093e66cf96f354a5c286270bb9ffb508344c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marga Millet \u003cfragatina@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-16 07:47:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow host route injection of metadata server IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vendors implementing Neutron L3 API in their devices may not be able to provide"},{"line_number":10,"context_line":"metadata server access via the Neutron router. In such cases it is useful for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_bce78d3f","line":7,"updated":"2015-08-17 23:23:07.000000000","message":"Commit title and message are quite unclear: before reading the code i assumed the aim of the code was to allow to set metadata server route using subnet host_routes attributes. \n\nPrefer something like: \n\n Allow dhcp metadata service use for non-isolated networks","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a2db9bd795d646471aedf779d5f8ac47a2a89f31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marga Millet \u003cfragatina@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-16 07:47:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow host route injection of metadata server IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vendors implementing Neutron L3 API in their devices may not be able to provide"},{"line_number":10,"context_line":"metadata server access via the Neutron router. In such cases it is useful for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_a4bbe471","line":7,"in_reply_to":"fa1b9901_bce78d3f","updated":"2015-08-18 07:44:12.000000000","message":"Done","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ab1b22fa0e76f83ba677b1f7ce031402f17249a9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Vendors implementing Neutron L3 API in their devices may not be able to provide"},{"line_number":10,"context_line":"metadata server access via the Neutron router. In such cases we want to allow"},{"line_number":11,"context_line":"the metadata service as done for non-isolated networks segments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5f6ee9788717c3d4f1f2e2a4b9734fdd8dd92b40"},{"line_number":14,"context_line":"Closes-Bug:#1483939"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa1b9901_b7d39bd4","line":12,"updated":"2015-08-20 10:40:18.000000000","message":"I guess this needs DocImpact (https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references)","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a9a4e57d44ceb2b927a84628b3530401e1029c4f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Vendors implementing Neutron L3 API in their devices may not be able to provide"},{"line_number":10,"context_line":"metadata server access via the Neutron router. In such cases we want to allow"},{"line_number":11,"context_line":"the metadata service as done for non-isolated networks segments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5f6ee9788717c3d4f1f2e2a4b9734fdd8dd92b40"},{"line_number":14,"context_line":"Closes-Bug:#1483939"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa1b9901_6e7525f8","line":12,"in_reply_to":"fa1b9901_b7d39bd4","updated":"2015-08-20 13:41:31.000000000","message":"Thanks Oleg, I\u0027ll tag it appropiately","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"}],"etc/dhcp_agent.ini":[{"author":{"_account_id":7021,"name":"Hareesh Puthalath","email":"hareesh.puthalath@gmail.com","username":"hareesh"},"change_message_id":"06d30399423443bfa22b860629fa48a03c7d90f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":44,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# In some cases the neutron router cannot provide the metadata server IP"},{"line_number":47,"context_line":"# but it can be done via the DHCP server as it happens on isolated networks."},{"line_number":48,"context_line":"# Setting this value will force the DHCP server to append specific host "},{"line_number":49,"context_line":"# routes to the DHCP request."}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a4dcd0f_639a1a64","line":46,"updated":"2015-08-12 14:56:34.000000000","message":"consider rewording this line to be more clear about the issue. Also remove the empty space in the 3rd line","commit_id":"0bf8e88f7de456151ad222d662e288ea7f151458"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ac7093e66cf96f354a5c286270bb9ffb508344c6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":44,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# In some cases the neutron router is not present to provide the metatadata"},{"line_number":47,"context_line":"# IP but the DHCP server can be used to provide this info. Setting this"},{"line_number":48,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":49,"context_line":"# DHCP request."}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa1b9901_7931070b","line":46,"updated":"2015-08-17 23:23:07.000000000","message":"metadata\n\niirc, this text should be aligned with always_use_dhcp_to_get_metadata help in config.py","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a2db9bd795d646471aedf779d5f8ac47a2a89f31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":44,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# In some cases the neutron router is not present to provide the metatadata"},{"line_number":47,"context_line":"# IP but the DHCP server can be used to provide this info. Setting this"},{"line_number":48,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":49,"context_line":"# DHCP request."}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa1b9901_840ca095","line":46,"in_reply_to":"fa1b9901_7931070b","updated":"2015-08-18 07:44:12.000000000","message":"Done","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"bac9971fef634a5f874954db99b7300e8333d780","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"},{"line_number":41,"context_line":"# specific host routes to the DHCP request. The metadata service will only"},{"line_number":42,"context_line":"# be activated when the subnet does not contain any router port. The guest"},{"line_number":43,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":44,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# In some cases the neutron router is not present to provide the metadata"}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa1b9901_45541e20","line":43,"updated":"2015-08-18 21:46:48.000000000","message":"you should clarify that changing enable_isolated_metadata value has no effect when enable_always_metadata is True","commit_id":"08a3664577a498305cc0d87433d2bed5b6c6a5f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3577b252f51a9418dd98381389920f186e0d10ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":42,"context_line":"# DHCP request. If this option is set, then the metadata service will be"},{"line_number":43,"context_line":"# activated for all the networks."},{"line_number":44,"context_line":"# enable_always_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The DHCP server can assist with providing metadata support on isolated"},{"line_number":47,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa1b9901_67f59c81","line":44,"updated":"2015-08-19 04:27:36.000000000","message":"I\u0027ve seen how the name has changed over the patchsets :)  but it still doesn\u0027t roll off the tongue.  I know you\u0027re trying to stay with enable*, but always_enable_metadata really describes exactly what it\u0027s doing.","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"96b7a68fea312b684097ef762e2f33f330abb4bb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":42,"context_line":"# DHCP request. If this option is set, then the metadata service will be"},{"line_number":43,"context_line":"# activated for all the networks."},{"line_number":44,"context_line":"# enable_always_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The DHCP server can assist with providing metadata support on isolated"},{"line_number":47,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa1b9901_9bcb5d1e","line":44,"in_reply_to":"fa1b9901_4d975948","updated":"2015-08-19 12:09:04.000000000","message":"ok, let\u0027s hope a new name conquers all hearts! :-)","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"356f18f8d19ced1e98770781b095316aef854eed","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":42,"context_line":"# DHCP request. If this option is set, then the metadata service will be"},{"line_number":43,"context_line":"# activated for all the networks."},{"line_number":44,"context_line":"# enable_always_metadata \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The DHCP server can assist with providing metadata support on isolated"},{"line_number":47,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa1b9901_4d975948","line":44,"in_reply_to":"fa1b9901_67f59c81","updated":"2015-08-19 06:00:56.000000000","message":"how about \"enable_metadata_always\", that way there\u0027s the enable* model that maps to the rest of the local config, and it says \"always\".","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b6f830388a099be48c9736235d0dd3a4c119072e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":42,"context_line":"# DHCP request. If this option is set, then the metadata service will be"},{"line_number":43,"context_line":"# activated for all the networks."},{"line_number":44,"context_line":"# enable_metadata_always \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The DHCP server can assist with providing metadata support on isolated"},{"line_number":47,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa1b9901_a6061a1a","line":44,"updated":"2015-08-20 04:00:32.000000000","message":"use a name like \"force_metadata\".\n\n\u0027always\u0027 isn\u0027t used in other configuration options in openstack, but \u0027force\u0027 is quite common. Let\u0027s use \u0027force\u0027 for consistency.","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a9a4e57d44ceb2b927a84628b3530401e1029c4f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# value will force the DHCP server to append specific host routes to the"},{"line_number":42,"context_line":"# DHCP request. If this option is set, then the metadata service will be"},{"line_number":43,"context_line":"# activated for all the networks."},{"line_number":44,"context_line":"# enable_metadata_always \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The DHCP server can assist with providing metadata support on isolated"},{"line_number":47,"context_line":"# networks. Setting this value to True will cause the DHCP server to append"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa1b9901_e9328f5d","line":44,"in_reply_to":"fa1b9901_a6061a1a","updated":"2015-08-20 13:41:31.000000000","message":"Done","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"79ce2cf5bd152d82e08b90e14f9eeb7a7c333b28","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# specific host routes to the DHCP request. The metadata service will only"},{"line_number":49,"context_line":"# be activated when the subnet does not contain any router port. The guest"},{"line_number":50,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":51,"context_line":"# This option doesn\u0027t have effect when enable_metadata_always is set to True."},{"line_number":52,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Allows for serving metadata requests coming from a dedicated metadata"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa1b9901_81718eaa","line":51,"updated":"2015-08-19 21:07:52.000000000","message":"doesn\u0027t have ANY(?) effect","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a9a4e57d44ceb2b927a84628b3530401e1029c4f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# specific host routes to the DHCP request. The metadata service will only"},{"line_number":49,"context_line":"# be activated when the subnet does not contain any router port. The guest"},{"line_number":50,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":51,"context_line":"# This option doesn\u0027t have effect when enable_metadata_always is set to True."},{"line_number":52,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Allows for serving metadata requests coming from a dedicated metadata"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa1b9901_69475fbc","line":51,"in_reply_to":"fa1b9901_81718eaa","updated":"2015-08-20 13:41:31.000000000","message":"Done","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"bb811c9c40e16c70f1dba99c5fce02c889c6ae8d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# specific host routes to the DHCP request. The metadata service will only"},{"line_number":49,"context_line":"# be activated when the subnet does not contain any router port. The guest"},{"line_number":50,"context_line":"# instance must be configured to request host routes via DHCP (Option 121)."},{"line_number":51,"context_line":"# This option doesn\u0027t have effect when enable_metadata_always is set to True."},{"line_number":52,"context_line":"# enable_isolated_metadata \u003d False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Allows for serving metadata requests coming from a dedicated metadata"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa1b9901_9260fea6","line":51,"in_reply_to":"fa1b9901_81718eaa","updated":"2015-08-19 22:30:45.000000000","message":"Thanks Cedric! It looks better. \nI\u0027ll update, if I need to push another patch","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ac7093e66cf96f354a5c286270bb9ffb508344c6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.IntOpt(\u0027num_sync_threads\u0027, default\u003d4,"},{"line_number":32,"context_line":"               help\u003d_(\u0027Number of threads to use during sync process.\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\"always_use_dhcp_to_get_metadata\", default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d_(\"Allows for host route injection of metadata server \""},{"line_number":35,"context_line":"                       \"IP via DHCP\")),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_bc554dc7","line":34,"updated":"2015-08-17 23:23:07.000000000","message":"help is unclear (see commit message)\n\nMoreover there is \"enable_isolated_metadata\" option to enable dhcp metadata service on isolated networks, so for consistency i would prefer \"enable_always_metadata\" instead of \"always_use_...\"","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a2db9bd795d646471aedf779d5f8ac47a2a89f31","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.IntOpt(\u0027num_sync_threads\u0027, default\u003d4,"},{"line_number":32,"context_line":"               help\u003d_(\u0027Number of threads to use during sync process.\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\"always_use_dhcp_to_get_metadata\", default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d_(\"Allows for host route injection of metadata server \""},{"line_number":35,"context_line":"                       \"IP via DHCP\")),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_8457c001","line":34,"in_reply_to":"fa1b9901_bc554dc7","updated":"2015-08-18 07:44:12.000000000","message":"As you see, there\u0027s already another enable_isolated_metadata variable above used in a similar but slightly different scenario. Hence, I won\u0027t change the name","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"b060ccf6cad658185bb3caa46cac2b646c8b0ee0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_isolated_metadata\u0027, default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d_(\"Support Metadata requests on isolated networks.\")),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027always_use_dhcp_to_get_metadata\u0027, default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Always use DHCP to get Metadata on pure isolated \""},{"line_number":29,"context_line":"                       \"networks\")),"},{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d_(\"Allows for serving metadata requests from a \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_f33667e6","line":28,"updated":"2015-08-18 17:33:11.000000000","message":"According to enabled_isolated_metadata description and associated implementation, isolated networks mean networks without subnet having a gateway ip not networks without subnet connected to a router","commit_id":"b25db81704eab1cdd24cc530aa12cdd1a1d4f550"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3577b252f51a9418dd98381389920f186e0d10ab","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_isolated_metadata\u0027, default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d_(\"Support Metadata requests on isolated networks.\")),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027enable_always_metadata\u0027, default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Allows to use DHCP to get Metadata on all networks\")),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":31,"context_line":"                       \"dedicated network. Requires \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_e730cca0","line":28,"updated":"2015-08-19 04:27:36.000000000","message":"nit: missing trailing \u0027.\u0027","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"96b7a68fea312b684097ef762e2f33f330abb4bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027enable_isolated_metadata\u0027, default\u003dFalse,"},{"line_number":26,"context_line":"                help\u003d_(\"Support Metadata requests on isolated networks.\")),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027enable_always_metadata\u0027, default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d_(\"Allows to use DHCP to get Metadata on all networks\")),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027enable_metadata_network\u0027, default\u003dFalse,"},{"line_number":30,"context_line":"                help\u003d_(\"Allows for serving metadata requests from a \""},{"line_number":31,"context_line":"                       \"dedicated network. Requires \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_0697f048","line":28,"in_reply_to":"fa1b9901_e730cca0","updated":"2015-08-19 12:09:04.000000000","message":"Done","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ac7093e66cf96f354a5c286270bb9ffb508344c6","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        \"\"\"Determine whether the metadata proxy is needed for a network"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router), when either enable_isolated_metadata or"},{"line_number":924,"context_line":"        always_use_dhcp_to_get_metadata flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9cbba9c4","line":923,"updated":"2015-08-17 23:23:07.000000000","message":"The sentence seems incorrect:\n \n This method returns True for truly isolated networks when \n enable_isolated_metadata flag is True or for all networks when \n always_use_dhcp_to_get_metadata is True","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a2db9bd795d646471aedf779d5f8ac47a2a89f31","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        \"\"\"Determine whether the metadata proxy is needed for a network"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router), when either enable_isolated_metadata or"},{"line_number":924,"context_line":"        always_use_dhcp_to_get_metadata flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_04c97078","line":923,"in_reply_to":"fa1b9901_9cbba9c4","updated":"2015-08-18 07:44:12.000000000","message":"Done","commit_id":"150b70f83f7bc391ca17804f01de8c01089749eb"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"356f18f8d19ced1e98770781b095316aef854eed","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        \"\"\"Determine whether the metadata proxy is needed for a network"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router), when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_always_metadata flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_cd904946","line":923,"updated":"2015-08-19 06:00:56.000000000","message":"nit: If we\u0027re going to be gramatically correct, you might as well remove the , after the ).","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"96b7a68fea312b684097ef762e2f33f330abb4bb","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        \"\"\"Determine whether the metadata proxy is needed for a network"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router), when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_always_metadata flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_26a0f48f","line":923,"in_reply_to":"fa1b9901_cd904946","updated":"2015-08-19 12:09:04.000000000","message":"Done","commit_id":"1b0e23e7d60be88721aa383c5d6f7d6fba95e94e"},{"author":{"_account_id":6620,"name":"Abishek Subramanian","email":"absubram@cisco.com","username":"absubram"},"change_message_id":"67238f7646c98676cb14ecd96872dacdadd7f31f","unresolved":false,"context_lines":[{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router) when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_metadata_always flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"},{"line_number":927,"context_line":"        and the network passed as a parameter has a subnet in the link-local"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_fe1b4bc8","line":924,"updated":"2015-08-19 21:00:34.000000000","message":"Minor nit, but the way it is written, it sounds like you need both enable_isoloated_metadata and enable_metadata_always flags.\n\nCan we re-word it something like - \n\"This method returns True for only truly isolated networks (i.e.: not attached to a router) when then enable_isolated_metdata flag alone is True.\n\nThis method also returns True for all networks when the enable_metadata_always flag is true.\"","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"a9a4e57d44ceb2b927a84628b3530401e1029c4f","unresolved":false,"context_lines":[{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router) when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_metadata_always flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"},{"line_number":927,"context_line":"        and the network passed as a parameter has a subnet in the link-local"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_c9a22b99","line":924,"in_reply_to":"fa1b9901_2cc4398f","updated":"2015-08-20 13:41:31.000000000","message":"Done","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":11269,"name":"Marga Millet","email":"marga.sfo@gmail.com","username":"marga"},"change_message_id":"bb811c9c40e16c70f1dba99c5fce02c889c6ae8d","unresolved":false,"context_lines":[{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router) when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_metadata_always flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"},{"line_number":927,"context_line":"        and the network passed as a parameter has a subnet in the link-local"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_520d86e6","line":924,"in_reply_to":"fa1b9901_2cc4398f","updated":"2015-08-19 22:30:45.000000000","message":"Thanks Abishek for your comments. If I need to submit another patch, I\u0027ll change it this way.","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":6620,"name":"Abishek Subramanian","email":"absubram@cisco.com","username":"absubram"},"change_message_id":"f2afae734db5e806e929fcf98c5a901ca1a56e57","unresolved":false,"context_lines":[{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router) when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_metadata_always flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"},{"line_number":927,"context_line":"        and the network passed as a parameter has a subnet in the link-local"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_2cc4398f","line":924,"in_reply_to":"fa1b9901_c1f0e600","updated":"2015-08-19 21:32:48.000000000","message":"Well at least the last part then needs to change to -\n\"the enable_metadata_always flag is True.\"","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"319941c4bacbd6e710b99fcd54ca5e14a680acbf","unresolved":false,"context_lines":[{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        This method returns True for truly isolated networks (ie: not attached"},{"line_number":923,"context_line":"        to a router) when enable_isolated_metadata is True or for all the"},{"line_number":924,"context_line":"        networks when enable_metadata_always flags are True."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        This method also returns True when enable_metadata_network is True,"},{"line_number":927,"context_line":"        and the network passed as a parameter has a subnet in the link-local"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_c1f0e600","line":924,"in_reply_to":"fa1b9901_fe1b4bc8","updated":"2015-08-19 21:10:42.000000000","message":"imo, current sentence is not ambiguous","commit_id":"c8c7f7dca4b7311640ad71d20277558f53b2b64c"}]}