)]}'
{"quantum/db/api.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"dcc253f3473c13ef6bfd562c224363b18da1ee22","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            msg \u003d _(\"Configuration option \u0027sql_connection\u0027 not \""},{"line_number":116,"context_line":"                    \"specified in any config file.\")"},{"line_number":117,"context_line":"            LOG.error(msg)"},{"line_number":118,"context_line":"            raise Exception(msg)"},{"line_number":119,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"},{"line_number":120,"context_line":"        engine_args \u003d {"},{"line_number":121,"context_line":"            \u0027pool_recycle\u0027: 3600,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FHYw%3D","line":118,"updated":"2013-02-06 18:43:37.000000000","message":"We should avoid to use Exception. It is too generic","commit_id":"005d740896c9b3c2a32e985494af4d3d627b9850"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ec2bc0ec7fe235340e067e1376f744ea4ae8241a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            msg \u003d _(\"Configuration option \u0027sql_connection\u0027 not \""},{"line_number":116,"context_line":"                    \"specified in any config file.\")"},{"line_number":117,"context_line":"            LOG.error(msg)"},{"line_number":118,"context_line":"            raise Exception(msg)"},{"line_number":119,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"},{"line_number":120,"context_line":"        engine_args \u003d {"},{"line_number":121,"context_line":"            \u0027pool_recycle\u0027: 3600,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FHGE%3D","line":118,"in_reply_to":"AAAAM3%2F%2FHYw%3D","updated":"2013-02-06 20:53:00.000000000","message":"Sure, I see there is NoSuchIptError() and RequiredOptError(). The latter seems more appropriate. Will revise.","commit_id":"005d740896c9b3c2a32e985494af4d3d627b9850"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       \"in any config file - using default \""},{"line_number":118,"context_line":"                       \"value \u0027%s\u0027\" % SQL_CONNECTION_DEFAULT))"},{"line_number":119,"context_line":"            sql_connection \u003d SQL_CONNECTION_DEFAULT"},{"line_number":120,"context_line":"            cfg.CONF.set_override(\u0027sql_connection\u0027,"},{"line_number":121,"context_line":"                                  SQL_CONNECTION_DEFAULT,"},{"line_number":122,"context_line":"                                  \u0027DATABASE\u0027)"},{"line_number":123,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FA4E%3D","line":120,"updated":"2013-02-11 17:12:11.000000000","message":"I think that tthe cfg.CONF should be just \u0027read only\u0027. I think that it is best that we do not do the overried.","commit_id":"1486e8d696ec35da18e33ed15b72141a66438cc5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ec2bc0ec7fe235340e067e1376f744ea4ae8241a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       \"in any config file - using default \""},{"line_number":118,"context_line":"                       \"value \u0027%s\u0027\" % SQL_CONNECTION_DEFAULT))"},{"line_number":119,"context_line":"            sql_connection \u003d SQL_CONNECTION_DEFAULT"},{"line_number":120,"context_line":"            cfg.CONF.set_override(\u0027sql_connection\u0027,"},{"line_number":121,"context_line":"                                  SQL_CONNECTION_DEFAULT,"},{"line_number":122,"context_line":"                                  \u0027DATABASE\u0027)"},{"line_number":123,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FAzY%3D","line":120,"in_reply_to":"AAAAM3%2F%2FA4E%3D","updated":"2013-02-11 17:37:02.000000000","message":"Sorry, I didn\u0027t see this, until I posted an update.  I was considering this a special case, with a default being applied, if none entered. IOW a lazy default.\n\nI can remove the override, but was concerned about a latent issue where some other code reads this config option. Then, at some point, a run occurs where the option is not specified, which would then cause an issue with the value being undefined.\n\nPlease let me know your thoughts on patch 6 and I can revise, if needed.","commit_id":"1486e8d696ec35da18e33ed15b72141a66438cc5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       \"in any config file - using default \""},{"line_number":118,"context_line":"                       \"value \u0027%s\u0027\" % SQL_CONNECTION_DEFAULT))"},{"line_number":119,"context_line":"            sql_connection \u003d SQL_CONNECTION_DEFAULT"},{"line_number":120,"context_line":"            cfg.CONF.set_override(\u0027sql_connection\u0027,"},{"line_number":121,"context_line":"                                  SQL_CONNECTION_DEFAULT,"},{"line_number":122,"context_line":"                                  \u0027DATABASE\u0027)"},{"line_number":123,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FATM%3D","line":120,"updated":"2013-02-11 21:30:52.000000000","message":"please remove the override.","commit_id":"6cc9136be22211da377f7499167b93b110d46729"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       \"in any config file - using default \""},{"line_number":118,"context_line":"                       \"value \u0027%s\u0027\" % SQL_CONNECTION_DEFAULT))"},{"line_number":119,"context_line":"            sql_connection \u003d SQL_CONNECTION_DEFAULT"},{"line_number":120,"context_line":"            cfg.CONF.set_override(\u0027sql_connection\u0027,"},{"line_number":121,"context_line":"                                  SQL_CONNECTION_DEFAULT,"},{"line_number":122,"context_line":"                                  \u0027DATABASE\u0027)"},{"line_number":123,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B%2Fj0%3D","line":120,"in_reply_to":"AAAAM3%2F%2FAQc%3D","updated":"2013-02-12 07:15:35.000000000","message":"I think that it should only be accessed by this code.","commit_id":"6cc9136be22211da377f7499167b93b110d46729"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ec2bc0ec7fe235340e067e1376f744ea4ae8241a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       \"in any config file - using default \""},{"line_number":118,"context_line":"                       \"value \u0027%s\u0027\" % SQL_CONNECTION_DEFAULT))"},{"line_number":119,"context_line":"            sql_connection \u003d SQL_CONNECTION_DEFAULT"},{"line_number":120,"context_line":"            cfg.CONF.set_override(\u0027sql_connection\u0027,"},{"line_number":121,"context_line":"                                  SQL_CONNECTION_DEFAULT,"},{"line_number":122,"context_line":"                                  \u0027DATABASE\u0027)"},{"line_number":123,"context_line":"        connection_dict \u003d sql.engine.url.make_url(sql_connection)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FAQc%3D","line":120,"in_reply_to":"AAAAM3%2F%2FATM%3D","updated":"2013-02-11 21:47:20.000000000","message":"Did you see my question in patch #5? I didn\u0027t notice the comment you made until I had posted patch #6 (sorry).\n\nI understand that cfg.CONF should be read-only. Thought was that this was a special case, where we\u0027re doing a \"lazy\" default assignment.\n\nMy concern is that if we don\u0027t have the override, and some other module uses sql_connection in the future, there will be a latent bug in that module, when sql_connection is not provided. It\u0027ll get set to the default in db/api.py, but not in the new module (unless they remember to set it there too).\n\nCan we guarantee that this will only be accessed by db/api.py?\nIf not, do we want to be setting default values in multiple places?\n\nPlease let me know and I can tweak the diff...","commit_id":"6cc9136be22211da377f7499167b93b110d46729"}]}