)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e99421c553447825f9c059091e893965caf8e5dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Index() object in the model such that autogenerate would"},{"line_number":12,"context_line":"know that these aren\u0027t removed.  Ensure they are considered by"},{"line_number":13,"context_line":"the include_object filter so that autogenerate does not"},{"line_number":14,"context_line":"include that these seem to be removed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I49abb3f7ad9731cde046fa2862cdb9ec16c3aeb3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_6349be5f","line":14,"updated":"2015-08-20 12:57:32.000000000","message":"you mean \u0027conclude\u0027?","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"0531d1e49f8822101891f2325c446cf74dae7dcc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Index() object in the model such that autogenerate would"},{"line_number":12,"context_line":"know that these aren\u0027t removed.  Ensure they are considered by"},{"line_number":13,"context_line":"the include_object filter so that autogenerate does not"},{"line_number":14,"context_line":"include that these seem to be removed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I49abb3f7ad9731cde046fa2862cdb9ec16c3aeb3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_3b7bee8d","line":14,"in_reply_to":"fa1b9901_6349be5f","updated":"2015-08-20 13:48:23.000000000","message":"er well i did mean \"include\" since we\u0027re talking about the \"include_object\" filter, e.g. in its list of changes it sees, \"index X is removed\", include_object says, \"don\u0027t include that\".   but it\u0027s not that clear here sure.","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"}],"neutron/db/migration/__init__.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e99421c553447825f9c059091e893965caf8e5dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# like to skip within autogenerate"},{"line_number":26,"context_line":"# (indexname, tablename)"},{"line_number":27,"context_line":"SPECIAL_INDEXES \u003d ["},{"line_number":28,"context_line":"    (\u0027idx_autoinc_vr_id\u0027, \u0027ha_router_vrid_allocations\u0027),  # mysql"},{"line_number":29,"context_line":"    (\u0027idx_autoinc_vnic_index\u0027, \u0027nsxv_edge_vnic_bindings\u0027)  # mysql"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_c37bea26","line":28,"updated":"2015-08-20 12:57:32.000000000","message":"Can you elaborate why those fields are special?","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"70279078533a69215d299c5ea4aa77aa2de4a8f4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# like to skip within autogenerate"},{"line_number":26,"context_line":"# (indexname, tablename)"},{"line_number":27,"context_line":"SPECIAL_INDEXES \u003d ["},{"line_number":28,"context_line":"    (\u0027idx_autoinc_vr_id\u0027, \u0027ha_router_vrid_allocations\u0027),  # mysql"},{"line_number":29,"context_line":"    (\u0027idx_autoinc_vnic_index\u0027, \u0027nsxv_edge_vnic_bindings\u0027)  # mysql"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_9e7ea817","line":28,"in_reply_to":"fa1b9901_5be58235","updated":"2015-08-20 14:08:51.000000000","message":"I mean, it\u0027s not clear to me why these specific fields got the index and not others. I tried to understand it by comparing them with other Integer fields, but failed to locate the clue. Do you know why they are special in mysql world?","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"eee304daeb5f80e77d72442f5f5a9a5964b6c930","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# like to skip within autogenerate"},{"line_number":26,"context_line":"# (indexname, tablename)"},{"line_number":27,"context_line":"SPECIAL_INDEXES \u003d ["},{"line_number":28,"context_line":"    (\u0027idx_autoinc_vr_id\u0027, \u0027ha_router_vrid_allocations\u0027),  # mysql"},{"line_number":29,"context_line":"    (\u0027idx_autoinc_vnic_index\u0027, \u0027nsxv_edge_vnic_bindings\u0027)  # mysql"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_9428c7e3","line":28,"in_reply_to":"fa1b9901_9e7ea817","updated":"2015-08-20 14:42:37.000000000","message":"well, you have a good point, because all this time i had assumed these indexes were there because someone wrote \"if db \u003d\u003d \u0027mysql\u0027: op.create_index()\" in a migration script.  But in fact it is because these tables setting up composite primary key columns with integers in them and are not setting autoincrement\u003dFalse, SQLAlchemy\u0027s MySQL dialect has a rule to generate an explicit KEY for these so that they are set up as the \"autoincrement\" column and that\u0027s coming out as an index here.\n\nthe default behavior of autoincrement w/ mysql composite pks, where people may or may not expect autoincrement in a composite primary key is a currently unsolvable problem: https://bitbucket.org/zzzeek/sqlalchemy/issues/3216/make-autoincrement-true-less-surprising-in\n\nSo, this SPECIAL_INDEXES list needs to be removed and we instead need to build a generic rule that works around the lack of \"autoincrement\u003dFalse\" on these columns.   Changing the tables also would be nice as they have a useless AUTOINCREMENT in them (note \"Change\" means \"migrate everyone\"), but there\u0027s no good mechanism from keeping this from happening over and over again.","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"0531d1e49f8822101891f2325c446cf74dae7dcc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# like to skip within autogenerate"},{"line_number":26,"context_line":"# (indexname, tablename)"},{"line_number":27,"context_line":"SPECIAL_INDEXES \u003d ["},{"line_number":28,"context_line":"    (\u0027idx_autoinc_vr_id\u0027, \u0027ha_router_vrid_allocations\u0027),  # mysql"},{"line_number":29,"context_line":"    (\u0027idx_autoinc_vnic_index\u0027, \u0027nsxv_edge_vnic_bindings\u0027)  # mysql"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_5be58235","line":28,"in_reply_to":"fa1b9901_c37bea26","updated":"2015-08-20 13:48:23.000000000","message":"the comment \"indexes that are not present in all database backends,which we\u0027d like to skip within autogenerate\" is attempting to describe this, can you suggest edits?","commit_id":"9578ffff1e2b0b27914f07026573e6a2c662fbda"}],"neutron/db/migration/alembic_migrations/external.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6d680f85f12f384cb0a2a7c996a88923418a70b4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"TABLES \u003d (FWAAS_TABLES + LBAAS_TABLES + VPNAAS_TABLES + DRIVER_TABLES)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# (indexname, tablename)"},{"line_number":49,"context_line":"MYSQL_INDEXES \u003d ["},{"line_number":50,"context_line":"    (\u0027idx_autoinc_vr_id\u0027, \u0027ha_router_vrid_allocations\u0027),"},{"line_number":51,"context_line":"    (\u0027idx_autoinc_vnic_index\u0027, \u0027nsxv_edge_vnic_bindings\u0027)"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9611f9b1","line":49,"updated":"2015-08-17 09:04:10.000000000","message":"I think this is not appropriate place for this list. May be just have it in alembic_migrations/env.py","commit_id":"8168e45190a399771a88389be6eb303d7eefe154"}]}