)]}'
{"neutron/service.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8d6945e029a94afe89fb4a3e62800664cd278302","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            self._wait()"},{"line_number":123,"context_line":"        except Exception as e:"},{"line_number":124,"context_line":"            LOG.error(\u0027done with wait: %s %r\u0027 % (e, e), exc_info\u003dTrue)"},{"line_number":125,"context_line":"            raise"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _wait(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_867b107b","line":124,"updated":"2015-08-17 01:49:11.000000000","message":"can you please use the log hint _LE\n\nsame for below","commit_id":"461f9ea4e4d91c0d0a3ee46fa12b03ab2e187056"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"32b0cb8dc34eb4bb8949c28ea7c096c24df57e0d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            self._wait()"},{"line_number":123,"context_line":"        except Exception:"},{"line_number":124,"context_line":"            LOG.error(_LE(\u0027done with wait\u0027), exc_info\u003dTrue)"},{"line_number":125,"context_line":"            raise"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _wait(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_7e9fb05f","line":124,"updated":"2015-08-17 21:07:05.000000000","message":"prefer LOG.exception(_LE(...))","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ea9f4f32376e454df47bd41ff200169c49bb599","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            self._wait()"},{"line_number":123,"context_line":"        except Exception:"},{"line_number":124,"context_line":"            LOG.error(_LE(\u0027done with wait\u0027), exc_info\u003dTrue)"},{"line_number":125,"context_line":"            raise"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _wait(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_7fe9e719","line":124,"in_reply_to":"fa1b9901_7e9fb05f","updated":"2015-08-17 23:38:42.000000000","message":"Done","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"32b0cb8dc34eb4bb8949c28ea7c096c24df57e0d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _wait(self):"},{"line_number":128,"context_line":"        LOG.error(_LE(\u0027calling RpcWorker wait()\u0027))"},{"line_number":129,"context_line":"        for server in self._servers:"},{"line_number":130,"context_line":"            if isinstance(server, rpc_server.MessageHandlingServer):"},{"line_number":131,"context_line":"                LOG.debug(\u0027calling wait on %s\u0027 % server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_be3f8824","line":128,"updated":"2015-08-17 21:07:05.000000000","message":"it seems to be the wrong log level? Is it a WIP change?","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ea9f4f32376e454df47bd41ff200169c49bb599","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _wait(self):"},{"line_number":128,"context_line":"        LOG.error(_LE(\u0027calling RpcWorker wait()\u0027))"},{"line_number":129,"context_line":"        for server in self._servers:"},{"line_number":130,"context_line":"            if isinstance(server, rpc_server.MessageHandlingServer):"},{"line_number":131,"context_line":"                LOG.debug(\u0027calling wait on %s\u0027 % server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_9fee3b21","line":128,"in_reply_to":"fa1b9901_be3f8824","updated":"2015-08-17 23:38:42.000000000","message":"Done","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"32b0cb8dc34eb4bb8949c28ea7c096c24df57e0d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        rpc \u003d RpcWorker(plugin)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if cfg.CONF.rpc_workers \u003c 1:"},{"line_number":168,"context_line":"            LOG.debug(\u0027starting rpc directly, workers\u003d%s\u0027 %"},{"line_number":169,"context_line":"                      cfg.CONF.rpc_workers)"},{"line_number":170,"context_line":"            rpc.start()"},{"line_number":171,"context_line":"            return rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_1e9eb456","line":168,"updated":"2015-08-17 21:07:05.000000000","message":"use lazy formatting:\n\n LOG.debug(\u0027...\u0027, cfg.CONF.rpc_workers)","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ea9f4f32376e454df47bd41ff200169c49bb599","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        rpc \u003d RpcWorker(plugin)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if cfg.CONF.rpc_workers \u003c 1:"},{"line_number":168,"context_line":"            LOG.debug(\u0027starting rpc directly, workers\u003d%s\u0027 %"},{"line_number":169,"context_line":"                      cfg.CONF.rpc_workers)"},{"line_number":170,"context_line":"            rpc.start()"},{"line_number":171,"context_line":"            return rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_bfe77f3f","line":168,"in_reply_to":"fa1b9901_1e9eb456","updated":"2015-08-17 23:38:42.000000000","message":"Done","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"32b0cb8dc34eb4bb8949c28ea7c096c24df57e0d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            # dispose the whole pool before os.fork, otherwise there will"},{"line_number":174,"context_line":"            # be shared DB connections in child processes which may cause"},{"line_number":175,"context_line":"            # DB errors."},{"line_number":176,"context_line":"            LOG.debug(\u0027using launcher for rpc, workers\u003d%s\u0027 %"},{"line_number":177,"context_line":"                      cfg.CONF.rpc_workers)"},{"line_number":178,"context_line":"            session.dispose()"},{"line_number":179,"context_line":"            launcher \u003d common_service.ProcessLauncher(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_9eaac46f","line":176,"updated":"2015-08-17 21:07:05.000000000","message":"itto","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ea9f4f32376e454df47bd41ff200169c49bb599","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            # dispose the whole pool before os.fork, otherwise there will"},{"line_number":174,"context_line":"            # be shared DB connections in child processes which may cause"},{"line_number":175,"context_line":"            # DB errors."},{"line_number":176,"context_line":"            LOG.debug(\u0027using launcher for rpc, workers\u003d%s\u0027 %"},{"line_number":177,"context_line":"                      cfg.CONF.rpc_workers)"},{"line_number":178,"context_line":"            session.dispose()"},{"line_number":179,"context_line":"            launcher \u003d common_service.ProcessLauncher(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_dfe4b33c","line":176,"in_reply_to":"fa1b9901_9eaac46f","updated":"2015-08-17 23:38:42.000000000","message":"Done","commit_id":"9f7daa9d68e3f34badc8bb17b6a4b8864550e54c"}]}
