)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"1fce4e18d9f7d6421e576df4f828e51a7155472e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"delete the redundant \u0027if len(network_ids) \u003d\u003d 1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2 condition can merge 1,for"},{"line_number":10,"context_line":"\"if len(network_ids) \u003d\u003d 1\" then"},{"line_number":11,"context_line":"NetworkDhcpAgentBinding.network_id in network_ids"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_10818dfb","line":9,"updated":"2015-08-15 01:08:59.000000000","message":"I am not convinced by this fix but let\u0027s start with having a bug reported","commit_id":"546ffdd3789e69d67db2ec90599f73ac63b9ab9b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2024458d479225929d0b24dba92119f8a60d2630","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"delete the redundant \u0027if len(network_ids) \u003d\u003d 1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2 condition can merge 1,for"},{"line_number":10,"context_line":"\"if len(network_ids) \u003d\u003d 1\" then"},{"line_number":11,"context_line":"NetworkDhcpAgentBinding.network_id in network_ids"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_507875f8","line":9,"in_reply_to":"1a4dcd0f_10818dfb","updated":"2015-08-15 01:29:17.000000000","message":"imo, a bug seems overkill for a cosmetic change (but the commit message must highlight it)","commit_id":"546ffdd3789e69d67db2ec90599f73ac63b9ab9b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2024458d479225929d0b24dba92119f8a60d2630","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2 condition can merge 1,for"},{"line_number":10,"context_line":"\"if len(network_ids) \u003d\u003d 1\" then"},{"line_number":11,"context_line":"NetworkDhcpAgentBinding.network_id in network_ids"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaf0d97d3186343ac8fc342213269d4bc44fbf0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_305cc97c","line":11,"updated":"2015-08-15 01:29:17.000000000","message":"This sentence is unclear, prefer:\n\nquery.filter(NetworkDhcpAgentBinding.network_id \u003d\u003d network_ids[0]) and \nquery.filter(NetworkDhcpAgentBinding.network_id in network_ids) are equivalent when len(network_ids) \u003d\u003d1, this change uses such property to simplify get_dhcp_agents_hosting_networks implementation.","commit_id":"546ffdd3789e69d67db2ec90599f73ac63b9ab9b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"426472a424c9004fd2fee75772b2ce47afaf3556","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2 condition can merge 1,for"},{"line_number":10,"context_line":"\"if len(network_ids) \u003d\u003d 1\" then"},{"line_number":11,"context_line":"NetworkDhcpAgentBinding.network_id in network_ids"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaf0d97d3186343ac8fc342213269d4bc44fbf0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_f405ec78","line":11,"updated":"2015-08-15 19:23:37.000000000","message":"comments from previous patch sets should be addressed. this message is not clear.  I would put a better description of the problem and fix instead of just the code.  I had to look at the code to see what the problem was.","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"cfdb3be7e249d6ac1263fd9835204cfb99c45200","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2 condition can merge 1,for"},{"line_number":10,"context_line":"\"if len(network_ids) \u003d\u003d 1\" then"},{"line_number":11,"context_line":"NetworkDhcpAgentBinding.network_id in network_ids"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaf0d97d3186343ac8fc342213269d4bc44fbf0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_86b8efe6","line":11,"in_reply_to":"1a4dcd0f_f405ec78","updated":"2015-08-28 09:12:55.000000000","message":"+1 :s","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2024458d479225929d0b24dba92119f8a60d2630","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        query \u003d query.options(orm.contains_eager("},{"line_number":331,"context_line":"                              NetworkDhcpAgentBinding.dhcp_agent))"},{"line_number":332,"context_line":"        query \u003d query.join(NetworkDhcpAgentBinding.dhcp_agent)"},{"line_number":333,"context_line":"        if len(network_ids)  \u003e 0:"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7014919e","line":333,"updated":"2015-08-15 01:29:17.000000000","message":"\"if network_ids:\" is equivalent","commit_id":"546ffdd3789e69d67db2ec90599f73ac63b9ab9b"},{"author":{"_account_id":8282,"name":"Dong Liu","email":"willowd878@gmail.com","username":"liudong"},"change_message_id":"31cb5e5491e86fecdde32372c5fa1d4bfa66b77d","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        query \u003d query.options(orm.contains_eager("},{"line_number":331,"context_line":"                              NetworkDhcpAgentBinding.dhcp_agent))"},{"line_number":332,"context_line":"        query \u003d query.join(NetworkDhcpAgentBinding.dhcp_agent)"},{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_fdf7d156","line":333,"updated":"2015-08-29 02:04:01.000000000","message":"I don\u0027t think the if statement is necessary, because there is \"if not network_ids\" in line 327.\nMaybe we can add this:\nif isinstance(network_ids, list):","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e275308ff7792fdf44a7ec2945b97866757d2ea1","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        query \u003d query.options(orm.contains_eager("},{"line_number":331,"context_line":"                              NetworkDhcpAgentBinding.dhcp_agent))"},{"line_number":332,"context_line":"        query \u003d query.join(NetworkDhcpAgentBinding.dhcp_agent)"},{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1379c82f","line":333,"updated":"2015-10-02 00:38:30.000000000","message":"I vote to remove 333 because it\u0027s doing no work given 327 and because it doesn\u0027t add to the code\u0027s readability.  I disagree with type-checking network_ids; if the caller is sending in something other than a list, they *should* get a trace, I believe, because they aren\u0027t sending in what they should and the lack of a trace in such a case will produce results they don\u0027t intend.","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"558ff621839f0b18c6a82427801959f96a6e085f","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        query \u003d query.options(orm.contains_eager("},{"line_number":331,"context_line":"                              NetworkDhcpAgentBinding.dhcp_agent))"},{"line_number":332,"context_line":"        query \u003d query.join(NetworkDhcpAgentBinding.dhcp_agent)"},{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4deecb23","line":333,"updated":"2015-08-26 22:15:12.000000000","message":"This can just become \u0027if network_ids\u0027","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"55615443e46a07c48a52488f6ac6eafdeacdb515","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        query \u003d query.options(orm.contains_eager("},{"line_number":331,"context_line":"                              NetworkDhcpAgentBinding.dhcp_agent))"},{"line_number":332,"context_line":"        query \u003d query.join(NetworkDhcpAgentBinding.dhcp_agent)"},{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_11994ec4","line":333,"in_reply_to":"da20952f_fdf7d156","updated":"2015-08-29 06:20:38.000000000","message":"I agree with Dong Liu","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e275308ff7792fdf44a7ec2945b97866757d2ea1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5302e070","line":336,"updated":"2015-10-02 00:38:30.000000000","message":"I disagree with the proposed change, whether in scope of this commit or not, from \"if admin_state_up is not None\" to \"if admin_state_up\".  The variable name smells like a Boolean--and 337-338 reinforce my suspicion here--in which case if the caller sends it in at all, they will want it acted upon as such.","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1279385031c82ea53ac1b198bd642a04fc8fd3e0","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_71812c8f","line":336,"updated":"2015-08-17 17:01:51.000000000","message":"unrelated and wrong change","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"445311de4979e54dabf3109bc946a4d170588c59","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_c7f93d4f","line":336,"in_reply_to":"fa1b9901_07c89554","updated":"2015-08-18 06:54:35.000000000","message":"+1","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":16053,"name":"Pengtao Huang","email":"huangpengtao@huawei.com","username":"huangpengtao"},"change_message_id":"c246e212366aa9295cd97c70f0b83bcd6182140d","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_859a68c4","line":336,"in_reply_to":"fa1b9901_07c89554","updated":"2015-08-27 01:04:38.000000000","message":"if network_ids is None  and will  return in line 328\nand also len(network_ids) will raise error.","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":16053,"name":"Pengtao Huang","email":"huangpengtao@huawei.com","username":"huangpengtao"},"change_message_id":"db4c0ba909eb25f5c5c21d9b9374ef22fd7ddbe8","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_e5f9e44e","line":336,"in_reply_to":"fa1b9901_71812c8f","updated":"2015-08-18 00:58:36.000000000","message":"This will be more simplify to read code. what about other\u0027s option.","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"cfdb3be7e249d6ac1263fd9835204cfb99c45200","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e6f20bd2","line":336,"in_reply_to":"fa1b9901_859a68c4","updated":"2015-08-28 09:12:55.000000000","message":"At least it should be done in a specific change as it\u0027s out of change scope","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"57937815b3b901314dffa8ab8b5d157a495da489","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if len(network_ids):"},{"line_number":334,"context_line":"            query \u003d query.filter("},{"line_number":335,"context_line":"                NetworkDhcpAgentBinding.network_id in network_ids)"},{"line_number":336,"context_line":"        if admin_state_up:"},{"line_number":337,"context_line":"            query \u003d query.filter(agents_db.Agent.admin_state_up \u003d\u003d"},{"line_number":338,"context_line":"                                 admin_state_up)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_07c89554","line":336,"in_reply_to":"fa1b9901_e5f9e44e","updated":"2015-08-18 06:45:19.000000000","message":"there is difference between False and None, here we check for None","commit_id":"3ff67ccf655526768fb1d20542d5a09462c2ad5d"}]}