)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"409726e2ee5709524e60a831bd72e37565c9c965","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add report_counters RPC for agents and integrate"},{"line_number":10,"context_line":"into linuxbridge and OVS agents."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iab09c495e9ed5990599697a5536b6f8f7bfeb73e"},{"line_number":13,"context_line":"Partial-Bug: 1475736"},{"line_number":14,"context_line":"Signed-off-by: Ryan Moats \u003crmoats@us.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"da20952f_8ace2558","line":11,"updated":"2015-09-08 00:49:14.000000000","message":"Please add DocImpact tag.","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e5bcf7f759c1344f24bb4e333023671a68e72bd8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add report_counters RPC for agents and integrate"},{"line_number":10,"context_line":"into linuxbridge and OVS agents."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iab09c495e9ed5990599697a5536b6f8f7bfeb73e"},{"line_number":13,"context_line":"Partial-Bug: 1475736"},{"line_number":14,"context_line":"Signed-off-by: Ryan Moats \u003crmoats@us.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"da20952f_a23a1f33","line":11,"in_reply_to":"da20952f_8ace2558","updated":"2015-09-08 12:15:50.000000000","message":"Done","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e82c666608a2f2756b47181a6d029821cf600fed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ryan Moats \u003crmoats@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-11 08:21:46 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce report_counters RPC for agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add report_counters RPC for agents and integrate"},{"line_number":10,"context_line":"into linuxbridge and OVS agents."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"ba8a016a_184942b7","line":7,"updated":"2015-11-19 14:01:40.000000000","message":"Can you elaborate more about the purpose of this new RPC?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"}],"doc/source/devref/instrumentation.rst":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"88f5e5cc95733f79ee13a051b58a53dec7c0e910","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  neutron metering-label-create monitor_incoming"},{"line_number":50,"context_line":"  neutron metering-label-rule-create monitor_incoming 0.0.0.0/0 --direction ingress"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"This reference implementation converts this to a pair of iptables rules"},{"line_number":53,"context_line":"that are implemented within the namespace where the router\u0027s external device"},{"line_number":54,"context_line":"lives. This means that the information collected by metering rules covers"},{"line_number":55,"context_line":"only traffic passing through that external device from the networks behind"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_0cb9082e","line":52,"updated":"2015-12-08 16:34:51.000000000","message":"So I think I understand your point that the difference is that L3 Metering Labels collect only a subset of what the proposed Instrumentation could. But I\u0027m not clear about this example (although I like the idea of using a specific example). Are you trying to describe why just implementation of this via the L3 Metering Labels would be incomplete? If so I don\u0027t understand what you are referring to when you say \"This reference implementation\".","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f0bac540f70b6ab070f8ccda563c9cf0a9c3927e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  neutron metering-label-create monitor_incoming"},{"line_number":50,"context_line":"  neutron metering-label-rule-create monitor_incoming 0.0.0.0/0 --direction ingress"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"This reference implementation converts this to a pair of iptables rules"},{"line_number":53,"context_line":"that are implemented within the namespace where the router\u0027s external device"},{"line_number":54,"context_line":"lives. This means that the information collected by metering rules covers"},{"line_number":55,"context_line":"only traffic passing through that external device from the networks behind"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_7e186bd3","line":52,"in_reply_to":"7a740942_0cb9082e","updated":"2015-12-08 17:24:48.000000000","message":"Yes, I\u0027m trying to show why this isn\u0027t good enough.\n\n\u0027m referring to the reference implementation of the metering extension - will update in the next revision.","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"88f5e5cc95733f79ee13a051b58a53dec7c0e910","unresolved":false,"context_lines":[{"line_number":314,"context_line":"#. A separate collection agent could be started on each compute/network node"},{"line_number":315,"context_line":"   to collect counters."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"Because of the number of counters being collected (for example, a cloud"},{"line_number":318,"context_line":"running legacy routing would need to collect (for each project) three"},{"line_number":319,"context_line":"counters from a network node and a tap counter for each running instance),"},{"line_number":320,"context_line":"while it would be desirable to reuse the existing L3 and ML2 agents, this"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_6cc3ec89","line":317,"updated":"2015-12-08 16:34:51.000000000","message":"Nit: break up this first sentence, it seems way too long and includes parenthesis inside parenthesis.","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f0bac540f70b6ab070f8ccda563c9cf0a9c3927e","unresolved":false,"context_lines":[{"line_number":314,"context_line":"#. A separate collection agent could be started on each compute/network node"},{"line_number":315,"context_line":"   to collect counters."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"Because of the number of counters being collected (for example, a cloud"},{"line_number":318,"context_line":"running legacy routing would need to collect (for each project) three"},{"line_number":319,"context_line":"counters from a network node and a tap counter for each running instance),"},{"line_number":320,"context_line":"while it would be desirable to reuse the existing L3 and ML2 agents, this"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_de295fe7","line":317,"in_reply_to":"7a740942_6cc3ec89","updated":"2015-12-08 17:24:48.000000000","message":"will do","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"88f5e5cc95733f79ee13a051b58a53dec7c0e910","unresolved":false,"context_lines":[{"line_number":320,"context_line":"while it would be desirable to reuse the existing L3 and ML2 agents, this"},{"line_number":321,"context_line":"proof of concept runs as a separate agent with separate collection and"},{"line_number":322,"context_line":"reporting threads. This allows the agent to only be run for testing purposes"},{"line_number":323,"context_line":"and further allows isolation the effects of counter collection from counter"},{"line_number":324,"context_line":"reporting."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The PoC\u0027s counter collection runs in a tight loop (i.e. constantly reading and"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_6c4a0c28","line":323,"updated":"2015-12-08 16:34:51.000000000","message":"Nit: Should be \"allows isolation of the effects\"","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f0bac540f70b6ab070f8ccda563c9cf0a9c3927e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"while it would be desirable to reuse the existing L3 and ML2 agents, this"},{"line_number":321,"context_line":"proof of concept runs as a separate agent with separate collection and"},{"line_number":322,"context_line":"reporting threads. This allows the agent to only be run for testing purposes"},{"line_number":323,"context_line":"and further allows isolation the effects of counter collection from counter"},{"line_number":324,"context_line":"reporting."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The PoC\u0027s counter collection runs in a tight loop (i.e. constantly reading and"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_fe245b0d","line":323,"in_reply_to":"7a740942_6c4a0c28","updated":"2015-12-08 17:24:48.000000000","message":"will do","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"88f5e5cc95733f79ee13a051b58a53dec7c0e910","unresolved":false,"context_lines":[{"line_number":321,"context_line":"proof of concept runs as a separate agent with separate collection and"},{"line_number":322,"context_line":"reporting threads. This allows the agent to only be run for testing purposes"},{"line_number":323,"context_line":"and further allows isolation the effects of counter collection from counter"},{"line_number":324,"context_line":"reporting."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The PoC\u0027s counter collection runs in a tight loop (i.e. constantly reading and"},{"line_number":327,"context_line":"updating counters) to determine cycle times and amount of server CPU used."}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_cc2f803d","line":324,"updated":"2015-12-08 16:34:51.000000000","message":"Doesn\u0027t the proposed new instrumentation agent do both the counter collection and counter reporting?  I don\u0027t understand how this isolates collection from reporting?","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f0bac540f70b6ab070f8ccda563c9cf0a9c3927e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"proof of concept runs as a separate agent with separate collection and"},{"line_number":322,"context_line":"reporting threads. This allows the agent to only be run for testing purposes"},{"line_number":323,"context_line":"and further allows isolation the effects of counter collection from counter"},{"line_number":324,"context_line":"reporting."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"The PoC\u0027s counter collection runs in a tight loop (i.e. constantly reading and"},{"line_number":327,"context_line":"updating counters) to determine cycle times and amount of server CPU used."}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_1e8287c8","line":324,"in_reply_to":"7a740942_cc2f803d","updated":"2015-12-08 17:24:48.000000000","message":"they run in separate threads, so collection can run in a tight loop and reporting only reports on the current counters.","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f0bac540f70b6ab070f8ccda563c9cf0a9c3927e","unresolved":false,"context_lines":[{"line_number":357,"context_line":"reporting traffic is deemed to be too bursty, a later version of the PoC"},{"line_number":358,"context_line":"may include a granularity configuration parameter for limiting the counters"},{"line_number":359,"context_line":"returned to only those where the counter has changed by at least the amount"},{"line_number":360,"context_line":"of the granularity configuration parameter. "},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"Even if the functionality of this PoC were to be merged back into the current"},{"line_number":363,"context_line":"L3 and ML2 agents, the counter reporting thread should be kept separate from"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a740942_de707f0d","line":360,"updated":"2015-12-08 17:24:48.000000000","message":"Sigh - note to self: red thingy","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"}],"etc/neutron.conf":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"f0ee48f95caddbad13ddd4253a3e6b6d7cfb7469","unresolved":false,"context_lines":[{"line_number":710,"context_line":"# report_interval \u003d 30"},{"line_number":711,"context_line":"#"},{"line_number":712,"context_line":"# seconds between nodes reporting counters to server"},{"line_number":713,"context_line":"# counter_report_interval \u003d 300"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent management extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":716,"context_line":""}],"source_content_type":"text/plain","patch_set":11,"id":"1a4dcd0f_4480ad8b","line":713,"updated":"2015-08-16 06:27:06.000000000","message":"I think this should be disabled by default (so maybe default value of 0)","commit_id":"fc122eadc08f18a0c0fe0defc54c89c3dc9e614a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"872ada31d84a3d2da1a21afaaf0ee7ac27787fc1","unresolved":false,"context_lines":[{"line_number":710,"context_line":"# report_interval \u003d 30"},{"line_number":711,"context_line":"#"},{"line_number":712,"context_line":"# seconds between nodes reporting counters to server"},{"line_number":713,"context_line":"# counter_report_interval \u003d 300"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  end of items for agent management extension \u003d\u003d\u003d\u003d\u003d"},{"line_number":716,"context_line":""}],"source_content_type":"text/plain","patch_set":11,"id":"1a4dcd0f_b842ee66","line":713,"in_reply_to":"1a4dcd0f_4480ad8b","updated":"2015-08-16 14:13:20.000000000","message":"Good point. Done","commit_id":"fc122eadc08f18a0c0fe0defc54c89c3dc9e614a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7af074dc973d7a381e6edf82485a24df2850462e","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":"#"},{"line_number":596,"context_line":"# (IntOpt) seconds between nodes reporting counters to server "},{"line_number":597,"context_line":"# counter_report_interval \u003d 300"},{"line_number":598,"context_line":"#"},{"line_number":599,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d end of collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/plain","patch_set":26,"id":"7a740942_d0f26e06","line":596,"updated":"2015-12-03 20:20:50.000000000","message":"nit: others use (integer value), and trailing space","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d17f2031f6babbff23295591dd13eb0533cb36d1","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":"#"},{"line_number":596,"context_line":"# (IntOpt) seconds between nodes reporting counters to server "},{"line_number":597,"context_line":"# counter_report_interval \u003d 300"},{"line_number":598,"context_line":"#"},{"line_number":599,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d end of collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/plain","patch_set":26,"id":"7a740942_bcdc26e5","line":596,"in_reply_to":"7a740942_d0f26e06","updated":"2015-12-06 21:05:32.000000000","message":"This file goes away in the rebase, so no changes being made","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7af074dc973d7a381e6edf82485a24df2850462e","unresolved":false,"context_lines":[{"line_number":594,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":"#"},{"line_number":596,"context_line":"# (IntOpt) seconds between nodes reporting counters to server "},{"line_number":597,"context_line":"# counter_report_interval \u003d 300"},{"line_number":598,"context_line":"#"},{"line_number":599,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d end of collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":600,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"7a740942_105eb6e9","line":597,"updated":"2015-12-03 20:20:50.000000000","message":"collector_report_interval ?","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d17f2031f6babbff23295591dd13eb0533cb36d1","unresolved":false,"context_lines":[{"line_number":594,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":"#"},{"line_number":596,"context_line":"# (IntOpt) seconds between nodes reporting counters to server "},{"line_number":597,"context_line":"# counter_report_interval \u003d 300"},{"line_number":598,"context_line":"#"},{"line_number":599,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d end of collector PoC items \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":600,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"7a740942_675b692f","line":597,"in_reply_to":"7a740942_105eb6e9","updated":"2015-12-06 21:05:32.000000000","message":"I like that - have changed","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"}],"neutron/agent/collection/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7af074dc973d7a381e6edf82485a24df2850462e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(CollectionAgent, self).__init__()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _collect_counters_from_device(self, namespace, device):"},{"line_number":54,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027-s\u0027, \u0027link\u0027, \u0027show\u0027, device]"},{"line_number":55,"context_line":"        lines \u003d namespace.netns.execute(cmd, run_as_root\u003dTrue).splitlines()"},{"line_number":56,"context_line":"        rx_counters \u003d lines[3].split()"},{"line_number":57,"context_line":"        tx_counters \u003d lines[5].split()"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_a25e7843","line":54,"updated":"2015-12-03 20:20:50.000000000","message":"Seems like a candidate for IpLinkCommand class - get_stats() ?","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d17f2031f6babbff23295591dd13eb0533cb36d1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(CollectionAgent, self).__init__()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _collect_counters_from_device(self, namespace, device):"},{"line_number":54,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027-s\u0027, \u0027link\u0027, \u0027show\u0027, device]"},{"line_number":55,"context_line":"        lines \u003d namespace.netns.execute(cmd, run_as_root\u003dTrue).splitlines()"},{"line_number":56,"context_line":"        rx_counters \u003d lines[3].split()"},{"line_number":57,"context_line":"        tx_counters \u003d lines[5].split()"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_677289af","line":54,"in_reply_to":"7a740942_a25e7843","updated":"2015-12-06 21:05:32.000000000","message":"will add a todo to remind myself","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7af074dc973d7a381e6edf82485a24df2850462e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                self.counters[\u0027root\u0027] \u003d {}"},{"line_number":79,"context_line":"            for dev in root_ip.get_devices():"},{"line_number":80,"context_line":"                try:"},{"line_number":81,"context_line":"                    if dev.name.startswith(\u0027tap\u0027):"},{"line_number":82,"context_line":"                        sample \u003d self._collect_counters_from_device(root_ip,"},{"line_number":83,"context_line":"                                                                    dev.name)"},{"line_number":84,"context_line":"                        self.counters[\u0027root\u0027][dev.name] \u003d sample"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_9013865c","line":81,"updated":"2015-12-03 20:20:50.000000000","message":"constants.TAP_DEVICE_PREFIX","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d17f2031f6babbff23295591dd13eb0533cb36d1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                self.counters[\u0027root\u0027] \u003d {}"},{"line_number":79,"context_line":"            for dev in root_ip.get_devices():"},{"line_number":80,"context_line":"                try:"},{"line_number":81,"context_line":"                    if dev.name.startswith(\u0027tap\u0027):"},{"line_number":82,"context_line":"                        sample \u003d self._collect_counters_from_device(root_ip,"},{"line_number":83,"context_line":"                                                                    dev.name)"},{"line_number":84,"context_line":"                        self.counters[\u0027root\u0027][dev.name] \u003d sample"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_47a66d11","line":81,"in_reply_to":"7a740942_9013865c","updated":"2015-12-06 21:05:32.000000000","message":"Done","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7af074dc973d7a381e6edf82485a24df2850462e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    self.counters[namespace] \u003d {}"},{"line_number":91,"context_line":"                try:"},{"line_number":92,"context_line":"                    ns_ip \u003d ip_lib.IPWrapper(namespace\u003dnamespace)"},{"line_number":93,"context_line":"                    for dev in ns_ip.get_devices():"},{"line_number":94,"context_line":"                        if dev.name !\u003d \u0027lo\u0027:"},{"line_number":95,"context_line":"                            self._collect_counters_from_device(ns_ip, dev.name)"},{"line_number":96,"context_line":"                            self.counters[namespace][dev.name] \u003d sample"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_e56c8a0a","line":93,"updated":"2015-12-03 20:20:50.000000000","message":".get_devices(exclude_loopback\u003dTrue) then you won\u0027t need next line","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d17f2031f6babbff23295591dd13eb0533cb36d1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    self.counters[namespace] \u003d {}"},{"line_number":91,"context_line":"                try:"},{"line_number":92,"context_line":"                    ns_ip \u003d ip_lib.IPWrapper(namespace\u003dnamespace)"},{"line_number":93,"context_line":"                    for dev in ns_ip.get_devices():"},{"line_number":94,"context_line":"                        if dev.name !\u003d \u0027lo\u0027:"},{"line_number":95,"context_line":"                            self._collect_counters_from_device(ns_ip, dev.name)"},{"line_number":96,"context_line":"                            self.counters[namespace][dev.name] \u003d sample"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a740942_67a929df","line":93,"in_reply_to":"7a740942_e56c8a0a","updated":"2015-12-06 21:05:32.000000000","message":"Done","commit_id":"ee00075a2fa0cd80baf04fee995d822e8134631e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c58f755f135ab996220160a7687c6ff5f9a71043","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _collect_counters(self):"},{"line_number":75,"context_line":"        LOG.debug(\"Entering _collect_counters\")"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            root_ip \u003d ip_lib.IPWrapper()"},{"line_number":78,"context_line":"            # collect instance tap counters from root namespace"},{"line_number":79,"context_line":"            if \u0027root\u0027 not in self.counters:"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a740942_0325405a","line":76,"updated":"2015-12-08 21:58:29.000000000","message":"nit: this is for the get_namespaces() call on L90, which wasn\u0027t obvious, perhaps it\u0027s better to get rid of the nesting and load the namespaces into a local var.","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"a11f75d0bf04509ffd40c32b62c9b48a6afca967","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _collect_counters(self):"},{"line_number":75,"context_line":"        LOG.debug(\"Entering _collect_counters\")"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            root_ip \u003d ip_lib.IPWrapper()"},{"line_number":78,"context_line":"            # collect instance tap counters from root namespace"},{"line_number":79,"context_line":"            if \u0027root\u0027 not in self.counters:"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a740942_1ce0daf9","line":76,"in_reply_to":"7a740942_0325405a","updated":"2015-12-10 14:28:33.000000000","message":"Done","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c58f755f135ab996220160a7687c6ff5f9a71043","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                        self.counters[\u0027root\u0027][dev.name] \u003d sample"},{"line_number":87,"context_line":"                except RuntimeError:"},{"line_number":88,"context_line":"                    pass"},{"line_number":89,"context_line":"            # collect couters from dhcp/router/fip/snat namespaces"},{"line_number":90,"context_line":"            for namespace in root_ip.get_namespaces():"},{"line_number":91,"context_line":"                if namespace not in self.counters:"},{"line_number":92,"context_line":"                    self.counters[namespace] \u003d {}"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a740942_ddccfb8a","line":89,"updated":"2015-12-08 21:58:29.000000000","message":"nit: s/couters/counters","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"a11f75d0bf04509ffd40c32b62c9b48a6afca967","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                        self.counters[\u0027root\u0027][dev.name] \u003d sample"},{"line_number":87,"context_line":"                except RuntimeError:"},{"line_number":88,"context_line":"                    pass"},{"line_number":89,"context_line":"            # collect couters from dhcp/router/fip/snat namespaces"},{"line_number":90,"context_line":"            for namespace in root_ip.get_namespaces():"},{"line_number":91,"context_line":"                if namespace not in self.counters:"},{"line_number":92,"context_line":"                    self.counters[namespace] \u003d {}"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a740942_dce25201","line":89,"in_reply_to":"7a740942_ddccfb8a","updated":"2015-12-10 14:28:33.000000000","message":"Done","commit_id":"92782e197cd08e03dd33b909887d30d8cf5df9d1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d8f10970bf488ee05ec7fee154a87b15a34e129","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                except RuntimeError:"},{"line_number":89,"context_line":"                    pass"},{"line_number":90,"context_line":"            # collect counters from dhcp/router/fip/snat namespaces"},{"line_number":91,"context_line":"            for namespace in root_ip.get_namespaces():"},{"line_number":92,"context_line":"                if namespace not in self.counters:"},{"line_number":93,"context_line":"                    self.counters[namespace] \u003d {}"},{"line_number":94,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a740942_84e8d67d","line":91,"updated":"2015-12-10 22:13:40.000000000","message":"I guess I was more thinking\n\ntry:\n    namespaces \u003d root_ip.get_namespaces()\nexcept RuntimeError:\n    LOG...\n    return","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ac4c9dd199029d7ac50138c856e040912d4a6274","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                except RuntimeError:"},{"line_number":89,"context_line":"                    pass"},{"line_number":90,"context_line":"            # collect counters from dhcp/router/fip/snat namespaces"},{"line_number":91,"context_line":"            for namespace in root_ip.get_namespaces():"},{"line_number":92,"context_line":"                if namespace not in self.counters:"},{"line_number":93,"context_line":"                    self.counters[namespace] \u003d {}"},{"line_number":94,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a740942_2157785b","line":91,"updated":"2015-12-11 11:24:29.000000000","message":"so you\u0027re collecting the data of all namespaces, regardless if managed by Openstack or not?","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f16d1a36f7c3da8b948f46378eac4988f125bf2c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                except RuntimeError:"},{"line_number":89,"context_line":"                    pass"},{"line_number":90,"context_line":"            # collect counters from dhcp/router/fip/snat namespaces"},{"line_number":91,"context_line":"            for namespace in root_ip.get_namespaces():"},{"line_number":92,"context_line":"                if namespace not in self.counters:"},{"line_number":93,"context_line":"                    self.counters[namespace] \u003d {}"},{"line_number":94,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a740942_d1be9ffe","line":91,"in_reply_to":"7a740942_84e8d67d","updated":"2015-12-10 22:27:27.000000000","message":"I\u0027ll keep it in mind for the next respin :)","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ac4c9dd199029d7ac50138c856e040912d4a6274","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        LOG.debug(\"Starting _collection_counters_loop\")"},{"line_number":108,"context_line":"        pool \u003d eventlet.GreenPool(size\u003d1)"},{"line_number":109,"context_line":"        while True:"},{"line_number":110,"context_line":"            pool.spawn_n(self._collect_counters)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"class CollectionAgentWithStateReport(CollectionAgent):"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a740942_47117403","line":110,"updated":"2015-12-11 11:24:29.000000000","message":"Seems like your collector runs a marathon. No sleep for a few seconds or so? I mean if you have a large collector_report_interval you might not need to collect all the time. But I must admit I have no idea of a realistic value for collector_report_interval.","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"0782a81bc6890c0e030fc3d9d3ca6d7257c7ac2f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            \u0027binary\u0027: \u0027neutron-collection-agent\u0027,"},{"line_number":138,"context_line":"            \u0027host\u0027: host,"},{"line_number":139,"context_line":"            \u0027topic\u0027: topics.COLLECTION_AGENT,"},{"line_number":140,"context_line":"            \u0027start_flag\u0027: True}"},{"line_number":141,"context_line":"        report_interval \u003d self.conf.AGENT.report_interval"},{"line_number":142,"context_line":"        if report_interval:"},{"line_number":143,"context_line":"            self.heartbeat \u003d loopingcall.FixedIntervalLoopingCall("}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_b583f4cb","line":140,"updated":"2016-02-26 08:06:45.000000000","message":"What does this attribute plan for? Seems it only been used in L155.","commit_id":"f52d4c9a20cd31f45ed3316f8b7cc552605c808a"}],"neutron/agent/common/config.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"f0ee48f95caddbad13ddd4253a3e6b6d7cfb7469","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting state to server; \u0027"},{"line_number":45,"context_line":"                        \u0027should be less than agent_down_time, best if it \u0027"},{"line_number":46,"context_line":"                        \u0027is half or less than agent_down_time.\u0027)),"},{"line_number":47,"context_line":"    cfg.FloatOpt(\u0027counter_report_interval\u0027, default\u003d300,"},{"line_number":48,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting counters to \u0027"},{"line_number":49,"context_line":"                        \u0027server.\u0027)),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027log_agent_heartbeats\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_c4427d68","line":47,"updated":"2015-08-16 06:27:06.000000000","message":"Same as previous comment, think default should be disabled here (meaning 0)","commit_id":"fc122eadc08f18a0c0fe0defc54c89c3dc9e614a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"872ada31d84a3d2da1a21afaaf0ee7ac27787fc1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting state to server; \u0027"},{"line_number":45,"context_line":"                        \u0027should be less than agent_down_time, best if it \u0027"},{"line_number":46,"context_line":"                        \u0027is half or less than agent_down_time.\u0027)),"},{"line_number":47,"context_line":"    cfg.FloatOpt(\u0027counter_report_interval\u0027, default\u003d300,"},{"line_number":48,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting counters to \u0027"},{"line_number":49,"context_line":"                        \u0027server.\u0027)),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027log_agent_heartbeats\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_d8457a6f","line":47,"in_reply_to":"1a4dcd0f_c4427d68","updated":"2015-08-16 14:13:20.000000000","message":"Done","commit_id":"fc122eadc08f18a0c0fe0defc54c89c3dc9e614a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"003b297463ee4f69972d69cf0e72fcb4af98c912","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        \u0027is half or less than agent_down_time.\u0027)),"},{"line_number":47,"context_line":"    cfg.FloatOpt(\u0027counter_report_interval\u0027, default\u003d0,"},{"line_number":48,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting counters to \u0027"},{"line_number":49,"context_line":"                        \u0027server.\u0027)),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027log_agent_heartbeats\u0027, default\u003dFalse,"},{"line_number":51,"context_line":"                help\u003d_(\u0027Log agent heartbeats\u0027)),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_f4e75faa","line":49,"updated":"2015-08-17 22:05:38.000000000","message":"pedantry: specify that this can be set to 0 for disabling counter reporting","commit_id":"eb4e63d3ec3eae4bc23937064759edea40646701"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"039a1f37348c5195164a13db1ec24d758e513e25","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        \u0027is half or less than agent_down_time.\u0027)),"},{"line_number":47,"context_line":"    cfg.FloatOpt(\u0027counter_report_interval\u0027, default\u003d0,"},{"line_number":48,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting counters to \u0027"},{"line_number":49,"context_line":"                        \u0027server.\u0027)),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027log_agent_heartbeats\u0027, default\u003dFalse,"},{"line_number":51,"context_line":"                help\u003d_(\u0027Log agent heartbeats\u0027)),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_ea5dd747","line":49,"in_reply_to":"fa1b9901_f4e75faa","updated":"2015-09-05 17:53:13.000000000","message":"Done","commit_id":"eb4e63d3ec3eae4bc23937064759edea40646701"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d377da86b2d744b6dc31415f376a71283c1fc763","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting state to server; \u0027"},{"line_number":45,"context_line":"                        \u0027should be less than agent_down_time, best if it \u0027"},{"line_number":46,"context_line":"                        \u0027is half or less than agent_down_time.\u0027)),"},{"line_number":47,"context_line":"    cfg.FloatOpt(\u0027counter_report_interval\u0027, default\u003d0,"},{"line_number":48,"context_line":"                 help\u003d_(\u0027Seconds between nodes reporting counters to \u0027"},{"line_number":49,"context_line":"                        \u0027server. Set to 0 to disable counter reporting.\u0027)),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027log_agent_heartbeats\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba8a016a_42803bf5","line":47,"updated":"2015-11-19 13:30:59.000000000","message":"why does this need to be float?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"}],"neutron/agent/rpc.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2cdb4ee1d4a78b274fe59cc664ef362091db65ab","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        method \u003d cctxt.call if use_call else cctxt.cast"},{"line_number":90,"context_line":"        return method(context, \u0027report_state\u0027, **kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def report_counters(self, context, counters, use_call\u003dFalse):"},{"line_number":93,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":94,"context_line":"        # add unique identifier to a report"},{"line_number":95,"context_line":"        # that can be logged on server side."}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_c6f3e871","line":92,"updated":"2015-09-06 04:10:02.000000000","message":"this kind of report needs \u0027use_call\u0027?","commit_id":"8375d406911f2cce6eb63fae14ec9d1edf3b4d76"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"712fedbd745c8c02e78b8a2a2bccf09ad56d7078","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        method \u003d cctxt.call if use_call else cctxt.cast"},{"line_number":90,"context_line":"        return method(context, \u0027report_state\u0027, **kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def report_counters(self, context, counters, use_call\u003dFalse):"},{"line_number":93,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":94,"context_line":"        # add unique identifier to a report"},{"line_number":95,"context_line":"        # that can be logged on server side."}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_33f0cc66","line":92,"in_reply_to":"da20952f_c6f3e871","updated":"2015-09-07 11:53:17.000000000","message":"good point - it should default to True - so changed","commit_id":"8375d406911f2cce6eb63fae14ec9d1edf3b4d76"}],"neutron/db/agents_db.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"b228ffb2efe124454b83746a55588ceabc11dedf","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    def report_counters(self, context, **kwargs):"},{"line_number":430,"context_line":"        time \u003d kwargs[\u0027time\u0027]"},{"line_number":431,"context_line":"        counters \u003d kwargs[\u0027counters\u0027]"},{"line_number":432,"context_line":"        LOG.debug(\"received counters (%d bytes) - throwing on floor\", "},{"line_number":433,"context_line":"                  len(str(counters)))"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a740942_66e580da","line":432,"updated":"2015-12-07 17:57:45.000000000","message":"oh ugh, red thingy :(","commit_id":"256fa862e8e4f6412688c00240edb033c403c1f6"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"003b297463ee4f69972d69cf0e72fcb4af98c912","unresolved":false,"context_lines":[{"line_number":852,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":853,"context_line":"                                           self.counters,"},{"line_number":854,"context_line":"                                           self.use_counter_call)"},{"line_number":855,"context_line":"            self.use_counter_call \u003d False"},{"line_number":856,"context_line":"        except Exception:"},{"line_number":857,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":858,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_d46a5b1a","line":855,"updated":"2015-08-17 22:05:38.000000000","message":"why are you choosing to always do a cast?","commit_id":"eb4e63d3ec3eae4bc23937064759edea40646701"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"039a1f37348c5195164a13db1ec24d758e513e25","unresolved":false,"context_lines":[{"line_number":852,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":853,"context_line":"                                           self.counters,"},{"line_number":854,"context_line":"                                           self.use_counter_call)"},{"line_number":855,"context_line":"            self.use_counter_call \u003d False"},{"line_number":856,"context_line":"        except Exception:"},{"line_number":857,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":858,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa1b9901_4d289d86","line":855,"in_reply_to":"fa1b9901_d46a5b1a","updated":"2015-09-05 17:53:13.000000000","message":"good point","commit_id":"eb4e63d3ec3eae4bc23937064759edea40646701"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f4512c4ff480d6eb4909c8f42b770b0b11d09752","unresolved":false,"context_lines":[{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":903,"context_line":"                                           self.counters,"},{"line_number":904,"context_line":"                                           self.use_counter_call)"},{"line_number":905,"context_line":"        except Exception:"},{"line_number":906,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_016bf7b7","line":904,"updated":"2015-09-07 08:07:36.000000000","message":"where are the definition and initialization of use_counter_call?","commit_id":"8375d406911f2cce6eb63fae14ec9d1edf3b4d76"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"712fedbd745c8c02e78b8a2a2bccf09ad56d7078","unresolved":false,"context_lines":[{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":903,"context_line":"                                           self.counters,"},{"line_number":904,"context_line":"                                           self.use_counter_call)"},{"line_number":905,"context_line":"        except Exception:"},{"line_number":906,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_364f5a6c","line":904,"in_reply_to":"da20952f_016bf7b7","updated":"2015-09-07 11:53:17.000000000","message":"good catch - so added","commit_id":"8375d406911f2cce6eb63fae14ec9d1edf3b4d76"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"409726e2ee5709524e60a831bd72e37565c9c965","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                self._report_state)"},{"line_number":943,"context_line":"            heartbeat.start(interval\u003dreport_interval)"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        counterReport_interval \u003d cfg.CONF.AGENT.counter_report_interval"},{"line_number":946,"context_line":"        if counterReport_interval:"},{"line_number":947,"context_line":"            counterReporter \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":948,"context_line":"                self._report_counters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_0ae215d5","line":945,"updated":"2015-09-08 00:49:14.000000000","message":"The variable name includes camel and snake. Please integrate with snake.","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e5bcf7f759c1344f24bb4e333023671a68e72bd8","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                self._report_state)"},{"line_number":943,"context_line":"            heartbeat.start(interval\u003dreport_interval)"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        counterReport_interval \u003d cfg.CONF.AGENT.counter_report_interval"},{"line_number":946,"context_line":"        if counterReport_interval:"},{"line_number":947,"context_line":"            counterReporter \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":948,"context_line":"                self._report_counters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_0202eb72","line":945,"in_reply_to":"da20952f_0ae215d5","updated":"2015-09-08 12:15:50.000000000","message":"Done","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d377da86b2d744b6dc31415f376a71283c1fc763","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        try:"},{"line_number":903,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":904,"context_line":"                                           self.counters,"},{"line_number":905,"context_line":"                                           self.use_counter_call)"},{"line_number":906,"context_line":"        except Exception:"},{"line_number":907,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":908,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba8a016a_e20a8f89","line":905,"updated":"2015-11-19 13:30:59.000000000","message":"why is this a call and not a cast?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"409726e2ee5709524e60a831bd72e37565c9c965","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                self._report_state)"},{"line_number":286,"context_line":"            heartbeat.start(interval\u003dreport_interval)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        counterReport_interval \u003d self.conf.AGENT.counter_report_interval"},{"line_number":289,"context_line":"        if counterReport_interval:"},{"line_number":290,"context_line":"            counterReporter \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":291,"context_line":"                self._report_counters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_6ad39104","line":288,"updated":"2015-09-08 00:49:14.000000000","message":"The variable name includes camel and snake. Please integrate with snake.","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e5bcf7f759c1344f24bb4e333023671a68e72bd8","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                self._report_state)"},{"line_number":286,"context_line":"            heartbeat.start(interval\u003dreport_interval)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        counterReport_interval \u003d self.conf.AGENT.counter_report_interval"},{"line_number":289,"context_line":"        if counterReport_interval:"},{"line_number":290,"context_line":"            counterReporter \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":291,"context_line":"                self._report_counters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_82f6fb8e","line":288,"in_reply_to":"da20952f_6ad39104","updated":"2015-09-08 12:15:50.000000000","message":"Done","commit_id":"2a58734ebbed39ecda103f3129fda5b981b2df4d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c2496828b760a0e941a3d6c22bb275ffd1cb3f2","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        except Exception:"},{"line_number":337,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def _report_counters(self):"},{"line_number":340,"context_line":"        self.counters \u003d {}"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            self.state_rpc.report_counters(self.context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_585c807c","line":339,"updated":"2015-09-18 02:51:41.000000000","message":"We have too many knobs that need tweaking to get a scalable deployment of these agents already. I would really like to avoid another one. How large are these counters and what is the justification for a different cycle than the state message?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"891ec85babad050c7e7af76237f57bc1eca98228","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        except Exception:"},{"line_number":337,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def _report_counters(self):"},{"line_number":340,"context_line":"        self.counters \u003d {}"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            self.state_rpc.report_counters(self.context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_7fd95521","line":339,"updated":"2015-09-17 09:55:03.000000000","message":"why do you want to introduce another periodic calls rather than stashing it into the existing one?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"1b0c9580dd1268bef49fad1b6b8203f9f6c6722e","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        except Exception:"},{"line_number":337,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def _report_counters(self):"},{"line_number":340,"context_line":"        self.counters \u003d {}"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            self.state_rpc.report_counters(self.context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_3c066e52","line":339,"in_reply_to":"ba15a1d1_7fd95521","updated":"2015-09-17 17:31:56.000000000","message":"Because I want to be able to run it on a different cycle than the state message","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"891ec85babad050c7e7af76237f57bc1eca98228","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def _report_counters(self):"},{"line_number":340,"context_line":"        self.counters \u003d {}"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":343,"context_line":"                                           self.counters,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_1fb379ea","line":340,"updated":"2015-09-17 09:55:03.000000000","message":"empty?","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"1b0c9580dd1268bef49fad1b6b8203f9f6c6722e","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def _report_counters(self):"},{"line_number":340,"context_line":"        self.counters \u003d {}"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":343,"context_line":"                                           self.counters,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_7c9e2608","line":340,"in_reply_to":"ba15a1d1_1fb379ea","updated":"2015-09-17 17:31:56.000000000","message":"yes, for this patch set it is empty - the next patch set will fill it in","commit_id":"de462da3dbb4eda57ae5bad5a07bbbd480009726"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"42eb759839141fa54094f2a501978bc853f79252","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        try:"},{"line_number":358,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":359,"context_line":"                                           self.counters,"},{"line_number":360,"context_line":"                                           self.use_counter_call)"},{"line_number":361,"context_line":"        except Exception:"},{"line_number":362,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_70e77711","line":360,"updated":"2015-11-26 16:29:24.000000000","message":"where is self.use_couner_call initialized?","commit_id":"4a4f3b51a93c5aa0de7503cd3aeae051eeada0f6"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c6e9c92704533479473c5a2d497f0eefed14198c","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        try:"},{"line_number":358,"context_line":"            self.state_rpc.report_counters(self.context,"},{"line_number":359,"context_line":"                                           self.counters,"},{"line_number":360,"context_line":"                                           self.use_counter_call)"},{"line_number":361,"context_line":"        except Exception:"},{"line_number":362,"context_line":"            LOG.exception(_LE(\"Failed reporting counters!\"))"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_d7529534","line":360,"in_reply_to":"9a8ffd7b_70e77711","updated":"2015-11-29 01:41:26.000000000","message":"This method (and the one under the linuxbridge driver will be removed in the next draft","commit_id":"4a4f3b51a93c5aa0de7503cd3aeae051eeada0f6"}],"neutron/tests/unit/agent/collection/test_agent.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"1c60716caa7d4171a6d8ad7a0c7987fac58df0ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            time.sleep(self.conf.collector_report_interval)"},{"line_number":51,"context_line":"            report_counters.assert_called_once_with(agent.context,"},{"line_number":52,"context_line":"                                                    agent.counters,"},{"line_number":53,"context_line":"                                                    True)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a710552_844905d3","line":53,"updated":"2015-12-15 03:00:35.000000000","message":"Should probably have additional unit tests that directly test the collection functions _collect_counters_from_device() and _collect_counters(), verifying that they gather and structure the collection data correctly","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"}],"neutron/tests/unit/agent/test_rpc.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"1c60716caa7d4171a6d8ad7a0c7987fac58df0ed","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                                           use_call\u003dFalse)"},{"line_number":155,"context_line":"            self.assertEqual(mock_cast.call_args[0][0], ctxt)"},{"line_number":156,"context_line":"            self.assertEqual(mock_cast.call_args[0][1], \u0027report_counters\u0027)"},{"line_number":157,"context_line":"            self.assertEqual(mock_cast.call_args[0][1], \u0027report_counters\u0027)"},{"line_number":158,"context_line":"            self.assertEqual(mock_cast.call_args[1][\u0027counters\u0027],"},{"line_number":159,"context_line":"                             {\u0027counters\u0027: expected_agent_counters})"},{"line_number":160,"context_line":"            self.assertIsInstance(mock_cast.call_args[1][\u0027time\u0027], str)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a710552_4479ddfb","line":157,"updated":"2015-12-15 03:00:35.000000000","message":"Duplicate lines above, probably only need one :-)","commit_id":"96e88db18dea73ee74fb2a7a02c74292f2edc416"}]}
