)]}'
{"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae8b1cb0ee23a1b138899df03bada26748841f48","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":146,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":147,"context_line":"    def get_policy_bandwidth_limit_rules(self, context, policy_id,"},{"line_number":148,"context_line":"                                         filters\u003d{}, fields\u003dNone,"},{"line_number":149,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":150,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":151,"context_line":"        # make sure we have access to the policy when fetching rules"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7fab001e","line":148,"updated":"2015-08-18 16:26:22.000000000","message":"filters\u003dNone and then below","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d78d7d8aaf0cc4f7fcf0372a5679fd629544a3e4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":146,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":147,"context_line":"    def get_policy_bandwidth_limit_rules(self, context, policy_id,"},{"line_number":148,"context_line":"                                         filters\u003d{}, fields\u003dNone,"},{"line_number":149,"context_line":"                                         sorts\u003dNone, limit\u003dNone,"},{"line_number":150,"context_line":"                                         marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":151,"context_line":"        # make sure we have access to the policy when fetching rules"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_dfd00156","line":148,"in_reply_to":"fa1b9901_7fab001e","updated":"2015-08-18 20:43:17.000000000","message":"Done","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae8b1cb0ee23a1b138899df03bada26748841f48","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":156,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":157,"context_line":"                                                                 **filters)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_9ff8544b","line":155,"updated":"2015-08-18 16:26:22.000000000","message":"should be:\n\n filters \u003d filters or dict()","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d78d7d8aaf0cc4f7fcf0372a5679fd629544a3e4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":156,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":157,"context_line":"                                                                 **filters)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_bfcd0db9","line":155,"in_reply_to":"fa1b9901_9ff8544b","updated":"2015-08-18 20:43:17.000000000","message":"Done","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"faa9cefa96bd10507cf7efd2d7ce9613638d8881","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters \u003d filters or dict()"},{"line_number":156,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":157,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":158,"context_line":"                                                                 **filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_0b9c1868","line":155,"updated":"2015-08-24 09:00:12.000000000","message":"they say a {} literal is a tiny fraction quicker, but I don\u0027t care.","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f8d7fb8da822936f19fa2c4f458da7c41f30493e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters \u003d filters or dict()"},{"line_number":156,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":157,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":158,"context_line":"                                                                 **filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_fa472c49","line":155,"in_reply_to":"fa1b9901_0b9c1868","updated":"2015-08-24 10:56:31.000000000","message":"Whoa! Indeed, I though it\u0027s just a syntax sugar \u003d-O:\n\n In [2]: timeit.timeit(\"mydict \u003d {}\", number\u003d10000000)\n Out[2]: 0.4090290069580078\n\n In [3]: timeit.timeit(\"mydict \u003d dict()\", number\u003d10000000)\n Out[3]: 1.1846280097961426\n\nIt was actually me who provided suggestion with dict() :(","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d47127b94e1390bc1827027fb4d714978f004ba1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters \u003d filters or dict()"},{"line_number":156,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":157,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":158,"context_line":"                                                                 **filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_f6c4eb92","line":155,"in_reply_to":"fa1b9901_abd161fd","updated":"2015-08-25 13:46:06.000000000","message":"yeah, as @sam said :)","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"},{"author":{"_account_id":5319,"name":"Sam Stoelinga","email":"sammiestoel@gmail.com","username":"sammiestoel"},"change_message_id":"d66c79c7810dc273380c741a5deffacae6e8f36d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters \u003d filters or dict()"},{"line_number":156,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":157,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":158,"context_line":"                                                                 **filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_abd161fd","line":155,"in_reply_to":"fa1b9901_fa472c49","updated":"2015-08-24 13:07:59.000000000","message":"As long as there is no coding style for dictating {} over dict() i also dont think we should care about this at all.\n\nThe time difference between {} and dict() is insignificant in this case if you compare it with the time spent on the db lookup.\n\nNonetheless it\u0027s fun to know :)","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d47127b94e1390bc1827027fb4d714978f004ba1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":153,"context_line":"            # first, validate that we have access to the policy"},{"line_number":154,"context_line":"            self._get_policy_obj(context, policy_id)"},{"line_number":155,"context_line":"            filters \u003d filters or dict()"},{"line_number":156,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":157,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":158,"context_line":"                                                                 **filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_36ca63a2","line":155,"in_reply_to":"fa1b9901_fa472c49","updated":"2015-08-25 13:46:06.000000000","message":"well, it\u0027s slower, but within the context of an API request, with DB backend, it\u0027s absolutely nothing :)","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"}],"neutron/tests/api/test_qos.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"dfb84148fb0157c4cdd6cf5ca300fd2a0b89c8b5","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    @test.idempotent_id(\u0027ce0bd0c2-54d9-4e29-85f1-cfb36ac3ebe2\u0027)"},{"line_number":406,"context_line":"    def test_get_rules_by_policy(self):"},{"line_number":407,"context_line":"        policy1 \u003d self.create_qos_policy(name\u003d\u0027test-policy1\u0027,"},{"line_number":408,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":409,"context_line":"                                        shared\u003dFalse)"},{"line_number":410,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy1[\u0027id\u0027],"},{"line_number":411,"context_line":"                                                    max_kbps\u003d200,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_6dc3fa89","line":408,"updated":"2015-08-20 08:19:46.000000000","message":"Conventions dictate that such arguments (description and shared) should start right below \u0027name\u0027. In other words, push an extra space before these 2 parameters.\n\nSame apply 4 more times until the end of the test code.","commit_id":"6867640facdb713aabfcdddb671a423b0876a0a8"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"82c86cbdf3ce2e34d84cfab0db5705642c58167c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    @test.idempotent_id(\u0027ce0bd0c2-54d9-4e29-85f1-cfb36ac3ebe2\u0027)"},{"line_number":406,"context_line":"    def test_get_rules_by_policy(self):"},{"line_number":407,"context_line":"        policy1 \u003d self.create_qos_policy(name\u003d\u0027test-policy1\u0027,"},{"line_number":408,"context_line":"                                        description\u003d\u0027test policy1\u0027,"},{"line_number":409,"context_line":"                                        shared\u003dFalse)"},{"line_number":410,"context_line":"        rule1 \u003d self.create_qos_bandwidth_limit_rule(policy_id\u003dpolicy1[\u0027id\u0027],"},{"line_number":411,"context_line":"                                                    max_kbps\u003d200,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_0d47debc","line":408,"in_reply_to":"fa1b9901_6dc3fa89","updated":"2015-08-20 08:28:10.000000000","message":"Done","commit_id":"6867640facdb713aabfcdddb671a423b0876a0a8"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae8b1cb0ee23a1b138899df03bada26748841f48","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_get_policy_bandwidth_limit_rules_for_policy(self):"},{"line_number":115,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_by_id\u0027,"},{"line_number":116,"context_line":"                        return_value\u003dself.policy):"},{"line_number":117,"context_line":"                with mock.patch(\u0027neutron.objects.qos.rule.\u0027"},{"line_number":118,"context_line":"                                \u0027QosBandwidthLimitRule.\u0027"},{"line_number":119,"context_line":"                                \u0027get_objects\u0027) as get_object_mock:"},{"line_number":120,"context_line":"                    self.qos_plugin.get_policy_bandwidth_limit_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3f4b4889","line":117,"updated":"2015-08-18 16:26:22.000000000","message":"I wonder why our pep8 job doesn\u0027t fail here because of indentation ...","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d78d7d8aaf0cc4f7fcf0372a5679fd629544a3e4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_get_policy_bandwidth_limit_rules_for_policy(self):"},{"line_number":115,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_by_id\u0027,"},{"line_number":116,"context_line":"                        return_value\u003dself.policy):"},{"line_number":117,"context_line":"                with mock.patch(\u0027neutron.objects.qos.rule.\u0027"},{"line_number":118,"context_line":"                                \u0027QosBandwidthLimitRule.\u0027"},{"line_number":119,"context_line":"                                \u0027get_objects\u0027) as get_object_mock:"},{"line_number":120,"context_line":"                    self.qos_plugin.get_policy_bandwidth_limit_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7fc6954a","line":117,"in_reply_to":"fa1b9901_3f4b4889","updated":"2015-08-18 20:43:17.000000000","message":"Done","commit_id":"4dad968c907d16c907bd8f4b2380807b9974e10e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3d5e72adcdf30e77a20b614364a879a797c4edf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                self.qos_plugin.get_policy_bandwidth_limit_rules("},{"line_number":121,"context_line":"                    self.ctxt, self.policy.id)"},{"line_number":122,"context_line":"                get_object_mock.assert_called_once_with("},{"line_number":123,"context_line":"                    self.ctxt, qos_policy_id\u003dself.policy.id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_policy_for_nonexistent_policy(self):"},{"line_number":126,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_by_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_1cc2ae34","line":123,"updated":"2015-08-20 10:12:07.000000000","message":"We should also add test that validates if we define filters then they are passed properly.","commit_id":"b9630cc49a72b21df1ab705f9493f9387f1e081e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f3711cf9118c169fb0169e78d76bf9975821998d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                self.qos_plugin.get_policy_bandwidth_limit_rules("},{"line_number":121,"context_line":"                    self.ctxt, self.policy.id)"},{"line_number":122,"context_line":"                get_object_mock.assert_called_once_with("},{"line_number":123,"context_line":"                    self.ctxt, qos_policy_id\u003dself.policy.id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_policy_for_nonexistent_policy(self):"},{"line_number":126,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_by_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_fa0c97ed","line":123,"in_reply_to":"fa1b9901_1cc2ae34","updated":"2015-08-20 11:53:34.000000000","message":"Done","commit_id":"b9630cc49a72b21df1ab705f9493f9387f1e081e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"faa9cefa96bd10507cf7efd2d7ce9613638d8881","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                        return_value\u003dself.policy):"},{"line_number":117,"context_line":"            with mock.patch(\u0027neutron.objects.qos.rule.\u0027"},{"line_number":118,"context_line":"                            \u0027QosBandwidthLimitRule.\u0027"},{"line_number":119,"context_line":"                            \u0027get_objects\u0027) as get_object_mock:"},{"line_number":120,"context_line":"                self.qos_plugin.get_policy_bandwidth_limit_rules("},{"line_number":121,"context_line":"                    self.ctxt, self.policy.id)"},{"line_number":122,"context_line":"                get_object_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_eb752432","line":119,"updated":"2015-08-24 09:00:12.000000000","message":"I would name it \u0027gate_objects_mock\u0027.","commit_id":"6063e70927ed436772c602ce0cf26d5d24486fbd"}]}
