)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5ec6b48b68393b07639ff858645bc6b5ca6c91d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The L3 agent was determined when create or update port."},{"line_number":10,"context_line":"So notify the specific agent rather than notify all agents."},{"line_number":11,"context_line":"This will save some RPC resources."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I40aa9d9492e582168f4e9e57a138791946c89f8a"},{"line_number":14,"context_line":"Close-Bug: #1486795"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_7df686fa","line":11,"updated":"2015-10-05 10:53:07.000000000","message":"not only RPC, main thing is that it should significantly decrease server load at scale","commit_id":"0e1055ab25b760162c6adc8d8e49c842ca4b0f58"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7d95461b1c1a496d2eb76ac4a8d55c8e462a331a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                router_dict \u003d self.get_router(context, router_id)"},{"line_number":123,"context_line":"                if router_dict.get(\u0027distributed\u0027, False):"},{"line_number":124,"context_line":"                    payload \u003d {\u0027subnet_id\u0027: subnet}"},{"line_number":125,"context_line":"                    payload.update({\"agent\": agent}) if agent else payload"},{"line_number":126,"context_line":"                    self.l3_rpc_notifier.routers_updated("},{"line_number":127,"context_line":"                        context, [router_id], None, payload)"},{"line_number":128,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ad5e8b43","line":125,"updated":"2015-09-14 05:33:06.000000000","message":"\"else payload\" doesn\u0027t make any sense here, and this line is not good to maintain.","commit_id":"0e1055ab25b760162c6adc8d8e49c842ca4b0f58"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"67578c4d8be84607985c35b94932ad86670d74fd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                router_dict \u003d self.get_router(context, router_id)"},{"line_number":123,"context_line":"                if router_dict.get(\u0027distributed\u0027, False):"},{"line_number":124,"context_line":"                    payload \u003d {\u0027subnet_id\u0027: subnet}"},{"line_number":125,"context_line":"                    payload.update({\"agent\": agent}) if agent else payload"},{"line_number":126,"context_line":"                    self.l3_rpc_notifier.routers_updated("},{"line_number":127,"context_line":"                        context, [router_id], None, payload)"},{"line_number":128,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_31240dae","line":125,"in_reply_to":"ba15a1d1_ad5e8b43","updated":"2015-09-21 01:55:46.000000000","message":"yes. here, we do not want to change the payload if agent conditions is not satisfied.\n\nwhat is your suggestion, as follow?\n\n\t\tif router_dict.get(\u0027distributed\u0027, False):\t\n\t\t\tpayload \u003d {\u0027subnet_id\u0027: subnet}\n\t\t\tif agent:\n\t\t\t\tpayload.update({\"agent\": agent})","commit_id":"0e1055ab25b760162c6adc8d8e49c842ca4b0f58"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"79013041a801a91a41f8464513c8a26d54f32f4a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    payload \u003d {\u0027subnet_id\u0027: subnet}"},{"line_number":125,"context_line":"                    payload.update({\"agent\": agent}) if agent else payload"},{"line_number":126,"context_line":"                    self.l3_rpc_notifier.routers_updated("},{"line_number":127,"context_line":"                        context, [router_id], None, payload)"},{"line_number":128,"context_line":"                    break"},{"line_number":129,"context_line":"            LOG.debug(\u0027DVR: dvr_update_router_addvm %s \u0027, router_id)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1d142a42","line":127,"updated":"2015-10-05 10:48:57.000000000","message":"payload is not used in l3_rpc_notifier.routers_updated(), so..","commit_id":"0e1055ab25b760162c6adc8d8e49c842ca4b0f58"}]}