)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to add similar testing with ports belonging to network with set qos"},{"line_number":11,"context_line":"policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint ml2-qos"},{"line_number":14,"context_line":"Change-Id: Iebe9b3e9d612d3533381a8cf4d0b9c587f8fda42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da20952f_56e41cab","line":13,"updated":"2015-09-01 20:44:12.000000000","message":"That blueprint has since been marked as completed, so you can and should remove this line.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to add similar testing with ports belonging to network with set qos"},{"line_number":11,"context_line":"policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint ml2-qos"},{"line_number":14,"context_line":"Change-Id: Iebe9b3e9d612d3533381a8cf4d0b9c587f8fda42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da20952f_122219ba","line":13,"in_reply_to":"da20952f_56e41cab","updated":"2015-09-02 09:50:27.000000000","message":"Hmm, weird we mark blueprints as complete without basic tests...","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"}],"neutron/tests/fullstack/resources/client.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ec9f102a2ab005e4fe7752060918e8a53a2438ce","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return self._create_resource(resource_type, spec)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def create_port(self, tenant_id, network_id, hostname, qos_policy_id\u003dNone):"},{"line_number":81,"context_line":"        body \u003d {"},{"line_number":82,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":83,"context_line":"            \u0027tenant_id\u0027: tenant_id,"},{"line_number":84,"context_line":"            \u0027binding:host_id\u0027: hostname,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_77f743d3","line":81,"updated":"2015-08-26 09:20:15.000000000","message":"i would prefer we use spec instead of body for consistency ... it also avoids ambiguity between request/response bodies","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2950186d939c8053397e15201be33763e7dac820","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return self._create_resource(resource_type, spec)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def create_port(self, tenant_id, network_id, hostname, qos_policy_id\u003dNone):"},{"line_number":81,"context_line":"        body \u003d {"},{"line_number":82,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":83,"context_line":"            \u0027tenant_id\u0027: tenant_id,"},{"line_number":84,"context_line":"            \u0027binding:host_id\u0027: hostname,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_9240e560","line":81,"in_reply_to":"fa1b9901_77f743d3","updated":"2015-08-26 09:48:33.000000000","message":"Done","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ec9f102a2ab005e4fe7752060918e8a53a2438ce","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.addCleanup(_safe_method(self.client.remove_interface_router),"},{"line_number":94,"context_line":"                        router\u003drouter_id, body\u003dbody)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_qos_policy(self, tenant_id, name, description, shared):"},{"line_number":97,"context_line":"        policy \u003d self.client.create_qos_policy("},{"line_number":98,"context_line":"            body\u003d{\u0027policy\u0027: {\u0027name\u0027: name,"},{"line_number":99,"context_line":"                             \u0027description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b7cb9ba3","line":96,"updated":"2015-08-26 09:20:15.000000000","message":"should we update _create_resource to allow something:\n\n  def create_qos_policy(...):\n   spec \u003d {...}\n   return self._create_resource(\u0027qos_policy\u0027, spec, resource_key\u003d\u0027policy\u0027)","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2950186d939c8053397e15201be33763e7dac820","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.addCleanup(_safe_method(self.client.remove_interface_router),"},{"line_number":94,"context_line":"                        router\u003drouter_id, body\u003dbody)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_qos_policy(self, tenant_id, name, description, shared):"},{"line_number":97,"context_line":"        policy \u003d self.client.create_qos_policy("},{"line_number":98,"context_line":"            body\u003d{\u0027policy\u0027: {\u0027name\u0027: name,"},{"line_number":99,"context_line":"                             \u0027description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_34054679","line":96,"in_reply_to":"fa1b9901_b7cb9ba3","updated":"2015-08-26 09:48:33.000000000","message":"Not sure it\u0027s worth it, it will just make _create_resource more complex. My plan is to provide a method that detaches policy from port in case it\u0027s attached and pass this method to cleanup (TODO from L102).","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        rule \u003d self.client.create_bandwidth_limit_rule("},{"line_number":127,"context_line":"            policy\u003dqos_policy_id,"},{"line_number":128,"context_line":"            body\u003d{\u0027bandwidth_limit_rule\u0027: rule})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.addCleanup(_safe_method(self.client.delete_bandwidth_limit_rule),"},{"line_number":131,"context_line":"                        rule[\u0027bandwidth_limit_rule\u0027][\u0027id\u0027],"},{"line_number":132,"context_line":"                        qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_461b6173","line":129,"updated":"2015-08-31 11:53:16.000000000","message":"(No action needed): _safe_method should be renamed to _sefe_delete... :(","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d8be065793137727e60874085e0f56ec855c54c9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ports_with_policy \u003d self.client.list_ports("},{"line_number":106,"context_line":"                qos_policy_id\u003dqos_policy_id)[\u0027ports\u0027]"},{"line_number":107,"context_line":"            for port in ports_with_policy:"},{"line_number":108,"context_line":"                self.client.update_port("},{"line_number":109,"context_line":"                    port[\u0027id\u0027],"},{"line_number":110,"context_line":"                    body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":111,"context_line":"            self.client.delete_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_ce066885","line":108,"updated":"2015-09-01 13:22:47.000000000","message":"what if an update_port fails? It seems safer to do the following?\n\n qos_policy_id \u003d policy[\u0027policy\u0027][\u0027id\u0027]\n def detach_policy():\n    ...\n self.addCleanup(self.client.delete_qos_policy, qos_policy_id)\n self.addCleanup(detach_policy, qos_policy_id)","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ports_with_policy \u003d self.client.list_ports("},{"line_number":106,"context_line":"                qos_policy_id\u003dqos_policy_id)[\u0027ports\u0027]"},{"line_number":107,"context_line":"            for port in ports_with_policy:"},{"line_number":108,"context_line":"                self.client.update_port("},{"line_number":109,"context_line":"                    port[\u0027id\u0027],"},{"line_number":110,"context_line":"                    body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":111,"context_line":"            self.client.delete_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_367de8e7","line":108,"in_reply_to":"da20952f_3f45cfb2","updated":"2015-09-01 20:44:12.000000000","message":"+1 to everything Jakub said.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"feb7bcf1af60c434641dc42170eb71264a8090ca","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ports_with_policy \u003d self.client.list_ports("},{"line_number":106,"context_line":"                qos_policy_id\u003dqos_policy_id)[\u0027ports\u0027]"},{"line_number":107,"context_line":"            for port in ports_with_policy:"},{"line_number":108,"context_line":"                self.client.update_port("},{"line_number":109,"context_line":"                    port[\u0027id\u0027],"},{"line_number":110,"context_line":"                    body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":111,"context_line":"            self.client.delete_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_3f45cfb2","line":108,"in_reply_to":"da20952f_4957b257","updated":"2015-09-01 14:34:02.000000000","message":"Tests control the flow of things happening and they don\u0027t share resources as there is an environment per test running in the same process (no parallelism). I don\u0027t think it\u0027s wise to try to workaround this \"what if someone took my resource\" because that\u0027s a fatal error in test scenario that shouldn\u0027t happen in deterministic test.\n\nAnd if that happens, failure of test is a correct thing to happen and let programmer know something went wrong.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0190b1361aea8461a7a36adebc961854e84531d3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ports_with_policy \u003d self.client.list_ports("},{"line_number":106,"context_line":"                qos_policy_id\u003dqos_policy_id)[\u0027ports\u0027]"},{"line_number":107,"context_line":"            for port in ports_with_policy:"},{"line_number":108,"context_line":"                self.client.update_port("},{"line_number":109,"context_line":"                    port[\u0027id\u0027],"},{"line_number":110,"context_line":"                    body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":111,"context_line":"            self.client.delete_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_4957b257","line":108,"in_reply_to":"da20952f_a9e8ceb3","updated":"2015-09-01 13:38:08.000000000","message":"typically what if a port is deleted between list_port and update_port?","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ad7a8f2a20a451a8fcef517d074cbfc6bd425e4f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ports_with_policy \u003d self.client.list_ports("},{"line_number":106,"context_line":"                qos_policy_id\u003dqos_policy_id)[\u0027ports\u0027]"},{"line_number":107,"context_line":"            for port in ports_with_policy:"},{"line_number":108,"context_line":"                self.client.update_port("},{"line_number":109,"context_line":"                    port[\u0027id\u0027],"},{"line_number":110,"context_line":"                    body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":111,"context_line":"            self.client.delete_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_a9e8ceb3","line":108,"in_reply_to":"da20952f_ce066885","updated":"2015-09-01 13:36:04.000000000","message":"If we fail in detaching qos_policy then we will fail in delete_qos_policy() too so there is no reason to call it separately because delete is a dependency.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"}],"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            \u0027ml2\u0027: {"},{"line_number":167,"context_line":"                \u0027tenant_network_types\u0027: tenant_network_types,"},{"line_number":168,"context_line":"                \u0027mechanism_drivers\u0027: \u0027openvswitch\u0027,"},{"line_number":169,"context_line":"                \u0027extension_drivers\u0027: \u0027\u0027,"},{"line_number":170,"context_line":"            },"},{"line_number":171,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":172,"context_line":"                \u0027network_vlan_ranges\u0027: \u0027physnet1:1000:2999\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e67075a6","line":169,"updated":"2015-08-31 11:53:16.000000000","message":"The default value of \u0027extension_drivers\u0027 is an empty list, so we don\u0027t need to specify it if qos is not enabled.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af2fae786c0c1331e52a8895a5f2d3e12c339b30","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            \u0027ml2\u0027: {"},{"line_number":167,"context_line":"                \u0027tenant_network_types\u0027: tenant_network_types,"},{"line_number":168,"context_line":"                \u0027mechanism_drivers\u0027: \u0027openvswitch\u0027,"},{"line_number":169,"context_line":"                \u0027extension_drivers\u0027: \u0027\u0027,"},{"line_number":170,"context_line":"            },"},{"line_number":171,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":172,"context_line":"                \u0027network_vlan_ranges\u0027: \u0027physnet1:1000:2999\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_f4a49e4b","line":169,"in_reply_to":"da20952f_e67075a6","updated":"2015-08-31 12:52:19.000000000","message":"I don\u0027t think it hurts to have it defined. Also I suggest not to rely on defaults in tests. Being explicit is better than implicit.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                    \u0027OVSHybridIptablesFirewallDriver\u0027),"},{"line_number":203,"context_line":"            },"},{"line_number":204,"context_line":"            \u0027agent\u0027: {"},{"line_number":205,"context_line":"                \u0027extensions\u0027: \u0027\u0027,"},{"line_number":206,"context_line":"            },"},{"line_number":207,"context_line":"        })"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_86b17949","line":205,"updated":"2015-08-31 11:53:16.000000000","message":"Likewise.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"}],"neutron/tests/fullstack/resources/machine.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def _setUp(self):"},{"line_number":34,"context_line":"        super(FakeFullstackMachine, self)._setUp()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if not self.neutron_port:"},{"line_number":37,"context_line":"            self.neutron_port \u003d self.safe_client.create_port("},{"line_number":38,"context_line":"                network_id\u003dself.network_id,"},{"line_number":39,"context_line":"                tenant_id\u003dself.tenant_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_c1ab84d5","line":36,"updated":"2015-09-01 20:44:12.000000000","message":"Doesn\u0027t it make more sense for FakeFullstackMachine to accept an optional qos_policy_id so that the port creation happens exclusively here?","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def _setUp(self):"},{"line_number":34,"context_line":"        super(FakeFullstackMachine, self)._setUp()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if not self.neutron_port:"},{"line_number":37,"context_line":"            self.neutron_port \u003d self.safe_client.create_port("},{"line_number":38,"context_line":"                network_id\u003dself.network_id,"},{"line_number":39,"context_line":"                tenant_id\u003dself.tenant_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_cd3080eb","line":36,"in_reply_to":"da20952f_c1ab84d5","updated":"2015-09-02 09:50:27.000000000","message":"Maybe? This solution reflects the behavior how you call it from cli (you create port first and then provide it to nova boot). And also qos_policy is tied to port, not machine. I\u0027ll leave it to discuss, though I don\u0027t think it matters much.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ec9f102a2ab005e4fe7752060918e8a53a2438ce","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return decor"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class SkipperMetaclass(type):"},{"line_number":50,"context_line":"    def __new__(mcs, name, bases, dct):"},{"line_number":51,"context_line":"        for method_name, method in dct.items():"},{"line_number":52,"context_line":"            if method_name.startswith(\u0027test_\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_97e3f7d7","line":49,"updated":"2015-08-26 09:20:15.000000000","message":"It seems overkill to define a decorator and a metaclass when the check can be done in setUp:\n\n  from neutron.tests.common import base as common_base\n  \n  def setUp(self):\n    self.check_qos_support_in_client()\n    ...\n\n  @common_base.no_skip_on_missing_deps\n  def check_qos_support_in_client(self):\n     try:\n       ...\n     except:\n       if ...:\n         self.skipTest(...)\n\nno_skip_on_missing_deps ensures test(s) are not skipped in the gate","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2950186d939c8053397e15201be33763e7dac820","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return decor"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class SkipperMetaclass(type):"},{"line_number":50,"context_line":"    def __new__(mcs, name, bases, dct):"},{"line_number":51,"context_line":"        for method_name, method in dct.items():"},{"line_number":52,"context_line":"            if method_name.startswith(\u0027test_\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f4d90e57","line":49,"in_reply_to":"fa1b9901_97e3f7d7","updated":"2015-08-26 09:48:33.000000000","message":"Hehe :) That\u0027s a remnant from [1] where I thought environment is build per class and not per test_ method. It\u0027s gonna be removed after we merge QoS neutronclient part. This is a workaround for people that don\u0027t review patches that have -1 from Jenkins or give -1 because \"Jenkins failed\".\n\n[1] https://review.openstack.org/#/c/202492/5/neutron/tests/fullstack/test_qos.py","commit_id":"ad498f97432a3a8edab2119ff7cfa6b60b184933"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests.fullstack.resources import process"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"nc_exc \u003d process.nc_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LIMIT \u003d 500"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_86c65998","line":25,"updated":"2015-08-31 11:53:16.000000000","message":"I would rather you simply re-import nc_exc instead of do something like this... This seems less explicit and requires one to browse 2 files to find out where nc_exc is really placed.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af2fae786c0c1331e52a8895a5f2d3e12c339b30","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests.fullstack.resources import process"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"nc_exc \u003d process.nc_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LIMIT \u003d 500"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c16afbec","line":25,"in_reply_to":"da20952f_86c65998","updated":"2015-08-31 12:52:19.000000000","message":"Done","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"nc_exc \u003d process.nc_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LIMIT \u003d 500"},{"line_number":29,"context_line":"BURST \u003d 100"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_66ec65f3","line":28,"updated":"2015-08-31 11:53:16.000000000","message":"Since we\u0027re bound to have more rule types in the future:\n\ns/LIMIT/BANDWIDTH_LIMIT/g\ns/BURST/BANDWIDTH_BURST/g","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af2fae786c0c1331e52a8895a5f2d3e12c339b30","unresolved":false,"context_lines":[{"line_number":25,"context_line":"nc_exc \u003d process.nc_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LIMIT \u003d 500"},{"line_number":29,"context_line":"BURST \u003d 100"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_14583287","line":28,"in_reply_to":"da20952f_66ec65f3","updated":"2015-08-31 12:52:19.000000000","message":"Done","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9b8e9d848736a84e262db55f73eca630433e66eb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _prepare_vm_with_qos_policy(self, limit\u003dNone, burst\u003dNone):"},{"line_number":72,"context_line":"        qos_policy \u003d self._create_qos_policy()"},{"line_number":73,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":74,"context_line":"        if not (limit is None and burst is None):"},{"line_number":75,"context_line":"            rule \u003d self._create_bw_limit_rule("},{"line_number":76,"context_line":"                qos_policy_id, limit, burst)"},{"line_number":77,"context_line":"            # Make it consistent with GET reply"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c696913d","line":74,"updated":"2015-08-31 11:53:16.000000000","message":"Why should we allow not having both a limit and a burst? In other words, why should we allow creating a qos policy with no rule? This does not make sense to me in the fullstack-testing-scope.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"af2fae786c0c1331e52a8895a5f2d3e12c339b30","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _prepare_vm_with_qos_policy(self, limit\u003dNone, burst\u003dNone):"},{"line_number":72,"context_line":"        qos_policy \u003d self._create_qos_policy()"},{"line_number":73,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":74,"context_line":"        if not (limit is None and burst is None):"},{"line_number":75,"context_line":"            rule \u003d self._create_bw_limit_rule("},{"line_number":76,"context_line":"                qos_policy_id, limit, burst)"},{"line_number":77,"context_line":"            # Make it consistent with GET reply"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_74eace75","line":74,"in_reply_to":"da20952f_c696913d","updated":"2015-08-31 12:52:19.000000000","message":"I think I used that in previous version and forgot to remove.","commit_id":"05cb111dff90dc09c4a34d22779e6f0ff8180a78"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(TestQoSWithOvsAgent, self).setUp(env)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":"        self.network \u003d self.safe_client.create_network(self.tenant_id,"},{"line_number":39,"context_line":"                                                       \u0027network-test\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.subnet \u003d self.safe_client.create_subnet("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_960b942b","line":38,"updated":"2015-09-01 20:44:12.000000000","message":"Since you have exactly a single test now, I think you should move create_network/subnet to the test itself. I find it more readable. If/when you add the network QoS test and both tests require the same resources, then it makes sense to create them during setUp.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(TestQoSWithOvsAgent, self).setUp(env)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":"        self.network \u003d self.safe_client.create_network(self.tenant_id,"},{"line_number":39,"context_line":"                                                       \u0027network-test\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.subnet \u003d self.safe_client.create_subnet("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_63094431","line":38,"in_reply_to":"da20952f_960b942b","updated":"2015-09-02 09:50:27.000000000","message":"I find usual to prepare resources in setup part of the test and in test body do the actual test. But I don\u0027t care much, so Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.tenant_id, \u0027fs_policy\u0027, \u0027Fullstack testing policy\u0027,"},{"line_number":51,"context_line":"            shared\u003d\u0027False\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_bw_limit_rule(self, qos_policy_id, limit\u003dNone, burst\u003dNone):"},{"line_number":54,"context_line":"        return self.safe_client.create_bandwidth_limit_rule("},{"line_number":55,"context_line":"            self.tenant_id, qos_policy_id, limit, burst)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_3635e8f6","line":53,"updated":"2015-09-01 20:44:12.000000000","message":"Do we have to have this method? Seems like an unnecessary indirection that doesn\u0027t buy us anything. Also, why are limit and burst optional?","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.tenant_id, \u0027fs_policy\u0027, \u0027Fullstack testing policy\u0027,"},{"line_number":51,"context_line":"            shared\u003d\u0027False\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_bw_limit_rule(self, qos_policy_id, limit\u003dNone, burst\u003dNone):"},{"line_number":54,"context_line":"        return self.safe_client.create_bandwidth_limit_rule("},{"line_number":55,"context_line":"            self.tenant_id, qos_policy_id, limit, burst)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_6610724f","line":53,"in_reply_to":"da20952f_3635e8f6","updated":"2015-09-02 09:50:27.000000000","message":"Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self.safe_client.create_bandwidth_limit_rule("},{"line_number":55,"context_line":"            self.tenant_id, qos_policy_id, limit, burst)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _create_qos_policy_with_rule(self, limit\u003dNone, burst\u003dNone):"},{"line_number":58,"context_line":"        policy \u003d self._create_qos_policy()"},{"line_number":59,"context_line":"        self._create_bw_limit_rule(policy[\u0027id\u0027], BANDWIDTH_LIMIT,"},{"line_number":60,"context_line":"                                   BANDWIDTH_BURST)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_f670d0de","line":57,"updated":"2015-09-01 20:44:12.000000000","message":"This method is unused.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self.safe_client.create_bandwidth_limit_rule("},{"line_number":55,"context_line":"            self.tenant_id, qos_policy_id, limit, burst)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _create_qos_policy_with_rule(self, limit\u003dNone, burst\u003dNone):"},{"line_number":58,"context_line":"        policy \u003d self._create_qos_policy()"},{"line_number":59,"context_line":"        self._create_bw_limit_rule(policy[\u0027id\u0027], BANDWIDTH_LIMIT,"},{"line_number":60,"context_line":"                                   BANDWIDTH_BURST)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_866d86ce","line":57,"in_reply_to":"da20952f_f670d0de","updated":"2015-09-02 09:50:27.000000000","message":"Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return policy"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _wait_for_rule_applied(self, vm, limit\u003dNone, burst\u003dNone):"},{"line_number":65,"context_line":"        utils.wait_until_true("},{"line_number":66,"context_line":"            lambda: vm.bridge.get_egress_bw_limit_for_port("},{"line_number":67,"context_line":"                vm.port.name) \u003d\u003d (limit, burst))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_81e34c33","line":64,"updated":"2015-09-01 20:44:12.000000000","message":"I suggest having two methods, one named \u0027wait_for_rule_applied\u0027 that accepts a mandatory limit/burst methods, and one that is called \u0027wait_for_rule_removed\u0027 that doesn\u0027t accept limit/burst. They could share the underlying code, just a readability thing. The method as it is is a bit surprising in line 118.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return policy"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _wait_for_rule_applied(self, vm, limit\u003dNone, burst\u003dNone):"},{"line_number":65,"context_line":"        utils.wait_until_true("},{"line_number":66,"context_line":"            lambda: vm.bridge.get_egress_bw_limit_for_port("},{"line_number":67,"context_line":"                vm.port.name) \u003d\u003d (limit, burst))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_e62fa2f4","line":64,"in_reply_to":"da20952f_81e34c33","updated":"2015-09-02 09:50:27.000000000","message":"Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            qos_policy_id, limit, burst)"},{"line_number":74,"context_line":"        # Make it consistent with GET reply"},{"line_number":75,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":76,"context_line":"        rule[\u0027type\u0027] \u003d \u0027bandwidth_limit\u0027"},{"line_number":77,"context_line":"        rule[\u0027qos_policy_id\u0027] \u003d qos_policy_id"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        port \u003d self.safe_client.create_port("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_0172dcad","line":76,"updated":"2015-09-01 20:44:12.000000000","message":"Surely there\u0027s a const for \u0027bandwidth_limit\u0027 somewhere :)","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            qos_policy_id, limit, burst)"},{"line_number":74,"context_line":"        # Make it consistent with GET reply"},{"line_number":75,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":76,"context_line":"        rule[\u0027type\u0027] \u003d \u0027bandwidth_limit\u0027"},{"line_number":77,"context_line":"        rule[\u0027qos_policy_id\u0027] \u003d qos_policy_id"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        port \u003d self.safe_client.create_port("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_06be56ff","line":76,"in_reply_to":"da20952f_0172dcad","updated":"2015-09-02 09:50:27.000000000","message":"Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                                          BANDWIDTH_BURST)"},{"line_number":101,"context_line":"        self._wait_for_rule_applied(vm, BANDWIDTH_LIMIT, BANDWIDTH_BURST)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Get qos policy"},{"line_number":104,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":105,"context_line":"        obtained_qos_policy \u003d self.client.show_qos_policy("},{"line_number":106,"context_line":"            qos_policy_id)[\u0027policy\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_c192a49f","line":103,"updated":"2015-09-01 20:44:12.000000000","message":"I think you can remove this block and the next. This is an integration / scenario test, it should focus on the high level picture. Testing the API should be done in API tests.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                                          BANDWIDTH_BURST)"},{"line_number":101,"context_line":"        self._wait_for_rule_applied(vm, BANDWIDTH_LIMIT, BANDWIDTH_BURST)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Get qos policy"},{"line_number":104,"context_line":"        qos_policy_id \u003d qos_policy[\u0027id\u0027]"},{"line_number":105,"context_line":"        obtained_qos_policy \u003d self.client.show_qos_policy("},{"line_number":106,"context_line":"            qos_policy_id)[\u0027policy\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_46ce8e84","line":103,"in_reply_to":"da20952f_c192a49f","updated":"2015-09-02 09:50:27.000000000","message":"Done","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8ba3b163365db8af36fd6fc884d67e31156b8013","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":136,"context_line":"        self._wait_for_rule_applied(vm)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # Delete qos policy"},{"line_number":139,"context_line":"        self.client.delete_qos_policy(qos_policy_id)"},{"line_number":140,"context_line":"        with testtools.ExpectedException(nc_exc.NotFound):"},{"line_number":141,"context_line":"            self.client.show_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_81682c89","line":138,"updated":"2015-09-01 20:44:12.000000000","message":"Same comment as in line 103, this belongs in API tests, not here.","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dc73c05df06542d9ffda0d4be13f0166aea95e5e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            body\u003d{\u0027port\u0027: {\u0027qos_policy_id\u0027: None}})"},{"line_number":136,"context_line":"        self._wait_for_rule_applied(vm)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # Delete qos policy"},{"line_number":139,"context_line":"        self.client.delete_qos_policy(qos_policy_id)"},{"line_number":140,"context_line":"        with testtools.ExpectedException(nc_exc.NotFound):"},{"line_number":141,"context_line":"            self.client.show_qos_policy(qos_policy_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_e6a562b5","line":138,"in_reply_to":"da20952f_81682c89","updated":"2015-09-02 09:50:27.000000000","message":"Done. Funny that this exact block discovered two bugs that weren\u0027t caught by api tests: one in fullstack tests and one in qos db model :)","commit_id":"3e44dcf53d4445d6bd6f1f49fdb9a9aa1ff8f6bb"}]}
