)]}'
{"neutron/plugins/ml2/extensions/port_security.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0b76be887143f4a6fccba529360ce98a17216b90","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            response_data[psec.PORTSECURITY] \u003d ("},{"line_number":77,"context_line":"                                db_data[\u0027port_security\u0027][psec.PORTSECURITY])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _check_device_owner(self, port):"},{"line_number":80,"context_line":"        return (port.get(\u0027device_owner\u0027) and"},{"line_number":81,"context_line":"                port[\u0027device_owner\u0027].startswith(\u0027network:\u0027))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_ff9b9e70","line":79,"updated":"2015-08-24 10:36:34.000000000","message":"this deserves a docstring","commit_id":"c207a243347346712be21bc3d3345b094a2ffa1e"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"37b2d56d411e77b3a90fd13f93fe9204e671d437","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            response_data[psec.PORTSECURITY] \u003d ("},{"line_number":77,"context_line":"                                db_data[\u0027port_security\u0027][psec.PORTSECURITY])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _check_device_owner(self, port):"},{"line_number":80,"context_line":"        return (port.get(\u0027device_owner\u0027) and"},{"line_number":81,"context_line":"                port[\u0027device_owner\u0027].startswith(\u0027network:\u0027))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_24a6c253","line":79,"in_reply_to":"fa1b9901_5a9f1c5f","updated":"2015-08-25 01:24:34.000000000","message":"Done","commit_id":"c207a243347346712be21bc3d3345b094a2ffa1e"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"37b2d56d411e77b3a90fd13f93fe9204e671d437","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            response_data[psec.PORTSECURITY] \u003d ("},{"line_number":77,"context_line":"                                db_data[\u0027port_security\u0027][psec.PORTSECURITY])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _check_device_owner(self, port):"},{"line_number":80,"context_line":"        return (port.get(\u0027device_owner\u0027) and"},{"line_number":81,"context_line":"                port[\u0027device_owner\u0027].startswith(\u0027network:\u0027))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_04ab7e1e","line":79,"in_reply_to":"fa1b9901_ff9b9e70","updated":"2015-08-25 01:24:34.000000000","message":"Done","commit_id":"c207a243347346712be21bc3d3345b094a2ffa1e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e007d84575192f2ce8003cbc1751da0b21f0a40","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            response_data[psec.PORTSECURITY] \u003d ("},{"line_number":77,"context_line":"                                db_data[\u0027port_security\u0027][psec.PORTSECURITY])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _check_device_owner(self, port):"},{"line_number":80,"context_line":"        return (port.get(\u0027device_owner\u0027) and"},{"line_number":81,"context_line":"                port[\u0027device_owner\u0027].startswith(\u0027network:\u0027))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_5a9f1c5f","line":79,"in_reply_to":"fa1b9901_ff9b9e70","updated":"2015-08-24 20:05:41.000000000","message":"and it should probably be called _check_device_owner_network() to make it obvious what it\u0027s doing","commit_id":"c207a243347346712be21bc3d3345b094a2ffa1e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6497ab04dee4c735dcc4f119d35136c1b3e1ba31","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _extend_port_security_dict(self, response_data, db_data):"},{"line_number":68,"context_line":"        if db_data.get(\u0027port_security\u0027) is None:"},{"line_number":69,"context_line":"            if self._check_device_owner_network(db_data):"},{"line_number":70,"context_line":"                response_data[psec.PORTSECURITY] \u003d False"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                response_data[psec.PORTSECURITY] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_0a5962fe","line":69,"updated":"2015-08-27 18:25:52.000000000","message":"doesn\u0027t it make more sense to put this check in extend_port_dict\nas this method is used for networks as well?","commit_id":"eba766c81b23ddf07b9c4cd280a5400fc6e150f7"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"51ed16d9d3055900f9cc76c095d320835a1dc609","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _extend_port_security_dict(self, response_data, db_data):"},{"line_number":68,"context_line":"        if db_data.get(\u0027port_security\u0027) is None:"},{"line_number":69,"context_line":"            if self._check_device_owner_network(db_data):"},{"line_number":70,"context_line":"                response_data[psec.PORTSECURITY] \u003d False"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                response_data[psec.PORTSECURITY] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_3f17f9a4","line":69,"in_reply_to":"da20952f_0a5962fe","updated":"2015-09-14 10:38:12.000000000","message":"thanks Takashi, right","commit_id":"eba766c81b23ddf07b9c4cd280a5400fc6e150f7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"28bb474b3dd4faf124053a91e0e84605e94b5782","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self._extend_port_security_dict(result, db_data)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def extend_port_dict(self, session, db_data, result):"},{"line_number":65,"context_line":"        if (db_data.get(\u0027port_security\u0027) is None and"},{"line_number":66,"context_line":"                self._check_device_owner_network(db_data)):"},{"line_number":67,"context_line":"            result[psec.PORTSECURITY] \u003d False"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_bbc1cc30","line":65,"updated":"2015-09-14 15:45:39.000000000","message":"I wonder if it\u0027s better to raise bad input at the API level than default it to false if none.\n\nI don\u0027t think we allow one to pass admin_state_up \u003d None when creating a port or network. This should be a bool (or the field shouldn\u0027t be present imo).","commit_id":"a8fb4778ea9c45fcea9c61f332151fd798d1057b"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"52a40c81d00a5bd3780e111d372c3bd2f33f18ad","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self._extend_port_security_dict(result, db_data)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def extend_port_dict(self, session, db_data, result):"},{"line_number":65,"context_line":"        if (db_data.get(\u0027port_security\u0027) is None and"},{"line_number":66,"context_line":"                self._check_device_owner_network(db_data)):"},{"line_number":67,"context_line":"            result[psec.PORTSECURITY] \u003d False"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_2c506131","line":65,"in_reply_to":"ba15a1d1_bbc1cc30","updated":"2015-11-12 16:10:11.000000000","message":"tks Aaron, set it to False only when check_device_owner_network return True, that means the port is start with \u0027network:\u0027","commit_id":"a8fb4778ea9c45fcea9c61f332151fd798d1057b"}]}
