)]}'
{"quantum/plugins/nec/db/api.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            return ofc_item.ofc_id"},{"line_number":80,"context_line":"    else:"},{"line_number":81,"context_line":"        return None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def exists_ofc_item(session, resource, quantum_id, old_style\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2ByRM%3D","line":81,"updated":"2013-02-19 09:35:16.000000000","message":"nit: return","commit_id":"7a7675c748a0bd5b7e554f0ad61cb979fa4e9513"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            params \u003d dict(ofc_id\u003dofc_id)"},{"line_number":98,"context_line":"        return (session.query(model).filter_by(**params).one())"},{"line_number":99,"context_line":"    except sa.orm.exc.NoResultFound:"},{"line_number":100,"context_line":"        return None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def add_ofc_item(session, resource, quantum_id, ofc_id, old_style\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2ByRI%3D","line":100,"updated":"2013-02-19 09:35:16.000000000","message":"nit return","commit_id":"7a7675c748a0bd5b7e554f0ad61cb979fa4e9513"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def del_portinfo(session, id):"},{"line_number":196,"context_line":"    try:"},{"line_number":197,"context_line":"        portinfo \u003d session.query(nmodels.PortInfo).filter_by(id\u003did).one()"},{"line_number":198,"context_line":"        session.delete(portinfo)"},{"line_number":199,"context_line":"        session.flush()"},{"line_number":200,"context_line":"    except sa.orm.exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2ByRE%3D","line":197,"updated":"2013-02-19 09:35:16.000000000","message":"consider using  context.session.begin(subtransactions\u003dTrue): instead.","commit_id":"7a7675c748a0bd5b7e554f0ad61cb979fa4e9513"}],"quantum/plugins/nec/db/models.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3cd369f7e93557cbc3bb381f2708d6be9fb800dd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.db import model_base"},{"line_number":21,"context_line":"from quantum.db import models_v2"},{"line_number":22,"context_line":"from quantum.openstack.common import uuidutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class OFCId(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FAy0%3D","line":22,"updated":"2013-02-11 17:47:35.000000000","message":"unused import","commit_id":"3ceb974c6072b5acdd5c9020c83806c35692db88"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    quantum_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class OFCTenantMapping(model_base.BASEV2, QuantumId, OFCId):"},{"line_number":38,"context_line":"    \"\"\"Represents a Tenant on OpenFlow Network/Controller.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2d4%3D","line":37,"updated":"2013-02-17 01:50:24.000000000","message":"nit: why not delete OFCId and replace this with: models_v2.HasId","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"    quantum_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class OFCTenantMapping(model_base.BASEV2, QuantumId, OFCId):"},{"line_number":38,"context_line":"    \"\"\"Represents a Tenant on OpenFlow Network/Controller.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2Y4%3D","line":37,"in_reply_to":"AAAAM3%2F%2B2d4%3D","updated":"2013-02-17 05:14:47.000000000","message":"There are two reason: the one is because i need longer field than 36 chars. models_v2.HasId is 36 char long. This field actually stores REST path such as /tenants/\u003ctenant_id\u003e/networks/\u003cnetwork_id\u003e/ports/\u003cport_id\u003e. The other is this OFCId is not a primary key.\n\nThe field definition of QuantumId is same as models_v2.HasId but the field name is different. In old mapping table \u0027id\u0027 is used for OFC ID, thus using \u0027id\u0027 for different field is confusing and I would like to avoid it.\n\nThis patch changes the primary key from OFCID to Quantum ID since most of all DB accesses use Quantum ID as a key.\n\nThe original DB scheme design in our plugin is not good, so I am wondering how to make it better.... .","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    quantum_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class OFCTenant(model_base.BASEV2, HasOFCId, HasQuantumId):"},{"line_number":67,"context_line":"    \"\"\"Represents a Tenant on OpenFlow Network/Controller.\"\"\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2d0%3D","line":66,"updated":"2013-02-17 01:50:24.000000000","message":"ditto, same with classes below.","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":63,"context_line":"    quantum_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class OFCTenant(model_base.BASEV2, HasOFCId, HasQuantumId):"},{"line_number":67,"context_line":"    \"\"\"Represents a Tenant on OpenFlow Network/Controller.\"\"\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2Yg%3D","line":66,"in_reply_to":"AAAAM3%2F%2B2d0%3D","updated":"2013-02-17 05:14:47.000000000","message":"Thanks. HasOFCId is no need to change. I will revert it to modes_v2.HasId.","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"}],"quantum/plugins/nec/nec_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5ecc4bd7bafcedcd7e06276807575859b999268e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    binding_set \u003d \"extension:port_binding:set\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def __init__(self):"},{"line_number":77,"context_line":"        config.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":78,"context_line":"        ndb.initialize()"},{"line_number":79,"context_line":"        self.ofc \u003d ofc_manager.OFCManager()"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FBm4%3D","line":77,"updated":"2013-02-11 08:45:51.000000000","message":"why do we need this?","commit_id":"3ceb974c6072b5acdd5c9020c83806c35692db88"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"    binding_set \u003d \"extension:port_binding:set\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def __init__(self):"},{"line_number":77,"context_line":"        config.CONF.log_opt_values(LOG, std_logging.DEBUG)"},{"line_number":78,"context_line":"        ndb.initialize()"},{"line_number":79,"context_line":"        self.ofc \u003d ofc_manager.OFCManager()"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FBeo%3D","line":77,"in_reply_to":"AAAAM3%2F%2FBm4%3D","updated":"2013-02-11 10:52:48.000000000","message":"log_opt_values in quantum/services dumps only config options defined in quantum.conf and does not dump options defined in plugin config file. It is helpful to dump all options including plugin options  It is the reason to add it here.\n\nI understand that it is a general issue related to the topic of required option check (paul from Cisco working), but i have not allocate enough time to involve it so far.","commit_id":"3ceb974c6072b5acdd5c9020c83806c35692db88"}],"quantum/plugins/nec/ofc_manager.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.driver.delete_network(ofc_net_id)"},{"line_number":92,"context_line":"        self._del_ofc_item(context, \"ofc_network\", network_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # Port"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_ofc_port(self, context, port_id, port):"},{"line_number":97,"context_line":"        ofc_net_id \u003d self._get_ofc_id(context, \"ofc_network\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2dw%3D","line":94,"updated":"2013-02-17 01:50:24.000000000","message":"Needed?","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.driver.delete_network(ofc_net_id)"},{"line_number":92,"context_line":"        self._del_ofc_item(context, \"ofc_network\", network_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # Port"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def create_ofc_port(self, context, port_id, port):"},{"line_number":97,"context_line":"        ofc_net_id \u003d self._get_ofc_id(context, \"ofc_network\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2YY%3D","line":94,"in_reply_to":"AAAAM3%2F%2B2dw%3D","updated":"2013-02-17 05:14:47.000000000","message":"Removed all similar ones.","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.driver.delete_port(ofc_port_id)"},{"line_number":116,"context_line":"        self._del_ofc_item(context, \"ofc_port\", port_id)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # PacketFilter"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_ofc_packet_filter(self, context, filter_id, filter_dict):"},{"line_number":121,"context_line":"        ofc_net_id \u003d self._get_ofc_id(context, \"ofc_network\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2ds%3D","line":118,"updated":"2013-02-17 01:50:24.000000000","message":"ditto?","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"}],"quantum/tests/unit/nec/test_db.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.assertFalse(ndb.exists_ofc_item_lookup_both("},{"line_number":225,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        ret \u003d ndb.add_ofc_item(self.session, \u0027ofc_tenant\u0027, q, o, mode)"},{"line_number":228,"context_line":"        self._check_new_old_item(ndb.exists_ofc_item, q, exp_new, exp_old)"},{"line_number":229,"context_line":"        self.assertTrue(ndb.exists_ofc_item_lookup_both("},{"line_number":230,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B15g%3D","line":227,"updated":"2013-02-17 19:47:09.000000000","message":"ret seems to be unused","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.assertFalse(ndb.exists_ofc_item_lookup_both("},{"line_number":225,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        ret \u003d ndb.add_ofc_item(self.session, \u0027ofc_tenant\u0027, q, o, mode)"},{"line_number":228,"context_line":"        self._check_new_old_item(ndb.exists_ofc_item, q, exp_new, exp_old)"},{"line_number":229,"context_line":"        self.assertTrue(ndb.exists_ofc_item_lookup_both("},{"line_number":230,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1OI%3D","line":227,"in_reply_to":"AAAAM3%2F%2B15g%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done. \nI also fixed all similar ones.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.assertTrue(ndb.exists_ofc_item_lookup_both("},{"line_number":230,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        ret \u003d ndb.del_ofc_item(self.session, \u0027ofc_tenant\u0027, q, mode)"},{"line_number":233,"context_line":"        self._check_new_old_item(ndb.exists_ofc_item, q, False, False)"},{"line_number":234,"context_line":"        self.assertFalse(ndb.exists_ofc_item_lookup_both("},{"line_number":235,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B15c%3D","line":232,"updated":"2013-02-17 19:47:09.000000000","message":"ret seems to be ununsed","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.assertTrue(ndb.exists_ofc_item_lookup_both("},{"line_number":230,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        ret \u003d ndb.del_ofc_item(self.session, \u0027ofc_tenant\u0027, q, mode)"},{"line_number":233,"context_line":"        self._check_new_old_item(ndb.exists_ofc_item, q, False, False)"},{"line_number":234,"context_line":"        self.assertFalse(ndb.exists_ofc_item_lookup_both("},{"line_number":235,"context_line":"            self.session, \u0027ofc_tenant\u0027, q))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1OA%3D","line":232,"in_reply_to":"AAAAM3%2F%2B15c%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def test_delete_ofc_item_new(self):"},{"line_number":265,"context_line":"        self._check_delete_ofc_item(self.NEW)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_delete_ofc_item_old(self):"},{"line_number":268,"context_line":"        self._check_delete_ofc_item(self.OLD)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_delete_ofc_item_with_auto_detect_new(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B15k%3D","line":267,"updated":"2013-02-17 19:47:09.000000000","message":"this method has the same name as in L273","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def test_delete_ofc_item_new(self):"},{"line_number":265,"context_line":"        self._check_delete_ofc_item(self.NEW)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_delete_ofc_item_old(self):"},{"line_number":268,"context_line":"        self._check_delete_ofc_item(self.OLD)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_delete_ofc_item_with_auto_detect_new(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1OM%3D","line":267,"in_reply_to":"AAAAM3%2F%2B15k%3D","updated":"2013-02-18 08:40:27.000000000","message":"Thanks.\nI chaged the method name of L.273.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"}],"quantum/tests/unit/nec/test_pfc_driver.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    mac\u003d\"11:22:33:44:55:66\")"},{"line_number":67,"context_line":"        return tenant_id, network_id, portinfo"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def _generate_ofc_tenant_id(tenant_id):"},{"line_number":71,"context_line":"        fields \u003d tenant_id.split(\u0027-\u0027)"},{"line_number":72,"context_line":"        # Strip 1st character (UUID version) of 3rd field"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B16I%3D","line":69,"updated":"2013-02-17 19:47:09.000000000","message":"nit: does this have to be static?","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                    mac\u003d\"11:22:33:44:55:66\")"},{"line_number":67,"context_line":"        return tenant_id, network_id, portinfo"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def _generate_ofc_tenant_id(tenant_id):"},{"line_number":71,"context_line":"        fields \u003d tenant_id.split(\u0027-\u0027)"},{"line_number":72,"context_line":"        # Strip 1st character (UUID version) of 3rd field"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1Os%3D","line":69,"in_reply_to":"AAAAM3%2F%2B16I%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done. I changed similar ones  to normal methods.\n\nThe reason using static methods is just since it does not depend on any instance variables.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def testh_delete_port(self):"},{"line_number":163,"context_line":"        t, n, p \u003d self.get_ofc_item_random_params()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        net_path \u003d \"/tenants/%s/networks/%s\" % (_ofc(t), _ofc(n))"},{"line_number":166,"context_line":"        port_path \u003d \"/tenants/%s/networks/%s/ports/%s\" % (_ofc(t), _ofc(n),"},{"line_number":167,"context_line":"                                                          _ofc(p.id))"},{"line_number":168,"context_line":"        ofc.OFCClient.do_request(\"DELETE\", port_path)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B150%3D","line":165,"updated":"2013-02-17 19:47:09.000000000","message":"is the above required, doesn\u0027t seem to be used.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def testh_delete_port(self):"},{"line_number":163,"context_line":"        t, n, p \u003d self.get_ofc_item_random_params()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        net_path \u003d \"/tenants/%s/networks/%s\" % (_ofc(t), _ofc(n))"},{"line_number":166,"context_line":"        port_path \u003d \"/tenants/%s/networks/%s/ports/%s\" % (_ofc(t), _ofc(n),"},{"line_number":167,"context_line":"                                                          _ofc(p.id))"},{"line_number":168,"context_line":"        ofc.OFCClient.do_request(\"DELETE\", port_path)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1PQ%3D","line":165,"in_reply_to":"AAAAM3%2F%2B150%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":259,"context_line":"        if count \u003d\u003d 1:"},{"line_number":260,"context_line":"            return uuidutils.generate_uuid()"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            return [uuidutils.generate_uuid() for i in xrange(count)]"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_convert_tenant_id(self):"},{"line_number":265,"context_line":"        ofc_t_id \u003d self.generate_random_ids(1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B158%3D","line":262,"updated":"2013-02-17 19:47:09.000000000","message":"nit: consider using,\nreturn [uuidutils.generate_uuid() for _ in xrange(count)]\n\nor if count is large:\nreturn [uuidutils.generate_uuid() for _ in itertools.repeat(None, count)]","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":259,"context_line":"        if count \u003d\u003d 1:"},{"line_number":260,"context_line":"            return uuidutils.generate_uuid()"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            return [uuidutils.generate_uuid() for i in xrange(count)]"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_convert_tenant_id(self):"},{"line_number":265,"context_line":"        ofc_t_id \u003d self.generate_random_ids(1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1PE%3D","line":262,"in_reply_to":"AAAAM3%2F%2B158%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done\n\nxrange() is like a generator. I believe the cost of xrange() and itertools.repear() are same.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"}],"quantum/tests/unit/nec/test_trema_driver.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59d49bc12a992f36cdab9f2736d567e4182f472d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def tearDown(self):"},{"line_number":259,"context_line":"        self.mox.UnsetStubs()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    # Tenant"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_convert_tenant_id(self):"},{"line_number":264,"context_line":"        ofc_t_id \u003d generate_random_ids(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2dg%3D","line":261,"updated":"2013-02-17 01:50:24.000000000","message":"ditto with comments below. Fine with me to keep them.","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def tearDown(self):"},{"line_number":259,"context_line":"        self.mox.UnsetStubs()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    # Tenant"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_convert_tenant_id(self):"},{"line_number":264,"context_line":"        ofc_t_id \u003d generate_random_ids(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2YM%3D","line":261,"in_reply_to":"AAAAM3%2F%2B2dg%3D","updated":"2013-02-17 05:14:47.000000000","message":"Remove all similar ones since ome files have these comments and some do not.","commit_id":"f6a955e26ad4108e1dde36cc7c8b774074a7a01e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _test_convert_port_id_noconv(self, port_path_template):"},{"line_number":335,"context_line":"        t_id \u003d n_id \u003d \u0027dummy\u0027"},{"line_number":336,"context_line":"        ofc_t_id, ofc_n_id, ofc_p_id \u003d generate_random_ids(3)"},{"line_number":337,"context_line":"        ofc_p_id \u003d port_path_template % {\u0027network\u0027: ofc_n_id, \u0027port\u0027: ofc_p_id}"},{"line_number":338,"context_line":"        ret \u003d self.driver.convert_ofc_port_id(self.ctx, ofc_p_id, t_id, n_id)"},{"line_number":339,"context_line":"        self.assertEqual(ret, ofc_p_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B15w%3D","line":336,"updated":"2013-02-17 19:47:09.000000000","message":"ofc_t_id not used, maybe:\n\nofc_n_id, ofc_p_id \u003d generate_random_ids(2)","commit_id":"659a509679d61d534355dd790378dcc52849acb5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _test_convert_port_id_noconv(self, port_path_template):"},{"line_number":335,"context_line":"        t_id \u003d n_id \u003d \u0027dummy\u0027"},{"line_number":336,"context_line":"        ofc_t_id, ofc_n_id, ofc_p_id \u003d generate_random_ids(3)"},{"line_number":337,"context_line":"        ofc_p_id \u003d port_path_template % {\u0027network\u0027: ofc_n_id, \u0027port\u0027: ofc_p_id}"},{"line_number":338,"context_line":"        ret \u003d self.driver.convert_ofc_port_id(self.ctx, ofc_p_id, t_id, n_id)"},{"line_number":339,"context_line":"        self.assertEqual(ret, ofc_p_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2B1NU%3D","line":336,"in_reply_to":"AAAAM3%2F%2B15w%3D","updated":"2013-02-18 08:40:27.000000000","message":"Done. Fixed similar ones too.","commit_id":"659a509679d61d534355dd790378dcc52849acb5"}]}