)]}'
{"quantum/db/migration/alembic_migrations/versions/54c2c487e913_lbaas.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"89377011f3b4c0e387e9cbc0e9eced465239d4bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027*\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAzw%3D","line":33,"updated":"2013-02-11 17:35:19.000000000","message":"Remove \u0027*\u0027 so that this in an empty list.  This will make this migration a no-op until a a plugin implements the LBaaS extension and the identifier is added here.","commit_id":"001a0038da1adab746f0c54fddcda0341a33cc5c"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027*\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAyE%3D","line":33,"in_reply_to":"AAAAM3%2F%2FAzw%3D","updated":"2013-02-11 18:01:15.000000000","message":"Done","commit_id":"001a0038da1adab746f0c54fddcda0341a33cc5c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u002754c2c487e913\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u002749332180ca96\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FAsE%3D","line":28,"updated":"2013-02-11 18:34:42.000000000","message":"This is bad luck, but revision 38335592a0dc landed less than two hours ago in trunk. You can either use that as down revision for this patch or change the down revision of 38335592a0dc","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u002754c2c487e913\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u002749332180ca96\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2B%2Fdk%3D","line":28,"in_reply_to":"AAAAM3%2F%2FAsE%3D","updated":"2013-02-12 12:57:28.000000000","message":"Done","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d []"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from alembic import op"},{"line_number":35,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FArg%3D","line":32,"updated":"2013-02-11 18:34:42.000000000","message":"This is interesting, and I was surprised by it. Luckily I read the comments on the previous patch sets!","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d []"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from alembic import op"},{"line_number":35,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FAqo%3D","line":32,"in_reply_to":"AAAAM3%2F%2FArg%3D","updated":"2013-02-12 12:57:28.000000000","message":"I\u0027ve added a comment to avoid surprising someone else.","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    op.create_table("},{"line_number":46,"context_line":"        u\u0027vips\u0027,"},{"line_number":47,"context_line":"        sa.Column(u\u0027tenant_id\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"},{"line_number":48,"context_line":"        sa.Column(u\u0027id\u0027, sa.VARCHAR(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(u\u0027name\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"},{"line_number":50,"context_line":"        sa.Column(u\u0027description\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FAGQ%3D","line":47,"updated":"2013-02-11 22:45:31.000000000","message":"Change to sa.TYPE to actual type used in loadbalancers.py. This should be sa.String() ditto through out file.","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    op.create_table("},{"line_number":46,"context_line":"        u\u0027vips\u0027,"},{"line_number":47,"context_line":"        sa.Column(u\u0027tenant_id\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"},{"line_number":48,"context_line":"        sa.Column(u\u0027id\u0027, sa.VARCHAR(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(u\u0027name\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"},{"line_number":50,"context_line":"        sa.Column(u\u0027description\u0027, sa.VARCHAR(length\u003d255), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2B%2FMA%3D","line":47,"in_reply_to":"AAAAM3%2F%2FAGQ%3D","updated":"2013-02-12 12:57:28.000000000","message":"Done","commit_id":"4847b2408ef7480341fe0e03c692e5db8dd50a01"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"\u0027DB support for load balancing service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 54c2c487e913"},{"line_number":21,"context_line":"Revises: 49332180ca96"},{"line_number":22,"context_line":"Create Date: 2013-02-04 16:32:32.048731"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9GA%3D","line":21,"updated":"2013-02-13 11:22:16.000000000","message":"This is just a comment so it\u0027s not important, but it should be changed to 38335592a0dc","commit_id":"3e39e5eeda6427ebffb6aef580ab0f29294a174e"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"\u0027DB support for load balancing service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 54c2c487e913"},{"line_number":21,"context_line":"Revises: 49332180ca96"},{"line_number":22,"context_line":"Create Date: 2013-02-04 16:32:32.048731"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9B4%3D","line":21,"in_reply_to":"AAAAM3%2F%2B9GA%3D","updated":"2013-02-13 12:48:23.000000000","message":"Done","commit_id":"3e39e5eeda6427ebffb6aef580ab0f29294a174e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          \"HTTPS\","},{"line_number":116,"context_line":"                          name\u003d\"healthmontiors_type\"),"},{"line_number":117,"context_line":"                  nullable\u003dFalse),"},{"line_number":118,"context_line":"        sa.Column(u\u0027delay\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":119,"context_line":"        sa.Column(u\u0027timeout\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(u\u0027max_retries\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":121,"context_line":"        sa.Column(u\u0027http_method\u0027, sa.String(16), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B9Fk%3D","line":118,"updated":"2013-02-13 11:22:16.000000000","message":"nit: INTEGER is slightly different from Integer, as pointed out by Aaron in a previous revision.\n\nWe should use the basic types like Integer, Boolean and so on whenever possible.\n\nthis applies pretty much to all references to INTEGER and BOOLEAN in this file.","commit_id":"3e39e5eeda6427ebffb6aef580ab0f29294a174e"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          \"HTTPS\","},{"line_number":116,"context_line":"                          name\u003d\"healthmontiors_type\"),"},{"line_number":117,"context_line":"                  nullable\u003dFalse),"},{"line_number":118,"context_line":"        sa.Column(u\u0027delay\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":119,"context_line":"        sa.Column(u\u0027timeout\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(u\u0027max_retries\u0027, sa.INTEGER(), nullable\u003dFalse),"},{"line_number":121,"context_line":"        sa.Column(u\u0027http_method\u0027, sa.String(16), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2B8%2Bs%3D","line":118,"in_reply_to":"AAAAM3%2F%2B9Fk%3D","updated":"2013-02-13 12:48:23.000000000","message":"I replaced BOOLEANs and INTEGERs with basic types.","commit_id":"3e39e5eeda6427ebffb6aef580ab0f29294a174e"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"# if there\u0027s no plugin that implements the LBaaS extension."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"migration_for_plugins \u003d []"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from alembic import op"},{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B88E%3D","line":34,"updated":"2013-02-13 13:30:58.000000000","message":"imports should come first then global variables","commit_id":"72ceb492ee37e28b2adb0c9fcd589a56f9f15406"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# if there\u0027s no plugin that implements the LBaaS extension."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"migration_for_plugins \u003d []"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from alembic import op"},{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B87M%3D","line":34,"in_reply_to":"AAAAM3%2F%2B88E%3D","updated":"2013-02-13 13:37:37.000000000","message":"As far as I can see these variables: revision, down_revision and migration_for_plugins come before imports in every Alembic migration script.","commit_id":"72ceb492ee37e28b2adb0c9fcd589a56f9f15406"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from alembic import op"},{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from quantum.db import migration"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B88A%3D","line":37,"updated":"2013-02-13 13:30:58.000000000","message":"redundant line","commit_id":"72ceb492ee37e28b2adb0c9fcd589a56f9f15406"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"1d62f279fbe310069dde6197388318174c381521","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from alembic import op"},{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from quantum.db import migration"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B87A%3D","line":37,"in_reply_to":"AAAAM3%2F%2B88A%3D","updated":"2013-02-13 13:37:37.000000000","message":"Done","commit_id":"72ceb492ee37e28b2adb0c9fcd589a56f9f15406"}]}
