)]}'
{"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"607579cffbcdd5e48331accb65d22d1b721e885a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027ovs\u0027: {"},{"line_number":149,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":150,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"},{"line_number":151,"context_line":"                \u0027of_interface\u0027: getattr(host_desc, \u0027of_interface\u0027, None),"},{"line_number":152,"context_line":"                \u0027of_listen_port\u0027: getattr(host_desc, \u0027of_listen_port\u0027, None),"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":"            \u0027securitygroup\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_dc25c1ae","line":151,"updated":"2015-10-27 08:14:14.000000000","message":"iiuc the change done in HostDescription, of_interface and of_listen_port attributes always exist? So no need to use getattr?","commit_id":"a83ec87f8152651cddb7fc58fd796ca00b56b973"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c6fa328afe9e7682469940bfe5fade407c0f736c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027ovs\u0027: {"},{"line_number":149,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":150,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"},{"line_number":151,"context_line":"                \u0027of_interface\u0027: getattr(host_desc, \u0027of_interface\u0027, None),"},{"line_number":152,"context_line":"                \u0027of_listen_port\u0027: getattr(host_desc, \u0027of_listen_port\u0027, None),"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":"            \u0027securitygroup\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_3ba9d47b","line":151,"in_reply_to":"1a26ad4f_dc25c1ae","updated":"2015-11-11 07:45:28.000000000","message":"Seconded.","commit_id":"a83ec87f8152651cddb7fc58fd796ca00b56b973"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2fd7796afa7c165387592f83318ea09f4b43eac0","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027ovs\u0027: {"},{"line_number":149,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":150,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"},{"line_number":151,"context_line":"                \u0027of_interface\u0027: getattr(host_desc, \u0027of_interface\u0027, None),"},{"line_number":152,"context_line":"                \u0027of_listen_port\u0027: getattr(host_desc, \u0027of_listen_port\u0027, None),"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":"            \u0027securitygroup\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_59578526","line":151,"in_reply_to":"da85f559_3ba9d47b","updated":"2015-11-13 07:02:23.000000000","message":"Done","commit_id":"a83ec87f8152651cddb7fc58fd796ca00b56b973"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"45107ce6ac0e5a5bb227f84b7413dda4821b19bf","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":150,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"},{"line_number":151,"context_line":"                \u0027of_interface\u0027: host_desc[\u0027of_interface\u0027],"},{"line_number":152,"context_line":"                \u0027of_listen_port\u0027: host_desc[\u0027of_listen_port\u0027],"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":"            \u0027securitygroup\u0027: {"},{"line_number":155,"context_line":"                \u0027firewall_driver\u0027: (\u0027neutron.agent.linux.iptables_firewall.\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"da85f559_cbb90dcd","line":152,"updated":"2015-11-16 07:09:44.000000000","message":"host_desc is not a dict-like.","commit_id":"3ebd4b7106301f806b3dc33d6bf6df3dd9f0f8b8"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"03bb138215c537e9f2c22c339e86d90246820cf4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    Does the setup, as a whole, support tunneling? How about l2pop?"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    def __init__(self, of_interface\u003d\u0027ovs-ofctl\u0027):"},{"line_number":34,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HostDescription(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8da1aef9","line":34,"updated":"2015-08-26 06:28:12.000000000","message":"isn\u0027t HostDescription more appropriate for this setting?","commit_id":"4b9afcf9e64cfab866cab3bd9e7c7eacd4a8ec5f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fcff8d5219dd83289510fc90b104c358fab002a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    under?"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    def __init__(self, l3_agent\u003dFalse, of_interface\u003d\u0027ovs-ofctl\u0027,"},{"line_number":54,"context_line":"                 of_listen_port\u003d\u00276633\u0027):"},{"line_number":55,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":56,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":57,"context_line":"        self.of_listen_port \u003d of_listen_port"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_883dce2c","line":54,"updated":"2015-09-18 16:56:39.000000000","message":"Just question: Why is of_listen_port string?","commit_id":"6451237f73d51d4a6c8d4c8fbfcd158f74c5c47c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"e833b5b6d2707d08712dd121b19a4beb40d3f25c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    under?"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    def __init__(self, l3_agent\u003dFalse, of_interface\u003d\u0027ovs-ofctl\u0027,"},{"line_number":54,"context_line":"                 of_listen_port\u003d\u00276633\u0027):"},{"line_number":55,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":56,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":57,"context_line":"        self.of_listen_port \u003d of_listen_port"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_20947ee0","line":54,"in_reply_to":"ba15a1d1_883dce2c","updated":"2015-10-01 07:01:06.000000000","message":"Because it is used as a config variable.","commit_id":"6451237f73d51d4a6c8d4c8fbfcd158f74c5c47c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6ca086aa0ed6bc57d7e1ec4aafe5de8a33b13639","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 of_listen_port\u003d\u00276633\u0027):"},{"line_number":55,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":56,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":57,"context_line":"        self.of_listen_port \u003d of_listen_port"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class Host(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba8a016a_cdce5eb4","line":57,"updated":"2015-11-16 12:34:59.000000000","message":"of_listen_port is used only when of_interface is native, right? Instead of adding it to HostDescription, I think we can avoid adding a new member here and having to configure it in test_connectivity. We can simply set of_listen_port in OVSConfigFixture only if the interface is native, what do you think?","commit_id":"60de6b6ad3a34276e636e93c949e01ae96bd3d40"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"67b2e2349340a7be745057ad01c46da09c5d657a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 of_listen_port\u003d\u00276633\u0027):"},{"line_number":55,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":56,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":57,"context_line":"        self.of_listen_port \u003d of_listen_port"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class Host(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba8a016a_380778cb","line":57,"in_reply_to":"ba8a016a_cdce5eb4","updated":"2015-11-19 08:55:24.000000000","message":"As you advised, host_desc.of_listen_port can be removed. I\u0027ll update the patch.","commit_id":"60de6b6ad3a34276e636e93c949e01ae96bd3d40"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"e19c8f0a146109ce7f6bbf06eed05c6d13fd6425","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 of_listen_port\u003d\u00276633\u0027):"},{"line_number":55,"context_line":"        self.l3_agent \u003d l3_agent"},{"line_number":56,"context_line":"        self.of_interface \u003d of_interface"},{"line_number":57,"context_line":"        self.of_listen_port \u003d of_listen_port"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class Host(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_b025d209","line":57,"in_reply_to":"ba8a016a_cdce5eb4","updated":"2015-11-27 01:16:22.000000000","message":"Done","commit_id":"60de6b6ad3a34276e636e93c949e01ae96bd3d40"}],"neutron/tests/fullstack/test_connectivity.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2ec446460273ce1ccc365595b5ea4c6d4abf19f6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            environment.HostDescription("},{"line_number":47,"context_line":"                of_interface\u003dself.of_interface,"},{"line_number":48,"context_line":"                of_listen_port\u003dstr(net_helpers.get_free_namespace_port("},{"line_number":49,"context_line":"                    n_const.PROTO_NAME_TCP)))"},{"line_number":50,"context_line":"            for i in range(2)]"},{"line_number":51,"context_line":"        env \u003d environment.Environment("},{"line_number":52,"context_line":"            environment.EnvironmentDescription("}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_70f2869c","line":49,"updated":"2015-09-14 06:25:47.000000000","message":"better to have a retry logic somewhere","commit_id":"bb42b963cd795d9a8db0e019060bf3515466c80b"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"68a66ecb18c9277014b7ad060935ab0711d5ce2d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            environment.HostDescription("},{"line_number":47,"context_line":"                of_interface\u003dself.of_interface,"},{"line_number":48,"context_line":"                of_listen_port\u003dstr(net_helpers.get_free_namespace_port("},{"line_number":49,"context_line":"                    n_const.PROTO_NAME_TCP)))"},{"line_number":50,"context_line":"            for i in range(2)]"},{"line_number":51,"context_line":"        env \u003d environment.Environment("},{"line_number":52,"context_line":"            environment.EnvironmentDescription("}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_1823cc06","line":49,"in_reply_to":"ba15a1d1_70f2869c","updated":"2015-09-16 07:20:43.000000000","message":"get_free_namespace_port has 64000 ports to choose from.\nAs bind failures from race conditions happen rarely, retry logic is overkill, IMO.","commit_id":"bb42b963cd795d9a8db0e019060bf3515466c80b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fcff8d5219dd83289510fc90b104c358fab002a6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                of_interface\u003dself.of_interface,"},{"line_number":48,"context_line":"                of_listen_port\u003dstr(net_helpers.get_free_namespace_port("},{"line_number":49,"context_line":"                    n_const.PROTO_NAME_TCP)))"},{"line_number":50,"context_line":"            for i in range(2)]"},{"line_number":51,"context_line":"        env \u003d environment.Environment("},{"line_number":52,"context_line":"            environment.EnvironmentDescription("},{"line_number":53,"context_line":"                network_type\u003dself.network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_48a7b6a6","line":50,"updated":"2015-09-18 16:56:39.000000000","message":"Previous code have used \"_\" because it specifies the variable is useless. I don\u0027t think that we need to change it.","commit_id":"6451237f73d51d4a6c8d4c8fbfcd158f74c5c47c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"e833b5b6d2707d08712dd121b19a4beb40d3f25c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                of_interface\u003dself.of_interface,"},{"line_number":48,"context_line":"                of_listen_port\u003dstr(net_helpers.get_free_namespace_port("},{"line_number":49,"context_line":"                    n_const.PROTO_NAME_TCP)))"},{"line_number":50,"context_line":"            for i in range(2)]"},{"line_number":51,"context_line":"        env \u003d environment.Environment("},{"line_number":52,"context_line":"            environment.EnvironmentDescription("},{"line_number":53,"context_line":"                network_type\u003dself.network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a1a9d01_e0bc466e","line":50,"in_reply_to":"ba15a1d1_48a7b6a6","updated":"2015-10-01 07:01:06.000000000","message":"Done","commit_id":"6451237f73d51d4a6c8d4c8fbfcd158f74c5c47c"}]}
