)]}'
{"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"1ff365838f883140f7d2cf001ad855466d7e4b92","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"                port_create_func(context, port_data)"},{"line_number":1146,"context_line":"            except Exception as e:"},{"line_number":1147,"context_line":"                # failed to create port in NVP -  Delete port from quantum_db"},{"line_number":1148,"context_line":"                # FIXME (arosen) or the plugin_interface call failed in which"},{"line_number":1149,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":1150,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2F60%3D","side":"PARENT","line":1147,"updated":"2013-02-12 00:47:40.000000000","message":"this comment seems out of date if you remove the code below.  \n\nI\u0027m not clear on how the code below relates to the overall change.","commit_id":"bbef9ab0acb52b51b311adedbbb4d8b056550915"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"                port_create_func(context, port_data)"},{"line_number":1146,"context_line":"            except Exception as e:"},{"line_number":1147,"context_line":"                # failed to create port in NVP -  Delete port from quantum_db"},{"line_number":1148,"context_line":"                # FIXME (arosen) or the plugin_interface call failed in which"},{"line_number":1149,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":1150,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2BJw%3D","side":"PARENT","line":1147,"in_reply_to":"AAAAM3%2F%2B%2F5w%3D","updated":"2013-02-12 21:14:36.000000000","message":"got it.","commit_id":"bbef9ab0acb52b51b311adedbbb4d8b056550915"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"114778174c38052a63200318d444128551e902a3","unresolved":false,"context_lines":[{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"                port_create_func(context, port_data)"},{"line_number":1146,"context_line":"            except Exception as e:"},{"line_number":1147,"context_line":"                # failed to create port in NVP -  Delete port from quantum_db"},{"line_number":1148,"context_line":"                # FIXME (arosen) or the plugin_interface call failed in which"},{"line_number":1149,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":1150,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2F5w%3D","side":"PARENT","line":1147,"in_reply_to":"AAAAM3%2F%2B%2F60%3D","updated":"2013-02-12 00:58:38.000000000","message":"Right, I\u0027ll remove the comment. \n\nThis code is all wrapped in a transaction so if we fail to create the port in NVP we\u0027ll raise an error on line 1160 which will ensure the port is not persisted to the database. Therefore we can remove the call to delete it from the db if the call to nvp fails.\n\nThis code was removed in a previous commit but was accidentally reintroduced in the l3 patch.","commit_id":"bbef9ab0acb52b51b311adedbbb4d8b056550915"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1139,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":1140,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the \""},{"line_number":1141,"context_line":"                            \"interface in NVP for port %s\") % port_data[\u0027id\u0027]"},{"line_number":1142,"context_line":"                LOG.exception(err_msg)"},{"line_number":1143,"context_line":"                raise e"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"            LOG.debug(_(\"create_port completed on NVP for tenant \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2FbY%3D","line":1142,"updated":"2013-02-12 09:54:13.000000000","message":"You might want to port the Quantum port in ERROR or DOWN state here, as this port won\u0027t be functional.\n\nThe admin state can stay to whatever the use set it imho.\n\nAlso, the log message is not really pertinent to what\u0027s going on in here.","commit_id":"832d0fb515d169e9b14a1bfcace0f02bbe62712c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"114778174c38052a63200318d444128551e902a3","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"                # case we need to garbage collect the left over port in nvp."},{"line_number":1140,"context_line":"                err_msg \u003d _(\"An exception occured while plugging the \""},{"line_number":1141,"context_line":"                            \"interface in NVP for port %s\") % port_data[\u0027id\u0027]"},{"line_number":1142,"context_line":"                LOG.exception(err_msg)"},{"line_number":1143,"context_line":"                raise e"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"            LOG.debug(_(\"create_port completed on NVP for tenant \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BYg%3D","line":1142,"in_reply_to":"AAAAM3%2F%2B%2FbY%3D","updated":"2013-02-12 19:13:16.000000000","message":"Hrm, I\u0027m not exactly following you. There will not be a port in quantum at this point since we raise on line 1143. Therefore the port won\u0027t be saved to the database since this is within a transaction.  The admin_state code was stuff that could be removed since this is not needed since we are doing it in a transaction.  The log message was previously there but I agree it could be better. I\u0027ll update it to make more sense.","commit_id":"832d0fb515d169e9b14a1bfcace0f02bbe62712c"}]}
