)]}'
{"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d07459cf665abebe7958af4fa0aff2e42a3bbf73","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                                               table\u003dsnat_idx,"},{"line_number":262,"context_line":"                                               priority\u003dsnat_idx)"},{"line_number":263,"context_line":"                        break"},{"line_number":264,"context_line":"        except Exception:"},{"line_number":265,"context_line":"            if is_add:"},{"line_number":266,"context_line":"                exc \u003d _LE(\u0027DVR: error adding redirection logic\u0027)"},{"line_number":267,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_87dda572","line":264,"updated":"2015-08-26 20:58:39.000000000","message":"Site note: This looks like really bad practice IMO. The try block is huge, and this is catching any exception (Which could be one of many, in any one of the lines above) and masking the actual failure.","commit_id":"f74d64abd96d9b2baf3b883c78cd477769f19cae"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a36d65e3a283943c9fcc2c75c7b0099cc1a8a9f5","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                                               table\u003dsnat_idx,"},{"line_number":262,"context_line":"                                               priority\u003dsnat_idx)"},{"line_number":263,"context_line":"                        break"},{"line_number":264,"context_line":"        except Exception:"},{"line_number":265,"context_line":"            if is_add:"},{"line_number":266,"context_line":"                exc \u003d _LE(\u0027DVR: error adding redirection logic\u0027)"},{"line_number":267,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e70ee0e4","line":264,"in_reply_to":"da20952f_87dda572","updated":"2015-08-26 21:27:43.000000000","message":"Will try to address this in another patch.","commit_id":"f74d64abd96d9b2baf3b883c78cd477769f19cae"}],"neutron/agent/l3/dvr_router_base.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d07459cf665abebe7958af4fa0aff2e42a3bbf73","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            return match_port[0]"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found for the given router \u0027"},{"line_number":43,"context_line":"                          \u0027 internal port: %s\u0027), int_port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_a748e92e","line":43,"updated":"2015-08-26 20:58:39.000000000","message":"I think that logging the value of snat_ports would also help.","commit_id":"f74d64abd96d9b2baf3b883c78cd477769f19cae"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a36d65e3a283943c9fcc2c75c7b0099cc1a8a9f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            return match_port[0]"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found for the given router \u0027"},{"line_number":43,"context_line":"                          \u0027 internal port: %s\u0027), int_port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8769248e","line":43,"in_reply_to":"da20952f_a748e92e","updated":"2015-08-26 21:27:43.000000000","message":"will fix this.","commit_id":"f74d64abd96d9b2baf3b883c78cd477769f19cae"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e13b96d7c85495fae519d6a64f2a1af3bbc1f1a9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found in the list \u0027"},{"line_number":43,"context_line":"                          \u0027%(snat_list)s for the given router \u0027"},{"line_number":44,"context_line":"                          \u0027 internal port %(int_p)s: %s\u0027), {"},{"line_number":45,"context_line":"                              \u0027snat_list\u0027: snat_ports,"},{"line_number":46,"context_line":"                              \u0027int_p\u0027: int_port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_493796b0","line":44,"updated":"2015-08-27 02:38:13.000000000","message":"That last %s will throw an exception if this line is hit.","commit_id":"88da952ac84cf8a3564053079bf5d068039a914f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3e4727bb8bbfde24fed144420e2af95c52c0ad8d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found in the list \u0027"},{"line_number":43,"context_line":"                          \u0027%(snat_list)s for the given router \u0027"},{"line_number":44,"context_line":"                          \u0027 internal port %(int_p)s: %s\u0027), {"},{"line_number":45,"context_line":"                              \u0027snat_list\u0027: snat_ports,"},{"line_number":46,"context_line":"                              \u0027int_p\u0027: int_port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_44cbd81e","line":44,"in_reply_to":"da20952f_40ad09e8","updated":"2015-08-27 16:21:13.000000000","message":"Sorry I will clean it up.","commit_id":"88da952ac84cf8a3564053079bf5d068039a914f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c4867240a83f31da834c26582891c6347c35fdfc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found in the list \u0027"},{"line_number":43,"context_line":"                          \u0027%(snat_list)s for the given router \u0027"},{"line_number":44,"context_line":"                          \u0027 internal port %(int_p)s: %s\u0027), {"},{"line_number":45,"context_line":"                              \u0027snat_list\u0027: snat_ports,"},{"line_number":46,"context_line":"                              \u0027int_p\u0027: int_port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_40ad09e8","line":44,"in_reply_to":"da20952f_493796b0","updated":"2015-08-27 14:45:40.000000000","message":"Agreed","commit_id":"88da952ac84cf8a3564053079bf5d068039a914f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e9f216f601c38ed5c9b88df2fe0ebdc8038df39f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            LOG.error(_LE(\u0027DVR: SNAT port not found in the list \u0027"},{"line_number":43,"context_line":"                          \u0027%(snat_list)s for the given router \u0027"},{"line_number":44,"context_line":"                          \u0027 internal port %(int_p)s\u0027), {"},{"line_number":45,"context_line":"                              \u0027snat_list\u0027: snat_ports,"},{"line_number":46,"context_line":"                              \u0027int_p\u0027: int_port})"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_f8a2ba4a","line":44,"updated":"2015-08-28 01:35:20.000000000","message":"nit: remove starting space here","commit_id":"177f738ffe1ee6acb3ecd31f7e147d7608d2ad9e"}]}